Re: RFR: 8299254: Support dealing with standard assert macro [v2]

2023-01-05 Thread Kim Barrett
> Please review this change to provide and use mechanisms for dealing with uses > of the standard assert macro (from or ) in 3rd party code > that we use in HotSpot. > > We provide a pair of utility header files, to be included before and after a > header that may use (and so include) the

Re: RFR: 8299254: Support dealing with standard assert macro

2023-01-05 Thread Kim Barrett
On Tue, 3 Jan 2023 03:11:32 GMT, Xue-Lei Andrew Fan wrote: >> Please review this change to provide and use mechanisms for dealing with uses >> of the standard assert macro (from or ) in 3rd party code >> that we use in HotSpot. >> >> We provide a pair of utility header files, to be included

Re: RFR: 8299254: Support dealing with standard assert macro

2023-01-04 Thread Mikael Vidstedt
On Thu, 22 Dec 2022 23:05:03 GMT, Kim Barrett wrote: > Please review this change to provide and use mechanisms for dealing with uses > of the standard assert macro (from or ) in 3rd party code > that we use in HotSpot. > > We provide a pair of utility header files, to be included before and

Re: RFR: 8299254: Support dealing with standard assert macro

2023-01-04 Thread Kim Barrett
On Tue, 3 Jan 2023 06:36:38 GMT, David Holmes wrote: > Not pretty, but effective. > > Do we need some text added to the hotspot style guide to describe this usage? > Should we bracket all includes of system headers with these, or only those > known to cause a problem? Most of the uses are

Re: RFR: 8299254: Support dealing with standard assert macro

2023-01-02 Thread David Holmes
On Thu, 22 Dec 2022 23:05:03 GMT, Kim Barrett wrote: > Please review this change to provide and use mechanisms for dealing with uses > of the standard assert macro (from or ) in 3rd party code > that we use in HotSpot. > > We provide a pair of utility header files, to be included before and

Re: RFR: 8299254: Support dealing with standard assert macro

2023-01-02 Thread Xue-Lei Andrew Fan
On Thu, 22 Dec 2022 23:05:03 GMT, Kim Barrett wrote: > Please review this change to provide and use mechanisms for dealing with uses > of the standard assert macro (from or ) in 3rd party code > that we use in HotSpot. > > We provide a pair of utility header files, to be included before and

Re: RFR: 8299254: Support dealing with standard assert macro

2022-12-23 Thread Erik Joelsson
On Thu, 22 Dec 2022 23:05:03 GMT, Kim Barrett wrote: > Please review this change to provide and use mechanisms for dealing with uses > of the standard assert macro (from or ) in 3rd party code > that we use in HotSpot. > > We provide a pair of utility header files, to be included before and

RFR: 8299254: Support dealing with standard assert macro

2022-12-22 Thread Kim Barrett
Please review this change to provide and use mechanisms for dealing with uses of the standard assert macro (from or ) in 3rd party code that we use in HotSpot. We provide a pair of utility header files, to be included before and after a header that may use (and so include) the standard assert