On Tue, 7 Mar 2023 01:36:56 GMT, David Holmes wrote:
>> Kim Barrett has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> make Debugging::_enabled a nesting counter
>
> Okay other than the one outstanding minor syntax query, I have nothing
>
> Also 8302799: Refactor Debugging variable usage for noreturn crash reporting
Kim Barrett has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains four addition
The message from this sender included one or more files
which could not be scanned for virus detection; do not
open these files unless you are certain of the sender's intent.
--
On Tue, 7 Mar 2023 13:08:22 GMT, Coleen Phillimore
On Sat, 4 Mar 2023 11:23:58 GMT, Kim Barrett wrote:
>> Also 8302799: Refactor Debugging variable usage for noreturn crash reporting
>
> Kim Barrett has updated the pull request incrementally with one additional
> commit since the last revision:
>
> make Debugging::_enabled a nesting counter
On Tue, 7 Mar 2023 05:58:57 GMT, Kim Barrett wrote:
>> No I'm comparing the syntax used elsewhere:
>>
>> DebuggingContext debugging{};
>>
>> with that used here:
>>
>> DebuggingContext debugging;
>>
>> why the braces in most cases but not here?
>
> "syntax used elsewhere" are declarations of
The message from this sender included one or more files
which could not be scanned for virus detection; do not
open these files unless you are certain of the sender's intent.
--
On Tue, 7 Mar 2023 01:25:47 GMT, David Holmes wrote
On Sat, 4 Mar 2023 11:23:58 GMT, Kim Barrett wrote:
>> Also 8302799: Refactor Debugging variable usage for noreturn crash reporting
>
> Kim Barrett has updated the pull request incrementally with one additional
> commit since the last revision:
>
> make Debugging::_enabled a nesting counter
On Sat, 4 Mar 2023 11:16:10 GMT, Kim Barrett wrote:
>> src/hotspot/share/utilities/debug.cpp line 85:
>>
>>> 83: if (is_enabled()) {
>>> 84: fatal("Multiple Debugging contexts");
>>> 85: }
>>
>> This seems too restrictive as you could hit different DebuggingContexts in
>> different thr
On Sun, 5 Mar 2023 15:36:30 GMT, Julian Waters wrote:
>> I don't understand the question? These are member variable declarations.
>
> I believe David is asking about why these particular member names were changed
No I'm comparing the syntax used elsewhere:
DebuggingContext debugging{};
with t
On Sat, 4 Mar 2023 11:16:03 GMT, Kim Barrett wrote:
>> make/hotspot/lib/CompileJvm.gmk line 103:
>>
>>> 101: DISABLED_WARNINGS_xlc := tautological-compare shift-negative-value
>>> 102:
>>> 103: DISABLED_WARNINGS_microsoft := 4624 4244 4291 4146 4127 4722
>>
>> It is annoying that we don't docu
> Also 8302799: Refactor Debugging variable usage for noreturn crash reporting
Kim Barrett has updated the pull request incrementally with one additional
commit since the last revision:
make Debugging::_enabled a nesting counter
-
Changes:
- all: https://git.openjdk.org/jdk/pul
On Fri, 3 Mar 2023 04:35:35 GMT, David Holmes wrote:
> I don't use these particular debugging mechanism, neither Debugger nor
> BREAKPOINT, but it seems potentially problematic to me that the removed
> BREAKPOINTs happened after the error was reported, and IIUC the new mechanism
> will activat
On Fri, 3 Mar 2023 04:04:25 GMT, Kim Barrett wrote:
> Also 8302799: Refactor Debugging variable usage for noreturn crash reporting
A few initial comments while I try to digest this.
I don't use these particular debugging mechanism, neither Debugger nor
BREAKPOINT, but it seems potentially prob
On Fri, 3 Mar 2023 04:04:25 GMT, Kim Barrett wrote:
> Also 8302799: Refactor Debugging variable usage for noreturn crash reporting
make/hotspot/lib/CompileJvm.gmk line 103:
> 101: DISABLED_WARNINGS_xlc := tautological-compare shift-negative-value
> 102:
> 103: DISABLED_WARNINGS_microsoft := 46
Also 8302799: Refactor Debugging variable usage for noreturn crash reporting
-
Commit messages:
- new implementation of Debugging
- noreturn attributes
Changes: https://git.openjdk.org/jdk/pull/12845/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=12845&range=00
Issue: ht
15 matches
Mail list logo
