On Fri, 17 Feb 2023 10:37:30 GMT, Mark Sheppard wrote:
>> Rich DiCroce has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Limit line length to 80-ish characters
>
> I don't think the NetworkInterface.h file should be dropped.
> It is prefer
On Thu, 16 Feb 2023 17:56:58 GMT, Rich DiCroce wrote:
>> src/java.base/windows/native/libnet/NetworkInterface.c line 72:
>>
>>> 70: return FALSE;
>>> 71: }
>>> 72: if (GetAnycastIpAddressTable(addrFamily, anyAddrs) != NO_ERROR) {
>>
>> Were the anycast addresses covered by the e
On Thu, 16 Feb 2023 21:48:19 GMT, Daniel Fuchs wrote:
>> Note that the new code doesn't attempt to sort anything. If it happens to be
>> sorted by LUID, that's the underlying API at work. The MS docs don't say
>> anything about ordering, so this is probably an implementation detail and I
>> wo
On Thu, 16 Feb 2023 16:49:09 GMT, Rich DiCroce wrote:
>> Improves performance and correctness, as discussed on the net-dev mailing
>> list.
>
> Rich DiCroce has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Limit line length to 80-ish charac
On Thu, 16 Feb 2023 20:22:17 GMT, Rich DiCroce wrote:
>> ok so here goes: your patch changes the order in which the interfaces are
>> returned; the original code returned them in order of increasing indexes,
>> the new code appears to sort interfaces by LUID.
>> The failing test uses the first
On Thu, 16 Feb 2023 19:38:58 GMT, Daniel Jeliński wrote:
>> I ran the tests for NetworkInterface specifically, though that reminds me
>> that I need to open a bug report about fixpath mangling things incorrectly.
>> I'll give the full jdk_net suite a run and see what happens.
>
> ok so here goe
On Thu, 16 Feb 2023 18:59:06 GMT, Rich DiCroce wrote:
>> Ha! Apparently I have a machine where the implementation of
>> `supportsMulticast` implementation makes a difference. On my machine the
>> test `jdk/java/net/SocketOption/OptionsTest.java` is failing with:
>>
>> java.net.SocketException:
On Thu, 16 Feb 2023 18:54:05 GMT, Daniel Jeliński wrote:
>> You and me both. As I wrote in the giant comment, I did a lot of
>> experimenting. In the end, what I determined was that if the IGMPLevel
>> (IPv4) or MldLevel (IPv6) is set to 0 (None), then attempting to join a
>> multicast group t
On Thu, 16 Feb 2023 18:05:05 GMT, Rich DiCroce wrote:
>> src/java.base/windows/native/libnet/NetworkInterface.c line 523:
>>
>>> 521: * Signature: (Ljava/lang/String;I)Z
>>> 522: */
>>> 523: JNIEXPORT jboolean JNICALL
>>> Java_java_net_NetworkInterface_supportsMulticast0(JNIEnv *env, jclass c
On Thu, 16 Feb 2023 18:01:43 GMT, Mark Sheppard wrote:
>> Rich DiCroce has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Limit line length to 80-ish characters
>
> what versions of Windows has this been tested on ? Just wondering if the
>
On Thu, 16 Feb 2023 17:08:25 GMT, Daniel Jeliński wrote:
>> Rich DiCroce has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Limit line length to 80-ish characters
>
> src/java.base/windows/native/libnet/NetworkInterface.c line 523:
>
>> 52
On Thu, 16 Feb 2023 16:49:09 GMT, Rich DiCroce wrote:
>> Improves performance and correctness, as discussed on the net-dev mailing
>> list.
>
> Rich DiCroce has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Limit line length to 80-ish charac
On Thu, 16 Feb 2023 16:08:55 GMT, Daniel Jeliński wrote:
>> Rich DiCroce has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Limit line length to 80-ish characters
>
> src/java.base/windows/native/libnet/NetworkInterface.c line 72:
>
>> 70:
On Thu, 16 Feb 2023 16:49:09 GMT, Rich DiCroce wrote:
>> Improves performance and correctness, as discussed on the net-dev mailing
>> list.
>
> Rich DiCroce has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Limit line length to 80-ish charac
> Improves performance and correctness, as discussed on the net-dev mailing
> list.
Rich DiCroce has updated the pull request incrementally with one additional
commit since the last revision:
Limit line length to 80-ish characters
-
Changes:
- all: https://git.openjdk.org/jdk/
15 matches
Mail list logo
