On Fri, 21 Apr 2023 08:40:49 GMT, Christoph Langer wrote:
> This is the plain fix for the currently observed error in GHA.
>
> Will handle the optional install of the MSVC toolchain in a separate item.
Thanks for the reviews. Now the GHAs are merely done with only some jtregs for
Windows and
On Fri, 21 Apr 2023 08:40:49 GMT, Christoph Langer wrote:
> This is the plain fix for the currently observed error in GHA.
>
> Will handle the optional install of the MSVC toolchain in a separate item.
LGTM.
-
Marked as reviewed by mdoerr (Reviewer).
PR Review:
On Fri, 21 Apr 2023 08:51:31 GMT, Aleksey Shipilev wrote:
> Okay, as long as GHAs are green after this change.
It already got past the installation step. Will wait until GHA is done and
integrate if there are no new related issues.
-
PR Comment:
On Fri, 21 Apr 2023 08:40:49 GMT, Christoph Langer wrote:
> This is the plain fix for the currently observed error in GHA.
>
> Will handle the optional install of the MSVC toolchain in a separate item.
Okay, as long as GHAs are green after this change.
-
Marked as reviewed by
This is the plain fix for the currently observed error in GHA.
Will handle the optional install of the MSVC toolchain in a separate item.
-
Commit messages:
- JDK-8306543
Changes: https://git.openjdk.org/jdk/pull/13576/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=13576=00
On Fri, 21 Apr 2023 07:51:00 GMT, Aleksey Shipilev wrote:
> Okay, this sounds good to me. The synopsis is now incorrect, though: we do
> not fail because the component was already installed, we fail because of the
> backslashes. Suggestion: "GHA: MSVC installation should be skipped when it is
On Thu, 20 Apr 2023 11:56:37 GMT, Aleksey Shipilev wrote:
> Currrent GHA fails on MSVC installation. Looks like the required versions are
> already installed in the runner image, and this is why the command fails. Our
> configure scripts look for the specific minor version, and the builds
On Fri, 21 Apr 2023 06:56:43 GMT, Christoph Langer wrote:
> I did some more investigation for this issue.
>
> The real root cause for the failing install seems to be that the option
> --installPath nowadays needs a correct Windows path with backslashes. This
> probably must have been
I did some more investigation for this issue.
The real root cause for the failing install seems to be that the option
--installPath nowadays needs a correct Windows path with backslashes. This
probably must have been different beforehand. So I corrected that.
However, as we figured that
On Thu, 20 Apr 2023 11:56:37 GMT, Aleksey Shipilev wrote:
> Currrent GHA fails on MSVC installation. Looks like the required versions are
> already installed in the runner image, and this is why the command fails. Our
> configure scripts look for the specific minor version, and the builds
On Thu, 20 Apr 2023 11:56:37 GMT, Aleksey Shipilev wrote:
> Currrent GHA fails on MSVC installation. Looks like the required versions are
> already installed in the runner image, and this is why the command fails. Our
> configure scripts look for the specific minor version, and the builds
On Thu, 20 Apr 2023 11:56:37 GMT, Aleksey Shipilev wrote:
> Currrent GHA fails on MSVC installation. Looks like the required versions are
> already installed in the runner image, and this is why the command fails. Our
> configure scripts look for the specific minor version, and the builds
On Thu, 20 Apr 2023 16:23:26 GMT, Christoph Langer wrote:
>> Currrent GHA fails on MSVC installation. Looks like the required versions
>> are already installed in the runner image, and this is why the command
>> fails. Our configure scripts look for the specific minor version, and the
>>
On Thu, 20 Apr 2023 11:56:37 GMT, Aleksey Shipilev wrote:
> Currrent GHA fails on MSVC installation. Looks like the required versions are
> already installed in the runner image, and this is why the command fails. Our
> configure scripts look for the specific minor version, and the builds
On Thu, 20 Apr 2023 16:23:26 GMT, Christoph Langer wrote:
> Looks good. Too bad that the Windows installer is not showing any sensible
> output. We will want to backport this to 11u and 17u soon, too.
Yes, that would be my plan. GHA rolls out the new image right now, and so lots
of backports
On Thu, 20 Apr 2023 11:56:37 GMT, Aleksey Shipilev wrote:
> Currrent GHA fails on MSVC installation. Looks like the required versions are
> already installed in the runner image, and this is why the command fails. Our
> configure scripts look for the specific minor version, and the builds
On Thu, 20 Apr 2023 11:56:37 GMT, Aleksey Shipilev wrote:
> Currrent GHA fails on MSVC installation. Looks like the required versions are
> already installed in the runner image, and this is why the command fails. Our
> configure scripts look for the specific minor version, and the builds
Currrent GHA fails on MSVC installation. Looks like the required versions are
already installed in the runner image, and this is why the command fails. Our
configure scripts look for the specific minor version, and the builds still
pass if I drop the VC installation block completely. This tells
18 matches
Mail list logo
