On Thu, 11 May 2023 12:12:56 GMT, Stefan Karlsson wrote:
>> Hi all,
>>
>> Please review the implementation of Generational ZGC, which can be turned on
>> by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational
>> ZGC is a major rewrite of the non-generational ZGC version
> Hi all,
>
> Please review the implementation of Generational ZGC, which can be turned on
> by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational
> ZGC is a major rewrite of the non-generational ZGC version that exists in the
> openjdk/jdk repository. It splits the heap
> Hi all,
>
> Please review the implementation of Generational ZGC, which can be turned on
> by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational
> ZGC is a major rewrite of the non-generational ZGC version that exists in the
> openjdk/jdk repository. It splits the heap
On Tue, 9 May 2023 12:55:42 GMT, Stefan Karlsson wrote:
>> Hi all,
>>
>> Please review the implementation of Generational ZGC, which can be turned on
>> by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational
>> ZGC is a major rewrite of the non-generational ZGC version
On Tue, 9 May 2023 12:55:42 GMT, Stefan Karlsson wrote:
>> Hi all,
>>
>> Please review the implementation of Generational ZGC, which can be turned on
>> by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational
>> ZGC is a major rewrite of the non-generational ZGC version
On Tue, 9 May 2023 12:55:42 GMT, Stefan Karlsson wrote:
>> Hi all,
>>
>> Please review the implementation of Generational ZGC, which can be turned on
>> by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational
>> ZGC is a major rewrite of the non-generational ZGC version
> Hi all,
>
> Please review the implementation of Generational ZGC, which can be turned on
> by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational
> ZGC is a major rewrite of the non-generational ZGC version that exists in the
> openjdk/jdk repository. It splits the heap
> Hi all,
>
> Please review the implementation of Generational ZGC, which can be turned on
> by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational
> ZGC is a major rewrite of the non-generational ZGC version that exists in the
> openjdk/jdk repository. It splits the heap
On Tue, 9 May 2023 07:27:46 GMT, Kim Barrett wrote:
>> Stefan Karlsson has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Workaround failed reservation in ZForwardingTest
>
> src/hotspot/share/code/relocInfo.hpp line 1105:
>
>> 1103:
On Tue, 9 May 2023 06:06:11 GMT, Stefan Karlsson wrote:
>> Hi all,
>>
>> Please review the implementation of Generational ZGC, which can be turned on
>> by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational
>> ZGC is a major rewrite of the non-generational ZGC version
On Tue, 9 May 2023 00:50:56 GMT, Fei Yang wrote:
>> That's unfortunate. Could you try this patch, which probes the address range
>> to see if it can reserve the memory somewhere else within
>> `[ZAddressHeapBase, ZAddressHeapBase+ZAddressOffsetMax)`:
>>
> Hi all,
>
> Please review the implementation of Generational ZGC, which can be turned on
> by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational
> ZGC is a major rewrite of the non-generational ZGC version that exists in the
> openjdk/jdk repository. It splits the heap
On Mon, 8 May 2023 12:47:51 GMT, Stefan Karlsson wrote:
> That's unfortunate. Could you try this patch, which probes the address range
> to see if it can reserve the memory somewhere else within `[ZAddressHeapBase,
> ZAddressHeapBase+ZAddressOffsetMax)`:
>
> Hi all,
>
> Please review the implementation of Generational ZGC, which can be turned on
> by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational
> ZGC is a major rewrite of the non-generational ZGC version that exists in the
> openjdk/jdk repository. It splits the heap
> Hi all,
>
> Please review the implementation of Generational ZGC, which can be turned on
> by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational
> ZGC is a major rewrite of the non-generational ZGC version that exists in the
> openjdk/jdk repository. It splits the heap
On Mon, 8 May 2023 10:19:44 GMT, Fei Yang wrote:
>> Could you provide the values for `reserved`, `ZAddressHeapBase`, and
>> `ZAddressOffsetMax`, when this test is failing. I'd like to know if we can
>> make a workaround for you, or if we have to turn off the test for riscv.
>
> @stefank : I
On Mon, 8 May 2023 09:01:07 GMT, Erik Österlund wrote:
>> I think we use the flag `UseStoreImmI16` for these kinds of situations.
>
> We did indeed run into the predecoder issue when we used testw for normal
> store barriers, so I changed to testl. However, this cmpw is only taken when
> we
On Fri, 5 May 2023 06:50:55 GMT, Stefan Karlsson wrote:
>> We emailed to erik to discuss this issue two months ago, and maybe he missed
>> it.
>> ZForwardingTest does not guarantee a successful invoke of os::commit_memory
>> for ZAddressHeapBase, and we saw some conflicts between
On Sat, 6 May 2023 05:22:48 GMT, Quan Anh Mai wrote:
>> Stefan Karlsson has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 917 commits:
>>
>> - ZGC: Generational
>>
>>Co-authored-by: Stefan Karlsson
>>Co-authored-by:
On Sat, 6 May 2023 08:14:24 GMT, Quan Anh Mai wrote:
>> src/hotspot/cpu/x86/gc/z/zBarrierSetAssembler_x86.cpp line 310:
>>
>>> 308: // A not relocatable object could have spurious raw null pointers
>>> in its fields after
>>> 309: // getting promoted to the old generation.
>>> 310:
On Sat, 6 May 2023 04:08:42 GMT, Quan Anh Mai wrote:
>> Stefan Karlsson has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 917 commits:
>>
>> - ZGC: Generational
>>
>>Co-authored-by: Stefan Karlsson
>>Co-authored-by:
On Fri, 5 May 2023 07:43:17 GMT, Stefan Karlsson wrote:
>> Hi all,
>>
>> Please review the implementation of Generational ZGC, which can be turned on
>> by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational
>> ZGC is a major rewrite of the non-generational ZGC version
> Hi all,
>
> Please review the implementation of Generational ZGC, which can be turned on
> by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational
> ZGC is a major rewrite of the non-generational ZGC version that exists in the
> openjdk/jdk repository. It splits the heap
On Fri, 5 May 2023 06:28:59 GMT, Yadong Wang wrote:
>> Thanks for reporting. It would be interesting to see what address you get
>> and compare it to the range [ZAddressHeapBase,
>> ZAddressHeapBase+ZAddressOffsetMax).
>
> We emailed to erik to discuss this issue two months ago, and maybe he
On Fri, 5 May 2023 05:17:44 GMT, Stefan Karlsson wrote:
>> test/hotspot/gtest/gc/z/test_zForwarding.cpp line 68:
>>
>>> 66:
>>> 67: bool reserved =
>>> os::attempt_reserve_memory_at((char*)ZAddressHeapBase, ZGranuleSize, false
>>> /* executable */);
>>> 68: ASSERT_TRUE(reserved);
>>
On Fri, 5 May 2023 01:54:48 GMT, Fei Yang wrote:
>> Stefan Karlsson has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> undefine glibc major/minor macros
>
> test/hotspot/gtest/gc/z/test_zForwarding.cpp line 68:
>
>> 66:
>> 67: bool
On Thu, 4 May 2023 20:21:12 GMT, Andrey Turbanov wrote:
>> Stefan Karlsson has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> undefine glibc major/minor macros
>
> test/hotspot/jtreg/runtime/stringtable/StringTableCleaningTest.java line
> Hi all,
>
> Please review the implementation of Generational ZGC, which can be turned on
> by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational
> ZGC is a major rewrite of the non-generational ZGC version that exists in the
> openjdk/jdk repository. It splits the heap
On Thu, 4 May 2023 11:44:14 GMT, Stefan Karlsson wrote:
>> Hi all,
>>
>> Please review the implementation of Generational ZGC, which can be turned on
>> by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational
>> ZGC is a major rewrite of the non-generational ZGC version
On Thu, 4 May 2023 11:44:14 GMT, Stefan Karlsson wrote:
>> Hi all,
>>
>> Please review the implementation of Generational ZGC, which can be turned on
>> by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational
>> ZGC is a major rewrite of the non-generational ZGC version
> Hi all,
>
> Please review the implementation of Generational ZGC, which can be turned on
> by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational
> ZGC is a major rewrite of the non-generational ZGC version that exists in the
> openjdk/jdk repository. It splits the heap
On Thu, 4 May 2023 09:50:23 GMT, Axel Boldt-Christmas
wrote:
>>> I'm getting build warnings on all linux platforms with gcc-11.3.0:
>>>
>>> ```
>>> src/hotspot/share/gc/z/zDriver.cpp:84:13: error: In the GNU C Library,
>>> "minor" is defined
>>> by . For historical compatibility, it is
>>>
On Thu, 4 May 2023 09:50:23 GMT, Axel Boldt-Christmas
wrote:
>>> I'm getting build warnings on all linux platforms with gcc-11.3.0:
>>>
>>> ```
>>> src/hotspot/share/gc/z/zDriver.cpp:84:13: error: In the GNU C Library,
>>> "minor" is defined
>>> by . For historical compatibility, it is
>>>
On Wed, 3 May 2023 21:58:25 GMT, Stefan Karlsson wrote:
> I'm getting build warnings on all linux platforms with gcc-11.3.0:
>
> ```
> src/hotspot/share/gc/z/zDriver.cpp:84:13: error: In the GNU C Library,
> "minor" is defined
> by . For historical compatibility, it is
> currently defined by
On Wed, 3 May 2023 21:08:39 GMT, Stefan Karlsson wrote:
>> test/jdk/ProblemList-generational-zgc.txt line 27:
>>
>>> 25: #
>>> 26: # List of quarantined tests for testing with Generational ZGC.
>>> 27: #
>>
>> Are the tests in `test/jdk/sun/tools/jhsdb/` not failing?
>
> It seems like these
On Wed, 3 May 2023 21:32:54 GMT, Martin Doerr wrote:
> I'm getting build warnings on all linux platforms with gcc-11.3.0:
>
> ```
> src/hotspot/share/gc/z/zDriver.cpp:84:13: error: In the GNU C Library,
> "minor" is defined
> by . For historical compatibility, it is
> currently defined by
> Hi all,
>
> Please review the implementation of Generational ZGC, which can be turned on
> by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational
> ZGC is a major rewrite of the non-generational ZGC version that exists in the
> openjdk/jdk repository. It splits the heap
> Hi all,
>
> Please review the implementation of Generational ZGC, which can be turned on
> by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational
> ZGC is a major rewrite of the non-generational ZGC version that exists in the
> openjdk/jdk repository. It splits the heap
On Wed, 3 May 2023 20:00:42 GMT, Chris Plummer wrote:
>> Yes, the test was finicky with the heap size. Given that the leak it tries
>> to provoke would be provoked by other GCs as well, we didn't think it was
>> that important to run this particular test with Generational ZGC. If you
>> still
On Wed, 3 May 2023 19:36:55 GMT, Stefan Karlsson wrote:
>> Hi all,
>>
>> Please review the implementation of Generational ZGC, which can be turned on
>> by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational
>> ZGC is a major rewrite of the non-generational ZGC version
On Wed, 3 May 2023 18:54:24 GMT, Chris Plummer wrote:
>> Stefan Karlsson has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix PPC build after 8305668
>
> test/jdk/ProblemList-generational-zgc.txt line 27:
>
>> 25: #
>> 26: # List of
On Wed, 3 May 2023 19:42:01 GMT, Stefan Karlsson wrote:
>> test/jdk/com/sun/jdi/ThreadMemoryLeakTest.java line 30:
>>
>>> 28: *
>>> 29: * @comment Don't allow -Xcomp or -Xint as they impact memory useage
>>> and number of iterations
>>> 30: * @requires (vm.compMode == "Xmixed") & !(vm.gc.Z
On Wed, 3 May 2023 18:57:22 GMT, Chris Plummer wrote:
>> Stefan Karlsson has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix PPC build after 8305668
>
> test/jdk/com/sun/jdi/ThreadMemoryLeakTest.java line 30:
>
>> 28: *
>> 29: *
> Hi all,
>
> Please review the implementation of Generational ZGC, which can be turned on
> by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational
> ZGC is a major rewrite of the non-generational ZGC version that exists in the
> openjdk/jdk repository. It splits the heap
On Wed, 3 May 2023 18:52:19 GMT, Chris Plummer wrote:
>> Stefan Karlsson has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix PPC build after 8305668
>
> test/hotspot/jtreg/ProblemList-generational-zgc.txt line 32:
>
>> 30: # Quiet all
On Wed, 3 May 2023 10:55:49 GMT, Stefan Karlsson wrote:
>> Hi all,
>>
>> Please review the implementation of Generational ZGC, which can be turned on
>> by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational
>> ZGC is a major rewrite of the non-generational ZGC version
On Wed, 3 May 2023 10:55:49 GMT, Stefan Karlsson wrote:
>> Hi all,
>>
>> Please review the implementation of Generational ZGC, which can be turned on
>> by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational
>> ZGC is a major rewrite of the non-generational ZGC version
On Wed, 3 May 2023 12:29:15 GMT, Martin Doerr wrote:
> Thanks for fixing PPC64! With this, the VM compiles and the
> `test/hotspot/jtreg/gc` tests are passing on linux PPC64le.
>
> I'm glad to see this PR for JDK 21 LTS. It's a big step forward for ZGC.
> Congratulations!
Thanks for porting
On Wed, 3 May 2023 10:55:49 GMT, Stefan Karlsson wrote:
>> Hi all,
>>
>> Please review the implementation of Generational ZGC, which can be turned on
>> by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational
>> ZGC is a major rewrite of the non-generational ZGC version
> Hi all,
>
> Please review the implementation of Generational ZGC, which can be turned on
> by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational
> ZGC is a major rewrite of the non-generational ZGC version that exists in the
> openjdk/jdk repository. It splits the heap
On Wed, 3 May 2023 09:04:50 GMT, Stefan Karlsson wrote:
> Hi all,
>
> Please review the implementation of Generational ZGC, which can be turned on
> by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational
> ZGC is a major rewrite of the non-generational ZGC version that
Hi all,
Please review the implementation of Generational ZGC, which can be turned on by
adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational ZGC is
a major rewrite of the non-generational ZGC version that exists in the
openjdk/jdk repository. It splits the heap into two
52 matches
Mail list logo
