Re: RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on the Microsoft Visual C compiler [v2]

2024-04-05 Thread Magnus Ihse Bursie
On Fri, 5 Apr 2024 05:48:40 GMT, Julian Waters wrote: >> Magnus Ihse Bursie has updated the pull request with a new target base due >> to a merge or a rebase. The incremental webrev excludes the unrelated >> changes brought in by the merge/rebase. The pull request contains two >> additional co

Re: RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on the Microsoft Visual C compiler [v2]

2024-04-04 Thread Julian Waters
On Thu, 4 Apr 2024 22:47:18 GMT, Magnus Ihse Bursie wrote: >> This is a retake on https://github.com/openjdk/jdk/pull/15096. >> >> I tried to fix the remaining issues in that PR, but could not push them. In >> the end, it seemed easier to create a new branch in my own personal fork. >> >> The

Re: RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on the Microsoft Visual C compiler [v2]

2024-04-04 Thread Magnus Ihse Bursie
> This is a retake on https://github.com/openjdk/jdk/pull/15096. > > I tried to fix the remaining issues in that PR, but could not push them. In > the end, it seemed easier to create a new branch in my own personal fork. > > The majority of the work in this PR has been done by @TheShermanTanker.

Re: RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on the Microsoft Visual C compiler [v2]

2024-03-22 Thread Magnus Ihse Bursie
On Sun, 3 Dec 2023 15:37:47 GMT, Julian Waters wrote: >> src/java.desktop/windows/native/libawt/windows/awt_Frame.cpp line 1641: >> >>> 1639: } >>> 1640: } >>> 1641: >> >> A possible improvement later (and for a future RFE) would be to use RAII for >> deletion and then get rid of