Re: RFR: JDK-8298445: Add LeakSanitizer support in HotSpot [v6]

2023-02-08 Thread David Holmes
On Wed, 8 Feb 2023 13:37:04 GMT, Magnus Ihse Bursie wrote: >> Justin King has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revert changes to JDK >> >> Signed-off-by: Justin King > > I apologize, the fault lies entirely with me. Just

Re: RFR: JDK-8298445: Add LeakSanitizer support in HotSpot [v6]

2023-02-08 Thread Thomas Stuefe
On Wed, 8 Feb 2023 15:39:17 GMT, Justin King wrote: > > I read through your explanation, and through the [design > > docs](https://github.com/google/sanitizers/wiki/AddressSanitizerLeakSanitizerDesignDocument), > > but my question remains unanswered. See below. > > > > Metaspace objects hold po

Re: RFR: JDK-8298445: Add LeakSanitizer support in HotSpot [v6]

2023-02-08 Thread Justin King
On Wed, 8 Feb 2023 06:58:52 GMT, Thomas Stuefe wrote: > I read through your explanation, and through the [design > docs](https://github.com/google/sanitizers/wiki/AddressSanitizerLeakSanitizerDesignDocument), > but my question remains unanswered. See below. > > > > Metaspace objects hold point

Re: RFR: JDK-8298445: Add LeakSanitizer support in HotSpot [v6]

2023-02-08 Thread Justin King
On Wed, 8 Feb 2023 06:45:28 GMT, Thomas Stuefe wrote: > The informal rule is that ongoing discussions should be closed and that > nobody strongly objects to a change. Two reviewers are easy to come by. The > point of this rule is that you have a reasonable chance to block changes you > strongl

Re: RFR: JDK-8298445: Add LeakSanitizer support in HotSpot [v6]

2023-02-08 Thread Magnus Ihse Bursie
On Tue, 7 Feb 2023 15:40:34 GMT, Justin King wrote: >> Adds initial LSan (LeakSanitizer) support to Hotspot. This setup has been >> used to identify multiple leaks so far. It can run most of the test suite >> except those that also fail with ASan, which is being looked at separately. >> It is

Re: RFR: JDK-8298445: Add LeakSanitizer support in HotSpot [v6]

2023-02-07 Thread Thomas Stuefe
On Tue, 7 Feb 2023 15:40:34 GMT, Justin King wrote: >> Adds initial LSan (LeakSanitizer) support to Hotspot. This setup has been >> used to identify multiple leaks so far. It can run most of the test suite >> except those that also fail with ASan, which is being looked at separately. >> It is

Re: RFR: JDK-8298445: Add LeakSanitizer support in HotSpot [v6]

2023-02-07 Thread Thomas Stuefe
On Wed, 8 Feb 2023 03:11:32 GMT, Justin King wrote: > > The bot can only check the required number of Reviewers (strictly 1 per > > OpenJDK rules but changeable as here via `/reviewers` command) but it > > doesn't know about the informal rules such as having reviewers from each > > affected ar

Re: RFR: JDK-8298445: Add LeakSanitizer support in HotSpot [v6]

2023-02-07 Thread Justin King
On Wed, 8 Feb 2023 02:53:51 GMT, David Holmes wrote: > The bot can only check the required number of Reviewers (strictly 1 per > OpenJDK rules but changeable as here via `/reviewers` command) but it doesn't > know about the informal rules such as having reviewers from each affected > area (the

Re: RFR: JDK-8298445: Add LeakSanitizer support in HotSpot [v6]

2023-02-07 Thread David Holmes
On Tue, 7 Feb 2023 15:40:34 GMT, Justin King wrote: >> Adds initial LSan (LeakSanitizer) support to Hotspot. This setup has been >> used to identify multiple leaks so far. It can run most of the test suite >> except those that also fail with ASan, which is being looked at separately. >> It is

Re: RFR: JDK-8298445: Add LeakSanitizer support in HotSpot [v6]

2023-02-07 Thread Justin King
On Tue, 7 Feb 2023 15:40:34 GMT, Justin King wrote: >> Adds initial LSan (LeakSanitizer) support to Hotspot. This setup has been >> used to identify multiple leaks so far. It can run most of the test suite >> except those that also fail with ASan, which is being looked at separately. >> It is

Re: RFR: JDK-8298445: Add LeakSanitizer support in HotSpot [v4]

2023-02-07 Thread David Holmes
On Tue, 7 Feb 2023 15:34:50 GMT, Justin King wrote: >> Justin King has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains ten commits: >> >> - Merge branch 'master' into lsan >> - Fix grammatical error >> >>Signed-off-by: Justi

Re: RFR: JDK-8298445: Add LeakSanitizer support in HotSpot [v4]

2023-02-07 Thread Justin King
On Tue, 7 Feb 2023 15:32:11 GMT, Justin King wrote: >> Adds initial LSan (LeakSanitizer) support to Hotspot. This setup has been >> used to identify multiple leaks so far. It can run most of the test suite >> except those that also fail with ASan, which is being looked at separately. >> It is

Re: RFR: JDK-8298445: Add LeakSanitizer support in HotSpot [v6]

2023-02-07 Thread Justin King
> Adds initial LSan (LeakSanitizer) support to Hotspot. This setup has been > used to identify multiple leaks so far. It can run most of the test suite > except those that also fail with ASan, which is being looked at separately. > It is especially useful when combined with ASan, as LSan can use

Re: RFR: JDK-8298445: Add LeakSanitizer support in HotSpot [v5]

2023-02-07 Thread Justin King
> Adds initial LSan (LeakSanitizer) support to Hotspot. This setup has been > used to identify multiple leaks so far. It can run most of the test suite > except those that also fail with ASan, which is being looked at separately. > It is especially useful when combined with ASan, as LSan can use

Re: RFR: JDK-8298445: Add LeakSanitizer support in HotSpot [v3]

2023-02-07 Thread Justin King
On Tue, 7 Feb 2023 13:49:55 GMT, Magnus Ihse Bursie wrote: >> Justin King has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Fix grammatical error >> >>Signed-off-by: Justin King >> - Update based on review and remove restrictio

Re: RFR: JDK-8298445: Add LeakSanitizer support in HotSpot [v4]

2023-02-07 Thread Justin King
> Adds initial LSan (LeakSanitizer) support to Hotspot. This setup has been > used to identify multiple leaks so far. It can run most of the test suite > except those that also fail with ASan, which is being looked at separately. > It is especially useful when combined with ASan, as LSan can use

Re: RFR: JDK-8298445: Add LeakSanitizer support in HotSpot [v3]

2023-02-07 Thread Magnus Ihse Bursie
On Thu, 2 Feb 2023 15:52:01 GMT, Justin King wrote: >> Adds initial LSan (LeakSanitizer) support to Hotspot. This setup has been >> used to identify multiple leaks so far. It can run most of the test suite >> except those that also fail with ASan, which is being looked at separately. >> It is

Re: RFR: JDK-8298445: Add LeakSanitizer support in HotSpot [v2]

2023-02-03 Thread Justin King
On Fri, 3 Feb 2023 06:16:06 GMT, Thomas Stuefe wrote: > Thanks for the explanation. Do I understand correctly: You register address > ranges with LSAN, and at certain points (program exit?) the memory is > examined for pointers that point still to unreleased memory? Does LSAN > instrument mall

Re: RFR: JDK-8298445: Add LeakSanitizer support in HotSpot [v3]

2023-02-03 Thread David Holmes
On Fri, 3 Feb 2023 04:26:40 GMT, David Holmes wrote: >> Justin King has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Fix grammatical error >> >>Signed-off-by: Justin King >> - Update based on review and remove restriction on c

Re: RFR: JDK-8298445: Add LeakSanitizer support in HotSpot [v2]

2023-02-02 Thread Thomas Stuefe
On Thu, 2 Feb 2023 06:34:56 GMT, Thomas Stuefe wrote: >> Justin King has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Support CDS >> >> Signed-off-by: Justin King > > Thinking this through some more: > > Why would UseCompressedClas

Re: RFR: JDK-8298445: Add LeakSanitizer support in HotSpot [v3]

2023-02-02 Thread David Holmes
On Thu, 2 Feb 2023 15:52:01 GMT, Justin King wrote: >> Adds initial LSan (LeakSanitizer) support to Hotspot. This setup has been >> used to identify multiple leaks so far. It can run most of the test suite >> except those that also fail with ASan, which is being looked at separately. >> It is

Re: RFR: JDK-8298445: Add LeakSanitizer support in HotSpot [v2]

2023-02-02 Thread Justin King
On Thu, 2 Feb 2023 06:34:56 GMT, Thomas Stuefe wrote: >> Justin King has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Support CDS >> >> Signed-off-by: Justin King > > Thinking this through some more: > > Why would UseCompressedClas

Re: RFR: JDK-8298445: Add LeakSanitizer support in HotSpot [v2]

2023-02-02 Thread Justin King
On Thu, 2 Feb 2023 06:06:04 GMT, David Holmes wrote: >> src/hotspot/share/runtime/arguments.cpp line 3979: >> >>> 3977: // LSAN relies on pointers to be natively aligned. Using compressed >>> class pointers breaks this >>> 3978: // expectation and results in nondeterministic leak reports. >

Re: RFR: JDK-8298445: Add LeakSanitizer support in HotSpot [v2]

2023-02-02 Thread Justin King
On Thu, 2 Feb 2023 05:34:57 GMT, David Holmes wrote: >> Justin King has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Support CDS >> >> Signed-off-by: Justin King > > make/data/lsan/lsan_default_options.c line 49: > >> 47: // extrem

Re: RFR: JDK-8298445: Add LeakSanitizer support in HotSpot [v3]

2023-02-02 Thread Justin King
> Adds initial LSan (LeakSanitizer) support to Hotspot. This setup has been > used to identify multiple leaks so far. It can run most of the test suite > except those that rely on testing compressed oops or compressed class > pointers. It is especially useful when combined with ASan, as LSan can

Re: RFR: JDK-8298445: Add LeakSanitizer support in HotSpot [v2]

2023-02-01 Thread Thomas Stuefe
On Wed, 1 Feb 2023 15:26:27 GMT, Justin King wrote: >> Adds initial LSan (LeakSanitizer) support to Hotspot. This setup has been >> used to identify multiple leaks so far. It can run most of the test suite >> except those that rely on testing compressed oops or compressed class >> pointers. It

Re: RFR: JDK-8298445: Add LeakSanitizer support in HotSpot [v2]

2023-02-01 Thread Thomas Stuefe
On Wed, 1 Feb 2023 15:26:27 GMT, Justin King wrote: >> Adds initial LSan (LeakSanitizer) support to Hotspot. This setup has been >> used to identify multiple leaks so far. It can run most of the test suite >> except those that rely on testing compressed oops or compressed class >> pointers. It

Re: RFR: JDK-8298445: Add LeakSanitizer support in HotSpot [v2]

2023-02-01 Thread David Holmes
On Thu, 2 Feb 2023 06:01:04 GMT, David Holmes wrote: >> Justin King has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Support CDS >> >> Signed-off-by: Justin King > > src/hotspot/share/runtime/arguments.cpp line 3979: > >> 3977: /

Re: RFR: JDK-8298445: Add LeakSanitizer support in HotSpot [v2]

2023-02-01 Thread David Holmes
On Wed, 1 Feb 2023 15:26:27 GMT, Justin King wrote: >> Adds initial LSan (LeakSanitizer) support to Hotspot. This setup has been >> used to identify multiple leaks so far. It can run most of the test suite >> except those that rely on testing compressed oops or compressed class >> pointers. It

Re: RFR: JDK-8298445: Add LeakSanitizer support in HotSpot

2023-02-01 Thread Justin King
On Thu, 26 Jan 2023 17:33:28 GMT, Justin King wrote: > Adds initial LSan (LeakSanitizer) support to Hotspot. This setup has been > used to identify multiple leaks so far. It can run most of the test suite > except those that rely on testing compressed oops or compressed class > pointers. It is

Re: RFR: JDK-8298445: Add LeakSanitizer support in HotSpot [v2]

2023-02-01 Thread Justin King
> Adds initial LSan (LeakSanitizer) support to Hotspot. This setup has been > used to identify multiple leaks so far. It can run most of the test suite > except those that rely on testing compressed oops or compressed class > pointers. It is especially useful when combined with ASan, as LSan can

Re: RFR: JDK-8298445: Add LeakSanitizer support in HotSpot

2023-01-31 Thread Erik Joelsson
On Thu, 26 Jan 2023 17:33:28 GMT, Justin King wrote: > Adds initial LSan (LeakSanitizer) support to Hotspot. This setup has been > used to identify multiple leaks so far. It can run most of the test suite > except those that rely on testing compressed oops, compressed class pointers, > or CDS.

RFR: JDK-8298445: Add LeakSanitizer support in HotSpot

2023-01-31 Thread Justin King
Adds initial LSan (LeakSanitizer) support to Hotspot. This setup has been used to identify multiple leaks so far. It can run most of the test suite except those that rely on testing compressed oops, compressed class pointers, or CDS. It is especially useful when combined with ASan, as LSan can u