e and simply re-implement the relevant defines from
linux/i2c-dev.h in miscutils/i2c-tools.c.
Tested by building on systems with and without i2c-tools headers.
Signed-off-by: Bartosz Golaszewski
---
miscutils/i2c_tools.c | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff
Two patches for i2c-tools: one minor - just removing an unnecessary
include - and one fixing a significant bug: building busybox' i2c-tools
with upstream i2c-tools headers installed.
Bartosz Golaszewski (2):
i2c-tools: remove unneeded include
i2c-tools: fix build with upstream i2c-
uding linux/i2c.h and defining the i2c access routines
only if a well known symbol provided by linux uapi is not defined in
linux/i2c-dev.h.
Tested by building on systems with and without i2c-tools headers.
Signed-off-by: Bartosz Golaszewski
---
miscutils/i2c_tools.c | 16 +++-
1
We no longer use common_bufsiz1 in i2c-tools.
Don't include common_bufsiz.h.
Signed-off-by: Bartosz Golaszewski
---
miscutils/i2c_tools.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/miscutils/i2c_tools.c b/miscutils/i2c_tools.c
index 30f606e8e..03a09d519 100644
--- a/misc
The first function allows to create parser_t objects for files
that are already open.
The second frees the parser_t instance without closing the file.
With these functions it is now possible to feed config files to
applets via stdin.
Signed-off-by: Bartosz Golaszewski
---
include/libbb.h
this branch.
Resending just in case you changed your mind.
Best regards,
Bartosz Golaszewski
Bartosz Golaszewski (3):
libbb: add str_isblank() macro
libbb: add config_from_fp() and config_free() functions
readahead: applet extension
docs/readahead.txt | 39 +++
include/li
- 38 +38
tree_cmp - 11 +11
--
(add/remove: 4/0 grow/shrink: 3/0 up/down: 3126/0) Total: 3126 bytes
Signed-off-by: Bartosz Golaszewski
Add a wrapper around skip_whitespace() which evaluates to true if given
string contains only whitespace characters.
Signed-off-by: Bartosz Golaszewski
---
include/libbb.h | 2 ++
libbb/skip_whitespace.c | 17 +
2 files changed, 19 insertions(+)
diff --git a/include
ate the integer array required for block reads on the stack.
Tested with i2c block read on a Lenovo Thinkpad laptop.
Signed-off-by: Bartosz Golaszewski
---
miscutils/i2c_tools.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/miscutils/i2c_tools.c b/miscutils/i2c_tools.c
index 5
Implement a fully featured (sans selinux part) nsenter applet.
Signed-off-by: Bartosz Golaszewski
---
util-linux/namespace.h | 20 +++
util-linux/nsenter.c | 351 +
util-linux/unshare.c | 12 +-
3 files changed, 374 insertions(+), 9
Add a new xfunction that prints an error message and exits if the
underlying fchdir() fails.
Signed-off-by: Bartosz Golaszewski
---
include/libbb.h | 1 +
libbb/xfuncs_printf.c | 6 ++
2 files changed, 7 insertions(+)
diff --git a/include/libbb.h b/include/libbb.h
index 0713917
This macro - taken from the linux kernel source - improves readability
of single bit definitions.
Signed-off-by: Bartosz Golaszewski
---
include/libbb.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/libbb.h b/include/libbb.h
index 8b226c0..64e8490 100644
--- a/include/libbb.h
Add a fully featured unshare implementation implementing all arguments
supported in the upstream version.
Signed-off-by: Bartosz Golaszewski
---
util-linux/unshare.c | 465 +++
1 file changed, 465 insertions(+)
create mode 100644 util-linux
Add a new xfunction that prints an error message and exits if the
underlying fchdir() fails.
Signed-off-by: Bartosz Golaszewski
---
include/libbb.h | 1 +
libbb/xfuncs_printf.c | 6 ++
2 files changed, 7 insertions(+)
diff --git a/include/libbb.h b/include/libbb.h
index 826804a
Add a fully featured unshare implementation implementing all arguments
supported in the upstream version.
Signed-off-by: Bartosz Golaszewski
---
util-linux/unshare.c | 464 +++
1 file changed, 464 insertions(+)
create mode 100644 util-linux
textdata bss dec hex filename
82955244869120 843158 cdd96 busybox_old
82949844869120 843104 cdd60 busybox_unstripped
Signed-off-by: Bartosz Golaszewski
---
util-linux/namespace.c | 34 ++
util-linux/namespace.h | 7 +++
Add a simple macro calculating the size needed to store the string
representation of an integer type (both signed and unsigned) together
with the terminating NUL-character.
Suggested-by: Michael Conrad
Signed-off-by: Bartosz Golaszewski
---
include/libbb.h | 1 +
1 file changed, 1 insertion
Replace a call to fchdir() and the subsequent bail-out in case of an
error with a call to xfchdir().
Signed-off-by: Bartosz Golaszewski
---
runit/chpst.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/runit/chpst.c b/runit/chpst.c
index 301cdd0..7fe5151 100644
--- a/runit
textdata bss dec hex filename
82955244869120 843158 cdd96 busybox_old
82949844869120 843104 cdd60 busybox_unstripped
Signed-off-by: Bartosz Golaszewski
---
util-linux/namespace.c | 34 ++
util-linux/namespace.h | 7 +++
patch 3/4
v1: http://lists.busybox.net/pipermail/busybox/2016-March/083957.html
Bartosz Golaszewski (7):
libbb: add BIT() macro
libbb: INT_BUF_MAX(): new macro
unshare: new applet
libbb: xfchdir(): new function
nsenter: new applet
namespace utils: code shrink
runit: use xfchdir()
ed it
- added some parenthesis for better readability in patch 3/4
v1: http://lists.busybox.net/pipermail/busybox/2016-March/083957.html
Bartosz Golaszewski (5):
libbb: add BIT() macro
libbb: INT_BUF_MAX(): new macro
unshare: new applet
nsenter: new applet
namespace utils: code shrink
in
Implement a fully featured (sans selinux part) nsenter applet.
Signed-off-by: Bartosz Golaszewski
---
util-linux/namespace.h | 20 +++
util-linux/nsenter.c | 351 +
util-linux/unshare.c | 12 +-
3 files changed, 374 insertions(+), 9
Implement a fully featured (sans selinux part) nsenter applet.
Signed-off-by: Bartosz Golaszewski
---
util-linux/namespace.h | 20 +++
util-linux/nsenter.c | 367 +
util-linux/unshare.c | 12 +-
3 files changed, 390 insertions(+), 9
Add a fully featured unshare implementation implementing all arguments
supported in the upstream version.
Signed-off-by: Bartosz Golaszewski
---
util-linux/unshare.c | 464 +++
1 file changed, 464 insertions(+)
create mode 100644 util-linux
This macro - taken from the linux kernel source - improves readability
of single bit definitions.
Signed-off-by: Bartosz Golaszewski
---
include/libbb.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/libbb.h b/include/libbb.h
index 8b226c0..64e8490 100644
--- a/include/libbb.h
Add a simple macro calculating the size needed to store the string
representation of an integer type (both signed and unsigned) together
with the terminating NUL-character.
Suggested-by: Michael Conrad
Signed-off-by: Bartosz Golaszewski
---
include/libbb.h | 1 +
1 file changed, 1 insertion
Add a simple macro calculating the size needed to store the string
representation of an integer type (both signed and unsigned) together
with the terminating NUL-character.
Suggested-by: Michael Conrad
Signed-off-by: Bartosz Golaszewski
---
include/libbb.h | 17 +
1 file
it
- added some parenthesis for better readability in patch 3/4
v1: http://lists.busybox.net/pipermail/busybox/2016-March/083957.html
Bartosz Golaszewski (7):
libbb: add BIT() macro
libbb: INT_BUF_MAX(): new macro
unshare: new applet
libbb: xfchdir(): new function
nsenter: new applet
textdata bss dec hex filename
82955244869120 843158 cdd96 busybox_old
82949844869120 843104 cdd60 busybox_unstripped
Signed-off-by: Bartosz Golaszewski
---
util-linux/namespace.c | 34 ++
util-linux/namespace.h | 7 +++
Replace a call to fchdir() and the subsequent bail-out in case of an
error with a call to xfchdir().
Signed-off-by: Bartosz Golaszewski
---
runit/chpst.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/runit/chpst.c b/runit/chpst.c
index 301cdd0..7fe5151 100644
--- a/runit
This macro - taken from the linux kernel source - improves readability
of single bit definitions.
Signed-off-by: Bartosz Golaszewski
---
include/libbb.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/libbb.h b/include/libbb.h
index 8b226c0..64e8490 100644
--- a/include/libbb.h
textdata bss dec hex filename
82955244869120 843158 cdd96 busybox_old
82949844869120 843104 cdd60 busybox_unstripped
Signed-off-by: Bartosz Golaszewski
---
util-linux/namespace.c | 34 ++
util-linux/namespace.h | 7 +++
rebased and patch 3/4 didn't compile - fixed it
- added some parenthesis for better readability in patch 3/4
v1: http://lists.busybox.net/pipermail/busybox/2016-March/083957.html
Bartosz Golaszewski (4):
libbb: add BIT() macro
unshare: new applet
nsenter: new applet
namespace utils:
Implement a fully featured (sans selinux part) nsenter applet.
Signed-off-by: Bartosz Golaszewski
---
util-linux/namespace.h | 20 +++
util-linux/nsenter.c | 367 +
util-linux/unshare.c | 12 +-
3 files changed, 390 insertions(+), 9
Add a fully featured unshare implementation implementing all arguments
supported in the upstream version.
Signed-off-by: Bartosz Golaszewski
---
util-linux/unshare.c | 464 +++
1 file changed, 464 insertions(+)
create mode 100644 util-linux
This macro - taken from the linux kernel source - improves readability
of single bit definitions.
Signed-off-by: Bartosz Golaszewski
---
include/libbb.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/libbb.h b/include/libbb.h
index d05ac29..fcad060 100644
--- a/include/libbb.h
textdata bss dec hex filename
82955244869120 843158 cdd96 busybox_old
82949844869120 843104 cdd60 busybox_unstripped
Signed-off-by: Bartosz Golaszewski
---
util-linux/namespace.c | 34 ++
util-linux/namespace.h | 7 +++
x27;t compile - fixed it
- added some parenthesis for better readability in patch 3/4
v1: http://lists.busybox.net/pipermail/busybox/2016-March/083957.html
Bartosz Golaszewski (4):
libbb: add BIT() macro
unshare: new applet
nsenter: new applet
namespace utils: code shrink
include/li
Add a fully featured unshare implementation implementing all arguments
supported in the upstream version.
Signed-off-by: Bartosz Golaszewski
---
util-linux/unshare.c | 453 +++
1 file changed, 453 insertions(+)
create mode 100644 util-linux
This macro - taken from the linux kernel source - improves readability
of single bit definitions.
Signed-off-by: Bartosz Golaszewski
---
include/libbb.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/libbb.h b/include/libbb.h
index d05ac29..fcad060 100644
--- a/include/libbb.h
Implement a fully featured (sans selinux part) nsenter applet.
Signed-off-by: Bartosz Golaszewski
---
util-linux/namespace.h | 20 +++
util-linux/nsenter.c | 362 +
util-linux/unshare.c | 12 +-
3 files changed, 385 insertions(+), 9
textdata bss dec hex filename
82955244869120 843158 cdd96 busybox_old
82949844869120 843104 cdd60 busybox_unstripped
Signed-off-by: Bartosz Golaszewski
---
util-linux/namespace.c | 34 ++
util-linux/namespace.h | 7 +++
Add a fully featured unshare implementation implementing all arguments
supported in the upstream version.
Signed-off-by: Bartosz Golaszewski
---
util-linux/unshare.c | 450 +++
1 file changed, 450 insertions(+)
create mode 100644 util-linux
Implement a fully featured (sans selinux part) nsenter applet.
Signed-off-by: Bartosz Golaszewski
---
util-linux/namespace.h | 20 +++
util-linux/nsenter.c | 359 +
util-linux/unshare.c | 12 +-
3 files changed, 382 insertions(+), 9
This macro - taken from the linux kernel source - improves readability
of single bit definitions.
Signed-off-by: Bartosz Golaszewski
---
include/libbb.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/libbb.h b/include/libbb.h
index d05ac29..fcad060 100644
--- a/include/libbb.h
ty in patch 3/4
v1: http://lists.busybox.net/pipermail/busybox/2016-March/083957.html
Bartosz Golaszewski (4):
libbb: add BIT() macro
unshare: new applet
nsenter: new applet
namespace utils: code shrink
include/libbb.h| 2 +
util-linux/namespace.c | 34
util-linux/namesp
Add a fully featured unshare implementation implementing all arguments
supported in the upstream version.
Signed-off-by: Bartosz Golaszewski
---
util-linux/unshare.c | 450 +++
1 file changed, 450 insertions(+)
create mode 100644 util-linux
textdata bss dec hex filename
82945644869120 843062 cdd36 busybox_old
82939944869120 843005 cdcfd busybox_unstripped
Signed-off-by: Bartosz Golaszewski
---
util-linux/namespace.c | 34 ++
util-linux/namespace.h | 7 +++
Implement a fully featured (sans selinux part) nsenter applet.
Signed-off-by: Bartosz Golaszewski
---
util-linux/namespace.h | 20 +++
util-linux/nsenter.c | 340 +
util-linux/unshare.c | 12 +-
3 files changed, 363 insertions(+), 9
This series adds two namespaces-related applets reimplementing most
arguments supported by their upstream util-linux counterparts.
The fourth patch is an optional code shrink.
Bartosz Golaszewski (4):
libbb: add BIT() macro
unshare: new applet
nsenter: new applet
namespace utils: code
This macro - taken from the linux kernel source - improves readability
of single bit definitions.
Signed-off-by: Bartosz Golaszewski
---
include/libbb.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/libbb.h b/include/libbb.h
index d05ac29..fcad060 100644
--- a/include/libbb.h
We should bail-out if i2c_smbus_read_block_data() or
i2c_smbus_read_i2c_block_data() return 0 or less. Add the missing check
for the former and fix the existing for the latter.
Signed-off-by: Bartosz Golaszewski
---
miscutils/i2c_tools.c | 13 -
1 file changed, 8 insertions(+), 5
for I2C block.
Signed-off-by: Bartosz Golaszewski
---
miscutils/i2c_tools.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/miscutils/i2c_tools.c b/miscutils/i2c_tools.c
index 094bf9e..6d221e9 100644
--- a/miscutils/i2c_tools.c
+++ b/miscutils/i2c_tools.c
@@ -723,7 +723,7 @@
d an additional variable to hold the
temporary state.
Signed-off-by: Bartosz Golaszewski
---
miscutils/i2c_tools.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/miscutils/i2c_tools.c b/miscutils/i2c_tools.c
index d77e6ba..c5baaa7 100644
--- a/miscutils/i2
This series contains a couple of bugfixes and tweaks for i2cdetect
and i2cdump.
Bartosz Golaszewski (6):
i2cdetect: fix address skipping in auto mode
i2cdetect: coding style: add a space after 'for'
i2cdump: don't read block data in non-block modes
i2cdump: use I2C block
This makes busybox i2cdump compatible with the upstream version, which
also displays the numeric error value in case of a block read failure.
Signed-off-by: Bartosz Golaszewski
---
miscutils/i2c_tools.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/miscutils
We currently read data twice in byte mode. Add a check to avoid calling
i2c_smbus_read_i2c_block_data() if we're not in I2C or SMBus block mode.
Signed-off-by: Bartosz Golaszewski
---
miscutils/i2c_tools.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/misc
Signed-off-by: Bartosz Golaszewski
---
miscutils/i2c_tools.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/miscutils/i2c_tools.c b/miscutils/i2c_tools.c
index c5baaa7..907d738 100644
--- a/miscutils/i2c_tools.c
+++ b/miscutils/i2c_tools.c
@@ -1270,7 +1270,7 @@ int
The implementation is more or less feature complete. Remove the parts of
kernel UAPI copied from include/uapi/linux/i2c.h that aren't used.
Signed-off-by: Bartosz Golaszewski
---
v2:
- update comments as well
v1:
http://lists.busybox.net/pipermail/busybox/2015-September/083345.html
misc
The implementation is more or less feature complete. Remove the parts of
kernel UAPI copied from include/uapi/linux/i2c.h that aren't used.
Signed-off-by: Bartosz Golaszewski
---
miscutils/i2c_tools.c | 13 -
1 file changed, 13 deletions(-)
diff --git a/miscutils/i2c_tool
usage 30460 30516 +56
--
(add/remove: 0/0 grow/shrink: 3/0 up/down: 209/0) Total: 209 bytes
Signed-off-by: Bartosz Golaszewski
---
v2:
- don't call xstrtol_range() if -x is not specified
- 38 +38
tree_cmp - 11 +11
--
(add/remove: 4/0 grow/shrink: 3/0 up/down: 3126/0) Total: 3126 bytes
Signed-off-by: Bartosz Golaszewski
The first function allows to create parser_t objects for files
that are already open.
The second frees the parser_t instance without closing the file.
With these functions it is now possible to feed config files to
applets via stdin.
Signed-off-by: Bartosz Golaszewski
---
include/libbb.h
This function checks if given key can be found at the end of the string.
Signed-off-by: Bartosz Golaszewski
---
include/libbb.h | 1 +
libbb/compare_string_array.c | 32
2 files changed, 33 insertions(+)
diff --git a/include/libbb.h b/include
Signed-off-by: Bartosz Golaszewski
---
libbb/compare_string_array.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/libbb/compare_string_array.c b/libbb/compare_string_array.c
index eb754af..901e61a 100644
--- a/libbb/compare_string_array.c
+++ b/libbb/compare_string_array.c
@@ -5,6
Add a macro returning the maximum required buffer size for given
integer type.
Signed-off-by: Bartosz Golaszewski
---
include/libbb.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a/include/libbb.h b/include/libbb.h
index 6d7b128..abbd2c7 100644
--- a/include/libbb.h
+++ b/include
Test corner cases too like looking for an empty prefix etc.
Signed-off-by: Bartosz Golaszewski
---
libbb/compare_string_array.c | 19 +++
1 file changed, 19 insertions(+)
diff --git a/libbb/compare_string_array.c b/libbb/compare_string_array.c
index fe6d4a5..eb754af 100644
Add a wrapper around skip_whitespace() which evaluates to true if given
string contains only whitespace characters.
Signed-off-by: Bartosz Golaszewski
---
include/libbb.h | 2 ++
libbb/skip_whitespace.c | 17 +
2 files changed, 19 insertions(+)
diff --git a/include
Signed-off-by: Bartosz Golaszewski
---
libbb/compare_string_array.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/libbb/compare_string_array.c b/libbb/compare_string_array.c
index e24815a..fe6d4a5 100644
--- a/libbb/compare_string_array.c
+++ b/libbb/compare_string_array.c
@@ -7,12
ses
- updated unit tests for is_suffixed_with()
- added detailed comments for both functions
- removed unused code from is_prefixed_with() (any reason to keep it?)
- removed global stopped condition from readahead since signals are handled
by signalfd, not signal handlers
Bartosz Golaszewski
Add a wrapper around skip_whitespace() which evaluates to true if given
string contains only whitespace characters.
Signed-off-by: Bartosz Golaszewski
---
include/libbb.h | 2 ++
libbb/skip_whitespace.c | 17 +
2 files changed, 19 insertions(+)
diff --git a/include
and disabled by default
- removed patches implementing system calls in busybox
Bartosz Golaszewski (5):
libbb: add str_isblank() macro
libbb: add DECIMAL_STR_MAX macro
libbb: add ends_with() function
libbb: add config_from_fp() and config_free() functions
readahead: applet extension
d
The first function allows to create parser_t objects for files
that are already open.
The second frees the parser_t instance without closing the file.
With these functions it is now possible to feed config files to
applets via stdin.
Signed-off-by: Bartosz Golaszewski
---
include/libbb.h
Add a macro returning the maximum required buffer size for given
integer type.
Signed-off-by: Bartosz Golaszewski
---
include/libbb.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a/include/libbb.h b/include/libbb.h
index 478c030..a56b684 100644
--- a/include/libbb.h
+++ b/include
- 38 +38
tree_cmp - 11 +11
--
(add/remove: 4/0 grow/shrink: 3/0 up/down: 3111/0) Total: 3111 bytes
Signed-off-by: Bartosz Golaszewski
This function checks if given key can be found at the end of the string.
Signed-off-by: Bartosz Golaszewski
---
include/libbb.h | 1 +
libbb/compare_string_array.c | 30 ++
2 files changed, 31 insertions(+)
diff --git a/include/libbb.h b/include
.
Signed-off-by: Bartosz Golaszewski
---
Makefile.flags | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/Makefile.flags b/Makefile.flags
index a1ed148..bb90a08 100644
--- a/Makefile.flags
+++ b/Makefile.flags
@@ -121,20 +121,20 @@ endif
# fall back to using a
- 11 +11
--
(add/remove: 4/0 grow/shrink: 3/0 up/down: 3091/0) Total: 3091 bytes
Signed-off-by: Bartosz Golaszewski
---
docs/readahead.txt| 36 +++
miscutils/Config.src | 4 +-
miscutils
The first function allows to create parser_t objects for files
that are already open.
The second frees the parser_t instance without closing the file.
With these functions it is now possible to feed config files to
applets via stdin.
Signed-off-by: Bartosz Golaszewski
---
include/libbb.h
Fanotify syscalls are not supported in uClibc. Add a new include
file - missing_syscalls.h - implementing the syscalls directly in
busybox.
Signed-off-by: Bartosz Golaszewski
---
include/missing_syscalls.h | 47 ++
1 file changed, 47 insertions
Readahead isn't a commonly used applet and since the addition of the
daemon mode its size increased significantly. Change the default value
in Config.src to 'n'.
Signed-off-by: Bartosz Golaszewski
---
miscutils/Config.src | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-
Currently uClibc declares but doesn't define syncfs(). In versions <= 0.9.33
it's not even declared in unistd.h. This makes it impossible to compile sync
with CONFIG_FEATURE_SYNC_FANCY on uClibc.
Add support for this system call to missing_syscalls.h.
Signed-off-by: Bartos
Since there is no interest in merging a config option for WANT_TIMING,
remove the parts of code depending on it altogether.
While we're at it: add some newlines to improve readability.
Signed-off-by: Bartosz Golaszewski
---
libbb/bbunit.c | 30 +++---
1 file chang
ead, remove unneeded code or fix compilation issues in different
parts of code.
This series is also available at:
https://github.com/brgl/busybox readahead
Bartosz Golaszewski (10):
unit-tests: remove unnecesary field from struct bbunit_listelem
unit-tests: remove code depending on WANT_TIM
_elem 24 16 -8
--
(add/remove: 0/0 grow/shrink: 0/4 up/down: 0/-25) Total: -25 bytes
Signed-off-by: Bartosz Golaszewski
---
include/libbb.h | 1 -
libbb/bbunit.c | 1 -
2
Add a wrapper around skip_whitespace() which evaluates to true if given
string contains only whitespace characters.
Signed-off-by: Bartosz Golaszewski
---
include/libbb.h | 2 ++
libbb/skip_whitespace.c | 17 +
2 files changed, 19 insertions(+)
diff --git a/include
This function checks if given key can be found at the end of the string.
Signed-off-by: Bartosz Golaszewski
---
include/libbb.h | 1 +
libbb/compare_string_array.c | 30 ++
2 files changed, 31 insertions(+)
diff --git a/include/libbb.h b/include
Add a macro returning the maximum required buffer size for given
integer type.
Signed-off-by: Bartosz Golaszewski
---
include/libbb.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a/include/libbb.h b/include/libbb.h
index 478c030..a56b684 100644
--- a/include/libbb.h
+++ b/include
41969584 841945 cd8d9 busybox_unstripped
Signed-off-by: Bartosz Golaszewski
---
miscutils/inotifyd.c | 24 ++--
1 file changed, 18 insertions(+), 6 deletions(-)
diff --git a/miscutils/inotifyd.c b/miscutils/inotifyd.c
index 7a1a6a2..97f67ab 100644
--- a/miscutils/inoti
41969584 841945 cd8d9 busybox_unstripped
Signed-off-by: Bartosz Golaszewski
---
NOTE: I don't quite understand where the increase in size of .rodata
comes from. Looking at objdump output I can see some strings generated
for xstrtol_range() and then some additional non-readable bytes whi
Since there are no more statements in the if block after the while loop
in list_i2c_busses_and_exit(), there's no need for a goto.
Signed-off-by: Bartosz Golaszewski
---
NOTES: fixed two typos in the commit message.
miscutils/i2c_tools.c | 3 +--
1 file changed, 1 insertion(+), 2 dele
Addresses 0x00-0x02 shouldn't be scanned by default. This patch makes
'first' default to 0x03 and only enables lower addresses if '-a' option
is passed
Signed-off-by: Bartosz Golaszewski
---
miscutils/i2c_tools.c | 6 --
1 file changed, 4 insertions(+), 2 d
We should only warn the user about addresses to be skipped if
(mode == DETECT_MODE_AUTO).
Signed-off-by: Bartosz Golaszewski
---
miscutils/i2c_tools.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/miscutils/i2c_tools.c b/miscutils/i2c_tools.c
index 6f97872..16784e9
Split i2cdump_main() into shorter functions. Simplify the code a bit.
Make block an array of ints so that we can store negative results of
read functions (fixes a bug found by Denys Vlasenko).
Signed-off-by: Bartosz Golaszewski
---
miscutils/i2c_tools.c | 316
dec hex filename
82609741649584 839845 cd0a5 busybox_old
82614541649584 839893 cd0d5 busybox_unstripped
Signed-off-by: Bartosz Golaszewski
---
miscutils/i2c_tools.c | 31 +++
1 file changed, 19 insertions(+), 12 deletions(-)
diff --git a/mis
Since there are now more statements in the if block after the while loop
in list_i2c_busses_and_exit(), there's no need for a label.
Signed-off-by: Bartosz Golaszewski
---
miscutils/i2c_tools.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/miscutils/i2c_tool
rework to the series
- fixed an unneeded indentation in i2cdetect
Bartosz Golaszewski (5):
i2cdetect: don't die on addresses already in use by drivers
i2cdetect: don't scan non-regular addresses without the '-a' option
i2cdetect: add a check for (mode == DETECT_MODE_AUTO)
Split i2cdump_main() into shorter functions. Simplify the code a bit.
Make block an array of ints so that we can store negative results of
read functions (fixes a bug found by Denys Vlasenko).
Signed-off-by: Bartosz Golaszewski
---
miscutils/i2c_tools.c | 316
Addresses 0x00-0x02 shouldn't be scanned by default. This patch makes
'first' default to 0x03 and only enables lower addresses if '-a' option
is passed
Signed-off-by: Bartosz Golaszewski
---
miscutils/i2c_tools.c | 6 --
1 file changed, 4 insertions(+), 2 d
This series fixes one major issue and two smaller bugs in i2cdetect and
reworks i2cdump_main().
v3:
- drop the check for COMMON_BUFSIZE < block buffer size as it's highly
unlikely, isn't it?
v2:
- added i2cdump code rework to the series
- fixed an unneeded indentation in i2cde
1 - 100 of 162 matches
Mail list logo
