Re: [PATCH 9/9] loop: Add LOOP_CONFIGURE ioctl

2022-11-18 Thread Lauri Kasanen
On Fri, 18 Nov 2022 17:11:17 +0800 Xiaoming Ni wrote: > >> +#if LINUX_VERSION_CODE >= KERNEL_VERSION(5,8,0) > >> +static int set_loop_configure(int ffd, int lfd, bb_loop_info *loopinfo) > >> +#else > > > > This assumes compile-time matches runtime. Ie, if you build on a 5.8 > > system, but run

Re: [PATCH 9/9] loop: Add LOOP_CONFIGURE ioctl

2022-11-17 Thread Lauri Kasanen
On Fri, 18 Nov 2022 09:01:58 +0800 Xiaoming Ni wrote: > LOOP_CONFIGURE is added to Linux 5.8 ... > diff --git a/libbb/loop.c b/libbb/loop.c > index 9a7ca666d..d4f4906b0 100644 > --- a/libbb/loop.c > +++ b/libbb/loop.c > @@ -126,6 +126,30 @@ static int open_file(const char *file, unsigned flags,

Re: [PATCH] volume_id: volume_id_get_buffer with small FSes

2022-05-16 Thread Lauri Kasanen
On Mon, 16 May 2022 10:03:20 + Alyssa Ross wrote: > On Mon, May 16, 2022 at 08:23:37AM +0300, Lauri Kasanen wrote: > > On Sun, 15 May 2022 17:18:47 + > > Alyssa Ross wrote: > > > > > I tested both the cases mentioned in the comments — an empty floppy &

Re: [PATCH] volume_id: volume_id_get_buffer with small FSes

2022-05-15 Thread Lauri Kasanen
On Sun, 15 May 2022 17:18:47 + Alyssa Ross wrote: > I tested both the cases mentioned in the comments — an empty floppy > drive, and an unused loop device. Reading from an empty floppy drive > is ENXIO, and reading from an unused loop device returns 0, so it > should be fine to drop the

Re: [PATCH] pw_encrypt: Add option to enable bcrypt support

2022-05-03 Thread Lauri Kasanen
On Tue, 3 May 2022 13:58:44 +0200 Andreas Helmcke wrote: > diff --git a/loginutils/Config.src b/loginutils/Config.src > index cbb09646b..cdcd7132f 100644 > --- a/loginutils/Config.src > +++ b/loginutils/Config.src > @@ -91,6 +91,28 @@ config USE_BB_CRYPT_SHA > With this option off,

Re: httpd ranges do not work over 4gb

2021-10-08 Thread Lauri Kasanen
On Fri, 8 Oct 2021 15:58:47 +0200 Denys Vlasenko wrote: > WRONG. If CONFIG_LFS is off, sizeof(off_t) can be larger than sizeof(int). > x86_64 is an example. > > > Fixed in git, please test. Fixed! Thanks. - Lauri ___ busybox mailing list

httpd ranges do not work over 4gb

2021-10-08 Thread Lauri Kasanen
Hi, On current bb master httpd, when the client requests valid Range: bytes over 4gb, the response is wrong - it sends the entire file instead of the requested range. E.g. Range: bytes=5926192128-5926195199 This is on x86_64, so CONFIG_LFS etc shouldn't matter. I haven't yet looked deeper if

Re: Would a patch implementing the netns feature to iplink.c be interesting?

2021-09-26 Thread Lauri Kasanen
On Sun, 26 Sep 2021 22:30:43 -0400 blowfist wrote: > Hey there, > > I've made a few patches to busybox to add a few standard features to > busybox which aren't yet supported in busybox. I'm using these for my project > jailTools and I was wondering if they would stand any chance of being merged

Re: [PATCH] Add support for zstd decompression

2021-09-11 Thread Lauri Kasanen
On Sat, 11 Sep 2021 02:51:51 +0200 Denys Vlasenko wrote: > Anyone knows whether working > with zstd people is doable, or it is more of a "Pottering" > experience? Cyan is quite responsive, I had an issue with a rare arch and it was taken care of. Facebook of course has performance as priority

Re: six patches from tinycore linux

2021-08-12 Thread Lauri Kasanen
On Thu, 12 Aug 2021 16:59:35 +0200 Emmanuel Deloget wrote: > * busybox-1.33.0_skip-loop-control.patch makes get_free_loop() behave > as if there was no free loop devices (unconditionnaly). It would help > to have some background info here, as it does not seem to fix a bug. It fixes a specific

Re: Curious bug in remounting read-only cdrom mount point

2021-08-09 Thread Lauri Kasanen
Hi, Your logs show you're running a different binary. correct.txt and dropbear.txt run the util-linux mount, and only uncorrect.txt runs busybox mount. So it's not about SSH or the env, but looks like busybox mount just has a different (wrong?) return code. - Lauri

Traceroute bug in 1.33 release (please apply patch from master)

2021-03-07 Thread Lauri Kasanen
Hi, Traceroute on the 1.33 release is buggy "traceroute: NO OPT x!". The patch on master, commit f3a55b306ed3 "traceroute: fix option parsing" fixes it. Please apply this patch to the 1.33 branch. - Lauri ___ busybox mailing list busybox@busybox.net

Re: [PATCH v2 1/2] modutils: check ELF header before calling finit_module()

2021-01-05 Thread Lauri Kasanen
On Tue, 5 Jan 2021 20:21:12 +0100 Alex Samorukov wrote: > On Tue, 5 Jan 2021 10:47:25 +0800 > > Kang-Che Sung wrote: > > > >> I don't see why the > >> "Invalid ELF header" message would bother you so much, since you > >> won't load kernel modules often. > > As mentioned in my original post,

Re: [PATCH v2 1/2] modutils: check ELF header before calling finit_module()

2021-01-04 Thread Lauri Kasanen
On Tue, 5 Jan 2021 10:47:25 +0800 Kang-Che Sung wrote: > I don't see why the > "Invalid ELF header" message would bother you so much, since you > won't load kernel modules often. As mentioned in my original post, it's a pr_err. It shows up on console! So every boot there's 20 scary errors

Re: Busybox modprobe hitch with kernel 5.10

2020-12-30 Thread Lauri Kasanen
On Tue, 29 Dec 2020 22:05:21 +0100 Denys Vlasenko wrote: > On Mon, Dec 28, 2020 at 6:15 PM Lauri Kasanen wrote: > > Hi, > > > > On Busybox 1.31.1, modprobing any module for the 5.10 kernel prints a > > nasty message: > > Module has invalid ELF header > >

Busybox modprobe hitch with kernel 5.10

2020-12-28 Thread Lauri Kasanen
Hi, On Busybox 1.31.1, modprobing any module for the 5.10 kernel prints a nasty message: Module has invalid ELF header but the module loads successfully after that. So looks like bb tries two paths, the first fails, second succeeds. It's rather unsightly to get a high priority kernel error

[PATCH] mount: Surround syslog.h with the config check

2020-12-21 Thread Lauri Kasanen
This lets bb mount build for limited targets without syslog.h, as long as the parts using it like NFS are disabled. Signed-off-by: Lauri Kasanen --- util-linux/mount.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/util-linux/mount.c b/util-linux/mount.c index 0814a52..831dab9 100644

Re: [PATCH] shrink last_char_is function even more

2020-07-19 Thread Lauri Kasanen
On Sun, 19 Jul 2020 22:31:09 +0200 Tito wrote: > please don't do this, this will bite us further up the road, > similarly as all string functions that save a check and break > havoc afterwards. The param should be marked with the nonnull attribute, just like the libc string functions. Then the

Re: [PATCH] unzip: -d should create the dir

2020-04-18 Thread Lauri Kasanen
On Sat, 18 Apr 2020 00:23:13 +0200 (CEST) Johannes Schindelin wrote: > Doesn't Info-Zip do more like an `mkdir -p` than only a single level? Not sure, I've never tried to extract in a non-existent subdir tree. 100% of my use of -d is in a single new dir. - Lauri

[PATCH] unzip: -d should create the dir

2020-04-15 Thread Lauri Kasanen
The official Info-Zip unzip creates the dir if it doesn't exist. Signed-off-by: Lauri Kasanen --- archival/unzip.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/archival/unzip.c b/archival/unzip.c index 8c4cb98..45e0727 100644 --- a/archival/unzip.c +++ b/archival

master build failure (ash, undefined reference to `fill_arglist')

2020-03-19 Thread Lauri Kasanen
Hi, Current master fails to build with the attached config. shell/ash.c: In function 'subevalvar': shell/ash.c:7287: warning: label 'out1' defined but not used shell/ash.c: In function 'evalcommand': shell/ash.c:10173: warning: implicit declaration of function 'fill_arglist' shell/ash.c:10173:

Re: Weird signal issues using yocto's warrior busybox (aarch64) when memory is cached

2020-01-29 Thread Lauri Kasanen
Hi, Try running your uptime loop script under valgrind? - Lauri ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox

"mount,losetup: use /dev/loop-control is it exists" regression

2019-12-17 Thread Lauri Kasanen
Hi, In TC, we noticed a regression from the loop-control commit. "mount: can't setup loop device: No such file or directory" when trying to mount more than eight loops, on a kernel with loop-control. It's possibly a race, could be udev didn't have time to create the device before bb tried to

Re: [PATCH 8/8] mdev: remember line number in rule

2019-12-17 Thread Lauri Kasanen
On Mon, 16 Dec 2019 22:56:56 +0100 Jan Klötzke wrote: > --- a/util-linux/mdev.c > +++ b/util-linux/mdev.c > @@ -299,6 +299,7 @@ struct rule { > IF_FEATURE_MDEV_EXEC(char *r_cmd;) > regex_t match; > struct envmatch *envmatch; > + int lineno; > }; int16_t? Surely mdev.conf

Re: Why almost every command is trying to read urandom?

2019-11-12 Thread Lauri Kasanen
On Tue, 12 Nov 2019 22:43:28 +0100 Mauro Condarelli wrote: > Question: is that supposed to be a "harmless warning" or it's the tip of > an iceberg? It's harmless as long as the program causing it is not cryptographic. "The randomness provided may not be high quality". - Lauri

Re: [PATCH] Add svg to built in MIME types list

2019-06-07 Thread Lauri Kasanen
On Fri, 7 Jun 2019 08:36:42 +0200 Xabier Oneca -- xOneca wrote: > (But there's missing js!) I second this. That's the only change I had to make recently to httpd.conf, because FF does not execute JS with the wrong mime type (other browsers do). - Lauri

Re: [PATCH] Add bc (Last patch)

2018-10-30 Thread Lauri Kasanen
On Mon, 29 Oct 2018 17:30:09 -0600 Gavin Howard wrote: > Okay, as it stands, I see one big showstopper for getting this into > busybox: code style. I don't know how to fix code style with a script, > so if it is a showstopper for you (and if it is, I don't blame you), I > guess I have to

Re: Ash glob symlink regression when using libc glob

2017-10-31 Thread Lauri Kasanen
On Tue, 31 Oct 2017 13:34:48 +0100 Denys Vlasenko wrote: > > It fails with glibc 2.24 and 2.7, x86 and x86_64, so probably everything > > between. Are you on a more recent glibc? > > $ /lib64/libc.so.6 > GNU C Library (GNU libc) development release version 2.26.9000.

Re: Ash glob symlink regression when using libc glob

2017-10-31 Thread Lauri Kasanen
On Mon, 30 Oct 2017 20:24:08 +0100 Denys Vlasenko <vda.li...@googlemail.com> wrote: > On Sun, Oct 29, 2017 at 7:43 PM, Lauri Kasanen <c...@gmx.com> wrote: > > Hi, > > > > It was reported the following case fails with bb 1.27.2: > > > > ln

Ash glob symlink regression when using libc glob

2017-10-29 Thread Lauri Kasanen
Hi, It was reported the following case fails with bb 1.27.2: ln -s nonexistent mylink mv myli* someother It also fails with master. I bisected it to b3f29b452a660a7293162897424bed205f7f9147, "ash: use glob() from libc". Works with bash. - Lauri bb-config.gz Description: Binary data

Re: [PATCH] Silence misguided GCC warning about alignment issues

2017-08-07 Thread Lauri Kasanen
On Mon, 7 Aug 2017 12:09:45 +0200 (CEST) Johannes Schindelin wrote: > Meaning: GCC gets this all wrong and should not complain. So let's force > it to be quiet for a couple of lines. I believe this is both wrong and dangerous. If gcc warns about it, it will also very

Re: acpid & detection of new input devices

2017-07-20 Thread Lauri Kasanen
Hi, Big acpid seems to use inotify on /dev/input. Or perhaps you can set up an udev rule that sends a signal to acpid. - Lauri ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox

Re: Problem with cat

2017-03-14 Thread Lauri Kasanen
On Mon, 13 Mar 2017 19:24:17 + (UTC) Grant Edwards wrote: > That paragraph is wrong (or at least misleading). I've checked the > source code, and 2.6.33 does not update the output file postition (at > least not the version I downloaded from kernels.org nor the

Re: SSL/TLS client command line API?

2017-01-20 Thread Lauri Kasanen
On Thu, Jan 19, 2017, at 16:17, Denys Vlasenko wrote: > Hi folks, > > So far bbox is completely SSL/TLS-illiterate. wget can't talk > HTTPS. sendmail groks neither smtps not STARTTLS command. nc can't > do TLS either. ... > Do you know a tool whose command line is suitable for us? Don't know of

Re: Ash wildcard usability bug

2016-10-27 Thread Lauri Kasanen
On Thu, Oct 27, 2016, at 09:14, Kang-Che Sung wrote: > If you are arguing about usability, you should assume a case that you > are in an _interactive_ shell. Non-interactive environment is for > shell scripts, and for that portability and robustness will be more > important than what you called

Re: Ash wildcard usability bug

2016-10-26 Thread Lauri Kasanen
On Wed, Oct 26, 2016, at 05:44, Kang-Che Sung wrote: > I wonder why you can't implement an easy workaround using ls or > something. > > filename="`ls *zip | head -n 1`" > nc 10.0.0.1 12345 < "$filename" > do_something_else < "$filename" > > Yeah. Just avoid the glob on the

Re: Ash wildcard usability bug

2016-10-25 Thread Lauri Kasanen
> > On Mon, Oct 24, 2016, at 20:09, Denys Vlasenko wrote: > > > Note that they allow to consistently never do globbing on the > > > redirect word. > > > > > > To me it looks like the best course of action. > > > > Surely we all agree that it's terrible usability to not expand it? > > It may be

Re: Ash wildcard usability bug

2016-10-25 Thread Lauri Kasanen
On Mon, Oct 24, 2016, at 20:09, Denys Vlasenko wrote: > Note that they allow to consistently never do globbing > on the redirect word. > > To me it looks like the best course of action. Surely we all agree that it's terrible usability to not expand it? - Lauri -- http://www.fastmail.com -

Ash wildcard usability bug

2016-10-18 Thread Lauri Kasanen
Hi, The following fails in ash 1.24.1, probably also in git. Works in bash. nc 10.0.0.1 1234 < *zip "sh: can't open *zip: no such file" Also applies to cat, etc. With only one matching file in the directory. - Lauri -- http://www.fastmail.com - The way an email service should be

Re: Current git HEAD busybox segfaults on some applets

2016-09-16 Thread Lauri Kasanen
On Fri, Sep 16, 2016, at 19:41, Rich Felker wrote: > More to the point, they're unnecessary and unsafe. The *_unlocked > functions are not well-specified, and except for getc/putc, they're > not going to yield you any performance benefits anyway. They were originally added because of my request,

Re: [PATCH] libbb: More informative "short write" error

2016-09-05 Thread Lauri Kasanen
On Mon, Sep 5, 2016, at 13:18, Denys Vlasenko wrote: > How about just replacing bb_error_msg_and_die() > with bb_perror_msg_and_die()? $ busybox wget google.com Connecting to google.com (172.217.20.14:80) Connecting to www.google.fi (80.239.229.245:80) wget: short write: No space left on device

[PATCH] libbb: More informative "short write" error

2016-09-04 Thread Lauri Kasanen
ing to ask. - Lauri -- http://www.fastmail.com - A no graphics, no pop-ups email service From 5c9f3c91db1e8f5b7adb7fb8211ece92a5ecc756 Mon Sep 17 00:00:00 2001 From: Lauri Kasanen <cur...@operamail.com> Date: Sun, 4 Sep 2016 13:08:59 +0300 Subject: [PATCH] libbb: More informative "

Re: Not getting the correct result with SHA3

2016-08-29 Thread Lauri Kasanen
On Mon, Aug 29, 2016, at 15:10, Denys Vlasenko wrote: > I guess this is an example why it makes sense to wait for general > adoption of the tool in common distros before adding it to busybox. > > The bug was that SHA3 uses 0110*1 padding (raw Keccak uses 10*1). > Easy to fix. > > sha3sum which I

Re: Not getting the correct result with SHA3

2016-08-27 Thread Lauri Kasanen
On Fri, Aug 26, 2016, at 21:28, Marlon Smith wrote: > Hi everyone, > > I'm using Busybox version 1.23.1 and it seems like sha3sum is giving an > incorrect result. > > For example if I run this command: > > echo "abc" | sha3sum > > I get an incorrect result: > >

Re: [PATCH] md5sum: error out on -c empty file

2016-07-11 Thread Lauri Kasanen
On Sat, Jun 25, 2016, at 20:48, Lauri Kasanen wrote: > Hi, > > GNU md5sum errors out when passed an empty file via -c. Add a test and > make bb md5sum do the same. Ping. We have scripts that need this behavior. - Lauri -- http://www.fastmail.com - A no graphics, no pop-ups e

Re: [PATCH] getrandom: new applet

2016-06-28 Thread Lauri Kasanen
On Tue, Jun 28, 2016, at 19:56, Etienne CHAMPETIER wrote: > first user of this applet will be LEDE (OpenWrt) to save an urandom seed > using getrandom() (so we are sure /dev/urandom pool is initialized) In LFS, the boot scripts use dd for this. Is there any need for an applet? - Lauri --

[PATCH] md5sum: error out on -c empty file

2016-06-25 Thread Lauri Kasanen
Hi, GNU md5sum errors out when passed an empty file via -c. Add a test and make bb md5sum do the same. - Lauri -- http://www.fastmail.com - Choose from over 50 domains or use your own From f5a686ea2ac56d91f6cecf16b234b43608a51ec7 Mon Sep 17 00:00:00 2001 From: Lauri Kasanen <

New warning from the applet rework

2016-06-25 Thread Lauri Kasanen
Hi, Today's git with the attached config, on x86_64 linux, gives this warning: libbb/appletlib.c:55: warning: 'run_applet_and_exit' declared 'static' but never defined - Lauri -- http://www.fastmail.com - Access all of your messages and folders wherever you are

Re: Busybox binary ends up only 340 bytes

2016-04-05 Thread Lauri Kasanen
On Mon, Apr 4, 2016, at 23:52, st...@weaverpad.com wrote: > I am trying to build Busybox for my ARMv7-M microprocessor based > board. It seems to compile everything as configured; however, the > resulting binary is only 340 bytes in size. The map file shows all > files that were built, but there

Testing gcc 5.2 and LTO

2015-08-31 Thread Lauri Kasanen
Hi, With my shiny new gcc 5.2 toy, I thought I'd test how its LTO worked for bb, and share the numbers. There were a few hundred new warnings, one parenthesis in ash, and all the rest about strict aliasing, mainly in minix and top. All on x86_64, defconfig with sync_fancy and ubi* disabled.

Re: How to compare two floats?

2015-05-24 Thread Lauri Kasanen
On Saturday 23 May 2015 21:41:51 bifferos wrote: I'm trying to write a thermostat using busybox shell, however the only way I could think to compare two float temperatures (without adding awk) was to multiply them up in dc and then compare as integers. In the end I modified dc to add a

modinfo broken in both master and 1.23

2015-02-21 Thread Lauri Kasanen
Hi, We find that modinfo for gzipped modules is broken in both today's master and the stable 1.23 branch (1.23.1 release is also broken). Good output (1.22.1 for example): $ modinfo ntfs filename: kernel/fs/ntfs/ntfs.ko.gz license:GPL author: Anton Altaparmakov

Re: [PATCH] Add a gzip fastpath for the xmalloc readers, v3

2014-12-07 Thread Lauri Kasanen
On Sun, Dec 7, 2014, at 01:51, Denys Vlasenko wrote: It misses the plus one zero byte behavior of the non-compressed path (xmalloc_read). I bet some callers depend on it, using str* functions on the returned buffer. Fixed, and committed to git. Please try it. Results are correct and

Re: [PATCH] Add a gzip fastpath for the xmalloc readers, v3

2014-12-06 Thread Lauri Kasanen
On Sat, Dec 6, 2014, at 18:11, Denys Vlasenko wrote: Please see attached patch (only compile-tested so far). It builds on your work, implementing in-memory compression for all unpackers we have. It misses the plus one zero byte behavior of the non-compressed path (xmalloc_read). I bet some

[PATCH] Add a gzip fastpath for the xmalloc readers, v3

2014-11-30 Thread Lauri Kasanen
) Total: 348 bytes -- http://www.fastmail.com - Does exactly what it says on the tin From 5ad6804ed4485eae176da45524ea848a00b11929 Mon Sep 17 00:00:00 2001 From: Lauri Kasanen cur...@operamail.com Date: Sun, 30 Nov 2014 21:37:10 +0200 Subject: [PATCH] Add a gzip fastpath for the xmalloc

[PATCH] Add a gzip fastpath for the xmalloc readers, v2

2014-11-28 Thread Lauri Kasanen
-- (add/remove: 6/0 grow/shrink: 1/2 up/down: 2989/-2400)Total: 589 bytes -- http://www.fastmail.com - The way an email service should be From e5a58da5d54b8a8e2eef657ac6be60231683a662 Mon Sep 17 00:00:00 2001 From: Lauri Kasanen cur...@operamail.com

[PATCH] Add a gzip fastpath for the xmalloc readers

2014-11-27 Thread Lauri Kasanen
4eaee06a748ce07b004b40aa10fa1bcc3e5e8928 Mon Sep 17 00:00:00 2001 From: Lauri Kasanen cur...@operamail.com Date: Thu, 27 Nov 2014 14:48:17 +0200 Subject: [PATCH] Add a gzip fastpath for the xmalloc readers The performance and number of processes for a depmod -a with gzipped modules was abysmal. This patch

open_transformer fork, depmod

2014-11-25 Thread Lauri Kasanen
Hi, Can anyone fill me in on the reason why open_transformer always forks, instead of straight decompressing? I found the original commit from 2003: http://lists.busybox.net/pipermail/busybox-cvs/2003-November/019040.html But it doesn't explain why the move was done. I ask because doing a

Re: [PATCHv2] Use sendfile to copy data between file descriptors

2014-10-21 Thread Lauri Kasanen
On Tue, Oct 21, 2014, at 08:46, Mike Frysinger wrote: On 20 Oct 2014 21:00, Lauri Kasanen wrote: +config FEATURE_USE_SENDFILE +bool Use sendfile system call +default y +help + When enabled, busybox will use the kernel sendfile() function

Re: [PATCHv2] Use sendfile to copy data between file descriptors

2014-10-20 Thread Lauri Kasanen
+config FEATURE_USE_SENDFILE +bool Use sendfile system call +default y +help + When enabled, busybox will use the kernel sendfile() function + instead of read/write loops where applicable. Please include the kernel version requirement here. +#if

Re: dc hitting a compiler bug, or undefined behavior

2014-03-31 Thread Lauri Kasanen
On Mon, Mar 31, 2014, at 0:37, Ralf Friedl wrote: What's even worse is that adding any output to push(), even a puts(hi) that does not print the argument or any of the stack vars, fixes it. So something magic is going on inside the GCC optimization, I'm afraid this is above my pay grade.

dc hitting a compiler bug, or undefined behavior

2014-03-30 Thread Lauri Kasanen
Hi, I'm seeing busybox dc acting funny when compiled with some versions of gcc. This is on busybox git. The x86 binary busybox_unstripped and config are attached. gcc 4.2.2 - ok gcc 4.7.2: nc 10 1 add p 2.738e+93 So either bb is hitting a compiler bug, or undefined behavior somewhere with new

Re: dc hitting a compiler bug, or undefined behavior

2014-03-30 Thread Lauri Kasanen
On Sun, Mar 30, 2014, at 15:05, Ralf Friedl wrote: I'm seeing busybox dc acting funny when compiled with some versions of gcc. This is on busybox git. The x86 binary busybox_unstripped and config are attached. gcc 4.2.2 - ok gcc 4.7.2: nc 10 1 add p 2.738e+93 So either bb is

Re: dc hitting a compiler bug, or undefined behavior

2014-03-30 Thread Lauri Kasanen
On Sun, Mar 30, 2014, at 18:26, Ralf Friedl wrote: What's even worse is that adding any output to push(), even a puts(hi) that does not print the argument or any of the stack vars, fixes it. So something magic is going on inside the GCC optimization, I'm afraid this is above my pay grade.

Re: Ntpd config file support

2014-03-22 Thread Lauri Kasanen
On Sat, Mar 22, 2014, at 1:57, Laurent Bercot wrote: On 21/03/2014 23:10, Cathey, Jim wrote: The only thing BB would need would be to isolate initialization into separate functions that would be grouped together by the linker. (And an associated link control file.) The usual demand-paged

Re: [PATCH] correct_password: Handle NULL from crypt

2014-02-10 Thread Lauri Kasanen
On Mon, Feb 10, 2014, at 10:35, Rich Felker wrote: On Sun, Feb 09, 2014 at 12:52:50PM +0100, Denys Vlasenko wrote: The old behavior was to return ? (I have no old glibc at hand to check it quickly). Since we have exactly one crypt() call in the entire busybox, the easiest fix would

[PATCH] correct_password: Handle NULL from crypt

2014-02-03 Thread Lauri Kasanen
. The attached patch fixes su. You may want to check every other call to crypt() in busybox. - Lauri -- http://www.fastmail.fm - A fast, anti-spam email service. From 586f648074e6f979b79a88e1722188b8e6562bd0 Mon Sep 17 00:00:00 2001 From: Lauri Kasanen cur...@operamail.com Date: Mon, 3 Feb 2014 18:47

Re: [PATCH 0/3] less: display ANSI colors with option -R

2014-02-02 Thread Lauri Kasanen
On Sun, Feb 2, 2014, at 17:56, Rich Felker wrote: systemd is broken by design. I did not look too deeply into its design. Unless there are serious design flaws I am not aware of, the idea per se looks sensible. The idea is not sensible. If I find time I'll write a short article on

Re: [PATCH 0/3] less: display ANSI colors with option -R

2014-01-24 Thread Lauri Kasanen
On Thu, Jan 23, 2014, at 21:28, Bernhard Reutner-Fischer wrote: On 23 January 2014 11:01:05 Denys Vlasenko vda.li...@googlemail.com Pottering's attempts to force his crap down our throats have to be called out and resisted. :) Fix systemd then. But apart from that I'd like to have a

Re: set_loop tries to create 1048575 loop devices

2014-01-20 Thread Lauri Kasanen
On Mon, Jan 20, 2014, at 18:52, Ralf Friedl wrote: Hi I just had mount create a large number of loop devices before I interrupted it. The reason is that the loop module is not loaded in the kernel, but it would be better to have an error message instead. ... I don't know whether

Re: set_loop tries to create 1048575 loop devices

2014-01-20 Thread Lauri Kasanen
I just had mount create a large number of loop devices before I interrupted it. The reason is that the loop module is not loaded in the kernel, but it would be better to have an error message instead. ... I don't know whether there are other reasons why open /dev/loop might

Re: Why '-c DEV' option for switch_root?

2013-12-16 Thread Lauri Kasanen
On Mon, Dec 16, 2013, at 10:05, Laurent Bercot wrote: On 2013-12-16 01:08, Rob Landley wrote: The most recent kernel has my initmpfs patches, meaning initramfs can now be a tmpfs instead of ramfs. [snip blurb] You're listing reasons why initramfs (or initmpfs, if you prefer) is more

Re: [PATCH] wget: User-friendly fallback to http

2013-12-16 Thread Lauri Kasanen
Hi Denys, Ping on http://lists.busybox.net/pipermail/busybox/2013-November/080038.html If DESKTOP guards or something else is needed, please say. - Lauri -- http://www.fastmail.fm - The way an email service should be ___ busybox mailing list

[PATCH] wget: User-friendly fallback to http

2013-11-25 Thread Lauri Kasanen
17 00:00:00 2001 From: Lauri Kasanen cur...@operamail.com Date: Mon, 25 Nov 2013 20:53:12 +0200 Subject: [PATCH] wget: User-friendly fallback to http GNU wget: wget google.com // ok bb before: wget google.com // wget: not an http or ftp url Signed-off-by: Lauri Kasanen cur...@operamail.com

Re: [PATCH 1/2] wget: make default timeout configurable, remove a duplicate line

2013-10-18 Thread Lauri Kasanen
On Fri, Oct 18, 2013, at 12:52, Tito wrote: Hi, can the wget scripts not be modified like [ -r /etc/default/wget.conf ] . /etc/default/wget.conf wget -t $WGET_TIMEOUT Hi Tito, The whole point of this patch was to avoid having to modify scripts, otherwise we'd just have added the lot of -T

Re: [PATCH 1/2] wget: make default timeout configurable, remove a duplicate line

2013-10-17 Thread Lauri Kasanen
On Wed, Oct 16, 2013, at 22:23, Harald Becker wrote: GNU wget does kinda cater to this use: you can specify it in the .wgetrc file, but then that's only portable to GNU wget. How about adding limited support for .wgetrc then (only for timeouts)? Just a suggestion ... Support for

Re: [PATCH 1/2] wget: make default timeout configurable, remove a duplicate line

2013-10-15 Thread Lauri Kasanen
On Mon, Oct 14, 2013, at 19:22, Denys Vlasenko wrote: wget: make default timeout configurable Why? Upstream wget uses a fixed default timeout, 900. We'd like to change it in one place instead of adding -T options to a ton of scripts. But this will make your scripts depend on

Re: [PATCH 1/2] wget: make default timeout configurable, remove a duplicate line

2013-10-13 Thread Lauri Kasanen
On Sat, Oct 12, 2013, at 22:48, Denys Vlasenko wrote: Small housekeeping for wget. wget: make default timeout configurable Why? Upstream wget uses a fixed default timeout, 900. We'd like to change it in one place instead of adding -T options to a ton of scripts. Doing it via Kconfig is

[PATCH 1/2] wget: make default timeout configurable, remove a duplicate line

2013-10-08 Thread Lauri Kasanen
Hi, Small housekeeping for wget. - Lauri -- http://www.fastmail.fm - One of many happy users: http://www.fastmail.fm/help/overview_quotes.html From 13755e22b0dc9655d5e5d05c2a0d06873a8ef526 Mon Sep 17 00:00:00 2001 From: Lauri Kasanen cur...@operamail.com Date: Tue, 8 Oct 2013 16:40:20 +0300

[PATCH 2/2] wget: add support for connect timeout

2013-10-08 Thread Lauri Kasanen
-- http://www.fastmail.fm - Or how I learned to stop worrying and love email again From 2a33129f02ce0609ba88e3d4ae98b1bed60654f0 Mon Sep 17 00:00:00 2001 From: Lauri Kasanen cur...@operamail.com Date: Tue, 8 Oct 2013 17:11:22 +0300 Subject: [PATCH 2/2] wget: add support

Kernel build + ash, trap ERR

2013-03-30 Thread Lauri Kasanen
Hi The 3.8 kernel build, in scripts/link-vmlinux.sh, uses #!/bin/sh but requests a trap on ERR. This fails on bb ash: scripts/link-vmlinux.sh: trap: line 105: ERR: invalid signal specification Is this something that ash should support, or is it a kernel bug for using a bash feature in a /bin/sh

[PATCH] sha3sum: New applet, v4

2013-01-10 Thread Lauri Kasanen
showed an actual value. I don't have any idea why that happens there. - Lauri -- http://www.fastmail.fm - Access all of your messages and folders wherever you are From c50a72a34c46e016c9c0962abc64a9682f213e9a Mon Sep 17 00:00:00 2001 From: Lauri Kasanen cur...@operamail.com

Re: [PATCH] sha3sum: New applet, v4

2013-01-10 Thread Lauri Kasanen
On Thu, Jan 10, 2013, at 13:35, Baruch Siach wrote: I just wanted to note the this SHA3 implementation is considerably slower than MD5 and SHA1 of Busybox, when run on my system. Sample results: # ls -l busybox -rwxr-xr-x 1 root root 1296692 Jan 10 11:17 busybox # time ./busybox sha3sum

Re: [PATCH] sha3sum: New applet, v4

2013-01-10 Thread Lauri Kasanen
Yes, from two ways: SHA-3 as an algorithm is 2-3x slower than md5, and the implementation here is optimized for size. There exist faster implementations, but bb usually wants the smallest size. Another point is that on big-endian it now flips to little-endian and back to get correct

Re: [PATCH] sha3sum: New applet, v2

2013-01-08 Thread Lauri Kasanen
# mips64 $ echo Hello World | ./busybox sha3sum bb5596c9990b5e6f821d17150b3c79585180ed05f4570ba82a89816a5680c463d3ce23fa8daff68e0ada7c235e21f619d5fc0e122ee2e5fe959e004742d53ee4 # x86_64 $ echo Hello World | ./busybox sha3sum

Re: [PATCH] sha3sum: New applet, v2

2013-01-08 Thread Lauri Kasanen
A pessimized build give the exact same result. Details below: Thanks Baruch. It's as I thought - something gives it wrong arguments. See here: #1 0x1009dab4 in sha3_hash (state=0xbfca1fc0, data=0x101cafd0 , bytes=21474836485) at libbb/hash_md5_sha.c:1055 bytes is 20 Gb (!), yet the

[PATCH] sha3sum: New applet, v3

2013-01-08 Thread Lauri Kasanen
- The way an email service should be From 864e27f3a01ebff916ade68d5706ad0088bc5b40 Mon Sep 17 00:00:00 2001 From: Lauri Kasanen cur...@operamail.com Date: Thu, 3 Jan 2013 21:10:01 +0200 Subject: [PATCH] sha3sum: New applet, v3 v3: - Align to 64, just in case - Use the correct type, size_t

Re: [PATCH] sha3sum: New applet, v3

2013-01-08 Thread Lauri Kasanen
You can send me a debug prints augmented version of your patch to run on my PowerPC board if you like. Thanks. Before we go to that, is the empty string example also wrong on ppc? echo -n - Lauri -- http://www.fastmail.fm - Send your email first class

Re: [PATCH] sha3sum: New applet, v2

2013-01-06 Thread Lauri Kasanen
On Sun, Jan 6, 2013, at 7:18, Baruch Siach wrote: Hi Lauri, Testing on a big-endian system (PowerPC) I'm getting: # echo test |./busybox sha3sum Segmentation fault (core dumped) On a PC I get: $ echo test |./busybox sha3sum

Re: [PATCH] sha3sum: New applet, v2

2013-01-06 Thread Lauri Kasanen
Well, as mentioned, I don't have such a system. Could you do a debug build (CONFIG_DEBUG=y) and get valgrind output? echo test | valgrind ./busybox_unstripped sha3sum Unfortunately, valgrind does not support this PowerPC variant (e500v2). I'll try gdb and see what I get.

Re: [PATCH] sha3sum: New applet, v2

2013-01-06 Thread Lauri Kasanen
The content of the r28 register is: (gdb) info registers ... r280x10173010 269955088 The process' /proc/[pid]/maps file shows: 1014d000-10173000 rwxp 00:00 0 [heap] which means that we're trying to read just beyond the process allocated heap. From

[PATCH] sha3sum: New applet, v2

2013-01-04 Thread Lauri Kasanen
, just above in the md5 code. The requirement felt kinda weird with those there... -- http://www.fastmail.fm - Same, same, but different... From 84768213e7a004b9e703a1d7091bd43b34822e0c Mon Sep 17 00:00:00 2001 From: Lauri Kasanen cur...@operamail.com Date: Thu, 3 Jan 2013 21:10:01 +0200 Subject

Re: [PATCH] sha3sum: New applet

2013-01-03 Thread Lauri Kasanen
Hi can't you `git send-email` ? attaching patches encoded in base64 makes it a pain to review. Sorry, not at the moment, no usable SMTP server to do that with. seems like you do an xor in the LE case but not the BE case ? i'm guessing that's a bug. I don't have anything big-endian to

Re: su should not chdir

2012-06-12 Thread Lauri Kasanen
Hi Denys Seems this patch by Pascal in March was missed: http://lists.busybox.net/pipermail/busybox/2012-March/077510.html - Lauri -- http://www.fastmail.fm - A no graphics, no pop-ups email service ___ busybox mailing list busybox@busybox.net

Linking fails when httpd gzip is enabled, but seamless gzip not

2012-04-28 Thread Lauri Kasanen
Hi Building bb git master with the attached config, on armv6 gcc 4.4.5, fails linking with: /usr/bin/ld: busybox_unstripped: hidden symbol `check_signature16' isn't defined /usr/bin/ld: final link failed: Nonrepresentable section on output After enabling CONFIG_FEATURE_SEAMLESS_GZ, the build

Re: tcpsvd single-applet build fails

2012-03-19 Thread Lauri Kasanen
Please try attached patch. Works well, thanks. - Lauri -- http://www.fastmail.fm - The way an email service should be ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox

tcpsvd single-applet build fails

2012-03-16 Thread Lauri Kasanen
32-bit x86 gcc 4.6.1 libbb/lib.a(appletlib.o): In function `main': appletlib.c:(.text.main+0x67): undefined reference to `tcpsvd_main' The config is attached. - Lauri -- http://www.fastmail.fm - Access all of your messages and folders wherever you are bb-config

Re: [PATCH] tar: support the common file extensions .tlzma and .txz

2012-03-06 Thread Lauri Kasanen
On Tue, Mar 6, 2012, at 17:02, Denys Vlasenko wrote: I consolidated several copies of autodetection code. One in get_header_tar.c is gone. Now tar recognizes XZ-compressed data using generic setup_unzip_on_fd(). I added a testsuite entry which verifies that. Please try current git. Please

Re: [PATCH] tar: support the common file extensions .tlzma and .txz

2012-03-06 Thread Lauri Kasanen
Thanks, it works well now. Didn't catch anything reading the last few commits. I ran cppcheck on the affected files, and it found one possibly uninitialized use: [decompress_bunzip2.c:156]: (error) Uninitialized variable: runCnt Also, seems the __KERNEL__ ifdefs in the unxz code could be

Re: [PATCH] tar: support the common file extensions .tlzma and .txz

2012-03-01 Thread Lauri Kasanen
I am not convinced .txz and .tlzma extensions are common. (In my opinion, existence of .tgz extension was a mistake). They exist, and GNU tar handles them, so I think bb tar shouldn't puke when it sees one. Busybox does handle .tgz and .tbz2, because they have the magic detection already

  1   2   >