Re: find . -delete gives an error message for the . directory entry

2015-09-26 Thread Matthias Andree
Am 25.09.2015 um 17:01 schrieb Ari Sundholm: > Hello! > > Busybox (git HEAD) seems to give an error when doing a "find . -delete" > within a directory: > > -->8- > ~/busybox/foobarbaz$ ls > ~/busybox/foobarbaz$ find > . > ~/busybox/f

Re: 1.23.0 FreeBSD build fails: 1 showstopper mempcpy(), 1 sendfile() incompat.

2015-02-04 Thread Matthias Andree
Am 02.02.2015 um 13:17 schrieb Denys Vlasenko: > On Mon, Feb 2, 2015 at 3:20 AM, Matthias Andree wrote: >>> Ok, let me restate the question. >>> On which version(s) of FreeBSD do you see lack of mempcpy? >> >> All released versions are affected, and probably m

Re: 1.23.0 FreeBSD build fails: 1 showstopper mempcpy(), 1 sendfile() incompat.

2015-02-01 Thread Matthias Andree
Am 2. Februar 2015 02:32:31 MEZ, schrieb Denys Vlasenko : >On Sun, Feb 1, 2015 at 11:23 AM, Matthias Andree > wrote: >> Am 31. Januar 2015 17:58:40 MEZ, schrieb Denys Vlasenko >> : >>> >>> On Wed, Jan 28, 2015 at 10:50 PM, Matthias Andree > >>> wrot

Re: 1.23.0 FreeBSD build fails: 1 showstopper mempcpy(), 1 sendfile() incompat.

2015-01-29 Thread Matthias Andree
Am 29.01.2015 um 16:40 schrieb Denys Vlasenko: > On Wed, Jan 28, 2015 at 10:50 PM, Matthias Andree wrote: >>> Matthias, please get current git, uncomment this line, >>> and confirm that it builds for you. Let me know the version >>> of FreeBSD which needs it

Re: 1.23.0 FreeBSD build fails: 1 showstopper mempcpy(), 1 sendfile() incompat.

2015-01-28 Thread Matthias Andree
Am 25.01.2015 um 22:10 schrieb Denys Vlasenko: > On Mon, Jan 19, 2015 at 12:47 PM, Bartosz Gołaszewski > wrote: >> 2015-01-18 10:31 GMT+01:00 Matthias Andree : >>> >>> That was the minor part because I can disable it by build configuration. >>> >>&

Re: 1.23.0 FreeBSD build fails: 1 showstopper mempcpy(), 1 sendfile() incompat.

2015-01-18 Thread Matthias Andree
Am 07.01.2015 um 10:11 schrieb Bartosz Gołaszewski: > 2015-01-06 21:55 GMT+01:00 Matthias Andree : >> Happy new year! >> >> I just tried to upgrade the busybox-unstable port on FreeBSD to 1.23.0, >> but one issue of the two given below is a showstopper. >> &

1.23.0 FreeBSD build fails: 1 showstopper mempcpy(), 1 sendfile() incompat.

2015-01-06 Thread Matthias Andree
Happy new year! I just tried to upgrade the busybox-unstable port on FreeBSD to 1.23.0, but one issue of the two given below is a showstopper. The first one pertains to an incompatibility around sendfile. Easily sidestepped by deconfiguring it. > libbb/copyfd.c:12:27: error: sys/sendfile.h: No

Re: 1.22.1 is released

2014-01-23 Thread Matthias Andree
Am 23.01.2014 12:36, schrieb Denys Vlasenko: > On Wed, Jan 22, 2014 at 11:31 PM, Eugene Rudoy wrote: >> just wanted to point out that the patch currently available under >> http://busybox.net/downloads/fixes-1.22.1/busybox-1.22.1-ash.patch is >> not the SHLVL related one but some other one (it see

Re: 1.22.0 builds still broken due to strchrnul mis-declaration on FreeBSD

2014-01-10 Thread Matthias Andree
Am 10.01.2014 11:57, schrieb Denys Vlasenko: > On Thu, Jan 9, 2014 at 8:14 PM, Matthias Andree wrote: >> The attached patch (for git am) achieves all that and enables the >> current busybox Git master to build on FreeBSD without further ado. > > -sed -n -e 's@^//usage:\

Re: 1.22.0 builds still broken due to strchrnul mis-declaration on FreeBSD

2014-01-09 Thread Matthias Andree
Am 09.01.2014 11:11, schrieb Denys Vlasenko: > On Wed, Jan 8, 2014 at 10:33 PM, Matthias Andree wrote: >>> Please try current git. >> >> Better, but still does not work due to use of alloca.h in >> scripts/basic/fixdep.c l. 116 and scripts/basic/docproc.c l. 42. >

Re: 1.22.0 builds still broken due to strchrnul mis-declaration on FreeBSD

2014-01-08 Thread Matthias Andree
Am 08.01.2014 15:26, schrieb Denys Vlasenko: > On Wed, Jan 8, 2014 at 12:34 AM, Matthias Andree wrote: >> Am 07.01.2014 14:09, schrieb Denys Vlasenko: >>> On Tue, Jan 7, 2014 at 1:43 AM, Matthias Andree wrote: >>>> FreeBSD/HEAD fails to build busybox 1.22.0, be

Re: 1.22.0 builds still broken due to strchrnul mis-declaration on FreeBSD

2014-01-07 Thread Matthias Andree
Am 07.01.2014 14:09, schrieb Denys Vlasenko: > On Tue, Jan 7, 2014 at 1:43 AM, Matthias Andree wrote: >> FreeBSD/HEAD fails to build busybox 1.22.0, because busybox's >> strchrnul() declaration is in conflict with FreeBSD's; sources at >> <http://svnweb.free

1.22.0 builds still broken due to strchrnul mis-declaration on FreeBSD (was: [PATCH 1/3] platform: fix missing strchrnul)

2014-01-06 Thread Matthias Andree
FreeBSD/HEAD fails to build busybox 1.22.0, because busybox's strchrnul() declaration is in conflict with FreeBSD's; sources at . There is, unfortunately, no exact version tag that you can test against, but on FreeBSD, you m

Re: [PATCH 1/3] platform: fix missing strchrnul

2013-11-27 Thread Matthias Andree
Am 27.11.2013 12:14, schrieb Daniel Borca: > > > Matthias Andree wrote: >> >> The whole #ifdef approach is massively broken and prone to mis-guess. >> >> It denies one of the most basic considerations, and that is: operating >> systems change over time

Re: [PATCH 1/3] platform: fix missing strchrnul

2013-11-27 Thread Matthias Andree
Am 27.11.2013 02:53, schrieb Daniel Borca: > I was testing on Darwin. More specifically, iPhoneOS6.1.sdk > > Also, http://www.manpagez.com/man/alpha.php?S does not list strchrnul() > > However, > > #if defined(__FreeBSD__) || defined(__APPLE__) > should really be > #if defined(__APPLE__) > > t

Re: SO_BINDTODEVICE is not supported on this system

2013-07-23 Thread Matthias Andree
Am 23.07.2013 11:09, schrieb Lambrecht Jürgen: > On 07/22/2013 05:02 AM, Denys Vlasenko wrote: >> On Thursday 18 July 2013 20:59, Matthias Andree wrote: >>> Am 18.07.2013 16:58, schrieb Lambrecht Jürgen: >>>> On 07/18/2013 12:49 PM, Lambrecht Jürgen wrote: >>

Re: SO_BINDTODEVICE is not supported on this system

2013-07-18 Thread Matthias Andree
Am 18.07.2013 16:58, schrieb Lambrecht Jürgen: > On 07/18/2013 12:49 PM, Lambrecht Jürgen wrote: >> Hi, >> >> I am porting the busybox dhcp server to an RTOS (eCos). eCos uses the >> FreeBSD TCP/IP stack. >> >> I get this message: bb_error_msg("SO_BINDTODEVICE is not supported on >> this system");.

Re: [SOLVED] pidof misses a pid sometimes

2011-12-29 Thread Matthias Andree
Am 29.12.2011 08:55, schrieb Bastian Bittorf: >> pidof: pid:9071 no match: comm:'sh' argv0:'sh' exe:'/bin/bash' >> pidof: pid:9072 no match: comm:'busybox' argv0:'./busybox' >> exe:'/root/srcdevel/bbox/fix/busybox.t2/busybox' >> pidof: pid:9073 no match: comm:'sh' argv0:'sh' exe:'/bin/bash' >> pido

Re: pidof misses a pid sometimes

2011-12-27 Thread Matthias Andree
Am 26.12.2011 15:32, schrieb Bastian Bittorf: > dear embedded warriors, > > we use "BusyBox v1.19.3 (2011-11-24 08:39:59 CET)" > on ar71xx and brcm47xx (mipsel) on openWRT. > > It took us some days to trac down a problem with > pidof. We have some checker scripts, which regulary > watch for tasks

Re: [PATCH] syslogd: Possible endless loop when reinitializing after power loss

2011-10-25 Thread Matthias Andree
Am 25.10.2011 01:57, schrieb Rich Felker: > On Tue, Oct 25, 2011 at 12:52:42AM +0200, Christian Engelmayer wrote: >> Function log_locally() within the syslogd can potentially lock up when >> restarting the daemon after a power loss in case the unplanned shutdown hit >> the >> rename operation duri

Re: new FreeBSD port maintainer

2011-09-11 Thread Matthias Andree
Am 11.09.2011 16:36, schrieb Rich Felker: > The standard also explictly allows #undef to avoid using macros, or > you could change my example to use: > > char *(dirname)(char *); > > And either way, now it is conforming. Either way it avoids the macro expansion, but it still isn't conforming.

Re: [PATCH] reimplement dirname v2

2011-09-11 Thread Matthias Andree
Am 11.09.2011 09:55, schrieb Tito: > There are also two more problems of different behaviour > between linux and freebsd: > 1) freebsd dirname could return NULL on error This is a standards conformance bug to be addressed inside FreeBSD. FreeBSD's dirname() claims conformance to X/Open Issue 4 R

"Strange" patch in Git?

2011-09-11 Thread Matthias Andree
I see this recently changed in shell/hush.c: -# if defined MAX_HISTORY && MAX_HISTORY > 0 && ENABLE_HUSH_SAVEHISTORY +# if MAX_HISTORY > 0 && ENABLE_HUSH_SAVEHISTORY Is it guaranteed that MAX_HISTORY is always defined? Is it desired that compilation fails if it undefined? If not, the warning-fr

Re: new FreeBSD port maintainer

2011-09-10 Thread Matthias Andree
Am 10.09.2011 22:57, schrieb Rich Felker: > On Sat, Sep 10, 2011 at 10:30:45PM +0200, Matthias Andree wrote: >> Am 10.09.2011 20:33, schrieb Laurent Bercot: >>>>> #if !defined __FreeBSD__ >>>>> char *dirname(char *path); >>>>> #endif >&g

Re: new FreeBSD port maintainer

2011-09-10 Thread Matthias Andree
Am 10.09.2011 13:49, schrieb Denys Vlasenko: > On Saturday 10 September 2011 12:57, Matthias Andree wrote: >> Am 10.09.2011 04:31, schrieb Denys Vlasenko: >>> On Thursday 14 July 2011 11:57, Matthias Andree wrote: >>>> - Is there a particular reason the sed

Re: new FreeBSD port maintainer

2011-09-10 Thread Matthias Andree
Am 10.09.2011 20:33, schrieb Laurent Bercot: >>> #if !defined __FreeBSD__ >>> char *dirname(char *path); >>> #endif >>> Can you confirm that it helps? >> It's bogus because ours is const char *. > > FreeBSD defines dirname as a different function from the standard > and then *busybox* is bogus ?

Re: new FreeBSD port maintainer

2011-09-10 Thread Matthias Andree
Am 10.09.2011 04:31, schrieb Denys Vlasenko: > On Thursday 14 July 2011 11:57, Matthias Andree wrote: >> - Is there a particular reason the sed scripts use GNU extensions or >> syntax? What are the chances of these being replaced by POSIX default >> constructs (If none, add:

Re: [PATCH] reimplement dirname v2

2011-09-10 Thread Matthias Andree
Am 09.09.2011 23:17, schrieb Tito: > On Friday 09 September 2011 17:43:08 you wrote: >> On Wed, Sep 7, 2011 at 10:29 PM, Tito wrote: >>> Ops...and now with text :-) >>> >>> Hi, >>> in my attempt to reinvent the wheel I've come up >>> with a nice implementation of dirname for busybox. >>> The pros

Re: [PATCH] reimplement dirname v2

2011-09-10 Thread Matthias Andree
Am 08.09.2011 22:24, schrieb Tito: > On Thursday 08 September 2011 18:11:22 Matthias Andree wrote: >> If libc has a good dirname() implementation it should be used. Please >> make that configurable and have it default to off on (e)glibc and FreeBSD. > > Hi, > not that I t

Re: [PATCH] reimplement dirname v2

2011-09-08 Thread Matthias Andree
If libc has a good dirname() implementation it should be used. Please make that configurable and have it default to off on (e)glibc and FreeBSD. ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox

Re: Assorted bug reports with a few fixes for busybox 1.19.0 - dirname

2011-08-30 Thread Matthias Andree
Am 29.08.2011 07:57, schrieb Tito: [on reimplementation of basename()/dirname()] > because we already have alternative basename implementations > in libbb get_last_path_component.c that could be used/fixed/extended > to remove the few basename occurences (if there are any) > and with an alternati

Re: Assorted bug reports with a few fixes for busybox 1.19.0 - dirname

2011-08-28 Thread Matthias Andree
Am 29.08.2011 02:01, schrieb Tito: > Hi, > attached a alternative version of dirname() > so that we don't need libgen.h for it. > Tested only with dirname applet and seems to work. > Needs to be tested with other code where it is called. > Hints, critics and improvements are welcome. Why the effor

Re: Assorted bug reports with a few fixes for busybox 1.19.0

2011-08-28 Thread Matthias Andree
Am 28.08.2011 05:41, schrieb Denys Vlasenko: > On Friday 26 August 2011 03:34, Matthias Andree wrote: >> - in kconfig, note that #define _XOPEN_SOURCE 700 prevents the >> definition of SIGWINCH on FreeBSD, as that's a BSD-specific signal. >> I don't know what

Assorted bug reports with a few fixes for busybox 1.19.0

2011-08-26 Thread Matthias Andree
Greetings, during update of the busybox port on FreeBSD to 1.19.0, I found these issues and am attaching patches that I propose for inclusion upstream: - platform.h: FreeBSD doesn't provide the _unlocked stdio.h garbage. Disable. - match_fstype.c: depends on mntent.h being availabl

Re: [PATCH] improve checks on usernames V3.

2011-08-10 Thread Matthias Andree
Am 10.08.2011 12:43, schrieb Denys Vlasenko: > Tried it. Bloatcheck: > > function old new delta > next_token 842 912 +70 > parse_dollar 731 782 +51 >

Re: [PATCH] improve checks on usernames V3.

2011-08-10 Thread Matthias Andree
Am 10.08.2011 13:24, schrieb Harald Becker: > Hallo Denys! > >> On Tue, Aug 9, 2011 at 7:33 PM, Rich Felker wrote: >>> On Tue, Aug 09, 2011 at 09:37:58AM +0200, Denys Vlasenko wrote: #define isalnum(a) bb_ascii_isalnum(a) static ALWAYS_INLINE int bb_ascii_isalnum(unsigned char a)

Re: [PATCH] improve checks on usernames V3.

2011-08-09 Thread Matthias Andree
Am 09.08.2011 19:33, schrieb Rich Felker: > On Tue, Aug 09, 2011 at 09:37:58AM +0200, Denys Vlasenko wrote: >> #define isalnum(a) bb_ascii_isalnum(a) >> static ALWAYS_INLINE int bb_ascii_isalnum(unsigned char a) >> { >> unsigned char b = a - '0'; >> if (b <= 9) >> re

Re: enforce maxlength in usernames

2011-07-28 Thread Matthias Andree
Am 28.07.2011 14:12, schrieb Tito: > OK, I see. One more try. Eventually we could substitute LOGIN_NAME_MAX > with 64 as suggested or with 32 as in man useradd. Hints > for a better error message are welcome. man useradd is irrelevant, as would the higher-level man adduser be. These are nonstanda

Re: enforce maxlength in usernames

2011-07-28 Thread Matthias Andree
Am 27.07.2011 23:12, schrieb Tito: > On Wednesday 27 July 2011 22:33:09 Matthias Andree wrote: >> Am 27.07.2011 21:56, schrieb Tito: >> >>> Saying that it does not belong there is not enough, please tell me also >>> where it should be. Looked like a good place to

Re: enforce maxlength in usernames (was: [PATCH] enforce maxlenght in usernames)

2011-07-27 Thread Matthias Andree
Am 27.07.2011 21:56, schrieb Tito: > Saying that it does not belong there is not enough, please tell me also > where it should be. Looked like a good place to me. In the same > function we check for illegal chars in usernames. You should also take > into account that busybox does not support conf

Re: [PATCH] enforce maxlenght in usernames

2011-07-27 Thread Matthias Andree
Am 27.07.2011 21:33, schrieb Tito: > Hi, > while reading man useradd on my box I stumbles across this line: > > Usernames may only be up to 32 characters long. > > > So it seems to be a good idea to enforce this also in busybox. > I've added the relevant code to the die_if_bad_username libb func

secure programming (was: [PATCH] users: new applet)

2011-07-27 Thread Matthias Andree
Am 27.07.2011 15:26, schrieb gotru...@gmail.com: > On Wed, Jul 27, 2011 at 3:23 PM, Matthias Andree wrote: >> Am 27.07.2011 13:19, schrieb gotru...@gmail.com: >> >>> It was about saving bytes but ok, revised patch attached. >> >> Trading a dozen bytes for secu

Re: [PATCH] users: new applet

2011-07-27 Thread Matthias Andree
Am 27.07.2011 10:29, schrieb Tito: > On Wednesday 27 July 2011 00:33:37 gotru...@gmail.com wrote: >> Hi, >> >> patch attached. >> >> Regards, >> > > Hi, > printf(ut->ut_user); maybe adding a format string here would be a good thing. > BTW.: this code looks very similar to what the who applet does

Re: new FreeBSD port maintainer

2011-07-14 Thread Matthias Andree
Am 14.07.2011 11:57, schrieb Matthias Andree: > - Why do parts of the package use #include ? Sorry, I meant but mistyped . ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox

new FreeBSD port maintainer

2011-07-14 Thread Matthias Andree
Greetings, I am a FreeBSD ports committer and have taken over maintaining the FreeBSD busybox port from Chris Rees. I have updated the FreeBSD port to 1.18.5 and a couple of questions: - Why do parts of the package use #include ? - Is there a particular reason the sed scripts use GNU extensions