Re: [PATCH] ares_parse_txt_reply: add `record_start` field

2016-02-01 Thread Fedor Indutny
Thank you, Daniel. Hopefully, I have fixed all mentioned nits. I tried to do my best on the documentation, but please forgive me some grammar issues since I am not a native english speaker. If you have any other suggestions with regards to either code, docs, or both. I will be more than happy to

Re: [PATCH] ares_parse_txt_reply: add `record_start` field

2016-02-01 Thread Daniel Stenberg
On Mon, 1 Feb 2016, Fedor Indutny wrote: I have made fixes to the patch from 2015-03-21, according to your comments. Please take a look. Two comments from me: 1. Please don't refer to source code file names in ares.h. That's a public header file and users of c-ares will read that and have n

Re: [PATCH] ares_parse_txt_reply: add `record_start` field

2016-02-01 Thread Fedor Indutny
Hello David, I have made fixes to the patch from 2015-03-21, according to your comments. Please take a look. Thank you! On Mon, Feb 1, 2016 at 11:12 AM, David Drysdale wrote: > The first version of the patch still has the problem that it changes the > size of > an existing structure and thus

Re: [PATCH] extension to ares_txt_reply parsing

2016-02-01 Thread bdoetsch
Thanks Dave, Yes, the patch from 2015-03-21 will work for me as well. Let's go for it! B From: c-ares on behalf of David Drysdale Reply-To: c-ares hacking Date: Monday, February 1, 2016 at 10:31 AM To: c-ares hacking Subject: Re: [PATCH] extension to ares_txt_reply parsing On Thu,

Re: [PATCH] extension to ares_txt_reply parsing

2016-02-01 Thread David Drysdale
On Thu, Jan 28, 2016 at 11:42 PM, bdoetsch wrote: > > @Fedor -- I think you and I are trying to get the same result, a TXT > parsing routine that clearly delineates between TXT chunk components. > Hopefully this submission can help us both. > Hi Brady, By the way, did you take a look at Fedor's