Thank you, Daniel. Hopefully, I have fixed all mentioned nits. I tried to do my best on the documentation, but please forgive me some grammar issues since I am not a native english speaker.
If you have any other suggestions with regards to either code, docs, or both. I will be more than happy to put them into the patch. Thanks again, Fedor. On Mon, Feb 1, 2016 at 5:29 PM, Daniel Stenberg <dan...@haxx.se> wrote: > On Mon, 1 Feb 2016, Fedor Indutny wrote: > > I have made fixes to the patch from 2015-03-21, according to your comments. >> >> Please take a look. >> > > Two comments from me: > > 1. Please don't refer to source code file names in ares.h. That's a public > header file and users of c-ares will read that and have no idea about the > specific source file or what we're talking about. You could of course still > explain that the new struct is a superset of the old one. > > 2. Regarding the documentation/functionality. The new man page paragraph > says: > > "Continuations are linked using next pointer field in the structure" > > (I think it should say "*the* next pointer...") > > ... but it doesn't really explain how it works with any details. Should > the user then consider the 'txt' areas to be joined? I don't think we can > presume users will understand what a continuation is if we don't explain it! > > -- > > / daniel.haxx.se >
-----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAABAgAGBQJWr+WSAAoJENcGPM4Zt+iQvngP/idVfiEeFDHGUrpYlwn9YzI2 7mhTMUYIZTkhwmtMsQEJyymCiTMrSKXi/Qn9RV694dt3iM0xYBLOZUGfHACA3+4r oQ4h7yldd/Bi2XlO0azD/mtX8mNBom8htqlLrju+Oo35Ch037XbI3DHQA7+1MQtW h7dmx7b4qzSJPXu7iGmY1aWxSCKPD7HoPJs/4jUM/FTcm6ND2BRiUCO8b1O6znO7 OlicynED80TfCMRs0CKTup/mpkbIf8gd5YpakZtHkAVHqf7jNwldHd4I9wN5nlh5 ZPSNwJx9t9hDbTro1oAo9c11a/DOz6UWs5HdzgIWCq8a7CGBESDeWHAzU0N0VsKY VCnqARsrBGULhhnV7obmcMnD8/tRj8ux4Xxgww/kbW3cTxCdRHBpKWgdu6KJqRj8 rxtQwiUDmxZ3djpId3vLWFPa/HDxXUH1KcM2CJ0UN46mffzmVSU+6Q5xoDSAYlvr PvHCYG/jPCVFZ6qXED3/KR+HyXV9pRdeCVMX+lUVDNRWzKVEmt4wJ0w2h8ja8uii ekNnTAv+5H4rW4DGKXC+sX1cSAgqg/DB/BUyNrdh4amJqpMZqhnPxNLwlwa0NPqe QeU6pL463sg0kzPwJU3RDYMEZbrjWCphkzwNXmtBAhBg1WY6BUJXPb4h0zpNsLBS JD3NVFhSm63KsRFBrKd9 =Hneg -----END PGP SIGNATURE-----
0001-txt-introduce-ares_parse_txt_reply_ex.patch
Description: Binary data
