Re: Review Request: autocorrect config file lookup change

2012-11-07 Thread C. Boemann
> On Nov. 6, 2012, 6:04 p.m., Laurent Montel wrote: > > plugins/textediting/autocorrection/Autocorrect.cpp, line 707 > > > > > > You never breaks here ? > > So you will read a lot of file no ? > > C. Boemann wr

Re: Review Request: autocorrect config file lookup change

2012-11-07 Thread Laurent Montel
> On Nov. 6, 2012, 6:04 p.m., Laurent Montel wrote: > > plugins/textediting/autocorrection/Autocorrect.cpp, line 707 > > > > > > You never breaks here ? > > So you will read a lot of file no ? > > C. Boemann wr

Re: Review Request: autocorrect config file lookup change

2012-11-07 Thread C. Boemann
> On Nov. 6, 2012, 6:04 p.m., Laurent Montel wrote: > > plugins/textediting/autocorrection/Autocorrect.cpp, line 707 > > > > > > You never breaks here ? > > So you will read a lot of file no ? > > C. Boemann wr

Re: Review Request: autocorrect config file lookup change

2012-11-07 Thread Laurent Montel
> On Nov. 6, 2012, 6:04 p.m., Laurent Montel wrote: > > plugins/textediting/autocorrection/Autocorrect.cpp, line 707 > > > > > > You never breaks here ? > > So you will read a lot of file no ? > > C. Boemann wr

Review Request: Changing main.cpp to use KApplication in calligra active

2012-11-07 Thread Sujith Haridasan
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107244/ --- Review request for Calligra and Shantanu Tushar. Description --- Movi

Re: Review Request: Changing main.cpp to use KApplication in calligra active

2012-11-07 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107244/#review21555 --- active/main.cpp

Re: Review Request: Changing main.cpp to use KApplication in calligra active

2012-11-07 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107244/#review21557 --- active/main.cpp

Re: Review Request: Changing main.cpp to use KApplication in calligra active

2012-11-07 Thread Sujith Haridasan
> On Nov. 7, 2012, 2:27 p.m., Boudewijn Rempt wrote: > > active/main.cpp, line 53 > > > > > > Doesn't this change break opening a file from an argument? Also -- why > > create the MainWindow on the heap now? It did

Re: Review Request: autocorrect config file lookup change

2012-11-07 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107229/ --- (Updated Nov. 7, 2012, 5:04 p.m.) Review request for Calligra and Laurent

Re: Review Request: autocorrect config file lookup change

2012-11-07 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107229/#review21569 --- plugins/textediting/autocorrection/Autocorrect.cpp

Re: Review Request: autocorrect config file lookup change

2012-11-07 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107229/#review21571 --- plugins/textediting/autocorrection/Autocorrect.cpp

Re: Review Request: autocorrect config file lookup change

2012-11-07 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107229/#review21572 --- plugins/textediting/autocorrection/Autocorrect.cpp

Re: Review Request: autocorrect config file lookup change

2012-11-07 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107229/ --- (Updated Nov. 7, 2012, 5:20 p.m.) Review request for Calligra and Laurent

Re: Review Request: autocorrect config file lookup change

2012-11-07 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107229/#review21573 --- Ship it! Seems good for me. Will adapt kmail soon. Regards -

Re: Review Request: autocorrect config file lookup change

2012-11-07 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107229/#review21576 --- This review has been submitted with commit 1d25b420a43bc23da1a

Re: Review Request: Changing main.cpp to use KApplication in calligra active

2012-11-07 Thread Sujith Haridasan
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107244/ --- (Updated Nov. 7, 2012, 6:11 p.m.) Review request for Calligra and Shantanu

Re: Review Request: Changing main.cpp to use KApplication in calligra active

2012-11-07 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107244/#review21587 --- active/main.cpp

Re: Review Request: Kexi Tables/Forms: show indication that edited or pasted text is trimmed

2012-11-07 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107068/ --- (Updated Nov. 7, 2012, 8:59 p.m.) Review request for Calligra, Adam Pigg,

Re: Review Request: Kexi Tables/Forms: show indication that edited or pasted text is trimmed

2012-11-07 Thread Dimitrios Tanis
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107068/#review21598 --- Ship it! Ship It! - Dimitrios Tanis On Nov. 7, 2012, 8:59 p

Re: Review Request: Kexi Tables/Forms: show indication that edited or pasted text is trimmed

2012-11-07 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107068/#review21599 --- This review has been submitted with commit 5a045908fb47dec17f2

Re: Review Request: Kexi Tables/Forms: show indication that edited or pasted text is trimmed

2012-11-07 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107068/#review21600 --- This review has been submitted with commit c4bf842347421f20b75