st int KOREPORT_ITEM_RECT_DEFAULT_HEIGHT = 100;
in KoReportDesignerItemRectBase.h or so?
- Jarosław Staniek
On Nov. 1, 2014, 6:10 p.m., Wojciech Kosowicz wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
<https://git.reviewboard.kde.org/r/120634/#comment48808>
Shouldn't be tempReleasePointY and y() in next line?
I't clear when tested with non-square geometries (e.g. barcode).
- Jarosław Staniek
On Nov. 1, 2014, 6:10 p.m., Wojciec
elements work
Thanks,
Jarosław Staniek
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
5d80a023abc3fd9d4c7bc76699b711be0ffbfcc4
Diff: https://git.reviewboard.kde.org/r/120964/diff/
Testing
---
plugin loads and elements work
Thanks,
Jarosław Staniek
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
-7340fc863e9f__title-focus.png
Thanks,
Jarosław Staniek
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
i/plugins/importexport/csv/kexicsvimportdialog.cpp
<https://git.reviewboard.kde.org/r/120940/#comment48880>
S_COMMENT makes sense here and in 1161 too, right?
think what state should be set here
kexi/plugins/importexport/csv/kexicsvimportdialog.cpp
<https://git.reviewboard.kde.o
Button.cpp
<https://git.reviewboard.kde.org/r/119222/#comment48889>
Let's use QPixmap::size() instead of hardcoding
- Jarosław Staniek
On Nov. 3, 2014, 8:49 p.m., Adam Pigg wrote:
>
> ---
> This is an automatically gener
kexi/main/KexiMenuWidget_p.h 2463b9b30c4f7c55cec061da5f3602af4d78df79
Diff: https://git.reviewboard.kde.org/r/121088/diff/
Testing
---
Logo well displayed regardless of the menu height.
Thanks,
Jarosław Staniek
___
calligra-devel mailing
/KexiMenuWidget_p.h 2463b9b
Diff: https://git.reviewboard.kde.org/r/121088/diff/
Testing
---
Logo well displayed regardless of the menu height.
Thanks,
Jarosław Staniek
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org
https://git.reviewboard.kde.org/media/uploaded/files/2014/11/04/3c2e503c-50ad-47b3-a751-7340fc863e9f__title-focus.png
Thanks,
Jarosław Staniek
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
ław Staniek
On Nov. 12, 2014, 11:51 p.m., Adam Pigg wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119222/
> ---
>
> (Updated Nov. 12, 2014, 11:51 p.m.)
>
>
> Rev
kexi/main/KexiMenuWidget.cpp 6acd27e
kexi/main/KexiMenuWidget_p.h 2463b9b
Diff: https://git.reviewboard.kde.org/r/121088/diff/
Testing
---
Logo well displayed regardless of the menu height.
Thanks,
Jarosław Staniek
___
calligra-devel mailing
> On July 11, 2014, 12:25 a.m., Jarosław Staniek wrote:
> > libs/koreport/items/label/KoReportDesignerItemLabel.cpp, line 189
> > <https://git.reviewboard.kde.org/r/119222/diff/1/?file=289614#file289614line189>
> >
> > can be called once, move t
-
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121088/#review70401
---
On Nov. 16, 2014, 10:34 p.m., Jarosław Staniek wrote:
>
>
main menu
Diffs (updated)
-
kexi/main/KexiMenuWidget.h f5b418e
kexi/main/KexiMenuWidget.cpp 6acd27e
kexi/main/KexiMenuWidget_p.h 2463b9b
Diff: https://git.reviewboard.kde.org/r/121088/diff/
Testing
---
Logo well displayed regardless of the menu height.
Thanks,
Jarosław
--
The dialog with the What's This box
https://git.reviewboard.kde.org/media/uploaded/files/2014/11/17/e666191e-2f5c-4d2b-ae45-45b5fc34c4d7__savepwd.png
Thanks,
Jarosław Staniek
___
calligra-devel mailing list
calligra-devel@kde.org
Not fixed
DEFECT19 Exiting the inline editing mode (actually only possible by
clicking the LabelEditButton again) should keep the label element selected.
Currently the parent section gets selected (visible in property editor).
Fixed!
New: DEFECT20: Escape key should undo editing, now it a
> On Nov. 13, 2014, 11:36 a.m., Jarosław Staniek wrote:
> > libs/koreport/items/label/BoundedTextItem.cpp, line 43
> > <https://git.reviewboard.kde.org/r/119222/diff/6-7/?file=325068#file325068line43>
> >
> > Why QPalette::Background? It's the same a
perty editor).
> >
> > Fixed!
> >
> >
> > New: DEFECT20: Escape key should undo editing, now it accepts (nonintuitive
> > behaviour)
> >
> > New: DEFECT21: Property editor's Caption property is not updated in real
> > time while I
Diffs
-
kexi/main/KexiMenuWidget.h f5b418e
kexi/main/KexiMenuWidget.cpp 6acd27e
kexi/main/KexiMenuWidget_p.h 2463b9b
Diff: https://git.reviewboard.kde.org/r/121088/diff/
Testing
---
Logo well displayed regardless of the menu height.
Thanks,
Jarosław Staniek
04456990c1404
Diff: https://git.reviewboard.kde.org/r/121174/diff/
Testing
---
Creation works as before
Thanks,
Jarosław Staniek
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
)
-
kexi/main/startup/KexiStartupFileHandler.cpp ff483e7
kexi/main/startup/KexiStartupFileHandler.h d203bb4
kexi/main/startup/KexiNewProjectAssistant.cpp 633d919
Diff: https://git.reviewboard.kde.org/r/121174/diff/
Testing
---
Creation works as before
Thank
kexi/main/startup/KexiNewProjectAssistant.cpp 633d919
Diff: https://git.reviewboard.kde.org/r/121174/diff/
Testing
---
Creation works as before
Thanks,
Jarosław Staniek
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.
ff483e7
kexi/main/startup/KexiStartupFileHandler.h d203bb4
kexi/main/startup/KexiNewProjectAssistant.cpp 633d919
Diff: https://git.reviewboard.kde.org/r/121174/diff/
Testing
---
Creation works as before
Thanks,
Jarosław Staniek
___
calligr
2d7099d430685e250ef8c42f2bd12825f65bacab
Diff: https://git.reviewboard.kde.org/r/121237/diff/
Testing
---
Run with various Qt styles, looks better
Thanks,
Jarosław Staniek
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org
reply, visit:
https://git.reviewboard.kde.org/r/120910/#review70875
-------
On Oct. 31, 2014, 12:25 a.m., Jarosław Staniek wrote:
>
> ---
> This is an automatically
/kexiactionselectiondialog.cpp
1527152252fa3a344f5197ff03fd9b0cf67b9af3
kexi/formeditor/kexiactionselectiondialog_p.h
161dcb00785f92d871fafdd7b97d709904d515ad
Diff: https://git.reviewboard.kde.org/r/120910/diff/
Testing
---
looks better
Thanks,
Jarosław Staniek
same
>
>
> File Attachments
>
>
> The dialog with the What's This box
>
> https://git.reviewboard.kde.org/media/uploaded/files/2014/11/17/e666191e-2f5c-4d2b-ae45-45b5fc34c4d7__savepwd.png
>
>
> Thanks,
>
> Jarosław Staniek
>
>
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
g/r/121156/diff/
Testing
---
Dialog improved, overall features the same
File Attachments
The dialog with the What's This box
https://git.reviewboard.kde.org/media/uploaded/files/2014/11/17/e666191e-2f5c-4d2b-ae45-45b5fc34c4d7__savepwd.png
Thank
r you.
- Jarosław Staniek
On Nov. 20, 2014, 12:06 a.m., Stephen Leibowitz wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard
---
tested by building with tests
Thanks,
Jarosław Staniek
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
ttps://git.reviewboard.kde.org/r/119222/#comment49597>
Better, now we're catching clicks on the section's surface. But what if we
clicked on another item, ie. itemAt(e->scenePos()) != 0?
Then the previous editing isn't cancelled:
http://i.imgur.com/ZdyVaV1.pn
can assume appearance improvements fixe bug 341150 too
Diffs
-
kexi/main/KexiMainWindow_p.h 2d7099d430685e250ef8c42f2bd12825f65bacab
Diff: https://git.reviewboard.kde.org/r/121237/diff/
Testing
---
Run with various Qt styles, looks better
Thanks,
Jarosław Staniek
convenient since we're only implementing them in one element so far.
- Jarosław Staniek
On Nov. 29, 2014, 7:04 p.m., Adam Pigg wrote:
>
> ---
> This is an automatically
-
>
> (Updated Nov. 29, 2014, 7:04 p.m.)
>
>
> Review request for Calligra and Jarosław Staniek.
>
>
> Bugs: 336825
> http://bugs.kde.org/show_bug.cgi?id=336825
>
>
> Repository: calligra
>
>
> Description
> ---
>
avoid multiplication
everywhere?
libs/koreport/renderer/KoReportPrintRenderer.cpp
<https://git.reviewboard.kde.org/r/121281/#comment49661>
1. For better portability:
double -> qreal
2. Move this line out of the loop.
- Jarosław Staniek
On Nov. 28, 2014, 8:52 p.m., A
org/r/119222/
> ---
>
> (Updated Nov. 29, 2014, 11:37 p.m.)
>
>
> Review request for Calligra and Jarosław Staniek.
>
>
> Bugs: 336825
> http://bugs.kde.org/show_bug.cgi?id=336825
>
>
> Repository: calligra
>
>
> Description
> ---
>
> Usage:
e use QPainter::scale() transformation in one place to avoid "* scale"
multiplication everywhere?
I thought the QPainter::scale() setting also affects the line width, what's
what we want too. Are you willing to experiment?
- Jarosław Staniek
On Nov. 30, 2014, 9:05 p
...
- Jarosław Staniek
On Nov. 30, 2014, 9:05 p.m., Adam Pigg wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
ly generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121237/#review71218
---
On Nov. 28, 2014, 10:07 p.m., Jarosław Staniek wrote:
>
> ---
> This is an automat
better
Thanks,
Jarosław Staniek
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
w.cpp d61f955b340091952212da7bc1f58af3fde3b380
kexi/main/KexiMainWindow.h 13532b8fd234be71f76069f95bb8bfb2162d9de7
Diff: https://git.reviewboard.kde.org/r/121321/diff/
Testing
---
Works OK for any combination of file/server projects
Thanks,
Jarosław St
r any combination of file/server projects
Thanks,
Jarosław Staniek
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
> On Oct. 30, 2014, 8:11 p.m., Adam Pigg wrote:
> > What does it look like with a scroll bar? Where are the button actions
> > gone from the top?
>
> Jarosław Staniek wrote:
> http://wstaw.org/m/2014/10/30/plasma-desktopxB1834.png
>
> These are k
://git.reviewboard.kde.org/media/uploaded/files/2014/10/30/fabd15f3-00eb-4b83-bd28-b26c2fcce5cc__2.png
Thanks,
Jarosław Staniek
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120033/#review71537
---
What's new with this Radek?
- Jarosław Staniek
On Se
tasks for Kexi Mobile
with Qt Quick 2 and Qt Quick Controls. Then entire GUI would be made of the
Controls.
- Jarosław Staniek
On March 24, 2014, 10:44 p.m., Adam Pigg wrote:
>
> ---
> This is an automatically generated e-mail.
ctAssistant.cpp
78a3e08c6248a18a2c1d150676fe0bcf1118846e
Diff: https://git.reviewboard.kde.org/r/121389/diff/
Testing
---
Works OK for any combination of file/server projects
Thanks,
Jarosław Staniek
___
calligra-devel mailing list
calligra-devel@kde.org
https
d62cf2f5bf
kexi/main/startup/KexiNewProjectAssistant.cpp
78a3e08c6248a18a2c1d150676fe0bcf1118846e
Diff: https://git.reviewboard.kde.org/r/121389/diff/
Testing
---
Works OK for any combination of file/server projects
Thanks,
Jarosław Staniek
/KexiPropertyPaneViewBase.cpp
bd63b721f3681aef2b89e7c8aa67b4291493ce46
kexi/core/KexiView.cpp 64615f51a4ca9bd6d47f9cd9d277ef4c8a2dd5ec
Diff: https://git.reviewboard.kde.org/r/121420/diff/
Testing
---
All previous functionality still present
Thanks,
Jarosław Staniek
://git.reviewboard.kde.org/r/121420/diff/
Testing
---
All previous functionality still present
Thanks,
Jarosław Staniek
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
ail. To reply, visit:
> https://git.reviewboard.kde.org/r/121509/
> ---
>
> (Updated Dec. 14, 2014, 4:28 p.m.)
>
>
> Review request for Calligra, Adam Pigg and Jarosław Staniek.
>
>
> Repository: calligra
>
>
>
the
PATH changes.
- Jarosław Staniek
On Dec. 14, 2014, 4:28 p.m., Radosław Wicik wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewb
* variables? What's minimal
version accordint to your test?
- Jarosław Staniek
On Dec. 16, 2014, 11:26 p.m., Radosław Wicik wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard
org/r/121509/
> ---
>
> (Updated Dec. 19, 2014, 11:12 p.m.)
>
>
> Review request for Calligra, Adam Pigg and Jarosław Staniek.
>
>
> Repository: calligra
>
>
> Description
> ---
>
> CMake module for detecting Marble with versi
Diffs
-
Diff: https://git.reviewboard.kde.org/r/121625/diff/
Testing
---
Tested on tables and query designer: functional
Thanks,
Jarosław Staniek
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
irecordnavigator.cpp dd47b2c
libs/db/tableviewcolumn.h f2370bc
kexi/plugins/tables/kexitabledesigner_dataview.h ea9aba0
kexi/CMakeLists.txt 55eac5b
Diff: https://git.reviewboard.kde.org/r/121625/diff/
Testing
---
Tested on tables and query designer: functional
://community.kde.org/Kexi/Porting_to_Qt%26KDE_4#Table_View
- Jarosław Staniek
On Dec. 21, 2014, 11:27 p.m., Jarosław Staniek wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
de.org/r/120935/#comment50510>
Per convention, QString() is enough instead of ""
plugins/reporting/barcode/KoReportDesignerItemBarcode.cpp
<https://git.reviewboard.kde.org/r/120935/#comment50511>
Per convention, QString() is enough instead of ""
plugin
--
Tested with large .kexi files; these methods are used there and Kexi still
works OK
Thanks,
Jarosław Staniek
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
/121625/#review72566
-------
On Dec. 29, 2014, 10:28 p.m., Jarosław Staniek wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kd
esigner: functional
Thanks,
Jarosław Staniek
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
jectAssistant.h
25b4705b303966e14c1e5db7cc3126d62cf2f5bf
kexi/main/startup/KexiNewProjectAssistant.cpp
78a3e08c6248a18a2c1d150676fe0bcf1118846e
Diff: https://git.reviewboard.kde.org/r/121389/diff/
Testing
---
Works OK for any combination of file/server projects
Thanks,
J
previous functionality still present
Thanks,
Jarosław Staniek
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
bs/db/utils.cpp 923a401f7f4265d19c699db3d35046f21914747f
Diff: https://git.reviewboard.kde.org/r/121655/diff/
Testing
---
Tested with large .kexi files; these methods are used there and Kexi still
works OK
Thanks,
Jarosław Staniek
___
calligra-devel mailing list
calligra-deve
org/r/121625/#review72874
---
On Dec. 29, 2014, 10:28 p.m., Jarosław Staniek wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> htt
> On Jan. 1, 2015, 8:18 p.m., Friedrich W. H. Kossebau wrote:
> > Added some more defects I found on the wiki page. Looking into header not
> > resizing currently.
>
> Jarosław Staniek wrote:
> Thanks, categorized them now to major/minor/wishes. Do you thin
kexi/pics/tableview_pen.png f91eacf63e604300ca563a48bd749cde5d33cb6c
kexi/CMakeLists.txt 55eac5b
kexi/formeditor/connectiondialog.h 627499e
kexi/formeditor/connectiondialog.cpp 469e78a
Diff: https://git.reviewboard.kde.org/r/121625/diff/
Testing
---
Tested on tables and query designer: functional
/dataviewcommon/kexidataawareobjectiface.h
24cfa546324e3fa65fb8d5b36bf3e26f66bd47c3
Diff: https://git.reviewboard.kde.org/r/121793/diff/
Testing
---
The issue disappeared in data table views
Thanks,
Jarosław Staniek
___
calligra-devel mailing list
message please list all classes
removed in case we'll want to find them for reference later.
kexi/plugins/forms/CMakeLists.txt
<https://git.reviewboard.kde.org/r/121868/#comment50916>
extra tabs not needed
- Jarosław Staniek
On Jan. 5, 2015, 9:38 p.m., Adam
and a few other themes, plus all relevant GUIs
File Attachments
Welcome Screen with refreshed icons
https://git.reviewboard.kde.org/media/uploaded/files/2015/01/05/252a3b9a-02cd-40d2-9584-143d401c2b71__kexi-2.9-breeze-icons.png
Thanks,
J
rd to shorten it :) Maybe one day...
- Jarosław
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121793/#review73413
---
On Jan. 2, 2015,
,
Jarosław Staniek
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
g headers appear
OK soon.
Thanks so much for the review!
- Jarosław
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121874/#review73429
--------
-02cd-40d2-9584-143d401c2b71__kexi-2.9-breeze-icons.png
Thanks,
Jarosław Staniek
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
sting
---
Checked with tables/queries/forms/reports and various styles
File Attachments
The navigator
https://git.reviewboard.kde.org/media/uploaded/files/2015/01/09/806686d1-7680-434a-b2be-52a3b03a1275__d7AloPW.png
Thanks,
Jarosław St
media/uploaded/files/2015/01/09/806686d1-7680-434a-b2be-52a3b03a1275__d7AloPW.png
Thanks,
Jarosław Staniek
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
W.png
Thanks,
Jarosław Staniek
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120935/#review73658
---
Ship it!
Good Job!
- Jarosław Staniek
On Jan. 4, 2015, 10
files/2015/01/09/806686d1-7680-434a-b2be-52a3b03a1275__d7AloPW.png
Thanks,
Jarosław Staniek
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
bility fix)
Diffs
-
kexi/widget/dataviewcommon/kexidataawareobjectiface.cpp
aeaf7175feed04568d55b6f0410c66d431a27060
Diff: https://git.reviewboard.kde.org/r/122021/diff/
Testing
---
Editable table views work
Thanks,
Jarosław Staniek
__
<https://git.reviewboard.kde.org/r/122021/#comment51371>
int columnToSelect = 0; does the trick, selects 1st column.
- Jarosław Staniek
On Jan. 12, 2015, 10:59 p.m., Jarosław Staniek wrote:
>
> ---
> This is an automatica
the active column.
(this is a usability fix)
Diffs (updated)
-
kexi/widget/dataviewcommon/kexidataawareobjectiface.cpp aeaf717
Diff: https://git.reviewboard.kde.org/r/122021/diff/
Testing
---
Editable table views work
Thanks,
Jarosł
g/r/122042/#comment51395>
The original code at 2242 looks like command compression. Could you explain
what happens after your change?
- Jarosław Staniek
On Jan. 13, 2015, 9:06 p.m., Roman Shtemberko wrote:
>
> ---
olumn that has no autoincrement flag set.
Before it was the active column.
(this is a usability fix)
Diffs
-
kexi/widget/dataviewcommon/kexidataawareobjectiface.cpp aeaf717
Diff: https://git.reviewboard.kde.org/r/122021/diff/
Testing
---
Editable table views work
Thanks,
Jarosł
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120940/#review73989
---
Let's finish it!
- Jarosław Staniek
On Nov. 1, 2014,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122036/#review74067
---
Ship it!
Perfect!
- Jarosław Staniek
On Jan. 13, 2015, 3
.
- Jarosław Staniek
On Jan. 14, 2015, 9:55 a.m., Roman Shtemberko wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
il. To reply, visit:
> https://git.reviewboard.kde.org/r/122042/
> ---
>
> (Updated Jan. 14, 2015, 9:55 a.m.)
>
>
> Review request for Calligra, Adam Pigg and Jarosław Staniek.
>
>
> Bugs: 342371
> http://bug
<https://git.reviewboard.kde.org/r/122051/#comment51448>
Good catch. I wonder if we can add this line just to
KexiView::setViewActions() for each action.
- Jarosław Staniek
On Jan. 14, 2015, 12:21 p.m., Roman Shtemberko
AwareObject->isSortingEnabled());
...and it works - both in table and query designer. However we wouldn't need to
explicitly call addAction() this way.
Let's leave this unresolved for a while so I'll look how to improve the overall
API without workarounds. Looks like this would be
> On Jan. 15, 2015, 5:27 p.m., Jarosław Staniek wrote:
> > Your solution is a workaround - 1. we would need add the shortcut by hand
> > for every use of the table view, and 2. we wouldn't have global shortcut
> > available for configuration by users.
> >
&g
<https://git.reviewboard.kde.org/r/122197/#comment51768>
object -> table
kexi/widget/KexiConnectionSelectorWidget.cpp
<https://git.reviewboard.kde.org/r/122197/#comment51770>
This looks good!
- Jarosław Staniek
On Jan. 22, 2015, 9:58 a.m., Roman Shtemberko
ews remain unchanged
Thanks,
Jarosław Staniek
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
exi/widget/tableview/KexiTableScrollArea.h 836f5cc
kexi/widget/tableview/KexiTableScrollArea.cpp 0a06fc9
Diff: https://git.reviewboard.kde.org/r/122240/diff/
Testing
---
functionality of table views remain unchanged
Thanks,
Jarosław Staniek
__
/tableview/KexiTableScrollArea.h 836f5cc
kexi/widget/tableview/KexiTableScrollArea.cpp 0a06fc9
Diff: https://git.reviewboard.kde.org/r/122240/diff/
Testing
---
functionality of table views remain unchanged
Thanks,
Jarosław Staniek
___
calligra-devel ma
tps://git.reviewboard.kde.org/r/122042/#comment52001>
"geomtery" is a typo. How this fixes anything? :)
> Other than that we will need to add some handler for "geometry"
> property in Form::slotPropertyChanged(). Works as expected on my side.
Interesting so could you please explain? Ca
itor/form_p.cpp a6a277a583476e4c9a24d40d3124efc367d4babd
kexi/formeditor/resizehandle.cpp f4e8b1e7c74f31cb6613caa1e042ada559389f62
Diff: https://git.reviewboard.kde.org/r/122380/diff/
Testing
---
Tested improvements with various widgets
Thanks,
Jarosław Staniek
_
.reviewboard.kde.org/r/122045/#comment52021>
-- indent
filters/words/docx/import/CMakeLists.txt
<https://git.reviewboard.kde.org/r/122045/#comment52022>
Will these three files be moved to a shared lib instead one day?
- Jarosław Staniek
On Jan. 18, 2015, 4:26 a.m., Inge Wal
comment52032>
--explicit
filters/libodfreader/OdtReaderBackend.h
<https://git.reviewboard.kde.org/r/122035/#comment52029>
--explicit
- Jarosław Staniek
On Jan. 13, 2015, 3:30 p.m., Inge Wallin wrote:
>
> ---
&
1 - 100 of 989 matches
Mail list logo
