Re: [cas-dev] Authn API Status

2013-06-18 Thread Marvin S. Addison
I'm +1 on this as I already reviewed all the previous pull requests. I'd like to push CAS-1305 also for RC1 : https://github.com/Jasig/cas/pull/273. I've merged feature-new-authn-api. Unless you have a lot of free time on your hands, you do not want to click on the commit in the GitHub UI to v

Re:[cas-dev] Authn API Status

2013-06-17 Thread jleleu
Hi, I'm +1 on this as I already reviewed all the previous pull requests. I'd like to push CAS-1305 also for RC1 : https://github.com/Jasig/cas/pull/273. Best regards; Jérôme -- You are currently subscribed to cas-dev@lists.jasig.org as: arch...@mail-archive.com To unsubscribe, change settings o

Re: [cas-dev] Authn API Status

2013-06-14 Thread Marvin S. Addison
We're feature complete on the feature-new-authn-api branch and I have issued a pull request to merge with master: https://github.com/Jasig/cas/pull/274 We're blocking on this to cut RC1, so I encourage all committers to either review or rubber stamp it since each of the individual changes hav

Re: [cas-dev] Authn API Status

2013-06-12 Thread Marvin S. Addison
I have just merged the latest set of changes on ldaptive and principal resolvers. I believe the branch on that end is also feature-complete now. There's one more pull I'd like to consider before we move forward: https://github.com/Jasig/cas/pull/272 I expect some resistance to yet another comp

RE: [cas-dev] Authn API Status

2013-06-11 Thread Misagh Moayyed
une 06, 2013 6:32 AM > To: cas-dev@lists.jasig.org > Subject: [cas-dev] Authn API Status > > I just issued a pull onto the feature-new-authn-api branch for some > credential cleanup, and I'd like to do another subsequent one for the > CredentialsToPrincipalResolver. There i

re:[cas-dev] Authn API Status

2013-06-06 Thread jleleu
Hi, I reviewed most of the pull requests so I have no objection. Unfortunately, the new OAuth server support won't be ready for the RC. So I'm afraid to postpone it for a future version. I still have CAS-1305 in my TODO list : does it fit in the RC's schedule ? Thanks. Best regards, Jérôme --

[cas-dev] Authn API Status

2013-06-06 Thread Marvin S. Addison
I just issued a pull onto the feature-new-authn-api branch for some credential cleanup, and I'd like to do another subsequent one for the CredentialsToPrincipalResolver. There isn't a whole lot of functional change in either one, but they are valuable in my mind. In any case I think we're funct

RE: [cas-dev] Authn API Status

2013-05-21 Thread Misagh Moayyed
il.com] > Sent: Thursday, May 16, 2013 11:40 AM > To: cas-...@lists.wisc.edu > Subject: RE:[cas-dev] Authn API Status > > Let us know when you expect some code review/feedback... > -- > You are currently subscribed to cas-dev@lists.jasig.org as: > mmoay...@unicon.net To u

RE: [cas-dev] Authn API Status

2013-05-16 Thread Misagh Moayyed
I can. Misagh > -Original Message- > From: Marvin S. Addison [mailto:marvin.addi...@gmail.com] > Sent: Wednesday, May 15, 2013 6:26 AM > To: cas-dev@lists.jasig.org > Subject: Re: [cas-dev] Authn API Status > > > 1. Removing spring ldap dependencies > > 2. Removing no

Re: [cas-dev] Authn API Status

2013-05-15 Thread Marvin S. Addison
1. Removing spring ldap dependencies 2. Removing now-deprecated ldap classes that will no longer be in use. Sounds good. 3. Aligning the current ldap authentication handler with the current authentication hierarchy Not sure I'm clear on that, but your pull/commit should clear that up. I ha

RE: [cas-dev] Authn API Status

2013-05-14 Thread Misagh Moayyed
nterest of time. Misagh > -Original Message- > From: Marvin S. Addison [mailto:marvin.addi...@gmail.com] > Sent: Monday, May 13, 2013 1:13 PM > To: cas-dev@lists.jasig.org > Subject: Re: [cas-dev] Authn API Status > > > Just to clarify: are we pushing directly to the

Re: [cas-dev] Authn API Status

2013-05-13 Thread Marvin S. Addison
Just to clarify: are we pushing directly to the topic branch? In-progress code reviews as commits appear? Good question. I was thinking we'd follow the typical process of committing to a personal repository and submitting pull requests, but in the interest of time we may want to do that only f

RE: [cas-dev] Authn API Status

2013-05-13 Thread Misagh Moayyed
ts.jasig.org > Subject: [cas-dev] Authn API Status > > The ldaptive integration components have been completed and merged into the > feature-new-authn-api branch: > > https://github.com/Jasig/cas/commit/d082f66744b701c51be30032c2af94e69468c7 61 > (and children) > > We're

Re: [cas-dev] Authn API Status

2013-05-13 Thread William G. Thompson, Jr.
On Mon, May 13, 2013 at 10:15 AM, Marvin S. Addison wrote: > The ldaptive integration components have been completed and merged into the > feature-new-authn-api branch: > > https://github.com/Jasig/cas/commit/d082f66744b701c51be30032c2af94e69468c761 > (and children) > > We're ready to dive back in

re:[cas-dev] Authn API Status

2013-05-13 Thread jleleu
Hi, Wednesday fits for me. Good to see that you take into account in your last commit my comment about multiple principalId. Best, Jérôme -- You are currently subscribed to cas-dev@lists.jasig.org as: arch...@mail-archive.com To unsubscribe, change settings or access archives, see http://www.

[cas-dev] Authn API Status

2013-05-13 Thread Marvin S. Addison
The ldaptive integration components have been completed and merged into the feature-new-authn-api branch: https://github.com/Jasig/cas/commit/d082f66744b701c51be30032c2af94e69468c761 (and children) We're ready to dive back in to the authn API work generally. I believe we can work in parallel