Re: [Catalyst] Re: Catalyst::Plugin::DBIC::QueryLog

2007-09-12 Thread Jess Robinson
Hey Feyland, On Tue, 4 Sep 2007, Fayland Lam wrote: Thank God. it works now. :) plz have a check, then I'll commit it to Catalyst trunk and release as a CPAN module. I've created appropriate Catalyst-Model-DBIC-Schema-QueryLog directories in the svn repo, please commit your code in there

Re: [Catalyst] Re: Catalyst::Plugin::DBIC::QueryLog

2007-09-04 Thread Matt S Trout
On Tue, Sep 04, 2007 at 12:02:14PM +, Fayland Lam wrote: > Jonathan Rockway wrote: > >Fayland Lam wrote: > >>see attachment. check if it's OK? > >> > >>now it's not per request any more. hmm, after several requests, > >mst wrote: > >>That's trivial with Catalyst::Component::InstancePerContext.

[Catalyst] Re: Catalyst::Plugin::DBIC::QueryLog

2007-09-04 Thread Fayland Lam
Jonathan Rockway wrote: Fayland Lam wrote: see attachment. check if it's OK? now it's not per request any more. hmm, after several requests, mst wrote: That's trivial with Catalyst::Component::InstancePerContext. He intended for you to use that. It implements the per-request magic for yo

Re: [Catalyst] Re: Catalyst::Plugin::DBIC::QueryLog

2007-09-04 Thread Jonathan Rockway
Fayland Lam wrote: > see attachment. check if it's OK? > > now it's not per request any more. hmm, after several requests, mst wrote: > That's trivial with Catalyst::Component::InstancePerContext. He intended for you to use that. It implements the per-request magic for you with some clever use o

[Catalyst] Re: Catalyst::Plugin::DBIC::QueryLog

2007-09-04 Thread Fayland Lam
see attachment. check if it's OK? now it's not per request any more. hmm, after several requests, Total SQL Time: 1.033088 seconds Total Queries: 115 it will increasing. hmm, how to make it as per request? Thanks, mst. (I'll send u a htpasswd line after all is OK.) Matt S Trout wrote: On Tu

Re: [Catalyst] Re: Catalyst::Plugin::DBIC::QueryLog

2007-09-04 Thread Matt S Trout
On Tue, Sep 04, 2007 at 01:19:31AM +, Fayland Lam wrote: > Matt S Trout wrote: > >On Sat, Sep 01, 2007 at 04:08:09AM +, Fayland Lam wrote: > >>hi, guys. > >> > >>since I can't touch Cory Watson by [EMAIL PROTECTED] >>PROTECTED]> > >>so I wonder if this module is fine? > >

Re: [Catalyst] Re: Catalyst::Plugin::DBIC::QueryLog

2007-09-04 Thread Jonathan Rockway
Fayland Lam wrote: > Matt S Trout wrote: >> No, it's awful. There's no reason at all for this to be a plugin. >> >> I'd suggest you make it a mixin for Catalyst::Model::DBIC::Schema >> instead. > but it depends on every request. it start at the sub prepare and end > before finalize_body. due to my

[Catalyst] Re: Catalyst::Plugin::DBIC::QueryLog

2007-09-03 Thread Fayland Lam
Matt S Trout wrote: On Sat, Sep 01, 2007 at 04:08:09AM +, Fayland Lam wrote: hi, guys. since I can't touch Cory Watson by [EMAIL PROTECTED] so I wonder if this module is fine? No, it's awful. There's no reason at all for this to be a plugin. I'd suggest you mak

Re: [Catalyst] Re: Catalyst::Plugin::DBIC::QueryLog

2007-09-03 Thread Matt S Trout
On Sun, Sep 02, 2007 at 10:25:37PM +, Fayland Lam wrote: > Cory Watson wrote: > >On 9/1/07, Guillermo Roditi <[EMAIL PROTECTED]> wrote: > >>I want this too > >> > >> > >>On 9/1/07, Marcus Ramberg <[EMAIL PROTECTED]> wrote: > >>>I don't know DBIx::Class::QueryLog, but as a catalyst plugin it loo

RE: [Catalyst] Re: Catalyst::Plugin::DBIC::QueryLog

2007-09-03 Thread Hartmaier Alexander
Hi! It seems you missed a dependency in your Makefile.PL: Sort::Key -Alex -Original Message- From: Fayland Lam [mailto:[EMAIL PROTECTED] Sent: Monday, September 03, 2007 12:26 AM To: catalyst@lists.rawmode.org Subject: [Catalyst] Re: Catalyst::Plugin::DBIC::QueryLog Cory Watson wrote

[Catalyst] Re: Catalyst::Plugin::DBIC::QueryLog

2007-09-02 Thread Fayland Lam
Cory Watson wrote: On 9/1/07, Guillermo Roditi <[EMAIL PROTECTED]> wrote: I want this too On 9/1/07, Marcus Ramberg <[EMAIL PROTECTED]> wrote: I don't know DBIx::Class::QueryLog, but as a catalyst plugin it looks fine. Write some tests and ship it to cpan, I want this ;) Marcus Ramberg On 9