davidxl added a comment.
yes -- the intention of Yiran's patch is not to change the size/alignment of
the underlying storage, but to make the original padding space part of the type.
http://reviews.llvm.org/D12247
___
cfe-commits mailing list
cfe-c
EricWF added a comment.
I think I've misunderstood this patch the whole time. I didn't understand that
it was undefined to access the trailing padding of the storage type. Am I
correct in saying that this patch won't change the actual values of
`sizeof(aligned_storage::type)` and `sizeof(aligne
krememek added a comment.
One thing about the tests passing: that's great, but that's obviously
insufficient. We probably have fewer tests showing that the analyzer can't
handle something than tests that show it does handle something.
When a patch like this lands, which expands the analysis sc
krememek added a comment.
FWIW, I do think this is a great problem to work on. It is easy to come up
with solutions that work for specific examples but fall over on general code.
I completely agree that failing to analyzing code after the loop is a major
hole and lost opportunity to find bugs
> On Aug 26, 2015, at 3:59 AM, Sean Eveson via cfe-commits
> wrote:
>
> We have been looking at the following problem, where any code after the
> constant bound loop is not analyzed because of the limit on how many times
> the same block is visited, as described in bugzillas #7638 and #23438.
krememek added a comment.
In http://reviews.llvm.org/D12358#233983, @zaks.anna wrote:
> A way this could be improved is by invalidating all the values that the loops
> effects, both the values on the stack and on the heap. (We could even start
> overly conservative and invalidate all the values
compnerd added inline comments.
Comment at: lib/Headers/Intrin.h:961
@@ +960,3 @@
+static __inline__ void __DEFAULT_FN_ATTRS _lgdt(void *__ptr) {
+ __builtin_ia32_lgdt(__ptr);
+}
mkuper wrote:
> compnerd wrote:
> > Why does this need a builtin? Is an inline asse
xazax.hun added a comment.
A conservative solution should work.
But if we want to preserve some precision I think it should be possible to not
to invalidate those values on the stack that are not effected by the loop. The
hard problem here is that, it is impossible to reason about the heap with
zaks.anna requested changes to this revision.
zaks.anna added a comment.
This revision now requires changes to proceed.
I agree that the way the static analyzer handles loops with known bounds is
quite bad and we loose coverage because of it, so this is definitely an
important problem to solve!
EricWF added a comment.
In http://reviews.llvm.org/D12247#231444, @yiranwang wrote:
> A test case is as following. It has to be build by GCC 4.9 -O3 (maybe or
> later), with latest libc++, and for AARCH64+ANDROID target.
> AARCH64 requires 128 bit alignment for aligned_storage and 64 bit point
eugenis added a comment.
Richard, would you mind taking a look a this change?
http://reviews.llvm.org/D12022
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rsmith added a subscriber: rsmith.
Comment at: lib/CodeGen/CGClass.cpp:1369-1382
@@ +1368,16 @@
+
+void VisitCallExpr(const Expr *E) {
+ Sensitive = true;
+}
+void VisitCXXTypeidExpr(const Expr *E) {
+ Sensitive = true;
+}
+void VisitExpr(const Expr *
Author: echristo
Date: Wed Aug 26 19:05:52 2015
New Revision: 246128
URL: http://llvm.org/viewvc/llvm-project?rev=246128&view=rev
Log:
Pass in a cpu to initDefaultFeatures so that we can share this code
with multiple uses of feature map construction.
Note: We could make this a static function on
Author: echristo
Date: Wed Aug 26 19:05:50 2015
New Revision: 246127
URL: http://llvm.org/viewvc/llvm-project?rev=246127&view=rev
Log:
const-ify X86TargetInfo::getCPUKind.
Modified:
cfe/trunk/lib/Basic/Targets.cpp
Modified: cfe/trunk/lib/Basic/Targets.cpp
URL:
http://llvm.org/viewvc/llvm-pr
ab created this revision.
ab added a reviewer: rjmccall.
ab added a subscriber: cfe-commits.
One problem that came up in D12389 is that i386 doesn't know about the "avx"
ABIs. Judging by the commit that originally introduced the X86_64 check and
the "avx" ABI (r145652), it was just unnecessary.
ab created this revision.
ab added a reviewer: rjmccall.
ab added a subscriber: cfe-commits.
The long-overdue (sorry!) prequel to D10724.
http://reviews.llvm.org/D12389
Files:
lib/Basic/Targets.cpp
test/CodeGen/vector-alignment.c
Index: test/CodeGen/vector-alignment.c
==
Author: rsmith
Date: Wed Aug 26 18:55:49 2015
New Revision: 246124
URL: http://llvm.org/viewvc/llvm-project?rev=246124&view=rev
Log:
[modules] The key to a DeclContext name lookup table is not actually a
DeclarationName (because all ctor names are considered the same, and so on).
Reflect this in t
Author: echristo
Date: Wed Aug 26 18:42:18 2015
New Revision: 246122
URL: http://llvm.org/viewvc/llvm-project?rev=246122&view=rev
Log:
Pull out cpu string -> enum parsing for x86 as a separate function,
this is going to see use shortly in unifying feature set construction.
Modified:
cfe/trunk
Prazek updated this revision to Diff 33273.
Prazek marked an inline comment as done.
http://reviews.llvm.org/D12385
Files:
lib/CodeGen/CGCXXABI.h
lib/CodeGen/CGClass.cpp
lib/CodeGen/CGVTables.cpp
lib/CodeGen/ItaniumCXXABI.cpp
lib/CodeGen/MicrosoftCXXABI.cpp
test/CodeGenCXX/template-in
Author: hans
Date: Wed Aug 26 18:35:14 2015
New Revision: 246120
URL: http://llvm.org/viewvc/llvm-project?rev=246120&view=rev
Log:
Creating release candidate rc4 from release_370 branch
Added:
libunwind/tags/RELEASE_370/rc4/ (props changed)
- copied from r246119, libunwind/branches/re
Author: hans
Date: Wed Aug 26 18:34:56 2015
New Revision: 246114
URL: http://llvm.org/viewvc/llvm-project?rev=246114&view=rev
Log:
Creating release candidate rc4 from release_370 branch
Added:
libcxxabi/tags/RELEASE_370/rc4/ (props changed)
- copied from r246113, libcxxabi/branches/re
Author: hans
Date: Wed Aug 26 18:34:53 2015
New Revision: 246113
URL: http://llvm.org/viewvc/llvm-project?rev=246113&view=rev
Log:
Creating release candidate rc4 from release_370 branch
Added:
libcxx/tags/RELEASE_370/rc4/ (props changed)
- copied from r246112, libcxx/branches/release_
Prazek marked 2 inline comments as done.
Comment at: lib/CodeGen/CGClass.cpp:1861
@@ +1860,3 @@
+ // We also have to make sure if we can refer to vtable:
+ // - If vtable is external then it's safe to use it (for availabe_externally
+ // CGVTables will make sure if it can emi
Prazek added a comment.
I will wait with pushing for tomorrow noon, in case someone want's to check the
code.
http://reviews.llvm.org/D12385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
On Wed, Aug 26, 2015 at 3:38 PM, Eric Fiselier wrote:
> EricWF added a comment.
>
> In http://reviews.llvm.org/D12247#233717, @yiranwang wrote:
>
>> Hi Eric,
>>
>> Could you please explain a bit more what is broken specifically? As we can
>> see, sizeof(), _Len, and _Align, and alignof() of "alig
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM with some comment tweaks.
Comment at: lib/CodeGen/CGClass.cpp:1861
@@ +1860,3 @@
+ // We also have to make sure if we can refer to vtable:
+ // - If vtable is external
Prazek updated this revision to Diff 33269.
http://reviews.llvm.org/D12385
Files:
lib/CodeGen/CGCXXABI.h
lib/CodeGen/CGClass.cpp
lib/CodeGen/CGVTables.cpp
lib/CodeGen/ItaniumCXXABI.cpp
lib/CodeGen/MicrosoftCXXABI.cpp
test/CodeGenCXX/template-instantiation.cpp
test/CodeGenCXX/thunks.
Prazek marked 3 inline comments as done.
Prazek added a comment.
http://reviews.llvm.org/D12385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL246105: [Static Analyzer] Checks to catch nullability
related issues. (authored by xazax).
Changed prior to commit:
http://reviews.llvm.org/D11468?vs=33239&id=33267#toc
Repository:
rL LLVM
http://re
Author: xazax
Date: Wed Aug 26 18:17:43 2015
New Revision: 246105
URL: http://llvm.org/viewvc/llvm-project?rev=246105&view=rev
Log:
[Static Analyzer] Checks to catch nullability related issues.
Differential Revision: http://reviews.llvm.org/D11468
Added:
cfe/trunk/docs/analyzer/nullability.r
rsmith added inline comments.
Comment at: lib/CodeGen/CGCXXABI.h:221
@@ -220,4 +220,3 @@
- virtual bool canEmitAvailableExternallyVTable(
- const CXXRecordDecl *RD) const = 0;
+ virtual bool canEmitUnusedVTable(const CXXRecordDecl *RD) const = 0;
This w
Author: dexonsmith
Date: Wed Aug 26 17:50:48 2015
New Revision: 246099
URL: http://llvm.org/viewvc/llvm-project?rev=246099&view=rev
Log:
DI: Update DISubprogram testcases after LLVM r246098
Modified:
cfe/trunk/test/CodeGen/debug-info-scope-file.c
cfe/trunk/test/CodeGenCXX/PR20038.cpp
rsmith added inline comments.
Comment at: include/clang/Basic/Builtins.def:1249-1255
@@ +1248,9 @@
+BUILTIN(__builtin_nontemporal_store, "v.", "t")
+BUILTIN(__builtin_nontemporal_store_1, "vcc*.", "")
+BUILTIN(__builtin_nontemporal_store_2, "vss*.", "")
+BUILTIN(__builtin_nontempo
zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.
Looks good overall. I might have additional post-commit comments.
http://reviews.llvm.org/D11468
___
cfe-commits mailing list
cfe-commits@l
Prazek created this revision.
Prazek added reviewers: rsmith, majnemer, rjmccall.
Prazek added a subscriber: cfe-commits.
It wasn't always safe to generate assumption loads. Last time build failed on
linking of classes like FenceInst because
it didn't introduce any new virtual function, and it ha
EricWF added a comment.
In http://reviews.llvm.org/D12247#233717, @yiranwang wrote:
> Hi Eric,
>
> Could you please explain a bit more what is broken specifically? As we can
> see, sizeof(), _Len, and _Align, and alignof() of "aligned_storage" are all
> not changed.
That's correct. At the ris
eugenis marked 2 inline comments as done.
eugenis added a comment.
http://reviews.llvm.org/D12382
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
eugenis removed rL LLVM as the repository for this revision.
eugenis updated this revision to Diff 33259.
http://reviews.llvm.org/D12382
Files:
lib/Driver/ToolChains.cpp
test/Driver/Inputs/basic_linux_libcxxv2_tree/usr/bin/.keep
test/Driver/Inputs/basic_linux_libcxxv2_tree/usr/include/c++/v
jroelofs added a subscriber: jroelofs.
Comment at: lib/Driver/ToolChains.cpp:3535
@@ -3534,1 +3534,3 @@
+static std::string DetectLibcxxIncludePath(const std::string &base) {
+ std::error_code EC;
StringRef instead?
Comment at: lib/Driver/Tool
yiranwang added a comment.
Hi Eric,
Could you please explain a bit more what is broken specifically? As we can see,
sizeof(), _Len, and _Align, and alignof() of "aligned_storage" are all not
changed.
http://reviews.llvm.org/D12247
___
cfe-commits
eugenis created this revision.
eugenis added reviewers: EricWF, mclow.lists.
eugenis added a subscriber: cfe-commits.
eugenis set the repository for this revision to rL LLVM.
With http://reviews.llvm.org/D11740, libc++ headers can not be used from the
libc++ source directly, because they include
Author: ab
Date: Wed Aug 26 17:21:07 2015
New Revision: 246094
URL: http://llvm.org/viewvc/llvm-project?rev=246094&view=rev
Log:
[ARM] Mark mcr/mrc builtin operands as required-immediate.
An early error message is better than the "cannot select" alternative.
Modified:
cfe/trunk/include/clang
Author: dexonsmith
Date: Wed Aug 26 17:21:09 2015
New Revision: 246095
URL: http://llvm.org/viewvc/llvm-project?rev=246095&view=rev
Log:
DI: Clarify meaning of createTempFunctionFwdDecl() arg, NFC
I stared at `false /*declaration*/` for quite some time before giving up
and checking the actual fun
eugenis created this revision.
eugenis added reviewers: mclow.lists, EricWF, rsmith.
eugenis added a subscriber: cfe-commits.
eugenis set the repository for this revision to rL LLVM.
This goes with the ABI versioning support in libc++ in
http://reviews.llvm.org/D11740
Repository:
rL LLVM
http
mzolotukhin added a comment.
Hi,
I implemented builtin-based version in http://reviews.llvm.org/D12313 - could
you please take a look?
Thanks,
Michael
http://reviews.llvm.org/D12221
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
Author: lcharles
Date: Wed Aug 26 17:13:30 2015
New Revision: 246093
URL: http://llvm.org/viewvc/llvm-project?rev=246093&view=rev
Log:
Corrected 3 typos. NFC
Modified:
cfe/trunk/lib/AST/Type.cpp
Modified: cfe/trunk/lib/AST/Type.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/
hans added a comment.
Committed in r246090.
http://reviews.llvm.org/D12368
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL246090: Add a clang release note about raising the minimum
Windows version for the… (authored by hans).
Changed prior to commit:
http://reviews.llvm.org/D12368?vs=33208&id=33255#toc
Repository:
rL LL
Author: rnk
Date: Wed Aug 26 16:57:20 2015
New Revision: 246088
URL: http://llvm.org/viewvc/llvm-project?rev=246088&view=rev
Log:
[ms-inline-asm] Add field access to MS inline asm identifier lookup
Now we can parse code like this:
struct A {
int field;
};
int f(A o) {
__asm mov eax,
EricWF added a comment.
In http://reviews.llvm.org/D12247#233595, @yiranwang wrote:
> In http://reviews.llvm.org/D12247#233349, @EricWF wrote:
>
> > In http://reviews.llvm.org/D12247#233323, @davidxl wrote:
> >
> > > We certainly need a fix without breaking ABI. Is there a ABI conformance
> > >
Forward to the right ML:
>> Sorry about the extreme delay. This patch slipped through the cracks, and I
>> only noticed it again when searching my email for enable_if. Committed in
>> r245985! In the future, please feel free to continue pinging weekly!
>
> NP, thank you for committing the patch
--> lists.llvm.org
-- Forwarded message --
From: Ettore Speziale
Date: 26 August 2015 at 14:35
Subject: Re: [PATCH] __attribute__((enable_if)) and non-overloaded member
functions
To: Nick Lewycky
Cc: llvm cfe
Hello,
> Sorry about the extreme delay. This patch slipped through
EricWF updated this revision to Diff 33253.
EricWF added a comment.
Fix debug assertion.
http://reviews.llvm.org/D12355
Files:
include/string
Index: include/string
===
--- include/string
+++ include/string
@@ -3795,7 +3795,10 @@
EricWF updated this revision to Diff 33252.
EricWF added a comment.
Instead of optimizing away the length calculation, this patch still performs it
but uses the calculated length to return early if the two strings differ in
length.
http://reviews.llvm.org/D12355
Files:
include/string
Index
xazax.hun created this revision.
xazax.hun added reviewers: krememek, zaks.anna, jordan_rose, dcoughlin.
xazax.hun added a subscriber: cfe-commits.
This patch merged the functionality from ObjCGenericsChecker into
DynamicTypePropagation checker.
Note that the Generics Checker can still be turned
eugenis added a comment.
> How long is a major and minor ABI version supported?
We don't want to bump major version too often, and we want to support both +1
and -1 of the current major version, along with all possible minor versions.
> When is the major and minor ABI version bumped?
See Abi
yiranwang added a comment.
some more explanation of last comment.
For most architecture sizeof(function) is 4*sizeof(void *), but it is
6*sizeof(void*) on AARCH64/LINUX, which does not sound so great as there are
padding of 2*sizeof(void*) bytes.
http://reviews.llvm.org/D12247
_
This revision was automatically updated to reflect the committed changes.
Closed by commit rL246083: [X86][SSE] Add _mm_undefined_* intrinsics (authored
by RKSimon).
Changed prior to commit:
http://reviews.llvm.org/D12052?vs=32514&id=33249#toc
Repository:
rL LLVM
http://reviews.llvm.org/D12
Author: rksimon
Date: Wed Aug 26 16:17:12 2015
New Revision: 246083
URL: http://llvm.org/viewvc/llvm-project?rev=246083&view=rev
Log:
[X86][SSE] Add _mm_undefined_* intrinsics
Added missing SSE/AVX 'undefined' intrinsics (PR24040):
_mm_undefined_pd, _mm_undefined_ps + _mm_undefined_si128
_mm256_
eugenis removed rL LLVM as the repository for this revision.
eugenis updated this revision to Diff 33246.
eugenis added a comment.
Introduced cmake options for specifying the desired ABI version.
ABI version affects library soname and include path (include/c++/vN).
Baked ABI version into the heade
yiranwang added a comment.
In http://reviews.llvm.org/D12247#233349, @EricWF wrote:
> In http://reviews.llvm.org/D12247#233323, @davidxl wrote:
>
> > We certainly need a fix without breaking ABI. Is there a ABI conformance
> > test for libcxx?
>
>
> Well this patch definitely breaks the ABI. Thi
On Wed, Aug 26, 2015 at 1:55 PM, Aaron Ballman
wrote:
> On Wed, Aug 26, 2015 at 4:30 PM, Richard Smith
> wrote:
> > On Wed, Aug 26, 2015 at 11:27 AM, Aaron Ballman >
> > wrote:
> >>
> >> aaron.ballman created this revision.
> >> aaron.ballman added reviewers: rsmith, hans.
> >> aaron.ballman ad
zhengkai created this revision.
zhengkai added a reviewer: rtrieu.
zhengkai added a subscriber: cfe-commits.
Use a new algorithm to find map back the ranges to its spelling locations.
But the function is not working properly either, and it breaks a test.
In the last case in the test file
/llvm/
On Wed, Aug 26, 2015 at 4:30 PM, Richard Smith wrote:
> On Wed, Aug 26, 2015 at 11:27 AM, Aaron Ballman
> wrote:
>>
>> aaron.ballman created this revision.
>> aaron.ballman added reviewers: rsmith, hans.
>> aaron.ballman added a subscriber: cfe-commits.
>>
>> PR24559 brings up a long-standing iss
mclow.lists added a comment.
In http://reviews.llvm.org/D12355#233477, @bkramer wrote:
> Won't this do the wrong thing for embedded '\0' in a std::string?
>
> std::string("hello\0world", 11).compare("hello")
>
>
> should not return 0.
Good point; I think that pretty much kills this propose
xazax.hun updated this revision to Diff 33239.
xazax.hun added a comment.
- Fine tuned the heuristics for cocoa APIs.
- Only track "nullable" and "contradicted" nullability for symbols. Use the
rest statically.
- Cleanups.
http://reviews.llvm.org/D11468
Files:
docs/analyzer/nullability.rst
On Wed, Aug 26, 2015 at 11:27 AM, Aaron Ballman
wrote:
> aaron.ballman created this revision.
> aaron.ballman added reviewers: rsmith, hans.
> aaron.ballman added a subscriber: cfe-commits.
>
> PR24559 brings up a long-standing issue in Clang where attribute order
> with differing syntax impacts
Author: ericwf
Date: Wed Aug 26 15:18:21 2015
New Revision: 246070
URL: http://llvm.org/viewvc/llvm-project?rev=246070&view=rev
Log:
[libcxx] Remove installation rules on Darwin when it would overwrite the system
installation.
Summary:
On Mac OS X overwriting `/usr/lib/libc++.dylib` can cause yo
Author: ericwf
Date: Wed Aug 26 15:17:33 2015
New Revision: 246069
URL: http://llvm.org/viewvc/llvm-project?rev=246069&view=rev
Log:
[libcxx] Add special warning flag detection logic to compiler.py
Summary: Detecting `-Wno-` flags can be tricky with GCC (See
https://gcc.gnu.org/onlinedocs/gcc/Wa
Author: ericwf
Date: Wed Aug 26 15:15:02 2015
New Revision: 246068
URL: http://llvm.org/viewvc/llvm-project?rev=246068&view=rev
Log:
[libcxx] Rewrite C++03 __invoke.
Summary:
This patch rewrites the C++03 `__invoke` and related meta-programming. There
are a number of major changes.
`__invoke` i
mclow.lists added a comment.
So... what do we need to do to enumerate the "ABI breakage" of this patch?
I get that there's a couple of member variables that are changing type. Can
they change (as a result of this patch) from a plain pointer to a fancy pointer
(or vice versa)? Can they change si
EricWF added a comment.
In http://reviews.llvm.org/D12355#233477, @bkramer wrote:
> Won't this do the wrong thing for embedded '\0' in a std::string?
>
> std::string("hello\0world", 11).compare("hello")
>
>
> should not return 0.
Woops. Yep that seems correct but it will sure hamper the po
mclow.lists added a comment.
I like this because it localizes the weirdness into one routine `self`.
If we can't get D12999 applied due to ABI concerns, this will help a bunch.
http://reviews.llvm.org/D12297
___
cfe-commits mailing list
cfe-commits@
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
Ok, I think this is good to go. Thanks, Eric.
http://reviews.llvm.org/D11553
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
bkramer added a subscriber: bkramer.
bkramer added a comment.
Won't this do the wrong thing for embedded '\0' in a std::string?
std::string("hello\0world", 11).compare("hello")
should not return 0.
http://reviews.llvm.org/D12355
___
cfe-commits
mclow.lists added a comment.
Everything except __functional_03 LGTM. That's not to say that that file has
problems, it's just that the diff display is not really helping :-)
http://reviews.llvm.org/D11553
___
cfe-commits mailing list
cfe-commits@
EricWF updated this revision to Diff 33236.
EricWF added a comment.
Remove unused "CompileString" functions. The reason they can't be used to
implement `addWarningFlagIfSupported` is because we have to fuss with the flags
before invoking the compiler .
http://reviews.llvm.org/D11333
Files:
mclow.lists added inline comments.
Comment at: include/__functional_base:521
@@ +520,3 @@
+operator() (_ArgTypes&&... __args) const {
+return __invoke(get(), _VSTD::forward<_ArgTypes>(__args)...);
+}
I know you didn't change this, but how did we ge
EricWF updated this revision to Diff 33235.
EricWF added a comment.
Address @mclow.lists note about consistency.
http://reviews.llvm.org/D11553
Files:
include/__functional_base
include/__functional_base_03
include/functional
test/std/utilities/function.objects/refwrap/refwrap.const/type
pekka.jaaskelainen added a subscriber: pekka.jaaskelainen.
pekka.jaaskelainen accepted this revision.
pekka.jaaskelainen added a reviewer: pekka.jaaskelainen.
pekka.jaaskelainen added a comment.
This revision is now accepted and ready to land.
Perhaps the assert() is unneccessary, but otherwise LG
mclow.lists added a comment.
I think I'd rather see the call to `strcmp` and `wcscmp` in the char_traits
class.
http://reviews.llvm.org/D12355
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
mclow.lists added a comment.
So far, this looks good. I'm going to apply it locally and futz with it.
Comment at: include/__functional_base_03:30
@@ +29,3 @@
+typedef _Ret _Bullet2;
+typedef _Ret type;
+};
Let's be consistent. :-)
typedef _Bullet2 t
jroelofs added inline comments.
Comment at: test/libcxx/compiler.py:195
@@ +194,3 @@
+cmd.remove('-v')
+out, err, rc = lit.util.executeCommand(cmd, input='#error\n')
+assert rc != 0
... you could at least use `compileString` here.
htt
jroelofs added a comment.
I'd say put them in when you have actual uses for them
http://reviews.llvm.org/D11333
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF added a comment.
Those methods are currently unused but are you opposed to me adding them in
this patch? They will be useful for compiling short tests to check for compiler
features.
http://reviews.llvm.org/D11333
___
cfe-commits mailing li
bader created this revision.
bader added a subscriber: cfe-commits.
http://reviews.llvm.org/D12378
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaExpr.cpp
test/SemaOpenCL/cond.cl
Index: test/SemaOpenCL/cond.cl
jroelofs added a comment.
the `addWarningFlagIfSupported` part of this patch LGTM.
Comment at: test/libcxx/compiler.py:88
@@ -87,1 +87,3 @@
+def compileString(self, source, out=None, flags=[], env=None, cwd=None):
+cmd = self.compileCmd('-', out, flags)
---
Author: ericwf
Date: Wed Aug 26 14:04:40 2015
New Revision: 246055
URL: http://llvm.org/viewvc/llvm-project?rev=246055&view=rev
Log:
Refactor flaky shared_mutex tests
Modified:
libcxx/trunk/test/std/thread/thread.mutex/thread.mutex.requirements/thread.shared_mutex.requirements/thread.shared_
Author: ahatanak
Date: Wed Aug 26 14:00:11 2015
New Revision: 246054
URL: http://llvm.org/viewvc/llvm-project?rev=246054&view=rev
Log:
[ARM] Error out if float-ab=hard and abi=apcs-gnu on macho platforms.
Error out if -mfloat-abi=hard or -mhard-float is specified on the command
line and the targe
ahatanak added a comment.
float-abi=hard has no effect on the backend code-generation if the ABI is APCS,
meaning GPRs will be used to pass floating point arguments. This patch makes
changes to the driver so that the error is detected in the front-end rather
than silently ignoring the option in
aaron.ballman created this revision.
aaron.ballman added reviewers: rsmith, hans.
aaron.ballman added a subscriber: cfe-commits.
PR24559 brings up a long-standing issue in Clang where attribute order with
differing syntax impacts whether a parse will succeed or fail with poor
diagnostics. For in
sepavloff added a subscriber: sepavloff.
sepavloff added a comment.
Ping.
Thanks,
--Serge
http://reviews.llvm.org/D11844
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Ping.
Thanks,
--Serge
2015-08-22 3:15 GMT+06:00 Sean Silva :
> silvas added inline comments.
>
>
> Comment at: test/Modules/auto-module-import.m:89
> @@ +88,3 @@
> + expected-error {{import of module
> 'NoUmbrella.A' appears within function 'includeN
EricWF added a comment.
In http://reviews.llvm.org/D12247#233323, @davidxl wrote:
> We certainly need a fix without breaking ABI. Is there a ABI conformance test
> for libcxx?
To actually answer @davidxl's question: No. libc++ does not have an ABI test
suite of any sort.
http://reviews.llvm
On Wed, Aug 26, 2015 at 11:11 AM, Eric Fiselier wrote:
> EricWF added a comment.
>
> In http://reviews.llvm.org/D12247#233323, @davidxl wrote:
>
>> We certainly need a fix without breaking ABI. Is there a ABI conformance
>> test for libcxx?
>
>
> Well this patch definitely breaks the ABI. This wa
EricWF added a comment.
In http://reviews.llvm.org/D12247#233323, @davidxl wrote:
> We certainly need a fix without breaking ABI. Is there a ABI conformance test
> for libcxx?
Well this patch definitely breaks the ABI. This was my attempt at fixing the
problem in `std::function` that might no
davidxl added a comment.
We certainly need a fix without breaking ABI. Is there a ABI conformance test
for libcxx?
http://reviews.llvm.org/D12247
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
Hello everyone,
LLVM buildmaster will be restarted after 6 PM Pacific time today.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF added a comment.
I think I'm starting to understand but I think the correct fix for this would
be to fix function so that:
1. It aligns its buffer by alignof(void*).
2. It doesn't stick over-aligned types in the small object buffer.
Point two can probably be done without an ABI break, bu
EricWF updated this revision to Diff 33219.
EricWF added a comment.
Address failing test that @awi pointed out.
http://reviews.llvm.org/D12299
Files:
include/list
Index: include/list
===
--- include/list
+++ include/list
@@ -191
1 - 100 of 131 matches
Mail list logo
