[clang-tools-extra] r247261 - [clang-tidy] Add inconsistent declaration parameter name check

Author: alexfh Date: Thu Sep 10 05:07:11 2015 New Revision: 247261 URL: http://llvm.org/viewvc/llvm-project?rev=247261=rev Log: [clang-tidy] Add inconsistent declaration parameter name check This is first of series of patches, porting code from my project colobot-lint, as I mentioned recently in

Re: [PATCH] D12734: Another patch for modernize-loop-convert.

klimek added inline comments. Comment at: clang-tidy/modernize/LoopConvertUtils.cpp:765-766 @@ -764,2 +764,4 @@ // exactly one usage. - addUsage(Usage(nullptr, false, C->getLocation())); + // We are using the 'IsArrow' field of Usage to store if we have to add +

Re: [Diffusion] rL247251: [OPENMP] Outlined function for parallel and other regions with list of…

chapuni added subscribers: cfe-commits, chapuni. chapuni added a comment. See also; http://bb.pgr.jp/builders/clang-i686-cygwin-RA-centos6/builds/20524 /cfe/trunk/test/OpenMP/parallel_codegen.cpp:99 Seems it is incompatible to 32-bit targets, for example, i686-linux, i686-cygwin. define

Re: [Diffusion] rL247251: [OPENMP] Outlined function for parallel and other regions with list of…

Yes, I know. Fixing it right now. Will be fixed in few minutes, thanks. Best regards, Alexey Bataev = Software Engineer Intel Compiler Team 10.09.2015 11:46, NAKAMURA Takumi пишет: chapuni added subscribers: cfe-commits, chapuni. chapuni added a comment. See also;

Re: [PATCH] D11797: [LIbClang] Report the named type for ElaboratedType

klimek added a comment. Ok, so just for my understanding: the nested name specifier in the changed tests canonicaltype is *not* the user-written type (thus, what the elaborated type would get us), but the full nested name specifier of the canonical type? http://reviews.llvm.org/D11797

Re: [PATCH] D1623: Support __builtin_ms_va_list.

cdavis5x updated this revision to Diff 34415. cdavis5x added a comment. - Rebase onto http://reviews.llvm.org/rL247238. - Run `clang-format` on this patch. - Push `va_arg` emission down into the `ABIInfo` hierarchy. I threaded the `IsMS` parameter from the `VAArgExpr` through the `EmitVAArg`

Re: Preventing several replacements on a macro call.

+ Argyrios Hi Angel, I believe Argyrios is the original author of the code in question, as this looks related to the Objective-C “modernizer” migrator he wrote a while back. This code started life on our internal development branch at Apple related to an Xcode feature we were doing, and I

Re: [PATCH] D12734: Another patch for modernize-loop-convert.

klimek added inline comments. Comment at: clang-tidy/modernize/LoopConvertCheck.cpp:458 @@ -438,2 +457,3 @@ // variable. for (const auto : Usages) { + std::string ReplaceText; I'd call that 'Usage' here, as it's not an iterator.

Re: [PATCH] D10414: Attach function attribute "arm-restrict-it" instead of passing arm-restrict-it as a backend-option

jmolloy added a subscriber: jmolloy. jmolloy added a comment. Hi Akira, I'm sorry to be contrary (and I missed the discussion on Tuesday because I was away on vacation) but I think there *is* a usecase for -mno-restrict-it to work, and I would hate to see it broken. Non-restricted IT blocks

Re: [PATCH] D12732: Add a deprecation notice to the clang-modernize documentation.

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. LG http://reviews.llvm.org/D12732 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D12462: [PATCH] [clang-tidy] Add inconsistent declaration parameter name check

alexfh closed this revision. alexfh added a comment. Committed revision 247261. Thank you again for the new awesome check! http://reviews.llvm.org/D12462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [Diffusion] rL247251: [OPENMP] Outlined function for parallel and other regions with list of…

ABataev added a subscriber: ABataev. ABataev added a comment. Yes, I know. Fixing it right now. Will be fixed in few minutes, thanks. Best regards, Alexey Bataev = Software Engineer Intel Compiler Team 10.09.2015 11:46, NAKAMURA Takumi пишет: > chapuni added subscribers:

r247255 - [OPENMP] Fix test incompatibility with 32-bit platforms

Author: abataev Date: Thu Sep 10 04:06:59 2015 New Revision: 247255 URL: http://llvm.org/viewvc/llvm-project?rev=247255=rev Log: [OPENMP] Fix test incompatibility with 32-bit platforms Modified: cfe/trunk/test/OpenMP/parallel_codegen.cpp Modified: cfe/trunk/test/OpenMP/parallel_codegen.cpp

Re: [PATCH] D12734: Another patch for modernize-loop-convert.

angelgarcia updated this revision to Diff 34422. angelgarcia marked 4 inline comments as done. angelgarcia added a comment. Document Usage's fields and other comments. http://reviews.llvm.org/D12734 Files: clang-tidy/modernize/LoopConvertCheck.cpp clang-tidy/modernize/LoopConvertCheck.h

r247260 - [OPENMP] Propagate alignment from original variables to the private copies.

Author: abataev Date: Thu Sep 10 04:48:30 2015 New Revision: 247260 URL: http://llvm.org/viewvc/llvm-project?rev=247260=rev Log: [OPENMP] Propagate alignment from original variables to the private copies. Currently private copies of captured variables have default alignment. Patch makes private

Re: PATCH: Expose the 'file' that is associated with a compile database command

@@ -179,11 +185,13 @@ public: /// \param Directory The base directory used in the FixedCompilationDatabase. static FixedCompilationDatabase *loadFromCommandLine(int , const char *const *Argv, -

[clang-tools-extra] r247258 - Add a deprecation notice to the clang-modernize documentation.

Author: alexfh Date: Thu Sep 10 04:42:01 2015 New Revision: 247258 URL: http://llvm.org/viewvc/llvm-project?rev=247258=rev Log: Add a deprecation notice to the clang-modernize documentation. Summary: Add a deprecation notice to the clang-modernize documentation. Remove the reference to the

Re: [PATCH] D12734: Another patch for modernize-loop-convert.

angelgarcia updated this revision to Diff 34428. angelgarcia added a comment. Comment the enumerators. > Do we need default? I think so. We need to set the cases that do not fall in any of these categories to something, and I think that using one of the other three as the default kind would

r247277 - AVX-512: Changed nidx parameter in extractf64/32 intrinsic from i8 to i32 according to the Intel Spec

Author: ibreger Date: Thu Sep 10 07:55:54 2015 New Revision: 247277 URL: http://llvm.org/viewvc/llvm-project?rev=247277=rev Log: AVX-512: Changed nidx parameter in extractf64/32 intrinsic from i8 to i32 according to the Intel Spec Differential Revision: http://reviews.llvm.org/D12752 Modified:

r247273 - [OPENMP] Generate threadprivates as TLS variables by default.

Author: abataev Date: Thu Sep 10 07:06:58 2015 New Revision: 247273 URL: http://llvm.org/viewvc/llvm-project?rev=247273=rev Log: [OPENMP] Generate threadprivates as TLS variables by default. If target supports TLS all threadprivates are generated as TLS. If target does not support TLS, use

D12689: [libc++][static linking] std streams are not initialized prior to their use in static object constructors

Ping. Could anyone review the patch? Kind regards, Evgeny Astigeevich -Original Message- From: Evgeny Astigeevich [mailto:evgeny.astigeev...@arm.com] Sent: 08 September 2015 11:00 To: Evgeny Astigeevich Cc: cfe-commits@lists.llvm.org Subject: [PATCH] D12689: [libc++][static linking] std

Re: [PATCH] D12725: [analyzer] A fix for substraction of an integer from a pointer.

NoQ added a comment. Thanks, fixed :) http://reviews.llvm.org/D12725 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12725: [analyzer] A fix for substraction of an integer from a pointer.

NoQ updated this revision to Diff 34423. NoQ added a comment. Make the tests easier to understand. http://reviews.llvm.org/D12725 Files: lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp test/Analysis/ptr-arith.c Index: test/Analysis/ptr-arith.c

Re: [PATCH] D12689: [libc++][static linking] std streams are not initialized prior to their use in static object constructors

rnk added a subscriber: rnk. rnk added a comment. I think a better approach would be to use `__attribute__((init_priority(101)))` on Linux and `#pragma init_seg(lib)` on Windows to ensure that libc++'s iostream initializer runs earlier. http://reviews.llvm.org/D12689

[PATCH] D12759: [clang-tidy] Add misc-sizeof-container check to find sizeof() uses on stlcontainers.

alexfh created this revision. alexfh added a reviewer: djasper. alexfh added a subscriber: cfe-commits. sizeof(some_std_string) is likely to be an error. This check finds this pattern and suggests using .size() instead. http://reviews.llvm.org/D12759 Files: clang-tidy/misc/CMakeLists.txt

Re: [PATCH] D12759: [clang-tidy] Add misc-sizeof-container check to find sizeof() uses on stlcontainers.

alexfh updated this revision to Diff 34441. alexfh added a comment. Ignore template instantiations. http://reviews.llvm.org/D12759 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp clang-tidy/misc/SizeofContainerCheck.cpp clang-tidy/misc/SizeofContainerCheck.h

Re: [PATCH] D12759: [clang-tidy] Add misc-sizeof-container check to find sizeof() uses on stlcontainers.

aaron.ballman added a subscriber: aaron.ballman. aaron.ballman added a comment. Great idea for a checker! Some comments below. Comment at: clang-tidy/misc/SizeofContainerCheck.cpp:36 @@ +35,3 @@ + Finder->addMatcher( + expr(sizeOfExpr( +

Re: [PATCH] D12759: [clang-tidy] Add misc-sizeof-container check to find sizeof() uses on stlcontainers.

aaron.ballman added a comment. I noticed a few more things, but mostly nitpicky at this point. Comment at: clang-tidy/misc/SizeofContainerCheck.cpp:22 @@ +21,3 @@ +bool needsParens(const Expr *E) { + E = E->IgnoreImpCasts(); + if (isa(E) || isa(E)) Should we

Re: [PATCH] D10414: Attach function attribute "arm-restrict-it" instead of passing arm-restrict-it as a backend-option

grosbach added a comment. In http://reviews.llvm.org/D10414#243056, @jmolloy wrote: > Non-restricted IT blocks are indeed deprecated for ARMv8 in the ARMARM. But > there are circumstances where you may still want to emit them - the biggest > example being you're compiling for a CPU

Re: [PATCH] D12759: [clang-tidy] Add misc-sizeof-container check to find sizeof() uses on stlcontainers.

alexfh updated this revision to Diff 34446. alexfh added a comment. Match a broader set of containers. Updated diagnostic message. Added tests. http://reviews.llvm.org/D12759 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp clang-tidy/misc/SizeofContainerCheck.cpp

Re: [PATCH] D12759: [clang-tidy] Add misc-sizeof-container check to find sizeof() uses on stlcontainers.

alexfh marked 3 inline comments as done. Comment at: clang-tidy/misc/SizeofContainerCheck.cpp:37 @@ +36,3 @@ + expr(unless(isInTemplateInstantiation()), + sizeOfExpr( + has(expr(hasType(hasCanonicalType(hasDeclaration(recordDecl( Yes,

r247286 - Properly close documentation /code blocks with /endcode.

Author: aaronballman Date: Thu Sep 10 10:13:22 2015 New Revision: 247286 URL: http://llvm.org/viewvc/llvm-project?rev=247286=rev Log: Properly close documentation /code blocks with /endcode. Modified: cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h Modified:

Re: [PATCH] D12759: [clang-tidy] Add misc-sizeof-container check to find sizeof() uses on stlcontainers.

On Thu, Sep 10, 2015 at 10:54 AM, Alexander Kornienko wrote: > alexfh marked 3 inline comments as done. > > > Comment at: clang-tidy/misc/SizeofContainerCheck.cpp:37 > @@ +36,3 @@ > + expr(unless(isInTemplateInstantiation()), > + sizeOfExpr( > +

Re: r247233 - EmitRecord* API change: accepts ArrayRef instead of a SmallVector (NFC)

On Thu, Sep 10, 2015 at 9:00 AM, Mehdi Amini wrote: > > On Sep 9, 2015, at 7:06 PM, David Blaikie wrote: > > > > On Wed, Sep 9, 2015 at 6:46 PM, Mehdi Amini via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: mehdi_amini >> Date: Wed

Re: [PATCH] D12759: [clang-tidy] Add misc-sizeof-container check to find sizeof() uses on stlcontainers.

On Thu, Sep 10, 2015 at 12:14 PM, Alexander Kornienko wrote: > On Thu, Sep 10, 2015 at 5:22 PM, Aaron Ballman > wrote: >> >> > >> > Comment at: clang-tidy/misc/SizeofContainerCheck.cpp:49 >> > @@ +48,3 @@ >> > + SourceLocation

Re: [PATCH] D12689: [libc++][static linking] std streams are not initialized prior to their use in static object constructors

eastig added a comment. In http://reviews.llvm.org/D12689#243295, @rnk wrote: > I think a better approach would be to use > `__attribute__((init_priority(101)))` on Linux and `#pragma init_seg(lib)` on > Windows to ensure that libc++'s iostream initializer runs earlier. Thank you for advice.

r247303 - Debug Info: Remove an unnecessary debug type visitor.

Author: adrian Date: Thu Sep 10 12:13:31 2015 New Revision: 247303 URL: http://llvm.org/viewvc/llvm-project?rev=247303=rev Log: Debug Info: Remove an unnecessary debug type visitor. Thanks to dblaikie for spotting this. Modified: cfe/trunk/lib/CodeGen/ObjectFilePCHContainerOperations.cpp

r247307 - [CUDA] Allow trivial constructors as initializer for __shared__ variables.

Author: tra Date: Thu Sep 10 12:26:58 2015 New Revision: 247307 URL: http://llvm.org/viewvc/llvm-project?rev=247307=rev Log: [CUDA] Allow trivial constructors as initializer for __shared__ variables. Differential Revision: http://reviews.llvm.org/D12739 Modified:

Re: [PATCH] D12759: [clang-tidy] Add misc-sizeof-container check to find sizeof() uses on stlcontainers.

On Thu, Sep 10, 2015 at 5:22 PM, Aaron Ballman wrote: > > > > Comment at: clang-tidy/misc/SizeofContainerCheck.cpp:49 > > @@ +48,3 @@ > > + SourceLocation SizeOfLoc = SizeOf->getLocStart(); > > + auto Diag = diag(SizeOfLoc, "sizeof() doesn't return the

Re: [PATCH] D12381: [Static Analyzer] Merge the Objective-C Generics Checker into Dynamic Type Propagation checker.

xazax.hun added a comment. In http://reviews.llvm.org/D12381#241709, @xazax.hun wrote: > There are several fallouts from this review, so I decided to split this patch > up the following way: > > 1. I created a patch to incorporate the result of this review into > ObjCGenericsChecker:

Re: r247303 - Debug Info: Remove an unnecessary debug type visitor.

> On Sep 10, 2015, at 10:19 AM, David Blaikie wrote: > > > > On Thu, Sep 10, 2015 at 10:18 AM, David Blaikie > wrote: > > > On Thu, Sep 10, 2015 at 10:13 AM, Adrian Prantl via cfe-commits >

Re: [PATCH] D10414: Attach function attribute "arm-restrict-it" instead of passing arm-restrict-it as a backend-option

jmolloy added a comment. Hi Jim, In an ideal world, yes. However there's no guarantee that all ARM implementors will (a) be able to commit to LLVM or (b) use ToT. Perhaps they're building a project that uses clang, or a specific version of clang, and this tuning option makes things go faster

Re: r247233 - EmitRecord* API change: accepts ArrayRef instead of a SmallVector (NFC)

> On Sep 9, 2015, at 7:06 PM, David Blaikie wrote: > > > > On Wed, Sep 9, 2015 at 6:46 PM, Mehdi Amini via cfe-commits > > wrote: > Author: mehdi_amini > Date: Wed Sep 9 20:46:39 2015 > New Revision: 247233 >

Re: r247233 - EmitRecord* API change: accepts ArrayRef instead of a SmallVector (NFC)

> On Sep 10, 2015, at 9:02 AM, David Blaikie wrote: > > > > On Thu, Sep 10, 2015 at 9:00 AM, Mehdi Amini > wrote: > >> On Sep 9, 2015, at 7:06 PM, David Blaikie > >

Re: [PATCH] D12759: [clang-tidy] Add misc-sizeof-container check to find sizeof() uses on stlcontainers.

On Thu, Sep 10, 2015 at 12:04 PM, Alexander Kornienko wrote: > alexfh marked 5 inline comments as done. > > > Comment at: clang-tidy/misc/SizeofContainerCheck.cpp:23 > @@ +22,3 @@ > + E = E->IgnoreImpCasts(); > + if (isa(E) || isa(E)) > +return true; >

r247302 - Re-commit r247218: "Fix Clang-tidy misc-use-override warnings, other minor fixes"

Author: hans Date: Thu Sep 10 12:07:54 2015 New Revision: 247302 URL: http://llvm.org/viewvc/llvm-project?rev=247302=rev Log: Re-commit r247218: "Fix Clang-tidy misc-use-override warnings, other minor fixes" This never broke the build; it was the LLVM side, r247216, that caused problems.

Re: r247303 - Debug Info: Remove an unnecessary debug type visitor.

On Thu, Sep 10, 2015 at 10:13 AM, Adrian Prantl via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: adrian > Date: Thu Sep 10 12:13:31 2015 > New Revision: 247303 > > URL: http://llvm.org/viewvc/llvm-project?rev=247303=rev > Log: > Debug Info: Remove an unnecessary debug type visitor.

Re: [PATCH] D12695: [Driver] Use UniversalCRT on Windows if available

rnk added a comment. There's a bunch of whitespace issues that clang-format can resolve. We also have the convention that variables are StudlyCaps, which isn't followed in a few places. Do you need someone to commit this for you? If so, I can patch this in, test it manually, and deal with the

Re: [PATCH] D12695: [Driver] Use UniversalCRT on Windows if available

ikudrin added a comment. In http://reviews.llvm.org/D12695#243552, @rnk wrote: > There's a bunch of whitespace issues that clang-format can resolve. Thanks! I'll reformat it. > We also have the convention that variables are StudlyCaps, which isn't > followed in a few places. I've tried to

[PATCH] D12769: [analyzer] Update SATestBuild.py to set -isysroot for preprocessed files

dcoughlin created this revision. dcoughlin added reviewers: zaks.anna, xazax.hun. dcoughlin added a subscriber: cfe-commits. Update the static analyzer buildbot script to set -isysroot to the OS X SDK path when analyzing preprocessed files. http://reviews.llvm.org/D12769 Files:

Re: [PATCH] D12695: [Driver] Use UniversalCRT on Windows if available

ikudrin marked an inline comment as done. ikudrin added a comment. In http://reviews.llvm.org/D12695#243320, @rnk wrote: > FYI @ruiu is moving this code to LLVM in http://reviews.llvm.org/D12604. Thanks. I think I'll move my changes to the new place when he's finished.

Re: [PATCH] D11664: [CUDA] Implemented additional processing steps needed to link with CUDA libdevice bitcode.

This revision was automatically updated to reflect the committed changes. Closed by commit rL247317: [CUDA] Postprocess bitcode linked in during device-side CUDA compilation. (authored by tra). Changed prior to commit: http://reviews.llvm.org/D11664?vs=34467=34470#toc Repository: rL LLVM

Re: [PATCH] D12769: [analyzer] Update SATestBuild.py to set -isysroot for preprocessed files

dcoughlin updated this revision to Diff 34471. dcoughlin added a comment. Pass -cc1 to clang even when SDK path is not found. http://reviews.llvm.org/D12769 Files: utils/analyzer/SATestBuild.py Index: utils/analyzer/SATestBuild.py

Re: r247233 - EmitRecord* API change: accepts ArrayRef instead of a SmallVector (NFC)

On Thu, Sep 10, 2015 at 11:39 AM, Richard Smith wrote: > On Thu, Sep 10, 2015 at 9:13 AM, David Blaikie via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> >> >> On Thu, Sep 10, 2015 at 9:07 AM, Mehdi Amini >> wrote: >> >>> >>> On Sep 10,

Re: [PATCH] D12689: [libc++][static linking] std streams are not initialized prior to their use in static object constructors

rsmith added a subscriber: rsmith. rsmith added a comment. Can we instead fix this in Clang by ensuring that libc++ is put at the right position in the static link order so that its initializers run first? libc++'s avoidance of running iostreams init code from every translation unit is a

Re: [PATCH] D12769: [analyzer] Update SATestBuild.py to set -isysroot for preprocessed files

dcoughlin added inline comments. Comment at: utils/analyzer/SATestBuild.py:277 @@ +276,3 @@ +# For now, we assume the preprocessed files should be analyzed +# with the OS X SDK. +SDKPath = getSDKPath("macosx") xazax.hun wrote: > I think it might be

Re: PATCH: Expose the 'file' that is associated with a compile database command

> On Sep 10, 2015, at 1:48 AM, Manuel Klimek wrote: > > @@ -179,11 +185,13 @@ public: >/// \param Directory The base directory used in the > FixedCompilationDatabase. >static FixedCompilationDatabase *loadFromCommandLine(int , >

Re: r247233 - EmitRecord* API change: accepts ArrayRef instead of a SmallVector (NFC)

On Thu, Sep 10, 2015 at 9:13 AM, David Blaikie via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > > On Thu, Sep 10, 2015 at 9:07 AM, Mehdi Amini > wrote: > >> >> On Sep 10, 2015, at 9:02 AM, David Blaikie wrote: >> >> >> >> On Thu, Sep 10, 2015

Re: Preventing several replacements on a macro call.

Hi Angel, This part of the code is conservative because it is not clear if accepting the change in all the different places where the macro argument is expanded is acceptable or not. For a contrived example, let’s say you have this macro definition: #define MY_MAC(x) foo(x) + bar(x)

Re: [PATCH] D12785: Document __builtin_nontemporal_load and __builtin_nontemporal_store.

rsmith added inline comments. Comment at: docs/LanguageExtensions.rst:1802-1807 @@ +1801,8 @@ + +For example, on AArch64 in the following code:: + + LDR X1, [X2] + LDNP X3, X4, [X1] + +the ``LDNP`` might be executed before the ``LDR``. In this case the load would +be performed

Re: [PATCH] D12695: [Driver] Use UniversalCRT on Windows if available

This revision was automatically updated to reflect the committed changes. Closed by commit rL247362: [Driver] Use UniversalCRT on Windows if available (authored by rnk). Changed prior to commit: http://reviews.llvm.org/D12695?vs=34475=34515#toc Repository: rL LLVM

r247362 - [Driver] Use UniversalCRT on Windows if available

Author: rnk Date: Thu Sep 10 19:09:39 2015 New Revision: 247362 URL: http://llvm.org/viewvc/llvm-project?rev=247362=rev Log: [Driver] Use UniversalCRT on Windows if available Summary: With Visual Studio 2015 release, a part of runtime library was extracted and now comes with Windows Kits. This

Re: [PATCH] D11737: Add -linker (and -linker=) alias for -fuse-ld=

filcab abandoned this revision. filcab added a comment. We don't need this anymore, since we're making some internal changes. Thank you for the feedback! Comment at: include/clang/Driver/Options.td:1853-1854 @@ -1853,1 +1852,4 @@ +def fuse_ld_EQ : Joined<["-"], "fuse-ld=">,

Re: [PATCH] D12652: [Static Analyzer] Lambda support.

xazax.hun updated this revision to Diff 34498. xazax.hun added a comment. - Updated to latest trunk - Added test for the defensive inline check heuristic case - Added test for diagnostic within a lambda body - Added test for path notes http://reviews.llvm.org/D12652 Files:

Re: [PATCH] D12087: always_inline codegen rewrite

eugenis added a comment. I'm going to commit this tomorrow unless someone speaks up. Repository: rL LLVM http://reviews.llvm.org/D12087 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D12785: Document __builtin_nontemporal_load and __builtin_nontemporal_store.

mzolotukhin added inline comments. Comment at: docs/LanguageExtensions.rst:1802-1807 @@ +1801,8 @@ + +For example, on AArch64 in the following code:: + + LDR X1, [X2] + LDNP X3, X4, [X1] + +the ``LDNP`` might be executed before the ``LDR``. In this case the load would +be

Re: r247369 - Module Debugging: Emit forward declarations for types that are defined in

On Thu, Sep 10, 2015 at 6:03 PM, Adrian Prantl via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: adrian > Date: Thu Sep 10 20:03:26 2015 > New Revision: 247369 > > URL: http://llvm.org/viewvc/llvm-project?rev=247369=rev > Log: > Module Debugging: Emit forward declarations for types

Re: [PATCH] D11279: Initial patch for PS4 toolchain

filcab updated this revision to Diff 34522. filcab marked 12 inline comments as done. filcab added a comment. This revision is now accepted and ready to land. Addressed review comments. http://reviews.llvm.org/D11279 Files: include/clang/Basic/DiagnosticDriverKinds.td

Re: [PATCH] D12785: Document __builtin_nontemporal_load and __builtin_nontemporal_store.

> On Sep 10, 2015, at 6:29 PM, Richard Smith wrote: > > On Thu, Sep 10, 2015 at 5:57 PM, Michael Zolotukhin > wrote: > mzolotukhin added inline comments. > > > Comment at:

r247374 - Docs: Document __builtin_nontemporal_load and __builtin_nontemporal_store.

Author: mzolotukhin Date: Thu Sep 10 21:01:15 2015 New Revision: 247374 URL: http://llvm.org/viewvc/llvm-project?rev=247374=rev Log: Docs: Document __builtin_nontemporal_load and __builtin_nontemporal_store. Summary: In r247104 I added the builtins for generating non-temporal memory operations,

Re: [PATCH] D12785: Document __builtin_nontemporal_load and __builtin_nontemporal_store.

This revision was automatically updated to reflect the committed changes. Closed by commit rL247374: Docs: Document __builtin_nontemporal_load and __builtin_nontemporal_store. (authored by mzolotukhin). Changed prior to commit: http://reviews.llvm.org/D12785?vs=34521=34524#toc Repository:

r247351 - Handle '-r' option properly

Author: rnk Date: Thu Sep 10 17:31:45 2015 New Revision: 247351 URL: http://llvm.org/viewvc/llvm-project?rev=247351=rev Log: Handle '-r' option properly Summary: This fixs the bug https://llvm.org/bugs/show_bug.cgi?id=12587 Patch by Yunlian Jiang Reviewers: Bigcheese, rnk Differential

Re: [PATCH] D12785: Document __builtin_nontemporal_load and __builtin_nontemporal_store.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM Comment at: docs/LanguageExtensions.rst:1784 @@ +1783,3 @@ + +Clang provides overloaded builtins allowing to generate non-temporal memory +accesses. to

Re: [PATCH] D12402: PR24595: clang-cl fails to compile vswriter.h header from Windows SDK 8.1 in 32 bit mode

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, thanks! Comment at: test/CodeGenCXX/ctor-dtor-alias.cpp:170 @@ -169,3 +169,3 @@ // it has a different calling conversion. - // CHECK4: call void @_ZN5test93barD2Ev + //

Re: r247233 - EmitRecord* API change: accepts ArrayRef instead of a SmallVector (NFC)

On Thu, Sep 10, 2015 at 1:34 PM, Richard Smith wrote: > On Thu, Sep 10, 2015 at 11:46 AM, David Blaikie > wrote: > >> >> >> On Thu, Sep 10, 2015 at 11:39 AM, Richard Smith >> wrote: >> >>> On Thu, Sep 10, 2015 at 9:13 AM, David

Re: [PATCH] D10018: C11 _Bool bitfield diagnostic

rcraik added inline comments. Comment at: lib/Sema/SemaDecl.cpp:12586 @@ -12585,3 +12585,3 @@ if (!FieldTy->isDependentType()) { uint64_t TypeSize = Context.getTypeSize(FieldTy); if (Value.getZExtValue() > TypeSize) { hubert.reinterpretcast wrote: >

Re: r247233 - EmitRecord* API change: accepts ArrayRef instead of a SmallVector (NFC)

On Thu, Sep 10, 2015 at 6:26 PM, David Blaikie wrote: > > > On Thu, Sep 10, 2015 at 1:34 PM, Richard Smith > wrote: > >> On Thu, Sep 10, 2015 at 11:46 AM, David Blaikie >> wrote: >> >>> >>> >>> On Thu, Sep 10, 2015 at 11:39 AM,

Re: [PATCH] D12652: [Static Analyzer] Lambda support.

jordan_rose added a comment. A few comments coming late… Comment at: include/clang/StaticAnalyzer/Core/AnalyzerOptions.h:515-517 @@ -511,1 +514,5 @@ + /// Returns true if lambdas should be inlined. Otherwise a sink node will be + /// generated each time a LambdaExpr is

Re: [PATCH] D12785: Document __builtin_nontemporal_load and __builtin_nontemporal_store.

On Thu, Sep 10, 2015 at 5:57 PM, Michael Zolotukhin wrote: > mzolotukhin added inline comments. > > > Comment at: docs/LanguageExtensions.rst:1802-1807 > @@ +1801,8 @@ > + > +For example, on AArch64 in the following code:: > + > + LDR X1, [X2] > + LDNP

Re: r247319 - Add a getDeclContextDescriptor() helper function to CGDebugInfo. (NFC)

On Thu, Sep 10, 2015 at 11:39 AM, Adrian Prantl via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: adrian > Date: Thu Sep 10 13:39:45 2015 > New Revision: 247319 > > URL: http://llvm.org/viewvc/llvm-project?rev=247319=rev > Log: > Add a getDeclContextDescriptor() helper function to

Re: [PATCH] D12785: Document __builtin_nontemporal_load and __builtin_nontemporal_store.

mzolotukhin updated this revision to Diff 34521. mzolotukhin added a comment. - Remove paragraph about changing program behavior (since we shouldn't change it anyway). http://reviews.llvm.org/D12785 Files: docs/LanguageExtensions.rst Index: docs/LanguageExtensions.rst

Re: [PATCH] D12652: [Static Analyzer] Lambda support.

zaks.anna added a comment. Have you tested this on a large codebase that uses lambdas? When do you think we should turn this on by default? Please, add test cases that demonstrate what happens when an issue is reported within a lambda and to check if inlined defensive checks work. (As a

Re: [PATCH] D12652: [Static Analyzer] Lambda support.

zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. Please, do turn on by default. LGTM http://reviews.llvm.org/D12652 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D12780: [analyzer] Add generateErrorNode() APIs to CheckerContext

zaks.anna added inline comments. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h:229 @@ -228,2 +228,3 @@ + /// checkers should use generateErrorNode() instead. ExplodedNode *generateSink(ProgramStateRef State = nullptr,

Re: [PATCH] D12780: [analyzer] Add generateErrorNode() APIs to CheckerContext

jordan_rose added inline comments. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h:321 @@ +320,3 @@ +// sink, we assume that a client requesting a transition to a state that is +// the same as the predecessor state has made a mistake. We

r247373 - [sema] Fix assertion hit when using libclang to index a particular C++ snippet involving templates.

Author: akirtzidis Date: Thu Sep 10 20:44:56 2015 New Revision: 247373 URL: http://llvm.org/viewvc/llvm-project?rev=247373=rev Log: [sema] Fix assertion hit when using libclang to index a particular C++ snippet involving templates. Assertion hit was in

r247346 - [MS ABI] Make member pointers return true for isIncompleteType

Author: majnemer Date: Thu Sep 10 16:52:00 2015 New Revision: 247346 URL: http://llvm.org/viewvc/llvm-project?rev=247346=rev Log: [MS ABI] Make member pointers return true for isIncompleteType The type of a member pointer is incomplete if it has no inheritance model. This lets us reuse more

[PATCH] D12785: Document __builtin_nontemporal_load and __builtin_nontemporal_store.

mzolotukhin created this revision. mzolotukhin added reviewers: hfinkel, rsmith. mzolotukhin added a subscriber: cfe-commits. In r247104 I added the builtins for generating non-temporal memory operations, but now I realized that they lack documentation. This patch adds some.

r247367 - [MS ABI] Remove another call to RequireCompleteType

Author: majnemer Date: Thu Sep 10 19:53:15 2015 New Revision: 247367 URL: http://llvm.org/viewvc/llvm-project?rev=247367=rev Log: [MS ABI] Remove another call to RequireCompleteType I cannot come up with a testcase which would rely on this call to RequireCompleteType, I believe that it is

Re: [PATCH] D11361: [OpenMP] Target directive host codegen

rjmccall added a comment. Sorry for putting off the final review on this; I was heads-down trying to get the alignment patch done. It's looking good; obviously you'll need to update it to work with Addresses properly, but hopefully that won't be too much of a problem. When you do, maybe you

Re: [PATCH] D12221: [RFC] Introduce `__attribute__((nontemporal))`.

mzolotukhin abandoned this revision. mzolotukhin added a comment. We decided to go with an alternative way - with builtins instead of type attributes. The corresponding patch is http://reviews.llvm.org/D12313, and it's already reviewed and committed. http://reviews.llvm.org/D12221

r247380 - [opaque pointer type] update test cases for explicit pointee types on global aliases

Author: dblaikie Date: Thu Sep 10 22:22:18 2015 New Revision: 247380 URL: http://llvm.org/viewvc/llvm-project?rev=247380=rev Log: [opaque pointer type] update test cases for explicit pointee types on global aliases Modified: cfe/trunk/test/CodeGen/alias.c

r247384 - [modules] Don't load files specified by -fmodule-file= when modules are

Author: rsmith Date: Thu Sep 10 22:58:07 2015 New Revision: 247384 URL: http://llvm.org/viewvc/llvm-project?rev=247384=rev Log: [modules] Don't load files specified by -fmodule-file= when modules are disabled. (We still allow this via -cc1 / -Xclang, primarily for testing.) Modified:

Re: r246985 - Compute and preserve alignment more faithfully in IR-generation.

On Thu, Sep 10, 2015 at 7:27 PM John McCall wrote: > On Sep 10, 2015, at 16:09, Chandler Carruth wrote: > > > On Thu, Sep 10, 2015 at 3:26 PM John McCall wrote: > >> On Sep 10, 2015, at 3:22 PM, Chandler Carruth

Re: [PATCH] D1623: Support __builtin_ms_va_list.

rsmith added inline comments. Comment at: lib/Sema/SemaExpr.cpp:11664-11672 @@ -11662,1 +11663,11 @@ + + // It might be a __builtin_ms_va_list. + if (!E->isTypeDependent() && Context.getTargetInfo().hasBuiltinMSVaList()) { +QualType MSVaListType =

r247375 - [modules] Slightly defang an assert that produces false-positives on the selfhost bot.

Author: rsmith Date: Thu Sep 10 21:22:03 2015 New Revision: 247375 URL: http://llvm.org/viewvc/llvm-project?rev=247375=rev Log: [modules] Slightly defang an assert that produces false-positives on the selfhost bot. Modified: cfe/trunk/lib/Serialization/ASTWriterDecl.cpp Modified:

Re: [PATCH] D12747: Implement [depr.c.headers]

rsmith added a comment. Each of the foo.h files added here was svn cp'd from the corresponding cfoo file. The listed diffs are against the base file. Likewise, __nullptr was copied from cstddef. (Please disregard the changes to lib/buildit.) Repository: rL LLVM

Re: [PATCH] D12743: [CodeGen] Teach SimplifyPersonality about the updated LandingPadInst

rjmccall added a comment. LGTM, thanks. http://reviews.llvm.org/D12743 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11815: Pass subtarget feature "force-align-stack"

ahatanak added a comment. OK, thanks. I'll go ahead and commit this patch and the llvm-side patch. http://reviews.llvm.org/D11815 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12402: PR24595: clang-cl fails to compile vswriter.h header from Windows SDK 8.1 in 32 bit mode

andreybokhanko updated this revision to Diff 34477. andreybokhanko added a comment. Reid, Sorry for delayed reply. All your comments are fixed (it turned out that usage of DefaultCC instead of ToCC is the root of all evil; after I fixed this, all other problems went away). Patch updated;

  1   2   >