Re: [PATCH] D13313: [clang-tidy] new check misc-no-reinterpret-cast

xazax.hun added a subscriber: xazax.hun. xazax.hun added a comment. If you check AvoidCStyleCastsCheck.cpp, it also suggest what kind of cast should you use to replace a C style cast. Probably, in some cases, the developers might be able to change the reinterpret_cast to something more type

[PATCH] D13331: [libcxx] Use newest supported language dialect when running the test suite.

EricWF created this revision. EricWF added reviewers: mclow.lists, danalbert, jroelofs. EricWF added a subscriber: cfe-commits. Currently the test suite defaults to C++11 mode if no standard version is supplied to LIT using `--param=std=c++XX`. This patch changes that behavior so that the

Re: [PATCH] D12993: [analyzer] Add TK_EntireMemSpace invalidation trait.

seaneveson added a comment. Could you update this patch to the latest trunk please? There's a conflict with http://reviews.llvm.org/rL248516. Thanks. http://reviews.llvm.org/D12993 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxx] r248988 - Fix initialzation order in dynarray

Author: ericwf Date: Thu Oct 1 02:29:38 2015 New Revision: 248988 URL: http://llvm.org/viewvc/llvm-project?rev=248988=rev Log: Fix initialzation order in dynarray Modified: libcxx/trunk/include/experimental/dynarray Modified: libcxx/trunk/include/experimental/dynarray URL:

Re: [PATCH] D13318: Add a utility function to add target information to a command line

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. LG Comment at: include/clang/Tooling/Tooling.h:437 @@ +436,3 @@ +/// +/// \note This will not set \c CommandLine[0] to \c InvokedAs. +void

[PATCH] D13332: [libcxx] Remove uses of std::unique_ptr<T[N]> from test to prevent warning.

EricWF created this revision. EricWF added a reviewer: mclow.lists. EricWF added subscribers: cfe-commits, mclow.lists. constructing a std::unique_ptr will always cause a warning because the deleter (`std::default_delete`) will call `delete ptr` instead of `delete [] ptr`. This is a

Re: [PATCH] D13342: Prevent loop-convert from leaving empty lines after removing an alias declaration.

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. apart from that LG http://reviews.llvm.org/D13342 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D13336: [MSVC] 'property' with an empty array in array subscript expression.

ABataev created this revision. ABataev added a reviewer: rnk. ABataev added a subscriber: cfe-commits. MSVC supports 'property' attribute and allows to apply it to the declaration of an empty array in a class or structure definition. For example: ``` __declspec(property(get=GetX, put=PutX)) int

Re: r248984 - Test fix

Right, I reverted both commits on r249005. Please, let me know if you need help testing on ARM before the next commit. This looks like it could be tested on any 32-bit platform, though, so you should be able to get it passing on ARM if you test and make it pass on x86. On 1 October 2015 at 09:44,

Re: [PATCH] D13342: Prevent loop-convert from leaving empty lines after removing an alias declaration.

angelgarcia updated this revision to Diff 36234. angelgarcia added a comment. Change a comment. http://reviews.llvm.org/D13342 Files: clang-tidy/modernize/LoopConvertCheck.cpp clang-tidy/modernize/LoopConvertCheck.h test/clang-tidy/modernize-loop-convert-extra.cpp Index:

r249001 - C++11 rangify for loops, NFC.

Author: yrnkrn Date: Thu Oct 1 06:19:28 2015 New Revision: 249001 URL: http://llvm.org/viewvc/llvm-project?rev=249001=rev Log: C++11 rangify for loops, NFC. Modified: cfe/trunk/lib/Frontend/InitHeaderSearch.cpp Modified: cfe/trunk/lib/Frontend/InitHeaderSearch.cpp URL:

[PATCH] D13339: Allow a ToolChain to compute the path of a compiler-rt's component.

vkalintiris created this revision. vkalintiris added reviewers: atanasyan, rsmith. vkalintiris added a subscriber: cfe-commits. Herald added subscribers: srhines, danalbert, tberghammer. This patch moves getCompilerRT() from the clang::driver::tools namespace to the ToolChain class. This is

Re: [PATCH] D12362: [clang-format] Add support of consecutive declarations alignment

djasper closed this revision. djasper added a comment. Submitted as r248999. Thank you! http://reviews.llvm.org/D12362 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13313: [clang-tidy] new check misc-no-reinterpret-cast

aaron.ballman added a subscriber: aaron.ballman. aaron.ballman added reviewers: aaron.ballman, alexfh. aaron.ballman added a comment. As a slightly more broad question: I think we should have a user-customizable way to categorize these checks so that you can enable/disable them with

[PATCH] D13342: Prevent loop-convert from leaving empty lines after removing an alias declaration.

angelgarcia created this revision. angelgarcia added a reviewer: klimek. angelgarcia added subscribers: alexfh, cfe-commits. This fixes https://llvm.org/bugs/show_bug.cgi?id=17716. http://reviews.llvm.org/D13342 Files: clang-tidy/modernize/LoopConvertCheck.cpp

Re: [PATCH] D13313: [clang-tidy] new check misc-no-reinterpret-cast

alexfh added a comment. In http://reviews.llvm.org/D13313#256982, @vsk wrote: > The patch lgtm. Has there been a discussion on cfe-dev about adopting these > guidelines? > > I count well over 500 uses of reinterpret_cast in llvm+clang, so we might not > all be on the same page on this. I

Re: [PATCH] D13313: [clang-tidy] new check misc-no-reinterpret-cast

alexfh added a comment. In http://reviews.llvm.org/D13313#257476, @aaron.ballman wrote: > As a slightly more broad question: I think we should have a user-customizable > way to categorize these checks so that you can enable/disable them with > finer-grained control. Some of the existing

[PATCH] D13337: [libcxx] Attempt to fix __throw_future_error in C++03

EricWF created this revision. EricWF added a reviewer: mclow.lists. EricWF added a subscriber: cfe-commits. Hi Marshall, Could you please test this patch and see if you run into the same linker errors we talked about? I can't reproduce on linux or OS X. Hopefully you can't find any problems

[PATCH] D13340: Add support for the new mips-mti-linux toolchain.

vkalintiris created this revision. vkalintiris added reviewers: atanasyan, dsanders, rsmith. vkalintiris added a subscriber: cfe-commits. Herald added subscribers: dschuff, srhines, danalbert, tberghammer, jfb. This new toolchain uses primarily LLVM-based tools, eg. compiler-rt, lld, libcxx, etc.

r248999 - [clang-format] Add support of consecutive declarations alignment

Author: djasper Date: Thu Oct 1 05:06:54 2015 New Revision: 248999 URL: http://llvm.org/viewvc/llvm-project?rev=248999=rev Log: [clang-format] Add support of consecutive declarations alignment This allows clang-format to align identifiers in consecutive declarations. This is useful for

[clang-tools-extra] r249017 - Update clang-tidy documentation.

Author: angelgarcia Date: Thu Oct 1 09:50:40 2015 New Revision: 249017 URL: http://llvm.org/viewvc/llvm-project?rev=249017=rev Log: Update clang-tidy documentation. Summary: Improve modernize-use-auto documentation (https://llvm.org/bugs/show_bug.cgi?id=24962). Add documentation for

Re: [PATCH] D13344: Keep the IfStmt node even if the condition is invalid

klimek added a reviewer: rsmith. klimek added a comment. +Richard, whom we need to validate AST changes to make sure they're benign. http://reviews.llvm.org/D13344 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D13203: [Clang] - Massaging code to fix MSVS 2015 win32-release configuration

yaron.keren added a subscriber: yaron.keren. yaron.keren added a comment. clang can't generate Visual C++ debug info except line numbers yet, so building with VC is essential to development on Windows. While most people and our bots are still using VC 2013 going forward supporting VC 2015 (even

Re: [PATCH] D13330: Implement __attribute__((unique_instantiation))

aaron.ballman added a subscriber: aaron.ballman. aaron.ballman added reviewers: rsmith, aaron.ballman. Comment at: include/clang/Basic/Attr.td:1462 @@ +1461,3 @@ +def UniqueInstantiation : InheritableAttr { + let Spellings = [GCC<"unique_instantiation">]; + let Subjects =

Re: [PATCH] D13340: Add support for the new mips-mti-linux toolchain.

atanasyan added inline comments. Comment at: include/clang/Driver/ToolChain.h:92 @@ -91,2 +91,3 @@ MultilibSet Multilibs; + Multilib SelectedMultilib; This field is used by the `MipsToolChain` class only. If so, move it to that class.

Re: [PATCH] D13304: Avoid inlining in throw statement

mcrosier added a comment. FWIW, a llvm based solution was discussed in http://reviews.llvm.org/D12979, but the clang solution is obviously more robust and easier to implement. Comment at: lib/CodeGen/CodeGenFunction.h:287 @@ +286,3 @@ + // True if the current insertion point

[PATCH] D13344: Keep the IfStmt node even if the condition is invalid

ogoffart created this revision. ogoffart added a reviewer: cfe-commits. This is quite useful for IDE's or other tools which would like to recover as much as possible even if there are a few errors in the code, and discarding the full 'if' bodies is unfortunate. http://reviews.llvm.org/D13344

r249009 - [PowerPC] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP_* macros on all PPC cores

Author: hfinkel Date: Thu Oct 1 08:39:49 2015 New Revision: 249009 URL: http://llvm.org/viewvc/llvm-project?rev=249009=rev Log: [PowerPC] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP_* macros on all PPC cores We support all __sync_val_compare_and_swap_* builtins (only 64-bit on 64-bit targets) on

Re: [PATCH] D13344: Keep the IfStmt node even if the condition is invalid

milianw added a comment. Is there still an error reported for the invalid condition? Anyhow, from my POV this is excellent and should fix a bunch of issues I've seen when using clang-c in KDevelop. I never got around to investigating it, but it always was related to conditionals. I'm pretty

Re: [PATCH] D13318: Add a utility function to add target information to a command line

zarko marked an inline comment as done. zarko added a comment. Thanks; would someone with commit access land this? echristo: for a more concrete example, imagine a source code indexer that collects up dependencies. This is a Clang tool that gets called by the build system for each translation

[PATCH] D13349: Casting boolean to an integer vector in OpenCL should set all bits if boolean is true

neil.hickey created this revision. neil.hickey added a reviewer: cfe-commits. Changing behaviour of casting a true boolean to an integer vector for OpenCL. The spec (6.2.2) states that if the boolean is true, every bit in the result vector should be set. This change will treat the i1 value as

Re: [PATCH] D13340: Add support for the new mips-mti-linux toolchain.

vkalintiris added inline comments. Comment at: include/clang/Driver/ToolChain.h:147 @@ -145,1 +146,3 @@ + const Multilib () const { return SelectedMultilib; } + atanasyan wrote: > Do you need public access to this member function? I discarded this member

Re: [PATCH] D13203: [Clang] - Massaging code to fix MSVS 2015 win32-release configuration

majnemer added a subscriber: majnemer. majnemer added a comment. In http://reviews.llvm.org/D13203#257539, @klimek wrote: > Not sure whether it makes sense to work around compiler bugs in CL. I assume > this happens with clang from trunk? Is there a bug filed against CL? We do this with some

r249031 - Module debugging: Also emit Objective-C interfaces forward declarations

Author: adrian Date: Thu Oct 1 11:57:02 2015 New Revision: 249031 URL: http://llvm.org/viewvc/llvm-project?rev=249031=rev Log: Module debugging: Also emit Objective-C interfaces forward declarations in their module scope when building a clang module. Modified:

Re: [PATCH] D13330: Implement __attribute__((unique_instantiation))

loladiro added a comment. Thanks for the quick review. Comment at: include/clang/Basic/Attr.td:1462 @@ +1461,3 @@ +def UniqueInstantiation : InheritableAttr { + let Spellings = [GCC<"unique_instantiation">]; + let Subjects = SubjectList<[CXXRecord]>;

Re: [PATCH] D13340: Add support for the new mips-mti-linux toolchain.

vkalintiris updated this revision to Diff 36257. vkalintiris marked 8 inline comments as done. vkalintiris added a comment. Thanks. The review comments are addressed in this update. http://reviews.llvm.org/D13340 Files: lib/Driver/Driver.cpp lib/Driver/ToolChain.cpp

Re: [PATCH] D13336: [MSVC] 'property' with an empty array in array subscript expression.

rnk added a comment. I think fundamentally we are doing too much declspec property lowering in Sema. We might want to back up and figure out how to do it in IRGen. Right now we have bugs like this, which are probably more important than new functionality:

Re: [PATCH] D13276: Don't adjust field offsets for external record layouts

majnemer accepted this revision. majnemer added a comment. This revision is now accepted and ready to land. LGTM with a test added, see test/CodeGenCXX/override-layout.cpp for an example of how to test external record layout. http://reviews.llvm.org/D13276

r249030 - Allow a ToolChain to compute the path of a compiler-rt's component.

Author: vkalintiris Date: Thu Oct 1 11:54:58 2015 New Revision: 249030 URL: http://llvm.org/viewvc/llvm-project?rev=249030=rev Log: Allow a ToolChain to compute the path of a compiler-rt's component. Summary: This patch moves getCompilerRT() from the clang::driver::tools namespace to the

Re: [PATCH] D11908: Clang support for -fthinlto.

On Wed, Sep 30, 2015 at 2:33 PM, Duncan P. N. Exon Smith wrote: > +echristo, +espindola, +pcc > >> On 2015-Sep-30, at 12:39, Teresa Johnson wrote: >> >> On Wed, Sep 30, 2015 at 11:11 AM, Duncan P. N. Exon Smith >> wrote: >>>

Re: [PATCH] D9888: [OPENMP] Driver support for OpenMP offloading

sfantao updated this revision to Diff 36263. sfantao added a comment. This diff refactors the original patch and is rebased on top of the latests offloading changes inserted for CUDA. Here I don't touch the CUDA support. I tried, however, to have the implementation modular enough so that it

Re: [PATCH] D13157: Teach -Wtautological-overlap-compare about enums

george.burgess.iv closed this revision. george.burgess.iv marked 4 inline comments as done. george.burgess.iv added a comment. Changed code to address all feedback + committed as r249053. Thanks for the reviews! Comment at: lib/Analysis/CFG.cpp:49 @@ +48,3 @@

Re: [PATCH] D13157: Teach -Wtautological-overlap-compare about enums

On Thu, Oct 1, 2015 at 2:50 PM, George Burgess IV wrote: > george.burgess.iv closed this revision. > george.burgess.iv marked 4 inline comments as done. > george.burgess.iv added a comment. > > Changed code to address all feedback + committed as r249053. Thanks for

r249053 - Teach -Wtautological-overlap-compare about enums

Author: gbiv Date: Thu Oct 1 13:47:52 2015 New Revision: 249053 URL: http://llvm.org/viewvc/llvm-project?rev=249053=rev Log: Teach -Wtautological-overlap-compare about enums Prior to this patch, -Wtautological-overlap-compare would only warn us if there was a sketchy logical comparison between

r249065 - Perform Objective-C lifetime adjustments before comparing deduced lambda result types.

Author: dgregor Date: Thu Oct 1 15:20:47 2015 New Revision: 249065 URL: http://llvm.org/viewvc/llvm-project?rev=249065=rev Log: Perform Objective-C lifetime adjustments before comparing deduced lambda result types. Objective-C ARC lifetime qualifiers are dropped when canonicalizing function

Re: [PATCH] D13351: [Power PC] add soft float support for ppc32

alexr added a subscriber: alexr. alexr added a comment. PowerPC has floating point hardware by definition. Is this some new variant? http://reviews.llvm.org/D13351 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D13157: Teach -Wtautological-overlap-compare about enums

> Next time, add Differential Revision: to your commit and Phabricator will close the diff automatically. Ooh, shiny. Thanks for letting me know! > Doubling the expense for assert builds so that we get a slightly better stack trace in the event our assumptions are wrong doesn't seem like a good

Re: [PATCH] D12993: [analyzer] Add TK_EntireMemSpace invalidation trait.

This revision was automatically updated to reflect the committed changes. Closed by commit rL249063: [analyzer] Add TK_EntireMemSpace invalidation trait. (authored by dcoughlin). Changed prior to commit: http://reviews.llvm.org/D12993?vs=35170=36288#toc Repository: rL LLVM

Re: [PATCH] D13313: [clang-tidy] new check misc-no-reinterpret-cast

mgehre updated this revision to Diff 36296. mgehre added a comment. Read 'Check' suffix on ProTypeReinterpretCastCheck http://reviews.llvm.org/D13313 Files: clang-tidy/CMakeLists.txt clang-tidy/Makefile clang-tidy/add_new_check.py clang-tidy/cppcoreguidelines/CMakeLists.txt

Re: [PATCH] D13313: [clang-tidy] new check misc-no-reinterpret-cast

mgehre updated this revision to Diff 36294. mgehre added a comment. Fix add_new_check.py for capitalization of CppCoreGuidelinesTidyModule.cpp http://reviews.llvm.org/D13313 Files: clang-tidy/CMakeLists.txt clang-tidy/Makefile clang-tidy/add_new_check.py

r249090 - Don't try to get a CXXRecordDecl from a non-class TemplateSpecializationType.

Author: rikka Date: Thu Oct 1 17:38:51 2015 New Revision: 249090 URL: http://llvm.org/viewvc/llvm-project?rev=249090=rev Log: Don't try to get a CXXRecordDecl from a non-class TemplateSpecializationType. With -fms-extensions it is possible to have a non-class record that is a template

r249097 - Fix the SSE4 byte sign extension in a cleaner way, and more thoroughly

Author: chandlerc Date: Thu Oct 1 18:40:12 2015 New Revision: 249097 URL: http://llvm.org/viewvc/llvm-project?rev=249097=rev Log: Fix the SSE4 byte sign extension in a cleaner way, and more thoroughly test that our intrinsics behave the same under -fsigned-char and -funsigned-char. This further

Re: [PATCH] D13324: Fix the SSE4 byte sign extension in a cleaner way, and more thoroughly test that our intrinsics behave the same under -fsigned-char and -funsigned-char.

This revision was automatically updated to reflect the committed changes. Closed by commit rL249097: Fix the SSE4 byte sign extension in a cleaner way, and more thoroughly (authored by chandlerc). Changed prior to commit: http://reviews.llvm.org/D13324?vs=36178=36321#toc Repository: rL LLVM

Re: [PATCH] D13322: Add -f[no-]declspec to control recognition of __declspec as a keyword

wristow added inline comments. Comment at: include/clang/Basic/LangOptions.def:93 @@ -92,2 +92,3 @@ LANGOPT(WChar , 1, CPlusPlus, "wchar_t keyword") +LANGOPT(DeclSpecKeyword , 1, 0, "Microsoft __declspec keyword support") BENIGN_LANGOPT(DollarIdents , 1, 1, "'$'

Re: [PATCH] D10305: [Clang Static Analyzer] Bug identification

zaks.anna added a comment. Could you address this: Could you ask on the open source list if people are using "issue_hash" and if they are Ok with us renaming it. I'd suggest to suffix each issue hash field with the description of that hash. For example, we would remove "issue_hash" and

[PATCH] D13368: [clang-tidy] add check cppcoreguidelines-pro-type-static-cast-downcast

mgehre created this revision. mgehre added reviewers: alexfh, sbenza, bkramer, aaron.ballman. mgehre added a subscriber: cfe-commits. mgehre added a dependency: D13313: [clang-tidy] new check cppcoreguidelines-pro-type-reinterpret-cast. This check flags all usages of static_cast, where a base

Re: [PATCH] D12871: [OpenMP] Target directive host codegen - rebased

sfantao updated this revision to Diff 36317. sfantao added a comment. Address Alexey's remarks from last review. http://reviews.llvm.org/D12871 Files: lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h lib/CodeGen/CGStmtOpenMP.cpp lib/CodeGen/CodeGenFunction.h

Re: [PATCH] D12871: [OpenMP] Target directive host codegen - rebased

sfantao added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3044-3054 @@ +3043,13 @@ +Sizes.push_back(Size); +MapTypes.push_back(MapType); + } + + // Keep track on whether the host function has to be executed. + auto OffloadErrorQType = +

Re: [PATCH] D13311: [clang-tidy] Add check misc-pointer-arithmetic

mgehre updated this revision to Diff 36305. mgehre added a comment. Remove inclusion of misc-no-reinterpret-cast in this patch set http://reviews.llvm.org/D13311 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp

Re: [PATCH] D13322: Add -f[no-]declspec to control recognition of __declspec as a keyword

wristow updated this revision to Diff 36307. wristow added a comment. Updated patch to change the Group of the diagnostic from f_Group to f_clang_Group, and to change the string associated with the LANGOPT definition of the flag. Also fixed a minor typo in a comment.

Re: [PATCH] D13276: Don't adjust field offsets for external record layouts

majnemer added a comment. It seems our infrastructure is not up to the task of making this testable via Clang, please commit. http://reviews.llvm.org/D13276 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D13326: [PGO]: Eliminate __llvm_profile_register calls for Linux (clang changes)

davidxl updated this revision to Diff 36316. davidxl added a comment. I have modified the implementation to not use linker script, so this clang patch becomes strictly refactoring with NFC. I think it is still a good thing to have this in so that similar tunings like this can be done in the

[PATCH] D13330: Implement __attribute__((unique_instantiation))

loladiro created this revision. loladiro added a reviewer: doug.gregor. loladiro added a subscriber: cfe-commits. loladiro set the repository for this revision to rL LLVM. This implements a proposal by Doug Gregor on cfe-dev a couple of years ago, to allow the compiler to emit strong symbols for

[libcxx] r248987 - Suppress array initialization warnings in std::experimental::apply tests

Author: ericwf Date: Thu Oct 1 02:05:38 2015 New Revision: 248987 URL: http://llvm.org/viewvc/llvm-project?rev=248987=rev Log: Suppress array initialization warnings in std::experimental::apply tests Added: libcxx/trunk/test/support/disable_missing_braces_warning.h Removed:

Re: [PATCH] D13357: [Concepts] Add diagnostic; specializations of variable and function concepts

hubert.reinterpretcast added inline comments. Comment at: test/CXX/concepts-ts/dcl.dcl/dcl.spec/dcl.concept/p7.cpp:13 @@ +12,3 @@ +template concept bool FCEI() { return true; } +template concept bool FCEI(); // expected-error {{function concept cannot be explicitly

Re: r248984 - Test fix

On Thu, Oct 1, 2015 at 6:01 AM, Renato Golin via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Right, I reverted both commits on r249005. Please, let me know if you > need help testing on ARM before the next commit. This looks like it > could be tested on any 32-bit platform, though, so you

[PATCH] D13373: Emiting invariant.group.barrier for ctors bugfix

Prazek created this revision. Prazek added reviewers: rsmith, nlewycky, rjmccall, majnemer. Prazek added a subscriber: cfe-commits. Please review asap http://reviews.llvm.org/D13373 Files: lib/CodeGen/CGClass.cpp test/CodeGenCXX/invariant.group-for-vptrs.cpp

Re: [PATCH] D13276: Don't adjust field offsets for external record layouts

This revision was automatically updated to reflect the committed changes. Closed by commit rL249085: Don't adjust field offsets when using external record layout. (authored by zturner). Changed prior to commit: http://reviews.llvm.org/D13276?vs=36054=36310#toc Repository: rL LLVM

Re: [PATCH] D13373: Emiting invariant.group.barrier for ctors bugfix

nlewycky added a comment. I can't meaningfully review this, but I see nothing wrong here. Comment at: lib/CodeGen/CGClass.cpp:1378 @@ -1377,3 +1377,3 @@ - bool BaseVPtrsInitialized = false; + llvm::Value* const OldThis = CXXThisValue; // Virtual base initializers first.

Re: [PATCH] D13322: Add -f[no-]declspec to control recognition of __declspec as a keyword

compnerd added inline comments. Comment at: lib/Driver/Tools.cpp:4663 @@ +4662,3 @@ + else if (Args.hasArg(options::OPT_fno_declspec)) +CmdArgs.push_back("-fno-declspec"); // Explicitly disabling __declspec. + @rsmith, so they are. I misread something and

Re: [PATCH] D13081: [clang-tidy] Implement FixitHints for identifier references in IdentifierNamingCheck

berenm added a comment. Alright, thank you for your time! Repository: rL LLVM http://reviews.llvm.org/D13081 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12362: [clang-format] Add support of consecutive declarations alignment

berenm marked 7 inline comments as done. Comment at: unittests/Format/FormatTest.cpp:8699 @@ +8698,3 @@ + "int one = 1;\n" + "\n" + "unsigned oneTwoThree = 123;", I think I actually managed to do

Re: [PATCH] D12362: [clang-format] Add support of consecutive declarations alignment

berenm marked 2 inline comments as done. berenm added a comment. http://reviews.llvm.org/D12362 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12839: Extend MoveConstructorInitCheck to also flag constructor arguments passed by value and can be moved assigned to fields.

alexfh added a comment. The patch doesn't apply cleanly. Please update it. http://reviews.llvm.org/D12839 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12362: [clang-format] Add support of consecutive declarations alignment

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. This looks awesome. Do you have commit access? Comment at: unittests/Format/FormatTest.cpp:8699 @@ +8698,3 @@ + "int one = 1;\n" +

Re: [PATCH] D12362: [clang-format] Add support of consecutive declarations alignment

berenm added a comment. Thanks, I don't have commit access. http://reviews.llvm.org/D12362 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13357: [Concepts] Add diagnostic; specializations of variable and function concepts

hubert.reinterpretcast added inline comments. Comment at: test/CXX/concepts-ts/dcl.dcl/dcl.spec/dcl.concept/p7.cpp:4 @@ +3,3 @@ +template concept bool VCEI { true }; +template concept bool VCEI; // expected-error {{variable concept cannot be explicitly instantiated}} +

Re: [PATCH] D13317: clang_Cursor_getMangling shouldn't mangle if the declaration isn't mangled

michaelwu updated this revision to Diff 36330. michaelwu added a comment. Thanks for the review. I switched to shouldMangleDeclName instead of shouldMangleCXXName, and made it skip the frontend mangling instead of returning an empty string. I tried making mangleName do that instead, but it

[PATCH] D13375: [MSVC] Fix for http://llvm.org/PR24132: __declspec(property): double invocations of foo() when compiling foo()->propertyName

ABataev created this revision. ABataev added a reviewer: rnk. ABataev added a subscriber: cfe-commits. Removes extra codegen for base expression of MS property call http://reviews.llvm.org/D13375 Files: lib/Sema/SemaPseudoObject.cpp test/CodeGenCXX/ms-property.cpp Index:

Re: [PATCH] D13330: Implement __attribute__((unique_instantiation))

loladiro added inline comments. Comment at: include/clang/Basic/Attr.td:1462 @@ +1461,3 @@ +def UniqueInstantiation : InheritableAttr { + let Spellings = [GCC<"unique_instantiation">]; + let Subjects = SubjectList<[CXXRecord]>; loladiro wrote: > aaron.ballman

[libcxx] r248993 - Attempt to prevent flaky thread.mutex tests by once again increasing timing tolerances

Author: ericwf Date: Thu Oct 1 03:34:37 2015 New Revision: 248993 URL: http://llvm.org/viewvc/llvm-project?rev=248993=rev Log: Attempt to prevent flaky thread.mutex tests by once again increasing timing tolerances Modified:

Re: [PATCH] D13062: [libcxx] Fix PR24779 -- Prevent evaluation of std::is_default_constructible in clearly ill-formed tuple constructor.

EricWF abandoned this revision. EricWF added a comment. This change is garbage. Sorry for the noise. http://reviews.llvm.org/D13062 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13292: Add support for 'cbegin()' and 'cend()' on modernize-loop-convert.

angelgarcia updated this revision to Diff 36198. angelgarcia added a comment. Yes, right now it is pretty hard to figure out what some of the tests are for, they are a bit messy. I plan to do something about it, but for now I added a comment on that test. http://reviews.llvm.org/D13292

[clang-tools-extra] r248994 - Add support for 'cbegin()' and 'cend()' on modernize-loop-convert.

Author: angelgarcia Date: Thu Oct 1 03:57:11 2015 New Revision: 248994 URL: http://llvm.org/viewvc/llvm-project?rev=248994=rev Log: Add support for 'cbegin()' and 'cend()' on modernize-loop-convert. Summary: This fixes https://llvm.org/bugs/show_bug.cgi?id=22196 . Also add a non-trivially

Re: [PATCH] D13292: Add support for 'cbegin()' and 'cend()' on modernize-loop-convert.

This revision was automatically updated to reflect the committed changes. Closed by commit rL248994: Add support for 'cbegin()' and 'cend()' on modernize-loop-convert. (authored by angelgarcia). Changed prior to commit: http://reviews.llvm.org/D13292?vs=36198=36200#toc Repository: rL LLVM

Re: [PATCH] D13081: [clang-tidy] Implement FixitHints for identifier references in IdentifierNamingCheck

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. The patch looks good with one comment. I'll fix it and submit the patch for you. Thank you for working on this! Comment at:

Re: [PATCH] D13081: [clang-tidy] Implement FixitHints for identifier references in IdentifierNamingCheck

This revision was automatically updated to reflect the committed changes. Closed by commit rL248996: [clang-tidy] Implement FixitHints for identifier references in… (authored by alexfh). Changed prior to commit: http://reviews.llvm.org/D13081?vs=35974=36202#toc Repository: rL LLVM

[clang-tools-extra] r248996 - [clang-tidy] Implement FixitHints for identifier references in IdentifierNamingCheck

Author: alexfh Date: Thu Oct 1 04:19:40 2015 New Revision: 248996 URL: http://llvm.org/viewvc/llvm-project?rev=248996=rev Log: [clang-tidy] Implement FixitHints for identifier references in IdentifierNamingCheck This diff requires http://reviews.llvm.org/D13079 to be applied first. I wasn't

[clang-tools-extra] r248997 - [clang-tidy] fix add_new_check.py

Author: alexfh Date: Thu Oct 1 04:23:20 2015 New Revision: 248997 URL: http://llvm.org/viewvc/llvm-project?rev=248997=rev Log: [clang-tidy] fix add_new_check.py Before this check, I would get the following error: Updating ./misc/CMakeLists.txt... Creating ./misc/NoReinterpret_castCheck.h...

Re: [PATCH] D13272: [clang-tidy] fix add_new_check.py

alexfh added a comment. In http://reviews.llvm.org/D13272#256305, @mgehre wrote: > Yes, please. Btw, I'm going to submit some diffs for clang-tidy checks (for > the CppCoreGuidelines). Which reviewers should I set on them? Please always add me to the reviewers and cfe-commits to Subscribers.

Re: [PATCH] D13292: Add support for 'cbegin()' and 'cend()' on modernize-loop-convert.

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. ... Which indicates that the tests might need better names and more comments, so I don't mess them up next time :D http://reviews.llvm.org/D13292

Re: [PATCH] D13249: Divide TraverseInitListExpr to a different function for each form.

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. LG http://reviews.llvm.org/D13249 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D13081: [clang-tidy] Implement FixitHints for identifier references in IdentifierNamingCheck

alexfh added inline comments. Comment at: clang-tidy/readability/IdentifierNamingCheck.cpp:548 @@ +547,3 @@ + } + + if (const auto *Loc = Result.Nodes.getNodeAs("typeLoc")) { alexfh wrote: > Note, that I suggested to use `Loc->getType()->getDecl()`, which uses

Re: [PATCH] D13081: [clang-tidy] Implement FixitHints for identifier references in IdentifierNamingCheck

alexfh added a comment. Also note, that in October I'll be mostly unavailable, but other clang-tidy contributors can do the review and help getting patches in: sbenza, bkramer, aaron.ballman. Repository: rL LLVM http://reviews.llvm.org/D13081