tfiala added a comment.
Ah nice. Thanks!
-Todd
Repository:
rL LLVM
http://reviews.llvm.org/D13482
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Ah nice. Thanks!
-Todd
> On Oct 13, 2015, at 5:28 PM, Ed Maste wrote:
>
> emaste added a comment.
>
>> Can we get this fixed or reversed out? Thanks!
>
>
> It's already reverted.
>
>
> Repository:
> rL LLVM
>
> http://reviews.llvm.org/D13482
>
>
>
tfiala added a subscriber: tfiala.
tfiala added a comment.
This change appears to have broken quite a few builders.
Can we get this fixed or reversed out? Thanks!
http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA_build/7935/
tfiala added a comment.
Oh no worries, just wanted to make sure wasn't missed, that's all.
-Todd
Repository:
rL LLVM
http://reviews.llvm.org/D13482
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
On Tue, Oct 13, 2015 at 6:54 PM, Sean Silva wrote:
> On Tue, Oct 13, 2015 at 6:14 PM, Richard Smith
> wrote:
>
>> On Tue, Oct 13, 2015 at 5:31 PM, Sean Silva
>> wrote:
>>
>>> On Tue, Oct 13, 2015 at 3:17 PM, Richard Smith via
EricWF added a comment.
For the most part this looks good. I'm a touch concerned though about the
changes to the static initialization. The initializer is moved from within the
function body to outside it. Could you have somebody confirm this won't affect
the existing ABI?
Author: echristo
Date: Wed Oct 14 00:40:11 2015
New Revision: 250270
URL: http://llvm.org/viewvc/llvm-project?rev=250270=rev
Log:
Remove the optimization option from this test as it is unnecessary
and front end tests should avoid this if possible.
Modified:
Author: abataev
Date: Tue Oct 13 23:05:42 2015
New Revision: 250265
URL: http://llvm.org/viewvc/llvm-project?rev=250265=rev
Log:
[MSVC] Fix for http://llvm.org/PR24132: __declspec(property): double
invocations of foo() when compiling foo()->propertyName
Removes extra codegen for base expression
This is breaking llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast:
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/1358/steps/test/logs/stdio
On Tue, Oct 13, 2015 at 6:09 PM, Ekaterina Romanova via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: kromanova
ABataev added a comment.
I see, no problems, thanks!
Best regards,
Alexey Bataev
=
Software Engineer
Intel Compiler Team
Intel Corp.
http://reviews.llvm.org/D13375
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ABataev added a comment.
In http://reviews.llvm.org/D13336#257628, @rnk wrote:
> I think fundamentally we are doing too much declspec property lowering in
> Sema. We might want to back up and figure out how to do it in IRGen. Right
> now we have bugs like this, which are probably more
Author: echristo
Date: Wed Oct 14 00:40:21 2015
New Revision: 250271
URL: http://llvm.org/viewvc/llvm-project?rev=250271=rev
Log:
Canonicalize some of the x86 builtin tests and either remove or comment
about optimization options.
Modified:
cfe/trunk/test/CodeGen/3dnow-builtins.c
delena added a comment.
You should add the "xsave" features to all appropriate CPUs. It can be done in
a separate patch.
LGTM.
Repository:
rL LLVM
http://reviews.llvm.org/D13014
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
Comment at: clang-tidy/modernize/MakeUniqueCheck.cpp:125-128
@@ +124,6 @@
+ // Direct initialization with initialization list.
+ // \code
+ // struct S {
klimek added a subscriber: klimek.
Comment at:
clang-tidy/cppcoreguidelines/ProBoundsArrayToPointerDecayCheck.cpp:40
@@ +39,3 @@
+
+ diag(MatchedCast->getExprLoc(), "do not (implicitly) convert an array to a
pointer");
+}
Can't we provide a fixit?
ABataev updated this revision to Diff 37218.
ABataev marked 3 inline comments as done.
ABataev added a comment.
Update after review
http://reviews.llvm.org/D10599
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/clang/Basic/DiagnosticParseKinds.td
klimek added a reviewer: milianw.
klimek added a comment.
+milian - can you take a look at this patch (or do you know somebody who might
be in a good position to review)
http://reviews.llvm.org/D10833
___
cfe-commits mailing list
comex added inline comments.
Comment at: lib/Sema/SemaType.cpp:2654-2655
@@ -2648,4 +2653,4 @@
case Declarator::ConversionIdContext:
if (!SemaRef.getLangOpts().CPlusPlus14)
-Error = 12; // conversion-type-id
+Error = 14; // conversion-type-id
danielmarjamaki updated this revision to Diff 37223.
danielmarjamaki added a comment.
Minor cleanups and refactorings
http://reviews.llvm.org/D12359
Files:
include/clang/AST/Decl.h
include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/DiagnosticSemaKinds.td
comex added inline comments.
Comment at: lib/Sema/SemaType.cpp:2675-2678
@@ -2671,5 +2674,6 @@
break;
case Declarator::ConversionIdContext:
- if (!SemaRef.getLangOpts().CPlusPlus14)
-Error = 12; // conversion-type-id
+ if
ABataev marked 3 inline comments as done.
Comment at: include/clang/Basic/Attr.td:2098-2102
@@ +2097,7 @@
+ let Documentation = [OMPDeclareSimdDocs];
+ let AdditionalMembers = [{
+ void printPrettyPragma(raw_ostream , const PrintingPolicy ) const {
+OS << "\n";
+ }
+ }];
klimek added inline comments.
Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:418-419
@@ +417,4 @@
+unsigned Pos;
+int Type;
+int ErrorId;
+ };
These need to be documented.
Comment at:
klimek added a subscriber: klimek.
klimek added a reviewer: milianw.
klimek added a comment.
This LG, looping in Milian for a second opinion / to find more reviewers :)
http://reviews.llvm.org/D13388
___
cfe-commits mailing list
klimek added reviewers: aaron.ballman, rnk.
klimek added a comment.
+aaron for windows specific knowledge
+rnk to see whether we can get a reviewer with more MS VS experience (perhaps
somebody from MS :)
My main concern is that this adds a lot of things that I have no idea whether
they are
aaron.ballman added a comment.
Should there be an exception to this diagnostic for code involving Boolean
values? e.g.,
void f(bool a, bool b, bool c) {
if (a == b == c)
;
}
At the very least, it seems like this should also follow GCC's behavior and
suggest parenthesis directly.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL250158: [X86] Add XSAVE intrinsic family (authored by
aaboud).
Changed prior to commit:
http://reviews.llvm.org/D13014?vs=37108=37238#toc
Repository:
rL LLVM
http://reviews.llvm.org/D13014
Files:
Author: aaboud
Date: Tue Oct 13 07:29:35 2015
New Revision: 250158
URL: http://llvm.org/viewvc/llvm-project?rev=250158=rev
Log:
[X86] Add XSAVE intrinsic family
Add intrinsics for the
XSAVE instructions (XSAVE/XSAVE64/XRSTOR/XRSTOR64)
XSAVEOPT instructions (XSAVEOPT/XSAVEOPT64)
XSAVEC
milianw added a comment.
This looks good to me, but it's missing a unit test. Take a look at
http://reviews.llvm.org/D13388 for how to do that in principle.
http://reviews.llvm.org/D10833
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
milianw added a comment.
Yep, looks good to me as well - thanks!
http://reviews.llvm.org/D13388
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman added inline comments.
Comment at:
clang-tidy/cppcoreguidelines/ProBoundsArrayToPointerDecayCheck.cpp:40
@@ +39,3 @@
+
+ diag(MatchedCast->getExprLoc(), "do not (implicitly) convert an array to a
pointer");
+}
klimek wrote:
> aaron.ballman wrote:
aaron.ballman added inline comments.
Comment at: tools/clang-format-vs/ClangFormat/ClangFormatPackage.cs:82
@@ -42,1 +81,3 @@
+ " - Predefined styles ('LLVM', 'Google', 'Chromium',
'Mozilla', 'WebKit').\n" +
+ " - 'file' to search for a
Author: d0k
Date: Tue Oct 13 10:19:32 2015
New Revision: 250164
URL: http://llvm.org/viewvc/llvm-project?rev=250164=rev
Log:
[Driver] Use the parent_path of the clang executable as the default InstalledDir
This is what most people want anyways. Clang -cc1's main() will override
this but for
Author: aaronballman
Date: Tue Oct 13 10:24:33 2015
New Revision: 250165
URL: http://llvm.org/viewvc/llvm-project?rev=250165=rev
Log:
Expose the clang-tidy misc-assign-operator-signature checker as
cppcoreguidelines-c-copy-assignment-signature.
Modified:
tharvik added a comment.
In http://reviews.llvm.org/D13465#260846, @jroelofs wrote:
> In http://reviews.llvm.org/D13465#260628, @tharvik wrote:
>
> > When running the test suite, it gives a bunch of `undefined reference to
> > '__safestack_unsafe_stack_ptr'`.
> > See regression results
aaron.ballman added inline comments.
Comment at:
clang-tidy/cppcoreguidelines/ProBoundsArrayToPointerDecayCheck.cpp:29
@@ +28,3 @@
+ implicitCastExpr(unless(hasParent(arraySubscriptExpr())),
+
aaron.ballman added a comment.
Generally looks good to me, with a few small nits.
Comment at: tools/clang-format-vs/ClangFormat/ClangFormatPackage.cs:57
@@ +56,3 @@
+{
+StandardValuesCollection svc = new
StandardValuesCollection(values);
+
aaron.ballman added a comment.
LGTM, but someone who understands VS plugins better should give the final
sign-off.
Comment at: tools/clang-format-vs/ClangFormat/ClangFormatPackage.cs:309
@@ +308,3 @@
+uint _;
+IVsHierarchy __;
+string
klimek added inline comments.
Comment at:
clang-tidy/cppcoreguidelines/ProBoundsArrayToPointerDecayCheck.cpp:40
@@ +39,3 @@
+
+ diag(MatchedCast->getExprLoc(), "do not (implicitly) convert an array to a
pointer");
+}
aaron.ballman wrote:
> klimek wrote:
> >
curdeius added inline comments.
Comment at: tools/clang-format-vs/ClangFormat/ClangFormatPackage.cs:57
@@ +56,3 @@
+{
+StandardValuesCollection svc = new
StandardValuesCollection(values);
+return svc;
aaron.ballman
curdeius updated this revision to Diff 37253.
curdeius added a comment.
Applied Aaron's comments. Removed unused using.
http://reviews.llvm.org/D13549
Files:
tools/clang-format-vs/ClangFormat/ClangFormatPackage.cs
tools/clang-format-vs/ClangFormat/Properties/AssemblyInfo.cs
curdeius marked 7 inline comments as done.
curdeius added a comment.
Applied comments and done some minor clean up.
http://reviews.llvm.org/D13549
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
thakis added inline comments.
Comment at: test/SemaCXX/auto-type-from-cxx.cpp:14
@@ +13,3 @@
+ auto _ = [](__auto_type f) {}; // expected-error {{'__auto_type' not allowed
in lambda parameter}}
+ __auto_type g = 2;
+ struct BitField { int field:2; };
comex
Author: aaronballman
Date: Tue Oct 13 10:42:06 2015
New Revision: 250166
URL: http://llvm.org/viewvc/llvm-project?rev=250166=rev
Log:
Appeasing build bots by linking in the proper libraries.
Modified:
clang-tools-extra/trunk/clang-tidy/cppcoreguidelines/CMakeLists.txt
Modified:
aaron.ballman added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:201
@@ -200,1 +200,3 @@
+def warn_nonconst_parameter : Warning<"parameter %0 can be const">,
+ InGroup, DefaultIgnore;
def warn_unused_variable : Warning<"unused variable %0">,
NoQ updated this revision to Diff 37267.
NoQ added a comment.
A, another mis-submit. Sorry for the noise.
http://reviews.llvm.org/D12726
Files:
docs/analyzer/DebugChecks.rst
include/clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h
jroelofs added a comment.
Other than that, LGTM too.
Comment at: lib/Driver/ToolChains.cpp:4081
@@ +4080,3 @@
+
+ std::string PS4SDKDir = (EnvValue ? EnvValue : getDriver().Dir + "/../..");
+
Use `llvm::sys::path::append` instead of `std::string::operator+`
(Jonathan's review here is fine, don't wait on me. Thanks! :)
-eric
On Tue, Oct 13, 2015 at 10:32 AM Jonathan Roelofs
wrote:
> jroelofs added a comment.
>
> Other than that, LGTM too.
>
>
>
> Comment at: lib/Driver/ToolChains.cpp:4081
> @@ +4080,3 @@
aaron.ballman added a comment.
In http://reviews.llvm.org/D12922#265452, @ahatanak wrote:
> I think there are a couple of things that have to be discussed:
>
> 1. Name of the attribute: Should it be "notail" or "notailcall"? Perhaps it
> should be named something like "nodirecttail" to indicate
echristo added a subscriber: echristo.
echristo added a comment.
(Jonathan's review here is fine, don't wait on me. Thanks! :)
-eric
Repository:
rL LLVM
http://reviews.llvm.org/D13482
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
NoQ added a subscriber: NoQ.
NoQ added a comment.
While investigating http://reviews.llvm.org/D12726 , i accidentally came up
with a way to test this patch; with the extension of `ExprInspectionChecker` in
the aforementioned review, which allows testing SymbolReaper directly, the
following
kromanova added a comment.
Thank you! I will rebase and commit shortly
Katya.
Repository:
rL LLVM
http://reviews.llvm.org/D13482
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: dougk
Date: Tue Oct 13 11:22:51 2015
New Revision: 250173
URL: http://llvm.org/viewvc/llvm-project?rev=250173=rev
Log:
Always pass a -dwarf-version argument to integrated as.
This removes the default of 3 hidden in the assembler previously.
Fixes breakage caused by r249655, reported by
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Thanks, sorry for the delay, EH was keeping me busy. =/
http://reviews.llvm.org/D13375
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
rnk added inline comments.
Comment at: lib/Sema/TreeTransform.h:9138
@@ +9137,3 @@
+ isa(D))
+return getSema().BuildPossibleImplicitMemberExpr(
+SS, SourceLocation(), R, /*TemplateArgs=*/nullptr,
I believe this will always fail, so
eugenis created this revision.
eugenis added reviewers: mclow.lists, EricWF.
eugenis added a subscriber: cfe-commits.
eugenis set the repository for this revision to rL LLVM.
Libcxxabi tests are built against non-installed libc++ headers, and they need
to know the ABI version libc++ is
comex added inline comments.
Comment at: test/SemaCXX/auto-type-from-cxx.cpp:14
@@ +13,3 @@
+ auto _ = [](__auto_type f) {}; // expected-error {{'__auto_type' not allowed
in lambda parameter}}
+ __auto_type g = 2;
+ struct BitField { int field:2; };
thakis
thakis added inline comments.
Comment at: test/SemaCXX/auto-type-from-cxx.cpp:14
@@ +13,3 @@
+ auto _ = [](__auto_type f) {}; // expected-error {{'__auto_type' not allowed
in lambda parameter}}
+ __auto_type g = 2;
+ struct BitField { int field:2; };
comex
rnk added a comment.
Richard suggested that maybe we formed the wrong AST while parsing the
template. I'm not sure that's the case. We have this very explicit logic that
controls what AST nodes we form in SemaExprMember.cpp
ClassifyImplicitMemberAccess:
bool isStaticContext =
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
What is preventing to add this check to Clang-tidy? Just found another piece of
fresh C++ code in LLDB with (void) as argument list...
http://reviews.llvm.org/D7639
davidxl abandoned this revision.
davidxl added a comment.
The refactoring is done by a previous patch already.
http://reviews.llvm.org/D13326
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
rnk updated this revision to Diff 37283.
rnk added a comment.
- Rebase
http://reviews.llvm.org/D6700
Files:
lib/Sema/TreeTransform.h
test/SemaTemplate/instantiate-using-decl.cpp
Index: test/SemaTemplate/instantiate-using-decl.cpp
NoQ updated this revision to Diff 37263.
NoQ added a comment.
Hmm, i think i'm ready to explain most of the stuff.
- First of all, the piece of code in `EnvironmentManager::removeDeadBindings()`
i mentioned above is truly useless; everything would be marked as live anyway
on the next line.
-
NoQ updated this revision to Diff 37266.
NoQ added a comment.
Whoops accidentally left out a dead code line in tests.
http://reviews.llvm.org/D12726
Files:
docs/analyzer/DebugChecks.rst
include/clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h
george.burgess.iv created this revision.
george.burgess.iv added a reviewer: rsmith.
george.burgess.iv added a subscriber: cfe-commits.
Two smallish patches in one. Happy to split into two (for review and/or commit)
if that's preferred.
In C, we allow (as an extension) incompatible pointer
Author: aaronballman
Date: Tue Oct 13 13:13:10 2015
New Revision: 250194
URL: http://llvm.org/viewvc/llvm-project?rev=250194=rev
Log:
Updating the documentation for the
readability-inconsistent-declaration-parameter-name checker.
Patch by Piotr Dziwinski.
Modified:
Author: cbieneman
Date: Tue Oct 13 13:17:30 2015
New Revision: 250196
URL: http://llvm.org/viewvc/llvm-project?rev=250196=rev
Log:
[CMake] When building clang as an external project we should pass through all
variables that start with COMPILER_RT
Modified:
cfe/trunk/runtime/CMakeLists.txt
Author: echristo
Date: Tue Oct 13 13:40:21 2015
New Revision: 250203
URL: http://llvm.org/viewvc/llvm-project?rev=250203=rev
Log:
Move the adc-builtins test to the pattern of the other builtins
tests by predefining _MM_MALLOC_H rather than use -ffreestanding.
Modified:
Author: echristo
Date: Tue Oct 13 13:40:17 2015
New Revision: 250202
URL: http://llvm.org/viewvc/llvm-project?rev=250202=rev
Log:
Add subtarget feature support for 3dnowa to the 3dnowa intrinsics.
Modified:
cfe/trunk/lib/Headers/mm3dnow.h
Modified: cfe/trunk/lib/Headers/mm3dnow.h
URL:
Hi Richard,
this commit appears to break the module self-host on Darwin.
When compiling the following program generated by clang’s own cmake script:
> #undef NDEBUG
> #include
> #define NDEBUG
> #include
> int main() { assert(this code is not compiled); }
with clang++ -std=c++11 -fmodules
I would rather not do this if possible but I understand why we need to do
it.
Richard is there a cost associated with the 'extern "C++"' construct? or by
forcing the compiler to switch modes in general?
On Mon, Oct 12, 2015 at 12:27 PM, Richard Smith
wrote:
> On Mon,
Author: aaronballman
Date: Tue Oct 13 15:42:41 2015
New Revision: 250221
URL: http://llvm.org/viewvc/llvm-project?rev=250221=rev
Log:
Exposing an existing checker under the name cert-err61-cpp, as it corresponds
to the CERT C++ secure coding rule:
rjmccall added inline comments.
Comment at: lib/Sema/TreeTransform.h:9135
@@ +9134,3 @@
+if (NamedDecl *D = R.getAsSingle()) {
+ D = D->getUnderlyingDecl();
+ if (isa(D) || isa(D) ||
getAsSingle already looks through to the underlying decl.
rjmccall added a comment.
As a more general comment, I believe the rule is that we try to always make a
MemberExpr/UnresolvedMemberExpr whenever there *might* be a base, but that the
resulting distinction between an implicit-base UnresolvedMemberExpr and an
UnresolvedLookupExpr is not actually
EricWF accepted this revision.
EricWF added a reviewer: EricWF.
EricWF added a comment.
This revision is now accepted and ready to land.
Maintainers from Apple and FreeBSD gave this the thumbs up.
http://reviews.llvm.org/D13407
___
cfe-commits
rjmccall added a comment.
This is an inappropriate fix for this problem. If these runtime functions can
never throw, which seems to be the case, you should create the function type
with a no-throw exception specification, which will make EmitCall emit the call
with a CallInst.
dcoughlin added a comment.
> There is a loss of precision for loops that need to be executed exactly
> maxBlockVisitOnPath times, as the loop body is executed with the widened
> state instead of the last iteration.
I think this is an acceptable loss of precision because, in general, it is
Author: ericwf
Date: Tue Oct 13 17:12:02 2015
New Revision: 250235
URL: http://llvm.org/viewvc/llvm-project?rev=250235=rev
Log:
[libcxx] Capture configuration information when installing the libc++ headers
Summary:
Hi all,
This patch is a successor to D11963. However it has changed dramatically
emaste added a subscriber: emaste.
Comment at: cfe/trunk/lib/Driver/ToolChains.cpp:4080
@@ +4079,3 @@
+ SmallString<512> PS4SDKDir;
+ if (const char *EnvValue = getenv("SCE_PS4_SDK_DIR"))
+if (!llvm::sys::fs::exists(EnvValue))
Looks like a missing { here
rnk updated this revision to Diff 37303.
rnk added a comment.
- Remove duplicate tests, beef them up
http://reviews.llvm.org/D6700
Files:
include/clang/Sema/Sema.h
lib/Sema/SemaExprMember.cpp
lib/Sema/TreeTransform.h
test/SemaCXX/using-decl-1.cpp
Author: ericwf
Date: Tue Oct 13 19:22:05 2015
New Revision: 250261
URL: http://llvm.org/viewvc/llvm-project?rev=250261=rev
Log:
Use __config_site when building libc++. Also cleanup ABI versioning doc
Added:
libcxx/trunk/docs/DesignDocs/ABIVersioning.rst
Removed:
libcxx/trunk/docs/Abi.rst
emaste added a comment.
> Can we get this fixed or reversed out? Thanks!
It's already reverted.
Repository:
rL LLVM
http://reviews.llvm.org/D13482
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
eugenis closed this revision.
eugenis added a comment.
Landed as r250254, thanks for the review!
Repository:
rL LLVM
http://reviews.llvm.org/D11740
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
EricWF added a comment.
http://reviews.llvm.org/D13407 has landed and this is good to go.
Repository:
rL LLVM
http://reviews.llvm.org/D11740
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
This change LGTM. Let's hold off on the using "_Static_assert" until we
understand how that would work with "-pedantic" when the macro is expanded
in user code.
/Eric
On Tue, Oct 13, 2015 at 4:19 PM, Richard Smith
wrote:
> On Tue, Oct 13, 2015 at 2:12 PM, Eric Fiselier
Thanks! I just committed the patch.
Katya.
> -Original Message-
> From: Jonathan Roelofs [mailto:jonat...@codesourcery.com]
> Sent: Tuesday, October 13, 2015 3:40 PM
> To: Romanova, Katya; al...@leftfield.org; Robinson, Paul;
> echri...@gmail.com; filcab+llvm.phabrica...@gmail.com;
>
Author: ericwf
Date: Tue Oct 13 18:56:33 2015
New Revision: 250256
URL: http://llvm.org/viewvc/llvm-project?rev=250256=rev
Log:
Workaround -pedantic flag added by LLVM
Modified:
libcxx/trunk/CMakeLists.txt
Modified: libcxx/trunk/CMakeLists.txt
URL:
Author: rsmith
Date: Tue Oct 13 17:13:33 2015
New Revision: 250236
URL: http://llvm.org/viewvc/llvm-project?rev=250236=rev
Log:
Remove __config module to avoid #include cycle when libc headers include
libc++'s headers.
Modified:
libcxx/trunk/include/module.modulemap
Modified:
On Tue, Oct 13, 2015 at 2:12 PM, Eric Fiselier via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> I would rather not do this if possible but I understand why we need to do
> it.
>
> Richard is there a cost associated with the 'extern "C++"' construct? or
> by forcing the compiler to switch
jroelofs accepted this revision.
jroelofs added a comment.
This revision is now accepted and ready to land.
http://reviews.llvm.org/D13407 has landed.
http://reviews.llvm.org/D13673
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
This revision was automatically updated to reflect the committed changes.
Closed by commit rL250237: [analyzer] Don’t invalidate CXXThis when
conservatively evaluating const… (authored by dcoughlin).
Changed prior to commit:
http://reviews.llvm.org/D13099?vs=37084=37291#toc
Repository:
rL
EricWF requested changes to this revision.
EricWF added a comment.
This revision now requires changes to proceed.
I don't think this is ready to go. Please don't commit yet. Sorry @jroelofs.
Comment at: CMakeLists.txt:309
@@ -307,1 +308,3 @@
jroelofs accepted this revision.
jroelofs added a reviewer: jroelofs.
jroelofs added a comment.
One small suggestion. Otherwise, this still LGTM.
Comment at: lib/Driver/ToolChains.cpp:4078
@@ +4077,3 @@
+ // should be /host_tools/bin.
+ const char *EnvValue =
EricWF added a comment.
This is fine as a temporary workaround but it's not complete. I would rather do
something better.
Repository:
rL LLVM
http://reviews.llvm.org/D13705
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
EricWF added a comment.
Please address the inline comment. I think with that change we can hold off
modifying libc++abi.
Comment at: test/libcxx/test/config.py:444
@@ -442,1 +443,3 @@
+def configure_compile_flags_abi_version(self):
+abi_version =
Author: cbieneman
Date: Tue Oct 13 18:03:54 2015
New Revision: 250246
URL: http://llvm.org/viewvc/llvm-project?rev=250246=rev
Log:
[CMake]Getting rid of references to LLVM_SUBMIT_VERSION and
LLVM_SUBMIT_SUBVERSION in favor of LLVM_VERSION_MAJOR and LLVM_VERSION_MINOR.
LLVM_SUBMIT_VERSION and
Author: rsmith
Date: Tue Oct 13 18:12:22 2015
New Revision: 250247
URL: http://llvm.org/viewvc/llvm-project?rev=250247=rev
Log:
Fix use of libc++ headers from within an 'extern "C"' context in C++98.
Previously, this resulted in us declaring a template for static_assert
emulation within the
eugenis added inline comments.
Comment at: test/libcxx/test/config.py:444
@@ -442,1 +443,3 @@
+def configure_compile_flags_abi_version(self):
+abi_version = self.get_lit_conf('abi_version', '').strip()
EricWF wrote:
> Please allow abi_version to be
This revision was automatically updated to reflect the committed changes.
Closed by commit rL250252: This patch adds missing pieces to clang, including
the PS4 toolchain (authored by kromanova).
Changed prior to commit:
http://reviews.llvm.org/D13482?vs=37292=37301#toc
Repository:
rL LLVM
Author: kromanova
Date: Tue Oct 13 18:40:02 2015
New Revision: 250252
URL: http://llvm.org/viewvc/llvm-project?rev=250252=rev
Log:
This patch adds missing pieces to clang, including the PS4 toolchain
definition, added warnings, PS4 defaults, and Driver changes needed for
our compiler.
A patch by
EricWF added a comment.
LGTM. We'll fix the libc++abi issue later.
Repository:
rL LLVM
http://reviews.llvm.org/D11740
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1 - 100 of 122 matches
Mail list logo