djasper added inline comments.
Comment at: lib/Format/ContinuationIndenter.h:35
@@ -34,1 +34,3 @@
+/// \brief Helper class for breaking a logical line into multiple physical
+/// lines. Manages moving state from one physical line to the next.
You are the first
mclow.lists marked 3 inline comments as done.
mclow.lists added a comment.
http://reviews.llvm.org/D15862
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mclow.lists updated this revision to Diff 44703.
mclow.lists added a comment.
Last change, I hope. I added some more tests to make sure that string was
correctly identifying throwing vs. non-throwing iterators, and I discovered
that I had an `#ifdef` backwards. Fixing that revealed a bug in
`__
hokein added inline comments.
Comment at: clang-tidy/ClangTidyOptions.h:216
@@ +215,3 @@
+/// HeaderFileExtensions.
+bool endWithHeaderFileExtensions(llvm::StringRef FileName,
+ llvm::StringRef HeaderFileExtensions);
aaron.ballman w
Author: eugenezelenko
Date: Tue Jan 12 20:03:50 2016
New Revision: 257562
URL: http://llvm.org/viewvc/llvm-project?rev=257562&view=rev
Log:
Install scan-build and scan-view only if Static Analyzer was enabled.
Modified:
cfe/trunk/tools/CMakeLists.txt
Modified: cfe/trunk/tools/CMakeLists.txt
This revision was automatically updated to reflect the committed changes.
Closed by commit rL257559: [Bugfix] Fix ICE on constexpr vector splat.
(authored by gbiv).
Changed prior to commit:
http://reviews.llvm.org/D14877?vs=44187&id=44701#toc
Repository:
rL LLVM
http://reviews.llvm.org/D148
Author: gbiv
Date: Tue Jan 12 19:52:39 2016
New Revision: 257559
URL: http://llvm.org/viewvc/llvm-project?rev=257559&view=rev
Log:
[Bugfix] Fix ICE on constexpr vector splat.
In {CG,}ExprConstant.cpp, we weren't treating vector splats properly.
This patch makes us treat splats more properly.
Add
MatzeB accepted this revision.
MatzeB added a comment.
This revision is now accepted and ready to land.
LGTM, though you should wait a week or two for other opinions before committing.
http://reviews.llvm.org/D16115
___
cfe-commits mailing list
cfe-
mclow.lists added inline comments.
Comment at: include/iterator:442
@@ +441,3 @@
+struct __is_exactly_input_iterator
+: public integral_constant::iterator_category, input_iterator_tag>::value> {};
+
Sigh. Yes, `boost::input_output_iterator_tag` (and probably o
Author: jlebar
Date: Tue Jan 12 19:24:35 2016
New Revision: 257557
URL: http://llvm.org/viewvc/llvm-project?rev=257557&view=rev
Log:
[CUDA] Rename check-prefixes in cuda-options.cu and cuda-unused-arg-warning.cu.
Summary:
Rename the args to be more human-readable. Among other things, this
lets u
Author: bwilson
Date: Tue Jan 12 19:19:02 2016
New Revision: 257556
URL: http://llvm.org/viewvc/llvm-project?rev=257556&view=rev
Log:
Generalize r256026 to apply to all MachO targets, not just Darwin targets.
The PIC default is set for the MachO toolchain, not just the Darwin toolchain,
so this t
pcc added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:2620
@@ +2619,3 @@
+ Builder.CreateICmpEQ(Data, llvm::ConstantPointerNull::get(Int8PtrTy));
+ Builder.CreateCondBr(DataIsNullPtr, TrapBB, ContBB);
+
This looks like `CodeGenFunction::EmitTrapCheck
Author: jlebar
Date: Tue Jan 12 19:07:35 2016
New Revision: 257554
URL: http://llvm.org/viewvc/llvm-project?rev=257554&view=rev
Log:
[CUDA] Report an error if code tries to mix incompatible CUDA attributes.
Summary: Thanks to jhen for helping me figure this out.
Reviewers: tra, echristo
Subscri
rsmith accepted this revision.
This revision is now accepted and ready to land.
Comment at: lib/CodeGen/CGExprScalar.cpp:816-817
@@ +815,4 @@
+// the same as the vector's element type (sans qualifiers)
+assert(DstType->castAs()->getElementType().getTypePtr() ==
+
ISTM that there's no established way to tell Sema::Diag to not emit its
diagnostic, and trying to swap to e.g. Sema::CanPerformCopyInitialization
makes us too forgiving. So, given that we need to use
CheckSingleAssignmentConstraints directly, I don't see a better way to
handle this than plumbing th
dcoughlin closed this revision.
dcoughlin added a comment.
This was committed in r257533. Thanks Laszlo!
http://reviews.llvm.org/D9600
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM.
http://reviews.llvm.org/D16082
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ahatanak added a comment.
In http://reviews.llvm.org/D15599#325113, @hans wrote:
> Just out of curiosity, where does this come up in practice?
I only have a short test case a user provided so t's not really clear whether
it was necessary to mark a member function naked or there were other ways
Author: friss
Date: Tue Jan 12 17:47:59 2016
New Revision: 257543
URL: http://llvm.org/viewvc/llvm-project?rev=257543&view=rev
Log:
[Darwin] Fix deployment target detection
There was a thinko in the deployment target detection code that
made the -isysroot parsing have precedence over the environm
tra added a comment.
Richard, I've updated the patch as you've suggested -- it indeed simplifies
things quite a bit and handles the corner cases you've mentioned.
Comment at: lib/CodeGen/CGDeclCXX.cpp:323-324
@@ +322,4 @@
+
+ // The constructor function has no parameters,
+ i
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
Seems reasonable to me, but we should check with Richard.
http://reviews.llvm.org/D15670
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.
LGTM. Thank you!
http://reviews.llvm.org/D15448
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
Author: hans
Date: Tue Jan 12 17:31:58 2016
New Revision: 257541
URL: http://llvm.org/viewvc/llvm-project?rev=257541&view=rev
Log:
Follow-up to r257537: add test that majnemer asked about
Modified:
cfe/trunk/test/Driver/cl-options.c
Modified: cfe/trunk/test/Driver/cl-options.c
URL:
http://l
rnk added a subscriber: rnk.
rnk added a comment.
I thought we already addressed this issue with @rjmccall and decided that, if
the user intentionally declares extern "C" variables with an _Z prefix, then we
know they are intentionally attempting to name some C++ global variable.
I'd rather jus
tra updated this revision to Diff 44687.
tra added a comment.
Check all variable initializers and only allow 'empty constructors' as Richard
has suggested.
Changed test structure so that we test for allowed/disallowed constructors
separately from testing how we handle initialization of base clas
Author: hans
Date: Tue Jan 12 17:17:03 2016
New Revision: 257537
URL: http://llvm.org/viewvc/llvm-project?rev=257537&view=rev
Log:
clang-cl: Support /Dfoo#bar (PR25984)
Such flags will now be translated to -Dfoo=bar.
Modified:
cfe/trunk/lib/Driver/MSVCToolChain.cpp
cfe/trunk/test/Driver/
george.burgess.iv marked 2 inline comments as done.
george.burgess.iv added a comment.
Ping :)
http://reviews.llvm.org/D14877
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
george.burgess.iv added a comment.
Ping :)
http://reviews.llvm.org/D15721
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rizsotto.mailinglist added a comment.
Thank you guys for your review and help! The latest patch is commited. Let's do
the next steps too. ;)
@danielmarjamaki the standalone Bear will be maintained. and your comments will
also be considered.
http://reviews.llvm.org/D9600
___
On 1/12/16 3:38 PM, Laszlo Nagy via cfe-commits wrote:
Author: rizsotto
Date: Tue Jan 12 16:38:41 2016
New Revision: 257533
URL: http://llvm.org/viewvc/llvm-project?rev=257533&view=rev
Log:
D9600: Add scan-build python implementation
Yay!
___
cf
Author: jlebar
Date: Tue Jan 12 16:23:04 2016
New Revision: 257530
URL: http://llvm.org/viewvc/llvm-project?rev=257530&view=rev
Log:
[CUDA] Add explicit mapping from sm_XX to compute_YY.
Summary: This is used by D16082 when it invokes fatbinary.
Reviewers: tra
Subscribers: cfe-commits, jhen, ec
This revision was automatically updated to reflect the committed changes.
Closed by commit rL257530: [CUDA] Add explicit mapping from sm_XX to
compute_YY. (authored by jlebar).
Changed prior to commit:
http://reviews.llvm.org/D16097?vs=44673&id=44675#toc
Repository:
rL LLVM
http://reviews.l
echristo added a comment.
Still good. much nicer now.
http://reviews.llvm.org/D16097
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman added a comment.
Public-facing documentation should also be updated to specify the new option
for the various checkers.
Comment at: clang-tidy/ClangTidy.h:55
@@ +54,3 @@
+ /// Reads the option with the check-local name \p LocalName from local or
+ /// global \c
jlebar updated this revision to Diff 44673.
jlebar added a comment.
Use llvm::StringSwitch instead of a sequence of if statements.
http://reviews.llvm.org/D16097
Files:
include/clang/Driver/Action.h
lib/Driver/Action.cpp
test/Driver/cuda-bad-arch.cu
Index: test/Driver/cuda-bad-arch.cu
==
Author: rsmith
Date: Tue Jan 12 15:59:26 2016
New Revision: 257529
URL: http://llvm.org/viewvc/llvm-project?rev=257529&view=rev
Log:
Improve AST dumping:
1) When dumping a declaration that declares a name for a type, also dump the
named type.
2) Add a #pragma clang __debug dump X, that dumps t
echristo added a comment.
As long as the list of BAD things is somewhat conclusive I don't mind either
way. Just making sure that this was the reason :)
-eric
http://reviews.llvm.org/D16097
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
jlebar added a comment.
In http://reviews.llvm.org/D16097#325093, @echristo wrote:
> Seems reasonable. Why remove all of the tests though?
Previously we were checking that the arch was of the form /^sm_\d+$/ -- now
we're checking that it's one of some list of acceptable things. I figured that
Sorry for the delayed response; one of my filters silently marked this mail
as read. Looking into it now. :)
On Fri, Jan 8, 2016 at 12:38 PM, Bob Wilson wrote:
> George,
>
> This change caused a serious regression for Objective-C method lookup. See
> PR26085 (http://llvm.org/pr26085).
>
> For th
hans added a subscriber: hans.
hans added a reviewer: rnk.
hans added a comment.
Just out of curiosity, where does this come up in practice?
It seems a little backward that we're first emitting a bunch of instructions,
only to remove them later. It would be nice if for naked function we wouldn't
echristo added a comment.
Seems reasonable. Why remove all of the tests though?
http://reviews.llvm.org/D16097
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sbenza added inline comments.
Comment at: unittests/ASTMatchers/ASTMatchersTest.cpp:4994
@@ +4993,3 @@
+ EXPECT_TRUE(matches("typedef int hasUnderlyingTypeTest;",
+ typedefDecl(hasUnderlyingType(asString("int");
+ EXPECT_TRUE(matches("typedef const int T
Author: aaronballman
Date: Tue Jan 12 15:08:27 2016
New Revision: 257522
URL: http://llvm.org/viewvc/llvm-project?rev=257522&view=rev
Log:
Add extra tests for handling throw() and noexcept() specifiers.
Patch by Adrian Zgorzałek
Modified:
clang-tools-extra/trunk/test/clang-tidy/modernize-use
aaron.ballman closed this revision.
aaron.ballman added a comment.
Commit in r257522
http://reviews.llvm.org/D15444
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
http://reviews.llvm.org/D15444
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
aaron.ballman closed this revision.
aaron.ballman added a comment.
Commit in r257521
http://reviews.llvm.org/D15443
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: aaronballman
Date: Tue Jan 12 15:04:22 2016
New Revision: 257521
URL: http://llvm.org/viewvc/llvm-project?rev=257521&view=rev
Log:
Properly track the end location of an exception specification.
Patch by Adrian Zgorzałek
Modified:
cfe/trunk/lib/Parse/ParseDeclCXX.cpp
cfe/trunk/uni
Author: adrian
Date: Tue Jan 12 15:01:56 2016
New Revision: 257520
URL: http://llvm.org/viewvc/llvm-project?rev=257520&view=rev
Log:
Module debugging: Make the module format part of the module hash instead
of the file name. This is consistent with how other HeaderSearchOptions
are handled.
Due to
AndyG added a comment.
Bump! :o)
http://reviews.llvm.org/D15636
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: hans
Date: Tue Jan 12 14:54:36 2016
New Revision: 257516
URL: http://llvm.org/viewvc/llvm-project?rev=257516&view=rev
Log:
Don't store CGOpenMPRegionInfo::CodeGen as a reference (PR26078)
The referenced llvm::function_ref object can go
away before CodeGen is used, resulting in a crash.
M
Author: rsmith
Date: Tue Jan 12 14:34:32 2016
New Revision: 257512
URL: http://llvm.org/viewvc/llvm-project?rev=257512&view=rev
Log:
[modules] Don't diagnose a conflict between two using-declarations that name
equivalent internal linkage entities.
Added:
cfe/trunk/test/Modules/Inputs/using-d
congliu updated this revision to Diff 44661.
congliu added a comment.
- Removed braces; corrected comments; updated test.
http://reviews.llvm.org/D15823
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/VirtualNearMissCheck.cpp
clang-tidy/misc/Virt
congliu marked 9 inline comments as done.
congliu added a comment.
Fixed. For next steps, I will go through the results of clangmr, find out false
alarms, and fix them.
Comment at: clang-tidy/misc/VirtualNearMissCheck.cpp:90
@@ +89,3 @@
+// Check ambiguity.
+if (Paths.i
aaron.ballman added a subscriber: sbenza.
Comment at: unittests/ASTMatchers/ASTMatchersTest.cpp:4994
@@ +4993,3 @@
+ EXPECT_TRUE(matches("typedef int hasUnderlyingTypeTest;",
+ typedefDecl(hasUnderlyingType(asString("int");
+ EXPECT_TRUE(matches("typedef
adek05 added a comment.
Would you mind committing it for me, and I don't have a commit access yet.
Also, could you take a look at http://reviews.llvm.org/D15444 with tests for
clang-tidy related to this change?
http://reviews.llvm.org/D15443
___
cf
mclow.lists updated this revision to Diff 44659.
mclow.lists added a comment.
Made all iterators "noexcept" when building with exceptions turned off.
http://reviews.llvm.org/D15862
Files:
include/algorithm
include/iterator
include/string
test/libcxx/iterators/trivial_iterators.pass.cpp
rsmith added inline comments.
Comment at: include/iterator:442
@@ +441,3 @@
+struct __is_exactly_input_iterator
+: public integral_constant::iterator_category, input_iterator_tag>::value> {};
+
Is it permitted for people to derive their own tag types from
inp
LegalizeAdulthood added inline comments.
Comment at: unittests/ASTMatchers/ASTMatchersTest.cpp:4994
@@ +4993,3 @@
+ EXPECT_TRUE(matches("typedef int hasUnderlyingTypeTest;",
+ typedefDecl(hasUnderlyingType(asString("int");
+ EXPECT_TRUE(matches("typedef
keryell added a subscriber: keryell.
Comment at: include/clang/Basic/Builtins.h:39
@@ -38,2 +38,3 @@
MS_LANG = 0x10, // builtin requires MS mode.
+ OCLC_LANG = 0x20,// builtin for OpenCL C only.
ALL_LANGUAGES = C_LANG | CXX_LANG | OBJC_LANG, // builtin for all languages.
-
betulb updated this revision to Diff 44657.
betulb added a comment.
Addressed vsk's comment on CallSite API use.
http://reviews.llvm.org/D8940
Files:
lib/CodeGen/CGCall.cpp
lib/CodeGen/CodeGenPGO.cpp
lib/CodeGen/CodeGenPGO.h
test/Profile/c-indirect-call.c
Index: test/Profile/c-indirect
mclow.lists added a comment.
I think the best way to handle Richard's question is to specialize
`__libcpp_string_gets_noexcept_iterator` to always return true when exceptions
are turned off.
http://reviews.llvm.org/D15862
___
cfe-commits mailing l
Author: dim
Date: Tue Jan 12 13:40:55 2016
New Revision: 257509
URL: http://llvm.org/viewvc/llvm-project?rev=257509&view=rev
Log:
Add a clang test for r257376 (Ensure -mcpu=xscale works for arm targets).
Added:
cfe/trunk/test/Driver/arm-xscale.c
Added: cfe/trunk/test/Driver/arm-xscale.c
URL:
rsmith added a comment.
Would this be expected to degrade performance for people building with
-fno-exceptions who use iterators with non-noexcept operations (such as LLVM
and Clang)?
http://reviews.llvm.org/D15862
___
cfe-commits mailing list
cfe
Author: marshall
Date: Tue Jan 12 13:15:10 2016
New Revision: 257506
URL: http://llvm.org/viewvc/llvm-project?rev=257506&view=rev
Log:
One more missing std:: qualification from Jonathan
Modified:
libcxx/trunk/test/std/utilities/function.objects/unord.hash/integral.pass.cpp
Modified:
libcxx
MatzeB added a comment.
Putting static-analyzer tests into the test-suite sounds good to me, the static
analyzer is part of llvm so this should be fine. Though I'd like to wait a bit
to hear other opinions on this matter.
As for the patch itself:
- I'd call the directory ClangAnalyzer
- For th
Eugene.Zelenko added a comment.
See http://reviews.llvm.org/D14779 for discussion about Clang-tidy vs Static
Analyzer.
Repository:
rL LLVM
http://reviews.llvm.org/D16008
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
Looks good to me. Please commit!
http://reviews.llvm.org/D16062
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
aaron.ballman added a comment.
In http://reviews.llvm.org/D15998#324821, @mjacob wrote:
> In http://reviews.llvm.org/D15998#324757, @aaron.ballman wrote:
>
> > Can you point me to some documentation on what the semantics of this
> > attribute are? For instance, how does it play with other attrib
Author: spatel
Date: Tue Jan 12 12:03:41 2016
New Revision: 257497
URL: http://llvm.org/viewvc/llvm-project?rev=257497&view=rev
Log:
function names start with a lower case letter ; NFC
Modified:
cfe/trunk/lib/CodeGen/CodeGenFunction.cpp
Modified: cfe/trunk/lib/CodeGen/CodeGenFunction.cpp
URL
jroelofs updated this revision to Diff 44650.
jroelofs added a comment.
Added docs.
http://reviews.llvm.org/D15528
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidy.h
clang-tidy/ClangTidyDiagnosticConsumer.cpp
clang-tidy/ClangTidyDiagnosticConsumer.h
clang-tidy/ClangTidyOptions.cpp
jroelofs added a comment.
In http://reviews.llvm.org/D15528#312031, @alexfh wrote:
> Thank you for explaining. The use case seems to be important enough to
> support it. And the solution seems to be good for now. A few concerns:
>
> 1. `Werrors` isn't a good name for this. The only reason why a
jroelofs marked 9 inline comments as done.
jroelofs added a comment.
http://reviews.llvm.org/D15528
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jroelofs updated this revision to Diff 44648.
jroelofs added a comment.
Address review comments.
http://reviews.llvm.org/D15528
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidy.h
clang-tidy/ClangTidyDiagnosticConsumer.cpp
clang-tidy/ClangTidyDiagnosticConsumer.h
clang-tidy/ClangTi
kfunk added a comment.
@realincubus: Sorry, I didn't know you had put this up for review already.
So back to this patch. Yes, it works fine for me *without* amending
libclang.exports. I'm injecting the arguments to `clang_parseTranslationUnit2`.
See this patch here for reference:
https://quick
mjacob added a comment.
In http://reviews.llvm.org/D15998#324757, @aaron.ballman wrote:
> Can you point me to some documentation on what the semantics of this
> attribute are? For instance, how does it play with other attributes (like
> naked or dllexport), is there a reason it shouldn't apply
probinson added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:446-448
@@ -445,3 +445,5 @@
Opts.DebugTypeExtRefs = Args.hasArg(OPT_dwarf_ext_refs);
- Opts.DebugExplicitImport = Triple.isPS4CPU();
+ Opts.DebugExplicitImport =
+ Opts.getDebuggerTuning()
realincubus added a comment.
Hi.
I am finally back at work and happy to see that some effort already went into
the patch that i initially wrote some time ago (http://reviews.llvm.org/D5611)
I just looked through the files of the new patch and noticed that the
libclang.exports file is missing.
mclow.lists added a comment.
Ping? I'd like to land this before the branch for release tomorrow.
http://reviews.llvm.org/D15862
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On 1/11/16 5:38 PM, Marshall Clow via cfe-commits wrote:
Author: marshall
Date: Mon Jan 11 18:38:04 2016
New Revision: 257422
URL: http://llvm.org/viewvc/llvm-project?rev=257422&view=rev
Log:
Put the definition of _LIBCPP_DISABLE_UBSAN_UNSIGNED_INTEGER_CHECK in the right
place.
Modified:
junbuml abandoned this revision.
junbuml added a comment.
Abandon this based the last comment in http://reviews.llvm.org/D15289.
http://reviews.llvm.org/D13304
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
a.sidorin added a comment.
LongLongTy is initialized as a built-in type in ASTContext and, as I
understand, is always available. It is not 64-bit on some platforms (like TCE),
but these platforms don't have a wider type too.
http://reviews.llvm.org/D16063
___
aaron.ballman added a comment.
Can you point me to some documentation on what the semantics of this attribute
are? For instance, how does it play with other attributes (like naked or
dllexport), is there a reason it shouldn't apply to Objective-C methods, etc?
Comment at: incl
Author: marshall
Date: Tue Jan 12 08:51:04 2016
New Revision: 257474
URL: http://llvm.org/viewvc/llvm-project?rev=257474&view=rev
Log:
Add a bunch of missing includes in the test suite to make it more portable.
Fixes bugs #26120 and #26121. Thanks to Jonathan Wakely for the reports and the
patch
aaron.ballman added a comment.
I think the better way to fix this is to add a Subjects line in Attr.td that
limits the mode attribute to just TypedefNameDecl and VarDecl, then remove
err_attr_wrong_decl entirely.
http://reviews.llvm.org/D16112
___
aaron.ballman added inline comments.
Comment at: unittests/ASTMatchers/ASTMatchersTest.cpp:4994
@@ +4993,3 @@
+ EXPECT_TRUE(matches("typedef int hasUnderlyingTypeTest;",
+ typedefDecl(hasUnderlyingType(asString("int");
+ EXPECT_TRUE(matches("typedef cons
hokein added a comment.
In http://reviews.llvm.org/D16008#322811, @Eugene.Zelenko wrote:
> This check is duplicate of clang-analyzer-alpha.cplusplus.VirtualCall.
Oops... Didn't notice there is an implementation already.
> From my point of view, Clang-tidy is better place, since such calls does
NoQ updated this revision to Diff 44629.
NoQ added a comment.
Another rebase on top of http://reviews.llvm.org/D16062.
http://reviews.llvm.org/D15448
Files:
docs/analyzer/DebugChecks.rst
include/clang/StaticAnalyzer/Checkers/SValExplainer.h
include/clang/StaticAnalyzer/Core/PathSensitive/
NoQ updated this revision to Diff 44628.
NoQ marked 2 inline comments as done.
NoQ added a comment.
Good point! Removed the friend-class directive here, and also in
`NonStaticGlobalSpaceRegion`, which is also abstract.
Agreed and renamed text regions to code regions.
http://reviews.llvm.org/D1
pxli168 updated this revision to Diff 44624.
pxli168 added a comment.
Rewrite some comment.
Can this patch be in llvm3.8 release if it is commited after 13th Jan?
http://reviews.llvm.org/D15914
Files:
include/clang/Basic/Builtins.def
include/clang/Basic/Builtins.h
include/clang/Basic/Dia
d.zobnin.bugzilla created this revision.
d.zobnin.bugzilla added a reviewer: aaron.ballman.
d.zobnin.bugzilla added a subscriber: cfe-commits.
Allow "mode" attribute to be applied to VarDecl, not ValueDecl (which includes
FunctionDecl and EnumConstantDecl), emit an error if this attribute is used
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
In http://reviews.llvm.org/D15443#324426, @adek05 wrote:
> Adding testcases in unittest/AST/SourceLocationTest.cpp as suggested by
> @aaronballman
>
> Interestingly, without my c
pxli168 added inline comments.
Comment at: include/clang/Basic/Builtins.h:39
@@ -38,2 +38,3 @@
MS_LANG = 0x10, // builtin requires MS mode.
+ OCLC_LANG = 0x20,// builtin for OpenCL C only.
ALL_LANGUAGES = C_LANG | CXX_LANG | OBJC_LANG, // builtin for all languages.
---
pxli168 marked 4 inline comments as done.
Comment at: include/clang/Basic/Builtins.def:1255
@@ -1254,1 +1254,3 @@
+// OpenCL v2.0 s6.13.16, s9.17.3.5 -- Pipe functions.
+// We need the generic prototype, since the packet type could be anything.
Anastasia wrote:
dws added a comment.
Added cfe-commits to the Reviewers.
http://reviews.llvm.org/D16102
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pxli168 updated this revision to Diff 44619.
pxli168 added a comment.
FIxed bugs and relocate the test cases.
Upload the full diff.
http://reviews.llvm.org/D16047
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDecl.cpp
lib/Sema/SemaExpr.cpp
lib/Sema/SemaInit.cpp
lib/Se
pxli168 added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:593
@@ -592,2 +592,3 @@
InGroup;
+def err_no_declarators : Error<"declaration does not declare anything">;
def ext_typedef_without_a_name : ExtWarn<"typedef requires a name">,
---
jmolloy abandoned this revision.
jmolloy added a comment.
Abandoning - this isn't as clear-cut as I thought.
Repository:
rL LLVM
http://reviews.llvm.org/D16056
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
ismail added a comment.
Reverted in r257468.
http://reviews.llvm.org/D15006
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Anastasia added inline comments.
Comment at: include/clang/Basic/Builtins.def:1255
@@ -1254,1 +1254,3 @@
+// OpenCL v2.0 s6.13.16, s9.17.3.5 -- Pipe functions.
+// We need the generic prototype, since the packet type could be anything.
Could you remove one -?
=
Anastasia added a comment.
Also generally it's much nicer to have small logically isolated changes
committed. I can see how you could partition this change into into pipe, blocks
and images.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:593
@@ -592,2 +592,3 @@
InG
1 - 100 of 109 matches
Mail list logo
