Re: [PATCH] D17437: [OpenCL] Add Sema checks for types

pxli168 retitled this revision from "[OpenCL] Add Sema checks for image and pipe" to "[OpenCL] Add Sema checks for types". pxli168 updated the summary for this revision. pxli168 updated this revision to Diff 48654. pxli168 marked an inline comment as done. pxli168 added a comment. Refine comments

Re: [PATCH] D17437: [OpenCL] Add Sema checks for types

pxli168 added inline comments. Comment at: lib/Sema/SemaDecl.cpp:5725 @@ +5724,3 @@ + // Pipes can only be passed as arguments to a function. + if (getLangOpts().OpenCL && getLangOpts().OpenCLVersion >= 200 && + R->isPipeType()) { Anastasia wrote: > Remove

r261516 - [CLANG] [AVX512] [BUILTIN] Adding prol{d|q|w}{128|256|512} builtin to clang .

Author: mzuckerm Date: Mon Feb 22 03:05:41 2016 New Revision: 261516 URL: http://llvm.org/viewvc/llvm-project?rev=261516&view=rev Log: [CLANG] [AVX512] [BUILTIN] Adding prol{d|q|w}{128|256|512} builtin to clang . Differential Revision: http://reviews.llvm.org/D16985 Modified: cfe/trunk/inclu

r261518 - [CLANG] [AVX512] [BUILTIN] Adding prol{d|q|w}{128|256|512} builtin to clang .

Author: mzuckerm Date: Mon Feb 22 03:42:57 2016 New Revision: 261518 URL: http://llvm.org/viewvc/llvm-project?rev=261518&view=rev Log: [CLANG] [AVX512] [BUILTIN] Adding prol{d|q|w}{128|256|512} builtin to clang . Fixing problem with the lib/include/avx512vlintrin.h file. Adding one more _ to the

Re: [PATCH] D17335: [clang-tidy] Fix a crash issue when clang-tidy runs with compilation database.

hokein updated this revision to Diff 48657. hokein marked an inline comment as done. hokein added a comment. - Address review comments. http://reviews.llvm.org/D17335 Files: clang-tidy/ClangTidy.cpp clang-tidy/ClangTidyDiagnosticConsumer.cpp clang-tidy/ClangTidyDiagnosticConsumer.h test

Re: [PATCH] D17335: [clang-tidy] Fix a crash issue when clang-tidy runs with compilation database.

hokein marked 4 inline comments as done. Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:120 @@ +119,3 @@ + bool IsWarningAsError, + const std::string &BuildDirectory) +: BuildDirectory(std::move(BuildDirectory

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

Hi, On Fri, 19 Feb 2016, Richard Smith wrote: > >> > The trivially copyable is gone again. Why is it not necessary? > >> > >> The C++ ABI doesn't defer to the C psABI for types that aren't > >> trivially-copyable. See > >> http://mentorembedded.github.io/cxx-abi/abi.html#normal-call > > > > Hmm,

Re: r261506 - Fix PR24473 : Teach clang to remember to substitute into member variable templates referred to within dependent qualified ids.

On Sun, Feb 21, 2016 at 11:45 PM, Richard Smith wrote: > On 21 Feb 2016 8:21 p.m., "Faisal Vali" wrote: >> >> On Sun, Feb 21, 2016 at 10:06 PM, Richard Smith >> wrote: >> > On 21 Feb 2016 6:29 p.m., "Faisal Vali via cfe-commits" >> > wrote: >> >> >> >> Author: faisalv >> >> Date: Sun Feb 21 20:

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

Hi, On Sat, 20 Feb 2016, Richard Smith wrote: > > An empty type is a type where it and all of its subobjects > > (recursively) are of class, structure, union, or array type. > > > > doesn't cover "trivially-copyable". > > That's correct. Whether a type is trivially copyable is unrelated to > w

Re: [PATCH] D17335: [clang-tidy] Fix a crash issue when clang-tidy runs with compilation database.

alexfh added inline comments. Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:120 @@ +119,3 @@ + bool IsWarningAsError, + const std::string &BuildDirectory) +: BuildDirectory(std::move(BuildDirectory)), CheckNa

r261522 - Make Sema::CheckFormatString a static function inside SemaChecking.cpp

Author: andyg Date: Mon Feb 22 07:00:43 2016 New Revision: 261522 URL: http://llvm.org/viewvc/llvm-project?rev=261522&view=rev Log: Make Sema::CheckFormatString a static function inside SemaChecking.cpp No functionality change. Change at the request of Richard Trieu, see http://reviews.llvm.org/

Re: r261506 - Fix PR24473 : Teach clang to remember to substitute into member variable templates referred to within dependent qualified ids.

On Mon, Feb 22, 2016 at 6:46 AM, Faisal Vali wrote: > On Sun, Feb 21, 2016 at 11:45 PM, Richard Smith wrote: >> On 21 Feb 2016 8:21 p.m., "Faisal Vali" wrote: >>> >>> On Sun, Feb 21, 2016 at 10:06 PM, Richard Smith >>> wrote: >>> > On 21 Feb 2016 6:29 p.m., "Faisal Vali via cfe-commits" >>> >

r261523 - Use an anonymous hyperlink reference to eliminate Sphinx warnings.

Author: aaronballman Date: Mon Feb 22 07:09:36 2016 New Revision: 261523 URL: http://llvm.org/viewvc/llvm-project?rev=261523&view=rev Log: Use an anonymous hyperlink reference to eliminate Sphinx warnings. Modified: cfe/trunk/docs/SanitizerCoverage.rst Modified: cfe/trunk/docs/SanitizerCover

Re: [PATCH] D16139: [MIPS] initFeatureMap() to handle empty string argument

bhushan added a comment. > I'm guessing it's something to do with the 'Features[CPU] = true' line. Yes. `Features[CPU] = true` enables a feature given by CPU string. (This gets translated into "+CPU"). When CPU string is empty, this gets translated into "+" (i.e. with empty feature name). Thi

Re: [PATCH] D15636: Reduce false positives in printf/scanf format checker

AndyG marked 7 inline comments as done. AndyG added a comment. I've removed CheckFormatString from Sema.h and make it a static function inside SemaChecking.cpp in r261522. I'll submit a new diff here with the remaining requested changes for this patch when I have a moment. http://reviews.llvm

Re: r261461 - Lex: Never overflow the file in HeaderMap::lookupFilename()

On 20 February 2016 at 19:14, Duncan P. N. Exon Smith via cfe-commits wrote: > Author: dexonsmith > Date: Sat Feb 20 18:14:36 2016 > New Revision: 261461 > > URL: http://llvm.org/viewvc/llvm-project?rev=261461&view=rev > Log: > Lex: Never overflow the file in HeaderMap::lookupFilename() > > If a h

Re: [PATCH] D17456: [libcxx] Reorganize _LIBCPP_LOCALE__L_EXTENSIONS

On 2/19/2016 3:32 PM, Joerg Sonnenberger via cfe-commits wrote: On Fri, Feb 19, 2016 at 06:14:18PM +, Ben Craig via cfe-commits wrote: Instead of checking _LIBCPP_LOCALE__L_EXTENSIONS all over, instead check it once, and define the various *_l symbols once. If you want to rename using macro

Re: [PATCH] D17488: Extend UnnecessaryCopyInitialization check to trigger on non-const copies that can be safely converted to const references.

alexfh added inline comments. Comment at: clang-tidy/performance/UnnecessaryCopyInitialization.cpp:69 @@ +68,3 @@ + : "the variable '%0' is copy-constructed from a const reference " + "but " + "is only used as const reference; conside

Re: [PATCH] D17446: ASTMatchers: add new statement/decl matchers

aaron.ballman added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:1000 @@ +999,3 @@ + + +/// \brief Matches implicit initializers of init list expressions. Can remove the extra newline. Comment at: include/clang/ASTMatchers

Re: [PATCH][modules][PR26237]

ping... On 30/01/16 21:13, Vassil Vassilev wrote: On 30/01/16 18:36, David Blaikie wrote: On Sat, Jan 30, 2016 at 9:00 AM, Vassil Vassilev wrote: AFAICT the making a test case independent on STL is the hard part. I think it will be always failing due to the relocation of the me

r261528 - clang-format: [JS] treat forwardDeclare as an import/export statement.

Author: djasper Date: Mon Feb 22 09:06:53 2016 New Revision: 261528 URL: http://llvm.org/viewvc/llvm-project?rev=261528&view=rev Log: clang-format: [JS] treat forwardDeclare as an import/export statement. Patch by Martin Probst. Thank you. Modified: cfe/trunk/lib/Format/TokenAnnotator.cpp

Re: [PATCH] D17439: clang-format: [JS] treat forwardDeclare as an import/export statement.

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. LG. Submitted as r261528. http://reviews.llvm.org/D17439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/

Re: [PATCH] D17491: Add performance check to flag function parameters of expensive to copy types that can be safely converted to const references.

alexfh added inline comments. Comment at: clang-tidy/performance/UnnecessaryValueParamCheck.cpp:41 @@ +40,3 @@ + Function->parameters().begin(); + if (Index >= Function->getNumParams()) { +return; Please add a comment about when this hap

Re: [PATCH] D17440: clang-format: [JS] do not wrap ES6 imports/exports.

djasper added a comment. I am missing a decent explanation here. In contrast to C++ #includes as well as goog.require, etc. The import/export statements actually provide syntactic structure and can name multiple entities. Why would it be a good idea to always write them into a single line? ==

Re: [PATCH] D17447: Add check for CERT ENV33-C

aaron.ballman updated this revision to Diff 48674. aaron.ballman added a comment. Updated based on review feedback. http://reviews.llvm.org/D17447 Files: clang-tidy/cert/CERTTidyModule.cpp clang-tidy/cert/CMakeLists.txt clang-tidy/cert/CommandProcessorCheck.cpp clang-tidy/cert/CommandPr

Re: [PATCH] D17447: Add check for CERT ENV33-C

aaron.ballman marked 4 inline comments as done. aaron.ballman added a comment. http://reviews.llvm.org/D17447 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17146: [libcxx] locale portability refactor

bcraig abandoned this revision. bcraig added a comment. Breaking this up into smaller chunks. http://reviews.llvm.org/D17146 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15636: Reduce false positives in printf/scanf format checker

AndyG marked 11 inline comments as done. AndyG added a comment. Revised patch coming shortly... Comment at: lib/Sema/SemaChecking.cpp:3603 @@ -3554,3 +3602,3 @@ - void DoneProcessing(); + void DoneProcessing(signed &FirstUncoveredArg); rtrieu wrote: > Don'

Re: [PATCH] D15636: Reduce false positives in printf/scanf format checker

AndyG updated this revision to Diff 48678. AndyG marked 2 inline comments as done. AndyG added a comment. Patch additionally re-based off r261522. http://reviews.llvm.org/D15636 Files: lib/Sema/SemaChecking.cpp test/Sema/format-strings-scanf.c test/Sema/format-strings.c Index: test/Sema/

Re: [PATCH] D17416: [libcxx] Reorganize locale extension fallbacks. NFCI

mclow.lists added a comment. This looks fine to me; but I want to hear from @danalbert. http://reviews.llvm.org/D17416 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17456: [libcxx] Reorganize _LIBCPP_LOCALE__L_EXTENSIONS

On Mon, Feb 22, 2016 at 08:25:56AM -0600, Craig, Ben via cfe-commits wrote: > On 2/19/2016 3:32 PM, Joerg Sonnenberger via cfe-commits wrote: > >On Fri, Feb 19, 2016 at 06:14:18PM +, Ben Craig via cfe-commits wrote: > >>Instead of checking _LIBCPP_LOCALE__L_EXTENSIONS all over, instead > >>chec

Re: [PATCH] D17437: [OpenCL] Add Sema checks for types

yaxunl added a comment. do we need to add a test that pointer to sampler is invalid? http://reviews.llvm.org/D17437 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17456: [libcxx] Reorganize _LIBCPP_LOCALE__L_EXTENSIONS

mclow.lists added a comment. Actually, the prefix we use in the rest of libc++ for private functions is `__libcpp_` Take a look in type_traits for a bunch of examples. In general, I'm liking the way this is going. I suspect I will have more comments later today. http://reviews.llvm.org/D1745

Re: [PATCH] D17507: The controlling expression for _Generic is unevaluated

On Mon, Feb 22, 2016 at 10:52 AM, Aaron Ballman wrote: > aaron.ballman created this revision. > aaron.ballman added a reviewer: rsmith. > aaron.ballman added a subscriber: cfe-commits. > > In r252104, I fixed a _Generic bug so that the controlling expression has its > type decayed and qualifiers

Re: [PATCH] D17335: [clang-tidy] Fix a crash issue when clang-tidy runs with compilation database.

hokein updated this revision to Diff 48682. hokein marked an inline comment as done. hokein added a comment. - Don't save BuildDirectory for every error in each check. http://reviews.llvm.org/D17335 Files: clang-tidy/ClangTidy.cpp clang-tidy/ClangTidy.h clang-tidy/ClangTidyDiagnosticConsu

Re: [PATCH] D17335: [clang-tidy] Fix a crash issue when clang-tidy runs with compilation database.

hokein updated this revision to Diff 48683. hokein added a comment. Some cleanup. http://reviews.llvm.org/D17335 Files: clang-tidy/ClangTidy.cpp clang-tidy/ClangTidy.h clang-tidy/ClangTidyDiagnosticConsumer.cpp clang-tidy/ClangTidyDiagnosticConsumer.h clang-tidy/tool/ClangTidyMain.cpp

[PATCH] D17507: The controlling expression for _Generic is unevaluated

aaron.ballman created this revision. aaron.ballman added a reviewer: rsmith. aaron.ballman added a subscriber: cfe-commits. In r252104, I fixed a _Generic bug so that the controlling expression has its type decayed and qualifiers stripped. However, this caused a diagnostic regression because the

Re: [PATCH] D17335: [clang-tidy] Fix a crash issue when clang-tidy runs with compilation database.

hokein updated this revision to Diff 48684. hokein added a comment. Remove an extra blank line. http://reviews.llvm.org/D17335 Files: clang-tidy/ClangTidy.cpp clang-tidy/ClangTidy.h clang-tidy/ClangTidyDiagnosticConsumer.cpp clang-tidy/ClangTidyDiagnosticConsumer.h clang-tidy/tool/Cla

Re: [PATCH] D17163: [ASTMatchers] Add matcher hasAnyName.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good. Thanks! (I suppose, Manuel has no substantial comments on this, since he has already seen the patch). http://reviews.llvm.org/D17163 __

Re: [PATCH] D17484: [clang-tidy] introduce modernize-deprecated-headers check

alexfh added a comment. Thank you for this check! Mostly looks good, but there are a number of style nits. The most important question to this check is that the standard doesn't guarantee that the C++ headers declare all the same functions **in the global namespace** (at least, this is how I u

Re: [PATCH] D17335: [clang-tidy] Fix a crash issue when clang-tidy runs with compilation database.

hokein updated this revision to Diff 48686. hokein marked an inline comment as done. hokein added a comment. Address one comment. http://reviews.llvm.org/D17335 Files: clang-tidy/ClangTidy.cpp clang-tidy/ClangTidy.h clang-tidy/ClangTidyDiagnosticConsumer.cpp clang-tidy/ClangTidyDiagnost

Re: [PATCH] D17335: [clang-tidy] Fix a crash issue when clang-tidy runs with compilation database.

hokein marked 2 inline comments as done. Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:122 @@ -121,3 +121,3 @@ IsWarningAsError(IsWarningAsError) {} // Returns true if GlobList starts with the negative indicator ('-'), removes it Done. Now ther

Re: [PATCH] D17447: Add check for CERT ENV33-C

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks! I've commit in r261530. http://reviews.llvm.org/D17447 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r261530 - Add a new check, cert-env33-c, that diagnoses uses of system(), popen(), and _popen() to execute a command processor. This check corresponds to the CERT secure coding rul

Author: aaronballman Date: Mon Feb 22 10:01:06 2016 New Revision: 261530 URL: http://llvm.org/viewvc/llvm-project?rev=261530&view=rev Log: Add a new check, cert-env33-c, that diagnoses uses of system(), popen(), and _popen() to execute a command processor. This check corresponds to the CERT secu

Re: [PATCH] D17484: [clang-tidy] introduce modernize-deprecated-headers check

alexfh added a comment. In http://reviews.llvm.org/D17484#358617, @alexfh wrote: > ... the check in its current form can break the code that uses library > symbols from the global namespace. ... An action item for this is: document this possible issue and add a FIXME somewhere in the code to

Re: [PATCH] D17456: [libcxx] Reorganize _LIBCPP_LOCALE__L_EXTENSIONS

bcraig updated the summary for this revision. bcraig added a reviewer: joerg. bcraig updated this revision to Diff 48687. bcraig added a comment. Changed libcxx prefix to libcpp. Changed BSD forwarding macros to macro functions. http://reviews.llvm.org/D17456 Files: include/__bsd_locale_defau

Re: [PATCH] D17345: [OpenCL] Improve diagnostics of address spaces for variables inside function

Anastasia added a comment. Yes, that's right. In this commit I assume parser has already accepted the blocks. We currently accept them if -fblocks is passed. I think we should also accept blocks by default with CL2.0. But I am thinking not to restrict passing -fblocks with earlier CL version.

Re: [PATCH] D16928: [OpenCL] Apply missing restrictions for Blocks in OpenCL v2.0

Anastasia added a comment. Yes, that's right. In this commit I assume parser has already accepted the blocks. We currently accept them if -fblocks is passed. I think we should also accept blocks by default with CL2.0. But I am thinking not to restrict passing -fblocks with earlier CL version.

Re: [PATCH] D17170: [OPENMP] Codegen for distribute directive

carlo.bertolli marked 5 inline comments as done. carlo.bertolli added a comment. Updating patch following comments. Repository: rL LLVM http://reviews.llvm.org/D17170 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/c

Re: [PATCH] D17335: [clang-tidy] Fix a crash issue when clang-tidy runs with compilation database.

alexfh added a comment. In http://reviews.llvm.org/D17335#358613, @hokein wrote: > - Don't save BuildDirectory for every error in each check. I think, it's not going to work with multiple files. There's just one Stats instance. Comment at: test/clang-tidy/clang-tidy-run-with

Re: [PATCH] D17170: [OPENMP] Codegen for distribute directive

carlo.bertolli updated this revision to Diff 48691. carlo.bertolli added a comment. Address latest comments. Repository: rL LLVM http://reviews.llvm.org/D17170 Files: include/clang/AST/StmtOpenMP.h lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h lib/CodeGen/CGStmtOpenMP

r261533 - Add support for Android Vector calling convention for AArch64

Author: niravd Date: Mon Feb 22 10:48:42 2016 New Revision: 261533 URL: http://llvm.org/viewvc/llvm-project?rev=261533&view=rev Log: Add support for Android Vector calling convention for AArch64 This modification applies the following Android commit when we have an Android environment. This is th

Re: [PATCH] D15636: Reduce false positives in printf/scanf format checker

AndyG added inline comments. Comment at: lib/Sema/SemaChecking.cpp:3905 @@ -3822,14 +3904,3 @@ CoveredArgs.flip(); -signed notCoveredArg = CoveredArgs.find_first(); -if (notCoveredArg >= 0) { - assert((unsigned)notCoveredArg < NumDataArgs); - if (const Expr

Re: [PATCH] D16317: [Analyzer] Fix for PR23790: bind real value returned from strcmp when modelling strcmp.

dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. Looks great, other than some non-standard indentation. Comment at: lib/StaticAnalyzer/Checkers/CStringChecker.cpp:1886 @@ +1885,3 @@ + svalBuilder.evalBinOp(sta

r261535 - [MS ABI] Correctly handle dllimport'd explicit instantiation declaration w/ vbases

Author: majnemer Date: Mon Feb 22 11:22:08 2016 New Revision: 261535 URL: http://llvm.org/viewvc/llvm-project?rev=261535&view=rev Log: [MS ABI] Correctly handle dllimport'd explicit instantiation declaration w/ vbases We gave a VBTable dllimport storage class and external linkage while also prov

r261534 - Add a test for r261425.

Author: majnemer Date: Mon Feb 22 11:22:01 2016 New Revision: 261534 URL: http://llvm.org/viewvc/llvm-project?rev=261534&view=rev Log: Add a test for r261425. Added: cfe/trunk/test/CodeGenCXX/exceptions-cxx-ehsc.cpp Added: cfe/trunk/test/CodeGenCXX/exceptions-cxx-ehsc.cpp URL: http://llvm.o

Re: [PATCH] D14203: [analyzer] Improve pointer arithmetic checker.

dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. Other than a suggested diagnostic rewording to consider, looks good to me. Thanks Gábor! Comment at: lib/StaticAnalyzer/Checkers/PointerArithChecker.cpp:198 @@ +197,3 @

[PATCH] D17515: AMDGPU: Add builtins for recently added intrinsics

arsenm created this revision. arsenm added a reviewer: tstellarAMD. arsenm added a subscriber: cfe-commits. http://reviews.llvm.org/D17515 Files: include/clang/Basic/BuiltinsAMDGPU.def test/CodeGenOpenCL/builtins-amdgcn.cl test/SemaOpenCL/builtins-amdgcn.cl Index: test/SemaOpenCL/builtins-

[PATCH] D17516: AMDGPU: Verify subtarget specific builtins

arsenm created this revision. arsenm added reviewers: tstellarAMD, echristo. arsenm added a subscriber: cfe-commits. Cleanup setup of subtarget features. http://reviews.llvm.org/D17516 Files: include/clang/Basic/BuiltinsAMDGPU.def lib/Basic/Targets.cpp test/CodeGenOpenCL/builtins-amdgcn-er

Re: [PATCH] D17484: [clang-tidy] introduce modernize-deprecated-headers check

LegalizeAdulthood added a comment. In http://reviews.llvm.org/D17484#358617, @alexfh wrote: > Thank you for this check! Mostly looks good, but there are a number of style > nits. > > The most important question to this check is that the standard doesn't > guarantee that the C++ headers declare

r261537 - Don't enable /GX by default

Author: majnemer Date: Mon Feb 22 11:44:51 2016 New Revision: 261537 URL: http://llvm.org/viewvc/llvm-project?rev=261537&view=rev Log: Don't enable /GX by default The /GX flag is disabled unless explicitly specified on the command line. This partially addresses PR26698. Modified: cfe/trunk/

Re: [PATCH] D17436: [OpenCL] Add Sema checks for OpenCL 2.0 block

Anastasia added inline comments. Comment at: lib/Sema/SemaDecl.cpp:6714 @@ +6713,3 @@ + if (LangOpts.OpenCLVersion >= 200 && T->isBlockPointerType()) { +const BlockPointerType *BlkTy = T->getAs(); +const FunctionProtoType *FTy = Yes, but you have to diagn

r261545 - [analyzer] Detect duplicate [super dealloc] calls

Author: dcoughlin Date: Mon Feb 22 11:56:24 2016 New Revision: 261545 URL: http://llvm.org/viewvc/llvm-project?rev=261545&view=rev Log: [analyzer] Detect duplicate [super dealloc] calls Add an alpha path checker that warns about duplicate calls to [super dealloc]. This will form the foundation of

Re: [PATCH] D5238: [analyzer] Detect duplicate [super dealloc] calls

This revision was automatically updated to reflect the committed changes. Closed by commit rL261545: [analyzer] Detect duplicate [super dealloc] calls (authored by dcoughlin). Changed prior to commit: http://reviews.llvm.org/D5238?vs=48447&id=48707#toc Repository: rL LLVM http://reviews.llv

Re: [PATCH] D17437: [OpenCL] Add Sema checks for types

Anastasia added inline comments. Comment at: test/SemaOpenCL/invalid-image.cl:3 @@ +2,3 @@ + +void test1(image1d_t *i){} // expected-error {{pointer to type 'image1d_t' is invalid in OpenCL}} + Could we add similar tests for other types too. I think we could put

Re: [PATCH] D17446: ASTMatchers: add new statement/decl matchers

LegalizeAdulthood added a subscriber: LegalizeAdulthood. Comment at: docs/LibASTMatchersReference.html:512 @@ +511,3 @@ +MatcherStmt>addrLabelExprMatcherAddrL

Re: [PATCH] D17437: [OpenCL] Add Sema checks for types

Anastasia added inline comments. Comment at: test/SemaOpenCL/invalid-image.cl:3 @@ +2,3 @@ + +void test1(image1d_t *i){} // expected-error {{pointer to type 'image1d_t' is invalid in OpenCL}} + Anastasia wrote: > Could we add similar tests for other types too. I

Re: [PATCH] D17484: [clang-tidy] introduce modernize-deprecated-headers check

omtcyf0 added a comment. Thank you for a review, Alex! I'll clean up the parts you mentioned soon! In http://reviews.llvm.org/D17484#358617, @alexfh wrote: > The most important question to this check is that the standard doesn't > guarantee that the C++ headers declare all the same functions *

r261548 - Add has_feature attribute_availability_with_strict.

Author: mren Date: Mon Feb 22 12:24:30 2016 New Revision: 261548 URL: http://llvm.org/viewvc/llvm-project?rev=261548&view=rev Log: Add has_feature attribute_availability_with_strict. rdar://23791325 Modified: cfe/trunk/lib/Lex/PPMacroExpansion.cpp cfe/trunk/test/Sema/attr-availability-ma

Re: r261548 - Add has_feature attribute_availability_with_strict.

On Mon, Feb 22, 2016 at 1:24 PM, Manman Ren via cfe-commits wrote: > Author: mren > Date: Mon Feb 22 12:24:30 2016 > New Revision: 261548 > > URL: http://llvm.org/viewvc/llvm-project?rev=261548&view=rev > Log: > Add has_feature attribute_availability_with_strict. > > rdar://23791325 Please add mo

Re: r261448 - Lex: Check buckets on header map construction

> On Feb 20, 2016, at 1:00 PM, Duncan P. N. Exon Smith via cfe-commits > wrote: > > Author: dexonsmith > Date: Sat Feb 20 15:00:58 2016 > New Revision: 261448 > > URL: http://llvm.org/viewvc/llvm-project?rev=261448&view=rev > Log: > Lex: Check buckets on header map construction > > If the num

r261551 - [VFS] Add support for handling path traversals

Author: bruno Date: Mon Feb 22 12:41:01 2016 New Revision: 261551 URL: http://llvm.org/viewvc/llvm-project?rev=261551&view=rev Log: [VFS] Add support for handling path traversals Handle ".", ".." and "./" with trailing slashes while collecting files to be dumped into the vfs overlay directory. I

r261552 - [VFS] Add 'overlay-relative' field to YAML files

Author: bruno Date: Mon Feb 22 12:41:09 2016 New Revision: 261552 URL: http://llvm.org/viewvc/llvm-project?rev=261552&view=rev Log: [VFS] Add 'overlay-relative' field to YAML files The VFS overlay mapping between virtual paths and real paths is done through the 'external-contents' entries in YAML

Re: r261422 - Fix handling of vaargs on PPC32 when going from regsave to overflow.

On Sat, Feb 20, 2016 at 6:29 AM, Hal Finkel wrote: > > > - Original Message - >> From: "Dimitry Andric via cfe-commits" >> To: "Hans Wennborg" >> Cc: "Roman Divacky" , "cfe-commits" >> >> Sent: Saturday, February 20, 2016 8:24:36 AM >> Subject: Re: r261422 - Fix handling of vaargs on P

Re: r261548 - Add has_feature attribute_availability_with_strict.

> On Feb 22, 2016, at 10:37 AM, Aaron Ballman via cfe-commits > wrote: > > On Mon, Feb 22, 2016 at 1:24 PM, Manman Ren via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: >> Author: mren >> Date: Mon Feb 22 12:24:30 2016 >> New Revision: 261548 >> >> URL: http://llvm.org/viewvc/llvm-p

r261556 - [VFS] Fix call to getVFSFromYAML in unittests

Author: bruno Date: Mon Feb 22 13:02:27 2016 New Revision: 261556 URL: http://llvm.org/viewvc/llvm-project?rev=261556&view=rev Log: [VFS] Fix call to getVFSFromYAML in unittests Follow up from r261552 Modified: cfe/trunk/unittests/Basic/VirtualFileSystemTest.cpp Modified: cfe/trunk/unittest

Re: r261548 - Add has_feature attribute_availability_with_strict.

On Mon, Feb 22, 2016 at 1:57 PM, Manman Ren wrote: > > On Feb 22, 2016, at 10:37 AM, Aaron Ballman via cfe-commits > wrote: > > On Mon, Feb 22, 2016 at 1:24 PM, Manman Ren via cfe-commits > wrote: > > Author: mren > Date: Mon Feb 22 12:24:30 2016 > New Revision: 261548 > > URL: http://llvm.org/v

Re: [PATCH] D17484: [clang-tidy] introduce modernize-deprecated-headers check

omtcyf0 updated this revision to Diff 48711. omtcyf0 marked 9 inline comments as done. omtcyf0 added a comment. Fixed all the issues @alexfh pointed to. http://reviews.llvm.org/D17484 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/DeprecatedHeadersCheck.cpp clang-tidy/mod

Re: [PATCH] D17104: [VFS] Drop path traversal assertion

bruno closed this revision. bruno added a comment. Committed r261551 http://reviews.llvm.org/D17104 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17457: [VFS] Add 'overlay-relative' field to YAML files

bruno closed this revision. bruno added a comment. Committed r261552 / r261556 http://reviews.llvm.org/D17457 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17484: [clang-tidy] introduce modernize-deprecated-headers check

omtcyf0 added a comment. Marked the comments as *done*. Comment at: test/clang-tidy/modernize-deprecated-headers-cxx03.cpp:1 @@ +1,2 @@ +// RUN: %check_clang_tidy %s modernize-deprecated-headers %t -- -- -std=c++03 -isystem %S/Inputs/Headers + alexfh wrote: > Y

r261557 - [WebAssembly] Lower va_arg in clang.

Author: djg Date: Mon Feb 22 13:17:40 2016 New Revision: 261557 URL: http://llvm.org/viewvc/llvm-project?rev=261557&view=rev Log: [WebAssembly] Lower va_arg in clang. This uses the general emitVoidPtrVAArg lowering logic for everything, since this supports all types, and we don't have any special

r261560 - [WebAssembly] Initial driver support for standard library paths.

Author: djg Date: Mon Feb 22 13:26:15 2016 New Revision: 261560 URL: http://llvm.org/viewvc/llvm-project?rev=261560&view=rev Log: [WebAssembly] Initial driver support for standard library paths. Modified: cfe/trunk/lib/Driver/ToolChains.cpp cfe/trunk/lib/Driver/Tools.cpp cfe/trunk/tes

Re: [PATCH] D15829: [PGO] Clang Option that enables IR level PGO instrumentation

xur marked an inline comment as done. xur added a comment. I'll send a revised patch soon. Comment at: lib/CodeGen/CodeGenModule.cpp:150 @@ -149,2 +149,3 @@ - if (!CodeGenOpts.InstrProfileInput.empty()) { + if (!CodeGenOpts.hasProfileIRInstr() && + !CodeGenOpts.InstrPro

[PATCH] D17519: AMDGPU: Fix broken/confusing predefined macro

arsenm created this revision. arsenm added a reviewer: tstellarAMD. arsenm added a subscriber: cfe-commits. amdgcn should not be defining __R600__ http://reviews.llvm.org/D17519 Files: lib/Basic/Targets.cpp test/Preprocessor/predefined-arch-macros.c Index: test/Preprocessor/predefined-arch-

r261563 - clang-format: [JS] Add @return to the supported JSDoc pragmas in Google

Author: djasper Date: Mon Feb 22 14:24:11 2016 New Revision: 261563 URL: http://llvm.org/viewvc/llvm-project?rev=261563&view=rev Log: clang-format: [JS] Add @return to the supported JSDoc pragmas in Google style. Modified: cfe/trunk/lib/Format/Format.cpp Modified: cfe/trunk/lib/Format/Format

[PATCH] D17520: AMDGPU: Fix inconsistent register name for flat_scratch

arsenm created this revision. arsenm added a reviewer: tstellarAMD. arsenm added a subscriber: cfe-commits. http://reviews.llvm.org/D17520 Files: lib/Basic/Targets.cpp test/CodeGenOpenCL/amdgcn-flat-scratch-name.cl Index: test/CodeGenOpenCL/amdgcn-flat-scratch-name.cl ===

Re: [modules] PR24954

On 02/02/16 02:52, Richard Smith via cfe-commits wrote: On Thu, Jan 28, 2016 at 8:23 AM, Vassil Vassilev wrote: Would this patch be more reasonable? It follows what RegisterTemplateSpecialization (introduced in r245779) does. AFAICT this adds an update record far less often. It's still adding

Re: [PATCH] D16993: Add documentation for bitreverse builtins

arsenm added a comment. ping http://reviews.llvm.org/D16993 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17516: AMDGPU: Verify subtarget specific builtins

echristo added inline comments. Comment at: lib/Basic/Targets.cpp:1829 @@ -1820,2 +1828,3 @@ } + AddrSpaceMap = &AMDGPUAddrSpaceMap; Extra whitespace. Comment at: lib/Basic/Targets.cpp:2059-2063 @@ +2058,7 @@ + + if (Has16BitInsts) +

Re: [PATCH] D17163: [ASTMatchers] Add matcher hasAnyName.

This revision was automatically updated to reflect the committed changes. Closed by commit rL261574: [ASTMatchers] Add matcher hasAnyName. (authored by sbenza). Changed prior to commit: http://reviews.llvm.org/D17163?vs=47802&id=48720#toc Repository: rL LLVM http://reviews.llvm.org/D17163

r261574 - [ASTMatchers] Add matcher hasAnyName.

Author: sbenza Date: Mon Feb 22 15:13:02 2016 New Revision: 261574 URL: http://llvm.org/viewvc/llvm-project?rev=261574&view=rev Log: [ASTMatchers] Add matcher hasAnyName. Summary: Add matcher hasAnyName as an optimization over anyOf(hasName(),...) Reviewers: alexfh Subscribers: klimek, cfe-comm

Re: r261574 - [ASTMatchers] Add matcher hasAnyName.

On Mon, Feb 22, 2016 at 4:13 PM, Samuel Benzaquen via cfe-commits wrote: > Author: sbenza > Date: Mon Feb 22 15:13:02 2016 > New Revision: 261574 > > URL: http://llvm.org/viewvc/llvm-project?rev=261574&view=rev > Log: > [ASTMatchers] Add matcher hasAnyName. > > Summary: Add matcher hasAnyName as a

Re: [PATCH] D16821: Add whole-program vtable optimization feature to Clang.

pcc added inline comments. Comment at: lib/CodeGen/CGVTables.cpp:904-919 @@ -900,5 +903,18 @@ + +bool CodeGenModule::IsBitSetBlacklistedRecord(const CXXRecordDecl *RD) { + std::string TypeName = RD->getQualifiedNameAsString(); + auto isInBlacklist = [&](const SanitizerBlacklist

Re: [PATCH] D16821: Add whole-program vtable optimization feature to Clang.

> On Feb 22, 2016, at 1:30 PM, Peter Collingbourne wrote: > > One thing that I'd like to do (and this would help CFI as well) is to > specifically recognize cases like this: > > ``` > struct B { > virtual void vf(); > }; > > struct D1 { > }; I assume you meant D1 : B here? > > struct D2 : B

Re: r261574 - [ASTMatchers] Add matcher hasAnyName.

On Mon, Feb 22, 2016 at 4:19 PM, Aaron Ballman wrote: > On Mon, Feb 22, 2016 at 4:13 PM, Samuel Benzaquen via cfe-commits > wrote: > > Author: sbenza > > Date: Mon Feb 22 15:13:02 2016 > > New Revision: 261574 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=261574&view=rev > > Log: > > [AST

Re: r261574 - [ASTMatchers] Add matcher hasAnyName.

On Mon, Feb 22, 2016 at 4:43 PM, Samuel Benzaquen wrote: > > On Mon, Feb 22, 2016 at 4:19 PM, Aaron Ballman > wrote: >> >> On Mon, Feb 22, 2016 at 4:13 PM, Samuel Benzaquen via cfe-commits >> wrote: >> > Author: sbenza >> > Date: Mon Feb 22 15:13:02 2016 >> > New Revision: 261574 >> > >> > URL:

[libcxx] r261581 - Fix __is_referenceable to work with vector types. Fixes PR#26654 and 26656. Thanks to Evgeniy for the reports, and to Eric for the suggestion on how to fix it.

Author: marshall Date: Mon Feb 22 16:13:03 2016 New Revision: 261581 URL: http://llvm.org/viewvc/llvm-project?rev=261581&view=rev Log: Fix __is_referenceable to work with vector types. Fixes PR#26654 and 26656. Thanks to Evgeniy for the reports, and to Eric for the suggestion on how to fix it.

r261583 - Fix Visual Studio build after r261574

Author: hans Date: Mon Feb 22 16:21:58 2016 New Revision: 261583 URL: http://llvm.org/viewvc/llvm-project?rev=261583&view=rev Log: Fix Visual Studio build after r261574 Modified: cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h cfe/trunk/lib/ASTMatchers/ASTMatchersInternal.cpp Modified:

Re: r261574 - [ASTMatchers] Add matcher hasAnyName.

On Mon, Feb 22, 2016 at 1:13 PM, Samuel Benzaquen via cfe-commits wrote: > Author: sbenza > Date: Mon Feb 22 15:13:02 2016 > New Revision: 261574 > > URL: http://llvm.org/viewvc/llvm-project?rev=261574&view=rev > Log: > [ASTMatchers] Add matcher hasAnyName. > > Summary: Add matcher hasAnyName as a

  1   2   >