r276517 - [Profile] Use a flag to enable PGO rather than the profraw filename

2016-07-22 Thread Xinliang David Li via cfe-commits
Author: davidxl Date: Fri Jul 22 23:28:59 2016 New Revision: 276517 URL: http://llvm.org/viewvc/llvm-project?rev=276517&view=rev Log: [Profile] Use a flag to enable PGO rather than the profraw filename Patch by Jake VanAdrighem Differential Revision: http://reviews.llvm.org/D22608 Modified:

Re: [PATCH] D22608: [Profile] Use a flag to enable PGO rather than the profraw filename.

2016-07-22 Thread David Li via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL276517: [Profile] Use a flag to enable PGO rather than the profraw filename (authored by davidxl). Changed prior to commit: https://reviews.llvm.org/D22608?vs=64812&id=65216#toc Repository: rL LLVM

Re: [PATCH] D22662: [cxx1z-constexpr-lambda] Make a lambda's closure type a literal type in C++1z.

2016-07-22 Thread Faisal Vali via cfe-commits
faisalv accepted this revision. faisalv added a reviewer: faisalv. faisalv added a comment. This revision is now accepted and ready to land. Thanks Richard. Your request to separate out and centralize the diagnostic portion of the patch certainly seems like a good idea - and I shall do so separ

r276514 - [cxx1z-constexpr-lambda] Make a lambda's closure type eligible as a literal-type in C++1z

2016-07-22 Thread Faisal Vali via cfe-commits
Author: faisalv Date: Fri Jul 22 23:05:19 2016 New Revision: 276514 URL: http://llvm.org/viewvc/llvm-project?rev=276514&view=rev Log: [cxx1z-constexpr-lambda] Make a lambda's closure type eligible as a literal-type in C++1z Additionally, for pre-C++1z, instead of forbidding a lambda's closure t

[libcxx] r276511 - Implement P0392r0. Integrate filesystem::path and string_view.

2016-07-22 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Fri Jul 22 22:10:56 2016 New Revision: 276511 URL: http://llvm.org/viewvc/llvm-project?rev=276511&view=rev Log: Implement P0392r0. Integrate filesystem::path and string_view. Modified: libcxx/trunk/include/experimental/filesystem libcxx/trunk/src/experimental/filesyst

r276509 - Work around MSVC's lack of support for unrestricted unions by making this

2016-07-22 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Jul 22 21:39:52 2016 New Revision: 276509 URL: http://llvm.org/viewvc/llvm-project?rev=276509&view=rev Log: Work around MSVC's lack of support for unrestricted unions by making this struct a bit bigger under MSVC (this shouldn't be a big deal; we typically allocate no more

r276508 - Add -fmodules-ts flag to cc1 for the provisional C++ modules TS, and mark

2016-07-22 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Jul 22 21:32:21 2016 New Revision: 276508 URL: http://llvm.org/viewvc/llvm-project?rev=276508&view=rev Log: Add -fmodules-ts flag to cc1 for the provisional C++ modules TS, and mark 'module' and 'import' as keywords when the flag is specified. Added: cfe/trunk/test/Le

Re: [PATCH] D22666: Frontend: Fix mcount inlining bug

2016-07-22 Thread John McCall via cfe-commits
rjmccall added a comment. Note that the presence of the mcount call itself will significantly impact inlining and, really, the entire optimization pipeline. Having this be a late pass seems more in keeping with what I assume is a goal that this instrumentation doesn't drastically change the ge

Re: [PATCH] D22666: Frontend: Fix mcount inlining bug

2016-07-22 Thread Hal Finkel via cfe-commits
hfinkel added a comment. In https://reviews.llvm.org/D22666#493706, @honggyu.kim wrote: > In https://reviews.llvm.org/D22666#493109, @rjmccall wrote: > > > In https://reviews.llvm.org/D22666#493026, @hfinkel wrote: > > > > > What's the actual desired behavior here? Should the inliner strip out >

Re: [PATCH] D22666: Frontend: Fix mcount inlining bug

2016-07-22 Thread Honggyu Kim via cfe-commits
honggyu.kim added a comment. In https://reviews.llvm.org/D22666#493109, @rjmccall wrote: > In https://reviews.llvm.org/D22666#493026, @hfinkel wrote: > > > What's the actual desired behavior here? Should the inliner strip out calls > > to mcount() as it inlines? > > > I think they basically just

[libcxx] r276507 - Revert r276506 - Diagnose invalid memory order arguments in .

2016-07-22 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Fri Jul 22 20:43:53 2016 New Revision: 276507 URL: http://llvm.org/viewvc/llvm-project?rev=276507&view=rev Log: Revert r276506 - Diagnose invalid memory order arguments in . There is a bug in Clang 3.6 and earlier that causes compile failures. I suspect it's due to the usage

[PATCH] D22717: Improve documentation of the type safety attributes

2016-07-22 Thread Yunzhong Gao via cfe-commits
ygao created this revision. ygao added reviewers: gribozavr, aaron.ballman. ygao added a subscriber: cfe-commits. Hi, I was preparing our internal release documentation with our tech writers, and when reviewing the clang manual for the current release, we think the current documentation of type sa

[PATCH] D22716: [libunwind] support building shared lib and static lib simultaneously

2016-07-22 Thread Lei Zhang via cfe-commits
zlei created this revision. zlei added reviewers: rmaprath, EricWF, cfe-commits. Currently libunwind can be configured to build either shared lib or static lib, but not both. Downstream package maintainers may want to build/install shared lib and static lib simultaneously, without configuring tw

[libcxx] r276506 - [libcxx] Diagnose invalid memory order arguments in . Fixes PR21179.

2016-07-22 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Fri Jul 22 20:16:55 2016 New Revision: 276506 URL: http://llvm.org/viewvc/llvm-project?rev=276506&view=rev Log: [libcxx] Diagnose invalid memory order arguments in . Fixes PR21179. Summary: This patch uses the __attribute__((enable_if)) hack suggested by @rsmith to diagnose

[PATCH] D22712: Remove FileEntry copy-constructor

2016-07-22 Thread Alexander Shaposhnikov via cfe-commits
alexshap created this revision. alexshap added reviewers: bkramer, jdennett. alexshap added subscribers: compnerd, cfe-commits. alexshap changed the visibility of this Differential Revision from "Public (No Login Required)" to "All Users". Code cleanup: address FIXME in llvm/tools/clang/include/

[PATCH] D22711: Diagnose invalid failure memory orderings.

2016-07-22 Thread Eric Fiselier via cfe-commits
EricWF created this revision. EricWF added reviewers: majnemer, jfb, rsmith. EricWF added a subscriber: cfe-commits. Clang currently issues diagnostics if the success memory order argument is invalid, but it doesn't check the failure ordering argument for cmpxchg atomic operations. This patch ad

Re: [PATCH] D22557: [libcxx] Diagnose invalid memory order arguments in . Fixes PR21179.

2016-07-22 Thread JF Bastien via cfe-commits
On Jul 22, 2016 4:45 PM, "Eric Fiselier" wrote: > > EricWF added inline comments. > > > Comment at: test/libcxx/atomics/diagnose_invalid_memory_order.fail.cpp:87 > @@ +86,3 @@ > +x.compare_exchange_weak(val1, val2, std::memory_order_release); > +} > +{ > --

r276499 - Add doxygen comments to emmintrin.h's intrinsics.

2016-07-22 Thread Ekaterina Romanova via cfe-commits
Author: kromanova Date: Fri Jul 22 18:49:37 2016 New Revision: 276499 URL: http://llvm.org/viewvc/llvm-project?rev=276499&view=rev Log: Add doxygen comments to emmintrin.h's intrinsics. Only around 50% of the intrinsics in this file are documented now. The patches for the rest of the intrisics i

[libclc] r276497 - Implement cbrt builtin

2016-07-22 Thread Tom Stellard via cfe-commits
Author: tstellar Date: Fri Jul 22 18:45:15 2016 New Revision: 276497 URL: http://llvm.org/viewvc/llvm-project?rev=276497&view=rev Log: Implement cbrt builtin This implementation was ported from the AMD builtin library and has been tested with piglit, OpenCV, and the ocl conformance tests. Added:

[libclc] r276495 - geometric/floatn.inc: Add vec8 and vec16 types

2016-07-22 Thread Tom Stellard via cfe-commits
Author: tstellar Date: Fri Jul 22 18:45:11 2016 New Revision: 276495 URL: http://llvm.org/viewvc/llvm-project?rev=276495&view=rev Log: geometric/floatn.inc: Add vec8 and vec16 types Modified: libclc/trunk/generic/include/clc/geometric/floatn.inc Modified: libclc/trunk/generic/include/clc/geo

[libclc] r276496 - Implement cosh builtin

2016-07-22 Thread Tom Stellard via cfe-commits
Author: tstellar Date: Fri Jul 22 18:45:13 2016 New Revision: 276496 URL: http://llvm.org/viewvc/llvm-project?rev=276496&view=rev Log: Implement cosh builtin This implementation was ported from the AMD builtin library and has been tested with piglit, OpenCV, and the ocl conformance tests. Added:

Re: [PATCH] D22557: [libcxx] Diagnose invalid memory order arguments in . Fixes PR21179.

2016-07-22 Thread Eric Fiselier via cfe-commits
EricWF added inline comments. Comment at: test/libcxx/atomics/diagnose_invalid_memory_order.fail.cpp:87 @@ +86,3 @@ +x.compare_exchange_weak(val1, val2, std::memory_order_release); +} +{ jfb wrote: > That's not quite true: the failure ordering is a

r276492 - P0217R3: Parsing support and framework for AST representation of C++1z

2016-07-22 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Jul 22 18:36:59 2016 New Revision: 276492 URL: http://llvm.org/viewvc/llvm-project?rev=276492&view=rev Log: P0217R3: Parsing support and framework for AST representation of C++1z decomposition declarations. There are a couple of things in the wording that seem strange her

Re: [PATCH] D22557: [libcxx] Diagnose invalid memory order arguments in . Fixes PR21179.

2016-07-22 Thread JF Bastien via cfe-commits
jfb added inline comments. Comment at: test/libcxx/atomics/diagnose_invalid_memory_order.fail.cpp:87 @@ +86,3 @@ +x.compare_exchange_weak(val1, val2, std::memory_order_release); +} +{ That's not quite true: the failure ordering is auto-deduced from

Re: r276232 - [Sema] Fix PR28623.

2016-07-22 Thread George Burgess IV via cfe-commits
r276489. Thanks! On Fri, Jul 22, 2016 at 3:17 PM, Richard Smith wrote: > On Fri, Jul 22, 2016 at 3:15 PM, George Burgess IV < > george.burgess...@gmail.com> wrote: > >> (Assuming "yes" :) ) >> >> Richard, are you okay with this being merged into 3.9? >> > > Yes, LGTM for 3.9. > > >> On Fri, Jul

Re: [PATCH] D17820: Clang Code Completion Filtering

2016-07-22 Thread Argyrios Kyrtzidis via cfe-commits
akyrtzi added a comment. Thanks for making the changes; I'd recommend to go ahead and commit and we can iterate post-commit if necessary. Repository: rL LLVM https://reviews.llvm.org/D17820 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r276484 - [Profile] Enable profile merging with -fprofile-generat[=]

2016-07-22 Thread Xinliang David Li via cfe-commits
Author: davidxl Date: Fri Jul 22 17:25:01 2016 New Revision: 276484 URL: http://llvm.org/viewvc/llvm-project?rev=276484&view=rev Log: [Profile] Enable profile merging with -fprofile-generat[=] This patch enables raw profile merging for this option which is the new intended behavior. Modified:

Re: r276232 - [Sema] Fix PR28623.

2016-07-22 Thread Richard Smith via cfe-commits
On Fri, Jul 22, 2016 at 3:15 PM, George Burgess IV < george.burgess...@gmail.com> wrote: > (Assuming "yes" :) ) > > Richard, are you okay with this being merged into 3.9? > Yes, LGTM for 3.9. > On Fri, Jul 22, 2016 at 9:54 AM, George Burgess IV < > george.burgess...@gmail.com> wrote: > >> Error

Re: r276232 - [Sema] Fix PR28623.

2016-07-22 Thread George Burgess IV via cfe-commits
(Assuming "yes" :) ) Richard, are you okay with this being merged into 3.9? On Fri, Jul 22, 2016 at 9:54 AM, George Burgess IV < george.burgess...@gmail.com> wrote: > Error message says r272936 had the error, so it looks like it would, > yeah. :) > > Would you like me to merge it to the 3.9 bran

[PATCH] D22702: [libcxx]Missing default argument for flag_type parameter in one of std::basic_regex constructors

2016-07-22 Thread Jason Liu via cfe-commits
jasonliu created this revision. jasonliu added reviewers: mclow.lists, rsmith, hubert.reinterpretcast. jasonliu added a subscriber: cfe-commits. Standard 28.8 p3 indicates the 3-argument constructor have a default argument for flag_type parameter: basic_regex(const charT* p, size_t len, flag_type

Re: [PATCH] D17820: Clang Code Completion Filtering

2016-07-22 Thread Vassil Vassilev via cfe-commits
v.g.vassilev added a subscriber: v.g.vassilev. Comment at: include/clang/Lex/Preprocessor.h:270 @@ +269,3 @@ + /// on the stem that is to be code completed. + IdentifierInfo *CodeCompletionII; + Can you initialize this variable in the PP's ctor? Repository:

r276473 - [modules] Teach the ASTWriter to ignore mutations coming from the ASTReader.

2016-07-22 Thread Vassil Vassilev via cfe-commits
Author: vvassilev Date: Fri Jul 22 16:08:24 2016 New Revision: 276473 URL: http://llvm.org/viewvc/llvm-project?rev=276473&view=rev Log: [modules] Teach the ASTWriter to ignore mutations coming from the ASTReader. Processing update records (and loading a module, in general) might trigger unexpecte

Re: [PATCH] D19544: Pass for translating math intrinsics to math library calls.

2016-07-22 Thread Matt via cfe-commits
mmasten added a comment. Thanks Michael. The tests have been updated. Matt https://reviews.llvm.org/D19544 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19544: Pass for translating math intrinsics to math library calls.

2016-07-22 Thread Matt via cfe-commits
mmasten updated this revision to Diff 65152. https://reviews.llvm.org/D19544 Files: include/llvm/Analysis/TargetLibraryInfo.h lib/Analysis/TargetLibraryInfo.cpp test/Transforms/LoopVectorize/X86/svml-calls.ll Index: lib/Analysis/TargetLibraryInfo.cpp ===

[PATCH] D22698: [libcxx] Missing member types 'traits_type' and 'string_type' in class basic_regex

2016-07-22 Thread Jason Liu via cfe-commits
jasonliu created this revision. jasonliu added reviewers: mclow.lists, rsmith, hubert.reinterpretcast. jasonliu added a subscriber: cfe-commits. In standard 28.8 p3, class basic_regex is supposed to have 'traits_type' and 'string_type' as its member types. However, they are missing from the libra

r276469 - Add regression test for PR27699.

2016-07-22 Thread Vassil Vassilev via cfe-commits
Author: vvassilev Date: Fri Jul 22 15:49:31 2016 New Revision: 276469 URL: http://llvm.org/viewvc/llvm-project?rev=276469&view=rev Log: Add regression test for PR27699. Added: cfe/trunk/test/Modules/Inputs/PR27699/ cfe/trunk/test/Modules/Inputs/PR27699/Subdir/ cfe/trunk/test/Modules/I

[PATCH] D22697: [ObjC Availability] Consider lexical context of use of declaration when emitting availability diagnostics

2016-07-22 Thread Erik Pilkington via cfe-commits
erik.pilkington created this revision. erik.pilkington added a reviewer: manmanren. erik.pilkington added a subscriber: cfe-commits. -Wpartial-availability currently fires on the following: ``` void f1() __attribute__((availability(macos, introduced=10.10))); void f2() __attribute__((availability

Re: [PATCH] D22584: constexpr array support C++1z (P0031)

2016-07-22 Thread Jason Turner via cfe-commits
lefticus retitled this revision from "C++1z constexpr support for array and iterator" to "constexpr array support C++1z (P0031)". lefticus updated the summary for this revision. lefticus updated this revision to Diff 65143. lefticus added a comment. - Updated title and summary to be more accurate

Re: [PATCH] D22557: [libcxx] Diagnose invalid memory order arguments in . Fixes PR21179.

2016-07-22 Thread Eric Fiselier via cfe-commits
EricWF updated this revision to Diff 65140. EricWF added a comment. Add comment about checking "stronger" orderings. https://reviews.llvm.org/D22557 Files: include/atomic test/libcxx/atomics/diagnose_invalid_memory_order.fail.cpp Index: test/libcxx/atomics/diagnose_invalid_memory_order.fai

Re: [PATCH] D22513: [clang-tidy] add check cppcoreguidelines-rule-of-five-and-zero

2016-07-22 Thread Piotr Padlewski via cfe-commits
Prazek added a comment. In https://reviews.llvm.org/D22513#493303, @Eugene.Zelenko wrote: > Since rule name is different in C++98/03 and C++11 or newer it will make > sense to create two checks which will work only for their respective versions > (of course, implementation should be shared). Or

Re: [PATCH] D22513: [clang-tidy] add check cppcoreguidelines-rule-of-five-and-zero

2016-07-22 Thread Piotr Padlewski via cfe-commits
Prazek added a comment. I will look again soon, but it looks much better right now! Comment at: clang-tidy/cppcoreguidelines/RuleOfFiveAndZeroCheck.cpp:43-57 @@ +42,17 @@ + +llvm::StringRef RuleOfFiveAndZeroCheck::toString( +RuleOfFiveAndZeroCheck::SpecialMemberFunctionKind

Re: [PATCH] D22557: [libcxx] Diagnose invalid memory order arguments in . Fixes PR21179.

2016-07-22 Thread Eric Fiselier via cfe-commits
EricWF added a reviewer: jfb. EricWF marked an inline comment as done. EricWF added a comment. Address inline comments from @jfb and add him as a reviewer. Comment at: test/libcxx/atomics/diagnose_invalid_memory_order.fail.cpp:86 @@ +85,3 @@ +// does not generate any dia

Re: [PATCH] D22513: [clang-tidy] add check cppcoreguidelines-rule-of-five-and-zero

2016-07-22 Thread Eugene Zelenko via cfe-commits
Eugene.Zelenko added a comment. Since rule name is different in C++98/03 and C++11 or newer it will make sense to create two checks which will work only for their respective versions (of course, implementation should be shared). Or create alias name. Check is still not mentioned in docs/Releas

Re: [PATCH] D21642: [clang-tidy] boost-use-to-string arg expr location bugfix

2016-07-22 Thread Piotr Padlewski via cfe-commits
Prazek marked 3 inline comments as done. Comment at: test/clang-tidy/boost-use-to-string.cpp:154 @@ +153,3 @@ + float floating; + Fields* wierd; + const int &getConstInteger() const {return integer;} alexfh wrote: > alexfh wrote: > > "wierd" is weird ;) > I sho

Re: [PATCH] D22637: [OpenCL] Add extension cl_khr_mipmap_image to clang

2016-07-22 Thread Yaxun Liu via cfe-commits
yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rL LLVM https://reviews.llvm.org/D22637 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.or

[libunwind] r276462 - Merging r276215:

2016-07-22 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Fri Jul 22 15:04:56 2016 New Revision: 276462 URL: http://llvm.org/viewvc/llvm-project?rev=276462&view=rev Log: Merging r276215: r276215 | ericwf | 2016-07-20 17:56:42 -0600 (Wed, 20 Jul 2016) | 9 lines

Re: [PATCH] D22514: CloneDetection now respects statement specific data when searching for clones.

2016-07-22 Thread Vassil Vassilev via cfe-commits
v.g.vassilev added a comment. Could we stress test the implementation by running on files from llvm's/clang's test suite. For example, for a test TST we could do something like: cat TST >> tmp_TST; cat TST >> tmp_TST and run our our copy-paste checker on tmp_TST. This way we know how many clon

Re: [PATCH] D22637: [OpenCL] Add extension cl_khr_mipmap_image to clang

2016-07-22 Thread Aaron En Ye Shi via cfe-commits
ashi1 updated this revision to Diff 65126. ashi1 marked an inline comment as done. ashi1 added a comment. Revised based on Sam's comments. Repository: rL LLVM https://reviews.llvm.org/D22637 Files: include/clang/Basic/OpenCLExtensions.def lib/Basic/Targets.cpp test/Misc/amdgcn.language

Re: [PATCH] D22691: [OpenMP] Codegen for use_device_ptr clause.

2016-07-22 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 65123. sfantao added a comment. - Use the correct enumerator for return pointer, as specified in the design document. https://reviews.llvm.org/D22691 Files: include/clang/AST/OpenMPClause.h lib/AST/OpenMPClause.cpp lib/CodeGen/CGOpenMPRuntime.cpp l

Re: r276250 - [Sema, X86] Add explicit check to ensure that builtins that require x86-64 target throw an error if used on 32-bit target.

2016-07-22 Thread Craig Topper via cfe-commits
Most of these have been broken like this for a long time so I'm not sure. This patch as is depends on r276249 too since we were missing qualifiers in the intrinsics file. ~Craig On Fri, Jul 22, 2016 at 6:55 AM, Hans Wennborg wrote: > Should we merge this to 3.9? > > On Thu, Jul 21, 2016 at 3:38

Re: [PATCH] D20795: Added basic capabilities to detect source code clones.

2016-07-22 Thread Vassil Vassilev via cfe-commits
v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. LGTM, given the comments are addressed. Comment at: include/clang/Analysis/CloneDetection.h:37 @@ +36,3 @@ + /// Stmt, then S is a pointer to this Stmt. + Stmt c

Re: [PATCH] D15031: CFG: Add CFGElement for automatic variables that leave the scope

2016-07-22 Thread Matthias Gehre via cfe-commits
mgehre added a comment. Friendly ping https://reviews.llvm.org/D15031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22637: [OpenCL] Add extension cl_khr_mipmap_image to clang

2016-07-22 Thread Yaxun Liu via cfe-commits
yaxunl added inline comments. Comment at: test/Misc/amdgcn.languageOptsOpenCL.cl:190 @@ +189,3 @@ +// expected-warning@-1{{unsupported OpenCL extension 'cl_khr_mipmap_image' - ignoring}} +#endif + we also need to check the else case for `__OPENCL_C_VERSION__ < 20

Re: [PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

2016-07-22 Thread Pirama Arumuga Nainar via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL276455: Add .rgba syntax extension to ext_vector_type types (authored by pirama). Changed prior to commit: https://reviews.llvm.org/D20602?vs=62305&id=65119#toc Repository: rL LLVM https://reviews.l

r276455 - Add .rgba syntax extension to ext_vector_type types

2016-07-22 Thread Pirama Arumuga Nainar via cfe-commits
Author: pirama Date: Fri Jul 22 13:49:43 2016 New Revision: 276455 URL: http://llvm.org/viewvc/llvm-project?rev=276455&view=rev Log: Add .rgba syntax extension to ext_vector_type types Summary: This patch enables .rgba accessors to ext_vector_type types and adds tests for syntax validation and co

Re: [PATCH] D22637: [OpenCL] Add extension cl_khr_mipmap_image to clang

2016-07-22 Thread Aaron En Ye Shi via cfe-commits
ashi1 updated this revision to Diff 65118. ashi1 marked an inline comment as done. ashi1 added a comment. Revised based on Sam's comments. Added to tests Misc\amdgcn.languageOptsOpenCL.cl and SemaOpenCL\extension-version.cl Repository: rL LLVM https://reviews.llvm.org/D22637 Files: includ

Re: [PATCH] D22636: Module: retry building modules that were just compiled by the same instance and are are out of date

2016-07-22 Thread Manman Ren via cfe-commits
manmanren added a comment. In https://reviews.llvm.org/D22636#493072, @benlangmuir wrote: > > Can you point me to the source codes where we use rename to replace the > > file? I am curious on how this all works out. > > > This is the same as clang's handling of other output files. See > {{Comp

Re: [PATCH] D22666: Frontend: Fix mcount inlining bug

2016-07-22 Thread John McCall via cfe-commits
rjmccall added a comment. In https://reviews.llvm.org/D22666#493026, @hfinkel wrote: > What's the actual desired behavior here? Should the inliner strip out calls > to mcount() as it inlines? I think they basically just want a late pass (as in immediately prior to codegen) to insert the mcoun

[PATCH] D22691: [OpenMP] Codegen for use_device_ptr clause.

2016-07-22 Thread Samuel Antao via cfe-commits
sfantao created this revision. sfantao added reviewers: ABataev, hfinkel, carlo.bertolli, arpith-jacob, kkwli0. sfantao added subscribers: cfe-commits, caomhin. This patch adds support for the use_device_ptr clause. It includes changes in SEMA that could not be tested without codegen, namely, the

[PATCH] D22690: [OpenMP] Add support for mapping array sections through pointer references.

2016-07-22 Thread Samuel Antao via cfe-commits
sfantao created this revision. sfantao added reviewers: ABataev, hfinkel, carlo.bertolli, kkwli0. sfantao added subscribers: cfe-commits, caomhin. This patch fixes a bug in the map of array sections whose base is a reference to a pointer. The existing mapping support was not prepared to deal with

r276448 - Clang changes for overloading invariant.start and end intrinsics

2016-07-22 Thread Anna Thomas via cfe-commits
Author: annat Date: Fri Jul 22 12:50:08 2016 New Revision: 276448 URL: http://llvm.org/viewvc/llvm-project?rev=276448&view=rev Log: Clang changes for overloading invariant.start and end intrinsics This change depends on the corresponding LLVM change at: https://reviews.llvm.org/D22519 The llvm.i

Re: [PATCH] D22636: Module: retry building modules that were just compiled by the same instance and are are out of date

2016-07-22 Thread Ben Langmuir via cfe-commits
benlangmuir added a comment. > Can you point me to the source codes where we use rename to replace the file? > I am curious on how this all works out. This is the same as clang's handling of other output files. See {{CompilerInstance::createOutputFile}} and {{clearOutputFiles}}. When we are

Re: [PATCH] D22292: [libunwind] Fix unw_getcontext for ARMv6-m

2016-07-22 Thread Weiming Zhao via cfe-commits
weimingz added a comment. LGTM. Maybe @renato can review it too. Thanks Oliver and Saleem. https://reviews.llvm.org/D22292 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r276445 - ClangRenameTests: Update libdeps.

2016-07-22 Thread NAKAMURA Takumi via cfe-commits
Author: chapuni Date: Fri Jul 22 12:33:04 2016 New Revision: 276445 URL: http://llvm.org/viewvc/llvm-project?rev=276445&view=rev Log: ClangRenameTests: Update libdeps. Modified: clang-tools-extra/trunk/unittests/clang-rename/CMakeLists.txt Modified: clang-tools-extra/trunk/unittests/clang-re

Re: [PATCH] D22494: [analyzer] Explain why analyzer report is not generated (fix for PR12421).

2016-07-22 Thread Anna Zaks via cfe-commits
zaks.anna added inline comments. Comment at: test/Analysis/PR12421.c:11 @@ +10,2 @@ + +// CHECK: warning: Path diagnostic report is not generated. HTMLDiagnostics does not support diagnostics that cross file boundaries. We should use the name of the diagnostic co

RE: [PATCH] D16135: Macro Debug Info support in Clang

2016-07-22 Thread Aboud, Amjad via cfe-commits
Thanks Ranjeet, Indeed I was planning to update the patches to top of trunk and reload them, so if you can save me this trouble I would appreciate that. Once we upload the updated patches I would like to ping the community and ask for feedback. Thanks, Amjad > -Original Message- > From:

[libclc] r276443 - AMDGPU: Implement get_global_offset builtin

2016-07-22 Thread Jan Vesely via cfe-commits
Author: jvesely Date: Fri Jul 22 12:24:24 2016 New Revision: 276443 URL: http://llvm.org/viewvc/llvm-project?rev=276443&view=rev Log: AMDGPU: Implement get_global_offset builtin Also fix get_global_id to consider offset No idea how to add this for ptx, so they are stuck with the old get_global_id

[libclc] r276442 - AMDGPU: Use clang intrinsics for workitem builtins

2016-07-22 Thread Jan Vesely via cfe-commits
Author: jvesely Date: Fri Jul 22 12:24:20 2016 New Revision: 276442 URL: http://llvm.org/viewvc/llvm-project?rev=276442&view=rev Log: AMDGPU: Use clang intrinsics for workitem builtins v2: split into 2 patches use clang builtins for other intrinsics as well v3: Fix warnings Switch r600 t

Re: [PATCH] D22656: [Clang-apply-replacements] Remove custom version printing; fix some Include What You Use warnings

2016-07-22 Thread Eugene Zelenko via cfe-commits
Eugene.Zelenko updated this revision to Diff 65099. Eugene.Zelenko added a comment. Don't include DiagnosticIDs.h. Repository: rL LLVM https://reviews.llvm.org/D22656 Files: clang-apply-replacements/tool/ClangApplyReplacementsMain.cpp Index: clang-apply-replacements/tool/ClangApplyReplace

Re: [PATCH] D16135: Macro Debug Info support in Clang

2016-07-22 Thread Ranjeet Singh via cfe-commits
rs added a subscriber: rs. rs added a comment. Hi Amjad, are you still planning on getting this patch and https://reviews.llvm.org/D16077 committed ? It looks like these two patches are final pieces in the puzzle to get macro information in the DWARF debug output. I've downloaded the diffs and

Re: [PATCH] D22666: Frontend: Fix mcount inlining bug

2016-07-22 Thread Hal Finkel via cfe-commits
hfinkel added a subscriber: hfinkel. hfinkel added a comment. What's the actual desired behavior here? Should the inliner strip out calls to mcount() as it inlines? https://reviews.llvm.org/D22666 ___ cfe-commits mailing list cfe-commits@lists.llvm

Re: [PATCH] D22513: [clang-tidy] add check cppcoreguidelines-rule-of-five-and-zero

2016-07-22 Thread Jonathan B Coe via cfe-commits
jbcoe updated this revision to Diff 65096. jbcoe marked 6 inline comments as done. jbcoe added a comment. Address comments from review, thanks for those. https://reviews.llvm.org/D22513 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModu

Re: [PATCH] D22654: [Clang-rename] Remove custom version, fix extra space in error message

2016-07-22 Thread Eugene Zelenko via cfe-commits
Eugene.Zelenko added a comment. It's used for DiagnosticIDs.. However, in https://reviews.llvm.org/D22656 Alexander told that DiagnosticIDs.h should be treated as part of Diagnostic.h. Repository: rL LLVM https://reviews.llvm.org/D22654 ___ cfe-

Re: [PATCH] D21385: Adjust Registry interface to not require plugins to export a registry

2016-07-22 Thread John Brawn via cfe-commits
john.brawn added a comment. Ping. Repository: rL LLVM https://reviews.llvm.org/D21385 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22221: Decide whether to enable plugin tests based on cmake variables

2016-07-22 Thread John Brawn via cfe-commits
john.brawn added a comment. Ping. Repository: rL LLVM https://reviews.llvm.org/D1 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r276232 - [Sema] Fix PR28623.

2016-07-22 Thread George Burgess IV via cfe-commits
Error message says r272936 had the error, so it looks like it would, yeah. :) Would you like me to merge it to the 3.9 branch? On Fri, Jul 22, 2016 at 6:51 AM, Hans Wennborg wrote: > Does this apply to 3.9? > > On Wed, Jul 20, 2016 at 11:28 PM, George Burgess IV via cfe-commits > wrote: > > Au

Re: [PATCH] D22513: [clang-tidy] add check cppcoreguidelines-rule-of-five-and-zero

2016-07-22 Thread Jonathan B Coe via cfe-commits
jbcoe removed rL LLVM as the repository for this revision. jbcoe updated this revision to Diff 65092. jbcoe marked 2 inline comments as done. jbcoe added a comment. Addressed review comments, thanks for those, check is nicer now. https://reviews.llvm.org/D22513 Files: clang-tidy/cppcoreguidel

r276425 - test commit. update comment grammatically. NFC

2016-07-22 Thread Anna Thomas via cfe-commits
Author: annat Date: Fri Jul 22 10:37:56 2016 New Revision: 276425 URL: http://llvm.org/viewvc/llvm-project?rev=276425&view=rev Log: test commit. update comment grammatically. NFC Modified: cfe/trunk/lib/CodeGen/CGDeclCXX.cpp Modified: cfe/trunk/lib/CodeGen/CGDeclCXX.cpp URL: http://llvm.org

Re: [PATCH] D22622: [analyzer] Add more info to exploded graph dumps

2016-07-22 Thread Anna Zaks via cfe-commits
zaks.anna added a comment. Great! How does this work when a path spans multiple files, specifically, when the definitions from a header file are inlined? We could add file names but only in cases the file name does not match the main file. > and hard to navigate (especially when using a specia

Re: [PATCH] D22514: CloneDetection now respects statement specific data when searching for clones.

2016-07-22 Thread Raphael Isemann via cfe-commits
teemperor updated this revision to Diff 65086. teemperor added a comment. - StmtDataCollector is now using ConstStmtVisitor - Added tests for StmtDataCollector https://reviews.llvm.org/D22514 Files: lib/Analysis/CloneDetection.cpp test/Analysis/copypaste/test-asm.cpp test/Analysis/copypas

Re: [PATCH] D22671: MPI-Checker: move MPIFunctionClassifier.h

2016-07-22 Thread Anna Zaks via cfe-commits
zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D22671 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

[libunwind] r276424 - Merge r276128: libunwind: limit stack usage in unwind cursor

2016-07-22 Thread Ed Maste via cfe-commits
Author: emaste Date: Fri Jul 22 10:00:42 2016 New Revision: 276424 URL: http://llvm.org/viewvc/llvm-project?rev=276424&view=rev Log: Merge r276128: libunwind: limit stack usage in unwind cursor Modified: libunwind/branches/release_39/ (props changed) libunwind/branches/release_39/includ

[libclc] r276423 - ptx: Fix builtin names after clang r274770

2016-07-22 Thread Jan Vesely via cfe-commits
Author: jvesely Date: Fri Jul 22 10:00:08 2016 New Revision: 276423 URL: http://llvm.org/viewvc/llvm-project?rev=276423&view=rev Log: ptx: Fix builtin names after clang r274770 Signed-off-by: Jan Vesely Acked-By: Aaron Watry Modified: libclc/trunk/ptx-nvidiacl/lib/synchronization/barrier.c

Re: [PATCH] D22656: [Clang-apply-replacements] Remove custom version printing; fix some Include What You Use warnings

2016-07-22 Thread Alexander Kornienko via cfe-commits
alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. In many cases a transitively included header can be considered a part of a public interface of an already included header, e.g. it's reasonable to assume that DiagnosticIDs.h is a pa

Re: [PATCH] D22679: [mips][ias] Enable IAS by default for N64 on Debian mips64el.

2016-07-22 Thread Simon Dardis via cfe-commits
sdardis added a comment. Actually, seeing your reply on the related patch, keep the comment as it reflects trunk. https://reviews.llvm.org/D22679 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

Re: [PATCH] D22679: [mips][ias] Enable IAS by default for N64 on Debian mips64el.

2016-07-22 Thread Simon Dardis via cfe-commits
sdardis added a comment. Yes, I think you should also reflect mpf's comment here too. https://reviews.llvm.org/D22679 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22679: [mips][ias] Enable IAS by default for N64 on Debian mips64el.

2016-07-22 Thread Simon Dardis via cfe-commits
sdardis accepted this revision. sdardis added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D22679 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

Re: [PATCH] D21962: MPITypeMismatchCheck for Clang-Tidy

2016-07-22 Thread Alexander Droste via cfe-commits
Alexander_Droste updated this revision to Diff 65074. Alexander_Droste added a comment. - fix typo https://reviews.llvm.org/D21962 Files: clang-tidy/CMakeLists.txt clang-tidy/mpi/CMakeLists.txt clang-tidy/mpi/MPITidyModule.cpp clang-tidy/mpi/TypeMismatchCheck.cpp clang-tidy/mpi/TypeMi

[PATCH] D22679: [mips][ias] Enable IAS by default for N64 on Debian mips64el.

2016-07-22 Thread Daniel Sanders via cfe-commits
dsanders created this revision. dsanders added a reviewer: sdardis. dsanders added a subscriber: cfe-commits. Unfortunately we can't enable it for all N64 because it is not yet possible to distinguish N32 from N64 from the triple on other environments.

r276417 - [X86][AVX] Added support for lowering to VBROADCASTF128/VBROADCASTI128 with generic IR

2016-07-22 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Fri Jul 22 08:58:56 2016 New Revision: 276417 URL: http://llvm.org/viewvc/llvm-project?rev=276417&view=rev Log: [X86][AVX] Added support for lowering to VBROADCASTF128/VBROADCASTI128 with generic IR As discussed on D22460, I've updated the vbroadcastf128 pd256/ps256 builtin

Re: [PATCH] D21962: MPITypeMismatchCheck for Clang-Tidy

2016-07-22 Thread Alexander Droste via cfe-commits
Alexander_Droste updated this revision to Diff 65072. Alexander_Droste added a comment. This update addresses all requested changes. All integration tests are still passing. https://reviews.llvm.org/D21962 Files: clang-tidy/CMakeLists.txt clang-tidy/mpi/CMakeLists.txt clang-tidy/mpi/MPIT

Re: [PATCH] D21962: MPITypeMismatchCheck for Clang-Tidy

2016-07-22 Thread Alexander Droste via cfe-commits
Alexander_Droste marked 5 inline comments as done. Alexander_Droste added a comment. > You need to add this to ClangTidyMain.cpp: Thanks for pointing this out and reviewing the code once more! https://reviews.llvm.org/D21962 ___ cfe-commits mailin

Re: r276250 - [Sema, X86] Add explicit check to ensure that builtins that require x86-64 target throw an error if used on 32-bit target.

2016-07-22 Thread Hans Wennborg via cfe-commits
Should we merge this to 3.9? On Thu, Jul 21, 2016 at 3:38 AM, Craig Topper via cfe-commits wrote: > Author: ctopper > Date: Thu Jul 21 02:38:43 2016 > New Revision: 276250 > > URL: http://llvm.org/viewvc/llvm-project?rev=276250&view=rev > Log: > [Sema,X86] Add explicit check to ensure that builti

Re: r276352 - [Sema] Handle errors during rewriteBuiltinFunctionDecl

2016-07-22 Thread Hans Wennborg via cfe-commits
Richard: should we merge this to 3.9? On Thu, Jul 21, 2016 at 7:03 PM, David Majnemer via cfe-commits wrote: > Author: majnemer > Date: Thu Jul 21 18:03:43 2016 > New Revision: 276352 > > URL: http://llvm.org/viewvc/llvm-project?rev=276352&view=rev > Log: > [Sema] Handle errors during rewriteBuil

Re: r276350 - [CodeGen] Fix a crash when constant folding switch statement

2016-07-22 Thread Hans Wennborg via cfe-commits
Richard: should we merge this to 3.9? On Thu, Jul 21, 2016 at 6:31 PM, Erik Pilkington via cfe-commits wrote: > Author: epilk > Date: Thu Jul 21 17:31:40 2016 > New Revision: 276350 > > URL: http://llvm.org/viewvc/llvm-project?rev=276350&view=rev > Log: > [CodeGen] Fix a crash when constant foldi

Re: [PATCH] D5409: Fix for PR18393 - emit error when abstract type is returned or taken by value

2016-07-22 Thread Elias Pipping via cfe-commits
pipping added a subscriber: pipping. pipping added a comment. Any updates on this? https://reviews.llvm.org/D5409 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r276415 - Revert "Revert "[clang-tidy] new cppcoreguidelines-slicing""

2016-07-22 Thread Clement Courbet via cfe-commits
Author: courbet Date: Fri Jul 22 08:45:00 2016 New Revision: 276415 URL: http://llvm.org/viewvc/llvm-project?rev=276415&view=rev Log: Revert "Revert "[clang-tidy] new cppcoreguidelines-slicing"" Second try for r276408 Added: clang-tools-extra/trunk/clang-tidy/cppcoreguidelines/SlicingCheck.c

Re: r276232 - [Sema] Fix PR28623.

2016-07-22 Thread Hans Wennborg via cfe-commits
Does this apply to 3.9? On Wed, Jul 20, 2016 at 11:28 PM, George Burgess IV via cfe-commits wrote: > Author: gbiv > Date: Wed Jul 20 22:28:13 2016 > New Revision: 276232 > > URL: http://llvm.org/viewvc/llvm-project?rev=276232&view=rev > Log: > [Sema] Fix PR28623. > > In atomic builtins, we assume

Re: [PATCH] D22465: [clang-rename] introduce better symbol finding and add few more tests

2016-07-22 Thread Kirill Bobyrev via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL276414: [clang-rename] introduce better symbol finding (authored by omtcyfz). Changed prior to commit: https://reviews.llvm.org/D22465?vs=65066&id=65067#toc Repository: rL LLVM https://reviews.llvm.

[clang-tools-extra] r276414 - [clang-rename] introduce better symbol finding

2016-07-22 Thread Kirill Bobyrev via cfe-commits
Author: omtcyfz Date: Fri Jul 22 08:41:09 2016 New Revision: 276414 URL: http://llvm.org/viewvc/llvm-project?rev=276414&view=rev Log: [clang-rename] introduce better symbol finding This patch introduces: * TypeLoc visiting, which helps a lot in renaming types * NestedNameSpecifierLoc visiting (t

  1   2   >