Author: akirtzidis
Date: Fri Jul 29 21:20:21 2016
New Revision: 277261
URL: http://llvm.org/viewvc/llvm-project?rev=277261&view=rev
Log:
[c-index-test] Make sure to check that clang_Cursor_getNumTemplateArguments did
not return -1.
Modified:
cfe/trunk/tools/c-index-test/c-index-test.c
Modif
vsk added a subscriber: vsk.
vsk added a comment.
This is neat!
I may be missing something, but could you explain why 'false-positives.cpp' was
deleted? I'd expect the test to be incorporated into 'functions.cpp' with the
'expected-*' directives removed.
Comment at: lib/Analy
It seems the compiler was getting thrown off by the in-class
initializers of the local MapInfo struct. I've tried to work around
this in r277256. Hopefully this will make the buildbots happier.
Cheers,
Hans
On Fri, Jul 29, 2016 at 2:20 PM, Samuel F Antao wrote:
> Hi Hans,
>
> Thanks for the trou
zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.
Since this is an improvement, it looks good to me. (Improving printing of ObjC
methods is a good add on, but not blocking..)
https://reviews.llvm.org/D22856
_
Author: hans
Date: Fri Jul 29 19:41:37 2016
New Revision: 277256
URL: http://llvm.org/viewvc/llvm-project?rev=277256&view=rev
Log:
Fix VS2013 build of CGOpenMPRuntime.cpp
It seems the compiler was getting confused by the in-class initializers
in local struct MapInfo, so moving those to a default
zaks.anna added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:206
@@ +205,3 @@
+: Call.getArgExpr(ArgNo)->getType().getCanonicalType();
+ }
+ static QualType getArgType(const CallExpr *CE, ArgNoTy ArgNo) {
---
zaks.anna added a subscriber: Alexander_Droste.
zaks.anna added a comment.
> Even though there are some doxygen-style comments in the checkers, i’ve never
> seen doxygen actually generate any docs for checker classes.
> Are they useful for IDE quick-hints only?
I think it's useful to have co
zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.
LGTM
Thank you!
https://reviews.llvm.org/D22926
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
dcoughlin added a comment.
As PR15623 shows, returning the existing cast is not correct. But rather than
replace it with an unknown, here is a proposal for how to address this without
regressing in precision.
Instead of using `assumeDual()` in `ExprEngine::VisitLogicalExpr()` on the
`RHSVal` a
zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.
Ok. LGTM.
Thank you!
Anna.
https://reviews.llvm.org/D22810
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
zaks.anna added inline comments.
Comment at: lib/StaticAnalyzer/Core/PathDiagnostic.cpp:216
@@ +215,3 @@
+llvm::raw_svector_ostream warning(buf);
+warning << "warning: Path diagnostic report is not generated. Current "
+<< "output format does not support diagno
Hi Hans,
Can you make sure this makes it into 3.9 please?
Thanks!
-eric
On Fri, Jul 29, 2016 at 3:18 PM Eric Christopher via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: echristo
> Date: Fri Jul 29 17:11:11 2016
> New Revision: 277221
>
> URL: http://llvm.org/viewvc/llvm-project?
teemperor created this revision.
teemperor added reviewers: v.g.vassilev, NoQ, zaks.anna.
teemperor added a subscriber: cfe-commits.
One of the current false-positives the CloneDetector produces is that the
statements `a < b ? b` and `b < a ? b` are considered clones of each other,
even though t
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thank you!
https://reviews.llvm.org/D22668
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
hubert.reinterpretcast updated this revision to Diff 66194.
hubert.reinterpretcast added a comment.
Make FixedSizeStorage accessible to test code
FixedSizeStorage and not FixedSizeStorageOwner is what the test code needs. Use
alias template to avoid issues with MSVC.
https://reviews.llvm.org/D
Author: hans
Date: Fri Jul 29 17:48:54 2016
New Revision: 277250
URL: http://llvm.org/viewvc/llvm-project?rev=277250&view=rev
Log:
Creating release candidate rc1 from release_390 branch
Added:
libunwind/tags/RELEASE_390/rc1/ (props changed)
- copied from r277249, libunwind/branches/re
Author: hans
Date: Fri Jul 29 17:48:51 2016
New Revision: 277249
URL: http://llvm.org/viewvc/llvm-project?rev=277249&view=rev
Log:
Creating release directory for release_390.
Added:
libunwind/tags/RELEASE_390/
___
cfe-commits mailing list
cfe-commi
Author: hans
Date: Fri Jul 29 17:48:24 2016
New Revision: 277237
URL: http://llvm.org/viewvc/llvm-project?rev=277237&view=rev
Log:
Creating release directory for release_390.
Added:
libcxxabi/tags/RELEASE_390/
___
cfe-commits mailing list
cfe-commi
Author: hans
Date: Fri Jul 29 17:48:26 2016
New Revision: 277238
URL: http://llvm.org/viewvc/llvm-project?rev=277238&view=rev
Log:
Creating release candidate rc1 from release_390 branch
Added:
libcxxabi/tags/RELEASE_390/rc1/
- copied from r277237, libcxxabi/branches/release_39/
___
Author: hans
Date: Fri Jul 29 17:48:17 2016
New Revision: 277235
URL: http://llvm.org/viewvc/llvm-project?rev=277235&view=rev
Log:
Creating release directory for release_390.
Added:
libcxx/tags/RELEASE_390/
___
cfe-commits mailing list
cfe-commits@
Author: hans
Date: Fri Jul 29 17:48:20 2016
New Revision: 277236
URL: http://llvm.org/viewvc/llvm-project?rev=277236&view=rev
Log:
Creating release candidate rc1 from release_390 branch
Added:
libcxx/tags/RELEASE_390/rc1/ (props changed)
- copied from r277235, libcxx/branches/release_
Author: cbieneman
Date: Fri Jul 29 17:48:17 2016
New Revision: 277234
URL: http://llvm.org/viewvc/llvm-project?rev=277234&view=rev
Log:
[Perf-Helper] Add logging for dtrace commands
Logging the dtrace command into the top of the dtrace log is useful when
debugging why the order file generation i
hubert.reinterpretcast updated this revision to Diff 66190.
hubert.reinterpretcast added a comment.
Make FixedSizeStorageOwner accessible to test code
https://reviews.llvm.org/D22668
Files:
include/llvm/Support/AlignOf.h
include/llvm/Support/MathExtras.h
include/llvm/Support/TrailingObjec
sfantao updated this revision to Diff 66189.
sfantao added a comment.
- Remove duplicate keyword in linker script.
https://reviews.llvm.org/D21847
Files:
include/clang/Driver/Options.td
lib/Driver/Driver.cpp
lib/Driver/Tools.cpp
test/Driver/openmp-offload.c
Index: test/Driver/openmp-of
hubert.reinterpretcast updated this revision to Diff 66186.
hubert.reinterpretcast added a comment.
Replace call to LLVM_CONSTEXPR function in constant expression context
https://reviews.llvm.org/D22668
Files:
include/llvm/Support/AlignOf.h
include/llvm/Support/MathExtras.h
include/llvm/S
hubert.reinterpretcast updated this revision to Diff 66185.
hubert.reinterpretcast marked an inline comment as done.
hubert.reinterpretcast added a comment.
Avoid MSVC C4099: replace 'struct' with 'class'
https://reviews.llvm.org/D22668
Files:
include/llvm/Support/AlignOf.h
include/llvm/Sup
Author: echristo
Date: Fri Jul 29 17:11:11 2016
New Revision: 277221
URL: http://llvm.org/viewvc/llvm-project?rev=277221&view=rev
Log:
Remove unused variable.
Fixes PR28761.
Modified:
cfe/trunk/lib/Headers/avx512fintrin.h
Modified: cfe/trunk/lib/Headers/avx512fintrin.h
URL:
http://llvm.org
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thank you for the check! The oddness with the DenseMap can wait until a
follow-up patch, btw.
Repository:
rL LLVM
https://reviews.llvm.org/D22513
___
hubert.reinterpretcast updated this revision to Diff 66179.
hubert.reinterpretcast added a comment.
Address review comments: add tests, access control, Doxygen
https://reviews.llvm.org/D22668
Files:
include/llvm/Support/AlignOf.h
include/llvm/Support/MathExtras.h
include/llvm/Support/Trai
Author: aaronballman
Date: Fri Jul 29 16:41:18 2016
New Revision: 277217
URL: http://llvm.org/viewvc/llvm-project?rev=277217&view=rev
Log:
Sorting includes; NFC.
Modified:
clang-tools-extra/trunk/clang-tidy/readability/IdentifierNamingCheck.cpp
Modified:
clang-tools-extra/trunk/clang-tidy/r
Author: emaste
Date: Fri Jul 29 16:24:19 2016
New Revision: 277215
URL: http://llvm.org/viewvc/llvm-project?rev=277215&view=rev
Log:
libunwind: correct return code in unwinding trace log message
Modified:
libunwind/trunk/src/Unwind-EHABI.cpp
Modified: libunwind/trunk/src/Unwind-EHABI.cpp
URL
Hi Hans,
Thanks for the troubleshooting. I'd prefer to avoid the 'this->', but if Alexey is okay with that I wouldn't mind. The best solution would be to update the compiler of the bot if there is a newer version and see if the issue goes away, but not sure if that is possible at all.
Thanks ag
I agree this looks like a compiler bug, but I'm not sure what's
causing it exactly. Putting "this->" in front of those accesses to
CurDir and CGF seems to fix it, but it's also very ugly.
I tried a couple of other things, like moving the method out-of-line,
but no luck yet.
On Fri, Jul 29, 2016 a
Author: probinson
Date: Fri Jul 29 15:46:16 2016
New Revision: 277211
URL: http://llvm.org/viewvc/llvm-project?rev=277211&view=rev
Log:
Fix CGOpenMPRuntime.cpp for VS2013. NFC.
I don't know why these changes work but they do.
Modified:
cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp
Modified: cfe
I don't have easy access to Windows machine to test this, but it seems that whichever compiler is being used is broken. This is about a member function accessing a variable of the same class. I don't think I am doing any non-portable code pattern here.
Alexey, do you have a easy way to test this
Fixed in: r277206 after review in https://reviews.llvm.org/D22970
From: Keane, Erich
Sent: Friday, July 29, 2016 11:58 AM
To: 'Andrey Bokhanko' ; Mike Aizatsky
Cc: cfe-commits
Subject: RE: r277134 - [GCC] Support for __final specifier
Sure, looking into it now.
From: Andrey Bokhanko [mailto:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277206: Ensure Ident_GNU_final is properly initialized in
the Parser Initialize function (authored by majnemer).
Changed prior to commit:
https://reviews.llvm.org/D22970?vs=66158&id=66165#toc
Repositor
Author: majnemer
Date: Fri Jul 29 15:01:12 2016
New Revision: 277206
URL: http://llvm.org/viewvc/llvm-project?rev=277206&view=rev
Log:
Ensure Ident_GNU_final is properly initialized in the Parser Initialize function
The recent change implementing __final forgot to initialize a variable.
This was
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
Add TEST_STACK_ALLOCATOR_WORKAROUND. As I reported to Eric and Marshall:
"stack_allocator is seriously nonconformant to N4582 17.6.3.5
[allocator.requirements].
First, it lac
vmiklos added a comment.
Great! Manuel, OK to land?
https://reviews.llvm.org/D21814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
Fix an MSVC x64 compiler error due to mismatched iterator types.
This was attempting to store a list>::iterator in a
list::iterator. That isn't guaranteed by the Standard, and
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
Fix an MSVC x64 compiler warning, "warning C4312: 'type cast': conversion from
'unsigned int' to 'int *' of greater size".
The warning (which is valuable) is simple to avoid:
Yes, it still appears to be broken:
http://lab.llvm.org:8011/builders/sanitizer-windows/builds/26504/steps/run%20tests/logs/stdio
On Thu, Jul 28, 2016 at 1:30 PM, Samuel F Antao via cfe-commits
wrote:
> Hi Mike,
>
> I've already pushed r276981 and r276988 to fix those failures shortly after
> I
Author: rnk
Date: Fri Jul 29 14:43:28 2016
New Revision: 277205
URL: http://llvm.org/viewvc/llvm-project?rev=277205&view=rev
Log:
Fix naked.cpp test on 32-bit Windows
Modified:
cfe/trunk/test/CodeGenCXX/naked.cpp
Modified: cfe/trunk/test/CodeGenCXX/naked.cpp
URL:
http://llvm.org/viewvc/llvm
I don't have the ability to commit this, but if it is blocking someone in some
way (since the build verifier would otherwise be broken), someone committing it
before then would be much appreciated.
Thanks!
-Erich
-Original Message-
From: Andrey Bokhanko [mailto:andreybokha...@gmail.com]
andreybokhanko accepted this revision.
andreybokhanko added a comment.
This revision is now accepted and ready to land.
LGTM
I can commit this patch on Monday, when I will reach my work machine.
Andrey
Repository:
rL LLVM
https://reviews.llvm.org/D22970
__
Author: compnerd
Date: Fri Jul 29 14:15:51 2016
New Revision: 277200
URL: http://llvm.org/viewvc/llvm-project?rev=277200&view=rev
Log:
CodeGen: try harder to make the CFString structure RW
The previous change was insufficient to mark the content as read-write as the
structure itself was marked co
erichkeane created this revision.
erichkeane added reviewers: cfe-commits, andreybokhanko, aizatsky.
erichkeane set the repository for this revision to rL LLVM.
erichkeane added a project: clang-c.
My recent change to implement __final missed initializing the variable, which
was caught by the Mem
NoQ created this revision.
NoQ added reviewers: zaks.anna, dcoughlin, rizsotto.mailinglist.
NoQ added a subscriber: cfe-commits.
It seems that the executable scripts are not marked as executable in the
repository, so i had to `chmod +x` them before using. Because the old
scan-build is `+x`, i gu
jbcoe marked 9 inline comments as done.
jbcoe added a comment.
Repository:
rL LLVM
https://reviews.llvm.org/D22513
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jbcoe set the repository for this revision to rL LLVM.
jbcoe updated this revision to Diff 66161.
jbcoe added a comment.
Fix MSVC warning.
Repository:
rL LLVM
https://reviews.llvm.org/D22513
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppcoreguidelines/CppCoreGuidelines
Sure, looking into it now.
From: Andrey Bokhanko [mailto:andreybokha...@gmail.com]
Sent: Friday, July 29, 2016 11:57 AM
To: Mike Aizatsky ; Keane, Erich
Cc: cfe-commits
Subject: Re: r277134 - [GCC] Support for __final specifier
Mike,
Thanks for letting me know.
I committed a patch authored by E
Mike,
Thanks for letting me know.
I committed a patch authored by Erich (CCed); Erich, could you, please,
investigate?
Yours,
Andrey
On Fri, Jul 29, 2016 at 9:35 PM, Mike Aizatsky wrote:
> Andrey,
>
> This change breaks the bot:
>
> http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fa
NoQ created this revision.
NoQ added reviewers: zaks.anna, dcoughlin.
NoQ added a subscriber: cfe-commits.
If you store a boolean value as an Objective-C object `NSNumber *X`, and want
to see if it's true or false, than it's not a good idea to write this check as
'X == YES'. Because X is a point
The test was failing on 3.9 on my Mac, and I noticed there were some
follow-up commits, so I've merged r276983, r277138, r277141 in
r277193.
On Thu, Jul 28, 2016 at 10:18 AM, Hans Wennborg wrote:
> I've merged it in r277004.
>
> Cheers,
> Hans
>
> On Thu, Jul 28, 2016 at 10:15 AM, Samuel F Antao
jasonliu marked an inline comment as done.
Comment at: test/std/re/re.regex/re.regex.construct/ptr_size.pass.cpp:31
@@ +30,3 @@
+test("\\(a\\)", 5, 0);
+test("\\(a[bc]\\)", 9, 0);
+test("\\(a\\([bc]\\)\\)", 13, 0);
Comment addressed in the new patch. T
jasonliu updated this revision to Diff 66153.
jasonliu added a comment.
Address @hubert.reinterpretcast 's comment about the test case. Added more
cases to test "size" parameter in the constructor.
https://reviews.llvm.org/D22702
Files:
include/regex
test/std/re/re.regex/re.regex.construct
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277192: Improve documentation of the type safety attributes.
(authored by ygao).
Changed prior to commit:
https://reviews.llvm.org/D22717?vs=65206&id=66155#toc
Repository:
rL LLVM
https://reviews.ll
Author: ygao
Date: Fri Jul 29 13:34:21 2016
New Revision: 277192
URL: http://llvm.org/viewvc/llvm-project?rev=277192&view=rev
Log:
Improve documentation of the type safety attributes.
1. Add description of the arguments to these attributes.
2. Add missing declarations to some of the MPI code examp
I care highly about my commits. It's just that it's not actually my commit,
I committed it on Amjad's behalf before he had commit permissions. :-)
I think Eli missed the "Patch by" line when he originally added me to the
thread.
On Fri, Jul 29, 2016 at 11:16 AM, Gerolf Hoflehner
wrote:
> Sounds
Andrey,
This change breaks the bot:
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/15093
==15371==WARNING: MemorySanitizer: use-of-uninitialized-value
#0 0x733784d in
clang::Parser::ParseOptionalCXX11VirtSpecifierSeq(clang::VirtSpecifiers&,
bool, clang::SourceLocation)
Sounds like you care highly about your commit :-)
> On Jul 29, 2016, at 10:10 AM, Michael Kuperstein wrote:
>
> mkuper resigned from this revision.
> mkuper removed a reviewer: mkuper.
> mkuper added a comment.
>
> I really don't understand anything about this. :-)
>
>
> https://reviews.ll
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277181: [OpenCL] Add extension cl_khr_mipmap_image to clang
(authored by yaxunl).
Changed prior to commit:
https://reviews.llvm.org/D22637?vs=65773&id=66150#toc
Repository:
rL LLVM
https://reviews.l
Author: yaxunl
Date: Fri Jul 29 12:52:34 2016
New Revision: 277181
URL: http://llvm.org/viewvc/llvm-project?rev=277181&view=rev
Log:
[OpenCL] Add extension cl_khr_mipmap_image to clang
Adding extension cl_khr_mipmap_image to clang's OpenCL Extensions and initiated
inside AMDGPU Target.
Patch by
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277179: [OpenCL] Added CLK_ABGR definition for
get_image_channel_order return value (authored by yaxunl).
Changed prior to commit:
https://reviews.llvm.org/D22767?vs=65375&id=66149#toc
Repository:
rL
Author: yaxunl
Date: Fri Jul 29 12:50:10 2016
New Revision: 277179
URL: http://llvm.org/viewvc/llvm-project?rev=277179&view=rev
Log:
[OpenCL] Added CLK_ABGR definition for get_image_channel_order return value
Added CLK_ABGR definition for get_image_channel_order return value inside
opencl-c.h fi
Author: epilk
Date: Fri Jul 29 12:37:38 2016
New Revision: 277175
URL: http://llvm.org/viewvc/llvm-project?rev=277175&view=rev
Log:
Reapply r277058: "[ObjC] Consider availability of context when emitting
availability warnings"
Modified:
cfe/trunk/include/clang/AST/DeclBase.h
cfe/trunk/in
Oh, my bad...Fixed. Thanks!
On Fri, Jul 29, 2016 at 6:32 PM, Benjamin Kramer
wrote:
> Sorry for being overly dense, you misspelled 'typename' in the docs.
>
> On Fri, Jul 29, 2016 at 5:59 PM, Haojian Wu wrote:
> > No, this is not templateName patch. The templateName one is in r277155.
> >
> > O
Author: hokein
Date: Fri Jul 29 12:30:13 2016
New Revision: 277174
URL: http://llvm.org/viewvc/llvm-project?rev=277174&view=rev
Log:
Fix a typo in document.
Modified:
cfe/trunk/docs/LibASTMatchersReference.html
cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h
Modified: cfe/trunk/docs/Li
aaron.ballman added inline comments.
Comment at: clang-tidy/misc/EnumMisuseCheck.cpp:40
@@ +39,3 @@
+
+// Return the number of EnumConstantDecls in an EnumDecl.
+static int enumLength(const EnumDecl *EnumDec) {
Doxygen comment here as well.
Comme
jasonliu added a comment.
Ping?
https://reviews.llvm.org/D22698
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Fri, Jul 29, 2016 at 10:12 AM, Nico Weber wrote:
> On Thu, Jul 28, 2016 at 9:03 PM, Hans Wennborg wrote:
>>
>> Sorry, I was supposed to chime in here.
>>
>> I don't have a strong opinion on this, but I don't think it's a
>> problem for us to allow the -gline-tables-only spelling in addition to
On Thu, Jul 28, 2016 at 9:03 PM, Hans Wennborg wrote:
> Sorry, I was supposed to chime in here.
>
> I don't have a strong opinion on this, but I don't think it's a
> problem for us to allow the -gline-tables-only spelling in addition to
> /Zd.
>
> It just doesn't seem like a big deal to me.
>
Do
mkuper resigned from this revision.
mkuper removed a reviewer: mkuper.
mkuper added a comment.
I really don't understand anything about this. :-)
https://reviews.llvm.org/D22900
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
Author: mmasten
Date: Fri Jul 29 11:44:24 2016
New Revision: 277167
URL: http://llvm.org/viewvc/llvm-project?rev=277167&view=rev
Log:
Initial vectorization support for svml calls (short vector math library).
Differential Revision: https://reviews.llvm.org/D19544
Modified:
cfe/trunk/include/c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277166: Initial support for vectorization using svml (short
vector math library). (authored by mmasten).
Changed prior to commit:
https://reviews.llvm.org/D19544?vs=65152&id=66141#toc
Repository:
rL
Sorry for being overly dense, you misspelled 'typename' in the docs.
On Fri, Jul 29, 2016 at 5:59 PM, Haojian Wu wrote:
> No, this is not templateName patch. The templateName one is in r277155.
>
> On Fri, Jul 29, 2016 at 4:45 PM, Benjamin Kramer
> wrote:
>>
>> On Fri, Jul 29, 2016 at 3:57 PM, H
omtcyfz added a comment.
In https://reviews.llvm.org/D21814#500735, @vmiklos wrote:
> Yes, exactly, so not easy to customize I guess.
Aha, alright. Well, doesn't matter too much.
LGTM.
https://reviews.llvm.org/D21814
___
cfe-commits mailing list
vmiklos added a comment.
Yes, exactly, so not easy to customize I guess.
https://reviews.llvm.org/D21814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
omtcyfz added a comment.
In https://reviews.llvm.org/D21814#500629, @vmiklos wrote:
> In https://reviews.llvm.org/D21814#500621, @omtcyfz wrote:
>
> > P.S. not sure whether we have to write `clang-rename: for the -new-name
> > option: must be specified` out. We already launched `clang-rename` wh
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277155: [ASTMatcher] Add templateName matcher. (authored by
hokein).
Changed prior to commit:
https://reviews.llvm.org/D22963?vs=66129&id=66130#toc
Repository:
rL LLVM
https://reviews.llvm.org/D2296
Author: hokein
Date: Fri Jul 29 10:45:11 2016
New Revision: 277155
URL: http://llvm.org/viewvc/llvm-project?rev=277155&view=rev
Log:
[ASTMatcher] Add templateName matcher.
Reviewers: klimek
Subscribers: klimek, cfe-commits
Differential Revision: https://reviews.llvm.org/D22963
Modified:
cf
No, this is not templateName patch. The templateName one is in r277155.
On Fri, Jul 29, 2016 at 4:45 PM, Benjamin Kramer
wrote:
> On Fri, Jul 29, 2016 at 3:57 PM, Haojian Wu via cfe-commits
> wrote:
> > Author: hokein
> > Date: Fri Jul 29 08:57:27 2016
> > New Revision: 277142
> >
> > URL: http
hokein marked an inline comment as done.
Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:84-87
@@ -80,4 +83,6 @@
if (const auto *Used = Result.Nodes.getNodeAs("used")) {
-if (const auto *Specialization =
-dyn_cast(Used))
+if (const auto *FD = dyn_cast(
hokein updated this revision to Diff 66131.
hokein added a comment.
Use new ast matchers to simplify the code.
Updating D22803: [clang-tidy] Fix an unused-using-decl false positive about
template arguments in
===
hokein updated this revision to Diff 66129.
hokein marked an inline comment as done.
hokein added a comment.
Fix code style.
https://reviews.llvm.org/D22963
Files:
docs/LibASTMatchersReference.html
include/clang/AST/ASTTypeTraits.h
include/clang/ASTMatchers/ASTMatchers.h
lib/AST/ASTType
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
Comment at: unittests/ASTMatchers/ASTMatchersTraversalTest.cpp:550
@@ +549,3 @@
+"template class Y {};"
+ "X xi;",
+classTemplateSpecializationDecl(hasAnyTempl
hokein created this revision.
hokein added a reviewer: klimek.
hokein added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
https://reviews.llvm.org/D22963
Files:
docs/LibASTMatchersReference.html
include/clang/AST/ASTTypeTraits.h
include/clang/ASTMatchers/ASTMatchers.h
lib/
On Fri, Jul 29, 2016 at 3:57 PM, Haojian Wu via cfe-commits
wrote:
> Author: hokein
> Date: Fri Jul 29 08:57:27 2016
> New Revision: 277142
>
> URL: http://llvm.org/viewvc/llvm-project?rev=277142&view=rev
> Log:
> [ASTMatcher] Add hasTemplateArgument/hasAnyTemplateArgument support in
> functionDe
vmiklos added a comment.
In https://reviews.llvm.org/D21814#500621, @omtcyfz wrote:
> P.S. not sure whether we have to write `clang-rename: for the -new-name
> option: must be specified` out. We already launched `clang-rename` what else
> could've give us an error?
You mean how is that error
omtcyfz added a comment.
P.S. not sure whether we have to write `clang-rename: for the -new-name option:
must be specified` out. We already launched `clang-rename` what else could've
give us an error?
https://reviews.llvm.org/D21814
___
cfe-commit
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277142: [ASTMatcher] Add
hasTemplateArgument/hasAnyTemplateArgument support in… (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D22957?vs=66094&id=66119#toc
Repository:
rL LLV
Author: hokein
Date: Fri Jul 29 08:57:27 2016
New Revision: 277142
URL: http://llvm.org/viewvc/llvm-project?rev=277142&view=rev
Log:
[ASTMatcher] Add hasTemplateArgument/hasAnyTemplateArgument support in
functionDecl.
Reviewers: klimek
Subscribers: klimek, cfe-commits
Differential Revision: ht
Author: djasper
Date: Fri Jul 29 08:45:03 2016
New Revision: 277141
URL: http://llvm.org/viewvc/llvm-project?rev=277141&view=rev
Log:
Add missing '-no-canonical-prefixes' in test.
Modified:
cfe/trunk/test/Driver/offloading-interoperability.c
Modified: cfe/trunk/test/Driver/offloading-interop
aaron.ballman added inline comments.
Comment at: clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.cpp:60
@@ +59,3 @@
+ }
+}
+
Btw, with MSVC, this will give you a "not all control paths return a value"
warning. You should put an llvm_unreachable() after
Author: d0k
Date: Fri Jul 29 08:07:09 2016
New Revision: 277138
URL: http://llvm.org/viewvc/llvm-project?rev=277138&view=rev
Log:
Make test not fail on hosts where the default omp library is gomp.
This is the case on some linuxes, just force libomp so we get the
desired results.
Modified:
cf
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thank you!
Comment at: include/llvm/Support/MathExtras.h:672
@@ -669,2 +671,3 @@
inline uint64_t alignTo(uint64_t Value, uint64_t Align, uint64_t Skew = 0
aaron.ballman added a comment.
In https://reviews.llvm.org/D22668#500340, @hubert.reinterpretcast wrote:
> In https://reviews.llvm.org/D22668#499164, @aaron.ballman wrote:
>
> > I don't suppose there's a way to test these changes, is there?
>
>
> It's a utility class (which is not even used yet).
vmiklos added a comment.
> Just write a FIXME then, I think I may look into that on the next week or
> somewhen.
Done.
> Most of the time I use Foo->Bar renaming in tests
Done, I've renamed ClaN->KlaN to FooN->BarN.
https://reviews.llvm.org/D21814
___
vmiklos updated this revision to Diff 66110.
https://reviews.llvm.org/D21814
Files:
clang-rename/RenamingAction.cpp
clang-rename/RenamingAction.h
clang-rename/tool/ClangRename.cpp
docs/clang-rename.rst
test/clang-rename/ClassFindByName.cpp
test/clang-rename/ClassTestMulti.cpp
test/c
1 - 100 of 120 matches
Mail list logo
