[libcxxabi] r282692 - [libc++abi] Use fallback_malloc to allocate __cxa_eh_globals in case of dynamic memory exhaustion.

Author: ikudrin Date: Thu Sep 29 01:38:06 2016 New Revision: 282692 URL: http://llvm.org/viewvc/llvm-project?rev=282692&view=rev Log: [libc++abi] Use fallback_malloc to allocate __cxa_eh_globals in case of dynamic memory exhaustion. Throwing an exception for the first time may lead to call callo

Re: [PATCH] D17815: [libc++abi] Use fallback_malloc to allocate __cxa_eh_globals in case of dynamic memory exhaustion.

This revision was automatically updated to reflect the committed changes. Closed by commit rL282692: [libc++abi] Use fallback_malloc to allocate __cxa_eh_globals in case of… (authored by ikudrin). Changed prior to commit: https://reviews.llvm.org/D17815?vs=54189&id=72951#toc Repository: rL L

[PATCH] D25060: [Coroutines] Fix assertion about uncorrected typos in co_await/co_yield/co_return expressions.

EricWF created this revision. EricWF added reviewers: rsmith, GorNishanov. EricWF added a subscriber: cfe-commits. Herald added a subscriber: mehdi_amini. If there is an error finding the `coroutine_traits` template when building a coroutine AST nodes we throw away the remainder of the assignment

[libcxx] r282681 - [libc++] Add missing locale aliases

Author: smeenai Date: Wed Sep 28 22:35:41 2016 New Revision: 282681 URL: http://llvm.org/viewvc/llvm-project?rev=282681&view=rev Log: [libc++] Add missing locale aliases Add underscore aliases for strtof_l and strtod_l. _strtold_l exists in VS 2013 and above, so fix that definition as a drive-by

Re: [PATCH] D25059: [libc++] Add missing locale aliases

This revision was automatically updated to reflect the committed changes. Closed by commit rL282681: [libc++] Add missing locale aliases (authored by smeenai). Changed prior to commit: https://reviews.llvm.org/D25059?vs=72942&id=72948#toc Repository: rL LLVM https://reviews.llvm.org/D25059

Re: [PATCH] D24599: Add 'inline' but not _LIBCPP_INLINE_VISIBILITY to basic_string's destructor

hiraditya added a comment. I think now the original patch can be re-applied now that the bug: https://llvm.org/bugs/show_bug.cgi?id=30341 has been fixed in https://reviews.llvm.org/D24682 https://reviews.llvm.org/D24599 ___ cfe-commits mailing list

Re: [PATCH] D24682: [PR30341] Alias must point to a definition

This revision was automatically updated to reflect the committed changes. Closed by commit rL282679: [PR30341] Alias must point to a definition (authored by hiraditya). Changed prior to commit: https://reviews.llvm.org/D24682?vs=72898&id=72947#toc Repository: rL LLVM https://reviews.llvm.or

r282679 - [PR30341] Alias must point to a definition

Author: hiraditya Date: Wed Sep 28 22:32:04 2016 New Revision: 282679 URL: http://llvm.org/viewvc/llvm-project?rev=282679&view=rev Log: [PR30341] Alias must point to a definition Inlining the destructor caused the compiler to generate bad IR which failed the Verifier in the backend. https://llvm

[PATCH] D25059: [libc++] Add missing locale aliases

smeenai created this revision. smeenai added reviewers: compnerd, EricWF, mclow.lists. smeenai added a subscriber: cfe-commits. Add underscore aliases for strtof_l and strtod_l. _strtold_l exists in VS 2013 and above, so fix that definition as a drive-by fix. https://reviews.llvm.org/D25059 File

Re: [PATCH] D25053: [libc++] Correct alignment condition

smeenai added a comment. It's not – I just wasn't aware of the existence of the other one :) That one's been stagnant for a long time though. One of these changes should be abandoned in favor of the other, and I'm fine doing it either way. https://reviews.llvm.org/D25053 ___

Re: [PATCH] D25053: [libc++] Correct alignment condition

mclow.lists added a comment. How is this different from https://reviews.llvm.org/D14259 ?? https://reviews.llvm.org/D25053 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r282660 - Partially revert overflow checking in last_write_time

Author: ericwf Date: Wed Sep 28 20:01:26 2016 New Revision: 282660 URL: http://llvm.org/viewvc/llvm-project?rev=282660&view=rev Log: Partially revert overflow checking in last_write_time Modified: libcxx/trunk/src/experimental/filesystem/operations.cpp Modified: libcxx/trunk/src/experimental

Re: [PATCH] D5041: Fix for clang_Cursor_getSpellingNameRange() reportage of C++ functions

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in https://reviews.llvm.org/rL216480. https://reviews.llvm.org/D5041 ___ cfe-commits mailing list cfe-commits@lists.llv

Re: [PATCH] D5109: Fix "#pragma clang __debug overflow_stack" for MSVC builds

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Looks like patch was not committed. Does it still make sense? https://reviews.llvm.org/D5109 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm

r282652 - Mark P0127R3 as done, and replace its __has_feature check with the corresponding SD-6 macro.

Author: rsmith Date: Wed Sep 28 19:08:05 2016 New Revision: 282652 URL: http://llvm.org/viewvc/llvm-project?rev=282652&view=rev Log: Mark P0127R3 as done, and replace its __has_feature check with the corresponding SD-6 macro. Modified: cfe/trunk/lib/Frontend/InitPreprocessor.cpp cfe/trun

Re: [PATCH] D5789: C99 partial re-initialization behavior (DR-253)

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in https://reviews.llvm.org/rL239446. https://reviews.llvm.org/D5789 ___ cfe-commits mailing list cfe-commits@lists.llv

r282651 - P0127R2: Support type deduction for types of non-type template parameters in

Author: rsmith Date: Wed Sep 28 18:55:27 2016 New Revision: 282651 URL: http://llvm.org/viewvc/llvm-project?rev=282651&view=rev Log: P0127R2: Support type deduction for types of non-type template parameters in C++1z. Patch by James Touton! Some bugfixes and rebasing by me. Modified: cfe/trun

Re: [PATCH] D24693: [CodeGen] Don't emit lifetime intrinsics for some local variables

eugenis added a comment. In https://reviews.llvm.org/D24693#553474, @vitalybuka wrote: > My assumption is that "start" makes access valid, and "end" makes access > invalid, up to the next "start". That's also my understanding, but LangRef does not say anything about llvm.lifetime.start cancel

Buildbot numbers for the last week of 9/18/2016 - 9/24/2016

Hello everyone, Below are some buildbot numbers for the last week of 9/18/2016 - 9/24/2016. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status from

Re: [PATCH] D25040: [Coverage] Do not emit coverage mappings for functions marked 'unused'

vsk added a comment. In https://reviews.llvm.org/D25040#556209, @arphaman wrote: > In https://reviews.llvm.org/D25040#556165, @vsk wrote: > > > In https://reviews.llvm.org/D25040#556109, @arphaman wrote: > > > > > Thanks for working on this, I have a couple of comments/questions: > > > > > > - Th

Re: [PATCH] D25040: [Coverage] Do not emit coverage mappings for functions marked 'unused'

arphaman added a comment. In https://reviews.llvm.org/D25040#556165, @vsk wrote: > In https://reviews.llvm.org/D25040#556109, @arphaman wrote: > > > Thanks for working on this, I have a couple of comments/questions: > > > > - The current logic doesn't work correctly for a test case that's shown

Re: [PATCH] D24573: [CUDA] Do a better job at detecting wrong-side calls.

jlebar added a comment. I'm sorry to put more stuff on your plate, Richard, but you already have context on this, so you may be the best person to review this. Unfortunately people keep hitting the bug fixed here (and being confused), so it's maybe not as much of an edge case as I thought. FW

[PATCH] D25053: [libc++] Correct alignment condition

smeenai created this revision. smeenai added reviewers: compnerd, EricWF, mclow.lists. smeenai added a subscriber: cfe-commits. The max alignment is a PE/COFF restriction, not an MSVC-specific restriction; it also applies to gcc and clang when compiling for Windows. Change the conditional to _WIN3

Re: [PATCH] D25040: [Coverage] Do not emit coverage mappings for functions marked 'unused'

vsk added a comment. In https://reviews.llvm.org/D25040#556109, @arphaman wrote: > Thanks for working on this, I have a couple of comments/questions: > > - The current logic doesn't work correctly for a test case that's shown below: > > ``` class C2 { void __attribute__((unused)) m4() { } void

Re: [PATCH] D25036: [CUDA] Disallow exceptions in device code.

This revision was automatically updated to reflect the committed changes. jlebar marked an inline comment as done. Closed by commit rL282646: [CUDA] Disallow exceptions in device code. (authored by jlebar). Changed prior to commit: https://reviews.llvm.org/D25036?vs=72872&id=72918#toc Reposito

r282647 - [CUDA] Disallow variable-length arrays in CUDA device code.

Author: jlebar Date: Wed Sep 28 17:45:58 2016 New Revision: 282647 URL: http://llvm.org/viewvc/llvm-project?rev=282647&view=rev Log: [CUDA] Disallow variable-length arrays in CUDA device code. Reviewers: tra Subscribers: cfe-commits, jhen Differential Revision: https://reviews.llvm.org/D25050

Re: [PATCH] D25050: [CUDA] Disallow variable-length arrays in CUDA device code.

This revision was automatically updated to reflect the committed changes. Closed by commit rL282647: [CUDA] Disallow variable-length arrays in CUDA device code. (authored by jlebar). Changed prior to commit: https://reviews.llvm.org/D25050?vs=72914&id=72919#toc Repository: rL LLVM https://r

r282646 - [CUDA] Disallow exceptions in device code.

Author: jlebar Date: Wed Sep 28 17:45:54 2016 New Revision: 282646 URL: http://llvm.org/viewvc/llvm-project?rev=282646&view=rev Log: [CUDA] Disallow exceptions in device code. Reviewers: tra Subscribers: cfe-commits, jhen Differential Revision: https://reviews.llvm.org/D25036 Added: cfe/tr

[PATCH] D25051: Fix PR 10758: Infinite recursion when dealing with copy-initialization

arphaman created this revision. arphaman added a reviewer: rsmith. arphaman added a subscriber: cfe-commits. arphaman set the repository for this revision to rL LLVM. This patch fixes a bug that's tracked by PR 10758 and duplicates like PR 30343. The bug causes clang to crash with a stack overflo

Re: [PATCH] D25045: [Coroutines] Add proper mangling for operator co_await for MicrosoftABI

This revision was automatically updated to reflect the committed changes. Closed by commit rL282645: [Coroutines] Add proper mangling for operator co_await for MicrosoftABI (authored by GorNishanov). Changed prior to commit: https://reviews.llvm.org/D25045?vs=72900&id=72916#toc Repository: r

r282645 - [Coroutines] Add proper mangling for operator co_await for MicrosoftABI

Author: gornishanov Date: Wed Sep 28 17:37:17 2016 New Revision: 282645 URL: http://llvm.org/viewvc/llvm-project?rev=282645&view=rev Log: [Coroutines] Add proper mangling for operator co_await for MicrosoftABI Reviewers: rnk, rsmith Subscribers: mehdi_amini, cfe-commits Differential Revision: h

[libcxx] r282644 - [libc++] Clarify _LIBCPP_NEW_DELETE_VIS for Windows

Author: smeenai Date: Wed Sep 28 17:28:51 2016 New Revision: 282644 URL: http://llvm.org/viewvc/llvm-project?rev=282644&view=rev Log: [libc++] Clarify _LIBCPP_NEW_DELETE_VIS for Windows Replace a stale reference to cxx_EXPORTS with _LIBCPP_BUILDING_LIBRARY, and clarify why the operator new and de

Re: [PATCH] D25042: [libc++] Clarify _LIBCPP_NEW_DELETE_VIS for Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rL282644: [libc++] Clarify _LIBCPP_NEW_DELETE_VIS for Windows (authored by smeenai). Changed prior to commit: https://reviews.llvm.org/D25042?vs=72911&id=72915#toc Repository: rL LLVM https://reviews.

[PATCH] D25050: [CUDA] Disallow variable-length arrays in CUDA device code.

jlebar created this revision. jlebar added a reviewer: tra. jlebar added subscribers: jhen, cfe-commits. https://reviews.llvm.org/D25050 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaCUDA.cpp clang/lib/Sema/SemaType.cpp clang/

Re: [PATCH] D25040: [Coverage] Do not emit coverage mappings for functions marked 'unused'

arphaman added a comment. Thanks for working on this, I have a couple of comments/questions: - The current logic doesn't work correctly for a test case that's shown below: class C2 { void __attribute__((unused)) m4() { } void __attribute__((unused)) m5(); }; The method 'm4' actually

r282641 - Fix bug where template argument deduction of a non-type template parameter used

Author: rsmith Date: Wed Sep 28 17:08:38 2016 New Revision: 282641 URL: http://llvm.org/viewvc/llvm-project?rev=282641&view=rev Log: Fix bug where template argument deduction of a non-type template parameter used as a template argument in a template-id, from a null non-type template argument, fail

[libcxx] r282640 - Mark libc++ internal globals with _LIBCPP_SAFE_STATIC.

Author: ericwf Date: Wed Sep 28 17:08:13 2016 New Revision: 282640 URL: http://llvm.org/viewvc/llvm-project?rev=282640&view=rev Log: Mark libc++ internal globals with _LIBCPP_SAFE_STATIC. This patch applies the _LIBCPP_SAFE_STATIC attribute to internal globals, most of which are locking primitive

Re: [PATCH] D25042: [libc++] Clarify _LIBCPP_NEW_DELETE_VIS for Windows

smeenai updated this revision to Diff 72911. smeenai added a comment. Moving documentation to documentation file, per @EricWF's comment https://reviews.llvm.org/D25042 Files: docs/DesignDocs/VisibilityMacros.rst include/new Index: include/new ===

[PATCH] D25049: Add missing std::move in Replacements::add

alexshap created this revision. alexshap added reviewers: djasper, klimek, ioeric. alexshap added a subscriber: cfe-commits. alexshap set the repository for this revision to rL LLVM. alexshap changed the visibility of this Differential Revision from "Public (No Login Required)" to "All Users". Her

Re: [PATCH] D24693: [CodeGen] Don't emit lifetime intrinsics for some local variables

vitalybuka updated this revision to Diff 72909. vitalybuka added a comment. rebase https://reviews.llvm.org/D24693 Files: lib/CodeGen/CGDecl.cpp lib/CodeGen/CMakeLists.txt lib/CodeGen/CodeGenFunction.cpp lib/CodeGen/CodeGenFunction.h lib/CodeGen/VarBypassDetector.cpp lib/CodeGen/Var

Re: [PATCH] D24695: [CodeGen] Move shouldEmitLifetimeMarkers into more convenient place

vitalybuka updated this revision to Diff 72908. vitalybuka added a comment. rebase https://reviews.llvm.org/D24695 Files: lib/CodeGen/CGDecl.cpp lib/CodeGen/CodeGenFunction.cpp lib/CodeGen/CodeGenFunction.h Index: lib/CodeGen/CodeGenFunction.h

Re: [PATCH] D24695: [CodeGen] Move shouldEmitLifetimeMarkers into more convenient place

vitalybuka updated this revision to Diff 72907. vitalybuka added a comment. Herald added subscribers: mgorny, beanz. rebase https://reviews.llvm.org/D24695 Files: lib/CodeGen/CGDecl.cpp lib/CodeGen/CMakeLists.txt lib/CodeGen/CodeGenFunction.cpp lib/CodeGen/CodeGenFunction.h lib/CodeGe

Re: [PATCH] D24864: [libcxxabi] Refactor pthread usage into a separate API

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM once the `_POSIX_THREADS` comment is addressed. Comment at: src/config.h:46 @@ +45,3 @@ +defined(__linux__) || \ +defined(__APPLE__) || \ +defined(__CloudABI_

[PATCH] D25047: [AST] Add a const version of CallExpr::children() (NFC)

vsk created this revision. vsk added reviewers: bkramer, rsmith. vsk added a subscriber: cfe-commits. This makes it possible to visit the children of a CallExpr from a ConstStmtVisitor. https://reviews.llvm.org/D25047 Files: include/clang/AST/Expr.h Index: include/clang/AST/Expr.h ==

Re: [PATCH] D8048: TypePrinter print __restrict if not in C99 mode

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in https://reviews.llvm.org/rL231179. https://reviews.llvm.org/D8048 ___ cfe-commits mailing list cfe-commits@lists.llv

Re: [PATCH] D24886: Add [[clang::suppress(rule, ...)]] attribute

mgehre added a comment. My main goal is to be able to suppress any clang-tidy warning through an attribute. Initially, I though we could reuse the C++ Core Guidelines attribute for that, (because I though it was plain [[suppress]]). As a bonus (not more), we would have interoperability with oth

Re: [PATCH] D25042: [libc++] Clarify _LIBCPP_NEW_DELETE_VIS for Windows

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM modulo inline comments. Comment at: include/new:129 @@ +128,3 @@ +/* + * NOTE: When using the Microsoft CRT, the operator new and delete + * family of functions are defin

[libcxx] r282634 - Improve 'last_write_time(...)' accuracy and detect overflow errors.

Author: ericwf Date: Wed Sep 28 16:16:58 2016 New Revision: 282634 URL: http://llvm.org/viewvc/llvm-project?rev=282634&view=rev Log: Improve 'last_write_time(...)' accuracy and detect overflow errors. The ::stat struct on Linux, FreeBSD, and OS X provides the access and modification times as an

[PATCH] D25045: [Coroutines] Add proper mangling for operator co_await for MicrosoftABI

GorNishanov created this revision. GorNishanov added reviewers: rsmith, rnk. GorNishanov added a subscriber: cfe-commits. Herald added a subscriber: mehdi_amini. https://reviews.llvm.org/D25045 Files: lib/AST/MicrosoftMangle.cpp test/CodeGenCoroutines/microsoft-abi-operator-coawait.cpp Index

Re: [PATCH] D24397: Target Power9 bit counting and vector comparison instructions through builtins (front end portion)

echristo added inline comments. Comment at: lib/Basic/Targets.cpp:1393 @@ +1392,3 @@ + +if (std::find(FeaturesVec.begin(), FeaturesVec.end(), "+power9-vector") != +FeaturesVec.end()) { Can you combine this with the power8 check above?

Re: [PATCH] D23236: When ARC is enabled, no warning will be generated when a method1. Returns 'nil' in a method that is attributed to return a 'nonnull'2. The return-statement is a ConditionalOperator

parallaxe added a comment. I tried to commit by using arc, though it didn't work as I was prompted to login into the subversion-repository, which I can't. At this point I'm not sure if this should have worked or not, but I assumed that arc + phabricator would handle it in a way that i wouldn't

Re: [PATCH] D24682: [PR30341] Alias must point to a definition

hiraditya updated this revision to Diff 72898. hiraditya added a comment. Addressed Richard's comment. https://reviews.llvm.org/D24682 Files: clang/lib/CodeGen/CGCXX.cpp clang/test/CodeGenCXX/alias-available-externally.cpp Index: clang/test/CodeGenCXX/alias-available-externally.cpp ===

Re: [PATCH] D24682: [PR30341] Alias must point to a definition

hiraditya added inline comments. Comment at: clang/lib/CodeGen/CGCXX.cpp:169 @@ -170,3 +168,3 @@ // If we have a weak, non-discardable alias (weak, weak_odr), like an extern // template instantiation or a dllexported class, avoid forming it on COFF. Thanks

r282631 - cxx_status: use HTML5 details/summary elements to hide implementation status

Author: rsmith Date: Wed Sep 28 16:01:37 2016 New Revision: 282631 URL: http://llvm.org/viewvc/llvm-project?rev=282631&view=rev Log: cxx_status: use HTML5 details/summary elements to hide implementation status tables for fully-implemented language modes by default. Also add some missing elements t

Re: [PATCH] D24800: Merge conflicting replacements when they are order-independent.

alexshap added inline comments. Comment at: cfe/trunk/lib/Tooling/Core/Replacement.cpp:182 @@ +181,3 @@ +llvm::Expected +Replacements::mergeIfOrderIndependent(const Replacement &R) const { + Replacements Rs(R); ioeric wrote: > alexshap wrote: > > sorry, probably

r282629 - Add a couple more tentative names for upcoming SD-6 feature checks. These might

Author: rsmith Date: Wed Sep 28 15:42:56 2016 New Revision: 282629 URL: http://llvm.org/viewvc/llvm-project?rev=282629&view=rev Log: Add a couple more tentative names for upcoming SD-6 feature checks. These might not reflect the final chosen names, but supporting them now seems to have little down

Re: [PATCH] D25042: [libc++] Clarify _LIBCPP_NEW_DELETE_VIS for Windows

smeenai updated this revision to Diff 72891. smeenai added a comment. Clarifying code comment https://reviews.llvm.org/D25042 Files: include/new Index: include/new === --- include/new +++ include/new @@ -125,8 +125,18 @@ } /

[PATCH] D25042: [libc++] Clarify _LIBCPP_NEW_DELETE_VIS for Windows

smeenai created this revision. smeenai added reviewers: compnerd, EricWF, mclow.lists. smeenai added a subscriber: cfe-commits. Replace a stale reference to cxx_EXPORTS with _LIBCPP_BUILDING_LIBRARY, and clarify why the operator new and delete family of functions are marked dllexport when building

r282627 - P0095R3: Implement the latest published revision of SD-6 (C++ feature test macros).

Author: rsmith Date: Wed Sep 28 15:26:06 2016 New Revision: 282627 URL: http://llvm.org/viewvc/llvm-project?rev=282627&view=rev Log: P0095R3: Implement the latest published revision of SD-6 (C++ feature test macros). Modified: cfe/trunk/lib/Frontend/InitPreprocessor.cpp cfe/trunk/test/Le

Re: [PATCH] D24800: Merge conflicting replacements when they are order-independent.

alexshap added a subscriber: alexshap. Comment at: cfe/trunk/lib/Tooling/Core/Replacement.cpp:182 @@ +181,3 @@ +llvm::Expected +Replacements::mergeIfOrderIndependent(const Replacement &R) const { + Replacements Rs(R); sorry, probably i am late to the party, howev

Re: [PATCH] D24848: [clang-tidy] fix false-positive for cppcoreguidelines-pro-type-member-init with in-class initializers

This revision was automatically updated to reflect the committed changes. Closed by commit rL282625: [clang-tidy] fix false-positive for cppcoreguidelines-pro-type-member-init… (authored by mgehre). Changed prior to commit: https://reviews.llvm.org/D24848?vs=72677&id=72885#toc Repository: rL

[clang-tools-extra] r282625 - [clang-tidy] fix false-positive for cppcoreguidelines-pro-type-member-init with in-class initializers

Author: mgehre Date: Wed Sep 28 15:06:18 2016 New Revision: 282625 URL: http://llvm.org/viewvc/llvm-project?rev=282625&view=rev Log: [clang-tidy] fix false-positive for cppcoreguidelines-pro-type-member-init with in-class initializers Summary: This fixes https://llvm.org/bugs/show_bug.cgi?id=304

Re: [PATCH] D24481: make “#pragma STDC FP_CONTRACT” on by default

- Original Message - > From: "Matthias Braun" > To: "Hal Finkel" > Cc: "Steve Canon" , "yaxun liu" , "a > skolnik" , > cfe-commits@lists.llvm.org, clatt...@apple.com, > reviews+d24481+public+c0b8d50a92298...@reviews.llvm.org > Sent: Wednesday, September 28, 2016 2:55:44 PM > Subject: Re

Re: [PATCH] D21853: [Driver][OpenMP] Update actions builder to create unbundling action when necessary.

hfinkel added inline comments. Comment at: lib/Driver/Driver.cpp:2091 @@ +2090,3 @@ +InputArg->getOption().getKind() == llvm::opt::Option::InputClass && +!types::isSrcFile(HostAction->getType())) { + auto UnbundlingHostAction = hfinkel wrote:

[PATCH] D25040: [Coverage] Do not emit coverage mappings for functions marked 'unused'

vsk created this revision. vsk added a reviewer: arphaman. vsk added a subscriber: cfe-commits. This lets us suppress coverage reporting for ~30 functions across llvm and clang. I passed the test case through llvm-cov and verified that 'unused' functions are skipped, e.g: ``` 3| |voi

Re: [PATCH] D25024: [clang-tidy] Add check for detecting declarations with multiple names

Eugene.Zelenko added inline comments. Comment at: docs/ReleaseNotes.rst:62 @@ -60,1 +61,3 @@ + `_ check + - New `cppcoreguidelines-slicing Please add one sentence de

Re: [PATCH] D21857: [Driver][OpenMP] Add support to create jobs for unbundling actions.

hfinkel accepted this revision. hfinkel added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D21857 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

Re: [PATCH] D24481: make “#pragma STDC FP_CONTRACT” on by default

If we do this we should at least be targetted and restrict it to the tests that need the flag. For example you could put: list(APPEND CFLAGS -ffp-contract=off)to MultiSource/Applications/oggenc/CMakeLists.txt and CFLAGS += -ffp-contract=off into MultiSource/Applications/oggenc/Makefile

r282622 - P0096R2: Implement more recent revision of SD-6 (C++ feature test macros).

Author: rsmith Date: Wed Sep 28 14:44:50 2016 New Revision: 282622 URL: http://llvm.org/viewvc/llvm-project?rev=282622&view=rev Log: P0096R2: Implement more recent revision of SD-6 (C++ feature test macros). Modified: cfe/trunk/lib/Frontend/InitPreprocessor.cpp cfe/trunk/test/Lexer/cxx-fe

Re: [PATCH] D25036: [CUDA] Disallow exceptions in device code.

jlebar marked an inline comment as done. Comment at: clang/lib/Sema/SemaExprCXX.cpp:688 @@ +687,3 @@ + if (getLangOpts().CUDA) +CheckCUDAExceptionExpr(OpLoc, "throw"); + tra wrote: > Do you need/want to check returned result? We could, and we could return Exp

Re: [PATCH] D25036: [CUDA] Disallow exceptions in device code.

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. One question, LGTM otherwise. Comment at: clang/lib/Sema/SemaExprCXX.cpp:688 @@ +687,3 @@ + if (getLangOpts().CUDA) +CheckCUDAExceptionExpr(OpLoc, "throw"); +

Re: [PATCH] D25024: [clang-tidy] Add check for detecting declarations with multiple names

omtcyfz added inline comments. Comment at: clang-tidy/cppcoreguidelines/OneNamePerDeclarationCheck.cpp:26 @@ +25,3 @@ + +} // end anonymous namespace + Eugene.Zelenko wrote: > Namespace is inconsistent with following ones. It I'm not mistaken, **// > namespace**

Re: [PATCH] D25024: [clang-tidy] Add check for detecting declarations with multiple names

omtcyfz updated this revision to Diff 72881. omtcyfz marked an inline comment as done. omtcyfz added a comment. Address couple comments. https://reviews.llvm.org/D25024 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp clang-ti

Re: [PATCH] D21856: [Driver][OpenMP] Add support to create jobs for bundling actions.

hfinkel accepted this revision. hfinkel added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D21856 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

Re: [PATCH] D21853: [Driver][OpenMP] Update actions builder to create unbundling action when necessary.

hfinkel added inline comments. Comment at: include/clang/Driver/Action.h:504 @@ +503,3 @@ + /// unbundling action. + struct DependingActionInfoTy final { +/// \brief The tool chain of the depending action. Don't need 'Ty' in the name of this struct. ===

r282621 - Long-overdue update to cxx_status: C++14 is no longer "upcoming".

Author: rsmith Date: Wed Sep 28 14:22:36 2016 New Revision: 282621 URL: http://llvm.org/viewvc/llvm-project?rev=282621&view=rev Log: Long-overdue update to cxx_status: C++14 is no longer "upcoming". Modified: cfe/trunk/www/cxx_status.html Modified: cfe/trunk/www/cxx_status.html URL: http://

Re: [PATCH] D21852: [Driver][OpenMP] Update actions builder to create bundling action when necessary.

hfinkel accepted this revision. hfinkel added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D21852 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

Re: [PATCH] D21848: [Driver][OpenMP] Add logic for offloading-specific argument translation.

hfinkel added inline comments. Comment at: lib/Driver/ToolChains.cpp:2834 @@ +2833,3 @@ + // If this tool chain is used for an OpenMP offloading device we have to make + // sure we always generate a shared library regardless the commands the user + // passed to the host. This i

Re: [PATCH] D25024: [clang-tidy] Add check for detecting declarations with multiple names

malcolm.parsons added a subscriber: malcolm.parsons. Comment at: clang-tidy/cppcoreguidelines/OneNamePerDeclarationCheck.cpp:30 @@ +29,3 @@ + Finder->addMatcher( + declStmt(declCountIsGreaterThan(1)).bind("multipleNameDeclaration"), + this); Can declCou

r282619 - Re-commit r282556, reverted in r282564, with a fix to CallArgList::addFrom to

Author: rsmith Date: Wed Sep 28 14:09:10 2016 New Revision: 282619 URL: http://llvm.org/viewvc/llvm-project?rev=282619&view=rev Log: Re-commit r282556, reverted in r282564, with a fix to CallArgList::addFrom to function correctly when targeting MS ABIs (this appears to have never mattered prior to

Re: [PATCH] D21847: [Driver][OpenMP] Build jobs for OpenMP offloading actions for targets using gcc tool chains.

hfinkel added inline comments. Comment at: lib/Driver/Tools.cpp:243 @@ +242,3 @@ +// ignore inputs that refer to OpenMP offloading devices - they will be +// embedded recurring to a proper linker script. +if (auto *IA = II.getAction()) recurring -> acc

Re: [PATCH] D25024: [clang-tidy] Add check for detecting declarations with multiple names

Eugene.Zelenko added inline comments. Comment at: clang-tidy/cppcoreguidelines/OneNamePerDeclarationCheck.cpp:26 @@ +25,3 @@ + +} // end anonymous namespace + Namespace is inconsistent with following ones. It I'm not mistaken, **// namespace** is prevailing form

Re: [PATCH] D24848: [clang-tidy] fix false-positive for cppcoreguidelines-pro-type-member-init with in-class initializers

malcolm.parsons added a comment. In https://reviews.llvm.org/D24848#555636, @mgehre wrote: > Are you okay with me committing this as it currently is? Yes. https://reviews.llvm.org/D24848 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

Re: [PATCH] D21845: [Driver][OpenMP] Add specialized action builder for OpenMP offloading actions.

hfinkel added inline comments. Comment at: lib/Driver/Driver.cpp:1836 @@ +1835,3 @@ +ActionBuilderReturnCode +getDeviceDepences(OffloadAction::DeviceDependences &DA, phases::ID CurPhase, + phases::ID FinalPhase, PhasesTy &Phases) override { --

Re: [PATCH] D24864: [libcxxabi] Refactor pthread usage into a separate API

rmaprath added a comment. @EricWF: Gentle ping. https://reviews.llvm.org/D24864 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25036: [CUDA] Disallow exceptions in device code.

jlebar created this revision. jlebar added a reviewer: tra. jlebar added subscribers: jhen, cfe-commits. https://reviews.llvm.org/D25036 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaCUDA.cpp clang/lib/Sema/SemaExprCXX.cpp cla

Re: [PATCH] D21843: [Driver][OpenMP] Create tool chains for OpenMP offloading kind.

hfinkel added inline comments. Comment at: include/clang/Basic/DiagnosticDriverKinds.td:163 @@ +162,3 @@ +def err_drv_expecting_fopenmp_with_fopenmp_targets : Error< + "The option -fopenmp-targets must be used in conjunction with a -fopenmp option compatible with offloading.">;

Re: [PATCH] D21840: [Driver][CUDA][OpenMP] Reimplement tool selection in the driver.

hfinkel added a comment. The naming here is a bit hard to follow, we have 'dependent action', 'dependency action', 'depending action', and I think they're all supposed to mean the same thing. Only 'dependent action' sounds right to me, can we use that universally (i.e. in all comments and names

Re: [PATCH] D24886: Add [[clang::suppress(rule, ...)]] attribute

mgehre added a comment. In the C++ Core Guidelines issue on namespaceing of the [[suppress]], it was state that Microsoft uses [[gsl::suppress]] and it is the intent to update the C++ Core Guidelines to [[gsl::suppress]]. https://reviews.llvm.org/D24886 _

Re: [PATCH] D24472: [Sema] Support lax conversions for compound assignments

bruno added a comment. @rnk, do you have any concerns about this patch? https://reviews.llvm.org/D24472 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24888: [clang-tidy] Use [[clang::suppress]] with cppcoreguidelines-pro-type-reinterpret-cast

mgehre added inline comments. Comment at: clang-tidy/cppcoreguidelines/ProTypeReinterpretCastCheck.cpp:25 @@ -23,2 +24,3 @@ - Finder->addMatcher(cxxReinterpretCastExpr().bind("cast"), this); + std::vector Rules{"type", "type.1", "cppcoreguidelines-pro-type-reinterpret-cast"};

Re: [PATCH] D24916: [analyzer] Extend bug reports with extra notes - CloneChecker

zaks.anna added inline comments. Comment at: test/Analysis/copypaste/suspicious-clones.cpp:61 @@ -60,3 +60,3 @@ b /= a + b; - c -= b * a; // expected-warning{{suspicious code clone detected; did you mean to use 'a'?}} + c -= b * a; // expected-warning{{Suspicious code clone

Re: [PATCH] D24946: [CUDA] Added support for CUDA-8

This revision was automatically updated to reflect the committed changes. Closed by commit rL282610: [CUDA] Added support for CUDA-8 (authored by tra). Changed prior to commit: https://reviews.llvm.org/D24946?vs=72707&id=72863#toc Repository: rL LLVM https://reviews.llvm.org/D24946 Files:

Re: [PATCH] D24944: [CUDA] Added __nvvm_atom_{sys|cta}_* builtins for sm_60 GPUs.

This revision was automatically updated to reflect the committed changes. Closed by commit rL282609: [CUDA] added __nvvm_atom_{sys|cta}_* builtins. (authored by tra). Changed prior to commit: https://reviews.llvm.org/D24944?vs=72584&id=72862#toc Repository: rL LLVM https://reviews.llvm.org/

Re: [PATCH] D24916: [analyzer] Extend bug reports with extra notes - CloneChecker

zaks.anna added inline comments. Comment at: test/Analysis/copypaste/macros.cpp:8 @@ -7,3 +7,3 @@ -int foo(int a) { // expected-warning{{Detected code clone.}} +int foo(int a) { // expected-warning{{Clones of this code were detected}} a = a + 1; - Duplicate c

Re: [PATCH] D24682: [PR30341] Alias must point to a definition

rsmith added inline comments. Comment at: clang/lib/CodeGen/CGCXX.cpp:170 @@ -170,3 +169,3 @@ // If we have a weak, non-discardable alias (weak, weak_odr), like an extern // template instantiation or a dllexported class, avoid forming it on COFF. We can no

r282610 - [CUDA] Added support for CUDA-8

Author: tra Date: Wed Sep 28 12:47:40 2016 New Revision: 282610 URL: http://llvm.org/viewvc/llvm-project?rev=282610&view=rev Log: [CUDA] Added support for CUDA-8 Differential Revision: https://reviews.llvm.org/D24946 Added: cfe/trunk/test/Driver/Inputs/CUDA/usr/local/cuda/nvvm/libdevice/lib

r282609 - [CUDA] added __nvvm_atom_{sys|cta}_* builtins.

Author: tra Date: Wed Sep 28 12:47:35 2016 New Revision: 282609 URL: http://llvm.org/viewvc/llvm-project?rev=282609&view=rev Log: [CUDA] added __nvvm_atom_{sys|cta}_* builtins. These builtins are available on sm_60+ GPU only. Differential Revision: https://reviews.llvm.org/D24944 Modified:

Re: [PATCH] D24848: [clang-tidy] fix false-positive for cppcoreguidelines-pro-type-member-init with in-class initializers

mgehre added a comment. I would like to close that particular bug report, and thus I would like to have the reproducer of that bug as part of the test case. The PositivePartiallyInClassInitialized is also a good test, but I fail to see how it is proves that that particular bug is solved. Are yo

Re: [PATCH] D24916: [analyzer] Extend bug reports with extra notes - CloneChecker

zaks.anna added inline comments. Comment at: test/Analysis/copypaste/suspicious-clones.cpp:61 @@ -60,3 +60,3 @@ b /= a + b; - c -= b * a; // expected-warning{{suspicious code clone detected; did you mean to use 'a'?}} + c -= b * a; // expected-warning{{Suspicious code clone

  1   2   >