[PATCH] D27453: [OpenCL] Enable unroll hint for OpenCL 1.x.

echuraev updated this revision to Diff 80547. echuraev marked an inline comment as done. https://reviews.llvm.org/D27453 Files: lib/Sema/SemaStmtAttr.cpp test/CodeGenOpenCL/unroll-hint.cl test/SemaOpenCL/unroll-hint.cl Index: test/SemaOpenCL/unroll-hint.cl

r288890 - [OpenCL] Fix SPIR version generation.

Author: bader Date: Wed Dec 7 02:38:24 2016 New Revision: 288890 URL: http://llvm.org/viewvc/llvm-project?rev=288890&view=rev Log: [OpenCL] Fix SPIR version generation. Patch by Egor Churaev (echuraev). Reviewers: Anastasia Subscribers: bader, yaxunl, cfe-commits Differential Revision: https:

[PATCH] D27300: [OpenCL] Fix SPIR version generation.

This revision was automatically updated to reflect the committed changes. Closed by commit rL288890: [OpenCL] Fix SPIR version generation. (authored by bader). Changed prior to commit: https://reviews.llvm.org/D27300?vs=80229&id=80548#toc Repository: rL LLVM https://reviews.llvm.org/D27300

r288891 - [OpenCL] Added a LIT test for ensuring address space mangling is done the same both in OpenCL1.2 and OpenCL2.0.

Author: bader Date: Wed Dec 7 02:43:49 2016 New Revision: 288891 URL: http://llvm.org/viewvc/llvm-project?rev=288891&view=rev Log: [OpenCL] Added a LIT test for ensuring address space mangling is done the same both in OpenCL1.2 and OpenCL2.0. Patch by Egor Churaev (echuraev). Reviewers: Anasta

[PATCH] D27403: [OpenCL] Added a LIT test for ensuring address space mangling is done the same both in OpenCL1.2 and OpenCL2.0.

This revision was automatically updated to reflect the committed changes. Closed by commit rL288891: [OpenCL] Added a LIT test for ensuring address space mangling is done the same… (authored by bader). Changed prior to commit: https://reviews.llvm.org/D27403?vs=80401&id=80549#toc Repository:

[PATCH] D27403: [OpenCL] Added a LIT test for ensuring address space mangling is done the same both in OpenCL1.2 and OpenCL2.0.

bader added a comment. @echuraev, please, request commit access as described here: http://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access Repository: rL LLVM https://reviews.llvm.org/D27403 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D27504: Compilation database test: don't try to output to CWD

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Annoying. This test really shouldn't generate binary object files. Can we check in this patch now to unblock stuff and then look into how to do a dry run with -MJ? Usually driver tests use `

[PATCH] D27504: Compilation database test: don't try to output to CWD

sammccall updated this revision to Diff 80553. sammccall added a comment. Hoist cd %T to avoid repeating it. https://reviews.llvm.org/D27504 Files: test/Driver/compilation_database.c Index: test/Driver/compilation_database.c ==

[PATCH] D27504: Compilation database test: don't try to output to CWD

sammccall marked an inline comment as done. sammccall added a comment. Thanks! That makes sense. https://reviews.llvm.org/D27504 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27504: Compilation database test: don't try to output to CWD

This revision was automatically updated to reflect the committed changes. Closed by commit rL288892: Compilation database test: don't try to output to CWD (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D27504?vs=80553&id=80554#toc Repository: rL LLVM https://revi

Re: r288689 - Fix stack-use-after-scope in CheckExplicitlyDefaultedMemberExceptionSpec

On 6 December 2016 at 19:39, Vitaly Buka wrote: > Hi Alex, > > > > On Tue, Dec 6, 2016 at 11:14 AM Alex L wrote: > > Hi Vitaly, > > I noticed that you posted this patch up for review at > https://reviews.llvm.org/D27422, but then committed it instantly without > waiting for approval (and you did

[PATCH] D27478: Make ASTContext::getDeclAlign return the correct alignment for FunctionDecls

arphaman added a comment. Does this happen with blocks as well? https://reviews.llvm.org/D27478 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26922: [ObjC++] Don't enter a C++ declarator context when the current context is an Objective-C declaration

This revision was automatically updated to reflect the committed changes. Closed by commit rL288893: [ObjC++] Don't enter a C++ declarator scope when the current context is (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D26922?vs=79722&id=80556#toc Repository: rL L

r288893 - [ObjC++] Don't enter a C++ declarator scope when the current context is

Author: arphaman Date: Wed Dec 7 04:24:44 2016 New Revision: 288893 URL: http://llvm.org/viewvc/llvm-project?rev=288893&view=rev Log: [ObjC++] Don't enter a C++ declarator scope when the current context is an Objective-C declaration This commit ensures that Sema won't enter a C++ declarator scop

[PATCH] D26546: [PPC] Add vec_insert4b/vec_extract4b to altivec.h

nemanjai requested changes to this revision. nemanjai added a comment. This revision now requires changes to proceed. The finalized wording for vec_insert4b: Let W be the first doubleword element of ARG1, truncated to 32 bits. The result vector is formed by inserting W into ARG2 at the byte posi

r288896 - Implement the -Wstrict-prototypes warning

Author: arphaman Date: Wed Dec 7 04:52:18 2016 New Revision: 288896 URL: http://llvm.org/viewvc/llvm-project?rev=288896&view=rev Log: Implement the -Wstrict-prototypes warning This commit fixes PR20796. It implements the C only -Wstrict-prototypes warning. Clang now emits a warning for function

[PATCH] D16533: Bug 20796 - GCC's -Wstrict-prototypes warning not implemented in Clang

This revision was automatically updated to reflect the committed changes. Closed by commit rL288896: Implement the -Wstrict-prototypes warning (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D16533?vs=80285&id=80560#toc Repository: rL LLVM https://reviews.llvm.org/

[PATCH] D27515: [change-namespace] move template class forward-declarations and don't move fwd-decls in classes.

ioeric created this revision. ioeric added a reviewer: bkramer. ioeric added a subscriber: cfe-commits. Forward declarations in moved namespaces should be moved back to the old namespaces. We should also move template class forward declarations. Also fix a bug that moves forward declarations of n

[PATCH] D23130: [Clang-tidy] Add a check for definitions in the global namespace.

bkramer updated this revision to Diff 80574. bkramer marked 9 inline comments as done. bkramer added a comment. Herald added a subscriber: JDevlieghere. - Moved external linkage check to matcher - added msvcrt entry point check - fixed comment typos. https://reviews.llvm.org/D23130 Files: cla

[PATCH] D23130: [Clang-tidy] Add a check for definitions in the global namespace.

bkramer added inline comments. Comment at: clang-tidy/google/GlobalNamesCheck.cpp:90 +// extern "C" globals need to be in the global namespace. +if (VDecl->isExternC()) + return; alexfh wrote: > Is this already filtered-out by the matcher? Nope. ==

[PATCH] D27123: Add AVR target and toolchain to Clang

saaadhu updated this revision to Diff 80575. saaadhu added a comment. Thanks, setting DoubleFormat and LongDoubleFormat fixed the __DBL_ and __LDBL_ differences. Also, setting SigAtomicType fixed the __SIG_ATOMIC_ differences as well. I've added those defines to the test. Unrelated, but I also r

[PATCH] D23130: [Clang-tidy] Add a check for definitions in the global namespace.

malcolm.parsons added inline comments. Comment at: clang-tidy/google/GoogleTidyModule.cpp:68 +CheckFactories.registerCheck( +"google-global-names"); CheckFactories.registerCheck( bkramer wrote: > aaron.ballman wrote: > > Given that this was shipp

[PATCH] D27515: [change-namespace] move template class forward-declarations and don't move fwd-decls in classes.

This revision was automatically updated to reflect the committed changes. Closed by commit rL288908: [change-namespace] move template class forward-declarations and don't move fwd… (authored by ioeric). Changed prior to commit: https://reviews.llvm.org/D27515?vs=80571&id=80586#toc Repository:

[clang-tools-extra] r288908 - [change-namespace] move template class forward-declarations and don't move fwd-decls in classes.

Author: ioeric Date: Wed Dec 7 08:20:52 2016 New Revision: 288908 URL: http://llvm.org/viewvc/llvm-project?rev=288908&view=rev Log: [change-namespace] move template class forward-declarations and don't move fwd-decls in classes. Summary: Forward declarations in moved namespaces should be moved

[PATCH] D27520: [clang-tidy] Add check for redundant function pointer dereferences

malcolm.parsons created this revision. malcolm.parsons added reviewers: alexfh, aaron.ballman, hokein. malcolm.parsons added a subscriber: cfe-commits. Herald added subscribers: JDevlieghere, mgorny. See https://youtu.be/6eX9gPithBo https://reviews.llvm.org/D27520 Files: clang-tidy/readabilit

[PATCH] D15994: Allow for unfinished #if blocks in preambles.

erikjv marked 7 inline comments as done. erikjv added inline comments. Comment at: lib/Serialization/ASTReader.cpp:2816 +} +PP.setReplayablePreambleConditionalStack(ConditionalStack); + } rsmith wrote: > Why can't we set the conditional stack

[PATCH] D15994: Allow for unfinished #if blocks in preambles.

erikjv updated this revision to Diff 80589. https://reviews.llvm.org/D15994 Files: include/clang/Lex/Preprocessor.h include/clang/Lex/PreprocessorLexer.h include/clang/Lex/PreprocessorOptions.h include/clang/Serialization/ASTBitCodes.h lib/Frontend/ASTUnit.cpp lib/Lex/Lexer.cpp lib/

[PATCH] D27523: [change-namespace] don't fix using shadow decls in classes.

ioeric created this revision. ioeric added a reviewer: bkramer. ioeric added a subscriber: cfe-commits. Using shadow declarations in classes always refers to base class, which does not need to be fixed/qualified since it can be inferred from inheritance. https://reviews.llvm.org/D27523 Files:

[PATCH] D27304: [PATCH] [Sema][X86] Don't allow floating-point return types when SSE is disabled

thegameg added a comment. LLVM patch here: https://reviews.llvm.org/D27522 https://reviews.llvm.org/D27304 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27123: Add AVR target and toolchain to Clang

jroelofs added a comment. In https://reviews.llvm.org/D27123#615738, @saaadhu wrote: > Thanks, setting DoubleFormat and LongDoubleFormat fixed the __DBL_ and > __LDBL_ differences. Also, setting SigAtomicType fixed the __SIG_ATOMIC_ > differences as well. I've added those defines to the test. U

[PATCH] D26196: Add support for non-zero null pointer for C and OpenCL

yaxunl marked 4 inline comments as done. yaxunl added inline comments. Comment at: lib/CodeGen/CGExprScalar.cpp:1532 + return llvm::ConstantInt::get(ConvertType(DestTy), + CGF.getContext().getTargetNullPtrValue(E->getType())); assert(!DestTy->isBooleanType() &&

r288914 - [analyzer] pr31226: Disable CastSizeChecker in C++ because it's not quite ready.

Author: dergachev Date: Wed Dec 7 10:12:26 2016 New Revision: 288914 URL: http://llvm.org/viewvc/llvm-project?rev=288914&view=rev Log: [analyzer] pr31226: Disable CastSizeChecker in C++ because it's not quite ready. Avoids a crash and a related false positive. Investigation by Daniel Krupp! Mo

[PATCH] D26503: [Parser][ObjC] Improve diagnostics and recovery when C++ keywords are used as identifiers in Objective-C++

manmanren accepted this revision. manmanren added a comment. This revision is now accepted and ready to land. LGTM Manman Repository: rL LLVM https://reviews.llvm.org/D26503 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.ll

[PATCH] D26196: Add support for non-zero null pointer for C and OpenCL

yaxunl updated the summary for this revision. yaxunl updated this revision to Diff 80600. yaxunl marked an inline comment as done. yaxunl added a comment. Revised by John's comments. Fixed typos. Changed parameter of performAddrSpaceCast. Fixed constant folding of ptrtoint with side effect and ad

[PATCH] D27409: [analyzer] RetainCountChecker: The callback in dispatch_data_create() doesn't free the return symbol.

NoQ retitled this revision from "[analyzer] RetainCountChecker: Improve support for libdispatch APIs." to "[analyzer] RetainCountChecker: The callback in dispatch_data_create() doesn't free the return symbol.". NoQ updated the summary for this revision. NoQ updated this revision to Diff 80606. No

[PATCH] D27438: clang-format-vsix: add a date stamp to the VSIX version number to ensure upgradability

hans added a comment. In https://reviews.llvm.org/D27438#615396, @amaiorano wrote: > > Yes, I think this is still a worthwhile change. Let's add the hour and > > minute and get it landed. > > Alright, added hour and minute. How do we land this change? Is this something > I can now do myself? Or

r288917 - [analyzer] Remove an unused enum value in RetainCountChecker.

Author: dergachev Date: Wed Dec 7 10:51:54 2016 New Revision: 288917 URL: http://llvm.org/viewvc/llvm-project?rev=288917&view=rev Log: [analyzer] Remove an unused enum value in RetainCountChecker. No functional change intended. Differential Revision: https://reviews.llvm.org/D27408 Modified:

[PATCH] D27408: [analyzer] RetainCountChecker: remove unused enum value; NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rL288917: [analyzer] Remove an unused enum value in RetainCountChecker. (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D27408?vs=80431&id=80608#toc Repository: rL LLVM http

[PATCH] D27523: [change-namespace] don't fix using shadow decls in classes.

bkramer accepted this revision. bkramer added inline comments. This revision is now accepted and ready to land. Comment at: change-namespace/ChangeNamespace.cpp:331 + // Using shadow declarations in classes always refers to base class, which + // does not need to be qualified s

[PATCH] D27523: [change-namespace] don't fix using shadow decls in classes.

ioeric updated this revision to Diff 80613. ioeric added a comment. - address review comment. https://reviews.llvm.org/D27523 Files: change-namespace/ChangeNamespace.cpp unittests/change-namespace/ChangeNamespaceTests.cpp Index: unittests/change-namespace/ChangeNamespaceTests.cpp =

[clang-tools-extra] r288919 - [change-namespace] don't fix using shadow decls in classes.

Author: ioeric Date: Wed Dec 7 11:04:07 2016 New Revision: 288919 URL: http://llvm.org/viewvc/llvm-project?rev=288919&view=rev Log: [change-namespace] don't fix using shadow decls in classes. Summary: Using shadow declarations in classes always refers to base class, which does not need to be fix

[PATCH] D27523: [change-namespace] don't fix using shadow decls in classes.

This revision was automatically updated to reflect the committed changes. Closed by commit rL288919: [change-namespace] don't fix using shadow decls in classes. (authored by ioeric). Changed prior to commit: https://reviews.llvm.org/D27523?vs=80613&id=80615#toc Repository: rL LLVM https://r

[PATCH] D27166: [clang-tidy] Enhance modernize-use-auto to templated function casts

malcolm.parsons added a comment. ping. https://reviews.llvm.org/D27166 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27053: [CodeCompletion] Provide Objective-C class property completion results

manmanren accepted this revision. manmanren added a comment. This revision is now accepted and ready to land. LGTM . Manman Comment at: lib/Sema/SemaCodeComplete.cpp:3763 +if (!M->getSelector().isUnarySelector() || +M->getReturnType()->isVoidType() || M->is

r288922 - [analyzer] Fix typo in nullability checker diagnostic

Author: dcoughlin Date: Wed Dec 7 11:36:27 2016 New Revision: 288922 URL: http://llvm.org/viewvc/llvm-project?rev=288922&view=rev Log: [analyzer] Fix typo in nullability checker diagnostic 'infered' --> 'inferred' Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp Modif

[PATCH] D26742: [RecursiveASTVisitor] Fix post-order traversal of UnaryOperator

This revision was automatically updated to reflect the committed changes. Closed by commit rL288923: [RecursiveASTVisitor] Fix post-order traversal of UnaryOperator (authored by malcolm.parsons). Changed prior to commit: https://reviews.llvm.org/D26742?vs=78165&id=80621#toc Repository: rL LL

r288923 - [RecursiveASTVisitor] Fix post-order traversal of UnaryOperator

Author: malcolm.parsons Date: Wed Dec 7 11:39:04 2016 New Revision: 288923 URL: http://llvm.org/viewvc/llvm-project?rev=288923&view=rev Log: [RecursiveASTVisitor] Fix post-order traversal of UnaryOperator Reviewers: aaron.ballman, klimek, doug.gregor, teemperor, rsmith Subscribers: cfe-commits

Re: r288923 - [RecursiveASTVisitor] Fix post-order traversal of UnaryOperator

On 7 Dec 2016 9:49 am, "Malcolm Parsons via cfe-commits" < cfe-commits@lists.llvm.org> wrote: Author: malcolm.parsons Date: Wed Dec 7 11:39:04 2016 New Revision: 288923 URL: http://llvm.org/viewvc/llvm-project?rev=288923&view=rev Log: [RecursiveASTVisitor] Fix post-order traversal of UnaryOperat

[PATCH] D26196: Add support for non-zero null pointer for C and OpenCL

rjmccall added inline comments. Comment at: lib/CodeGen/CGExprScalar.cpp:1532 + return llvm::ConstantInt::get(ConvertType(DestTy), + CGF.getContext().getTargetNullPtrValue(E->getType())); assert(!DestTy->isBooleanType() && "bool should use PointerToBool");

[PATCH] D27520: [clang-tidy] Add check for redundant function pointer dereferences

Eugene.Zelenko added a comment. Please mention this check in docs/ReleaseNotes.rst (in alphabetical order). Comment at: docs/clang-tidy/checks/readability-redundant-function-ptr-dereference.rst:7 +Finds redundant dereferences of a function pointer. +See https://youtu.be/6eX9gP

[PATCH] D27166: [clang-tidy] Enhance modernize-use-auto to templated function casts

malcolm.parsons updated this revision to Diff 80623. malcolm.parsons added a comment. Remove hasReplacementType matcher. https://reviews.llvm.org/D27166 Files: clang-tidy/modernize/UseAutoCheck.cpp docs/ReleaseNotes.rst docs/clang-tidy/checks/modernize-use-auto.rst test/clang-tidy/moder

[PATCH] D25809: [CUDA] Improved target attribute-based overloading.

tra added a comment. In https://reviews.llvm.org/D25809#615485, @jlebar wrote: > If you would like me to have another look at this, is it possible to make an > interdiff of your changes between this and the last version I reviewed? > phab's interdiff is useless because it straddles a rebase.

Re: r288923 - [RecursiveASTVisitor] Fix post-order traversal of UnaryOperator

On 7 December 2016 at 17:56, Richard Smith wrote: > On 7 Dec 2016 9:49 am, "Malcolm Parsons via cfe-commits" > wrote: > > Author: malcolm.parsons > Date: Wed Dec 7 11:39:04 2016 > New Revision: 288923 > > URL: http://llvm.org/viewvc/llvm-project?rev=288923&view=rev > Log: > [RecursiveASTVisitor]

[PATCH] D25809: [CUDA] Improved target attribute-based overloading.

jlebar added a comment. > I've reverted to 75652 Did you forget to arc diff? Anyway if it's just that if statement, lgtm. https://reviews.llvm.org/D25809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

[PATCH] D27513: Refactor clang's ParseHelper into Support (clang part)

hans added a subscriber: cfe-commits. hans added a comment. I've commented on the llvm side. Adding cfe-commits as well since it affects clang. Repository: rL LLVM https://reviews.llvm.org/D27513 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D27501: clang-format-vsix: add command to format document

hans added inline comments. Comment at: tools/clang-format-vs/ClangFormat/ClangFormat.vsct:76 + + Clang Format Document + I think File would be better than Document when referring to source code. But it seems a little annoying to need tw

r288962 - [CUDA] Improve target attribute checking for function templates.

Author: tra Date: Wed Dec 7 13:27:16 2016 New Revision: 288962 URL: http://llvm.org/viewvc/llvm-project?rev=288962&view=rev Log: [CUDA] Improve target attribute checking for function templates. * __host__ __device__ functions are no longer considered to be redeclarations of __host__ or __devic

[PATCH] D27501: clang-format-vsix: add command to format document

amaiorano added inline comments. Comment at: tools/clang-format-vs/ClangFormat/ClangFormat.vsct:76 + + Clang Format Document + hans wrote: > I think File would be better than Document when referring to source code. > > But it seems a lit

[PATCH] D25809: [CUDA] Improved target attribute-based overloading.

This revision was automatically updated to reflect the committed changes. Closed by commit rL288962: [CUDA] Improve target attribute checking for function templates. (authored by tra). Changed prior to commit: https://reviews.llvm.org/D25809?vs=80522&id=80635#toc Repository: rL LLVM https:/

Re: r288923 - [RecursiveASTVisitor] Fix post-order traversal of UnaryOperator

On 7 December 2016 at 10:11, Malcolm Parsons wrote: > On 7 December 2016 at 17:56, Richard Smith wrote: > > On 7 Dec 2016 9:49 am, "Malcolm Parsons via cfe-commits" > > wrote: > > > > Author: malcolm.parsons > > Date: Wed Dec 7 11:39:04 2016 > > New Revision: 288923 > > > > URL: http://llvm.or

[PATCH] D26846: __uuidof() and declspec(uuid("...")) should be allowed on enumeration types

majnemer added a comment. This LGTM but Aaron should give the go ahead. Repository: rL LLVM https://reviews.llvm.org/D26846 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27529: Correct Vectorcall Register passing and HVA Behavior

majnemer added inline comments. Comment at: lib/CodeGen/TargetInfo.cpp:1688 +for (auto &I : FI.arguments()) { + if(Count < 6) +I.info = reclassifyHvaArgType(I.type, State, I.info); Formatting. Comment at: lib/CodeGen/TargetInfo

[clang-tools-extra] r288969 - [change-namespace] always add a '::' prefix when a symbol reference needs to be fully-qualified.

Author: ioeric Date: Wed Dec 7 14:08:02 2016 New Revision: 288969 URL: http://llvm.org/viewvc/llvm-project?rev=288969&view=rev Log: [change-namespace] always add a '::' prefix when a symbol reference needs to be fully-qualified. Modified: clang-tools-extra/trunk/change-namespace/ChangeNames

[PATCH] D27529: Correct Vectorcall Register passing and HVA Behavior

erichkeane marked an inline comment as done. erichkeane added inline comments. Comment at: lib/CodeGen/TargetInfo.cpp:1688 +for (auto &I : FI.arguments()) { + if(Count < 6) +I.info = reclassifyHvaArgType(I.type, State, I.info); majnemer wrote: >

[PATCH] D27529: Correct Vectorcall Register passing and HVA Behavior

majnemer added inline comments. Comment at: lib/CodeGen/TargetInfo.cpp:1688 +for (auto &I : FI.arguments()) { + if(Count < 6) +I.info = reclassifyHvaArgType(I.type, State, I.info); erichkeane wrote: > majnemer wrote: > > Formatting. > I don't see

r288976 - [RecursiveASTVisitor] Improve post-order traversal unit test

Author: malcolm.parsons Date: Wed Dec 7 14:38:20 2016 New Revision: 288976 URL: http://llvm.org/viewvc/llvm-project?rev=288976&view=rev Log: [RecursiveASTVisitor] Improve post-order traversal unit test Modified: cfe/trunk/unittests/AST/PostOrderASTVisitor.cpp Modified: cfe/trunk/unittests/A

[PATCH] D27529: Correct Vectorcall Register passing and HVA Behavior

erichkeane added inline comments. Comment at: lib/CodeGen/TargetInfo.cpp:1688 +for (auto &I : FI.arguments()) { + if(Count < 6) +I.info = reclassifyHvaArgType(I.type, State, I.info); majnemer wrote: > erichkeane wrote: > > majnemer wrote: > > > F

[PATCH] D27529: Correct Vectorcall Register passing and HVA Behavior

majnemer added inline comments. Comment at: lib/CodeGen/TargetInfo.cpp:3871 +for (auto &I : FI.arguments()) { + if (Count < 6) +I.info = classify(I.type, FreeSSERegs, false, IsVectorCall, IsRegCall); erichkeane wrote: > majnemer wrote: > > majnem

[PATCH] D27529: Correct Vectorcall Register passing and HVA Behavior

rnk added inline comments. Comment at: lib/CodeGen/TargetInfo.cpp:3871 +for (auto &I : FI.arguments()) { + if (Count < 6) +I.info = classify(I.type, FreeSSERegs, false, IsVectorCall, IsRegCall); majnemer wrote: > erichkeane wrote: > > majnemer wr

[PATCH] D27529: Correct Vectorcall Register passing and HVA Behavior

erichkeane updated this revision to Diff 80641. erichkeane added a comment. Fixing issues brought up by David. https://reviews.llvm.org/D27529 Files: include/clang/CodeGen/CGFunctionInfo.h lib/CodeGen/TargetInfo.cpp test/CodeGen/vectorcall.c test/CodeGenCXX/homogeneous-aggregates.cpp I

[PATCH] D27529: Correct Vectorcall Register passing and HVA Behavior

erichkeane marked 9 inline comments as done. erichkeane added inline comments. Comment at: lib/CodeGen/TargetInfo.cpp:3871 +for (auto &I : FI.arguments()) { + if (Count < 6) +I.info = classify(I.type, FreeSSERegs, false, IsVectorCall, IsRegCall);

[PATCH] D27520: [clang-tidy] Add check for redundant function pointer dereferences

malcolm.parsons updated this revision to Diff 80642. malcolm.parsons added a comment. Add to release notes. Remove youtube link. https://reviews.llvm.org/D27520 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/ReadabilityTidyModule.cpp clang-tidy/readability/RedundantFu

[PATCH] D27039: [CodeCompletion] Autocomplete NS_DESIGNATED_INITIALIZER in initializers with arguments

manmanren accepted this revision. manmanren added a comment. This revision is now accepted and ready to land. LGTM Manman Repository: rL LLVM https://reviews.llvm.org/D27039 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.ll

[PATCH] D27535: [analyzer] Add ObjCPropertyChecker - check for autosynthesized copy-properties of mutable types.

NoQ created this revision. NoQ added reviewers: zaks.anna, dcoughlin. NoQ added a subscriber: cfe-commits. Herald added a subscriber: mgorny. When an ObjC property is declared as `(copy)`, and the type of the property is mutable (eg. `NSMutableSomething`), the autosynthesized code for the setter,

[PATCH] D27501: clang-format-vsix: add command to format document

hans added inline comments. Comment at: tools/clang-format-vs/ClangFormat/ClangFormat.vsct:76 + + Clang Format Document + amaiorano wrote: > hans wrote: > > I think File would be better than Document when referring to source code. > > >

[PATCH] D27279: Store decls in prototypes on the declarator instead of in the AST

rnk updated this revision to Diff 80650. rnk added a comment. - Remove an assert and test that edge case https://reviews.llvm.org/D27279 Files: include/clang/AST/Decl.h include/clang/Sema/DeclSpec.h include/clang/Sema/Sema.h lib/AST/ASTDumper.cpp lib/AST/Decl.cpp lib/Parse/ParseDecl

[PATCH] D27434: [libc++abi] Disable failing test on Darwin

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. If this caused by a bug it should be marked `XFAIL` and have a comment explaining why it fails and links to the relevant PR's. Feel free to commit after making those changes. https://reviews

[PATCH] D27538: [libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible loss of data", part 1/7.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. [libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible loss of data", part 1/7. Given `std::basic_streambuf::int_type __c`, `std::basic_string str_`, an

[PATCH] D27539: [libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible loss of data", part 2/7.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. [libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible loss of data", part 2/7. These tests for some guy's transparent operator functors were needlessly

[PATCH] D27540: [libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible loss of data", part 3/7.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. [libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible loss of data", part 3/7. Add static_cast when constructing pair from (Something, int). https://

[PATCH] D27541: [libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible loss of data", part 4/7.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. [libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible loss of data", part 4/7. Change char to long and remove some char casts. This preserves test cover

[PATCH] D27542: [libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible loss of data", part 5/7.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. [libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible loss of data", part 5/7. Instead of storing double in double and then truncating to int, store int

[PATCH] D27543: [libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible loss of data", part 6/7.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. [libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible loss of data", part 6/7. test/std/algorithms/alg.modifying.operations/alg.random.shuffle/random_sh

[PATCH] D27544: [libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible loss of data", part 7/7.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. [libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible loss of data", part 7/7. test/std/input.output/iostream.format/input.streams/istream.unformatted/g

[PATCH] D27545: Don't assert when redefining a built-in macro in a PCH, PR29119

thakis created this revision. thakis added a reviewer: rnk. thakis added subscribers: cfe-commits, rsmith. PCH files store the macro history for a given macro, and the whole history list for one identifier is given to the Preprocessor at once via Preprocessor::setLoadedMacroDirective(). This co

[PATCH] D25417: [libcxxabi] Fix alignment of allocated exceptions in 32 bit builds

EricWF updated this revision to Diff 80658. EricWF added a comment. - Use `_aligned_malloc` on windows. - Ensure `posix_memalign` isn't called with a size of `0`. I'm 99% sure that's currently impossible but we might as well handle it. I'll commit after testing on OS X. https://reviews.llvm.or

[PATCH] D27546: [ASTReader] Sort RawComments before merging

bruno created this revision. bruno added reviewers: manmanren, akyrtzi, rsmith. bruno added a subscriber: cfe-commits. `RawComments` are sorted by comparing underlying `SourceLocation`'s. This is done by comparing `FileID` and `Offset`; when the `FileID` is the same it means the locations are wit

[PATCH] D27279: Store decls in prototypes on the declarator instead of in the AST

rsmith added inline comments. Comment at: include/clang/Sema/DeclSpec.h:1240 +/// in the prototype. These are generally tag types or enumerators. +unsigned NumDeclsInPrototype : 8; + It seems plausible that generated code could have more than 256 such de

[PATCH] D27486: Correct class-template deprecation behavior

majnemer added inline comments. Comment at: lib/Sema/SemaTemplate.cpp:2355 Converted, nullptr); + if (auto *attr = ClassTemplate->getTemplatedDecl() + ->getAttr()) Please capital

[PATCH] D27486: Correct class-template deprecation behavior

erichkeane added a comment. Thanks David! To all - I'm actually doing my best to rewrite this based on Richard's suggestions, so look for a 'in progress' update to this review as soon as I get something that is reasonably presentable. https://reviews.llvm.org/D27486

[PATCH] D27549: [DebugInfo] Add support for __fp16, float, and double constants.

probinson added subscribers: cfe-commits, probinson. probinson added a comment. Hi David! As this is a Clang patch, you should subscribe cfe-commits rather than llvm-commits. I've done that for you. See also inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:3765 +I

r288994 - [Driver] Add tests for default stack protector values on Darwin

Author: bruno Date: Wed Dec 7 17:20:30 2016 New Revision: 288994 URL: http://llvm.org/viewvc/llvm-project?rev=288994&view=rev Log: [Driver] Add tests for default stack protector values on Darwin Modified: cfe/trunk/test/Driver/stack-protector.c Modified: cfe/trunk/test/Driver/stack-protecto

r288997 - Add more tests for MSVC version handling.

Author: dlj Date: Wed Dec 7 17:39:44 2016 New Revision: 288997 URL: http://llvm.org/viewvc/llvm-project?rev=288997&view=rev Log: Add more tests for MSVC version handling. Summary: This change adds more test cases for the default MSVC compatibility version: 1. When -fms-extensions is supplied, b

r288998 - Refactor how the MSVC toolchain searches for a compatibility version.

Author: dlj Date: Wed Dec 7 17:41:58 2016 New Revision: 288998 URL: http://llvm.org/viewvc/llvm-project?rev=288998&view=rev Log: Refactor how the MSVC toolchain searches for a compatibility version. Summary: The MSVC toolchain and Clang driver combination currently uses a fairly complex sequence

[PATCH] D27279: Store decls in prototypes on the declarator instead of in the AST

rnk marked an inline comment as done. rnk added inline comments. Comment at: include/clang/Sema/DeclSpec.h:1240 +/// in the prototype. These are generally tag types or enumerators. +unsigned NumDeclsInPrototype : 8; + rsmith wrote: > It seems plausible th

[PATCH] D27279: Store decls in prototypes on the declarator instead of in the AST

rnk updated this revision to Diff 80682. rnk marked an inline comment as done. rnk added a comment. - Allow more decls in prototypes, dump fd decls https://reviews.llvm.org/D27279 Files: include/clang/AST/Decl.h include/clang/Sema/DeclSpec.h include/clang/Sema/Sema.h lib/AST/ASTDumper.c

[PATCH] D27549: [DebugInfo] Add support for __fp16, float, and double constants.

dgross updated this revision to Diff 80683. dgross added a comment. Incorporate code review feedback. - Reformat source. - Make test pattern more general. https://reviews.llvm.org/D27549 Files: lib/CodeGen/CGDebugInfo.cpp test/CodeGen/debug-info-static-const-fp.c Index: test/CodeGen/debu

[PATCH] D27549: [DebugInfo] Add support for __fp16, float, and double constants.

dgross added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:3765 +InitExpr = + DBuilder.createConstantValueExpression(Init.getFloat().bitcastToAPInt().getZExtValue()); GV.reset(DBuilder.createGlobalVariable( probinson wrote: > This line e

[PATCH] D25845: [CUDA] Ignore implicit target attributes during function template instantiation.

tra updated this revision to Diff 80677. tra marked 4 inline comments as done. tra added a comment. Addressed Justin's comments. https://reviews.llvm.org/D25845 Files: include/clang/Sema/Sema.h lib/Sema/SemaCUDA.cpp lib/Sema/SemaDecl.cpp lib/Sema/SemaTemplate.cpp test/SemaCUDA/functio

[PATCH] D25845: [CUDA] Ignore implicit target attributes during function template instantiation.

tra added inline comments. Comment at: lib/Sema/SemaCUDA.cpp:99 + if (!D->hasAttrs()) +return false; + for (Attr *Attribute : D->getAttrs()) { jlebar wrote: > Is this early return necessary? Yes. Otherwise D->getAttrs() will trigger assert(hasAttrs) if we d

  1   2   >