[libcxx] r299290 - string: Remove always_inline from basic_string::__init

2017-03-31 Thread Duncan P. N. Exon Smith via cfe-commits
Author: dexonsmith Date: Fri Mar 31 22:20:48 2017 New Revision: 299290 URL: http://llvm.org/viewvc/llvm-project?rev=299290=rev Log: string: Remove always_inline from basic_string::__init This is effectively a partial revert of r278356, which started inlining basic_string::__init. Even if we

[PATCH] D31564: string: Remove always_inline from basic_string::__init

2017-03-31 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith closed this revision. dexonsmith added a comment. Committed in r299290. https://reviews.llvm.org/D31564 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31562: [coroutines] Fix building of new/delete expressions when get_return_object_on_allocation_failure() is present.

2017-03-31 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF updated this revision to Diff 93739. EricWF added a comment. - Remove incorrectly added changes. Note that this patch is built on top of https://reviews.llvm.org/D31487 and not trunk. https://reviews.llvm.org/D31562 Files: include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D31564: string: Remove always_inline from basic_string::__init

2017-03-31 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith created this revision. Herald added subscribers: rengolin, aemerson. This is effectively a partial revert of r278356, which started inlining basic_string::__init. Even if we want to help the compiler along with an inlinehint, we shouldn't hamstring it by forcing it to inline all the

[PATCH] D31562: [coroutines] Fix building of new/delete expressions when get_return_object_on_allocation_failure() is present.

2017-03-31 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF updated this revision to Diff 93737. EricWF added a comment. - general cleanup. https://reviews.llvm.org/D31562 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaCoroutine.cpp test/SemaCXX/coroutines.cpp Index: test/SemaCXX/coroutines.cpp

[PATCH] D31561: cmath: Skip Libc for integral types in isinf, etc.

2017-03-31 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith created this revision. For std::isinf, the standard requires effectively calling isinf as double from Libc for integral types. But integral types are never infinite; we don't need to call Libc to return false. Also short-circuit other functions where Libc won't have

r299281 - [coroutines] Add cleanup for compiler injected objects/allocations in coroutine body

2017-03-31 Thread Gor Nishanov via cfe-commits
Author: gornishanov Date: Fri Mar 31 19:22:47 2017 New Revision: 299281 URL: http://llvm.org/viewvc/llvm-project?rev=299281=rev Log: [coroutines] Add cleanup for compiler injected objects/allocations in coroutine body Summary: * Use pushCleanup to emit freeing coroutine memory on normal and EH

[PATCH] D31460: [coroutines] Add cleanup for compiler injected objects/allocations in coroutine body

2017-03-31 Thread Gor Nishanov via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL299281: [coroutines] Add cleanup for compiler injected objects/allocations in coroutine… (authored by GorNishanov). Changed prior to commit: https://reviews.llvm.org/D31460?vs=93370=93728#toc

[PATCH] D30435: [clang-import-test] Lookup inside entities

2017-03-31 Thread Sean Callanan via Phabricator via cfe-commits
spyffe updated this revision to Diff 93721. spyffe added a comment. • Removed namespace qualification of `cast` across the board. • Standardized on `SmallVector` • Factored out the filtering of forward declarations • Fixed a loop as requested. • Made a Origin<> wrapper for arbitrary AST objects

[PATCH] D31534: [ThinLTO] Handle -emit-llvm* in ThinLTO backends

2017-03-31 Thread Teresa Johnson via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL299274: [ThinLTO] Handle -emit-llvm* in ThinLTO backends (authored by tejohnson). Changed prior to commit: https://reviews.llvm.org/D31534?vs=93695=93722#toc Repository: rL LLVM

r299274 - [ThinLTO] Handle -emit-llvm* in ThinLTO backends

2017-03-31 Thread Teresa Johnson via cfe-commits
Author: tejohnson Date: Fri Mar 31 17:35:47 2017 New Revision: 299274 URL: http://llvm.org/viewvc/llvm-project?rev=299274=rev Log: [ThinLTO] Handle -emit-llvm* in ThinLTO backends Summary: Use PreCodeGenModuleHook to invoke the correct writer when emitting LLVM IR, returning false to skip

Re: [libcxx] r299236 - Use strong enums independently of -fobjc-arc

2017-03-31 Thread Eric Fiselier via cfe-commits
On Fri, Mar 31, 2017 at 4:17 PM, Duncan P. N. Exon Smith < dexonsm...@apple.com> wrote: > Thanks. Unfortunately that's one of the ways we figured it out :(. > > The status quo, before this commit, was an ABI difference between > Objective-C++ (-fobjc-arc) and C++/Objective-C++ (-fno-objc-arc),

r299269 - Add/update PIE defaults for OpenBSD.

2017-03-31 Thread Brad Smith via cfe-commits
Author: brad Date: Fri Mar 31 17:13:17 2017 New Revision: 299269 URL: http://llvm.org/viewvc/llvm-project?rev=299269=rev Log: Add/update PIE defaults for OpenBSD. Modified: cfe/trunk/lib/Driver/ToolChains/CommonArgs.cpp cfe/trunk/test/Driver/pic.c Modified:

[PATCH] D31513: [Sema] Add __is_aggregate type-trait and implement LWG 2015

2017-03-31 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF updated this revision to Diff 93715. EricWF added a comment. - Correctly report array types as aggregates. (Woops!) - Also report vector types as aggregates. This behavior mirrors GCC. - report _Complex int and _Complex float as aggregates as well. Currently GCC does not have this

Re: [libcxx] r299236 - Use strong enums independently of -fobjc-arc

2017-03-31 Thread Duncan P. N. Exon Smith via cfe-commits
Thanks. Unfortunately that's one of the ways we figured it out :(. The status quo, before this commit, was an ABI difference between Objective-C++ (-fobjc-arc) and C++/Objective-C++ (-fno-objc-arc), which is... really bad. But rare enough I guess it took a couple of years to find. I

[PATCH] D31406: [clang-tidy] Reuse FileID in getLocation

2017-03-31 Thread Chih-Hung Hsieh via Phabricator via cfe-commits
chh reopened this revision. chh added a comment. This revision is now accepted and ready to land. This was reverted due to one failed test case clang-tidy/llvm-include-order.cpp on Windows: Assertion failed: EndColNo <= map.getSourceLine().size() && "Invalid range!", file

[PATCH] D31513: [Sema] Add __is_aggregate type-trait and implement LWG 2015

2017-03-31 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF updated this revision to Diff 93709. EricWF added a comment. - Update the doc to reflect that GCC has implemented this trait (and to assume MS will as well). - Rewrite the tests using static_assert over god-awful old style array asserts. https://reviews.llvm.org/D31513 Files:

Re: [libcxx] r299236 - Use strong enums independently of -fobjc-arc

2017-03-31 Thread Eric Fiselier via cfe-commits
This will be ABI breaking for Objective-C++ users. I'm not objecting to fixing the bogus configuration, but I just wanted to point it out. /Eric On Fri, Mar 31, 2017 at 11:39 AM, Duncan P. N. Exon Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: dexonsmith > Date: Fri Mar 31

[PATCH] D29654: [OpenMP] Integrate OpenMP target region cubin into host binary

2017-03-31 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added inline comments. Comment at: lib/Driver/ToolChains/Cuda.cpp:324 + "CUDA toolchain not expected for an OpenMP host device."); + if (JA.isDeviceOffloading(Action::OFK_OpenMP)) { +if (Output.isFilename()) { This entire if block constructs a

[PATCH] D31534: [ThinLTO] Handle -emit-llvm* in ThinLTO backends

2017-03-31 Thread Peter Collingbourne via Phabricator via cfe-commits
pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D31534 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D31534: [ThinLTO] Handle -emit-llvm* in ThinLTO backends

2017-03-31 Thread Teresa Johnson via Phabricator via cfe-commits
tejohnson updated this revision to Diff 93695. tejohnson added a comment. Implement review suggestions https://reviews.llvm.org/D31534 Files: lib/CodeGen/BackendUtil.cpp test/CodeGen/thinlto-emit-llvm.c Index: test/CodeGen/thinlto-emit-llvm.c

[PATCH] D30691: [analyzer] Support for naive cross translational unit analysis

2017-03-31 Thread Zoltán Gera via Phabricator via cfe-commits
gerazo added inline comments. Comment at: tools/xtu-analysis/xtu-analyze.py:29 + +threading_factor = int(multiprocessing.cpu_count() * 1.5) +analyser_output_formats = ['plist-multi-file', 'plist', 'plist-html', danielmarjamaki wrote: > does this mean that if

[PATCH] D31534: [ThinLTO] Handle -emit-llvm* in ThinLTO backends

2017-03-31 Thread Peter Collingbourne via Phabricator via cfe-commits
pcc added a comment. Why not call `Module::print()` or `WriteBitcodeToFile` directly instead of creating a pass manager? https://reviews.llvm.org/D31534 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D31404: [OpenCL] Allow alloca return non-zero private pointer

2017-03-31 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl marked 3 inline comments as done. yaxunl added inline comments. Comment at: lib/AST/ASTContext.cpp:9553 + // alloca. + if (AS == LangAS::Default && LangOpts.OpenCL) +return getTargetInfo().getDataLayout().getAllocaAddrSpace(); Anastasia wrote: >

[PATCH] D28952: [analyzer] Add new Z3 constraint manager backend

2017-03-31 Thread Dan Liew via Phabricator via cfe-commits
delcypher added inline comments. Comment at: cmake/modules/FindZ3.cmake:5 +PKG_CHECK_MODULES(PC_Z3 QUIET libz3) +set(Z3_DEFINITIONS ${PC_LIBZ3_CFLAGS_OTHER}) + ddcc wrote: > delcypher wrote: > > @ddcc This CMake variable is set but never used. Also based on the

[PATCH] D28952: [analyzer] Add new Z3 constraint manager backend

2017-03-31 Thread Dan Liew via Phabricator via cfe-commits
delcypher added inline comments. Comment at: lib/StaticAnalyzer/Core/Z3ConstraintManager.cpp:674 + // are the same size. + Z3_get_numeral_uint64(Z3Context::ZC, AST, +reinterpret_cast<__uint64 *>()); ddcc wrote: > The only

[PATCH] D31541: [analyzer] MisusedMovedObjectChecker: Add a printState() method.

2017-03-31 Thread Peter Szecsi via Phabricator via cfe-commits
szepet accepted this revision. szepet added a comment. This revision is now accepted and ready to land. LGTM, thank you (again)! https://reviews.llvm.org/D31541 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D31544: Add AllowReparse parameter to ASTUnit::Reparse

2017-03-31 Thread Igor Bronshteyn via Phabricator via cfe-commits
ibronstein created this revision. ibronstein added a project: clang-c. An idea behind the commit is to have an option (AllowReparse = false) in ASTUnit::Reparse() which will disallow rebuilding the precompiled preamble. https://reviews.llvm.org/D31544 Files:

[libcxx] r299236 - Use strong enums independently of -fobjc-arc

2017-03-31 Thread Duncan P. N. Exon Smith via cfe-commits
Author: dexonsmith Date: Fri Mar 31 12:39:56 2017 New Revision: 299236 URL: http://llvm.org/viewvc/llvm-project?rev=299236=rev Log: Use strong enums independently of -fobjc-arc r145698 introduced _LIBCPP_HAS_NO_STRONG_ENUMS by copy-pasting the __has_feature check from

[PATCH] D31538: [analyzer] MisusedMovedObjectChecker: Fix a false positive on state-resetting a base-class sub-object.

2017-03-31 Thread Peter Szecsi via Phabricator via cfe-commits
szepet added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MisusedMovedObjectChecker.cpp:426 + +State = State->remove(WholeObjectRegion); C.addTransition(State); szepet wrote: > I am wondering if I made a mistake but I think this should be >

r299233 - [Sema][X86] Update immediate check for gather/scatter prefetch instructions to match the _MM_HINT_T0/T1 constant definitions

2017-03-31 Thread Craig Topper via cfe-commits
Author: ctopper Date: Fri Mar 31 12:22:30 2017 New Revision: 299233 URL: http://llvm.org/viewvc/llvm-project?rev=299233=rev Log: [Sema][X86] Update immediate check for gather/scatter prefetch instructions to match the _MM_HINT_T0/T1 constant definitions Our _MM_HINT_T0/T1 constant values are

[PATCH] D31538: [analyzer] MisusedMovedObjectChecker: Fix a false positive on state-resetting a base-class sub-object.

2017-03-31 Thread Peter Szecsi via Phabricator via cfe-commits
szepet added a comment. Thank you for working on that, Artem! The changes look good, just one comment about that suspicious remove. Comment at: lib/StaticAnalyzer/Checkers/MisusedMovedObjectChecker.cpp:426 + +State = State->remove(WholeObjectRegion);

[PATCH] D30643: [OpenCL] Extended diagnostics for atomic initialization

2017-03-31 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia added inline comments. Comment at: test/SemaOpenCL/atomic-init.cl:6 +kernel void test_atomic_initialization() { + a1 = 1; // expected-error {{atomic variable can only be assigned to a compile time constant}} + atomic_int a2 = 0; // expected-error {{atomic variable

[PATCH] D28952: [analyzer] Add new Z3 constraint manager backend

2017-03-31 Thread Dominic Chen via Phabricator via cfe-commits
ddcc added inline comments. Comment at: cmake/modules/FindZ3.cmake:3 +# in the find_path() and find_library() calls +find_package(PkgConfig QUIET) +PKG_CHECK_MODULES(PC_Z3 QUIET libz3) delcypher wrote: > @ddcc Seeing as you don't want to use the new upstream Z3

[PATCH] D29658: [OpenMP] Customize CUDA-based tool chain selection

2017-03-31 Thread Gheorghe-Teodor Bercea via Phabricator via cfe-commits
gtbercea updated this revision to Diff 93679. gtbercea added a comment. Herald added a subscriber: rengolin. Split patch. Repository: rL LLVM https://reviews.llvm.org/D29658 Files: include/clang/Basic/DiagnosticDriverKinds.td lib/Driver/Driver.cpp test/OpenMP/target_messages.cpp

[PATCH] D31404: [OpenCL] Allow alloca return non-zero private pointer

2017-03-31 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia added a comment. In https://reviews.llvm.org/D31404#714906, @yaxunl wrote: > In https://reviews.llvm.org/D31404#714244, @Anastasia wrote: > > > I can't see clearly why the alloca has to be extended to accommodate the > > address space too? Couldn't the address space for alloca just

[PATCH] D29644: [OpenMP] Pass -v to PTXAS if it was passed to the driver.

2017-03-31 Thread Gheorghe-Teodor Bercea via Phabricator via cfe-commits
gtbercea updated this revision to Diff 93676. gtbercea added a comment. Move test. Repository: rL LLVM https://reviews.llvm.org/D29644 Files: lib/Driver/ToolChains/Cuda.cpp test/Driver/cuda-external-tools.cu Index: test/Driver/cuda-external-tools.cu

[PATCH] D29642: [OpenMP] Make OpenMP generated code for the NVIDIA device relocatable by default

2017-03-31 Thread Gheorghe-Teodor Bercea via Phabricator via cfe-commits
gtbercea updated this revision to Diff 93672. gtbercea marked an inline comment as done. gtbercea added a comment. Fix prefix. Repository: rL LLVM https://reviews.llvm.org/D29642 Files: lib/Driver/ToolChains/Cuda.cpp test/Driver/openmp-offload.c Index: test/Driver/openmp-offload.c

[PATCH] D29904: [OpenMP] Prevent emission of exception handling code when using OpenMP to offload to NVIDIA devices.

2017-03-31 Thread Gheorghe-Teodor Bercea via Phabricator via cfe-commits
gtbercea updated this revision to Diff 93670. gtbercea added a comment. run clang-format on test. Repository: rL LLVM https://reviews.llvm.org/D29904 Files: lib/Frontend/CompilerInvocation.cpp test/OpenMP/target_parallel_no_exceptions.cpp Index:

[PATCH] D31082: [mips][msa] Range adjustment for ldi_b builtin function operand

2017-03-31 Thread Petar Jovanovic via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL299229: [mips][msa] Range adjustment for ldi_b builtin function operand (authored by petarj). Changed prior to commit: https://reviews.llvm.org/D31082?vs=92439=93669#toc Repository: rL LLVM

r299229 - [mips][msa] Range adjustment for ldi_b builtin function operand

2017-03-31 Thread Petar Jovanovic via cfe-commits
Author: petarj Date: Fri Mar 31 11:16:43 2017 New Revision: 299229 URL: http://llvm.org/viewvc/llvm-project?rev=299229=rev Log: [mips][msa] Range adjustment for ldi_b builtin function operand Reasoning behind this change was allowing the function to accept all values from range [-128, 255] since

[PATCH] D29904: [OpenMP] Prevent emission of exception handling code when using OpenMP to offload to NVIDIA devices.

2017-03-31 Thread Gheorghe-Teodor Bercea via Phabricator via cfe-commits
gtbercea marked 2 inline comments as done. gtbercea added inline comments. Comment at: lib/Frontend/CompilerInvocation.cpp:2167-2172 +// Set the flag to prevent the implementation from emitting device exception +// handling code for those requiring so. +if

[PATCH] D29904: [OpenMP] Prevent emission of exception handling code when using OpenMP to offload to NVIDIA devices.

2017-03-31 Thread Gheorghe-Teodor Bercea via Phabricator via cfe-commits
gtbercea updated this revision to Diff 93665. gtbercea added a comment. Redo regression test. Repository: rL LLVM https://reviews.llvm.org/D29904 Files: lib/Frontend/CompilerInvocation.cpp test/OpenMP/target_parallel_no_exceptions.cpp Index:

[PATCH] D31541: [analyzer] MisusedMovedObjectChecker: Add a printState() method.

2017-03-31 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ created this revision. The `printState()` method adds the checker's information to the `State->dump()`. I find it very handy when debugging by looking at the exploded graphs, so i think it's great to have this method implemented in all checkers. It helped me already. I think it's not a

[PATCH] D31540: Prefer non-friend to friend in in redeclaration chain

2017-03-31 Thread Yaron Keren via Phabricator via cfe-commits
yaron.keren created this revision. Address http://bugs.llvm.org/pr30994 so that a non-friend can properly replace a friend, and a visible friend can properly replace an invisible friend but not vice verse. This also fixes two FIXME in SemaTemplate/friend-template.cpp. Repository: rL LLVM

[PATCH] D30691: [analyzer] Support for naive cross translational unit analysis

2017-03-31 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun updated this revision to Diff 93658. xazax.hun marked 11 inline comments as done. xazax.hun added a comment. - Fixed some of the review comments and some other cleanups. https://reviews.llvm.org/D30691 Files: include/clang/AST/ASTContext.h include/clang/AST/Decl.h

[PATCH] D31538: [analyzer] MisusedMovedObjectChecker: Fix a false positive on state-resetting a base-class sub-object.

2017-03-31 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ created this revision. If a state reset method is defined in a parent class, but called over an object of a child class, then the checker doesn't treat this as a state reset, at least for the sake of "Copying a 'moved-from' object" warning class. The patch fixes it, but Peter may have a

[PATCH] D31241: [Modules][PCH] Serialize #pragma pack

2017-03-31 Thread Alex Lorenz via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL299226: [Modules][PCH] Serialize #pragma pack (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D31241?vs=92638=93650#toc Repository: rL LLVM https://reviews.llvm.org/D31241

r299226 - [Modules][PCH] Serialize #pragma pack

2017-03-31 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Fri Mar 31 10:36:21 2017 New Revision: 299226 URL: http://llvm.org/viewvc/llvm-project?rev=299226=rev Log: [Modules][PCH] Serialize #pragma pack This patch serializes the state of #pragma pack. It preserves the state of the pragma from a PCH/from modules in a file that

[PATCH] D31078: [libunwind] Clean up macro usage.

2017-03-31 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL299225: [libunwind] Clean up macro usage. (authored by rsingh). Changed prior to commit: https://reviews.llvm.org/D31078?vs=93646=93647#toc Repository: rL LLVM https://reviews.llvm.org/D31078

[PATCH] D31078: [libunwind] Clean up macro usage.

2017-03-31 Thread Ranjeet Singh via Phabricator via cfe-commits
rs updated this revision to Diff 93646. rs marked 6 inline comments as done. https://reviews.llvm.org/D31078 Files: include/__libunwind_config.h include/libunwind.h include/unwind.h src/AddressSpace.hpp src/Unwind-EHABI.cpp src/Unwind-EHABI.h src/Unwind-sjlj.c

[PATCH] D29339: [OpenMP] Add support for auxiliary triple specification

2017-03-31 Thread Gheorghe-Teodor Bercea via Phabricator via cfe-commits
gtbercea updated this revision to Diff 93643. gtbercea added a comment. Re-order conditions and run clang-format. Repository: rL LLVM https://reviews.llvm.org/D29339 Files: lib/Driver/ToolChains/Clang.cpp lib/Frontend/CompilerInstance.cpp lib/Frontend/CompilerInvocation.cpp

Re: r299214 - clang-format: Fix post-commit review comment of r299204, use Style.isCpp().

2017-03-31 Thread Nico Weber via cfe-commits
Thanks! On Fri, Mar 31, 2017 at 9:30 AM, Daniel Jasper via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: djasper > Date: Fri Mar 31 08:30:24 2017 > New Revision: 299214 > > URL: http://llvm.org/viewvc/llvm-project?rev=299214=rev > Log: > clang-format: Fix post-commit review comment

[PATCH] D28952: [analyzer] Add new Z3 constraint manager backend

2017-03-31 Thread Dan Liew via Phabricator via cfe-commits
delcypher added inline comments. Comment at: CMakeLists.txt:188 +find_package(Z3 4.5) + ddcc wrote: > delcypher wrote: > > delcypher wrote: > > > @ddcc It is of course up to you but I recently [[ added support for using > > > `libz3` directly | added support

r299217 - Add back test for r299152

2017-03-31 Thread Teresa Johnson via cfe-commits
Author: tejohnson Date: Fri Mar 31 08:48:18 2017 New Revision: 299217 URL: http://llvm.org/viewvc/llvm-project?rev=299217=rev Log: Add back test for r299152 I am hoping the bot failures are addressed by using cc1 for the ThinLTO backend invocations as well. Modified:

[PATCH] D31101: [ThinLTO] Use clang's existing code gen handling for ThinLTO backends

2017-03-31 Thread Teresa Johnson via Phabricator via cfe-commits
tejohnson abandoned this revision. tejohnson added a comment. Subsumed by https://reviews.llvm.org/D31534 https://reviews.llvm.org/D31101 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D31534: [ThinLTO] Handle -emit-llvm* in ThinLTO backends

2017-03-31 Thread Teresa Johnson via Phabricator via cfe-commits
tejohnson created this revision. Herald added a subscriber: Prazek. Use PreCodeGenModuleHook to invoke the correct writer when emitting LLVM IR, returning false to skip codegen from within thinBackend. https://reviews.llvm.org/D31534 Files: lib/CodeGen/BackendUtil.cpp

r299214 - clang-format: Fix post-commit review comment of r299204, use Style.isCpp().

2017-03-31 Thread Daniel Jasper via cfe-commits
Author: djasper Date: Fri Mar 31 08:30:24 2017 New Revision: 299214 URL: http://llvm.org/viewvc/llvm-project?rev=299214=rev Log: clang-format: Fix post-commit review comment of r299204, use Style.isCpp(). Also, while at it, s/IsCpp/isCpp/ so that it follows LLVM style. Modified:

[PATCH] D31140: [LLVMbugs] [Bug 18710] Only generate .ARM.exidx and .ARM.extab when needed in EHABI

2017-03-31 Thread Christian Bruel via Phabricator via cfe-commits
chrib updated this revision to Diff 93631. chrib added a dependency: D31139: [LLVMbugs] [Bug 18710] Only generate .ARM.exidx and .ARM.extab when needed with EHABI. chrib added a comment. 1. Updating https://reviews.llvm.org/D31140: [LLVMbugs] [Bug 18710] Only generate .ARM.exidx and

Re: r299204 - clang-format: [JavaScript] Ignore QT keywords.

2017-03-31 Thread Nico Weber via cfe-commits
Please use style.isCpp() (spelling?) instead of comparing with LK_Cpp and LK_ObjC. On Mar 31, 2017 8:17 AM, "Daniel Jasper via cfe-commits" < cfe-commits@lists.llvm.org> wrote: Author: djasper Date: Fri Mar 31 07:04:37 2017 New Revision: 299204 URL:

r299210 - clang-format vs plugin support for Visual Studio 2017

2017-03-31 Thread Hans Wennborg via cfe-commits
Author: hans Date: Fri Mar 31 07:50:42 2017 New Revision: 299210 URL: http://llvm.org/viewvc/llvm-project?rev=299210=rev Log: clang-format vs plugin support for Visual Studio 2017 With the release of Visual Studio 2017, we need to at the very least claim support for it in the current manifest

[PATCH] D28952: [analyzer] Add new Z3 constraint manager backend

2017-03-31 Thread Dan Liew via Phabricator via cfe-commits
delcypher added inline comments. Comment at: cmake/modules/FindZ3.cmake:3 +# in the find_path() and find_library() calls +find_package(PkgConfig QUIET) +PKG_CHECK_MODULES(PC_Z3 QUIET libz3) @ddcc Seeing as you don't want to use the new upstream Z3 CMake package

r299204 - clang-format: [JavaScript] Ignore QT keywords.

2017-03-31 Thread Daniel Jasper via cfe-commits
Author: djasper Date: Fri Mar 31 07:04:37 2017 New Revision: 299204 URL: http://llvm.org/viewvc/llvm-project?rev=299204=rev Log: clang-format: [JavaScript] Ignore QT keywords. Modified: cfe/trunk/lib/Format/UnwrappedLineParser.cpp cfe/trunk/unittests/Format/FormatTestJS.cpp Modified:

r299198 - Spelling mistakes in comments. NFCI.

2017-03-31 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Fri Mar 31 06:00:53 2017 New Revision: 299198 URL: http://llvm.org/viewvc/llvm-project?rev=299198=rev Log: Spelling mistakes in comments. NFCI. Modified: cfe/trunk/include/clang/AST/ASTContext.h cfe/trunk/include/clang/AST/Decl.h

r299193 - Strip trailing whitespace

2017-03-31 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Fri Mar 31 05:40:56 2017 New Revision: 299193 URL: http://llvm.org/viewvc/llvm-project?rev=299193=rev Log: Strip trailing whitespace Modified: cfe/trunk/include/clang/AST/ASTContext.h Modified: cfe/trunk/include/clang/AST/ASTContext.h URL:

[PATCH] D28952: [analyzer] Add new Z3 constraint manager backend

2017-03-31 Thread Dan Liew via Phabricator via cfe-commits
delcypher added inline comments. Comment at: lib/StaticAnalyzer/Core/Z3ConstraintManager.cpp:559 + Float.toString(Chars, 0, 0); + AST = Z3_mk_numeral(Z3Context::ZC, Chars.c_str(), Sort); + break; ddcc wrote: > delcypher wrote: > > @ddcc I'm not

r299192 - [OpenCL] Do not generate "kernel_arg_type_qual" metadata for non-pointer args

2017-03-31 Thread Egor Churaev via cfe-commits
Author: echuraev Date: Fri Mar 31 05:14:52 2017 New Revision: 299192 URL: http://llvm.org/viewvc/llvm-project?rev=299192=rev Log: [OpenCL] Do not generate "kernel_arg_type_qual" metadata for non-pointer args Summary: "kernel_arg_type_qual" metadata should contain const/volatile/restrict tags

[PATCH] D29658: [OpenMP] Customize CUDA-based tool chain selection

2017-03-31 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld requested changes to this revision. Hahnfeld added inline comments. This revision now requires changes to proceed. Comment at: lib/Frontend/CompilerInvocation.cpp:2181-2190 + if (!(TT.getArch() == llvm::Triple::ppc || +TT.getArch() ==

[PATCH] D31515: [libc++] Implement LWG 2911 - add an is_aggregate type-trait

2017-03-31 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF updated this revision to Diff 93607. EricWF added a comment. - Fix typo in `// UNSUPPORTED` directive. https://reviews.llvm.org/D31515 Files: include/__config include/type_traits test/libcxx/utilities/meta/meta.unary/meta.unary.prop/missing_is_aggregate_trait.fail.cpp

[PATCH] D31515: [libc++] Implement LWG 2911 - add an is_aggregate type-trait

2017-03-31 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF updated this revision to Diff 93606. EricWF added a comment. - Fix accidental change. https://reviews.llvm.org/D31515 Files: include/__config include/type_traits test/libcxx/utilities/meta/meta.unary/meta.unary.prop/missing_is_aggregate_trait.fail.cpp

[PATCH] D29654: [OpenMP] Integrate OpenMP target region cubin into host binary

2017-03-31 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld added a reviewer: rnk. Hahnfeld added a subscriber: rnk. Hahnfeld added a comment. Please format all comments as full sentences. Comment at: lib/Driver/ToolChains/Cuda.cpp:338 +Args.getAllArgValues(options::OPT_march_EQ); +assert(GPUArchs.size() == 1 &&

[PATCH] D30691: [analyzer] Support for naive cross translational unit analysis

2017-03-31 Thread Daniel Marjamäki via Phabricator via cfe-commits
danielmarjamaki added inline comments. Comment at: include/clang/AST/ASTContext.h:42 #include "clang/Basic/Specifiers.h" +#include "clang/Basic/VersionTuple.h" #include "llvm/ADT/APSInt.h" I don't see why this is included here. Comment at:

r299191 - [msan] Turn off lifetime markers even when use after scope checking is on.

2017-03-31 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Mar 31 04:19:25 2017 New Revision: 299191 URL: http://llvm.org/viewvc/llvm-project?rev=299191=rev Log: [msan] Turn off lifetime markers even when use after scope checking is on. Since r299174 use after scope checking is on by default. Even though msan doesn't check for use

[PATCH] D31515: [libc++] Implement LWG 2911 - add an is_aggregate type-trait

2017-03-31 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF updated this revision to Diff 93605. EricWF added a comment. GCC implemented `__is_aggregate` hours ago as part of 7.0.1. Update the feature checks to reflect that. https://reviews.llvm.org/D31515 Files: include/__config include/type_traits

[PATCH] D29339: [OpenMP] Add support for auxiliary triple specification

2017-03-31 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld accepted this revision. Hahnfeld added a comment. This revision is now accepted and ready to land. LGTM Comment at: lib/Driver/ToolChains/Clang.cpp:1967-1968 +C.getSingleOffloadToolChain() +->getTriple() +.normalize(); +

[PATCH] D30643: [OpenCL] Extended diagnostics for atomic initialization

2017-03-31 Thread Egor Churaev via Phabricator via cfe-commits
echuraev updated this revision to Diff 93602. echuraev marked an inline comment as done. https://reviews.llvm.org/D30643 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaExpr.cpp lib/Sema/SemaInit.cpp test/Parser/opencl-atomics-cl20.cl test/SemaOpenCL/atomic-init.cl

[clang-tools-extra] r299190 - [clang-tidy] Correct code-block in the doc.

2017-03-31 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Mar 31 02:55:22 2017 New Revision: 299190 URL: http://llvm.org/viewvc/llvm-project?rev=299190=rev Log: [clang-tidy] Correct code-block in the doc. Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/readability-container-size-empty.rst Modified:

[PATCH] D31321: [OpenCL] Do not generate "kernel_arg_type_qual" metadata for non-pointer args

2017-03-31 Thread Egor Churaev via Phabricator via cfe-commits
echuraev updated this revision to Diff 93596. https://reviews.llvm.org/D31321 Files: lib/CodeGen/CodeGenFunction.cpp test/CodeGenOpenCL/kernel-arg-info.cl Index: test/CodeGenOpenCL/kernel-arg-info.cl === ---

[PATCH] D29904: [OpenMP] Prevent emission of exception handling code when using OpenMP to offload to NVIDIA devices.

2017-03-31 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld requested changes to this revision. Hahnfeld added a comment. This revision now requires changes to proceed. Out of interest: This is a limition of the implementation, right? Because the standard only says: `A throw executed inside a target region must cause execution to resume within

[PATCH] D23418: [analyzer] Added a reusable constraint system to the CloneDetector

2017-03-31 Thread Leslie Zhai via Phabricator via cfe-commits
xiangzhai added a comment. Hi Raphael, Then I will rebase my patch https://reviews.llvm.org/D31320 please review it when you have free time, thanks a lot! Regards, Leslie Zhai https://reviews.llvm.org/D23418 ___ cfe-commits mailing list

[PATCH] D31408: Add more examples to clang-format configuration

2017-03-31 Thread Daniel Jasper via Phabricator via cfe-commits
djasper added a comment. Generally please upload diffs with more contexts. For some here it's not even clear to which option they refer ;) Comment at: docs/ClangFormatStyleOptions.rst:941 + ContinuationIndentWidth: 2 + ColumnLimit: 15 + You could

[PATCH] D29644: [OpenMP] Pass -v to PTXAS if it was passed to the driver.

2017-03-31 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld added a comment. Just noticed that this isn't specific to OpenMP. Could you move the test to `Driver/cuda-external-tools.cu` where the rest of `ptxas` is tested? Repository: rL LLVM https://reviews.llvm.org/D29644 ___ cfe-commits

[PATCH] D31408: Add more examples to clang-format configuration

2017-03-31 Thread Sylvestre Ledru via Phabricator via cfe-commits
sylvestre.ledru added a comment. Daniel, wdyt? :) https://reviews.llvm.org/D31408 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29642: [OpenMP] Make OpenMP generated code for the NVIDIA device relocatable by default

2017-03-31 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld accepted this revision. Hahnfeld added a comment. This revision is now accepted and ready to land. LGTM after fixing the check-prefix Comment at: test/Driver/openmp-offload.c:595 +// RUN: %clang -### -fopenmp=libomp -fopenmp-targets=nvptx64-nvidia-cuda -save-temps