This revision was automatically updated to reflect the committed changes.
Closed by commit rL299510: [coroutines] Add coro.end handling (authored by
GorNishanov).
Changed prior to commit:
https://reviews.llvm.org/D25444?vs=94161&id=94162#toc
Repository:
rL LLVM
https://reviews.llvm.org/D254
Author: gornishanov
Date: Tue Apr 4 23:55:03 2017
New Revision: 299510
URL: http://llvm.org/viewvc/llvm-project?rev=299510&view=rev
Log:
[coroutines] Add coro.end handling
Summary:
For WinEH, We add a funclet bundle to a coro.end call, so that CoroSplit in
LLVM can replace it with cleanup ret a
GorNishanov updated this revision to Diff 94161.
GorNishanov retitled this revision from "[coroutines] Hybrid (bundle + bool
returning coro.end approach)" to "[coroutines] Add coro.end handling".
GorNishanov edited the summary of this revision.
GorNishanov added a subscriber: cfe-commits.
GorNisha
mprobst created this revision.
Herald added a subscriber: klimek.
Previously:
import {of } from 'x';
of (null);
Now:
import {of} from 'x';
of(null);
https://reviews.llvm.org/D31698
Files:
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTestJS.cpp
Index: unittests/Format/Fo
zturner created this revision.
To be honest I don't really understand anything about this code. I encountered
a situation when running `include-what-you-use` against LLVM where `TUScope`
was null here, triggering a segfault. Some surrounding comments and code
suggests that this variable is sp
zturner created this revision.
Herald added subscribers: mgorny, rengolin, aemerson.
It's a little bit annoying to have to manually edit files and then deal with
git thinking that you've got untracked files, and thusly deleting them when you
run `git clean -fd`. Although this is not an official
K-ballo added a comment.
I don't see any potential layout change, other than the case in which both `T1`
and `T2` are empty (which I understand doesn't happen within libc++). As far as
I know, the rest of the cases should result in the same layout regardless of
whether EBO actually applies or n
Hello everyone,
Below are some buildbot numbers for the last week of 03/26/2017 -
04/01/2017.
Please see the same data in attached csv files:
The longest time each builder was red during the last week;
"Status change ratio" by active builder (percent of builds that changed the
builder status fro
Hello everyone,
Below are some buildbot numbers for the week of 03/19/2017 - 03/25/2017.
Please see the same data in attached csv files:
The longest time each builder was red during the last week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from gre
GorNishanov created this revision.
If unhandled_exception member function is present in the coroutine promise,
wrap the body of the coroutine in:
try {
body
} catch(...) { promise.unhandled_exception(); }
https://reviews.llvm.org/D31692
Files:
include/clang/AST/StmtCXX.h
include/
inglorion abandoned this revision.
inglorion added a comment.
We will not be needing this.
https://reviews.llvm.org/D31633
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: anemet
Date: Tue Apr 4 18:46:34 2017
New Revision: 299488
URL: http://llvm.org/viewvc/llvm-project?rev=299488&view=rev
Log:
Another attempt to fix the sphinx warning from r299470
Modified:
cfe/trunk/docs/LanguageExtensions.rst
Modified: cfe/trunk/docs/LanguageExtensions.rst
URL:
ht
aaron.ballman added a reviewer: rsmith.
aaron.ballman added a comment.
Adding Richard, since this is a fairly extensive change to the frontend and he
may have some opinions as well.
Repository:
rL LLVM
https://reviews.llvm.org/D30009
___
cfe-com
aaron.ballman added a comment.
Thank you for the update! I think this is getting close, though I have a few
more comments inline.
Comment at: docs/LanguageExtensions.rst:2338
+The attributes can also be written using the C++11 style syntax, as long
+as only one attribute is sp
Author: anemet
Date: Tue Apr 4 17:45:20 2017
New Revision: 299481
URL: http://llvm.org/viewvc/llvm-project?rev=299481&view=rev
Log:
Fix sphinx warning from r299470
Modified:
cfe/trunk/docs/LanguageExtensions.rst
Modified: cfe/trunk/docs/LanguageExtensions.rst
URL:
http://llvm.org/viewvc/ll
This revision was automatically updated to reflect the committed changes.
Closed by commit rL299473: [Driver] Add option to print the resource directory
(authored by meadori).
Changed prior to commit:
https://reviews.llvm.org/D31447?vs=94110&id=94126#toc
Repository:
rL LLVM
https://reviews.
Author: meadori
Date: Tue Apr 4 16:46:50 2017
New Revision: 299473
URL: http://llvm.org/viewvc/llvm-project?rev=299473&view=rev
Log:
[Driver] Add option to print the resource directory
This patch adds the option -print-resource-dir. It simply
prints the resource directory. This information will
Author: anemet
Date: Tue Apr 4 16:18:36 2017
New Revision: 299470
URL: http://llvm.org/viewvc/llvm-project?rev=299470&view=rev
Log:
Add #pragma clang fp
This adds the new pragma and the first variant, contract(on/off/fast).
The pragma has the same block scope rules as STDC FP_CONTRACT, i.e. it
This revision was automatically updated to reflect the committed changes.
Closed by commit rL299470: Add #pragma clang fp (authored by anemet).
Changed prior to commit:
https://reviews.llvm.org/D31276?vs=93325&id=94122#toc
Repository:
rL LLVM
https://reviews.llvm.org/D31276
Files:
cfe/tru
This revision was automatically updated to reflect the committed changes.
Closed by commit rL299469: Set FMF for -ffp-contract=fast (authored by anemet).
Changed prior to commit:
https://reviews.llvm.org/D31168?vs=93882&id=94121#toc
Repository:
rL LLVM
https://reviews.llvm.org/D31168
Files:
Author: anemet
Date: Tue Apr 4 16:18:30 2017
New Revision: 299469
URL: http://llvm.org/viewvc/llvm-project?rev=299469&view=rev
Log:
Set FMF for -ffp-contract=fast
With this, FMF(contract) becomes an alternative way to express the request to
contract.
These are currently only propagated for FMul
jbcoe updated this revision to Diff 94120.
jbcoe added a comment.
Remove a couple of unnecessary type conversions.
Repository:
rL LLVM
https://reviews.llvm.org/D31568
Files:
clang/bindings/python/clang/__init__.py
clang/bindings/python/clang/cindex.py
clang/bindings/python/tests/cindex
clm updated this revision to Diff 94110.
clm added a subscriber: meadori.
clm added a comment.
I've now updated the patch to include your suggested revision of the test case.
I don't have commit access yet, but meadori said that he would commit it for
me.
https://reviews.llvm.org/D31447
File
This revision was automatically updated to reflect the committed changes.
Closed by commit rL299465: [clang-format] fix crash in
NamespaceEndCommentsFixer (PR32438) (authored by mgehre).
Changed prior to commit:
https://reviews.llvm.org/D31441?vs=93507&id=94108#toc
Repository:
rL LLVM
https
Author: mgehre
Date: Tue Apr 4 15:11:13 2017
New Revision: 299465
URL: http://llvm.org/viewvc/llvm-project?rev=299465&view=rev
Log:
[clang-format] fix crash in NamespaceEndCommentsFixer (PR32438)
Summary:
The new test case was crashing before. Now it passes
as expected.
Reviewers: djasper
Subs
rjmccall added inline comments.
Comment at: lib/Sema/SemaExprObjC.cpp:3358
var &&
- var->getStorageClass() == SC_Extern &&
+ !var->isThisDeclarationADefinition() &&
var->getType().isConstQualified()) {
Hmm. Come to think o
This revision was automatically updated to reflect the committed changes.
Closed by commit rL299463: [analyzer] Add new Z3 constraint manager backend
(authored by ddcc).
Changed prior to commit:
https://reviews.llvm.org/D28952?vs=93974&id=94107#toc
Repository:
rL LLVM
https://reviews.llvm.o
Author: ddcc
Date: Tue Apr 4 14:52:25 2017
New Revision: 299463
URL: http://llvm.org/viewvc/llvm-project?rev=299463&view=rev
Log:
[analyzer] Add new Z3 constraint manager backend
Summary: Implement new Z3 constraint manager backend.
Reviewers: zaks.anna, dcoughlin, NoQ, xazax.hun
Subscribers:
Author: jdevlieghere
Date: Tue Apr 4 14:42:29 2017
New Revision: 299461
URL: http://llvm.org/viewvc/llvm-project?rev=299461&view=rev
Log:
[clangd] Link against clangSema
Fixes linking issue introduced by rL299421 when building LLVM with
shared libraries.
Modified:
clang-tools-extra/trunk/cl
yaxunl updated this revision to Diff 94102.
yaxunl marked 2 inline comments as done.
yaxunl added a comment.
Revised by Anastasia's comments.
Add lit test for `__attribute__((address_space(0)))` and default address space.
https://reviews.llvm.org/D31404
Files:
include/clang/AST/ASTContext.h
Author: coby
Date: Tue Apr 4 14:20:21 2017
New Revision: 299459
URL: http://llvm.org/viewvc/llvm-project?rev=299459&view=rev
Log:
[fixup][X86][inline-asm] Add support for MS 'EVEN' directive
refining tested targets resolution, to amend failures caused by rL299454
Modified:
cfe/trunk/test/Co
yaxunl marked 8 inline comments as done.
yaxunl added inline comments.
Comment at: include/clang/AST/ASTContext.h:2328
+return AddrSpaceMapMangling ||
+ AS >= LangAS::target_first;
}
Anastasia wrote:
> Anastasia wrote:
> > yaxunl wrote:
> > > An
cdavis5x added a comment.
Extremely belated ping.
https://reviews.llvm.org/D20449
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: coby
Date: Tue Apr 4 12:58:28 2017
New Revision: 299454
URL: http://llvm.org/viewvc/llvm-project?rev=299454&view=rev
Log:
[X86][inline-asm] Add support for MS 'EVEN' directive
MS assembly syntax provide us with the 'EVEN' directive as a synonymous to at&t
'.even'.
This patch include the
This revision was automatically updated to reflect the committed changes.
Closed by commit rL299454: [X86][inline-asm] Add support for MS 'EVEN'
directive (authored by coby).
Changed prior to commit:
https://reviews.llvm.org/D27418?vs=80280&id=94095#toc
Repository:
rL LLVM
https://reviews.l
Anastasia added inline comments.
Comment at: include/clang/AST/ASTContext.h:2328
+return AddrSpaceMapMangling ||
+ AS >= LangAS::target_first;
}
Anastasia wrote:
> yaxunl wrote:
> > Anastasia wrote:
> > > So we couldn't use the LangAS::Count in
ruiu added a comment.
Is this a minimal test case that can produce the issue? It'd be awesome if you
can reduce it.
sema-segvcheck.c is not a good name for this test because that name can be used
for any crash bug. You want to see other files in the same directory to name
your file so that it'
Anastasia added inline comments.
Comment at: include/clang/AST/ASTContext.h:2328
+return AddrSpaceMapMangling ||
+ AS >= LangAS::target_first;
}
yaxunl wrote:
> Anastasia wrote:
> > So we couldn't use the LangAS::Count instead?
> >
> > I have
ahatanak added inline comments.
Comment at: clang/test/Sema/sema-segvcheck.c:3
+// RUN: %clang_cc1 -fsyntax-only %s; test $? -eq 1
+
+typedef struct {
You can simplify the test case. Compiling the following code still segfaults:
```
typedef struct {
unsigned l
ahatanak created this revision.
ARCCastChecker::VisitDeclRefExpr allows casting a constant pointer declared in
a header file to an ObjC pointer type. However, it rejects a cast from a
variable declared with a language linkage specification (e.g., extern "C") to
an ObjC pointer type.
According
bruno added inline comments.
Comment at: lib/Sema/SemaExpr.cpp:8032
+
+ return InvalidOperands(Loc, LHS, RHS);
+}
Double checking here: are there tests for the `InvalidOperands` case above?
Comment at: lib/Sema/SemaExpr.cpp:8163
+/// type with
This revision was automatically updated to reflect the committed changes.
Closed by commit rL299447: [Bug 25404] Fix crash on typedef in OpenCL 2.0
(authored by stulova).
Changed prior to commit:
https://reviews.llvm.org/D31397?vs=93226&id=94091#toc
Repository:
rL LLVM
https://reviews.llvm.
Author: stulova
Date: Tue Apr 4 11:50:46 2017
New Revision: 299447
URL: http://llvm.org/viewvc/llvm-project?rev=299447&view=rev
Log:
[Bug 25404] Fix crash on typedef in OpenCL 2.0
Fixed the assertion due to absence of source location for
implicitly defined types (using addImplicitTypedef()).
Dur
yamaguchi updated this revision to Diff 94090.
yamaguchi added a comment.
Add relative path to the file.
https://reviews.llvm.org/D31591
Files:
clang/test/Sema/sema-segvcheck.c
lib/Sema/SemaInit.cpp
Index: clang/test/Sema/sema-segvcheck.c
==
bruno added a comment.
Great! Thanks for improving this.
Comment at: include/clang/Sema/Sema.h:9287
bool AllowBothBool, bool AllowBoolConversion);
- QualType GetSignedVectorType(QualType V);
+ QualType GetSignedVectorType(QualType V, bool WantE
jaykang10 added a comment.
In https://reviews.llvm.org/D30810#718176, @Anastasia wrote:
> LGTM! Thanks!
Thanks Anastasia! Merge Done!
Repository:
rL LLVM
https://reviews.llvm.org/D30810
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
This revision was automatically updated to reflect the committed changes.
Closed by commit rL299445: Preserve vec3 type. (authored by jaykang10).
Changed prior to commit:
https://reviews.llvm.org/D30810?vs=92829&id=94088#toc
Repository:
rL LLVM
https://reviews.llvm.org/D30810
Files:
cfe/t
Author: jaykang10
Date: Tue Apr 4 11:40:25 2017
New Revision: 299445
URL: http://llvm.org/viewvc/llvm-project?rev=299445&view=rev
Log:
Preserve vec3 type.
Summary: Preserve vec3 type with CodeGen option.
Reviewers: Anastasia, bruno
Reviewed By: Anastasia
Subscribers: bruno, ahatanak, cfe-comm
ahatanak accepted this revision.
ahatanak added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rL LLVM
https://reviews.llvm.org/D31597
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
rjmccall added inline comments.
Comment at: include/clang/Sema/Initialization.h:124
+/// is a lambda that's captured by a block it's converted to.
+bool IsLambdaToBlockConversionEntity;
};
It seems less invasive to just give this a new EntityKind.
Re
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Yes, thank you, that's great.
https://reviews.llvm.org/D31168
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
GorNishanov created this revision.
Herald added a subscriber: EricWF.
Sema creates a declaration for gro variable as:
auto $gro = $promise.get_return_object();
However, gro variable has to outlive coroutine frame and coroutine promise, but,
it can only be initialized after the coroutine promis
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks!
https://reviews.llvm.org/D30643
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks!
https://reviews.llvm.org/D30810
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
Anastasia added a comment.
In https://reviews.llvm.org/D30810#710069, @jaykang10 wrote:
> > I believe the argument lacks numbers (or at least you have them but didn't
> > mention). I didn't hear about performance results, or validation that this
> > was actually tested for correctness. Small te
Author: mzuckerm
Date: Tue Apr 4 10:44:06 2017
New Revision: 299442
URL: http://llvm.org/viewvc/llvm-project?rev=299442&view=rev
Log:
Fix problem with test.
Modified:
cfe/trunk/test/CodeGen/avx512bw-builtins.c
cfe/trunk/test/CodeGen/avx512dq-builtins.c
cfe/trunk/test/CodeGen/avx512
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D31594
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
teemperor added a comment.
Change it to a namespace when merging if you prefer that :). Thanks for the
review!
https://reviews.llvm.org/D23418
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
NoQ accepted this revision.
NoQ added a comment.
Yay, i think this is good to go. Sorry again for being slow>< I guess i'd go
ahead and land this patch soon.
Comment at: include/clang/Analysis/CloneDetection.h:228
+/// custom constraints.
+class CloneConstraint {
+public:
aprantl added inline comments.
Comment at: include/clang/Sema/Initialization.h:122
+
+/// \brief When Kind == EK_BlockElement, this flag determines if the entity
+/// is a lambda that's captured by a block it's converted to.
No need to use \brief any more
NoQ added a comment.
Hello, sorry for your having to wait on me. The implementation looks good, i'm
only having a couple of public API concerns.
Comment at:
include/clang/StaticAnalyzer/Core/PathSensitive/CheckerHelpers.h:46-49
+bool isExprResultConformsComparisonRule(Checker
Author: krasimir
Date: Tue Apr 4 10:08:42 2017
New Revision: 299440
URL: http://llvm.org/viewvc/llvm-project?rev=299440&view=rev
Log:
[clangd] Fix completion test to not depend on the standard library
Modified:
clang-tools-extra/trunk/test/clangd/completion.test
Modified: clang-tools-extra/
anemet added a comment.
Thanks, Aaron! @rjmccall, does it look good to you too?
https://reviews.llvm.org/D31168
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
NoQ added a comment.
Hello,
Because i couldn't reproduce the loc-nonloc problem on my standard library,
could you share a preprocessed file with the issue? I'm really curious at
what's going on here, and it's the only issue remaining, so maybe we could
squash it together.
https://reviews.llv
NoQ added a comment.
Hello,
Sorry again for the delays, thank you for your patience. Your checker is in
good shape, very well-structured and easy to follow, you definitely know your
stuff, and my comments here are relatively minor.
Are you planning on making more varied warning messages, eg. s
This revision was automatically updated to reflect the committed changes.
Closed by commit rL299435: Fix exception address alignment test for EHABI
(authored by asiri).
Changed prior to commit:
https://reviews.llvm.org/D31178?vs=94074&id=94075#toc
Repository:
rL LLVM
https://reviews.llvm.or
Author: asiri
Date: Tue Apr 4 09:03:54 2017
New Revision: 299435
URL: http://llvm.org/viewvc/llvm-project?rev=299435&view=rev
Log:
Fix exception address alignment test for EHABI
This test fails on ARM bare-metal targets because it assumes the Itanium ABI,
whereas EHABI requires the exception add
rmaprath updated this revision to Diff 94074.
rmaprath added a comment.
Herald added a subscriber: mgorny.
Addressed review comments from @EricWF .
https://reviews.llvm.org/D31178
Files:
CMakeLists.txt
test/libcxxabi/test/config.py
test/lit.site.cfg.in
test/test_exception_address_alignm
yaxunl added a comment.
LGTM. Thanks.
https://reviews.llvm.org/D31594
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman added a comment.
LGTM. but you should wait for someone more familiar with this part of codegen
before committing.
https://reviews.llvm.org/D31168
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
sdardis updated this revision to Diff 94070.
sdardis added a comment.
Factored out the changes from https://reviews.llvm.org/D31337.
https://reviews.llvm.org/D25866
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/Sema.h
lib/Sema/SemaExpr.cpp
test/Sema/vector-cast.c
arphaman created this revision.
The commit r288866 introduced guaranteed copy elision to C++ 17. This
unfortunately broke the lambda to block conversion in C++17 (the compiler
crashes when performing IRGen). This patch fixes the conversion by avoiding
copy elision for the capture that captures
Author: mzuckerm
Date: Tue Apr 4 08:29:53 2017
New Revision: 299431
URL: http://llvm.org/viewvc/llvm-project?rev=299431&view=rev
Log:
[X86][Clang] Converting __mm{|256|512}_movm_epi{8|16|32|64} LLVMIR call into
generic intrinsics.
This patch is a part two of two reviews, one for the clang and t
ibronstein added inline comments.
Comment at: lib/Frontend/ASTUnit.cpp:2068
+if (!AllowRebuild && !OverrideMainBuffer)
+ return false;
+ }
Can we leave ASTUnit in such state?
https://reviews.llvm.org/D31544
_
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
> There are several undetected "TODO: loss of precision" right now in the tests
> that I would like to fix.
I think it's a good idea to have `// no-warning` comments as well when testing
for lack o
aaron.ballman added inline comments.
Comment at: clang-tidy/readability/OperatorsRepresentationCheck.cpp:34
+
+ if (const auto *B = Result.Nodes.getNodeAs("binary")) {
+switch (B->getOpcode()) {
alexfh wrote:
> Eugene.Zelenko wrote:
> > aaron.ballman wrote:
sdardis created this revision.
This improves some error messages which would otherwise refer to
ext_vector_type types in contexts where there are no such types.
Factored out from https://reviews.llvm.org/D25866 at reviewer's request.
https://reviews.llvm.org/D31667
Files:
include/clang/Sema/
alexfh added inline comments.
Comment at: clang-tidy/readability/OperatorsRepresentationCheck.cpp:34
+
+ if (const auto *B = Result.Nodes.getNodeAs("binary")) {
+switch (B->getOpcode()) {
Eugene.Zelenko wrote:
> aaron.ballman wrote:
> > alexfh wrote:
> > > a
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D31513
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
aaron.ballman added a comment.
LGTM! If you need someone to commit on your behalf, let us know. I won't be
able to do it this week. but I'm guessing @alexfh or someone else may be
available to help (or I can get to it next week).
Repository:
rL LLVM
https://reviews.llvm.org/D30547
__
Author: krasimir
Date: Tue Apr 4 05:42:22 2017
New Revision: 299426
URL: http://llvm.org/viewvc/llvm-project?rev=299426&view=rev
Log:
[clangd] Remove private vector fields from completion test.
Modified:
clang-tools-extra/trunk/test/clangd/completion.test
Modified: clang-tools-extra/trunk/t
echuraev updated this revision to Diff 94032.
echuraev marked an inline comment as done.
https://reviews.llvm.org/D31594
Files:
lib/Sema/SemaInit.cpp
test/CodeGenOpenCL/sampler.cl
test/SemaOpenCL/sampler_t.cl
Index: test/SemaOpenCL/sampler_t.cl
krasimir added inline comments.
Comment at: clangd/ASTManager.cpp:166
tooling::CompilationDatabase *
ASTManager::getOrCreateCompilationDatabaseForFile(StringRef Uri) {
auto &I = CompilationDatabases[Uri];
I think we should rename the `Uri` parameter here to
leanil updated this revision to Diff 94028.
leanil added a comment.
fix new lines
Repository:
rL LLVM
https://reviews.llvm.org/D30547
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/ForwardingReferenceOverloadCheck.cpp
clang-tidy/misc/ForwardingReferenceOverloadCheck.h
clang-ti
Author: hokein
Date: Tue Apr 4 04:53:55 2017
New Revision: 299422
URL: http://llvm.org/viewvc/llvm-project?rev=299422&view=rev
Log:
Fix windows buildbot error.
Modified:
clang-tools-extra/trunk/clang-rename/USRLocFinder.cpp
Modified: clang-tools-extra/trunk/clang-rename/USRLocFinder.cpp
URL
krasimir accepted this revision.
krasimir added a comment.
This revision is now accepted and ready to land.
Great!
https://reviews.llvm.org/D31441
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
This revision was automatically updated to reflect the committed changes.
Closed by commit rL299421: [clangd] Add code completion support (authored by
krasimir).
Changed prior to commit:
https://reviews.llvm.org/D31328?vs=92948&id=94026#toc
Repository:
rL LLVM
https://reviews.llvm.org/D3132
Author: krasimir
Date: Tue Apr 4 04:46:39 2017
New Revision: 299421
URL: http://llvm.org/viewvc/llvm-project?rev=299421&view=rev
Log:
[clangd] Add code completion support
Summary: Adds code completion support to clangd.
Reviewers: bkramer, malaperle-ericsson
Reviewed By: bkramer, malaperle-eri
bradfier created this revision.
Herald added a subscriber: klimek.
At present, clang-format mangles Java containing logical shift assignment
operators ('>>>=' or '<<<='), splitting them in two, resulting in invalid code:
public class Minimal {
public void func(String args) {
int i
Author: hokein
Date: Tue Apr 4 04:30:06 2017
New Revision: 299419
URL: http://llvm.org/viewvc/llvm-project?rev=299419&view=rev
Log:
[clang-rename] Support renaming qualified symbol
Summary:
The patch adds a new feature for renaming qualified symbol references.
Unlike orginal clang-rename behavio
This revision was automatically updated to reflect the committed changes.
Closed by commit rL299419: [clang-rename] Support renaming qualified symbol
(authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D31176?vs=93474&id=94021#toc
Repository:
rL LLVM
https://reviews.llvm
arphaman added a comment.
Ping.
Repository:
rL LLVM
https://reviews.llvm.org/D29768
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
NoQ added a comment.
Hello, thanks for the patch!
Because we already warn on freeing concrete function pointers, eg.
void foo() {
free(&foo);
}
this is a useful addition.
Is freeing function pointers always undefined? I wonder what happens if we take
some JIT-enabled javascript engine
AndersRonnholm created this revision.
The MallocChecker does not currently detect freeing of function pointers.
Example code.
void (*fnptr)(int);
void freeIndirectFunctionPtr() {
void *p = (void*)fnptr;
free(p); // expected-warning {{Argument to free() points to a function
pointer}}
94 matches
Mail list logo
