r303484 - [index] Fix forward declarations interfering with USR generation of external source symbols

Author: akirtzidis Date: Fri May 19 23:11:33 2017 New Revision: 303484 URL: http://llvm.org/viewvc/llvm-project?rev=303484&view=rev Log: [index] Fix forward declarations interfering with USR generation of external source symbols Patch by Nathan Hawes. https://reviews.llvm.org/D33346 Modified:

r303479 - Rename RAII objects for performing eager instantiation to have names that

Author: rsmith Date: Fri May 19 20:36:41 2017 New Revision: 303479 URL: http://llvm.org/viewvc/llvm-project?rev=303479&view=rev Log: Rename RAII objects for performing eager instantiation to have names that describe what they're for, not how they do it, and factor out a bit more common code into t

r303478 - CodeGenModule: Always output wchar_size, check LLVM assumptions.

Author: matze Date: Fri May 19 20:29:55 2017 New Revision: 303478 URL: http://llvm.org/viewvc/llvm-project?rev=303478&view=rev Log: CodeGenModule: Always output wchar_size, check LLVM assumptions. Re-commit r303463 now that LLVM is fixed and adjust some lit tests. llvm::TargetLibraryInfo needs t

r303474 - Revert "CodeGenModule: Always output wchar_size, check LLVM assumptions."

Author: matze Date: Fri May 19 19:38:27 2017 New Revision: 303474 URL: http://llvm.org/viewvc/llvm-project?rev=303474&view=rev Log: Revert "CodeGenModule: Always output wchar_size, check LLVM assumptions." Let's revert this for now (and with it the assert()) to get the bots back to green until I

r303472 - Fix valid-for-expr ellipses eaten as invalid decl

Author: hubert.reinterpretcast Date: Fri May 19 19:21:55 2017 New Revision: 303472 URL: http://llvm.org/viewvc/llvm-project?rev=303472&view=rev Log: Fix valid-for-expr ellipses eaten as invalid decl Summary: The trial parse for declarative syntax accepts an invalid pack declaration syntax, which

Buildbot numbers for the week of 05/07/2017 - 05/13/2017

Hello everyone, Below are some buildbot numbers for the last week of 05/07/2017 - 05/13/2017. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status fro

Buildbot numbers for the week of 04/30/2017 - 05/06/2017

Hello everyone, Below are some buildbot numbers for the week of 04/30/2017 - 05/06/2017. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status from gre

r303469 - Remove last (unnecessary) use of mapping from SourceLocation to Module and

Author: rsmith Date: Fri May 19 18:49:00 2017 New Revision: 303469 URL: http://llvm.org/viewvc/llvm-project?rev=303469&view=rev Log: Remove last (unnecessary) use of mapping from SourceLocation to Module and remove the mechanism for doing so. This mechanism was incorrect in the presence of prepro

[PATCH] D33339: Fix valid-for-expr ellipses eaten as invalid decl

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM, thanks! https://reviews.llvm.org/D9 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

r303468 - [modules] Simplify module macro handling in non-local-submodule-visibility mode.

Author: rsmith Date: Fri May 19 18:32:38 2017 New Revision: 303468 URL: http://llvm.org/viewvc/llvm-project?rev=303468&view=rev Log: [modules] Simplify module macro handling in non-local-submodule-visibility mode. When reaching the end of a module, we used to convert its macros to ModuleMacros bu

[PATCH] D33049: [libcxx] Support for Objective-C++ tests

This revision was automatically updated to reflect the committed changes. Closed by commit rL303466: [test] Add support for Objective-C++ tests (authored by epilk). Changed prior to commit: https://reviews.llvm.org/D33049?vs=99633&id=99643#toc Repository: rL LLVM https://reviews.llvm.org/D3

[libcxx] r303466 - [test] Add support for Objective-C++ tests

Author: epilk Date: Fri May 19 18:02:49 2017 New Revision: 303466 URL: http://llvm.org/viewvc/llvm-project?rev=303466&view=rev Log: [test] Add support for Objective-C++ tests Differential revision: https://reviews.llvm.org/D33049 Added: libcxx/trunk/test/libcxx/selftest/test.arc.fail.mm

r303463 - CodeGenModule: Always output wchar_size, check LLVM assumptions.

Author: matze Date: Fri May 19 17:37:15 2017 New Revision: 303463 URL: http://llvm.org/viewvc/llvm-project?rev=303463&view=rev Log: CodeGenModule: Always output wchar_size, check LLVM assumptions. llvm::TargetLibraryInfo needs to know the size of wchar_t to work on functions like `wcslen`. This p

r303459 - [ODRHash] Revert r303450 to fix buildbot

Author: rtrieu Date: Fri May 19 17:35:41 2017 New Revision: 303459 URL: http://llvm.org/viewvc/llvm-project?rev=303459&view=rev Log: [ODRHash] Revert r303450 to fix buildbot r303450 [ODRHash] Support TemplateName and TemplateArgument Modified: cfe/trunk/lib/AST/ODRHash.cpp cfe/trunk/tes

[PATCH] D33366: Fix that global delete operator get's assigned to a submodule.

rsmith added a comment. This is supposed to be handled by `Sema::DeclareGlobalAllocationFunction`: DeclContext::lookup_result R = GlobalCtx->lookup(Name); for (DeclContext::lookup_iterator Alloc = R.begin(), AllocEnd = R.end(); Alloc != AllocEnd; ++Alloc) { // Only look at non-temp

[PATCH] D33049: [libcxx] Support for Objective-C++ tests

jroelofs accepted this revision. jroelofs added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D33049 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

[PATCH] D33049: [libcxx] Support for Objective-C++ tests

erik.pilkington updated this revision to Diff 99633. erik.pilkington marked an inline comment as done. erik.pilkington added a comment. This new patch checks to make sure ARC is enabled in the tests, thanks for the suggestion! https://reviews.llvm.org/D33049 Files: test/libcxx/selftest/test.

[PATCH] D33049: [libcxx] Support for Objective-C++ tests

jroelofs added a comment. Would be good to test for the presence/absence of the flag, too: Comment at: test/libcxx/selftest/test.arc.pass.mm:10 +//===--===// + +int main() ``` #if __has_feature

[PATCH] D33339: Fix valid-for-expr ellipses eaten as invalid decl

hubert.reinterpretcast updated this revision to Diff 99632. hubert.reinterpretcast added a comment. Remove stray ellipsis treatment entirely https://reviews.llvm.org/D9 Files: lib/Parse/ParseTentative.cpp test/Parser/cxx0x-ambig.cpp Index: test/Parser/cxx0x-ambig.cpp ==

[PATCH] D33049: [libcxx] Support for Objective-C++ tests

erik.pilkington updated this revision to Diff 99628. erik.pilkington added a comment. In this new patch: - Add support for toggling -fobjc-arc, this is done by using file extensions, ie: `foo.arc.pass.mm` instead of `foo.pass.mm`. (Thanks @dexonsmith for the suggestion!) - Clean up/simplify thi

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 7 PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33368: [libcxxabi][demangler] Fix a crash in the demangler

erik.pilkington created this revision. Herald added a reviewer: EricWF. This patch fixes a bug in the demangler where a pack expansion template parameter substitution with more than one element in a lambda's parameter list resulted in either a misdemangle or a crash. I'll commit this change to

[PATCH] D33366: Fix that global delete operator get's assigned to a submodule.

teemperor added a comment. I'm not 100% sure if that's the right fix, but I didn't see a obvious way to declare the new/delete outside the current submodule. Maybe Richard knows a better way :) https://reviews.llvm.org/D33366 ___ cfe-commits maili

[PATCH] D33366: Fix that global delete operator get's assigned to a submodule.

teemperor created this revision. In the current local-submodule-visibility mode, as soon as we discover a virtual destructor, we declare on demand a global delete operator. However, this causes that this delete operator is owned by the submodule which contains said virtual destructor. This mean

r303451 - Do not issue -Wnullability-completeness for dependent types that are not written as pointer types.

Author: rsmith Date: Fri May 19 15:20:13 2017 New Revision: 303451 URL: http://llvm.org/viewvc/llvm-project?rev=303451&view=rev Log: Do not issue -Wnullability-completeness for dependent types that are not written as pointer types. Added: cfe/trunk/test/SemaCXX/Inputs/nullability-completenes

Re: [libcxx] r302723 - XFAIL is_trivially_copyable test for compilers that don't implement Core 2094

No, sorry, this is not ToT. This is r298531, which already self identifies as clang-5.0, but, apparently, does not implement Core 2094. I'll just upgrade. On Fri, May 19, 2017 at 1:27 PM, Evgenii Stepanov wrote: > Hi, > > this test is failing for me with ToT clang (clang -cc1 version 5.0.0 > bas

Re: [libcxx] r302723 - XFAIL is_trivially_copyable test for compilers that don't implement Core 2094

Hi, this test is failing for me with ToT clang (clang -cc1 version 5.0.0 based upon LLVM 5.0.0svn). All the failing static_assert's mention volatile one way or the other. On Wed, May 10, 2017 at 1:19 PM, Eric Fiselier via cfe-commits wrote: > Author: ericwf > Date: Wed May 10 15:19:35 2017 > N

[PATCH] D33339: Fix valid-for-expr ellipses eaten as invalid decl

hubert.reinterpretcast added a comment. In https://reviews.llvm.org/D9#759797, @rsmith wrote: > In https://reviews.llvm.org/D9#759146, @hubert.reinterpretcast wrote: > > > The `check-all` target passes even if the ellipsis-after-declarator-id > > disambiguation as a declarator is removed

r303450 - [ODRHash] Support TemplateName and TemplateArgument

Author: rtrieu Date: Fri May 19 15:05:16 2017 New Revision: 303450 URL: http://llvm.org/viewvc/llvm-project?rev=303450&view=rev Log: [ODRHash] Support TemplateName and TemplateArgument Modified: cfe/trunk/lib/AST/ODRHash.cpp cfe/trunk/test/Modules/odr_hash.cpp Modified: cfe/trunk/lib/AST

[PATCH] D33250: [Sema][ObjC] Fix a bug where -Wunguarded-availability was emitted at the wrong location

erik.pilkington updated this revision to Diff 99605. erik.pilkington added a comment. > Can we ignore the TypeLocs with invalid location and instead look at > ObjCPropertyRefExprs with a class receiver? Sure, good idea. This new patch does exactly that. Thanks, Erik https://reviews.llvm.org/D

[PATCH] D33339: Fix valid-for-expr ellipses eaten as invalid decl

rsmith added a comment. In https://reviews.llvm.org/D9#759146, @hubert.reinterpretcast wrote: > The `check-all` target passes even if the ellipsis-after-declarator-id > disambiguation as a declarator is removed entirely. [...] > So, on the whole, the stray ellipsis treatment is both too c

[PATCH] D31778: [Modules] Implement ODR-like semantics for tag types in C/ObjC

rsmith added inline comments. Comment at: include/clang/Parse/Parser.h:1956-1957 AccessSpecifier AS, DeclSpecContext DSC); - void ParseEnumBody(SourceLocation StartLoc, Decl *TagDecl); + void ParseEnumBody(SourceLocation StartLoc, Decl *TagDecl, +

[PATCH] D33272: Method loadFromCommandLine should be able to report errors

sepavloff updated this revision to Diff 99600. sepavloff added a comment. Change loadFromCommandLine so that it returns std::unique_ptr as methods of CompilationDatabase does https://reviews.llvm.org/D33272 Files: include/clang/Tooling/CompilationDatabase.h lib/Frontend/CreateInvocationFro

[PATCH] D33272: Method loadFromCommandLine should be able to report errors

sepavloff added a comment. In https://reviews.llvm.org/D33272#758616, @joerg wrote: > Can this use ErrorOr? It makes sense if constructing methods of `CompilationDatabase` were also changed to return `ErrorOr`, as there is no need to have different interfaces for the similar functionality. On

[PATCH] D32178: Delete unstable integration tests

jroelofs added a comment. @arphaman Those patches seem reasonable. https://reviews.llvm.org/D32178 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32401: [Devirtualization] insert placement new barrier with -O0

mehdi_amini accepted this revision. mehdi_amini added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D32401 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

[PATCH] D33364: [mips] Support micromips attribute passed by front-end

atanasyan created this revision. Herald added a subscriber: arichardson. This patch adds handling of the `micromips` and `nomicromips` attributes passed by front-end. The patch depends on https://reviews.llvm.org/D33363. Repository: rL LLVM https://reviews.llvm.org/D33364 Files: lib/Targe

[PATCH] D33363: [mips] Support `micromips` attribute

atanasyan created this revision. Herald added subscribers: arichardson, javed.absar. This patch adds support for the `micromips` and `nomicromips` attributes for MIPS targets. Repository: rL LLVM https://reviews.llvm.org/D33363 Files: include/clang/Basic/Attr.td include/clang/Basic/Attr

[PATCH] D32499: Further delay calling DeclMustBeEmitted until it's safe.

v.g.vassilev closed this revision. v.g.vassilev added a comment. Landed in r303432. https://reviews.llvm.org/D32499 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r303432 - [modules] Further delay calling DeclMustBeEmitted until it's safe.

Author: vvassilev Date: Fri May 19 11:46:06 2017 New Revision: 303432 URL: http://llvm.org/viewvc/llvm-project?rev=303432&view=rev Log: [modules] Further delay calling DeclMustBeEmitted until it's safe. As discussed in D30793, we have some unsafe calls to isConsumerInterestedIn(). This patch impl

[PATCH] D31778: [Modules] Implement ODR-like semantics for tag types in C/ObjC

bruno updated this revision to Diff 99585. bruno added a comment. Update the patch to address @rsmith comments and rebase https://reviews.llvm.org/D31778 Files: include/clang/AST/ASTStructuralEquivalence.h include/clang/Basic/DiagnosticASTKinds.td include/clang/Parse/Parser.h include/cl

[PATCH] D31778: [Modules] Implement ODR-like semantics for tag types in C/ObjC

bruno marked 3 inline comments as done. bruno added a comment. > I think the problem is that we don't take module visibility into account when > doing redefinition checking for enumerators. Instead of passing through this > flag, we should probably just ignore hidden declarations when checking f

[PATCH] D33354: [clang-tidy] readability-braces-around-statements false positive with char literals

fgross updated this revision to Diff 99576. fgross added a comment. After some digging into it, here is my uneducated guess: The comment in `findEndLocation` states that //"Loc points to the beginning of the last token before ';'"//. But `checkStmt` calls it with `FileRange.getEnd().getLocWithO

[PATCH] D32480: clang-format: Add CompactNamespaces option

Typz added inline comments. Comment at: include/clang/Format/Format.h:358 + /// \endcode + bool BinPackNamespaces; + djasper wrote: > Typz wrote: > > djasper wrote: > > > This is not bin packing at all. Maybe CompactNamespaces? Or > > > SingleLineNamespaces? >

[PATCH] D32480: clang-format: Add CompactNamespaces option

Typz updated this revision to Diff 99575. Typz marked 11 inline comments as done. Typz edited the summary of this revision. Typz added a comment. update for review comments https://reviews.llvm.org/D32480 Files: include/clang/Format/Format.h lib/Format/Format.cpp lib/Format/NamespaceEndCo

[PATCH] D33356: [Nios2] Changes in frontend to support Nios2 LLVM target

joerg added inline comments. Comment at: lib/Basic/Targets.cpp:7650 +DefineStd(Builder, "nios2", Opts); +DefineStd(Builder, "NIOS2", Opts); + belickim wrote: > joerg wrote: > > belickim wrote: > > > joerg wrote: > > > > DefineStd tends to give a lot of na

[PATCH] D33197: [libclang] [OpenCL] Expose more OpenCL CIndex types

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. https://reviews.llvm.org/D33197 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

[PATCH] D32499: Further delay calling DeclMustBeEmitted until it's safe.

v.g.vassilev added a comment. We were trying to come up with a test case. So far we are unsuccessful. I will check it in as is. https://reviews.llvm.org/D32499 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

[PATCH] D33197: [libclang] [OpenCL] Expose more OpenCL CIndex types

svenvh updated this revision to Diff 99574. svenvh added a comment. Adding comments. https://reviews.llvm.org/D33197 Files: bindings/python/clang/cindex.py include/clang-c/Index.h test/Index/opencl-types.cl tools/libclang/CXType.cpp Index: tools/libclang/CXType.cpp

[PATCH] D32401: [Devirtualization] insert placement new barrier with -O0

rjmccall added a comment. In https://reviews.llvm.org/D32401#759223, @Prazek wrote: > Is everyone ok with sending this patch? As long as this continues to be an opt-in optimization, go ahead and do your research project, I suppose. https://reviews.llvm.org/D32401 _

[PATCH] D32499: Further delay calling DeclMustBeEmitted until it's safe.

tstellar added a comment. This is mentioned as a fix for PR31863, which is a blocker for the 4.0.1 release, is there any reason this hasn't been committed to trunk yet? https://reviews.llvm.org/D32499 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D33354: [clang-tidy] readability-braces-around-statements false positive with char literals

alexfh added a comment. I'll repeat my comment from https://reviews.llvm.org/D25558: "I'm thoroughly confused as to why the code in your test was not handled correctly and why this is the right fix. Can you explain?" The "For some reason ..." part doesn't really explain anything. I guess, we're

[PATCH] D33356: [Nios2] Changes in frontend to support Nios2 LLVM target

belickim added inline comments. Comment at: lib/Basic/Targets.cpp:7650 +DefineStd(Builder, "nios2", Opts); +DefineStd(Builder, "NIOS2", Opts); + joerg wrote: > belickim wrote: > > joerg wrote: > > > DefineStd tends to give a lot of namespace pollution, is

[PATCH] D33358: [clang-tidy] readability-redundant-declaration false positive for defaulted function

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG. Thank you! https://reviews.llvm.org/D33358 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

[PATCH] D33358: [clang-tidy] readability-redundant-declaration false positive for defaulted function

fgross created this revision. Herald added a subscriber: xazax.hun. template struct C { C(); }; template C::C() = default; Causes a readability-redundant-declaration diagnostic. This is caused by `isDefinition` not matching defaulted functions. https://reviews.llvm.org/D3335

[PATCH] D33357: Avoid calling report_fatal_error in the destructor of raw_fd_ostream when saving a module timestamp file

arphaman created this revision. We should clear the error on the output stream to prevent the call to `report_fatal_error` from `raw_fd_ostreams`'s destructor. I couldn't think of a way to test this, do you think it's possible to have a test for this? Repository: rL LLVM https://reviews.ll

[PATCH] D33356: [Nios2] Changes in frontend to support Nios2 LLVM target

joerg added inline comments. Comment at: lib/Basic/Targets.cpp:7650 +DefineStd(Builder, "nios2", Opts); +DefineStd(Builder, "NIOS2", Opts); + belickim wrote: > joerg wrote: > > DefineStd tends to give a lot of namespace pollution, is that intentional > >

[PATCH] D33045: [libclang] Avoid more stats than necessary for reparse.

ilya-biryukov added a comment. Sorry, didn't get a chance to look into it very thoroughly yet. Are there any other callers to getMainBufferWithPrecompiledPreamble? Maybe they cause LibclangReparseTest.ReparseWithModule to fail? Comment at: lib/Frontend/ASTUnit.cpp:1395 +

[PATCH] D33356: [Nios2] Changes in frontend to support Nios2 LLVM target

belickim added a comment. Additionally this information may be useful in context of this patch: here is specification of Nios2 builtins as implemented in GCC: https://gcc.gnu.org/onlinedocs/gcc/Altera-Nios-II-Built-in-Functions.html https://reviews.llvm.org/D33356 __

[PATCH] D33356: [Nios2] Changes in frontend to support Nios2 LLVM target

belickim added inline comments. Comment at: lib/Basic/Targets.cpp:7614 + resetDataLayout(("e-" + Layout).str()); +} + } joerg wrote: > Can you just give the full string and avoid the runtime allocations? Yes, I will fix this. Comment

[PATCH] D32146: PR32476: __nop_locale_mgmt.h not needed with newlib 2.5+

MartinO added a comment. The introduction of the macros '__NEWLIB__' and '__NEWLIB_MINOR__' appear to have been first introduced in Newlib v2.3.0.20160226, but the new interface for '' was introduced in Newlib v2.4.0.20160923 - previous releases of v2.4.0 did not make these changes. This is wh

[PATCH] D33356: [Nios2] Changes in frontend to support Nios2 LLVM target

joerg added inline comments. Comment at: lib/Basic/Targets.cpp:7614 + resetDataLayout(("e-" + Layout).str()); +} + } Can you just give the full string and avoid the runtime allocations? Comment at: lib/Basic/Targets.cpp:7650 +Defi

[PATCH] D33356: [Nios2] Changes in frontend to support Nios2 LLVM target

belickim created this revision. Hello, This patch is part of our effort to implement Nios2 architecture support in LLVM and clang (our plans were announced in mailing list thread: "[llvm-dev] [RFC] Nios II backend" form April 12th). This patch depends on changes introduced by patch D32669

[PATCH] D33042: [libclang] Allow to suspend a translation unit.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. This makes sense to me. Comment at: lib/Frontend/ASTUnit.cpp:2089 +void ASTUnit::ResetForParse() +{ + SavedMainFileBuffer.reset(); Put the `{` on the same

[PATCH] D33354: [clang-tidy] readability-braces-around-statements false positive with char literals

fgross created this revision. Herald added a subscriber: xazax.hun. Single-line if statements cause a false positive when the last token in the conditional statement is a char constant: if (condition) return 'a'; For some reason `findEndLocation` seems to skips too many (vertical) whites

[PATCH] D33314: clang-format: Add option to remove semicolon at end of namespace

Typz abandoned this revision. Typz added a comment. ATM, in the presence of semicolons, the closing braces will simply not be merged : i will check if I can handle this case easily (in the CompactNamespaces patch), and I'll abandon this one for now. https://reviews.llvm.org/D33314 _

[PATCH] D32478: [clang-format] Fix AlignOperands when BreakBeforeBinaryOperators is set

Typz added a comment. In https://reviews.llvm.org/D32478#758258, @djasper wrote: > When you say "this doesn't happen in tests", do you mean this never happens > when there are parentheses around the expression? By 'test' I meant 'conditional construct' : it happens when there are parentheses

[PATCH] D32479: [clang-format] Add BreakConstructorInitializersBeforeColon option

Typz updated this revision to Diff 99553. Typz added a comment. Deprecate BreakConstructorInitializersBeforeComma and replace it with a more generic BreakConstructorInitializers option. https://reviews.llvm.org/D32479 Files: include/clang/Format/Format.h lib/Format/ContinuationIndenter.cpp

[PATCH] D33353: [OpenCL] An error shall occur if any scalar operand has greater rank than the type of the vector element

echuraev created this revision. Herald added a subscriber: yaxunl. https://reviews.llvm.org/D33353 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaExpr.cpp test/SemaOpenCL/arithmetic-conversions.cl test/SemaOpenCL/cond.cl Index: test/SemaOpenCL/cond.cl

[PATCH] D33284: [CodeGen] Propagate LValueBaseInfo instead of AlignmentSource

kparzysz marked an inline comment as done. kparzysz added inline comments. Comment at: cfe/trunk/lib/CodeGen/CodeGenFunction.h:3756 /// /// \param Source - If non-null, this will be initialized with /// information about the source of the alignment. Note that this ---

r303419 - Restore and update documentation comment for EmitPointerWithAlignment

Author: kparzysz Date: Fri May 19 07:03:34 2017 New Revision: 303419 URL: http://llvm.org/viewvc/llvm-project?rev=303419&view=rev Log: Restore and update documentation comment for EmitPointerWithAlignment Modified: cfe/trunk/lib/CodeGen/CodeGenFunction.h Modified: cfe/trunk/lib/CodeGen/CodeG

[PATCH] D32178: Delete unstable integration tests

arphaman added a comment. While I do agree that these tests would be better off in another place, we currently don't have the bandwidth to facilitate that move. https://reviews.llvm.org/D32178 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D32178: Delete unstable integration tests

arphaman added a comment. @jroelofs I've managed to put together a solution that adds REQUIRES to the tests that ensure they only work with the latest SDK (10.12). F3339761: macOSsdk.diff F3339760: sdkUtilLLVM.diff WDYT?

[PATCH] D33351: [clang-format] Handle trailing comment sections in import statement lines

This revision was automatically updated to reflect the committed changes. Closed by commit rL303415: [clang-format] Handle trailing comment sections in import statement lines (authored by krasimir). Changed prior to commit: https://reviews.llvm.org/D33351?vs=99538&id=99539#toc Repository: rL

r303415 - [clang-format] Handle trailing comment sections in import statement lines

Author: krasimir Date: Fri May 19 05:34:57 2017 New Revision: 303415 URL: http://llvm.org/viewvc/llvm-project?rev=303415&view=rev Log: [clang-format] Handle trailing comment sections in import statement lines Summary: This patch updates the handling of multiline trailing comment sections in impor

[PATCH] D33351: [clang-format] Handle trailing comment sections in import statement lines

krasimir updated this revision to Diff 99538. krasimir marked 2 inline comments as done. krasimir added a comment. - Address review comments https://reviews.llvm.org/D33351 Files: lib/Format/ContinuationIndenter.cpp lib/Format/TokenAnnotator.cpp lib/Format/UnwrappedLineParser.cpp unitte

[PATCH] D33351: [clang-format] Handle trailing comment sections in import statement lines

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. nice Comment at: lib/Format/ContinuationIndenter.cpp:590 1u, std::min(Current.NewlinesBefore, Style.MaxEmptyLinesToKeep + 1)); +bool InPPDirective = +S

[PATCH] D33284: [CodeGen] Propagate LValueBaseInfo instead of AlignmentSource

chapuni added inline comments. Comment at: cfe/trunk/lib/CodeGen/CodeGenFunction.h:3756 /// /// \param Source - If non-null, this will be initialized with /// information about the source of the alignment. Note that this Could you update this? See als

r303414 - CodeGenFunction::EmitPointerWithAlignment(): Prune a \param in r303358, possibly obsolete. [-Wdocumentation]

Author: chapuni Date: Fri May 19 05:19:59 2017 New Revision: 303414 URL: http://llvm.org/viewvc/llvm-project?rev=303414&view=rev Log: CodeGenFunction::EmitPointerWithAlignment(): Prune a \param in r303358, possibly obsolete. [-Wdocumentation] Modified: cfe/trunk/lib/CodeGen/CodeGenFunction.h

[PATCH] D33350: [clangd] Switch to incomplete translation units

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D33350 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D33350: [clangd] Switch to incomplete translation units

krasimir created this revision. This speeds up code completion. All the cool kids (ycmd) are doing it. https://reviews.llvm.org/D33350 Files: clangd/ClangdUnit.cpp Index: clangd/ClangdUnit.cpp === --- clangd/ClangdUnit.cpp +++

[PATCH] D33053: [PowerPC] Implement vec_xxpermdi builtin.

inouehrs added inline comments. Comment at: test/CodeGen/builtins-ppc-error.c:23 +void testXXPERMDI(void) { + int index = 5; + vec_xxpermdi(vsi); //expected-error {{too few arguments to function call, expected at least 3, have 1}} I am not sure we can assure t

[PATCH] D32401: [Devirtualization] insert placement new barrier with -O0

Prazek added a comment. Is everyone ok with sending this patch? https://reviews.llvm.org/D32401 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33314: clang-format: Add option to remove semicolon at end of namespace

djasper added a comment. I think we should just not do this for now. This addresses a very infrequent case that's easy enough to fix manually. As such, it's not worth the added complexity of clang-format and potential failures it might generate. Changing non-whitespace/non-comment code is alway

[PATCH] D33314: clang-format: Add option to remove semicolon at end of namespace

Typz added a comment. I stumbled on the issue when working on the CompactNamespaces option, where the extra semicolon prevents merging the closing braces. There was an easy fix, which guaranteed that the closing braces would be properly merged, so I went for it