[PATCH] D34329: [GSoC] Clang AST diffing

johannes updated this revision to Diff 103151. https://reviews.llvm.org/D34329 Files: include/clang/Tooling/ASTDiff/ASTDiff.h lib/Tooling/ASTDiff/ASTDiff.cpp lib/Tooling/ASTDiff/CMakeLists.txt lib/Tooling/CMakeLists.txt tools/CMakeLists.txt tools/clang-diff/CMakeLists.txt

[PATCH] D34329: [GSoC] Clang AST diffing

johannes added a comment. In https://reviews.llvm.org/D34329#784090, @arphaman wrote: > Generally we shouldn't have untested code in trunk, so I think that we need > to find a way to test this before committing. We can start off by testing the > output of the diff tool. Since there will be a

[PATCH] D34329: [GSoC] Clang AST diffing

johannes updated this revision to Diff 103147. johannes added a comment. - style fixes - do not compare nodes from system headers https://reviews.llvm.org/D34329 Files: include/clang/Tooling/ASTDiff/ASTDiff.h lib/Tooling/ASTDiff/ASTDiff.cpp lib/Tooling/ASTDiff/CMakeLists.txt

[PATCH] D34383: [Sema] PR32953: Fix hard crash of implicit instantiation of undefined template preceeded by scoped variable

hintonda created this revision. Reset ScopeSpec when parsing class, struct, etc.. Fixes PR32953. https://reviews.llvm.org/D34383 Files: lib/Parse/ParseDecl.cpp test/SemaTemplate/instantiate-complete.cpp Index: test/SemaTemplate/instantiate-complete.cpp

[PATCH] D16971: [Sema] PR26077 Fixed crash when partial specialization is missing required parameters

hintonda added a comment. ping... https://reviews.llvm.org/D16971 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r284060 - Implement MS _BitScan intrinsics

On Fri, Jun 16, 2017 at 5:08 PM, Duncan P. N. Exon Smith wrote: > > On Jun 16, 2017, at 11:02, Reid Kleckner wrote: > > We should fix it. > > > Agreed. > > We just need a new character code in the builtin function prototype > encoding. Currently there is no

r305764 - Turn off "disable free" mode when preprocessing imported module files in

Author: rsmith Date: Mon Jun 19 20:31:53 2017 New Revision: 305764 URL: http://llvm.org/viewvc/llvm-project?rev=305764=rev Log: Turn off "disable free" mode when preprocessing imported module files in -frewrite-imports mode. This could end up accumulating a very large amount of intermediate

Re: [PATCH] D34251: Add a new driver option to disable warning about c++17's non-throwing exception specification in function signature

On 19 June 2017 at 16:25, Duncan P. N. Exon Smith via Phabricator via cfe-commits wrote: > dexonsmith added a comment. > > > We use the `-Wc++NN-compat-` prefix on all the other subwarnings of > `-Wc++NN-compat` warnings > > Interesting; I thought I saw a

[PATCH] D34251: Add a new driver option to disable warning about c++17's non-throwing exception specification in function signature

dexonsmith added a comment. > We use the `-Wc++NN-compat-` prefix on all the other subwarnings of > `-Wc++NN-compat` warnings Interesting; I thought I saw a counter-example recently, and took that as the rule (although I can't for the life of me remember what it was).

[PATCH] D34251: Add a new driver option to disable warning about c++17's non-throwing exception specification in function signature

rsmith accepted this revision. rsmith added a comment. We use the `-Wc++NN-compat-` prefix on all the other subwarnings of `-Wc++NN-compat` warnings (examples: `-Wc++98-compat-bind-to-temporary-copy`, `-Wc++11-compat-reserved-user-defined-literal`, ...). I'd prefer to include the `-compat` in

r305758 - Support non-identifier module names when preprocessing modules.

Author: rsmith Date: Mon Jun 19 18:09:36 2017 New Revision: 305758 URL: http://llvm.org/viewvc/llvm-project?rev=305758=rev Log: Support non-identifier module names when preprocessing modules. Modified: cfe/trunk/include/clang/Basic/Module.h cfe/trunk/lib/Basic/Module.cpp

Re: r304081 - [coroutines] Mark cxx_status.html of Coroutines TS as (SVN)

I don't think we're quite done yet: we still seem to be missing serialization / deserialization support for coroutines. On 27 May 2017 at 15:54, Gor Nishanov via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: gornishanov > Date: Sat May 27 17:54:52 2017 > New Revision: 304081 > >

[PATCH] D34251: Add a new driver option to disable warning about c++17's non-throwing exception specification in function signature

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. I think `-Wc++1z-mangling` is best. IMO, with C++1z in the name, it's already clear that this is about compatibility. I also don't think we need to get as specific as

[PATCH] D34370: Fix for Bug 33471: Preventing operator auto from resolving to a template operator.

rsmith added inline comments. Comment at: lib/Sema/SemaLookup.cpp:870-872 +auto *Ty = +dyn_cast(R.getLookupName().getCXXNameType()); +if (Ty && Ty->isUndeducedType()) This is not sufficient to catch cases such as `operator auto*`, and one day

[PATCH] D34370: Fix for Bug 33471: Preventing operator auto from resolving to a template operator.

erichkeane created this revision. As the bug report says, struct A { template operator T(); }; void foo() { A().operator auto(); } causes: "undeduced type in IR-generation UNREACHABLE executed at llvm/tools/clang/lib/CodeGen/CodeGenFunction.cpp:208!" The problem is that in this case,

r305745 - [docs] Coverage: Improve the wording a bit

Author: vedantk Date: Mon Jun 19 16:26:04 2017 New Revision: 305745 URL: http://llvm.org/viewvc/llvm-project?rev=305745=rev Log: [docs] Coverage: Improve the wording a bit Modified: cfe/trunk/docs/SourceBasedCodeCoverage.rst Modified: cfe/trunk/docs/SourceBasedCodeCoverage.rst URL:

r305743 - [docs] Coverage: document issue with the BFD linker

Author: vedantk Date: Mon Jun 19 16:22:05 2017 New Revision: 305743 URL: http://llvm.org/viewvc/llvm-project?rev=305743=rev Log: [docs] Coverage: document issue with the BFD linker Modified: cfe/trunk/docs/SourceBasedCodeCoverage.rst Modified: cfe/trunk/docs/SourceBasedCodeCoverage.rst URL:

[PATCH] D34367: CodeGen: Fix address space of indirect function argument

yaxunl created this revision. The byval function argument is in alloca address space in LLVM IR. However, during Clang codegen for C++, the address space of indirect function argument should match its address space in the source code, even for byval argument. This is because destructor of the

[PATCH] D34353: [analyzer] Teach CloneDetection about Qt Meta-Object Compiler to filter auto generated files

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rL LLVM https://reviews.llvm.org/D34353 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34365: [FrontEnd] Allow overriding the default C/C++ -std via CMake vars

mgorny created this revision. Provide two new CMake cache variables -- CLANG_DEFAULT_STD_C and CLANG_DEFAULT_STD_CXX -- that can be used to override the default C/ObjC and C++/ObjC++ standards appropriately. They can be set to one of the identifiers from LangStandards.def, or left unset (the

[PATCH] D34304: Allow CompilerInvocations to generate .d files.

saugustine added a subscriber: klimek. saugustine added a comment. In https://reviews.llvm.org/D34304#783675, @klimek wrote: > I think a better way might be to generally leave dependency options alone, > add a default argument adapter to filter out all deps related flags, and > allow users to

r305738 - Typo fix: appropo -> apropos. NFC.

Author: aaronballman Date: Mon Jun 19 15:08:20 2017 New Revision: 305738 URL: http://llvm.org/viewvc/llvm-project?rev=305738=rev Log: Typo fix: appropo -> apropos. NFC. Modified: cfe/trunk/docs/Block-ABI-Apple.rst Modified: cfe/trunk/docs/Block-ABI-Apple.rst URL:

[PATCH] D34268: [clang] Fix format specifiers fixits for nested macros

alexshap updated this revision to Diff 103093. alexshap added a comment. update, rerun the tests Repository: rL LLVM https://reviews.llvm.org/D34268 Files: include/clang/Edit/EditedSource.h lib/Edit/EditedSource.cpp test/FixIt/fixit-format-darwin.m Index:

[PATCH] D34268: [clang] Fix format specifiers fixits for nested macros

alexshap planned changes to this revision. alexshap marked an inline comment as done. alexshap added a comment. probably we don't need to keep the entire expansion stack in MacroArgUse (i was doing that because it was easier to understand what's going on). I will update this diff soon.

[PATCH] D34268: [clang] Fix format specifiers fixits for nested macros

alexshap marked 3 inline comments as done. alexshap added inline comments. Comment at: lib/Edit/EditedSource.cpp:80 + return ArgUse.Identifier == U.Identifier && + std::tie(ArgUse.ExpansionStack, ArgUse.Use) != +

[PATCH] D34268: [clang] Fix format specifiers fixits for nested macros

alexshap updated this revision to Diff 103090. alexshap added a comment. Address code review comments Repository: rL LLVM https://reviews.llvm.org/D34268 Files: include/clang/Edit/EditedSource.h lib/Edit/EditedSource.cpp test/FixIt/fixit-format-darwin.m Index:

[PATCH] D32936: [clang] Add support for Ananas platform

ed added a comment. Final call: do any of you have any more feedback on this change? If not, I will go ahead and commit this change one of these days (together with https://reviews.llvm.org/D32937). Thanks, Ed https://reviews.llvm.org/D32936 ___

[PATCH] D34357: [Clang] Handle interaction of -pg and no_instrument_function attribute.

manojgupta added a comment. Thanks for the quick review. https://reviews.llvm.org/D34357 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r305728 - [Clang] Handle interaction of -pg and no_instrument_function attribute.

Author: manojgupta Date: Mon Jun 19 13:45:03 2017 New Revision: 305728 URL: http://llvm.org/viewvc/llvm-project?rev=305728=rev Log: [Clang] Handle interaction of -pg and no_instrument_function attribute. Summary: Disable generation of counting-function attribute if no_instrument_function

[PATCH] D34357: [Clang] Handle interaction of -pg and no_instrument_function attribute.

hfinkel accepted this revision. hfinkel added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D34357 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34357: [Clang] Handle interaction of -pg and no_instrument_function attribute.

manojgupta created this revision. Disable generation of counting-function attribute if no_instrument_function attribute is present in function. Interaction between -pg and no_instrument_function is the desired behavior and matches gcc as well. This is required for fixing a crash in Linux kernel

Re: r305665 - clang-format: Add capability to format the diff on save in vim.

Ah, nevermind - I hadn't sync'd this change! Sorry for the noise. Thanks for the feature! On Mon, Jun 19, 2017 at 11:18 AM David Blaikie wrote: > On Mon, Jun 19, 2017 at 12:30 AM Daniel Jasper via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: djasper >>

[PATCH] D26953: clang-format: handle formatting on constexpr if

thegameg added a comment. In https://reviews.llvm.org/D26953#783497, @jtbandes wrote: > Hm, I probably should've searched first — but I just re-implemented this in > https://reviews.llvm.org/D34330. Actually, I think my implementation solves > the `AllowShortIfStatementsOnASingleLine` issue

Re: r305665 - clang-format: Add capability to format the diff on save in vim.

On Mon, Jun 19, 2017 at 12:30 AM Daniel Jasper via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: djasper > Date: Mon Jun 19 02:30:04 2017 > New Revision: 305665 > > URL: http://llvm.org/viewvc/llvm-project?rev=305665=rev > Log: > clang-format: Add capability to format the diff on

[PATCH] D32642: [Analyzer] Iterator Checker - Part 2: Increment, decrement operators and ahead-of-begin checks

NoQ added a comment. I'm sorry, i'd try to get back to this and unblock your progress as soon as possible. One thing i notice is that you manipulate symbolic expressions manually, however many of the things that you need, eg stuff in your `compose()` method, seem to be already available in

[PATCH] D34268: [clang] Fix format specifiers fixits for nested macros

arphaman added inline comments. Comment at: include/clang/Edit/EditedSource.h:50 +// Location of argument use inside the top-level macro +SourceLocation Use; + I think a name like `UseLoc` is more appropriate. Comment at:

[PATCH] D31868: [analyzer] Check NULL pointer dereference issue for memset function

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thanks, this was very useful, please commit! Repository: rL LLVM https://reviews.llvm.org/D31868 ___ cfe-commits mailing list

[PATCH] D34185: [Parser][ObjC] Avoid crashing when skipping to EOF while parsing an ObjC interface/implementation

This revision was automatically updated to reflect the committed changes. arphaman marked an inline comment as done. Closed by commit rL305719: [Parser][ObjC] Use an artificial EOF token while parsing lexed ObjC methods (authored by arphaman). Changed prior to commit:

r305719 - [Parser][ObjC] Use an artificial EOF token while parsing lexed ObjC methods

Author: arphaman Date: Mon Jun 19 12:53:21 2017 New Revision: 305719 URL: http://llvm.org/viewvc/llvm-project?rev=305719=rev Log: [Parser][ObjC] Use an artificial EOF token while parsing lexed ObjC methods This change avoid a crash that occurred when skipping to EOF while parsing an ObjC

[PATCH] D33989: [OpenCL] Allow targets to select address space per type

yaxunl added inline comments. Comment at: include/clang/Basic/TargetInfo.h:1041 +default: + return LangAS::Default; +} Anastasia wrote: > bader wrote: > > yaxunl wrote: > > > bader wrote: > > > > yaxunl wrote: > > > > > I think the default

[PATCH] D32642: [Analyzer] Iterator Checker - Part 2: Increment, decrement operators and ahead-of-begin checks

baloghadamsoftware added a comment. Any progress in the review? https://reviews.llvm.org/D32642 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30691: [analyzer] Support for naive cross translational unit analysis

dkrupp added a comment. Thanks. > It would be best to just add the scan-build-py support to the tree, > especially, since the new scrips are not tested. OK. We will update this patch with the scan-build-py changes and remove the ctu-build.py and ctu-analyze.py scripts. > I am curious which

[PATCH] D34264: Introduce -Wunguarded-availability-new, which is like -Wunguarded-availability, except that it's enabled by default for new deployment targets

arphaman added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:7031 +Introduced) && +!S.Diags.isIgnored(diag::warn_unguarded_availability_new, Loc); +diag = NewWarning ? diag::warn_partial_availability_new erik.pilkington wrote: >

Clang Compile with Libtool

Hi I am working on some Clang source-to-source transformation. I am doing it from Clang source code: clang/tools/extra. What I do is that I am adding a printf("Hello World\n"); at the beginning of the main method. It works perfectly, I run my tool as bin/add-code ../../test/hello.c and it

[PATCH] D34277: [analyzer] Bump default performance thresholds?

a.sidorin accepted this revision. a.sidorin added a comment. Ok, I hope this will work. Anyway, we can always revert this patch in case of any problems. https://reviews.llvm.org/D34277 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34024: [OpenCL] Diagnose scoped address-space qualified variables

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Small comment in the test can be addressed in commit! Comment at: test/SemaOpenCL/storageclass.cl:52 +kernel void invalidScope() { + if (true) { +local int

[PATCH] D34235: [OpenCL] Fix OpenCL and SPIR version metadata generation.

bader added inline comments. Comment at: test/CodeGenOpenCL/spir_version.cl:13 kernel void foo() {} +kernel void bar() {} Anastasia wrote: > Would the original code produce duplicate version metadata here or is it just > for overloaded functions? Would it

[PATCH] D34185: [Parser][ObjC] Avoid crashing when skipping to EOF while parsing an ObjC interface/implementation

ahatanak added a comment. Thanks, LGTM. Comment at: lib/Parse/ParseObjc.cpp:3636 + Eof.setEofData(MCDecl); + Eof.setLocation(Tok.getLocation()); + LM.Toks.push_back(Eof); You can use OrigLoc instead of calling Tok.getLocation(). Repository: rL LLVM

[PATCH] D33989: [OpenCL] Allow targets to select address space per type

Anastasia added inline comments. Comment at: include/clang/Basic/TargetInfo.h:1041 +default: + return LangAS::Default; +} bader wrote: > yaxunl wrote: > > bader wrote: > > > yaxunl wrote: > > > > I think the default (including even_t, clk_event_t,

[PATCH] D33706: CodeGen: Cast temporary variable to proper address space

This revision was automatically updated to reflect the committed changes. Closed by commit rL305711: CodeGen: Cast temporary variable to proper address space (authored by yaxunl). Changed prior to commit: https://reviews.llvm.org/D33706?vs=101227=103070#toc Repository: rL LLVM

[PATCH] D34235: [OpenCL] Fix OpenCL and SPIR version metadata generation.

Anastasia added inline comments. Comment at: test/CodeGenOpenCL/spir_version.cl:13 kernel void foo() {} +kernel void bar() {} Would the original code produce duplicate version metadata here or is it just for overloaded functions? Would it make sense to add

r305711 - CodeGen: Cast temporary variable to proper address space

Author: yaxunl Date: Mon Jun 19 12:03:41 2017 New Revision: 305711 URL: http://llvm.org/viewvc/llvm-project?rev=305711=rev Log: CodeGen: Cast temporary variable to proper address space In C++ all variables are in default address space. Previously change has been made to cast automatic variables

[PATCH] D33383: [GSoC] Flag value completion for clang

ruiu added inline comments. Comment at: clang/include/clang/Driver/Options.td:496 def cl_std_EQ : Joined<["-"], "cl-std=">, Group, Flags<[CC1Option]>, - HelpText<"OpenCL language standard to compile for.">; + HelpText<"OpenCL language standard to compile for.">,

[PATCH] D34277: [analyzer] Bump default performance thresholds?

xazax.hun added a comment. While I have no objections, I am wondering whether this is the good way to spend the performance budget. In particular, there are patches to generate more symbolic expressions, that could also degrade the performance (but fix some fixmes along the way).

[PATCH] D33304: [clang-tidy][Part1] Add a new module Android and three new checks.

yawanng updated this revision to Diff 103068. yawanng marked 3 inline comments as done. https://reviews.llvm.org/D33304 Files: clang-tidy/CMakeLists.txt clang-tidy/android/AndroidTidyModule.cpp clang-tidy/android/CMakeLists.txt clang-tidy/android/FileOpenFlagCheck.cpp

[PATCH] D34263: [preprocessor] When preprocessor option 'SingleFileParseMode' is enabled, parse all directive blocks if the condition uses undefined macros

akyrtzi updated this revision to Diff 103067. akyrtzi added a comment. Update doc-comment for `Preprocessor::EvaluateDirectiveExpression` https://reviews.llvm.org/D34263 Files: include/clang/Lex/Preprocessor.h include/clang/Lex/PreprocessorOptions.h lib/Lex/PPDirectives.cpp

[PATCH] D34263: [preprocessor] When preprocessor option 'SingleFileParseMode' is enabled, parse all directive blocks if the condition uses undefined macros

akyrtzi updated this revision to Diff 103066. akyrtzi added a comment. Provide doc-comments for `struct DirectiveEvalResult`. https://reviews.llvm.org/D34263 Files: include/clang/Lex/Preprocessor.h include/clang/Lex/PreprocessorOptions.h lib/Lex/PPDirectives.cpp

[PATCH] D34266: Static Analyzer - Localizability Checker: New Localizable APIs for macOS High Sierra & iOS 11

kulpreet added a comment. In https://reviews.llvm.org/D34266#783156, @zaks.anna wrote: > Thanks! Do you have commit access? No problem! I don’t have commit access. In the past, Devin has commited on my behalf. Repository: rL LLVM https://reviews.llvm.org/D34266

[PATCH] D34263: [preprocessor] When preprocessor option 'SingleFileParseMode' is enabled, parse all directive blocks if the condition uses undefined macros

akyrtzi added a comment. In https://reviews.llvm.org/D34263#783770, @voskresensky.vladimir wrote: > What I find problematic in this patch is PPOpts->SingleFileParseMode checks. > Let's suppose we implement what I mentioned above => how is it going to > co-exist nicely? I think code will be

[PATCH] D34264: Introduce -Wunguarded-availability-new, which is like -Wunguarded-availability, except that it's enabled by default for new deployment targets

erik.pilkington added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:7031 +Introduced) && +!S.Diags.isIgnored(diag::warn_unguarded_availability_new, Loc); +diag = NewWarning ? diag::warn_partial_availability_new Sorry to keep this

[PATCH] D34353: [analyzer] Teach CloneDetection about Qt Meta-Object Compiler to filter auto generated files

xiangzhai created this revision. Herald added a subscriber: xazax.hun. Hi LLVM developers, As Raphael suggested in https://reviews.llvm.org/D31320 I renamed `AutoGeneratedCloneConstraint` to `FilenamePatternConstraint`, please review it, thanks a lot! Regards, Leslie Zhai Repository: rL

[PATCH] D34263: [preprocessor] When preprocessor option 'SingleFileParseMode' is enabled, parse all directive blocks if the condition uses undefined macros

akyrtzi added a comment. In https://reviews.llvm.org/D34263#783694, @klimek wrote: > how many patches for single file mode are coming down the road, though? I'm > somewhat concerned about the overall complexity it'll add to clang. There is no other patch for using this preprocessor option.

[PATCH] D34342: [OpenCL] Fix code generation of function-scope constant samplers.

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. https://reviews.llvm.org/D34342 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34238: clang-format: Do not binpack initialization lists

Typz updated this revision to Diff 103057. Typz added a comment. Fix indentation https://reviews.llvm.org/D34238 Files: lib/Format/ContinuationIndenter.cpp unittests/Format/FormatTest.cpp unittests/Format/FormatTestJava.cpp Index: unittests/Format/FormatTestJava.cpp

[PATCH] D34342: [OpenCL] Fix code generation of function-scope constant samplers.

bader added inline comments. Comment at: test/CodeGenOpenCL/sampler.cl:62 + + const sampler_t const_smp = CLK_ADDRESS_CLAMP_TO_EDGE | CLK_NORMALIZED_COORDS_TRUE | CLK_FILTER_LINEAR; + // CHECK: [[CONST_SAMP:%[0-9]+]] = call %opencl.sampler_t addrspace(2)*

[PATCH] D34238: clang-format: Do not binpack initialization lists

Typz updated this revision to Diff 103056. Typz added a comment. Fix case where the content fits on a line, by wrapping after each comma, like this: static int types[] = { 0, 1, 2, }; https://reviews.llvm.org/D34238 Files:

[PATCH] D34287: Moved code hanlding precompiled preamble out of the ASTUnit.

ilya-biryukov added inline comments. Comment at: include/clang/Frontend/PrecompiledPreamble.h:42-43 +/// destructors. +/// An assertion will fire if two PCHTempFiles are created with the same name, +/// so it's not intended to be used outside preamble-handling. +class

[PATCH] D34351: [clang-format] Simplify TT_SelectorName assignment logic

djasper added a comment. For the test introduced in https://reviews.llvm.org/rL262291, either of the changes causes a TT_SelectorName to become a TT_Unknown. So lets figure out how to make this a difference in observable formatting behavior instead of removing these checks.

[PATCH] D34287: Moved code hanlding precompiled preamble out of the ASTUnit.

ilya-biryukov updated this revision to Diff 103053. ilya-biryukov marked 2 inline comments as done. ilya-biryukov added a comment. - Added default initializers to PreambleFileHash. - Update file comments to address klimek's questions. https://reviews.llvm.org/D34287 Files:

[PATCH] D34279: Fix release_40 build with MSVC (VS 2015)

hans added a comment. I have 19.00.24210, so slightly earlier I suppose, but I believe we use Update 3 on our Chromium buildbots, and they seem happy. Can you paste the full error message? The part I see in your screenshot doesn't really make sense. Why should converting 1 to unsigned int be a

[PATCH] D34329: [GSoC] Clang AST diffing

arphaman added a comment. Generally we shouldn't have untested code in trunk, so I think that we need to find a way to test this before committing. We can start off by testing the output of the diff tool. Since there will be a lot of changes in the future, you don't have to have everything

[PATCH] D34329: [GSoC] Clang AST diffing

arphaman added inline comments. Comment at: lib/Tooling/ASTDiff/ASTDiff.cpp:277 +Mappings::~Mappings() { + delete[] SrcToDst; + delete[] DstToSrc; Please use `std::unique_ptr` for `SrcToDst` and `DstToSrc` as well and remove the destructor.

[PATCH] D34329: [GSoC] Clang AST diffing

arphaman added a comment. Congratulations of the first GSoC patch! I have some below comments: - Patches should be submitted using the full context (`git diff -U`). This makes it easier for reviewers to understand the change. This patch mainly adds new code, so this won't make much

[PATCH] D34351: Simplify TT_SelectorName assignment logic

krasimir created this revision. Herald added a subscriber: klimek. While trying to understand TT_SelectorName, I found 2 redundant checks. Removing them doesn't cause any tests to fail. https://reviews.llvm.org/D34351 Files: lib/Format/TokenAnnotator.cpp Index:

[PATCH] D34342: [OpenCL] Fix code generation of function-scope constant samplers.

yaxunl added inline comments. Comment at: test/CodeGenOpenCL/sampler.cl:62 + + const sampler_t const_smp = CLK_ADDRESS_CLAMP_TO_EDGE | CLK_NORMALIZED_COORDS_TRUE | CLK_FILTER_LINEAR; + // CHECK: [[CONST_SAMP:%[0-9]+]] = call %opencl.sampler_t addrspace(2)*

[PATCH] D33491: clang-format: Fix C99 designated initializers corner cases

This revision was automatically updated to reflect the committed changes. Closed by commit rL305696: clang-format: Fix C99 designated initializers corner cases (authored by Typz). Changed prior to commit: https://reviews.llvm.org/D33491?vs=103018=103041#toc Repository: rL LLVM

r305696 - clang-format: Fix C99 designated initializers corner cases

Author: typz Date: Mon Jun 19 09:41:21 2017 New Revision: 305696 URL: http://llvm.org/viewvc/llvm-project?rev=305696=rev Log: clang-format: Fix C99 designated initializers corner cases Summary: This fixes the missing space before the designated initializer when `Cpp11BracedListStyle=false` :

[PATCH] D33278: [LLVM][x86][Inline Asm] - Enum support for MS syntax

mharoush added a comment. ping Repository: rL LLVM https://reviews.llvm.org/D33278 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34249: [libc++] Don't use UTIME_OMIT to detect utimensat on Apple

mclow.lists added inline comments. Comment at: src/experimental/filesystem/operations.cpp:27 +// We can use the presence of UTIME_OMIT to detect platforms that do not +// provide utimensat, with some exceptions on OS X. +#if !defined(UTIME_OMIT) ||

[PATCH] D33383: [GSoC] Flag value completion for clang

ruiu accepted this revision. ruiu added a comment. LGTM https://reviews.llvm.org/D33383 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33823: [clang-format] Support sorting using declarations

krasimir added inline comments. Comment at: lib/Format/UsingDeclarationsSorter.cpp:66 + } + return HasIdentifier && Tok && Tok->isOneOf(tok::semi, tok::comma); +} Typz wrote: > could also be followed by an assignment, in case of type alias: > > using foo =

[PATCH] D33823: [clang-format] Support sorting using declarations

krasimir updated this revision to Diff 103032. krasimir added a comment. - Update test case https://reviews.llvm.org/D33823 Files: include/clang/Format/Format.h lib/Format/CMakeLists.txt lib/Format/Format.cpp lib/Format/UsingDeclarationsSorter.cpp lib/Format/UsingDeclarationsSorter.h

[PATCH] D33491: clang-format: Fix C99 designated initializers corner cases

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good. https://reviews.llvm.org/D33491 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D33823: [clang-format] Support sorting using declarations

krasimir updated this revision to Diff 103031. krasimir marked 3 inline comments as done. krasimir added a comment. - Address review comments https://reviews.llvm.org/D33823 Files: include/clang/Format/Format.h lib/Format/CMakeLists.txt lib/Format/Format.cpp

r305688 - Revert "[NFC] Refactor DiagnosticRenderer to use FullSourceLoc"

Author: christof Date: Mon Jun 19 07:41:22 2017 New Revision: 305688 URL: http://llvm.org/viewvc/llvm-project?rev=305688=rev Log: Revert "[NFC] Refactor DiagnosticRenderer to use FullSourceLoc" This reverts commit 305684. This patch breaks extra/tools/clang-tidy Modified:

r305685 - Move the test from r305678 to a separte file with 'REQUIRES: system-darwin'

Author: arphaman Date: Mon Jun 19 07:13:59 2017 New Revision: 305685 URL: http://llvm.org/viewvc/llvm-project?rev=305685=rev Log: Move the test from r305678 to a separte file with 'REQUIRES: system-darwin' Otherwise it will fail on non-macOS systems. Added:

r305684 - [NFC] Refactor DiagnosticRenderer to use FullSourceLoc

Author: christof Date: Mon Jun 19 07:05:58 2017 New Revision: 305684 URL: http://llvm.org/viewvc/llvm-project?rev=305684=rev Log: [NFC] Refactor DiagnosticRenderer to use FullSourceLoc Move the DiagnosticRenderer and its dependents to using FullSourceLocs instead of a SourceLocation and

[PATCH] D31709: [NFC] Refactor DiagnosticRenderer to use FullSourceLoc

christof added a comment. I'll go ahead and commit this on the grounds that it was already approved and the changes I made were the last nit-picks of @rnk https://reviews.llvm.org/D31709 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D33491: clang-format: Fix C99 designated initializers corner cases

Typz added inline comments. Comment at: unittests/Format/FormatTest.cpp:1526 + verifyFormat("const struct A a = {[0] = 1, [1] = 2};"); + verifyFormat("const struct A a = {[1] = a,\n" + "[2] = b,\n" djasper

[PATCH] D33491: clang-format: Fix C99 designated initializers corner cases

Typz updated this revision to Diff 103018. Typz marked 2 inline comments as done. Typz edited the summary of this revision. Typz added a comment. Fix review comments https://reviews.llvm.org/D33491 Files: lib/Format/ContinuationIndenter.cpp lib/Format/FormatToken.h

[PATCH] D33644: Add default values for function parameter chunks

yvvan updated this revision to Diff 103016. yvvan added a comment. Do not evaluate numbers. Check for != "=" is needed not to mess with invalid default arguments or their types (without it I get "const Bar& bar = =" when Bar is not defined) https://reviews.llvm.org/D33644 Files:

[PATCH] D34185: [Parser][ObjC] Avoid crashing when skipping to EOF while parsing an ObjC interface/implementation

arphaman updated this revision to Diff 103013. arphaman marked an inline comment as done. arphaman added a comment. Remove the old checks and consume EOF unconditionally. Repository: rL LLVM https://reviews.llvm.org/D34185 Files: lib/Parse/ParseObjc.cpp

[PATCH] D34185: [Parser][ObjC] Avoid crashing when skipping to EOF while parsing an ObjC interface/implementation

arphaman marked an inline comment as done. arphaman added inline comments. Comment at: lib/Parse/ParseObjc.cpp:220 CheckNestedObjCContexts(AtLoc); + if (isEofOrEom()) +return nullptr; ahatanak wrote: > Do you need this check here (and below)? Not

r305680 - Add missing OS check to r305678

Author: arphaman Date: Mon Jun 19 06:25:37 2017 New Revision: 305680 URL: http://llvm.org/viewvc/llvm-project?rev=305680=rev Log: Add missing OS check to r305678 That commit failed on non-macOS buildbots as I've forgotten to make sure that the system on which Clang is running on is actually

[PATCH] D33945: [OpenCL] Add support for missing sub_group functions.

bader requested changes to this revision. bader added a comment. This revision now requires changes to proceed. Please, split this patch into two parts: 1. Improve diagnostics on extension enabling. 2. Add missing `sub_group_*` built-in functions. Comment at:

[PATCH] D34175: [driver][macOS] Pick the system version for the deployment target if the SDK is newer than the system

This revision was automatically updated to reflect the committed changes. Closed by commit rL305678: [driver][macOS] Pick the system version for the deployment target (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D34175?vs=102607=103009#toc Repository: rL LLVM

r305678 - [driver][macOS] Pick the system version for the deployment target

Author: arphaman Date: Mon Jun 19 05:57:27 2017 New Revision: 305678 URL: http://llvm.org/viewvc/llvm-project?rev=305678=rev Log: [driver][macOS] Pick the system version for the deployment target if the SDK is newer than the system This commit improves the driver by making sure that it picks the

[PATCH] D33491: clang-format: Fix C99 designated initializers corner cases

djasper added inline comments. Comment at: lib/Format/TokenAnnotator.cpp:339 Left->Type = TT_JsComputedPropertyName; + } else if ((Style.Language == FormatStyle::LK_Cpp || + Style.Language == FormatStyle::LK_ObjC) && Use

[PATCH] D31320: [analyzer] Teach CloneDetection about Qt Meta-Object Compiler

teemperor added inline comments. Comment at: cfe/trunk/include/clang/Analysis/CloneDetection.h:324 +struct AutoGeneratedCloneConstraint { + StringRef IgnoredFilesPattern; xiangzhai wrote: > v.g.vassilev wrote: > > Shouldn't the name be more generic. What this

[PATCH] D33383: [GSoC] Flag value completion for clang

teemperor accepted this revision. teemperor added a comment. LGTM. https://reviews.llvm.org/D33383 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   >