bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
This looks good. Sorry for the long wait, do you have commit access?
https://reviews.llvm.org/D36390
___
cfe-commits mailing list
cfe-commits@l
klimek added a comment.
Just FYI, I talked with Richard and he'll not get to it before next week. Hope
that's fine.
https://reviews.llvm.org/D5767
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
yvvan added a comment.
@bkramer Not yet, it would be good to have one though :)
https://reviews.llvm.org/D36390
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: hokein
Date: Thu Oct 26 01:23:20 2017
New Revision: 316643
URL: http://llvm.org/viewvc/llvm-project?rev=316643&view=rev
Log:
[clang-tidy ObjC] [1/3] New module `objc` for Objective-C checks
Summary:
This is part 1 of 3 of a series of changes to improve Objective-C
linting in clang-tidy.
ioeric added inline comments.
Comment at: include/clang/Tooling/Execution.h:76
+
+ void appendArgumentsAdjuster(ArgumentsAdjuster Adjuster);
+
klimek wrote:
> I think the argument adjuster adjustment shouldn't be part of this interface,
> as the argument adjust
ioeric updated this revision to Diff 120370.
ioeric marked 2 inline comments as done.
ioeric added a comment.
- Addressed review comments o Removed argument adjusting interfaces from
ExecutionContext o Switched positions of Action and Adjuster parameters in the
`execute` interfaces
https://rev
Author: hokein
Date: Thu Oct 26 01:37:25 2017
New Revision: 316645
URL: http://llvm.org/viewvc/llvm-project?rev=316645&view=rev
Log:
[clang-tidy ObjC] [2/3] Support non-C++ files in ClangTidyTest
Summary:
This is part 2 of 3 of a series of changes to improve
Objective-C linting in clang-tidy.
Cu
Author: d0k
Date: Thu Oct 26 01:41:28 2017
New Revision: 316646
URL: http://llvm.org/viewvc/llvm-project?rev=316646&view=rev
Log:
Fix overloaded static functions in SemaCodeComplete
https://bugs.llvm.org/show_bug.cgi?id=33904
Happens when static function is accessed via the class variable. That l
This revision was automatically updated to reflect the committed changes.
Closed by commit rL316646: Fix overloaded static functions in SemaCodeComplete
(authored by d0k).
Changed prior to commit:
https://reviews.llvm.org/D36390?vs=111647&id=120374#toc
Repository:
rL LLVM
https://reviews.ll
r.stahl accepted this revision.
r.stahl added a comment.
This revision is now accepted and ready to land.
I'm gonna go ahead and approve this now, because I reported the issue. Note
that I'm not a regular contributor, yet!
Comment at: lib/CrossTU/CrossTranslationUnit.cpp:99
fhahn added a comment.
Could you upload a diff with more context, as suggested in
http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface?
That would make it easier to review the patch.
Repository:
rL LLVM
https://reviews.llvm.org/D39321
__
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D34272
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
Author: d0k
Date: Thu Oct 26 03:03:11 2017
New Revision: 316649
URL: http://llvm.org/viewvc/llvm-project?rev=316649&view=rev
Log:
[clangd] Add a simple fuzzer. It crashes a lot :)
Added:
clang-tools-extra/trunk/clangd/fuzzer/
clang-tools-extra/trunk/clangd/fuzzer/CMakeLists.txt
clang-
Author: d0k
Date: Thu Oct 26 03:07:04 2017
New Revision: 316650
URL: http://llvm.org/viewvc/llvm-project?rev=316650&view=rev
Log:
[clangd] Don't use /// for non-doxygen comments.
Modified:
clang-tools-extra/trunk/clangd/fuzzer/ClangdFuzzer.cpp
clang-tools-extra/trunk/clangd/tool/ClangdMai
mstorsjo updated this revision to Diff 120380.
mstorsjo added a comment.
Simplified the assembly by sharing much more code between the unix and win64
paths, added a padding element to ensure more stable struct packing.
https://reviews.llvm.org/D38819
Files:
docs/index.rst
include/__libunwi
Author: d0k
Date: Thu Oct 26 03:36:20 2017
New Revision: 316652
URL: http://llvm.org/viewvc/llvm-project?rev=316652&view=rev
Log:
[clangd] Don't crash on empty textDocument/didChange.
Found by clangd-fuzzer.
Modified:
clang-tools-extra/trunk/clangd/ClangdLSPServer.cpp
clang-tools-extra/t
This revision was automatically updated to reflect the committed changes.
Closed by commit rL316653: [Tooling] A new framework for executing clang
frontend actions. (authored by ioeric).
Repository:
rL LLVM
https://reviews.llvm.org/D34272
Files:
cfe/trunk/include/clang/Tooling/CommonOptions
Author: ioeric
Date: Thu Oct 26 03:38:14 2017
New Revision: 316653
URL: http://llvm.org/viewvc/llvm-project?rev=316653&view=rev
Log:
[Tooling] A new framework for executing clang frontend actions.
Summary:
This defines a `clang::tooling::ToolExecutor` interface that can be extended to
support di
Author: psmith
Date: Thu Oct 26 05:02:03 2017
New Revision: 316657
URL: http://llvm.org/viewvc/llvm-project?rev=316657&view=rev
Log:
[libunwind] Always use unwind tables in tests
For many targets setting -fno-exceptions will prevent unwinding tables from
being generated for the test programs.
Author: aaronballman
Date: Thu Oct 26 05:19:02 2017
New Revision: 316658
URL: http://llvm.org/viewvc/llvm-project?rev=316658&view=rev
Log:
Add a new attribute definition spelling, Clang<"attr">, that expands to two
attribute spellings: GNU<"attr"> and CXX11<"clang", "attr">. This is similar to
h
Author: d0k
Date: Thu Oct 26 05:28:13 2017
New Revision: 316659
URL: http://llvm.org/viewvc/llvm-project?rev=316659&view=rev
Log:
[clangd] Report an error on findDefinitions/signatureHelp on an unopened file
instead of crashing.
Found by clangd-fuzzer.
Modified:
clang-tools-extra/trunk/clan
FlameTop added a comment.
Hello, I'm afraid this commit is failing on Windows.
http://lab.llvm.org:8011/console?builder=llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast&builder=llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast
FAIL: Clang-Unit ::
Tooling/./ToolingTests.exe/StandaloneToolTest.SimpleAct
kosarev abandoned this revision.
kosarev added a comment.
OK, thanks.
Repository:
rL LLVM
https://reviews.llvm.org/D39138
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kosarev added a comment.
I suspect this is supposed to be in this diff:
In https://reviews.llvm.org/D38796#906887, @rjmccall wrote:
> I think probably the best solution is to track may-alias-ness explicitly in
> the TBAAAccessInfo instead of relying in the frontend on being able to
> distingui
bjope added a comment.
I get errors when compiling due to this commit:
FAILED:
tools/clang/lib/Tooling/CMakeFiles/clangTooling.dir/StandaloneExecution.cpp.o
/repo/app/clang/3.6/bin/clang++ -march=corei7 -DGTEST_HAS_RTTI=0 -D_DEBUG
-D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MA
Sorry about that! I'm fixing these now...
On Thu, Oct 26, 2017 at 2:50 PM Bjorn Pettersson via Phabricator <
revi...@reviews.llvm.org> wrote:
> bjope added a comment.
>
> I get errors when compiling due to this commit:
>
> FAILED:
> tools/clang/lib/Tooling/CMakeFiles/clangTooling.dir/Standalone
Author: ioeric
Date: Thu Oct 26 06:09:50 2017
New Revision: 316661
URL: http://llvm.org/viewvc/llvm-project?rev=316661&view=rev
Log:
Try to fix warnings and windows test failures caused by r316653
Modified:
cfe/trunk/lib/Tooling/StandaloneExecution.cpp
cfe/trunk/unittests/Tooling/Executio
r316661 should fix these (hopefully!).
On Thu, Oct 26, 2017 at 3:03 PM Eric Liu wrote:
> Sorry about that! I'm fixing these now...
>
>
> On Thu, Oct 26, 2017 at 2:50 PM Bjorn Pettersson via Phabricator <
> revi...@reviews.llvm.org> wrote:
>
>> bjope added a comment.
>>
>> I get errors when compi
Hi Eric,
This seems to have broken clang-cmake-thumbv7-a15 buildbot [*]. Would you
please investigate?
Or did you fix this while I was writing this email in 316661 :-) ?
Thank you,
[*] http://lab.llvm.org:8011/builders/clang-cmake-thumbv7-a15/builds/12511
--
Maxim Kuvyrkov
www.linaro.org
MTC updated this revision to Diff 120401.
MTC marked an inline comment as done.
MTC added a comment.
Split the long "expected" line into multiple lines.
https://reviews.llvm.org/D37187
Files:
lib/StaticAnalyzer/Core/PathDiagnostic.cpp
test/Analysis/loop-widening-notes.c
Index: test/Analy
Hi Maxim,
Thanks for the email! I'll look into this right now.
Thanks,
Eric
On Thu, Oct 26, 2017 at 3:11 PM Maxim Kuvyrkov
wrote:
> Hi Eric,
>
> This seems to have broken clang-cmake-thumbv7-a15 buildbot [*]. Would you
> please investigate?
>
> Or did you fix this while I was writing this ema
Am 2017-10-26 06:07, schrieb Benjamin Kramer via cfe-commits:
Author: d0k
Date: Thu Oct 26 03:07:04 2017
New Revision: 316650
URL: http://llvm.org/viewvc/llvm-project?rev=316650&view=rev
Log:
[clangd] Don't use /// for non-doxygen comments.
Modified:
clang-tools-extra/trunk/clangd/fuzzer/Cl
Author: lebedevri
Date: Thu Oct 26 06:18:14 2017
New Revision: 316662
URL: http://llvm.org/viewvc/llvm-project?rev=316662&view=rev
Log:
[Sema] -Wzero-as-null-pointer-constant: don't warn for system macros other than
NULL.
Summary:
The warning was initially introduced in D32914 by @thakis,
and th
This revision was automatically updated to reflect the committed changes.
Closed by commit rL316662: [Sema] -Wzero-as-null-pointer-constant: don't warn
for system macros other than… (authored by lebedevri).
Changed prior to commit:
https://reviews.llvm.org/D38954?vs=120316&id=120402#toc
Reposi
kosarev added a comment.
Yes, I don't like it too when it comes to comparing pointers to metadata nodes
in an attempt to figure out what kind of access we are dealing with.
What concerns me is that there may be other kinds of TBAA descriptors that are
neither ordinary nor may-alias ones. For ex
sepavloff updated this revision to Diff 120403.
sepavloff added a comment.
Addressed reviewer's notes
- Do not process binary directory separately but add it to the array of search
directories.
- Do not use result file name buffer for temporary data.
https://reviews.llvm.org/D24933
Files:
d
sepavloff marked 4 inline comments as done.
sepavloff added inline comments.
Comment at: lib/Driver/Driver.cpp:637
+ }
+ FilePath.clear();
+ return false;
hfinkel wrote:
> Why do we do clear FilePath here?
The intent was to avoid copying file name buffer. It h
hans created this revision.
This adds two flags:
-fno-cygprofile-exit Don't insert any calls for function exit.
-fno-cygprofile-args Don't pass any arguments to the cygprofile functions (the
implementer has to figure out the caller address themselves)
These are useful for reducing the size and
sammccall added a comment.
In https://reviews.llvm.org/D39057#906297, @ilya-biryukov wrote:
> There's another patch (https://reviews.llvm.org/D39276) that tries to add
> `workspace/executeCommand` for a slightly different use-case.
> Could we take the code for parsing/handling `workspace/execut
On Thu, Oct 26, 2017 at 3:16 PM, Jonas Hahnfeld wrote:
> Am 2017-10-26 06:07, schrieb Benjamin Kramer via cfe-commits:
>>
>> Author: d0k
>> Date: Thu Oct 26 03:07:04 2017
>> New Revision: 316650
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=316650&view=rev
>> Log:
>> [clangd] Don't use /// fo
baloghadamsoftware updated this revision to Diff 120408.
baloghadamsoftware added a comment.
Updated according to comments.
https://reviews.llvm.org/D39121
Files:
clang-tidy/bugprone/BugproneTidyModule.cpp
clang-tidy/bugprone/CMakeLists.txt
clang-tidy/bugprone/MisplacedOperatorInStrlenInA
lebedev.ri updated this revision to Diff 120407.
lebedev.ri marked 3 inline comments as done.
lebedev.ri added a comment.
Rebased.
Tighten matchers.
Add an assert that the function we matched does have the body (the check
analyses the function bodies, so if there is no body, there is nothing to d
lebedev.ri added inline comments.
Comment at: clang-tidy/readability/FunctionCognitiveComplexityCheck.cpp:499
+ functionDecl(
+ allOf(isDefinition(), unless(anyOf(isInstantiated(), isImplicit()
+ .bind("func"),
aaron.ballman wrote:
> Si
Author: rengolin
Date: Thu Oct 26 06:53:36 2017
New Revision: 316664
URL: http://llvm.org/viewvc/llvm-project?rev=316664&view=rev
Log:
Merging r316657: fixing libunwind tests
Modified:
libunwind/branches/release_50/test/libunwind/test/config.py
Modified: libunwind/branches/release_50/test/li
aaron.ballman added inline comments.
Comment at: clang-tidy/bugprone/MisplacedOperatorInStrlenInAllocCheck.cpp:64-67
+ const auto StrLenText = Lexer::getSourceText(
+ CharSourceRange::getTokenRange(StrLen->getSourceRange()),
+ *Result.SourceManager, getLangOpts());
+
It's not intended, but r316661 indeed fixed
http://lab.llvm.org:8011/builders/clang-cmake-thumbv7-a15 ;)
On Thu, Oct 26, 2017 at 3:16 PM Eric Liu wrote:
> Hi Maxim,
>
> Thanks for the email! I'll look into this right now.
>
> Thanks,
> Eric
>
> On Thu, Oct 26, 2017 at 3:11 PM Maxim Kuvyrkov
> w
bsdjhb added a comment.
I think one source of truth is better than two. I do find the constant's value
a bit off in general though. That is, the name 'HIGHEST' implies to me that it
is the highest value used, not N + 1 as we currently define it.
https://reviews.llvm.org/D39281
___
ABataev added a comment.
Tests?
Comment at: include/clang/Basic/LangOptions.def:193
LANGOPT(OpenMPUseTLS , 1, 0, "Use TLS for threadprivates or runtime
calls")
+LANGOPT(OpenMPImplicitDeclareTarget , 1, 0, "Enable implicit declare target
extension - marks automatically d
Author: kastiglione
Date: Thu Oct 26 08:53:37 2017
New Revision: 316670
URL: http://llvm.org/viewvc/llvm-project?rev=316670&view=rev
Log:
Add objcCategoryImplDecl matcher
Summary:
Add `objcCategoryImplDecl` which matches ObjC category definitions
(`@implementation`). This matcher complements `obj
This revision was automatically updated to reflect the committed changes.
Closed by commit rL316670: Add objcCategoryImplDecl matcher (authored by
kastiglione).
Changed prior to commit:
https://reviews.llvm.org/D39293?vs=120269&id=120431#toc
Repository:
rL LLVM
https://reviews.llvm.org/D392
aprantl added a comment.
Thanks! This looks generally good, I have one pending question inline.
Comment at: test/CodeGenObjC/debug-info-blocks.m:13
-// rdar://problem/14386148
-// Test that we don't emit bogus line numbers for the helper functions.
-// Test that we do emit sc
kosarev updated this revision to Diff 120428.
kosarev added a comment.
- Referencee's renamed to pointee's.
- EmitLoadOfReference() and EmitLoadOfReferenceLValue() reworked to take
reference lvalues.
https://reviews.llvm.org/D39177
Files:
lib/CodeGen/CGBlocks.cpp
lib/CodeGen/CGExpr.cpp
l
JDevlieghere added inline comments.
Comment at: lib/CodeGen/CGBlocks.cpp:1651
StartFunction(FD, C.VoidTy, Fn, FI, args);
- // Create a scope with an artificial location for the body of this function.
- auto AL = ApplyDebugLocation::CreateArtificial(*this);
+ ApplyDebugLocat
smeenai added a comment.
> And lld currently silently mislinks inputs with .ctors sections
Is there a bug for this? I see https://bugs.llvm.org/show_bug.cgi?id=31224,
which links to https://reviews.llvm.org/D35509, but neither seems active.
https://reviews.llvm.org/D39317
__
*the wrong thing
On Thu, Oct 26, 2017 at 12:43 PM, Nico Weber wrote:
> I don't know of one. ruiu said he's considering making lld error out on
> mixed init_array + ctors instead of having it silently do the same thing.
>
> On Thu, Oct 26, 2017 at 12:28 PM, Shoaib Meenai via Phabricator via
> cfe
I don't know of one. ruiu said he's considering making lld error out on
mixed init_array + ctors instead of having it silently do the same thing.
On Thu, Oct 26, 2017 at 12:28 PM, Shoaib Meenai via Phabricator via
cfe-commits wrote:
> smeenai added a comment.
>
> > And lld currently silently mis
On 24 Oct 2017 14:32, "Erich Keane via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
Author: erichkeane
Date: Tue Oct 24 14:31:50 2017
New Revision: 316518
URL: http://llvm.org/viewvc/llvm-project?rev=316518&view=rev
Log:
mplement __has_unique_object_representations
A helper builtin to facil
Thanks for the review Richard. Would you like me to revert, or can I just make
these changes in a new patch?
From: Richard Smith [mailto:rich...@metafoo.co.uk]
Sent: Thursday, October 26, 2017 9:50 AM
To: Keane, Erich
Cc: cfe-commits
Subject: Re: r316518 - mplement __has_unique_object_represe
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D38819
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
I don't think working around an lld bug is a particularly good justification
for this, but I do think it makes sense to switch this from being a
"compatibility with GCC 4.7+" thing to being a
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Very close. Thanks for making the changes. Just a few nits.
Comment at: utils/clangdiag.py:66
+def setDiagBreakpoint(frame, bp_loc, dict):
+id = frame.FindV
Author: rnk
Date: Thu Oct 26 10:07:48 2017
New Revision: 316674
URL: http://llvm.org/viewvc/llvm-project?rev=316674&view=rev
Log:
Move MS inline asm parser methods out of line to reduce indentation, NFC
Modified:
cfe/trunk/lib/Parse/ParseStmtAsm.cpp
Modified: cfe/trunk/lib/Parse/ParseStmtAsm
hintonda added a comment.
Thanks for the feedback (addressed below).
btw, where should this module go?
Since it's intended for clang, and clang based tool, developers, I put it in
`clang/utils`, but Zackery suggested `lldb/examples/python` might be a better
place. Please let me know if anyone
vsapsai accepted this revision.
vsapsai added a comment.
This revision is now accepted and ready to land.
Looks good to me.
Repository:
rL LLVM
https://reviews.llvm.org/D37341
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
zturner added a comment.
Do I understand correctly that this will insert breakpoints on *all* clang
diagnostics? That's not necessarily bad, but I was under the impression
originally that it would let you pick the diagnostics you wanted to insert
breakpoints on.
Also, What is the workflow for
rjmccall added a comment.
The original code doesn't make any sense; it looks like the indirection is
backwards. We just built a debug variable corresponding to the block
descriptor pointer parameter, so LocalAddr should be dbg.declare'd to be that
variable and Arg should be dbg.value'd. It lo
clayborg accepted this revision.
clayborg added inline comments.
Comment at: utils/clangdiag.py:117
+disable(exe_ctx)
+else:
+getDiagtool(exe_ctx.GetTarget(), args.path[0])
hintonda wrote:
> clayborg wrote:
> > should probably verify that this
Author: ctopper
Date: Thu Oct 26 10:54:22 2017
New Revision: 316681
URL: http://llvm.org/viewvc/llvm-project?rev=316681&view=rev
Log:
[X86] Add a target attribute test for no-sse4.
Modified:
cfe/trunk/test/CodeGen/attr-target-x86.c
Modified: cfe/trunk/test/CodeGen/attr-target-x86.c
URL:
htt
vsk added inline comments.
Comment at: test/CodeGenObjC/debug-info-blocks.m:13
-// rdar://problem/14386148
-// Test that we don't emit bogus line numbers for the helper functions.
-// Test that we do emit scope info for the helper functions.
+// rdar://problem/32907581
+// Test
aprantl added a comment.
In https://reviews.llvm.org/D39305#908208, @rjmccall wrote:
> The original code doesn't make any sense; it looks like the indirection is
> backwards. We just built a debug variable corresponding to the block
> descriptor pointer parameter, so LocalAddr should be dbg.de
hfinkel added a comment.
Quick question: We're talking about a few different variants on this feature
now: Post-inlining instrumentation, only marking function entries, and not
passing the function address. Do you intend to use all of these things
separately? I ask because, taken together, that
erichkeane added a comment.
I note my rebase lost the tests... I'll fix that up soon, sorry guys!
https://reviews.llvm.org/D38596
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aprantl added inline comments.
Comment at: test/CodeGenObjC/debug-info-blocks.m:20
// CHECK: call {{.*}}, !dbg ![[DBG_LINE:[0-9]+]]
// CHECK-NOT: ret
// CHECK: load {{.*}}, !dbg ![[COPY_LINE:[0-9]+]]
vsk wrote:
> aprantl wrote:
> > What's the location used for
aprantl added inline comments.
Comment at: test/CodeGenObjC/debug-info-blocks.m:20
// CHECK: call {{.*}}, !dbg ![[DBG_LINE:[0-9]+]]
// CHECK-NOT: ret
// CHECK: load {{.*}}, !dbg ![[COPY_LINE:[0-9]+]]
aprantl wrote:
> vsk wrote:
> > aprantl wrote:
> > > What's
Author: adrian
Date: Thu Oct 26 11:16:05 2017
New Revision: 316684
URL: http://llvm.org/viewvc/llvm-project?rev=316684&view=rev
Log:
Simplify codegen and debug info generation for block context parameters.
The exisiting code goes out of its way to put block parameters into an
alloca only at -O0,
This revision was automatically updated to reflect the committed changes.
Closed by commit rL316684: Simplify codegen and debug info generation for block
context parameters. (authored by adrian).
Changed prior to commit:
https://reviews.llvm.org/D39305?vs=120312&id=120455#toc
Repository:
rL
efriedma added a comment.
I think you missed a couple other places which still set SizeType and
PtrDiffType?
Repository:
rL LLVM
https://reviews.llvm.org/D39321
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
Author: adrian
Date: Thu Oct 26 11:32:16 2017
New Revision: 316686
URL: http://llvm.org/viewvc/llvm-project?rev=316686&view=rev
Log:
Revert "Simplify codegen and debug info generation for block context
parameters."
This reverts commit r316684 while investigating buildbot breakage.
Added:
cf
hintonda updated this revision to Diff 120459.
hintonda added a comment.
- Enhance diagtool option to check, reset, print out current value.
https://reviews.llvm.org/D36347
Files:
utils/clangdiag.py
Index: utils/clangdiag.py
===
erichkeane updated this revision to Diff 120460.
https://reviews.llvm.org/D38596
Files:
include/clang/AST/Decl.h
include/clang/Basic/Attr.td
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Basic/TargetInfo.h
include/clang/Sema/Sema.h
lib/Basic/Targets/X86.cpp
lib/Basic/Targ
vsk updated this revision to Diff 120461.
vsk marked 8 inline comments as done.
vsk added a comment.
- Tighten test case to show the dbg loc on return instructions.
https://reviews.llvm.org/D39310
Files:
lib/CodeGen/CGBlocks.cpp
test/CodeGenObjC/debug-info-blocks.m
Index: test/CodeGenObjC
vsk added inline comments.
Comment at: test/CodeGenObjC/debug-info-blocks.m:20
// CHECK: call {{.*}}, !dbg ![[DBG_LINE:[0-9]+]]
// CHECK-NOT: ret
// CHECK: load {{.*}}, !dbg ![[COPY_LINE:[0-9]+]]
aprantl wrote:
> aprantl wrote:
> > vsk wrote:
> > > aprantl wro
clayborg added a comment.
Looks good.
https://reviews.llvm.org/D36347
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arphaman marked 5 inline comments as done.
arphaman added inline comments.
Comment at: include/clang/Tooling/Refactoring/Extract/ExtractFunction.h:21
+/// then called from the place where the original code was.
+class ExtractFunction final : public SourceChangeRefactoringRule {
+
RKSimon added inline comments.
Comment at: lib/Basic/Targets/X86.cpp:835
defineCPUMacros(Builder, "slm");
+// gcc also defineds 'silvermont', but we never have. See comment below.
break;
defines
https://reviews.llvm.org/D38824
_
arphaman updated this revision to Diff 120466.
arphaman added a comment.
- Use a `RefactoringDescriptor` struct that's accessible from a static function
in an operation class.
- Make `createSourceReplacements` private.
Repository:
rL LLVM
https://reviews.llvm.org/D38985
Files:
include/cla
Author: george.karpenkov
Date: Thu Oct 26 12:00:22 2017
New Revision: 316687
URL: http://llvm.org/viewvc/llvm-project?rev=316687&view=rev
Log:
[Analyzer] [Tests] Write analyzers crashes to stdout, and not to a separate file
With this change it would be sufficient to look at CI console to see the
hintonda added a comment.
In https://reviews.llvm.org/D36347#908186, @zturner wrote:
> Do I understand correctly that this will insert breakpoints on *all* clang
> diagnostics? That's not necessarily bad, but I was under the impression
> originally that it would let you pick the diagnostics yo
mstorsjo updated this revision to Diff 120467.
mstorsjo edited the summary of this revision.
mstorsjo added a comment.
Herald added subscribers: JDevlieghere, aprantl.
Adjusted _LIBUNWIND_HIGHEST_DWARF_REGISTER to actually have the value of the
highest register, not highest+1.
https://reviews.l
craig.topper created this revision.
It looks like at one time Options.td was in alphabetical order, but that looks
to have long been broken. The result is that it all the no- x86 options got
separated from their other friends for no good reason.
This patch puts them all together in one place wi
craig.topper updated this revision to Diff 120469.
craig.topper added a comment.
Fix Simon's comment
https://reviews.llvm.org/D38824
Files:
lib/Basic/Targets/X86.cpp
test/Preprocessor/predefined-arch-macros.c
Index: test/Preprocessor/predefined-arch-macros.c
===
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Thanks, LGTM.
https://reviews.llvm.org/D38774
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
Author: adrian
Date: Thu Oct 26 13:08:52 2017
New Revision: 316689
URL: http://llvm.org/viewvc/llvm-project?rev=316689&view=rev
Log:
Simplify codegen and debug info generation for block context parameters.
The exisiting code goes out of its way to put block parameters into an
alloca only at -O0,
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks.
https://reviews.llvm.org/D39341
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D39177
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
rjmccall added a comment.
Sure, that makes sense to me.
John.
Repository:
rL LLVM
https://reviews.llvm.org/D39008
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aprantl accepted this revision.
aprantl added inline comments.
This revision is now accepted and ready to land.
Comment at: test/CodeGenObjC/debug-info-blocks.m:20
// CHECK: call {{.*}}, !dbg ![[DBG_LINE:[0-9]+]]
// CHECK-NOT: ret
// CHECK: load {{.*}}, !dbg ![[COPY_LINE:[0-9]
danielmarjamaki added a comment.
> Do you mind writing some tests with multidimensional arrays to check what do
> we lose if we remove that code?
I have spent a few hours trying to write a test case that shows there is false
negatives caused by this change. And fail.
I see lots of false negati
Author: adrian
Date: Thu Oct 26 13:16:03 2017
New Revision: 316695
URL: http://llvm.org/viewvc/llvm-project?rev=316695&view=rev
Log:
Fix C++ testcase I forgot to add to r316689.
Modified:
cfe/trunk/test/CodeGenCXX/blocks.cpp
Modified: cfe/trunk/test/CodeGenCXX/blocks.cpp
URL:
http://llvm.or
yamaguchi created this revision.
Previously, we passed "#" to --autocomplete to indicate to enable cc1
flags. For example, when -cc1 or -Xclang was passed to bash, bash
executed `clang --autocomplete=#-`.
However, this was not a good implementation because it depends -Xclang
and -cc1 parsing to s
1 - 100 of 154 matches
Mail list logo
