[PATCH] D41495: [clangd] Skip function bodies when building the preamble

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Those are some impressive numbers! Excited to see this land, thanks for tracking down all the weird problems. Comment at: clangd/ClangdUnit.cpp:536 + // so we set

[PATCH] D41433: Unit tests for TBAA metadata generation.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Interesting. Okay, LGTM. Repository: rC Clang https://reviews.llvm.org/D41433 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D41228: [ObjC] Enable __strong pointers in structs under ARC

rjmccall added inline comments. Comment at: include/clang/AST/Type.h:1152 +NTFK_Struct, // non-trivial C struct. +NTFK_Array// array that has non-trivial elements. + }; ahatanak wrote: > rjmccall wrote: > > ahatanak wrote: > > > rjmccall wrote: > >

[PATCH] D41326: [clang-tidy] Added diagnostics about incorrect usage of NOLINT comment

xgsa added a comment. Ping. https://reviews.llvm.org/D41326 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41536: Provide public getter for OverlayFileSystem

vladimir.plyashkun created this revision. vladimir.plyashkun added a reviewer: alexfh. vladimir.plyashkun added projects: clang, clang-tools-extra. Herald added subscribers: cfe-commits, klimek. This is part of review - https://reviews.llvm.org/D41535 Repository: rC Clang

[PATCH] D41535: Add -vfsoverlay option for Clang-Tidy

vladimir.plyashkun added a comment. Second part of review - https://reviews.llvm.org/D41536 Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41535 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r321346 - Fix unused variable warning in SemaTemplate. NFC

Author: sammccall Date: Thu Dec 21 23:09:51 2017 New Revision: 321346 URL: http://llvm.org/viewvc/llvm-project?rev=321346=rev Log: Fix unused variable warning in SemaTemplate. NFC Modified: cfe/trunk/lib/Sema/SemaTemplate.cpp Modified: cfe/trunk/lib/Sema/SemaTemplate.cpp URL:

[PATCH] D41535: Add -vfsoverlay option for Clang-Tidy

vladimir.plyashkun created this revision. vladimir.plyashkun added reviewers: alexfh, benlangmuir. vladimir.plyashkun added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. These changes introduce support for -vfsoverlay option in Clang-Tidy The main reason for it: In IDE

[PATCH] D41514: [Index] Reduce size of SymbolInfo struct.

sammccall updated this revision to Diff 127986. sammccall added a comment. Avoid repeating uint8_t type for SymbolProperty/SymbolPropertySet. Repository: rC Clang https://reviews.llvm.org/D41514 Files: include/clang/Index/IndexSymbol.h lib/Index/IndexSymbol.cpp

[PATCH] D41534: Don't add empty InstalledDir as a candidate GCC location

jackoalan created this revision. jackoalan added a reviewer: cfe-commits. I maintain a couple build tools based on Clang's Tooling framework. The tools are built and used directly out of the CMake binary directory (i.e. not installed in a meaningful way). This non-installed setup causes issues

r321343 - [X86] Add missing check lines for the silvermont cases in predefined-arch-macros.c test.

Author: ctopper Date: Thu Dec 21 21:09:38 2017 New Revision: 321343 URL: http://llvm.org/viewvc/llvm-project?rev=321343=rev Log: [X86] Add missing check lines for the silvermont cases in predefined-arch-macros.c test. Modified: cfe/trunk/test/Preprocessor/predefined-arch-macros.c Modified:

r321342 - [Modules] Map missing private submodules from Foo.Private to Foo_Private

Author: bruno Date: Thu Dec 21 21:04:43 2017 New Revision: 321342 URL: http://llvm.org/viewvc/llvm-project?rev=321342=rev Log: [Modules] Map missing private submodules from Foo.Private to Foo_Private In case `@import Foo.Private` fails because the submodule doesn't exist, look for `Foo_Private`

r321341 - [X86] Add 'prfchw' to the correct CPUs to match the backend.

Author: ctopper Date: Thu Dec 21 20:51:00 2017 New Revision: 321341 URL: http://llvm.org/viewvc/llvm-project?rev=321341=rev Log: [X86] Add 'prfchw' to the correct CPUs to match the backend. Modified: cfe/trunk/lib/Basic/Targets/X86.cpp cfe/trunk/test/Preprocessor/predefined-arch-macros.c

[PATCH] D40705: Diagnose invalid decl-specifiers in non-type template parameter declarations (original author miyuki!)

faisalv closed this revision. faisalv added a comment. Added via https://reviews.llvm.org/rC321339 Repository: rC Clang https://reviews.llvm.org/D40705 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r321339 - Diagnose the various invalid decl-specifiers on nontype template parameters.

Author: faisalv Date: Thu Dec 21 19:50:55 2017 New Revision: 321339 URL: http://llvm.org/viewvc/llvm-project?rev=321339=rev Log: Diagnose the various invalid decl-specifiers on nontype template parameters. The standard correctly forbids various decl-specifiers that dont make sense on non-type

[PATCH] D41507: avxintrin.h documentation fixes and updates

kromanova added inline comments. Comment at: lib/Headers/avxintrin.h:1668 ///operation to use: \n -///0x00 : Equal (ordered, non-signaling) -///0x01 : Less-than (ordered, signaling) -///0x02 : Less-than-or-equal (ordered, signaling) -///0x03 : Unordered

[PATCH] D41526: [libclang] Avoid builtin trap for __debug parser_crash pragma

arphaman abandoned this revision. arphaman added a comment. It turns out there's already something that works much better: `#pragma clang __debug handle_crash`. Sorry about the redundant patch! Repository: rC Clang https://reviews.llvm.org/D41526

[PATCH] D41528: [Sema] Don't emit the -Wstrict-prototypes warning for variadic functions.

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM, thank you https://reviews.llvm.org/D41528 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D41528: [Sema] Don't emit the -Wstrict-prototypes warning for variadic functions.

vsapsai created this revision. vsapsai added reviewers: arphaman, ahatanak. rdar://problem/33251668 https://reviews.llvm.org/D41528 Files: clang/lib/Sema/SemaType.cpp clang/test/Sema/warn-strict-prototypes.c Index: clang/test/Sema/warn-strict-prototypes.c

[PATCH] D41521: [CUDA] fixes for __shfl_* intrinsics.

This revision was automatically updated to reflect the committed changes. Closed by commit rC321326: [CUDA] More fixes for __shfl_* intrinsics. (authored by tra, committed by ). Changed prior to commit: https://reviews.llvm.org/D41521?vs=127950=127962#toc Repository: rC Clang

r321326 - [CUDA] More fixes for __shfl_* intrinsics.

Author: tra Date: Thu Dec 21 15:52:09 2017 New Revision: 321326 URL: http://llvm.org/viewvc/llvm-project?rev=321326=rev Log: [CUDA] More fixes for __shfl_* intrinsics. * __shfl_{up,down}* uses unsigned int for the third parameter. * added [unsigned] long overloads for non-sync shuffles.

r321325 - [X86] Allow _mm_prefetch (both the header implementation and the builtin) to accept bit 2 which is supposed to indicate the prefetched addresses will be written to

Author: ctopper Date: Thu Dec 21 15:50:22 2017 New Revision: 321325 URL: http://llvm.org/viewvc/llvm-project?rev=321325=rev Log: [X86] Allow _mm_prefetch (both the header implementation and the builtin) to accept bit 2 which is supposed to indicate the prefetched addresses will be written to

[PATCH] D41526: [libclang] Avoid builtin trap for __debug parser_crash pragma

benlangmuir added a comment. Did you consider just using a different pragma that triggers this behaviour instead of avoiding the crash? I don't really have a strong preference but I'd be interested to hear what you think the pros/cons are. Comment at:

[PATCH] D40819: Implement Attribute Target MultiVersioning (Improved edition!)

erichkeane added a comment. I'm sure most of you have taken off for the year, but if anyone had time, *ping* :D https://reviews.llvm.org/D40819 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D41363: [clang-tidy] Adding Fuchsia checker for overloaded operators

juliehockett added a comment. > Are the Fuchsia library headers intended to also comply with this rule? I > notice there's mention of a unique_ptr class, and I can't imagine that > working without overloading more operators than just assignment. Perhaps this > check should not be triggered for

[PATCH] D41151: [analyzer] Adding LoopContext and improve loop modeling

NoQ added a comment. Or not. Loop counter has its own whole-loop scope. I guess `LoopContext` can be treated as a sub-class of `ScopeContext`. And i don't mind having `ScopeContext` be split into small distinct sub-classes. Because we're stuck in cornercases for covering all possible scopes,

[PATCH] D41363: [clang-tidy] Adding Fuchsia checker for overloaded operators

juliehockett updated this revision to Diff 127960. juliehockett marked 5 inline comments as done. juliehockett added a comment. Fixing comments https://reviews.llvm.org/D41363 Files: clang-tidy/fuchsia/CMakeLists.txt clang-tidy/fuchsia/FuchsiaTidyModule.cpp

[PATCH] D41151: [analyzer] Adding LoopContext and improve loop modeling

NoQ added a comment. So, essentially, `LoopContext` is per-loop, while `ScopeContext` is per-iteration? Comment at: lib/StaticAnalyzer/Core/LoopUnrolling.cpp:28-46 struct LoopState { private: enum Kind { Normal, Unrolled } K; - const Stmt *LoopStmt; - const

[PATCH] D41521: [CUDA] fixes for __shfl_* intrinsics.

tra added a comment. Added to my todo list. There are few more gaps that I want to test in order to make sure we don't regress on compatibility with older CUDA versions while changing these wrappers. https://reviews.llvm.org/D41521 ___

r321324 - Correct hasFeature/isValidFeatureName's handling of shstk/adx/mwaitx

Author: erichkeane Date: Thu Dec 21 15:27:36 2017 New Revision: 321324 URL: http://llvm.org/viewvc/llvm-project?rev=321324=rev Log: Correct hasFeature/isValidFeatureName's handling of shstk/adx/mwaitx https://bugs.llvm.org/show_bug.cgi?id=35721 reports that x86intrin.h is issuing a few warnings.

[clang-tools-extra] r321323 - Update test after r321312

Author: probinson Date: Thu Dec 21 15:19:25 2017 New Revision: 321323 URL: http://llvm.org/viewvc/llvm-project?rev=321323=rev Log: Update test after r321312 Modified: clang-tools-extra/trunk/unittests/change-namespace/ChangeNamespaceTests.cpp Modified:

[PATCH] D41526: [libclang] Avoid builtin trap for __debug parser_crash pragma

arphaman created this revision. arphaman added a reviewer: benlangmuir. Herald added a subscriber: JDevlieghere. This patch allows libclang to report a parser crash that's caused by `#pragma clang __debug parser_crash` without using the `LLVM_BUILTIN_TRAP`. Instead a new flag in PPOpts is used

[PATCH] D41521: [CUDA] fixes for __shfl_* intrinsics.

jlebar accepted this revision. jlebar added a comment. This revision is now accepted and ready to land. Since this is tricky and we've seen it affecting user code, do you think it's a bad idea to add tests to the test-suite? https://reviews.llvm.org/D41521

[PATCH] D41514: [Index] Reduce size of SymbolInfo struct.

akyrtzi added a comment. Nice one! One minor change I'd suggest is to change `SymbolProperty` to `enum class SymbolProperty : SymbolPropertySet`, so that if it needs to increase we only change the type in one place. Repository: rC Clang https://reviews.llvm.org/D41514

r321321 - Delete dead code.

Author: adrian Date: Thu Dec 21 15:03:05 2017 New Revision: 321321 URL: http://llvm.org/viewvc/llvm-project?rev=321321=rev Log: Delete dead code. Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp URL:

[PATCH] D41414: [analyzer] Add keyboard j/k navigation to HTML reports

This revision was automatically updated to reflect the committed changes. Closed by commit rL321320: [analyzer] Add Javascript to analyzer HTML output to allow keyboard navigation. (authored by george.karpenkov, committed by ). Changed prior to commit:

r321320 - [analyzer] Add Javascript to analyzer HTML output to allow keyboard navigation.

Author: george.karpenkov Date: Thu Dec 21 14:57:51 2017 New Revision: 321320 URL: http://llvm.org/viewvc/llvm-project?rev=321320=rev Log: [analyzer] Add Javascript to analyzer HTML output to allow keyboard navigation. Differential Revision: https://reviews.llvm.org/D41414 Modified:

[PATCH] D41523: xmmintrin.h documentation fixes and updates

dyung created this revision. This is the result of several patches we made internally to update the documentation that we would like to have reviewed for possible submission. The changes include: 1. Fix inaccurate instruction listings. 2. Fix small issues in _mm_getcsr and _mm_setcsr. 3. Fix

r321319 - [ODRHash] Canonicalize Decl's before processing.

Author: rtrieu Date: Thu Dec 21 14:38:29 2017 New Revision: 321319 URL: http://llvm.org/viewvc/llvm-project?rev=321319=rev Log: [ODRHash] Canonicalize Decl's before processing. Canonicalizing the Decl before processing it as part of the hash should reduce issues with non-canonical types showing

[PATCH] D41521: [CUDA] fixes for __shfl_* intrinsics.

tra created this revision. tra added a reviewer: jlebar. Herald added a subscriber: sanjoy. - __shfl_{up,down}* uses `unsigned int` for the third parameter. - added [unsigned] long overloads for non-sync shuffles. Augments r319908 which added long overload for sync shuffles.

[PATCH] D41520: smmintrin.h documentation fixes and updates

dyung created this revision. This is the result of several patches we made internally to update the documentation that we would like to have reviewed for possible submission. The changes include: 1. Fix formatting issue due to hyphenated terms at line breaks. 2. Fix typo These patches were

[PATCH] D41518: pmmintrin.h documentation fixes and updates

dyung created this revision. This is the result of several patches we made internally to update the documentation that we would like to have reviewed for possible submission. The changes include: 1. Fix incorrect wording in various intrinsic descriptions. Previously the descriptions used

r321318 - Suppress "redundant parens" warning for "A (::B())".

Author: rsmith Date: Thu Dec 21 14:26:47 2017 New Revision: 321318 URL: http://llvm.org/viewvc/llvm-project?rev=321318=rev Log: Suppress "redundant parens" warning for "A (::B())". This is a slightly odd construct (it's more common to see "A (::B)()") but can happen in friend declarations, and

[PATCH] D41517: mmintrin.h documentation fixes and updates

dyung created this revision. This is the result of several patches we made internally to update the documentation that we would like to have reviewed for possible submission. The changes include: 1. Fix instruction mappings/listings for various intrinsics These patches were made by Craig

[PATCH] D41507: avxintrin.h documentation fixes and updates

lebedev.ri added inline comments. Comment at: lib/Headers/avxintrin.h:1668 ///operation to use: \n -///0x00 : Equal (ordered, non-signaling) -///0x01 : Less-than (ordered, signaling) -///0x02 : Less-than-or-equal (ordered, signaling) -///0x03 : Unordered

[PATCH] D41498: [libcxx] Add clang negative thread safety assertions to std::mutex

lhchavez added inline comments. Comment at: include/__mutex_base:65 void unlock() _NOEXCEPT _LIBCPP_THREAD_SAFETY_ANNOTATION(release_capability()); +#ifdef _LIBCPP_HAS_THREAD_SAFETY_ANNOTATIONS +const mutex& operator!() const { return *this; }

[PATCH] D41516: emmintrin.h documentation fixes and updates

dyung created this revision. This is the result of several patches we made internally to update the documentation that we would like to have reviewed for possible submission. The changes include: 1. Fixed innaccurate instruction mappings for various intrinsics. 2. Fixed description of NaN

[PATCH] D41514: [Index] Reduce size of SymbolInfo struct.

sammccall created this revision. sammccall added a reviewer: akyrtzi. Herald added subscribers: cfe-commits, ilya-biryukov. This is currently 16 bytes, the patch reduces it to 4. (Building with clang on linux x84, I guess others are similar) The only subfield that might need a bigger type is

[PATCH] D41471: [CMake][Fuchsia] Enable assertions

This revision was automatically updated to reflect the committed changes. Closed by commit rL321316: [CMake][Fuchsia] Enable assertions (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D41471?vs=127801=127943#toc Repository: rL LLVM

r321316 - [CMake][Fuchsia] Enable assertions

Author: phosek Date: Thu Dec 21 14:10:27 2017 New Revision: 321316 URL: http://llvm.org/viewvc/llvm-project?rev=321316=rev Log: [CMake][Fuchsia] Enable assertions Enable assertions in both stages. Release+Asserts is fast enough. No need to let insanity through. Patch By: mcgrathr Reviewers:

Re: r321301 - [AArch64] Enable fp16 data type for the Builtin for AArch64 only.

On Thu, Dec 21, 2017 at 12:10 PM, Abderrazek Zaafrani via cfe-commits wrote: > Author: az > Date: Thu Dec 21 12:10:03 2017 > New Revision: 321301 > > URL: http://llvm.org/viewvc/llvm-project?rev=321301=rev > Log: > [AArch64] Enable fp16 data type for the Builtin for

Re: r315984 - [CodeGen] EmitPointerWithAlignment() to generate TBAA info along with LValue base info

Hi, This commit has caused a new regression in LLVM 6. I filed the following PR: https://bugs.llvm.org/show_bug.cgi?id=35724 . Could you please take a look? Thanks, Alex On 17 October 2017 at 02:12, Ivan A. Kosarev via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: kosarev > Date:

[PATCH] D41363: [clang-tidy] Adding Fuchsia checker for overloaded operators

aaron.ballman added a comment. Are the Fuchsia library headers intended to also comply with this rule? I notice there's mention of a unique_ptr class, and I can't imagine that working without overloading more operators than just assignment. Perhaps this check should not be triggered for system

[PATCH] D41413: [scudo] Add -fsanitize=scudo option to Fuchsia.

This revision was automatically updated to reflect the committed changes. Closed by commit rC321314: [scudo] Add -fsanitize=scudo option to Fuchsia (authored by phosek, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D41413 Files:

r321314 - [scudo] Add -fsanitize=scudo option to Fuchsia

Author: phosek Date: Thu Dec 21 14:04:31 2017 New Revision: 321314 URL: http://llvm.org/viewvc/llvm-project?rev=321314=rev Log: [scudo] Add -fsanitize=scudo option to Fuchsia Apparently the -fsanitize flag hadn't been added for Scudo upstream yet. Patch By: flowerhack Reviewers: cryptoad,

r321312 - [AST] Incorrectly qualified unscoped enumeration as template actual parameter.

Author: probinson Date: Thu Dec 21 13:47:22 2017 New Revision: 321312 URL: http://llvm.org/viewvc/llvm-project?rev=321312=rev Log: [AST] Incorrectly qualified unscoped enumeration as template actual parameter. An unscoped enumeration used as template argument, should not have any qualified

[PATCH] D39239: [AST] Incorrectly qualified unscoped enumeration as template actual parameter.

This revision was automatically updated to reflect the committed changes. Closed by commit rC321312: [AST] Incorrectly qualified unscoped enumeration as template actual parameter. (authored by probinson, committed by ). Changed prior to commit:

Re: r321099 - [driver][darwin] Take the OS version specified in "-target" as the target

On 21 December 2017 at 12:34, James Y Knight wrote: > I totally agree with moving towards eliminating the -m-version-min > flags, it's much better to put it in the target, and will clean up a lot of > cruft in the driver, eventually. > > Now -- we (or anyone else who runs

[PATCH] D40983: Generate Libclang invocation reproducers using a new -cc1gen-reproducer option

arphaman updated this revision to Diff 127935. arphaman marked an inline comment as done. arphaman added a comment. Address review comments https://reviews.llvm.org/D40983 Files: include/clang/Driver/Driver.h lib/Driver/Driver.cpp test/Index/create-libclang-completion-reproducer.c

[PATCH] D40983: Generate Libclang invocation reproducers using a new -cc1gen-reproducer option

arphaman marked 2 inline comments as done. arphaman added a comment. In https://reviews.llvm.org/D40983#958809, @bruno wrote: > Hi Alex, > > Thanks for improving this. > > - Instead of adding `-cc1gen-reproducer`, why can't you run that through > `-cc1` and have a flag similar to `-###`, which

[PATCH] D41512: [Sema] -Wtautological-constant-compare is too good. Cripple it.

lebedev.ri created this revision. lebedev.ri added reviewers: aaron.ballman, rsmith, smeenai, rjmccall, rnk, mclow.lists. lebedev.ri added a project: clang. The diagnostic was mostly introduced in https://reviews.llvm.org/D38101 by me, as a reaction to wasting a lot of time, see mail

[PATCH] D41228: [ObjC] Enable __strong pointers in structs under ARC

ahatanak added inline comments. Comment at: include/clang/AST/Type.h:1152 +NTFK_Struct, // non-trivial C struct. +NTFK_Array// array that has non-trivial elements. + }; rjmccall wrote: > ahatanak wrote: > > rjmccall wrote: > > > We don't actually

r321306 - Revert "[CodeGen] Fix crash when a function taking transparent union is redeclared."

Author: vsapsai Date: Thu Dec 21 12:52:59 2017 New Revision: 321306 URL: http://llvm.org/viewvc/llvm-project?rev=321306=rev Log: Revert "[CodeGen] Fix crash when a function taking transparent union is redeclared." This reverts commit r321296. It caused performance regressions FAIL:

r321304 - Don't produce redundant parentheses warning for "A (::B); " and the like.

Author: rsmith Date: Thu Dec 21 12:50:39 2017 New Revision: 321304 URL: http://llvm.org/viewvc/llvm-project?rev=321304=rev Log: Don't produce redundant parentheses warning for "A (::B);" and the like. The parentheses here are not redundant as they affect the binding of the '::' token. Modified:

Re: r321099 - [driver][darwin] Take the OS version specified in "-target" as the target

I totally agree with moving towards eliminating the -m-version-min flags, it's much better to put it in the target, and will clean up a lot of cruft in the driver, eventually. Now -- we (or anyone else who runs into this) can simply start specifying the version in both locations ("-target

Re: r321099 - [driver][darwin] Take the OS version specified in "-target" as the target

Thanks for the quick response and your suggestions! I believe the workaround you suggest in 1) will work for us, so there's no need for an urgent change. Thanks again! On 21 December 2017 at 20:11, Alex L wrote: > Thanks for raising your concerns. > > We decided to avoid

[clang-tools-extra] r321302 - [clangd] Don't re-hash SymbolID in maps, just use the SHA1 data

Author: sammccall Date: Thu Dec 21 12:11:46 2017 New Revision: 321302 URL: http://llvm.org/viewvc/llvm-project?rev=321302=rev Log: [clangd] Don't re-hash SymbolID in maps, just use the SHA1 data Modified: clang-tools-extra/trunk/clangd/index/Index.cpp

r321301 - [AArch64] Enable fp16 data type for the Builtin for AArch64 only.

Author: az Date: Thu Dec 21 12:10:03 2017 New Revision: 321301 URL: http://llvm.org/viewvc/llvm-project?rev=321301=rev Log: [AArch64] Enable fp16 data type for the Builtin for AArch64 only. Differential Revision: https:://reviews.llvm.org/D41360 Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp

[PATCH] D41103: [CMake] Allow passing extra CMake arguments to custom libc++

This revision was automatically updated to reflect the committed changes. Closed by commit rL321299: [CMake] Allow passing extra CMake arguments to custom libc++ (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D41103?vs=126488=127924#toc Repository: rL

r321298 - Revert "Fix for PR32990"

Author: rnk Date: Thu Dec 21 11:44:23 2017 New Revision: 321298 URL: http://llvm.org/viewvc/llvm-project?rev=321298=rev Log: Revert "Fix for PR32990" This reverts commit r321239. It broke the Chromium DLL build: [8834/50217] LINK(DLL) icui18n.dll icui18n.dll.lib icui18n.dll.pdb FAILED:

r321297 - When instantiating a deduction guide, transform its name.

Author: rsmith Date: Thu Dec 21 11:43:39 2017 New Revision: 321297 URL: http://llvm.org/viewvc/llvm-project?rev=321297=rev Log: When instantiating a deduction guide, transform its name. Otherwise it will serve as a deduction guide for the wrong class template. Added:

[PATCH] D41311: [CodeGen] Fix crash when a function taking transparent union is redeclared.

This revision was automatically updated to reflect the committed changes. Closed by commit rC321296: [CodeGen] Fix crash when a function taking transparent union is redeclared. (authored by vsapsai, committed by ). Changed prior to commit: https://reviews.llvm.org/D41311?vs=127779=127923#toc

r321296 - [CodeGen] Fix crash when a function taking transparent union is redeclared.

Author: vsapsai Date: Thu Dec 21 11:42:37 2017 New Revision: 321296 URL: http://llvm.org/viewvc/llvm-project?rev=321296=rev Log: [CodeGen] Fix crash when a function taking transparent union is redeclared. When a function taking transparent union is declared as taking one of union members earlier

[PATCH] D41507: avxintrin.h documentation fixes and updates

dyung created this revision. This is the result of several patches we made internally to update the documentation that we would like to have reviewed for possible submission. The changes include: 1. Fix incorrect wording in various intrinsic descriptions. Previously the descriptions used

[PATCH] D40443: [Modules TS] Make imports from an interface unit visible to its implementation units

hamzasood added a comment. Ping https://reviews.llvm.org/D40443 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41498: [libcxx] Add clang negative thread safety assertions to std::mutex

mclow.lists added inline comments. Comment at: include/__mutex_base:65 void unlock() _NOEXCEPT _LIBCPP_THREAD_SAFETY_ANNOTATION(release_capability()); +#ifdef _LIBCPP_HAS_THREAD_SAFETY_ANNOTATIONS +const mutex& operator!() const { return *this; } We

[PATCH] D41506: [clangd] Use Builder for symbol slabs, and use sorted-vector for storage

sammccall updated this revision to Diff 127918. sammccall added a comment. minor doc and code layout tweaks Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41506 Files: clangd/index/FileIndex.cpp clangd/index/Index.cpp clangd/index/Index.h

Re: r321099 - [driver][darwin] Take the OS version specified in "-target" as the target

Thanks for raising your concerns. We decided to avoid -m-version-min flag in favor of -target to simplify the driver logic and to encourage the adoption of -target. Now after r321145 we only warn about -m-version-min flag when the OS version specified in it is different to the OS version

[PATCH] D41506: [clangd] Use Builder for symbol slabs, and use sorted-vector for storage

sammccall created this revision. sammccall added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, mgrang, klimek. This improves a few things: - the insert -> freeze -> read sequence is now enforced/communicated by the type system - SymbolSlab::const_iterator iterates over

r321290 - [analyzer] Fix zero-initialization of stack VLAs under ObjC ARC.

Author: dergachev Date: Thu Dec 21 10:43:02 2017 New Revision: 321290 URL: http://llvm.org/viewvc/llvm-project?rev=321290=rev Log: [analyzer] Fix zero-initialization of stack VLAs under ObjC ARC. Using ARC, strong, weak, and autoreleasing stack variables are implicitly initialized with nil. This

[PATCH] D41478: [analyzer] Fix zero-initialization of stack VLAs under ARC.

This revision was automatically updated to reflect the committed changes. Closed by commit rC321290: [analyzer] Fix zero-initialization of stack VLAs under ObjC ARC. (authored by dergachev, committed by ). Repository: rC Clang https://reviews.llvm.org/D41478 Files:

[PATCH] D40720: No -fsanitize=function warning when calling noexcept function through non-noexcept pointer in C++17

rsmith added inline comments. Comment at: clang/lib/CodeGen/CodeGenTypes.h:378 + /// specification removed. + QualType removeNothrowQualification(const FunctionProtoType *Proto) const; }; Please use the frontend language terminology here: "nothrow" is

[PATCH] D41478: [analyzer] Fix zero-initialization of stack VLAs under ARC.

dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. LGTM. The tests are great!! Repository: rC Clang https://reviews.llvm.org/D41478 ___ cfe-commits mailing list

[PATCH] D41242: [Solaris] Silence -pthread warning on Solaris

fedor.sergeev accepted this revision. fedor.sergeev added a comment. This revision is now accepted and ready to land. LGTM. Repository: rC Clang https://reviews.llvm.org/D41242 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D24933: Enable configuration files in clang

sepavloff updated this revision to Diff 127911. sepavloff marked 2 inline comments as done. sepavloff added a comment. Small corrections to the patch - Avoid quick return in the case of error, it may cause fails of clang tools. - Fixed typo. Repository: rC Clang

[PATCH] D40478: Added control flow architecture protection Flag

craig.topper added a comment. Are we sure we want a different command line option name from gcc? From our internal conversations with the gcc folks I thought they were suggesting that -fcf-protection could imply a software mechanism if a hardware mechanism was not available thorugh -mibt or

[PATCH] D41500: ananas: Add shared library support

zhmu created this revision. zhmu added a reviewer: ed. Herald added a subscriber: cfe-commits. The Ananas Operating System (https://github.com/zhmu/ananas) has shared library support as of commit 57739c0b6ece56dd4872aedf30264ed4b9412c77. This change adds the necessary settings to clang so that

[PATCH] D39053: [Bitfield] Add more cases to making the bitfield a separate location

spetrovic added a comment. ping https://reviews.llvm.org/D39053 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r321286 - [clangd] Fix use after free.

Author: d0k Date: Thu Dec 21 09:51:35 2017 New Revision: 321286 URL: http://llvm.org/viewvc/llvm-project?rev=321286=rev Log: [clangd] Fix use after free. Found by asan. Modified: clang-tools-extra/trunk/clangd/index/SymbolCollector.cpp Modified:

[PATCH] D41444: [ASTImporterTest] Make testing under '-fdelayed-template-parsing' mandatory

This revision was automatically updated to reflect the committed changes. Closed by commit rL321285: [ASTImporterTest] Add mandatory testing with -fdelayed-template-parsing (authored by a.sidorin, committed by ). Changed prior to commit: https://reviews.llvm.org/D41444?vs=127748=127903#toc

r321285 - [ASTImporterTest] Add mandatory testing with '-fdelayed-template-parsing'

Author: a.sidorin Date: Thu Dec 21 09:41:06 2017 New Revision: 321285 URL: http://llvm.org/viewvc/llvm-project?rev=321285=rev Log: [ASTImporterTest] Add mandatory testing with '-fdelayed-template-parsing' * While running ASTImporterTests, we often forget about Windows MSVC buildbots which

[PATCH] D41498: [libcxx] Add clang negative thread safety assertions to std::mutex

lhchavez created this revision. Herald added a reviewer: EricWF. Herald added a subscriber: cfe-commits. This adds clang negative thread safery assertion support to std::mutex, as documented in: https://clang.llvm.org/docs/ThreadSafetyAnalysis.html Fixes #34951. Repository: rCXX libc++

[PATCH] D38639: [clangd] #include statements support for Open definition

Nebiroth updated this revision to Diff 127900. Nebiroth marked 11 inline comments as done. Nebiroth added a comment. Minor code cleanup Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D38639 Files: clangd/ClangdUnit.cpp clangd/ClangdUnit.h clangd/Protocol.h

[PATCH] D40720: No -fsanitize=function warning when calling noexcept function through non-noexcept pointer in C++17

sberg updated this revision to Diff 127899. sberg added a comment. (need to call getAs instead of cast in one place, in case the name in the function decl is wrapped in parens, as happens in HarfBuzz's hb-buffer.cc) https://reviews.llvm.org/D40720 Files: clang/lib/CodeGen/CGExpr.cpp

[PATCH] D41150: [CFG] Adding new CFGStmt LoopEntrance for the StaticAnalyzer

szepet updated this revision to Diff 127894. szepet marked an inline comment as done. szepet added a comment. Comment added to LoopEntrance CFGElement. https://reviews.llvm.org/D41150 Files: include/clang/Analysis/CFG.h lib/Analysis/CFG.cpp lib/StaticAnalyzer/Core/PathDiagnostic.cpp

[PATCH] D41394: [CodeGen] Support generation of TBAA info in the new format

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. That's great, thanks. LGTM. https://reviews.llvm.org/D41394 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D41495: [clangd] Skip function bodies when building the preamble

ilya-biryukov added a comment. I haven't done proper benchmarks, but here are some numbers from running this on my machine: Sizes of preamble with (before the change) and without (after the change) functon bodies: | File | Before | After | | ClangdUnit.cpp |

[PATCH] D41495: [clangd] Skip function bodies when building the preamble

ilya-biryukov created this revision. ilya-biryukov added a reviewer: sammccall. Herald added a subscriber: klimek. To make building preambles faster and keep them smaller. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41495 Files: clangd/ClangdUnit.cpp Index:

Re: r321099 - [driver][darwin] Take the OS version specified in "-target" as the target

I think if a version number isn't explicitly specified in the -target value, the value from -m-version-min ought to still be used, as it was before. Currently, clang will ignore the -m-version-min version number if the target has a particular OS specified, even if it has no version number as part

[PATCH] D41487: [clang-format] Adds a FormatStyleSet

krasimir updated this revision to Diff 127888. krasimir added a comment. - Remove accidentally created file Repository: rC Clang https://reviews.llvm.org/D41487 Files: include/clang/Format/Format.h lib/Format/Format.cpp Index: lib/Format/Format.cpp

  1   2   >