Hello Jonathan,
On Mon, Jan 15, 2018 at 08:36:03AM -0700, Jonathan Roelofs wrote:
> LGTM. Would you like me to commit it for you?
Yes, please, commit this patch with my next html documentation patch
squashed into it, and also please commit the ccc-analyzer patch and
close the related ticket as I
hokein updated this revision to Diff 130568.
hokein marked an inline comment as done.
hokein added a comment.
Update comment.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42074
Files:
clangd/index/SymbolCollector.cpp
unittests/clangd/SymbolCollectorTests.cpp
Index: unit
hokein added inline comments.
Comment at: clang-tidy/objc/PropertyDeclarationCheck.h:38
const std::vector SpecialAcronyms;
+const std::vector AdditionalAcronyms;
};
nit: code indent
Comment at: docs/clang-tidy/checks/objc-property-dec
Author: hokein
Date: Fri Jan 19 01:35:55 2018
New Revision: 322929
URL: http://llvm.org/viewvc/llvm-project?rev=322929&view=rev
Log:
[clangd] Collect enum constants in SymbolCollector
Summary:
* ignore nameless symbols
* include enum constant declarataion
Reviewers: ilya-biryukov, jkorous-apple
This revision was automatically updated to reflect the committed changes.
Closed by commit rL322929: [clangd] Collect enum constants in SymbolCollector
(authored by hokein, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D42074
Files:
cl
hokein added inline comments.
Comment at: test/clang-tidy/Inputs/modernize-smart-ptr/initializer_list.h:30
vector(initializer_list<_E> init);
+ ~vector();
};
ilya-biryukov wrote:
> hokein wrote:
> > ilya-biryukov wrote:
> > > Why do we need to add this destr
Merged to 6.0 in r322931.
On Thu, Jan 18, 2018 at 10:40 PM, Nico Weber via cfe-commits
wrote:
> Author: nico
> Date: Thu Jan 18 13:40:27 2018
> New Revision: 322901
>
> URL: http://llvm.org/viewvc/llvm-project?rev=322901&view=rev
> Log:
> Remove TautologicalInRangeCompare from Extra and Tautologi
vladimir.plyashkun updated this revision to Diff 130573.
vladimir.plyashkun added a comment.
Fixed comment
Repository:
rC Clang
https://reviews.llvm.org/D41947
Files:
include/clang/Tooling/Tooling.h
lib/Tooling/Tooling.cpp
unittests/Tooling/ToolingTest.cpp
Index: unittests/Tooling/To
ilya-biryukov added inline comments.
Comment at: test/clang-tidy/Inputs/modernize-smart-ptr/initializer_list.h:30
vector(initializer_list<_E> init);
+ ~vector();
};
hokein wrote:
> ilya-biryukov wrote:
> > hokein wrote:
> > > ilya-biryukov wrote:
> > > > Why
ilya-biryukov added inline comments.
Comment at: clangd/CodeComplete.cpp:270
+ /// namespace scopes which are visible to the qualified-id completion token.
+ std::vector Scopes;
+};
sammccall wrote:
> ilya-biryukov wrote:
> > sammccall wrote:
> > > Just to chec
vladimir.plyashkun updated this revision to Diff 130578.
vladimir.plyashkun added a comment.
Fixed code review remarks.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41535
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidy.h
clang-tidy/tool/ClangTidyMain.cpp
Index: cl
On Fri, Jan 19, 2018 at 2:22 AM, Alex L wrote:
> Hi Roman,
Hi.
> This commit has caused a regression in LLVM 6 which now triggers
> -Wsign-compare for typeof(enum) and typeof(enumConstant).
Interesting, first impression is that it appears to be a false-positive.
> I filed
> https://bugs.llvm.org
miyuki added a comment.
ping
https://reviews.llvm.org/D41992
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
miyuki created this revision.
miyuki added reviewers: EricWF, mclow.lists.
Currently when a regular expression contains an invalid character
class name std::regex constructors throw an std::regex_error with
std::regex_constants::error_brack code.
This patch changes the code to std::regex_constant
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
Nice! Thanks for making the refactoring and adding tests! I think this is good
to go now.
I'm not very familiar with code outside of the index library (Driver, Basic
etc), but the changes see
krasimir updated this revision to Diff 130587.
krasimir marked an inline comment as done.
krasimir added a comment.
- Add a comment about std::string
Repository:
rC Clang
https://reviews.llvm.org/D42187
Files:
docs/ClangFormatStyleOptions.rst
include/clang/Format/Format.h
lib/Format/Co
krasimir added inline comments.
Comment at: lib/Format/ContinuationIndenter.cpp:1336
+ unsigned OldSuffixSize = 2 + OldDelimiter.size();
+ std::string RawText =
+ Current.TokenText.substr(OldPrefixSize).drop_back(OldSuffixSize);
bkramer wrote:
> Can this b
ilya-biryukov added a comment.
Just a few more NITs and we're good to go
Comment at: clang-tidy/tool/ClangTidyMain.cpp:347
+llvm::errs() << "Error: virtual filesystem overlay file '" << OverlayFile
+ << "' not found.\n";
+return nullptr;
vladimir.plyashkun updated this revision to Diff 130589.
vladimir.plyashkun added a comment.
Some more nits were fixed.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41535
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidy.h
clang-tidy/tool/ClangTidyMain.cpp
Index: cl
petarj added a comment.
This sounds as a valid improvement. Can we have this code committed?
https://reviews.llvm.org/D39053
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
RKSimon added inline comments.
Comment at: lib/Headers/immintrin.h:251
+#if !defined(_MSC_VER) || __has_feature(modules) || defined(__RDPID__)
+static __inline__ unsigned int __attribute__((__always_inline__, __nodebug__,
__target__("rdpid")))
+_rdpid_u32(void) {
---
aaron.ballman accepted this revision.
aaron.ballman added a comment.
LGTM aside from a few small nits.
Comment at: clang-tidy/fuchsia/MultipleInheritanceCheck.cpp:85
+void MultipleInheritanceCheck::registerMatchers(MatchFinder *Finder) {
+ // Match declarations which have base
ioeric added a comment.
LGTM
Comment at: clangd/CodeComplete.cpp:743
+ int NSema = 0, NIndex = 0, NBoth = 0; // Counters for logging.
+ bool Incomplete = false;
+ llvm::Optional Filter; // Initialized once Sema runs.
`InComplete` can probably be output varia
aaron.ballman added a comment.
The documentation needs to be regenerated for this patch. One thing that seems
to be inconsistent is with the "what gets matched" messages is that sometimes
it includes extra adornments like curly braces and other times it does not. It
might be good to pick a styl
aaron.ballman added inline comments.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:5902
+AST_MATCHER(FunctionDecl, hasTrailingReturn) {
+ return Node.getType()->castAs()->hasTrailingReturn();
+}
I think this may cause failed assertions on code like `void f
hokein added a comment.
looks good to me too, just a few nits.
Comment at: clangd/CodeComplete.cpp:308
+return None;
+ }
+}
add `return None` to make compiler happier? I think it might trigger
-Wreturn-type warning.
Comment at: clangd/C
sammccall added a comment.
Oops, I forgot to submit comments with my last update.
I don't think there's anything surprising so I'll land this, but let me know if
you want any changes!
Comment at: clangd/CodeComplete.cpp:339
+ std::vector Results;
+ CodeCompletionContext CCCo
kosarev updated this revision to Diff 130599.
kosarev added a comment.
- Supported propagation of TBAA info for aggregate transfers.
- Added tests on copying of `may_alias` aggregates.
https://reviews.llvm.org/D41539
Files:
lib/CodeGen/CGAtomic.cpp
lib/CodeGen/CGCall.cpp
lib/CodeGen/CGCla
sammccall marked 2 inline comments as done.
sammccall added inline comments.
Comment at: clangd/CodeComplete.cpp:308
+return None;
+ }
+}
hokein wrote:
> add `return None` to make compiler happier? I think it might trigger
> -Wreturn-type warning.
added llv
krasimir created this revision.
krasimir added a reviewer: bkramer.
Herald added a subscriber: klimek.
This patch addresses bug 36002, where a combination of options causes the line
following a short block in macro to be merged with that macro.
Repository:
rC Clang
https://reviews.llvm.org/D4
Author: sammccall
Date: Fri Jan 19 06:34:02 2018
New Revision: 322945
URL: http://llvm.org/viewvc/llvm-project?rev=322945&view=rev
Log:
[clangd] Merge index-provided completions with those from Sema.
Summary:
- we match on USR, and do a field-by-field merge if both have results
- scoring is pos
krasimir updated this revision to Diff 130604.
krasimir added a comment.
- Remove added newline
Repository:
rC Clang
https://reviews.llvm.org/D42298
Files:
lib/Format/UnwrappedLineFormatter.cpp
unittests/Format/FormatTest.cpp
Index: unittests/Format/FormatTest.cpp
=
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
sammccall marked an inline comment as done.
Closed by commit rL322945: [clangd] Merge index-provided completions with those
from Sema. (autho
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE322945: [clangd] Merge index-provided completions with
those from Sema. (authored by sammccall, committed by ).
Changed
krasimir updated this revision to Diff 130609.
krasimir added a comment.
- Remove double whitespace
Repository:
rC Clang
https://reviews.llvm.org/D42298
Files:
lib/Format/UnwrappedLineFormatter.cpp
unittests/Format/FormatTest.cpp
Index: unittests/Format/FormatTest.cpp
=
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: lib/Format/UnwrappedLineFormatter.cpp:310
+MergedLines = tryMergeSimpleBlock(I - 1, E, Limit);
+// If we managed to merge the block, discar
MTC created this revision.
MTC added reviewers: NoQ, a.sidorin, dcoughlin.
Herald added subscribers: cfe-commits, szepet, xazax.hun.
PreStmt and PostStmt callbacks for OffsetOfExpr are necessary to implement
`Cert ARR39-C: Do not add or subtract a scaled integer to a pointer`. And
should I defin
Author: sammccall
Date: Fri Jan 19 07:03:49 2018
New Revision: 322949
URL: http://llvm.org/viewvc/llvm-project?rev=322949&view=rev
Log:
[clangd] Fix memcpy(?, null, 0) UB by switching to std::copy
Modified:
clang-tools-extra/trunk/clangd/FuzzyMatch.cpp
Modified: clang-tools-extra/trunk/clang
nik added a comment.
Ping!
https://reviews.llvm.org/D40481
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: spatel
Date: Fri Jan 19 07:14:51 2018
New Revision: 322950
URL: http://llvm.org/viewvc/llvm-project?rev=322950&view=rev
Log:
[CodeGenCXX] annotate a GEP to a derived class with 'inbounds' (PR35909)
The standard says:
[expr.static.cast] p11: "If the prvalue of type “pointer to cv1 B” point
This revision was automatically updated to reflect the committed changes.
Closed by commit rL322950: [CodeGenCXX] annotate a GEP to a derived class with
'inbounds' (PR35909) (authored by spatel, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.ll
nik added a comment.
Hmm, nothing changed. So how to get rid of this correctly. Is "Abandon
Revision" the right thing to do?
Repository:
rC Clang
https://reviews.llvm.org/D42099
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://list
a.sidorin added a comment.
Hello Henry,
The patch looks reasonable. I think it can be landed after comments are
resolved.
Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:1497
+ ExplodedNodeSet PostVisit;
+ for (ExplodedNodeSet::iterator i = PreVisit.begin(), e =
hokein updated this revision to Diff 130618.
hokein marked 4 inline comments as done.
hokein added a comment.
- Rebase the patch to latest
- Update the patch based on the offline discussion
Updating D42073: [clangd] Query all visible scopes based on all visible
using-namespace declarations
=
hokein added inline comments.
Comment at: clangd/CodeComplete.cpp:270
+ /// namespace scopes which are visible to the qualified-id completion token.
+ std::vector Scopes;
+};
ilya-biryukov wrote:
> sammccall wrote:
> > ilya-biryukov wrote:
> > > sammccall wrote
ioeric updated this revision to Diff 130621.
ioeric marked 14 inline comments as done.
ioeric added a comment.
- Address review comments
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41946
Files:
clangd/CMakeLists.txt
clangd/URI.cpp
clangd/URI.h
unittests/clangd/CMakeL
ioeric added inline comments.
Comment at: clangd/URI.cpp:43
+ Body.consume_front("/");
+return llvm::sys::path::convert_to_slash(Body);
+ }
sammccall wrote:
> Don't you want the opposite here, convert from unix to native?
Ah, right!
C
sammccall added inline comments.
Comment at: clangd/URI.cpp:94
+
+std::vector createEncodeMap() {
+ std::vector Result(128, "");
Performance doesn't really matter here, but it looks like this is intended to
save time by precomputing, and I don't think it's any
Author: krasimir
Date: Fri Jan 19 08:12:37 2018
New Revision: 322954
URL: http://llvm.org/viewvc/llvm-project?rev=322954&view=rev
Log:
[clang-format] Fix shortening blocks in macros causing merged next line
Summary:
This patch addresses bug 36002, where a combination of options causes the line
fo
This revision was automatically updated to reflect the committed changes.
Closed by commit rL322954: [clang-format] Fix shortening blocks in macros
causing merged next line (authored by krasimir, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.
a.sidorin created this revision.
a.sidorin added reviewers: xazax.hun, szepet, jingham.
a.sidorin added a project: clang.
Herald added subscribers: rnkovacs, kristof.beyls, aemerson.
Also, a number of style and bug fixes was done:
- ASTImporterTest: added sanity check for source node
- ExternalAS
ilya-biryukov added a comment.
This looks good, but we should add a test.
Should've noticed that before, sorry for the slowing this down a bit more.
After the test is there, I'm happy to commit this change for you.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41535
___
Author: krasimir
Date: Fri Jan 19 08:18:47 2018
New Revision: 322956
URL: http://llvm.org/viewvc/llvm-project?rev=322956&view=rev
Log:
[clang-format] Adds a canonical delimiter to raw string formatting
Summary:
This patch adds canonical delimiter support to the raw string formatting.
This allows
This revision was automatically updated to reflect the committed changes.
Closed by commit rC322956: [clang-format] Adds a canonical delimiter to raw
string formatting (authored by krasimir, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D42187?vs=130587&id=130626#toc
Reposi
Sorry, I forgot to commit this before heading off on vacation. I'll be back
on monday.
Jon
On Fri, Jan 19, 2018 at 1:53 AM, Paul Fertser wrote:
> Hello Jonathan,
>
> On Mon, Jan 15, 2018 at 08:36:03AM -0700, Jonathan Roelofs wrote:
> > LGTM. Would you like me to commit it for you?
>
> Yes, ple
sammccall added a comment.
Sorry, our comments crossed...
Comment at: clangd/URI.cpp:57
+ Body = "/";
+Body += path::convert_to_slash(AbsolutePath, path::Style::posix);
+return (llvm::Twine(Scheme) + ":" + percentEncode(Body)).str();
ioeric wrote:
Author: djg
Date: Fri Jan 19 09:16:32 2018
New Revision: 322967
URL: http://llvm.org/viewvc/llvm-project?rev=322967&view=rev
Log:
[WebAssembly] Add target flags for sign-ext opcodes.
Add -msign-ext and -mno-sign-ext to control the new sign-ext target
feature.
Modified:
cfe/trunk/docs/ClangCo
Author: marshall
Date: Fri Jan 19 09:45:39 2018
New Revision: 322970
URL: http://llvm.org/viewvc/llvm-project?rev=322970&view=rev
Log:
More P0202 constexpr-ifying in . This commit handles 'transform'.
Modified:
libcxx/trunk/include/algorithm
libcxx/trunk/test/std/algorithms/alg.modifying
hintonda updated this revision to Diff 130638.
hintonda edited the summary of this revision.
hintonda added a comment.
- Also pass LLVM_CONFIG_EXE.
- Add llvm-objcopy, and make sure that is stage2 cache file is passed,
Repository:
rC Clang
https://reviews.llvm.org/D41829
Files:
cmake/cache
MaskRay updated this revision to Diff 130644.
MaskRay added a comment.
Revert some changes to address comments
Repository:
rC Clang
https://reviews.llvm.org/D42213
Files:
include/clang/ASTMatchers/ASTMatchers.h
Index: include/clang/ASTMatchers/ASTMatchers.h
===
compnerd accepted this revision.
compnerd added a comment.
This revision is now accepted and ready to land.
Took a bit of reading to realize that the compiler is being set to clang, and
therefore `CMAKE_ASM_COMPILER_ID` should be `Clang`.
Repository:
rC Clang
https://reviews.llvm.org/D42232
Author: marshall
Date: Fri Jan 19 10:07:29 2018
New Revision: 322975
URL: http://llvm.org/viewvc/llvm-project?rev=322975&view=rev
Log:
More P0202 constexpr-ifying in . This commit handles
replace/replace_if/replace_copy/replace_copy_if.
Modified:
libcxx/trunk/include/algorithm
libcxx/tr
MaskRay added a comment.
In https://reviews.llvm.org/D42213#981700, @aaron.ballman wrote:
> The documentation needs to be regenerated for this patch. One thing that
> seems to be inconsistent is with the "what gets matched" messages is that
> sometimes it includes extra adornments like curly br
hintonda added a comment.
Unless there's any further comment, I plan to commit these patches tomorrow.
Repository:
rCXXA libc++abi
https://reviews.llvm.org/D41623
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
qcolombet added inline comments.
Comment at: lib/Driver/ToolChains/Clang.cpp:4699
+else
+ CmdArgs.push_back("-global-isel=0");
+ }
I think that it would be useful to also set -global-isel-abort=2, so that users
can report problem early.
What do you th
hintonda added a comment.
In https://reviews.llvm.org/D42232#982043, @compnerd wrote:
> Took a bit of reading to realize that the compiler is being set to clang, and
> therefore `CMAKE_ASM_COMPILER_ID` should be `Clang`.
Thanks, I'll add that to the commit message.
Repository:
rC Clang
ht
benhamilton added a comment.
Thanks, fixed.
Comment at: clang-tidy/objc/PropertyDeclarationCheck.h:38
const std::vector SpecialAcronyms;
+const std::vector AdditionalAcronyms;
};
hokein wrote:
> nit: code indent
Ah, the previous one was wrong, I see.
benhamilton updated this revision to Diff 130657.
benhamilton marked 2 inline comments as done.
benhamilton added a comment.
- Switch to IncludeDefaultAcronyms option (defaults to 1).
- Use array for default acronyms, since we no longer need to parse it.
- Don't regex-escape default acronyms, sinc
Author: dhinton
Date: Fri Jan 19 10:31:12 2018
New Revision: 322977
URL: http://llvm.org/viewvc/llvm-project?rev=322977&view=rev
Log:
[cmake] Also pass CMAKE_ASM_COMPILER_ID to next stage when bootstrapping
Summary:
When setting CMAKE_ASM_COMPILER=clang, we also need to set
CMAKE_ASM_COMPILER_ID=
Anastasia created this revision.
Anastasia added reviewers: yaxunl, bader, hans.
https://reviews.llvm.org/D42307
Files:
docs/ReleaseNotes.rst
Index: docs/ReleaseNotes.rst
===
--- docs/ReleaseNotes.rst
+++ docs/ReleaseNotes.rst
@@
benhamilton updated this revision to Diff 130661.
benhamilton added a comment.
- Remove debugging code
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42261
Files:
clang-tidy/objc/PropertyDeclarationCheck.cpp
clang-tidy/objc/PropertyDeclarationCheck.h
docs/clang-tidy/check
This revision was automatically updated to reflect the committed changes.
Closed by commit rL322977: [cmake] Also pass CMAKE_ASM_COMPILER_ID to next
stage when bootstrapping (authored by dhinton, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.
Author: jvesely
Date: Fri Jan 19 10:57:19 2018
New Revision: 322979
URL: http://llvm.org/viewvc/llvm-project?rev=322979&view=rev
Log:
tan: Port from amd_builtins
v2: fixup constant precision
Passes piglit on turks and carrizo.
Passes CTS on carrizo
Fixes half_tan to pass CTS on carrizo
Acked-By:
Author: jvesely
Date: Fri Jan 19 10:57:22 2018
New Revision: 322980
URL: http://llvm.org/viewvc/llvm-project?rev=322980&view=rev
Log:
tanpi: Port from amd_builtins
Passes piglit on turks and carrizo.
Passes CTS on carrizo.
Acked-By: Aaron Watry
Tested-By: Aaron Watry
Signed-off-by: Jan Vesely
aaron.ballman added a comment.
In https://reviews.llvm.org/D42213#982047, @MaskRay wrote:
> In https://reviews.llvm.org/D42213#981700, @aaron.ballman wrote:
>
> > The documentation needs to be regenerated for this patch. One thing that
> > seems to be inconsistent is with the "what gets matched"
phosek added a comment.
Isn't `NO_DEFAULT_PATH` more appropriate here? That's what libc++ uses as well.
Repository:
rCXXA libc++abi
https://reviews.llvm.org/D41623
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
NoQ added a comment.
The patch seems correct, but i suspect that your overall approach to the
checker you're trying to make is not ideal. `offsetof` returns a concrete value
(because, well, symbolic `offsetof`s are not yet supported in the analyzer),
and even if you see the concrete value, you'
sammccall added a comment.
I think this mostly does the right thing, but I find some of the code
structure/description confusing.
I might have made misguided comments, happy to sit down together and work this
out :-)
Comment at: clangd/CodeComplete.cpp:316
+
+/// \brief Scope
craig.topper updated this revision to Diff 130670.
craig.topper added a comment.
Add doxygen comment
https://reviews.llvm.org/D42272
Files:
include/clang/Basic/BuiltinsX86.def
include/clang/Driver/Options.td
lib/Basic/Targets/X86.cpp
lib/Basic/Targets/X86.h
lib/Headers/immintrin.h
t
Author: ctopper
Date: Fri Jan 19 11:43:36 2018
New Revision: 322982
URL: http://llvm.org/viewvc/llvm-project?rev=322982&view=rev
Log:
[X86] Add goldmont to test/Driver/x86-march.c
Modified:
cfe/trunk/test/Driver/x86-march.c
Modified: cfe/trunk/test/Driver/x86-march.c
URL:
http://llvm.org/vi
juliehockett updated this revision to Diff 130671.
juliehockett marked 2 inline comments as done.
juliehockett added a comment.
Updating matcher and fixing semicolons
https://reviews.llvm.org/D42273
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMa
trixirt created this revision.
trixirt added reviewers: emaste, filcab, rsmith.
Herald added subscribers: cfe-commits, krytarowski.
FreeBSD's libgcc and libgcc_p are symlinks to libcompiler_rt and
libcompiler_rt_p
Start using the compiler rt libs directly.
Repository:
rC Clang
https://review
MaskRay updated this revision to Diff 130672.
MaskRay added a comment.
Address comment
Repository:
rC Clang
https://reviews.llvm.org/D42213
Files:
include/clang/ASTMatchers/ASTMatchers.h
Index: include/clang/ASTMatchers/ASTMatchers.h
===
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM with a minor commenting/documentation nit.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:5898
+/// \code
+/// int X() {};
+/// auto Y() -> int {};
--
lebedev.ri added inline comments.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:5904
+return F->hasTrailingReturn();
+ return false;
+}
There are no negative tests in the unittest that cover this false path.
https://reviews.llvm.org/D42273
___
MaskRay added a comment.
I am also not sure about this function: line 3548
/// \brief Matches \c FunctionDecls and \c FunctionProtoTypes that have a
/// specific parameter count.
///
/// Given
/// \code
/// void f(int i) {}
/// void g(int i, int j) {}
/// void h(int i, int
aaron.ballman added a comment.
In https://reviews.llvm.org/D42213#982256, @MaskRay wrote:
> I am also not sure about this function: line 3548
>
> /// \brief Matches \c FunctionDecls and \c FunctionProtoTypes that have a
> /// specific parameter count.
> ///
> /// Given
> /// \code
>
hintonda added a comment.
In https://reviews.llvm.org/D41623#982189, @phosek wrote:
> Isn't `NO_DEFAULT_PATH` more appropriate here? That's what libc++ uses as
> well.
Unfortunately no.
When cross compiling, it's important to look for headers in CMAKE_SYSROOT
and/or CMAKE_FIND_ROOT_PATH, or
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
This looks good to me.
Please add a test in test/libcxx/strings/string.modifiers and commit.
Something like this:
#include
#include
int main () {
std::string l = "Th
vitalybuka accepted this revision.
vitalybuka added a comment.
This revision is now accepted and ready to land.
LGTM, but please update the summary and git/svn patch description
Repository:
rL LLVM
https://reviews.llvm.org/D42017
___
cfe-commits
vitalybuka requested changes to this revision.
vitalybuka added a comment.
This revision now requires changes to proceed.
Please update the summary. No need to define kvm. Probably just few example of
essential functions needed by sanitizers.
Repository:
rL LLVM
https://reviews.llvm.org/D420
hintonda added a comment.
In https://reviews.llvm.org/D41623#982262, @hintonda wrote:
> In https://reviews.llvm.org/D41623#982189, @phosek wrote:
>
> > Isn't `NO_DEFAULT_PATH` more appropriate here? That's what libc++ uses as
> > well.
>
>
> Unfortunately no.
>
> When cross compiling, it's impor
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
This looks fine to me. Thanks!
Comment at: test/std/re/re.regex/re.regex.construct/bad_ctype.pass.cpp:28
+} catch (const std::regex_error &ex) {
+result
Author: rtrieu
Date: Fri Jan 19 12:46:19 2018
New Revision: 322984
URL: http://llvm.org/viewvc/llvm-project?rev=322984&view=rev
Log:
Allow BlockDecl in CXXRecord scope to have no access specifier.
Using a BlockDecl in a default member initializer causes it to be attached to
CXXMethodDecl without
yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
https://reviews.llvm.org/D42307
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
MaskRay added a comment.
In https://reviews.llvm.org/D42213#982261, @aaron.ballman wrote:
> In https://reviews.llvm.org/D42213#982256, @MaskRay wrote:
>
> > I am also not sure about this function: line 3548
> >
> > /// \brief Matches \c FunctionDecls and \c FunctionProtoTypes that have a
> >
Author: sammccall
Date: Fri Jan 19 13:58:58 2018
New Revision: 322996
URL: http://llvm.org/viewvc/llvm-project?rev=322996&view=rev
Log:
[clangd] Change index scope convention from "outer::inner" to "outer::inner::"
Global scope is "" (was "")
Top-level namespace scope is "ns::" (was "ns")
Nested
aaron.ballman added a comment.
In https://reviews.llvm.org/D42213#982385, @MaskRay wrote:
> Yes, I was asking about this because the results seemed to be wrong. I should
> have used `parameterCountIs()` to reduce the confusion :) I'll leave them
> untouched.
Alternatively, you can try out tho
Author: sammccall
Date: Fri Jan 19 14:09:34 2018
New Revision: 322998
URL: http://llvm.org/viewvc/llvm-project?rev=322998&view=rev
Log:
Revert "[clangd] Change index scope convention from "outer::inner" to
"outer::inner::""
This reverts commit r322996.
Modified:
clang-tools-extra/trunk/clan
Author: sammccall
Date: Fri Jan 19 14:18:21 2018
New Revision: 323000
URL: http://llvm.org/viewvc/llvm-project?rev=323000&view=rev
Log:
[clangd] Change index scope convention from "outer::inner" to "outer::inner::"
Global scope is "" (was "")
Top-level namespace scope is "ns::" (was "ns")
Nested
1 - 100 of 117 matches
Mail list logo
