[PATCH] D44191: Add Clang ReleaseNotes that --autocomplete breaks backward compatibily

yamaguchi created this revision. yamaguchi added reviewers: teemperor, v.g.vassilev. --autocomplete flag now handles all the flags passed to shell, and this implementation breaks backward compatibily before Clang 6.0. https://reviews.llvm.org/D44191 Files: clang/docs/ReleaseNotes.rst Index:

[PATCH] D41517: mmintrin.h documentation fixes and updates

dyung updated this revision to Diff 137333. dyung marked an inline comment as done. dyung added a comment. Update based on feedback from Simon. https://reviews.llvm.org/D41517 Files: lib/Headers/mmintrin.h Index: lib/Headers/mmintrin.h ===

[PATCH] D44069: Test Driver sanitise, unsupported on OpenBSD

krytarowski added a comment. While there can we add the remaining sanitizers here, like lsan, msan, tsan, esan etc? https://reviews.llvm.org/D44069 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

[PATCH] D43805: Optionally use nameless IR types

sepavloff updated this revision to Diff 137336. sepavloff added a comment. Use more consistent option names Repository: rC Clang https://reviews.llvm.org/D43805 Files: include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.def include/clang/Frontend/CodeGenOptions.h li

[PATCH] D43902: [clang-format] Don't detect C++11 attribute specifiers as ObjC

krasimir added inline comments. Comment at: unittests/Format/FormatTest.cpp:6068-6069 + verifyFormat("void f() [[deprecated(\"so sorry\")]];"); + verifyFormat("aa\n" + "[[unused]] aaa(int i);"); +

[PATCH] D41102: Setup clang-doc frontend framework

Athosvk added a comment. In https://reviews.llvm.org/D41102#1028760, @juliehockett wrote: > If you take a look at the follow-on patch to this (D43341 > ), you'll see that that is where the pointer > is added in (since it is irrelevant to the mapper portion, as i

[PATCH] D44191: Add Clang ReleaseNotes that --autocomplete breaks backward compatibily

yamaguchi updated this revision to Diff 137352. yamaguchi added a comment. Fixed typos https://reviews.llvm.org/D44191 Files: clang/docs/ReleaseNotes.rst Index: clang/docs/ReleaseNotes.rst === --- clang/docs/ReleaseNotes.rst ++

[PATCH] D44191: Add Clang ReleaseNotes that --autocomplete breaks backward compatibily

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D44191 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

r326889 - Add Clang ReleaseNotes that --autocomplete breaks backward compatibily

Author: yamaguchi Date: Wed Mar 7 03:34:02 2018 New Revision: 326889 URL: http://llvm.org/viewvc/llvm-project?rev=326889&view=rev Log: Add Clang ReleaseNotes that --autocomplete breaks backward compatibily Summary: --autocomplete flag now handles all the flags passed to shell, and this implement

[PATCH] D44191: Add Clang ReleaseNotes that --autocomplete breaks backward compatibily

This revision was automatically updated to reflect the committed changes. Closed by commit rL326889: Add Clang ReleaseNotes that --autocomplete breaks backward compatibily (authored by yamaguchi, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.l

[PATCH] D43906: [clang-format] Improve detection of Objective-C block types

djasper added inline comments. Comment at: lib/Format/TokenAnnotator.cpp:152 + const FormatToken *Next = CurrentToken->getNextNonComment(); + int ParenDepth = 1; + // Handle nested parens in case we have an array of blocks with No. Don't implement

[PATCH] D44203: [clang-format] Improve Incomplete detection for (text) protos

krasimir created this revision. krasimir added a reviewer: sammccall. Herald added subscribers: cfe-commits, klimek. This patch improves detection of incomplete code for protos and text protos. This is especially important for text protos in raw string literals, since they might be partial strings

[PATCH] D44204: [clang-format] Break consecutive string literals in text protos

krasimir created this revision. Herald added subscribers: cfe-commits, klimek. This patch fixes a bug where consecutive string literals in text protos were put on the same line. Repository: rC Clang https://reviews.llvm.org/D44204 Files: lib/Format/TokenAnnotator.cpp unittests/Format/For

[PATCH] D44093: [BUILTINS] structure pretty printer

paulsemel marked 2 inline comments as done. paulsemel added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:1206 +QualType Arg0Type = Arg0->getType()->getPointeeType(); +const RecordType *RT = Arg0Type->getAs(); + aaron.ballman wrote: > You can use

[PATCH] D44093: [BUILTINS] structure pretty printer

paulsemel updated this revision to Diff 137369. paulsemel added a comment. Applied Aaron suggestion changes. Added parameters checking in Sema. Repository: rC Clang https://reviews.llvm.org/D44093 Files: include/clang/Basic/Builtins.def include/clang/Basic/DiagnosticSemaKinds.td lib/Co

[PATCH] D44093: [BUILTINS] structure pretty printer

lebedev.ri added a comment. Please always upload patches with full context (-U99) Repository: rC Clang https://reviews.llvm.org/D44093 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[PATCH] D44093: [BUILTINS] structure pretty printer

paulsemel updated this revision to Diff 137371. paulsemel added a comment. Updated with more context. Repository: rC Clang https://reviews.llvm.org/D44093 Files: include/clang/Basic/Builtins.def include/clang/Basic/DiagnosticSemaKinds.td lib/CodeGen/CGBuiltin.cpp lib/Sema/SemaCheckin

[PATCH] D16632: clang-cl: Take dllexport from original function decl into account

sberg updated this revision to Diff 137374. sberg added a comment. Turns out DLLAttr-inherited-from-class is only added to members during Sema::CheckCompletedClass -> Sema::checkClassLevelDLLAttribute, when friend re-decls of those members may already have been created. https://reviews.llvm.or

Re: [PATCH] D43902: [clang-format] Don't detect C++11 attribute specifiers as ObjC

I made it longer so the two lines (__attribute__((foo)) vs. [[foo]]) had the same length. If I shorten it much more, everything goes on one line. On Wed, Mar 7, 2018, 03:42 Krasimir Georgiev via Phabricator < revi...@reviews.llvm.org> wrote: > krasimir added inline comments. > > > ==

[PATCH] D44204: [clang-format] Break consecutive string literals in text protos

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG. Thanks! Repository: rC Clang https://reviews.llvm.org/D44204 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org

[PATCH] D44173: [clang-tidy] Add "portability" module and rename readability-simd-intrinsics to portability-simd-intrinsics

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Thank you! LGTM Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44173 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D43906: [clang-format] Improve detection of Objective-C block types

benhamilton updated this revision to Diff 137394. benhamilton added a comment. - Greatly clean up ObjC block type logic by re-using `TT_FunctionTypeLParen` type logic. Repository: rC Clang https://reviews.llvm.org/D43906 Files: lib/Format/TokenAnnotator.cpp unittests/Format/FormatTest.c

[PATCH] D43906: [clang-format] Improve detection of Objective-C block types

benhamilton added inline comments. Comment at: lib/Format/TokenAnnotator.cpp:152 + const FormatToken *Next = CurrentToken->getNextNonComment(); + int ParenDepth = 1; + // Handle nested parens in case we have an array of blocks with djasper wrote: >

[PATCH] D42730: [clang-tidy]] Add check for use of types/classes/functions from header which are deprecated and removed in C++17

alexfh added inline comments. Comment at: clang-tidy/modernize/DeprecatedFunctionalCheck.cpp:48-54 + } else if (const auto *const Call = + Result.Nodes.getNodeAs("ptr_fun_call")) { +diag(Call->getLocStart(), Message) << "'std::ptr_fun'"; + } else if (const a

[PATCH] D44093: [BUILTINS] structure pretty printer

aaron.ballman added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:5022-5023 +def err_dump_struct_invalid_argument_type : Error< + "invalid argument of type %0; expected %1">; + Can you look to see if we have an existing diagnostic tha

[PATCH] D34367: CodeGen: Fix address space of indirect function argument

yaxunl marked 20 inline comments as done. yaxunl added inline comments. Comment at: lib/CodeGen/CGCall.h:248 + return HasLV ? LV.getAddress() : RV.getAggregateAddress(); +} + rjmccall wrote: > Part of my thinking in suggesting this representation change

[PATCH] D42730: [clang-tidy]] Add check for use of types/classes/functions from header which are deprecated and removed in C++17

aaron.ballman added inline comments. Comment at: clang-tidy/modernize/DeprecatedFunctionalCheck.cpp:48-54 + } else if (const auto *const Call = + Result.Nodes.getNodeAs("ptr_fun_call")) { +diag(Call->getLocStart(), Message) << "'std::ptr_fun'"; + } else if (

[PATCH] D43500: [clang-tidy]: modernize-use-default-member-init: Remove trailing comma and colon.

alexfh added inline comments. Comment at: unittests/clang-tidy/ClangTidyTest.h:145 + + if (Options.FormatStyle) { +llvm::Expected Style = format::getStyle( jdemeule wrote: > alexfh wrote: > > I wonder whether it's better to use lit for the tests that require

[PATCH] D43509: [libcxx][cmake] Remove libatomic temporarily from CMAKE_REQUIRED_LIBRARIES when configuring

sdardis added a comment. Ping. Repository: rCXX libc++ https://reviews.llvm.org/D43509 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44173: [clang-tidy] Add "portability" module and rename readability-simd-intrinsics to portability-simd-intrinsics

MaskRay updated this revision to Diff 137406. MaskRay added a comment. ReleaseNotes.rst Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44173 Files: clang-tidy/CMakeLists.txt clang-tidy/plugin/CMakeLists.txt clang-tidy/plugin/ClangTidyPlugin.cpp clang-tidy/portability/CM

[PATCH] D44173: [clang-tidy] Add "portability" module and rename readability-simd-intrinsics to portability-simd-intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rL326909: [clang-tidy] Add "portability" module and rename readability-simd-intrinsics to… (authored by MaskRay, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://r

[PATCH] D44213: [clangd] Remove unused field in HandlerRegisterer

simark updated this revision to Diff 137410. simark added a comment. Fix formatting Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44213 Files: clangd/ClangdLSPServer.cpp clangd/ProtocolHandlers.cpp clangd/ProtocolHandlers.h Index: clangd/ProtocolHandlers.h

[PATCH] D44213: [clangd] Remove unused field in HandlerRegisterer

simark created this revision. Herald added subscribers: cfe-commits, ioeric, jkorous-apple, ilya-biryukov, klimek. Tested by rebuilding. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44213 Files: clangd/ClangdLSPServer.cpp clangd/ProtocolHandlers.cpp clangd/ProtocolHand

[clang-tools-extra] r326909 - [clang-tidy] Add "portability" module and rename readability-simd-intrinsics to portability-simd-intrinsics

Author: maskray Date: Wed Mar 7 08:57:42 2018 New Revision: 326909 URL: http://llvm.org/viewvc/llvm-project?rev=326909&view=rev Log: [clang-tidy] Add "portability" module and rename readability-simd-intrinsics to portability-simd-intrinsics Reviewers: alexfh Subscribers: klimek, nemanjai, mgor

[PATCH] D43980: Push a function scope when parsing function bodies without a declaration

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Fix LGTM, one optional comment below. Comment at: clang/lib/Sema/SemaDecl.cpp:12412 +// anyway so we can try to parse the function body. +PushFunctionScope(); re

[PATCH] D43990: set dso_local on tls init functions

espindola added a comment. Richard, you added the setVisibility line, are you OK with the change? https://reviews.llvm.org/D43990 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44039: [Sema] Make getCurFunction() return null outside function parsing

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Good luck! I think the forward-looking statement in https://reviews.llvm.org/D43980 about this change here is a bit off, see below. The hasLocalStorage() comment below is probably the only in

[PATCH] D44039: [Sema] Make getCurFunction() return null outside function parsing

rnk added a comment. Thanks! Comment at: clang/include/clang/Sema/Sema.h:1320 sema::FunctionScopeInfo *getCurFunction() const { -return FunctionScopes.back(); +return FunctionScopes.empty() ? nullptr : FunctionScopes.back(); } thakis wrote: > The

[PATCH] D39562: [CodeGen][ObjC] Fix an assertion failure caused by copy elision

ahatanak updated this revision to Diff 137418. ahatanak marked an inline comment as done. ahatanak added a comment. Don't set the IsUnique bit of an OpaqueValueExpr that is used as the result expression. https://reviews.llvm.org/D39562 Files: include/clang/AST/Expr.h include/clang/AST/Stmt

[PATCH] D39562: [CodeGen][ObjC] Fix an assertion failure caused by copy elision

ahatanak added inline comments. Comment at: lib/CodeGen/CGExpr.cpp:4815 +} + } + rjmccall wrote: > Oh! So it's an interesting point that the RHS might be used as the result > expression, which means its use might not really be unique anymore. It > happen

[PATCH] D39562: [CodeGen][ObjC] Fix an assertion failure caused by copy elision

ahatanak added a comment. I also add a call to setIsUnique(false) in OpaqueValueExpr's constructor, which fixed the failing tests I was seeing. https://reviews.llvm.org/D39562 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

[PATCH] D34367: CodeGen: Fix address space of indirect function argument

yaxunl updated this revision to Diff 137421. yaxunl marked an inline comment as done. yaxunl added a comment. Revised by John's comments. Removed CallArg::getAggregateAddress(). https://reviews.llvm.org/D34367 Files: lib/CodeGen/CGAtomic.cpp lib/CodeGen/CGCall.cpp lib/CodeGen/CGCall.h l

r326922 - [OPENMP] Fix lifetime of the loop counters.

Author: abataev Date: Wed Mar 7 10:17:06 2018 New Revision: 326922 URL: http://llvm.org/viewvc/llvm-project?rev=326922&view=rev Log: [OPENMP] Fix lifetime of the loop counters. We may emit incorrect lifetime info during codegen for loop counters in OpenMP constructs because of automatic scope cl

[PATCH] D43990: set dso_local on tls init functions

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. I think Richard has been really busy preparing for some C++ committee function. I think we should go forward with this. https://reviews.llvm.org/D43990 __

[PATCH] D44217: [clang-tidy] Enable Python 3 support for add_new_check.py

jbcoe created this revision. jbcoe added a reviewer: alexfh. Herald added a subscriber: xazax.hun. In Python 3, filters are lazily evaluated and strings are not bytes. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44217 Files: clang-tools-extra/clang-tidy/add_new_check.py I

r326926 - Push a function scope when parsing function bodies without a declaration

Author: rnk Date: Wed Mar 7 10:55:10 2018 New Revision: 326926 URL: http://llvm.org/viewvc/llvm-project?rev=326926&view=rev Log: Push a function scope when parsing function bodies without a declaration Summary: This is PR36536. There are a few ways to reach Sema::ActOnStartOfFunctionDef with a

[PATCH] D43980: Push a function scope when parsing function bodies without a declaration

This revision was automatically updated to reflect the committed changes. Closed by commit rC326926: Push a function scope when parsing function bodies without a declaration (authored by rnk, committed by ). Changed prior to commit: https://reviews.llvm.org/D43980?vs=136635&id=137437#toc Repos

[PATCH] D43980: Push a function scope when parsing function bodies without a declaration

This revision was automatically updated to reflect the committed changes. Closed by commit rL326926: Push a function scope when parsing function bodies without a declaration (authored by rnk, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.

[PATCH] D44218: Correct the alignment for the PS4 target

ormris created this revision. ormris added reviewers: rsmith, craig.topper, echristo, erichkeane. See above. Repository: rC Clang https://reviews.llvm.org/D44218 Files: lib/Basic/Targets/OSTargets.h test/Preprocessor/init.c Index: test/Preprocessor/init.c ==

[PATCH] D44174: do not register matcher for objc-only checks when analyzing non-objc sources to save resources

This revision was automatically updated to reflect the committed changes. Closed by commit rL326928: do not register matcher for objc-only checks when analyzing non-objc sources to… (authored by Wizard, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://review

Re: r326926 - Push a function scope when parsing function bodies without a declaration

On Wed, Mar 7, 2018 at 1:55 PM, Reid Kleckner via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rnk > Date: Wed Mar 7 10:55:10 2018 > New Revision: 326926 > > URL: http://llvm.org/viewvc/llvm-project?rev=326926&view=rev > Log: > Push a function scope when parsing function bodies with

Re: [libcxx] r323971 - Remove ; use instead. See https://libcxx.llvm.org/TS_deprecation.html

On Sat, Feb 24, 2018 at 7:17 PM, Marshall Clow wrote: > On Thu, Feb 22, 2018 at 7:58 AM, Nico Weber wrote: > >> I have a small personal project where I used to use this. I tried >> switching to instead, but that apparently requires -std=c++17. >> With that, things build fine with my locally-bui

r326935 - [analyzer] [NFC] Minor refactoring of NonNullParamChecker

Author: george.karpenkov Date: Wed Mar 7 11:27:32 2018 New Revision: 326935 URL: http://llvm.org/viewvc/llvm-project?rev=326935&view=rev Log: [analyzer] [NFC] Minor refactoring of NonNullParamChecker Differential Revision: https://reviews.llvm.org/D43917 Modified: cfe/trunk/lib/StaticAnalyz

[PATCH] D43917: [analyzer] [NFC] Minor refactoring of NonNullParamChecker

This revision was automatically updated to reflect the committed changes. Closed by commit rC326935: [analyzer] [NFC] Minor refactoring of NonNullParamChecker (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D4

r326937 - [OpenCL] Remove block invoke function from emitted block literal struct

Author: yaxunl Date: Wed Mar 7 11:32:58 2018 New Revision: 326937 URL: http://llvm.org/viewvc/llvm-project?rev=326937&view=rev Log: [OpenCL] Remove block invoke function from emitted block literal struct OpenCL runtime tracks the invoke function emitted for any block expression. Due to restricti

[PATCH] D43783: [OpenCL] Remove block invoke function from emitted block literal struct

This revision was automatically updated to reflect the committed changes. Closed by commit rC326937: [OpenCL] Remove block invoke function from emitted block literal struct (authored by yaxunl, committed by ). Repository: rC Clang https://reviews.llvm.org/D43783 Files: lib/CodeGen/CGBlocks.

[PATCH] D44069: Test Driver sanitise, unsupported on OpenBSD

devnexen updated this revision to Diff 137447. https://reviews.llvm.org/D44069 Files: test/Driver/fsanitize.c Index: test/Driver/fsanitize.c === --- test/Driver/fsanitize.c +++ test/Driver/fsanitize.c @@ -388,6 +388,21 @@ // RUN

[PATCH] D43980: Push a function scope when parsing function bodies without a declaration

rnk added a comment. Thanks! John touched this code last in https://reviews.llvm.org/rL112038 in 2010, so maybe he has some thoughts on how to clean this and the follow-up. I think I'll land this as is since it fixes the crash and we can discuss more improvements in https://reviews.llvm.org/D4

[PATCH] D44069: Test Driver sanitise, unsupported on OpenBSD

devnexen updated this revision to Diff 137448. https://reviews.llvm.org/D44069 Files: test/Driver/fsanitize.c Index: test/Driver/fsanitize.c === --- test/Driver/fsanitize.c +++ test/Driver/fsanitize.c @@ -388,6 +388,25 @@ // RUN

[PATCH] D44221: Avoid including ScopeInfo.h from Sema.h

rnk created this revision. rnk added a reviewer: rjmccall. This provides no measurable build speedup, but it reinstates an optimization from r112038 that was lost in r179618. It requires moving CapturedScopeInfo::Capture out to clang::sema, which might be too general since we have plenty of other

[PATCH] D41102: Setup clang-doc frontend framework

lebedev.ri added a comment. In https://reviews.llvm.org/D41102#1028995, @lebedev.ri wrote: > Some further notes based on the SHA1 nature. I'm sorry, brainfreeze, i meant `40` chars, not `20`. Updated comments... Comment at: clang-doc/BitcodeWriter.cpp:309 + assert(Ref.USR.s

[PATCH] D44221: Avoid including ScopeInfo.h from Sema.h

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D44221 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

[PATCH] D44222: [AArch64] Add vmulxh_lane FP16 intrinsics

SjoerdMeijer created this revision. SjoerdMeijer added reviewers: az, evandro, olista01. Herald added subscribers: kristof.beyls, javed.absar, rengolin. Add 2 vmulxh_lane vector intrinsics that were commented out. https://reviews.llvm.org/D44222 Files: include/clang/Basic/arm_neon.td test/C

[PATCH] D34367: CodeGen: Fix address space of indirect function argument

rjmccall added inline comments. Comment at: lib/CodeGen/CGCall.cpp:3427 (void)InitialArgSize; -RValue RVArg = Args.back().RV; -EmitNonNullArgCheck(RVArg, ArgTypes[Idx], (*Arg)->getExprLoc(), AC, -ParamsToSkip + Idx); -// @llvm.objectsize s

[PATCH] D44223: [ms] Emit vtordisp initializers in a deterministic order.

thakis created this revision. thakis added a reviewer: rnk. No effective behavior change, just for cleanliness. Fixes PR36159. https://reviews.llvm.org/D44223 Files: lib/CodeGen/MicrosoftCXXABI.cpp Index: lib/CodeGen/MicrosoftCXXABI.cpp =

[PATCH] D44223: [ms] Emit vtordisp initializers in a deterministic order.

thakis added inline comments. Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:1207 + + for (const VBaseEntry E : VBases) { +if (!E.second.hasVtorDisp()) (I added the missing `&` here locally.) https://reviews.llvm.org/D44223

Re: [PATCH] D44218: Correct the alignment for the PS4 target

LGTM. On Wed, Mar 7, 2018, 11:02 AM Matthew Voss via Phabricator < revi...@reviews.llvm.org> wrote: > ormris created this revision. > ormris added reviewers: rsmith, craig.topper, echristo, erichkeane. > > See above. > > > Repository: > rC Clang > > https://reviews.llvm.org/D44218 > > Files: >

[PATCH] D44223: [ms] Emit vtordisp initializers in a deterministic order.

efriedma added inline comments. Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:1202 + SmallVector VBases(VBaseMap.begin(), VBaseMap.end()); + std::stable_sort(VBases.begin(), VBases.end(), + [](const VBaseEntry &a, const VBaseEntry &b) { Using st

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 137457. juliehockett marked 13 inline comments as done. juliehockett added a comment. Updating bitcode writer for hashed USRs, and re-running clang-format. Also cleaning up a couple of unused fields. https://reviews.llvm.org/D41102 Files: CMakeLists

RE: [PATCH] D44218: Correct the alignment for the PS4 target

Thanks! I’ll commit this. From: Eric Christopher [mailto:echri...@gmail.com] Sent: Wednesday, March 7, 2018 12:33 PM To: reviews+d44218+public+fd8ca19cc9985...@reviews.llvm.org Cc: cfe-commits@lists.llvm.org; craig.top...@gmail.com; erich.ke...@intel.com; filcab+llvm.phabrica...@gmail.com; Voss,

[PATCH] D43322: Diagnose cases of "return x" that should be "return std::move(x)" for efficiency

Quuxplusone added a comment. Btw, I'm going to be talking about this patch tonight at 7 in Palo Alto. :) https://www.meetup.com/ACCU-Bay-Area/events/248040207/ https://docs.google.com/presentation/d/18ZRnedocXSQKn9Eh67gGv-ignReHfRD7vj_dxrra1kc/ Repository: rC Clang https://reviews.llvm.org/D4

r326942 - Correct the alignment for the PS4 target

Author: ormris Date: Wed Mar 7 12:48:16 2018 New Revision: 326942 URL: http://llvm.org/viewvc/llvm-project?rev=326942&view=rev Log: Correct the alignment for the PS4 target https://reviews.llvm.org/D44218 Modified: cfe/trunk/lib/Basic/Targets/OSTargets.h cfe/trunk/test/Preprocessor/init

[PATCH] D34367: CodeGen: Fix address space of indirect function argument

yaxunl updated this revision to Diff 137460. yaxunl marked an inline comment as done. yaxunl edited the summary of this revision. yaxunl added a comment. Added comment about emit non-null argument check. https://reviews.llvm.org/D34367 Files: lib/CodeGen/CGAtomic.cpp lib/CodeGen/CGCall.cpp

[PATCH] D34367: CodeGen: Fix address space of indirect function argument

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks. LGTM! https://reviews.llvm.org/D34367 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

[PATCH] D44222: [AArch64] Add vmulxh_lane FP16 intrinsics

evandro accepted this revision. evandro added a comment. This revision is now accepted and ready to land. Looks pretty straightforward to me. https://reviews.llvm.org/D44222 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.o

[PATCH] D44223: [ms] Emit vtordisp initializers in a deterministic order.

thakis updated this revision to Diff 137463. thakis added a comment. Herald added a subscriber: mgrang. sort unstably https://reviews.llvm.org/D44223 Files: lib/CodeGen/MicrosoftCXXABI.cpp Index: lib/CodeGen/MicrosoftCXXABI.cpp ===

[PATCH] D44223: [ms] Emit vtordisp initializers in a deterministic order.

rnk added a comment. Thanks for investigating! Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:1206 + + for (const VBase &V : VBases) { +if (!V.second.hasVtorDisp()) I think we can avoid the sort altogether if we iterate `RD->vbases()`, which should already b

Re: r326602 - [Attr] Fix parameter indexing for several attributes

(I had to revert this since it caused https://bugs.llvm.org/show_bug.cgi?id=36620) On Fri, Mar 2, 2018 at 2:03 PM, Joel E. Denny via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: jdenny > Date: Fri Mar 2 11:03:22 2018 > New Revision: 326602 > > URL: http://llvm.org/viewvc/llvm-proje

r326945 - [clang-format] Break consecutive string literals in text protos

Author: krasimir Date: Wed Mar 7 13:30:38 2018 New Revision: 326945 URL: http://llvm.org/viewvc/llvm-project?rev=326945&view=rev Log: [clang-format] Break consecutive string literals in text protos Summary: This patch fixes a bug where consecutive string literals in text protos were put on the s

[PATCH] D44204: [clang-format] Break consecutive string literals in text protos

This revision was automatically updated to reflect the committed changes. Closed by commit rL326945: [clang-format] Break consecutive string literals in text protos (authored by krasimir, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D442

[PATCH] D41102: Setup clang-doc frontend framework

lebedev.ri added a comment. Hmm, i'm missing something about the way store sha1... Comment at: clang-doc/BitcodeWriter.cpp:53 +{// 0. Fixed-size integer (length of the sha1'd USR) + llvm::BitCodeAbbrevOp(llvm::BitCodeAbbrevOp::VBR, +

[PATCH] D44213: [clangd] Remove unused field in HandlerRegisterer

malaperle accepted this revision. malaperle added a comment. This revision is now accepted and ready to land. LGTM Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://l

[PATCH] D44189: [RISCV] Verify the input value of -march=

apazos added inline comments. Comment at: lib/Driver/ToolChains/Arch/RISCV.cpp:48 + break; +default: + // First letter should be 'i' or 'g'. In the switch cases move default to first position. Comment at: lib/Driver/ToolChains/Arc

r326946 - CodeGen: Fix address space of indirect function argument

Author: yaxunl Date: Wed Mar 7 13:45:40 2018 New Revision: 326946 URL: http://llvm.org/viewvc/llvm-project?rev=326946&view=rev Log: CodeGen: Fix address space of indirect function argument The indirect function argument is in alloca address space in LLVM IR. However, during Clang codegen for C++

[PATCH] D34367: CodeGen: Fix address space of indirect function argument

This revision was automatically updated to reflect the committed changes. Closed by commit rL326946: CodeGen: Fix address space of indirect function argument (authored by yaxunl, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D34367?vs

[PATCH] D44213: [clangd] Remove unused field in HandlerRegisterer

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE326947: [clangd] Remove unused field in HandlerRegisterer (authored by simark, committed by ). Changed prior to commit: https://reviews.llvm.org/D44213?vs=137410&id=137471#toc Repository: rCTE Clan

Re: r326602 - [Attr] Fix parameter indexing for several attributes

Joel, can you investigate the issue? ~Aaron On Wed, Mar 7, 2018 at 4:32 PM, Nico Weber via cfe-commits wrote: > (I had to revert this since it caused > https://bugs.llvm.org/show_bug.cgi?id=36620) > > On Fri, Mar 2, 2018 at 2:03 PM, Joel E. Denny via cfe-commits > wrote: >> >> Author: jdenny >>

[PATCH] D44039: [Sema] Make getCurFunction() return null outside function parsing

rnk updated this revision to Diff 137472. rnk added a comment. Bring back Sema::setFunctionHas* methods which internally do nothing when called outside function scope. This appears to happen in practice when parsing invalid code involving things like statement expressions, VLAs at global scope, et

[PATCH] D44223: [ms] Emit vtordisp initializers in a deterministic order.

thakis updated this revision to Diff 137470. thakis added a comment. rnk comment https://reviews.llvm.org/D44223 Files: lib/CodeGen/MicrosoftCXXABI.cpp Index: lib/CodeGen/MicrosoftCXXABI.cpp === --- lib/CodeGen/MicrosoftCXXABI.

[PATCH] D44223: [ms] Emit vtordisp initializers in a deterministic order.

thakis marked an inline comment as done. thakis added inline comments. Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:1206 + + for (const VBase &V : VBases) { +if (!V.second.hasVtorDisp()) rnk wrote: > I think we can avoid the sort altogether if we iterate `RD-

[PATCH] D44226: [clangd] Add -log-to-stderr option

simark created this revision. Herald added subscribers: cfe-commits, ioeric, JDevlieghere, jkorous-apple, ilya-biryukov, klimek. Currently, clangd prints all the LSP communication on stderr. While this is good for developping, I don't think it's good as a general default. For example, we are in

[clang-tools-extra] r326928 - do not register matcher for objc-only checks when analyzing non-objc sources to save resources

Author: wizard Date: Wed Mar 7 10:59:25 2018 New Revision: 326928 URL: http://llvm.org/viewvc/llvm-project?rev=326928&view=rev Log: do not register matcher for objc-only checks when analyzing non-objc sources to save resources Summary: I did not put lang opt check in AvoidSpinlockCheck since OS

[PATCH] D44223: [ms] Emit vtordisp initializers in a deterministic order.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:1207 uint64_t ConstantVBaseOffset = -Layout.getVBaseClassOffset(I->first).getQuantity(); +Layout.getVBaseClass

r326948 - [OpenMP] Remove implicit data sharing code gen that aims to use device shared memory

Author: gbercea Date: Wed Mar 7 13:59:50 2018 New Revision: 326948 URL: http://llvm.org/viewvc/llvm-project?rev=326948&view=rev Log: [OpenMP] Remove implicit data sharing code gen that aims to use device shared memory Summary: Remove this scheme for now since it will be covered by another more

[PATCH] D43625: [OpenMP] Remove implicit data sharing code gen that aims to use device shared memory

This revision was automatically updated to reflect the committed changes. Closed by commit rC326948: [OpenMP] Remove implicit data sharing code gen that aims to use device shared… (authored by gbercea, committed by ). Changed prior to commit: https://reviews.llvm.org/D43625?vs=136570&id=137475#

[PATCH] D37994: Implement LWG2946: More ambiguity in `string` vs. `string_view`

mclow.lists updated this revision to Diff 137474. mclow.lists added a comment. Added the proposed resolution for https://wg21.link/lwg3075 as well, and some deduction guide tests for `string_view` https://reviews.llvm.org/D37994 Files: include/string test/std/strings/basic.string/string.co

[PATCH] D44226: [clangd] Add -log-lsp-to-stderr option

simark updated this revision to Diff 137478. simark added a comment. Changed -log-to-stderr to -log-lsp-to-stderr The first version disabled a bit too much, this version removes the LSP communication logging in a more fine grained way. Repository: rCTE Clang Tools Extra https://reviews.llvm.

r326951 - [analyzer] Don't crash with assertion failure on structured bindings

Author: george.karpenkov Date: Wed Mar 7 14:20:35 2018 New Revision: 326951 URL: http://llvm.org/viewvc/llvm-project?rev=326951&view=rev Log: [analyzer] Don't crash with assertion failure on structured bindings Proper modeling still remains to be done. Note that BindingDecl#getHoldingVar() is al

r326952 - [analyzer] [PointerArithChecker] do not warn on indexes into vector types

Author: george.karpenkov Date: Wed Mar 7 14:20:39 2018 New Revision: 326952 URL: http://llvm.org/viewvc/llvm-project?rev=326952&view=rev Log: [analyzer] [PointerArithChecker] do not warn on indexes into vector types rdar://35041502 Differential Revision: https://reviews.llvm.org/D44172 Modifie

[PATCH] D44183: [analyzer] Don't crash with assertion failure on structured bindings

This revision was automatically updated to reflect the committed changes. Closed by commit rC326951: [analyzer] Don't crash with assertion failure on structured bindings (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://revie

  1   2   >