r331137 - Fix printing of reference-to-reference types.

Author: rsmith Date: Sat Apr 28 22:33:38 2018 New Revision: 331137 URL: http://llvm.org/viewvc/llvm-project?rev=331137&view=rev Log: Fix printing of reference-to-reference types. Previously we would sometimes print these as 'T &&&' or even 'T '. Modified: cfe/trunk/lib/AST/TypePrinter.cp

[PATCH] D46218: PR37275 packed attribute should not apply to base classes

rsmith added a comment. In https://reviews.llvm.org/D46218#1081933, @rjmccall wrote: > Have you checked whether we do the right thing with `#pragma pack` on MSVC? Great question, I hadn't. Both MSVC and GCC treat `#pragma pack` as applying to base classes, which is what we do with/without this

[PATCH] D46218: PR37275 packed attribute should not apply to base classes

This revision was automatically updated to reflect the committed changes. Closed by commit rL331136: PR37275 packed attribute should not apply to base classes (authored by rsmith, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D46218?v

r331136 - PR37275 packed attribute should not apply to base classes

Author: rsmith Date: Sat Apr 28 21:55:46 2018 New Revision: 331136 URL: http://llvm.org/viewvc/llvm-project?rev=331136&view=rev Log: PR37275 packed attribute should not apply to base classes Clang incorrectly applied the packed attribute to base classes. Per GCC's documentation and as can be obse

[PATCH] D46230: For x86_64, gcc 7.2 under Amazon Linux AMI sets its paths to x86_64-amazon-linux

gaijiading created this revision. gaijiading added a reviewer: rsmith. gaijiading added a project: clang. Herald added a subscriber: cfe-commits. For x86_64, gcc 7.2 under Amazon Linux AMI sets its paths to x86_64-amazon-linux gcc 7.2 under Amazon Linux AMI sets its paths to x86_64-amazon-linux.

r331124 - Remove unused includes of clang/Config/config.h

Author: nico Date: Sat Apr 28 16:48:36 2018 New Revision: 331124 URL: http://llvm.org/viewvc/llvm-project?rev=331124&view=rev Log: Remove unused includes of clang/Config/config.h Found by opening config.h.cmake in vim, finding all defined macros with /define\(01\)\? \zs[A-Za-z0-9_]* :%s//\=s

Re: r331077 - Revert r329698 (and r329702).

Looks like this helped :-/ http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/10262 On Fri, Apr 27, 2018, 4:33 PM Nico Weber via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: nico > Date: Fri Apr 27 13:29:57 2018 > New Revision: 331077 > > URL: http://llvm.org/viewvc/llvm

[PATCH] D44609: [Clang-Format] New option BreakBeforeLambdaBody to manage lambda line break inside function parameter call

Wawha updated this revision to Diff 144460. Wawha added a reviewer: klimek. Wawha added a comment. Hi klimek, I upload a new patch with the modifications you proposed. The option is now enable by default in Allman style. So I move the option to the BraceWrappingFlags struct, which make more sense

Re: If I want to disable certain attributes, such as "swiftcall", is there any way to do it now?

On Fri, Apr 27, 2018 at 11:23 PM, 朴素 via cfe-commits wrote: >As the title says,thanks. You could build a custom clang with specific attributes removed, but there are no compiler flags that allow you to disable arbitrary attributes like swiftcall. ~Aaron __

[PATCH] D45444: [clang-tidy] WIP: implement new check for const-correctness

JonasToth updated this revision to Diff 144458. JonasToth added a comment. - [Feature] use new statefull const checker - [Test] add more tests finding false positives Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45444 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt cla

[PATCH] D45679: [clang-tidy] Add a helper function isModified, that checks whether an expression is modified within a statement.

JonasToth added a comment. There is a false positive with the reference checking. Could you please take a look at it? I could not find the reason from inspecting your code. void false_positive() { // FIXME False positive int np_local0 = 42; // CHECK-MESSAGES: [[@LINE-1]]:3

[PATCH] D21852: [Driver][OpenMP] Update actions builder to create bundling action when necessary.

lijiansong added a comment. hello, if I want to compile device-only device code, e.g. clang foo.mlu a.cpp -o bar, I want to get the following action graph: for foo.mlu: input -> preprocess->compile->backend->assemble , Then i will get foo.o, for a.cpp: input -> preprocess->compile->backend->assem

[PATCH] D21852: [Driver][OpenMP] Update actions builder to create bundling action when necessary.

lijiansong added inline comments. Herald added a subscriber: guansong. Comment at: lib/Driver/Driver.cpp:2113-2124 +// the resulting list. Otherwise, just append the device actions. +if (CanUseBundler && !OffloadAL.empty()) { + // Add the host action to the list in o

[PATCH] D46052: GNUstep Objective-C ABI version 2

theraven added inline comments. Comment at: lib/CodeGen/CGObjCGNU.cpp:977 +if ((CGM.getTarget().getPointerWidth(0) == 64) && +(SL->getLength() < 9) && !isNonASCII) { + // Tiny strings are (roughly): rjmccall wrote: > Please hoist `SL->getLength()

[PATCH] D45532: [StaticAnalyzer] Checker to find uninitialized fields after a constructor call

Szelethus updated this revision to Diff 10. Szelethus added a comment. Forgot to rename the system header simulator file. Sorry about the spam :) https://reviews.llvm.org/D45532 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/Sta

[PATCH] D45532: [StaticAnalyzer] Checker to find uninitialized fields after a constructor call

Szelethus marked an inline comment as done. Szelethus added inline comments. Comment at: test/Analysis/cxx-uninitialized-object.cpp:526 + +void f23p5() { + void *vptr = malloc(sizeof(int)); I haven't marked @a.sidorin's comment as done, but it disappeared becaus

[PATCH] D45532: [StaticAnalyzer] Checker to find uninitialized fields after a constructor call

Szelethus updated this revision to Diff 144439. Szelethus marked an inline comment as done. Szelethus added a comment. Renamed the checker to `cplusplus.uninitialized.UninitializedObject`. I've read your comments regarding the category this should be in thoroughly, and should the clang-tidy cate