[libcxx] r333910 - Merging r333467:

Author: tstellar Date: Mon Jun 4 08:49:27 2018 New Revision: 333910 URL: http://llvm.org/viewvc/llvm-project?rev=333910=rev Log: Merging r333467: r333467 | marshall | 2018-05-29 15:25:42 -0700 (Tue, 29 May 2018) | 1 line

[PATCH] D47687: fix: [Bug 18971] - Missing -Wparentheses warning

Higuoxing added a comment. Thanks for reviewing! I think the logic that *do not emit warning in macros* is not so proper ... Best Regards, Xing https://reviews.llvm.org/D47687 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D47694: [CUDA][HIP] Do not emit type info when compiling for device

rjmccall added a comment. In https://reviews.llvm.org/D47694#1120375, @yaxunl wrote: > In https://reviews.llvm.org/D47694#1120367, @rjmccall wrote: > > > Why not just have the driver disable RTTI in the frontend invocation? > > > CUDA/HIP uses single source for device and host. The host code may

[PATCH] D47627: [ASTContext] Make getAddrSpaceQualType replace address spaces.

rjmccall added a comment. Well, Sema should always be diagnosing conflicts. If you don't have a specific reason to allow replacement, I would prefer just fixing the documentation to state this as a precondition. Repository: rC Clang https://reviews.llvm.org/D47627

[PATCH] D47687: fix: [Bug 18971] - Missing -Wparentheses warning

dblaikie added a subscriber: Higuoxing. dblaikie added a comment. Probably CC someone from apple here & ask about rdar://8678458 - they can look it up & provide the missing context. https://reviews.llvm.org/D47687 ___ cfe-commits mailing list

Re: [PATCH] D47687: fix: [Bug 18971] - Missing -Wparentheses warning

Probably CC someone from apple here & ask about rdar://8678458 - they can look it up & provide the missing context. On Mon, Jun 4, 2018 at 8:17 AM Roman Lebedev via Phabricator < revi...@reviews.llvm.org> wrote: > lebedev.ri added reviewers: rjmccall, akyrtzi. > lebedev.ri added a comment. > >

[PATCH] D47687: fix: [Bug 18971] - Missing -Wparentheses warning

lebedev.ri added reviewers: rjmccall, akyrtzi. lebedev.ri added a comment. It seems it was https://reviews.llvm.org/rL119537 that regressed it. Nice, such a change, no review, no test :) https://reviews.llvm.org/D47687 ___ cfe-commits mailing list

[PATCH] D46943: [clangd] Boost scores for decls from current file in completion

sammccall added inline comments. Comment at: unittests/clangd/QualityTests.cpp:129 + Test.Code = R"cpp( +#include "foo.h" +int ::test_func_in_header_and_cpp() { ilya-biryukov wrote: > sammccall wrote: > > this is not needed, the `#include` is implicit

[PATCH] D47720: [DebugInfo] Inline for without DebugLocation

gramanas created this revision. gramanas added a reviewer: vsk. Herald added subscribers: cfe-commits, JDevlieghere, eraman, aprantl. This test is a strip down version of a function inside the amalgamated sqlite source. When converted to IR clang produces a phi instruction without debug location.

[PATCH] D47687: fix: [Bug 18971] - Missing -Wparentheses warning

lebedev.ri added subscribers: dblaikie, rnk. lebedev.ri added a comment. In https://reviews.llvm.org/D47687#1120971, @Higuoxing wrote: > Update with test cases :) Thanks. I do believe we are being overly forgiving for macros. Sometimes that makes sense, sometimes not, especially there is no

r333899 - Created a tiny SMT interface and make Z3ConstraintManager implement it

Author: mramalho Date: Mon Jun 4 07:25:58 2018 New Revision: 333899 URL: http://llvm.org/viewvc/llvm-project?rev=333899=rev Log: Created a tiny SMT interface and make Z3ConstraintManager implement it Summary: This patch implements a simple SMTConstraintManager API, and requires the

r333903 - [analyzer] False positive refutation with Z3

Author: mramalho Date: Mon Jun 4 07:40:44 2018 New Revision: 333903 URL: http://llvm.org/viewvc/llvm-project?rev=333903=rev Log: [analyzer] False positive refutation with Z3 Summary: This is a prototype of a bug reporter visitor that invalidates bug reports by re-checking constraints of

[PATCH] D47394: [OpenMP][Clang][NVPTX] Replace bundling with partial linking for the OpenMP NVPTX device offloading toolchain

gtbercea added a comment. In https://reviews.llvm.org/D47394#1120255, @Hahnfeld wrote: > In https://reviews.llvm.org/D47394#1119489, @gtbercea wrote: > > > In https://reviews.llvm.org/D47394#1119056, @Hahnfeld wrote: > > > > > Hmm, maybe the scope is much larger: I just tried linking an

[PATCH] D46943: [clangd] Boost scores for decls from current file in completion

sammccall added a comment. oops, just saw this is closed - will fix these nits as I'm touching this file soon Comment at: clangd/Quality.h:68 + /// Proximity between the best declaration and the query location. [0-1] score + /// where 1 is closest + float ProximityScore =

[PATCH] D46943: [clangd] Boost scores for decls from current file in completion

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE333906: [clangd] Boost scores for decls from current file in completion (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D46943?vs=149765=149771#toc

[clang-tools-extra] r333906 - [clangd] Boost scores for decls from current file in completion

Author: ibiryukov Date: Mon Jun 4 07:50:59 2018 New Revision: 333906 URL: http://llvm.org/viewvc/llvm-project?rev=333906=rev Log: [clangd] Boost scores for decls from current file in completion Summary: This should, arguably, give better ranking. Reviewers: ioeric, sammccall Reviewed By:

[PATCH] D46943: [clangd] Boost scores for decls from current file in completion

ilya-biryukov added inline comments. Comment at: clangd/Quality.h:52 unsigned References = 0; + float ProximityScore = 0.0; /// Proximity score, in a [0,1] interval. sammccall wrote: > this belongs in `SymbolRelevanceSignals` rather than this struct. In >

[PATCH] D47190: [Driver] Add -ivfsoverlay-lib option to load VFS from shared library

asavonic updated this revision to Diff 149763. asavonic added a comment. Addressed CR comments, added a diagnostic if shared library was not loaded. https://reviews.llvm.org/D47190 Files: include/clang/Basic/DiagnosticFrontendKinds.td include/clang/Driver/Options.td

[PATCH] D47687: fix: [Bug 18971] - Missing -Wparentheses warning

Higuoxing updated this revision to Diff 149766. Higuoxing edited the summary of this revision. Higuoxing added a comment. Update with test cases :) https://reviews.llvm.org/D47687 Files: lib/Sema/SemaExpr.cpp test/Sema/parentheses.c Index: test/Sema/parentheses.c

[PATCH] D46943: [clangd] Boost scores for decls from current file in completion

ilya-biryukov updated this revision to Diff 149765. ilya-biryukov marked 5 inline comments as done. ilya-biryukov added a comment. - Address review comments Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D46943 Files: clangd/Quality.cpp clangd/Quality.h

[PATCH] D45517: [analyzer] False positive refutation with Z3

This revision was automatically updated to reflect the committed changes. Closed by commit rC333903: [analyzer] False positive refutation with Z3 (authored by mramalho, committed by ). Changed prior to commit: https://reviews.llvm.org/D45517?vs=149664=149764#toc Repository: rC Clang

[PATCH] D47689: Created a tiny SMT interface and make Z3ConstraintManager implement it

This revision was automatically updated to reflect the committed changes. Closed by commit rC333899: Created a tiny SMT interface and make Z3ConstraintManager implement it (authored by mramalho, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang

[PATCH] D47643: Rewrite JSON dispatcher loop using C IO (FILE*) instead of std::istream.

sammccall added inline comments. Comment at: clangd/JSONRPCDispatcher.cpp:70 } - log(llvm::Twine("--> ") + S); + log(llvm::Twine("--> ") + S + "\n"); } ilya-biryukov wrote: > Log adds a newline for us, right? Why do we want two newlines here? Oops, forgot

[PATCH] D47643: Rewrite JSON dispatcher loop using C IO (FILE*) instead of std::istream.

ilya-biryukov added a subscriber: hokein. ilya-biryukov added a comment. The change LG, but I'm not a big expert on C APIs, so I might've missed something. @ioeric, @hokein, maybe you have some experience with those and want to take a look? PS I've checked it on my Mac and lldb seems to attach

[clang-tools-extra] r333897 - [clangd] Fix inverted test (--gtest_filter strikes again...)

Author: sammccall Date: Mon Jun 4 06:28:17 2018 New Revision: 333897 URL: http://llvm.org/viewvc/llvm-project?rev=333897=rev Log: [clangd] Fix inverted test (--gtest_filter strikes again...) Modified: clang-tools-extra/trunk/unittests/clangd/XRefsTests.cpp Modified:

[PATCH] D47592: [AArch64] Corrected FP16 Intrinsic range checks in Clang + added Sema tests

LukeGeeson marked 2 inline comments as done. LukeGeeson added inline comments. Comment at: lib/Sema/SemaChecking.cpp:1409 - switch (BuiltinID) { -#define GET_NEON_OVERLOAD_CHECK -#include "clang/Basic/arm_neon.inc" SjoerdMeijer wrote: > Why do we need to remove

[PATCH] D47707: [clangd] Downrank symbols with reserved names (score *= 0.1)

ilya-biryukov added a comment. After chatting offline: a FIXME mentioning some special cases seems enough here, we do improve the results in most cases (i.e. for queries that don't start with an underscore). Another NIT: Maybe we could add unittests for names that start with underscore, but

[PATCH] D47196: [Time-report ](2): Recursive timers in Clang

avt77 updated this revision to Diff 149734. avt77 added a comment. To simplify the review I removed all LLVM_DEBUG items - now the patch is really shorter than it was before. https://reviews.llvm.org/D47196 Files: include/clang/Frontend/Utils.h lib/CodeGen/CodeGenAction.cpp

[PATCH] D47707: [clangd] Downrank symbols with reserved names (score *= 0.1)

sammccall updated this revision to Diff 149735. sammccall added a comment. FIXMEs pertaining to queries beginning with _, and standard _Names Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D47707 Files: clangd/Quality.cpp clangd/Quality.h unittests/clangd/QualityTests.cpp

[PATCH] D47707: [clangd] Downrank symbols with reserved names (score *= 0.1)

sammccall added a comment. In https://reviews.llvm.org/D47707#1120734, @ilya-biryukov wrote: > Is there a way to only downrank them if the query does not start with `_`? > That would cover the cases when I **do** want the symbols starting with > underscore. This is hard for a few reasons: -

Re: r333874 - Reland "Move #include manipulation code to new lib/Tooling/Inclusions."

What’s stopping the project from automatically setting BUILD_SHARED_LIBS to TRUE if asserts are enabled? That’d automatically “force” active developers to test the scenario on their local machines, but not change the way release builds work. > On Jun 4, 2018, at 8:11 AM, Roman Lebedev via

Re: r333874 - Reland "Move #include manipulation code to new lib/Tooling/Inclusions."

Thanks for fixing this Roman! On Mon, Jun 4, 2018 at 2:11 PM Roman Lebedev wrote: > This broke building as shared libraries. > > I've committed the fix, but the bot coverage is clearly severely missing, > given that such breakages are very often. > > Roman. > > On Mon, Jun 4, 2018 at 12:04 PM,

Re: r333874 - Reland "Move #include manipulation code to new lib/Tooling/Inclusions."

This broke building as shared libraries. I've committed the fix, but the bot coverage is clearly severely missing, given that such breakages are very often. Roman. On Mon, Jun 4, 2018 at 12:04 PM, Eric Liu via cfe-commits wrote: > Author: ioeric > Date: Mon Jun 4 02:04:12 2018 > New Revision:

Re: r333874 - Reland "Move #include manipulation code to new lib/Tooling/Inclusions."

FYI – This broke `cmake -DBUILD_SHARED_LIBS=TRUE` builds. > On Jun 4, 2018, at 5:04 AM, Eric Liu via cfe-commits > wrote: > > Author: ioeric > Date: Mon Jun 4 02:04:12 2018 > New Revision: 333874 > > URL: http://llvm.org/viewvc/llvm-project?rev=333874=rev > Log: > Reland "Move #include

Re: [clang-tools-extra] r333891 - [clang][tooling] Don't forget to link to clangToolingInclusions.

That was supposed to be "[clangd][tests] Don't forget to link to clangToolingInclusions.". On Mon, Jun 4, 2018 at 3:04 PM, Roman Lebedev via cfe-commits wrote: > Author: lebedevri > Date: Mon Jun 4 05:04:51 2018 > New Revision: 333891 > > URL: http://llvm.org/viewvc/llvm-project?rev=333891=rev

[clang-tools-extra] r333891 - [clang][tooling] Don't forget to link to clangToolingInclusions.

Author: lebedevri Date: Mon Jun 4 05:04:51 2018 New Revision: 333891 URL: http://llvm.org/viewvc/llvm-project?rev=333891=rev Log: [clang][tooling] Don't forget to link to clangToolingInclusions. Fixes build with shared libs, broken by rL333874. Some buildbot converage is sorely missing.

r333890 - [clang][tooling] Don't forget to link to clangToolingInclusions.

Author: lebedevri Date: Mon Jun 4 05:04:41 2018 New Revision: 333890 URL: http://llvm.org/viewvc/llvm-project?rev=333890=rev Log: [clang][tooling] Don't forget to link to clangToolingInclusions. Fixes build with shared libs, broken by rL333874. Some buildbot converage is sorely missing.

[PATCH] D47707: [clangd] Downrank symbols with reserved names (score *= 0.1)

ilya-biryukov added a comment. Is there a way to only downrank them if the query does not start with `_`? That would cover the cases when I **do** want the symbols starting with underscore. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D47707

[PATCH] D47707: [clangd] Downrank symbols with reserved names (score *= 0.1)

sammccall updated this revision to Diff 149732. sammccall added a comment. Forgot to add to debug string. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D47707 Files: clangd/Quality.cpp clangd/Quality.h unittests/clangd/QualityTests.cpp Index:

[PATCH] D47707: [clangd] Downrank symbols with reserved names (score *= 0.1)

sammccall created this revision. sammccall added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, jkorous, MaskRay, ioeric, klimek. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D47707 Files: clangd/Quality.cpp clangd/Quality.h

[PATCH] D46684: [Frontend] Don't skip function body when the return type is dependent on the template parameter.

hokein abandoned this revision. hokein added a comment. Abandon this, since @ilya-biryukov has fixed it in https://reviews.llvm.org/D44480. Repository: rC Clang https://reviews.llvm.org/D46684 ___ cfe-commits mailing list

[PATCH] D47623: [clangd] Avoid indexing decls associated with friend decls.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE333885: [clangd] Avoid indexing decls associated with friend decls. (authored by ioeric, committed by ). Changed prior to commit: https://reviews.llvm.org/D47623?vs=149723=149724#toc Repository:

[clang-tools-extra] r333885 - [clangd] Avoid indexing decls associated with friend decls.

Author: ioeric Date: Mon Jun 4 04:31:55 2018 New Revision: 333885 URL: http://llvm.org/viewvc/llvm-project?rev=333885=rev Log: [clangd] Avoid indexing decls associated with friend decls. Summary: These decls are sometime used as the canonical declarations (e.g. for go-to-def), which seems to

[PATCH] D47623: [clangd] Avoid indexing decls associated with friend decls.

ioeric updated this revision to Diff 149723. ioeric added a comment. - Revert unintended changes. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D47623 Files: clangd/index/SymbolCollector.cpp clangd/index/SymbolCollector.h unittests/clangd/SymbolCollectorTests.cpp

[PATCH] D47704: [clang-tidy] Improve string type matcher for abseil-string-find-starts-with check.

hokein created this revision. hokein added a reviewer: alexfh. Herald added subscribers: xazax.hun, klimek. This patch improves the check to match the desugared "string" type (so that it can handle custom-implemented string classes), see the newly-added test. Repository: rCTE Clang Tools

[PATCH] D47623: [clangd] Avoid indexing decls associated with friend decls.

ioeric updated this revision to Diff 149721. ioeric marked an inline comment as done. ioeric added a comment. Herald added a subscriber: mgorny. - Addressed review comment. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D47623 Files: clangd/CMakeLists.txt clangd/Headers.h

[PATCH] D47623: [clangd] Avoid indexing decls associated with friend decls.

ioeric added a comment. In https://reviews.llvm.org/D47623#1120547, @ilya-biryukov wrote: > In https://reviews.llvm.org/D47623#1119426, @ioeric wrote: > > > Sorry for the late response Ilya. I was trying to test these cases. So, > > with the current change, if a real "canonical" declaration

[PATCH] D47623: [clangd] Avoid indexing decls associated with friend decls.

sammccall accepted this revision. sammccall added inline comments. Comment at: clangd/index/SymbolCollector.cpp:302 + // A declaration created for a friend declaration should not be used as the + // canonical declaration in the index. If D is a defintion and is not OrigD, +

[PATCH] D47699: [clangd] Remove the dead offset fields in Symbol.

This revision was automatically updated to reflect the committed changes. Closed by commit rL333882: [clangd] Remove the dead offset fields in Symbol. (authored by hokein, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D47699 Files:

[clang-tools-extra] r333882 - [clangd] Remove the dead offset fields in Symbol.

Author: hokein Date: Mon Jun 4 03:43:59 2018 New Revision: 333882 URL: http://llvm.org/viewvc/llvm-project?rev=333882=rev Log: [clangd] Remove the dead offset fields in Symbol. Reviewers: sammccall Subscribers: klimek, ilya-biryukov, ioeric, MaskRay, jkorous, cfe-commits Differential

[PATCH] D45532: [StaticAnalyzer] Checker to find uninitialized fields after a constructor call

Szelethus marked 5 inline comments as done. Szelethus added a comment. In https://reviews.llvm.org/D45532#1116992, @george.karpenkov wrote: > @Szelethus I personally really like this idea, and I think it would be a > great checker. > Could you perform more evaluation on other projects?

[clang-tools-extra] r333881 - [clangd] Hover should return null when not hovering over anything.

Author: sammccall Date: Mon Jun 4 03:37:16 2018 New Revision: 333881 URL: http://llvm.org/viewvc/llvm-project?rev=333881=rev Log: [clangd] Hover should return null when not hovering over anything. Summary: Also made JSON serialize Optional to simplify this. Reviewers: ioeric Subscribers:

[PATCH] D47701: [clangd] Hover should return null when not hovering over anything.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE333881: [clangd] Hover should return null when not hovering over anything. (authored by sammccall, committed by ). Changed prior to commit: https://reviews.llvm.org/D47701?vs=149701=149705#toc

[PATCH] D47701: [clangd] Hover should return null when not hovering over anything.

ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. lgtm Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D47701 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D47701: [clangd] Hover should return null when not hovering over anything.

sammccall created this revision. sammccall added a reviewer: ioeric. Herald added subscribers: cfe-commits, jkorous, MaskRay, ilya-biryukov, klimek. Also made JSON serialize Optional to simplify this. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D47701 Files:

[PATCH] D47699: [clangd] Remove the dead offset fields in Symbol.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: jkorous, MaskRay, ioeric, ilya-biryukov, klimek. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D47699 Files: clangd/index/Index.h Index: clangd/index/Index.h

[PATCH] D47460: [Frontend] Honor UserFilesAreVolatile flag getting file buffer in ASTUnit

yvvan updated this revision to Diff 149697. yvvan added a comment. Use fixture in unit-test https://reviews.llvm.org/D47460 Files: include/clang/Basic/FileManager.h lib/Basic/FileManager.cpp lib/Frontend/ASTUnit.cpp unittests/Frontend/ASTUnitTest.cpp Index:

[PATCH] D47578: Do not enforce absolute path argv0 in windows

takuto.ikuta marked 3 inline comments as done. takuto.ikuta added a comment. Thank you for review Comment at: llvm/lib/Support/Windows/Process.inc:251 + // This may change argv0 like below, + // * clang -> clang.exe (just add extension) + // * CLANG_~1.EXE -> clang++.exe

[PATCH] D47623: [clangd] Avoid indexing decls associated with friend decls.

ilya-biryukov added a comment. In https://reviews.llvm.org/D47623#1119426, @ioeric wrote: > Sorry for the late response Ilya. I was trying to test these cases. So, with > the current change, if a real "canonical" declaration comes before the friend > decl, then the reference will still be

[PATCH] D47578: Do not enforce absolute path argv0 in windows

takuto.ikuta updated this revision to Diff 149694. takuto.ikuta added a comment. Address comments https://reviews.llvm.org/D47578 Files: llvm/lib/Support/Windows/Process.inc llvm/unittests/Support/CommandLineTest.cpp Index: llvm/unittests/Support/CommandLineTest.cpp

[PATCH] D41168: [X86] Lowering X86 avx512 sqrt intrinsics to IR

tkrupa updated this revision to Diff 149693. tkrupa added a comment. Removed CHECK-NOTs for consistency. Repository: rC Clang https://reviews.llvm.org/D41168 Files: lib/CodeGen/CGBuiltin.cpp test/CodeGen/avx-builtins.c test/CodeGen/avx512f-builtins.c test/CodeGen/avx512vl-builtins.c

[PATCH] D47460: [Frontend] Honor UserFilesAreVolatile flag getting file buffer in ASTUnit

orgads added inline comments. Comment at: unittests/Frontend/ASTUnitTest.cpp:21 +#define CREATE_AST_UNIT(isVolatile) \ + int FD; \ Macros are

[PATCH] D47628: Detect an incompatible VLA pointer assignment

jmorse marked 2 inline comments as done. jmorse added inline comments. Comment at: lib/AST/ASTContext.cpp:8588 + Expr *E = VAT->getSizeExpr(); + if (E && VAT->getSizeExpr()->isIntegerConstantExpr(TheInt, *this)) +return std::make_pair(true, TheInt);

[PATCH] D47628: Detect an incompatible VLA pointer assignment

jmorse updated this revision to Diff 149688. jmorse added a comment. Avoid un-necessary call, use APInt::isSameValue rather than operator!= https://reviews.llvm.org/D47628 Files: lib/AST/ASTContext.cpp test/Sema/vla.c Index: test/Sema/vla.c

[clang-tools-extra] r333875 - Reland "[clangd] Adapt file migration in r332720"

Author: ioeric Date: Mon Jun 4 02:04:19 2018 New Revision: 333875 URL: http://llvm.org/viewvc/llvm-project?rev=333875=rev Log: Reland "[clangd] Adapt file migration in r332720" This reverts commit r332752 (i.e. reland r332721). Modified: clang-tools-extra/trunk/clangd/CMakeLists.txt

[clang-tools-extra] r333876 - Revert "Reland "[clangd] Adapt file migration in r332720""

Author: ioeric Date: Mon Jun 4 02:04:25 2018 New Revision: 333876 URL: http://llvm.org/viewvc/llvm-project?rev=333876=rev Log: Revert "Reland "[clangd] Adapt file migration in r332720"" This reverts commit r333533. Modified: clang-tools-extra/trunk/clangd/CMakeLists.txt

r333874 - Reland "Move #include manipulation code to new lib/Tooling/Inclusions."

Author: ioeric Date: Mon Jun 4 02:04:12 2018 New Revision: 333874 URL: http://llvm.org/viewvc/llvm-project?rev=333874=rev Log: Reland "Move #include manipulation code to new lib/Tooling/Inclusions." This reverts commit r333534 (i.e. reland r332720) after fixing module build. Differential

[clang-tools-extra] r333877 - Reland "[clangd] Adapt file migration in r332720"

Author: ioeric Date: Mon Jun 4 02:04:28 2018 New Revision: 333877 URL: http://llvm.org/viewvc/llvm-project?rev=333877=rev Log: Reland "[clangd] Adapt file migration in r332720" This reverts commit r333535. Modified: clang-tools-extra/trunk/clangd/CMakeLists.txt

[PATCH] D47698: [ASTImporter] import macro source locations

r.stahl added a comment. The split-token case should be covered by this, because it takes the correct TokenLen and the isTokenRange flag. Other than that the split-token ExpansionInfo is indistinguishable. What about loaded source locations? Do they need to be handled specifically or does

[PATCH] D47698: [ASTImporter] import macro source locations

r.stahl created this revision. r.stahl added reviewers: a.sidorin, klimek, martong. Herald added subscribers: cfe-commits, rnkovacs. Implement full import of macro expansion info with spelling and expansion locations. Repository: rC Clang https://reviews.llvm.org/D47698 Files:

[PATCH] D47643: Rewrite JSON dispatcher loop using C IO (FILE*) instead of std::istream.

sammccall updated this revision to Diff 149685. sammccall added a comment. Handle one more case where fgets is interrupted. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D47643 Files: clangd/ClangdLSPServer.cpp clangd/ClangdLSPServer.h clangd/JSONRPCDispatcher.cpp

[PATCH] D47460: [Frontend] Honor UserFilesAreVolatile flag getting file buffer in ASTUnit

yvvan updated this revision to Diff 149684. yvvan added a comment. fix indentation in unit-test https://reviews.llvm.org/D47460 Files: include/clang/Basic/FileManager.h lib/Basic/FileManager.cpp lib/Frontend/ASTUnit.cpp unittests/Frontend/ASTUnitTest.cpp Index:

[PATCH] D43667: [clang-doc] Implement a YAML generator

ioeric added inline comments. Comment at: clang-doc/Generators.h:25 +// +// Derived classes must implement the generate*ForInfo methods, which should +// emit documentation for the specified info in the relevant format. This is nit: This seems a bit redundant as

[PATCH] D47643: Rewrite JSON dispatcher loop using C IO (FILE*) instead of std::istream.

sammccall added a comment. In https://reviews.llvm.org/D47643#1120385, @malaperle wrote: > In https://reviews.llvm.org/D47643#1119187, @sammccall wrote: > > > @malaperle: would you mind patching this in and checking whether attaching > > a debugger still works on Mac (this was the reason for

[PATCH] D47643: Rewrite JSON dispatcher loop using C IO (FILE*) instead of std::istream.

sammccall updated this revision to Diff 149682. sammccall added a comment. clearerr() on (partial) successful read, and recover from EAGAIN during fread. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D47643 Files: clangd/ClangdLSPServer.cpp clangd/ClangdLSPServer.h

[PATCH] D47108: [CodeGenCXX] Add -fforce-emit-vtables

rsmith accepted this revision. rsmith added a comment. I would like to see a test that virtual function definitions are properly emitted for classes instantiated from templates (and in particular, that this triggers instantiation of such virtual member functions so they can be emitted). Other

[PATCH] D47627: [ASTContext] Make getAddrSpaceQualType replace address spaces.

ebevhan added a comment. I have this patch uploaded as well: https://reviews.llvm.org/D47630 I suspected that there might be cases for which we would try adding the same address space to a type, but I noticed that this method doesn't replace properly. I don't actually have an example of this,

[PATCH] D35110: [Analyzer] Constraint Manager Negates Difference

baloghadamsoftware added a comment. In https://reviews.llvm.org/D35110#1119496, @NoQ wrote: > Which expressions are constrained? Why does the difference use the whole > range? Is it something that could have been fixed by the "enforce that > separately" part in my old comment: > > >

Re: [PATCH] D45517: [analyzer] False positive refutation with Z3

> > > Awesome! Does it mean that the optimization for adding less constraints > was in fact buggy? > > I pretty sure it was not related to the optimizations, I removed them days ago (in the previous version of this patch) and the bug was still there. > > 2. Could it be something unrelated to

r333862 - Moved RangedConstraintManager header to the StaticAnalyser include dir

Author: mramalho Date: Sun Jun 3 17:23:01 2018 New Revision: 333862 URL: http://llvm.org/viewvc/llvm-project?rev=333862=rev Log: Moved RangedConstraintManager header to the StaticAnalyser include dir Summary: Moved `RangedConstraintManager` header from `lib/StaticAnalyzer/Core/` to

[PATCH] D47658: [analyzer] Re-enable lifetime extension for temporaries with destructors and bring back static temporaries.

MTC added inline comments. Comment at: lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:234 + SVal V = UnknownVal(); + if (MTE) { +if (MTE->getStorageDuration() != SD_FullExpression) { An unrelated question. I want to know, what considerations are you

[PATCH] D47616: [CFG] [analyzer] Explain copy elision through construction contexts.

MTC added inline comments. Comment at: include/clang/Analysis/ConstructionContext.h:351 + + explicit SimpleTemporaryObjectConstructionContext( + const CXXBindTemporaryExpr *BTE, const MaterializeTemporaryExpr *MTE) `explicit` useless?

<    1   2