aaron.ballman added inline comments.
Comment at: clang-tidy/ClangTidy.h:230-232
+/// \param StoreCheckProfile If provided, and EnableCheckProfile is true,
+/// the profile will not be outputted to the stderr, but instead will be stored
+/// as JSON file in the specified directory
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
Aside from a minor commenting nit, this LGTM.
Comment at: clang-tidy/utils/ExprMutationAnalyzer.cpp:78-81
+ // TODO: also handle these cases:
+ // - `Exp` is
sammccall created this revision.
sammccall added a reviewer: ioeric.
Herald added subscribers: cfe-commits, jkorous, MaskRay, ilya-biryukov, klimek.
This signal is considered a relevance rather than a quality signal because it's
dependent on the query (the fact that it's completion, and implicitly
ethanhs added a comment.
In https://reviews.llvm.org/D47672#1121181, @rnk wrote:
>
> They are a hint to the processor that this is a short critical section, and
> it is likely that the entire critical section can be entered, run, and
> committed to memory before another thread needs to use
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: clang-doc/Generators.h:25
+//
+// Derived classes must implement the generate*ForInfo methods, which should
+// emit documentation for the specified info in
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: clangd/JSONRPCDispatcher.cpp:70
}
- log(llvm::Twine("--> ") + S);
+ log(llvm::Twine("--> ") + S + "\n");
}
sammccall wro
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM aside from a nit with one of the tests. Once you've updated the patch and
verified that check-clang passes all tests, I can commit for you next week when
I'm back from meeti
ioeric added a comment.
Looks like a great improvement on ranking!
Comment at: clangd/Quality.cpp:62
+ bool InClass;
+ for (const DeclContext *DC = D.getDeclContext(); DC != nullptr;
+ DC = DC->getParent()) {
nit: maybe stop when`!DC->isFileContext()`?
Author: jmorse
Date: Tue Jun 5 02:18:26 2018
New Revision: 333989
URL: http://llvm.org/viewvc/llvm-project?rev=333989&view=rev
Log:
Detect an incompatible VLA pointer assignment
For pointer assignments of VLA types, Clang currently detects when array
dimensions _lower_ than a variable dimension
This revision was automatically updated to reflect the committed changes.
jmorse marked 2 inline comments as done.
Closed by commit rL333989: Detect an incompatible VLA pointer assignment
(authored by jmorse, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
http
On Tue, 5 Jun 2018, Reid Kleckner via cfe-commits wrote:
Author: rnk
Date: Mon Jun 4 18:33:40 2018
New Revision: 333978
URL: http://llvm.org/viewvc/llvm-project?rev=333978&view=rev
Log:
Reimplement the bittest intrinsic family as builtins with inline asm
We need to implement _interlockedbitte
Author: sammccall
Date: Tue Jun 5 02:34:46 2018
New Revision: 333993
URL: http://llvm.org/viewvc/llvm-project?rev=333993&view=rev
Log:
[clangd] Rewrite JSON dispatcher loop using C IO (FILE*) instead of
std::istream.
Summary:
The EINTR loop around getline was added to fix an issue with mac gdb,
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE333993: [clangd] Rewrite JSON dispatcher loop using C IO
(FILE*) instead of std… (authored by sammccall, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D47643?vs=149685&id=149923#to
Author: sammccall
Date: Tue Jun 5 02:42:06 2018
New Revision: 333994
URL: http://llvm.org/viewvc/llvm-project?rev=333994&view=rev
Log:
[clang-tidy] fix broken test (no compile command) from r331763
Modified:
clang-tools-extra/trunk/test/clang-tidy/clang-tidy-enable-check-profile-one-tu.cpp
This is strange.
First, i'm pretty sure the test worked for me before.
Second, this commit actually *breaks* those two tests for me:
$ ninja check-clang-tools
[0/1] Running the Clang extra tools' regression tests
FAIL: Clang Tools ::
clang-tidy/clang-tidy-enable-check-profile-one-tu.cpp (123 of 8
ilya-biryukov added inline comments.
Comment at: unittests/clangd/QualityTests.cpp:129
+ Test.Code = R"cpp(
+#include "foo.h"
+int ::test_func_in_header_and_cpp() {
sammccall wrote:
> ilya-biryukov wrote:
> > sammccall wrote:
> > > this is not needed, th
Hi Roman,
Definitely something different in our configs, but it wasn't just me - a
couple of colleagues have mentioned those tests as being broken for a while!
The problem is the lack of compilation database, so I can imagine it can
depend on filesystem layout, e.g. whether you have a separate bu
tkrupa added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:2388
+ case X86::BI__builtin_ia32_vfmaddsubps512_maskz:
+ case X86::BI__builtin_ia32_vfmaddsubps512_mask3:
ArgNum = 4;
vfmsubps512_mask3, vfmsubpd512_mask3, vfmsubaddps512_mask3 and
vfmsu
Ah, hm, yes, that was a further local problem in https://reviews.llvm.org/D46602
And i didn't double-check on master initially, because that causes all
the checks to be rebuilt :/
So thanks for the fix!
Roman.
On Tue, Jun 5, 2018 at 1:40 PM, Sam McCall wrote:
> Hi Roman,
>
> Definitely somethi
lebedev.ri added inline comments.
Comment at: clang-tidy/ClangTidyProfiling.cpp:47
+void ClangTidyProfiling::printAsJSON(llvm::raw_ostream &OS) {
+ OS << "{\n";
aaron.ballman wrote:
> I'm not keen that we call this `printAsJSON()` when the docs talk about
> w
lebedev.ri updated this revision to Diff 149933.
lebedev.ri marked 5 inline comments as done.
lebedev.ri added a comment.
Rebase ontop of https://reviews.llvm.org/rL333994, address review notes,
canonicalize to `JSON`.
Repository:
rL LLVM
https://reviews.llvm.org/D46602
Files:
clang-tidy/
Ah, I've been there. No worries!
On Tue, Jun 5, 2018 at 1:08 PM Roman Lebedev wrote:
> Ah, hm, yes, that was a further local problem in
> https://reviews.llvm.org/D46602
> And i didn't double-check on master initially, because that causes all
> the checks to be rebuilt :/
>
> So thanks for the f
aaron.ballman accepted this revision.
aaron.ballman added a comment.
LGTM!
Comment at: clang-tidy/ClangTidyProfiling.cpp:47
+void ClangTidyProfiling::printAsJSON(llvm::raw_ostream &OS) {
+ OS << "{\n";
lebedev.ri wrote:
> aaron.ballman wrote:
> > I'm not kee
lebedev.ri added a comment.
In https://reviews.llvm.org/D46602#1122194, @aaron.ballman wrote:
> LGTM!
Thank you for the review.
Waiting on @alexfh ...
Repository:
rL LLVM
https://reviews.llvm.org/D46602
___
cfe-commits mailing list
cfe-commit
sammccall updated this revision to Diff 149951.
sammccall marked 3 inline comments as done.
sammccall added a comment.
Address review comments and sync.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47762
Files:
clangd/ClangdUnit.cpp
clangd/ClangdUnit.h
clangd/CodeComple
sammccall added inline comments.
Comment at: clangd/Quality.cpp:70
+return SymbolRelevanceSignals::ClassScope;
+ if (D.getLinkageInternal() < ExternalLinkage)
+return SymbolRelevanceSignals::FileScope;
ioeric wrote:
> I wonder if this comparison is a com
mike.dvoretsky abandoned this revision.
mike.dvoretsky added a comment.
Closing this due to failure of https://reviews.llvm.org/D45721.
https://reviews.llvm.org/D45720
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
Author: aaronballman
Date: Tue Jun 5 05:14:47 2018
New Revision: 334013
URL: http://llvm.org/viewvc/llvm-project?rev=334013&view=rev
Log:
Silence a "truncation from double to float" diagnostic in MSVC; NFC.
Modified:
clang-tools-extra/trunk/unittests/clangd/QualityTests.cpp
Modified: clang-
mike.dvoretsky abandoned this revision.
mike.dvoretsky added a comment.
Closing this due to failure of https://reviews.llvm.org/D45723.
https://reviews.llvm.org/D45722
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
Author: sammccall
Date: Tue Jun 5 05:22:43 2018
New Revision: 334014
URL: http://llvm.org/viewvc/llvm-project?rev=334014&view=rev
Log:
[clangd] Test tweaks (consistency, shorter, doc). NFC
Modified:
clang-tools-extra/trunk/clangd/Quality.h
clang-tools-extra/trunk/unittests/clangd/Quality
r.stahl updated this revision to Diff 149959.
r.stahl added a comment.
- add missing AnalysisConsumer diff
- only collect const qualified vardecls in the extdef index and adjust test
https://reviews.llvm.org/D46421
Files:
include/clang/Basic/DiagnosticCrossTUKinds.td
include/clang/CrossTU/C
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: clangd/Quality.cpp:70
+return SymbolRelevanceSignals::ClassScope;
+ if (D.getLinkageInternal() < ExternalLinkage)
+return SymbolRelevanceSignals::Fi
Author: malaperle
Date: Tue Jun 5 07:01:40 2018
New Revision: 334017
URL: http://llvm.org/viewvc/llvm-project?rev=334017&view=rev
Log:
[clangd] Add "member" symbols to the index
Summary:
This adds more symbols to the index:
- member variables and functions
- enum constants in scoped enums
The c
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE334017: [clangd] Add "member" symbols to the
index (authored by malaperle, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D44954?vs=149532&id=149970#toc
Repository:
rCTE Clang To
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334017: [clangd] Add "member" symbols to the index
(authored by malaperle, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D44954
Files:
clang-t
Author: malaperle
Date: Tue Jun 5 07:07:45 2018
New Revision: 334018
URL: http://llvm.org/viewvc/llvm-project?rev=334018&view=rev
Log:
[clangd] Remove unused variables
Summary: Signed-off-by: Marc-Andre Laperle
Subscribers: klimek, ilya-biryukov, ioeric, MaskRay, jkorous, cfe-commits
Differen
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE334018: [clangd] Remove unused variables (authored by
malaperle, committed by ).
Changed prior to commit:
https://rev
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334018: [clangd] Remove unused variables (authored by
malaperle, committed by ).
Herald added a subscriber: llvm-commits.
dmgreen added a comment.
Thanks.
I noticed in the paper that you used the name "unrollandjam", minus
underscores. Should I change this use that spelling here? I have no strong
opinion of one over the other (was just using what I had found from the Intel
docs).
https://reviews.llvm.org/D47267
ioeric added a comment.
fyi, you could actually accept your own patch phab (e.g. when you would like
post-commit review) :P
Repository:
rL LLVM
https://reviews.llvm.org/D47737
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.
arm-chrjan01 created this revision.
arm-chrjan01 added reviewers: simon_tatham, majnemer, rnk.
Herald added subscribers: cfe-commits, chrib.
Repository:
rC Clang
https://reviews.llvm.org/D47784
Files:
lib/CodeGen/CGBuiltin.cpp
test/CodeGen/ms-setjmp.c
Index: test/CodeGen/ms-setjmp.c
Author: yaxunl
Date: Tue Jun 5 08:11:02 2018
New Revision: 334021
URL: http://llvm.org/viewvc/llvm-project?rev=334021&view=rev
Log:
[CUDA][HIP] Do not emit type info when compiling for device
CUDA/HIP does not support RTTI on device side, therefore there
is no point of emitting type info when co
This revision was automatically updated to reflect the committed changes.
Closed by commit rC334021: [CUDA][HIP] Do not emit type info when compiling for
device (authored by yaxunl, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D47694
Files:
lib/CodeGen/CodeGenModule.cpp
t
craig.topper added inline comments.
Comment at: test/CodeGen/target-features-error-2.c:39
__m128d need_avx(__m128d a, __m128d b) {
return _mm_cmp_sd(a, b, 0); // expected-error {{'__builtin_ia32_cmpsd' needs
target feature avx}}
}
The 4 compare functions he
GBuella added inline comments.
Comment at: test/CodeGen/target-features-error-2.c:39
__m128d need_avx(__m128d a, __m128d b) {
return _mm_cmp_sd(a, b, 0); // expected-error {{'__builtin_ia32_cmpsd' needs
target feature avx}}
}
craig.topper wrote:
> The 4 com
ruiu added a comment.
LGTM
Repository:
rL LLVM
https://reviews.llvm.org/D47669
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
gramanas updated this revision to Diff 149996.
gramanas added a comment.
Add comment explaining the test
Repository:
rC Clang
https://reviews.llvm.org/D47720
Files:
test/CodeGen/debug-info-inline-for.c
Index: test/CodeGen/debug-info-inline-for.c
==
craig.topper added inline comments.
Comment at: test/CodeGen/target-features-error-2.c:39
__m128d need_avx(__m128d a, __m128d b) {
return _mm_cmp_sd(a, b, 0); // expected-error {{'__builtin_ia32_cmpsd' needs
target feature avx}}
}
GBuella wrote:
> craig.top
Anastasia added inline comments.
Comment at: test/Sema/address_spaces.c:17
int *_AS1 _AS2 *Z; // expected-error {{multiple address spaces specified
for type}}
+ int *_AS1 _AS1 *M;
ebevhan wrote:
> bader wrote:
> > I think it might be valuable to give a wa
martong added a comment.
> Are you OK with incremental review?
Hi Aleksei, thanks for reviewing this! Of course I am OK with an incremental
review. Just a minor thing, I'll be back in the office only at the 18th, so I
can address all of the comments only then.
Repository:
rC Clang
https://
juliehockett updated this revision to Diff 149997.
juliehockett marked 3 inline comments as done.
juliehockett added a comment.
Fixing comments
https://reviews.llvm.org/D43667
Files:
clang-doc/CMakeLists.txt
clang-doc/Generators.cpp
clang-doc/Generators.h
clang-doc/Representation.h
cl
sammccall marked an inline comment as done.
sammccall added inline comments.
Comment at: unittests/clangd/QualityTests.cpp:1
//===-- SourceCodeTests.cpp *- C++
-*-===//
//
ioeric wrote:
> sammccall wrote:
> > ioeric wrote:
Author: sammccall
Date: Tue Jun 5 09:30:25 2018
New Revision: 334026
URL: http://llvm.org/viewvc/llvm-project?rev=334026&view=rev
Log:
[clangd] Boost code completion results that are narrowly scoped (local, members)
Summary:
This signal is considered a relevance rather than a quality signal beca
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334026: [clangd] Boost code completion results that are
narrowly scoped (local, members) (authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https:/
ioeric added inline comments.
Comment at: unittests/clangd/QualityTests.cpp:1
//===-- SourceCodeTests.cpp *- C++
-*-===//
//
sammccall wrote:
> ioeric wrote:
> > sammccall wrote:
> > > ioeric wrote:
> > > > Could you also a
sammccall created this revision.
sammccall added a reviewer: ioeric.
Herald added subscribers: cfe-commits, jkorous, MaskRay, ilya-biryukov.
Numbers are guesses to be adjusted later.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47787
Files:
clangd/Quality.cpp
clangd/Quali
trixirt updated this revision to Diff 150003.
trixirt added a comment.
cleanup of last patch
Repository:
rC Clang
https://reviews.llvm.org/D47554
Files:
include/clang/AST/ExprCXX.h
include/clang/ASTMatchers/ASTMatchers.h
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/AST/ExprC
probinson added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:6729
def err_no_dynamic_cast_with_fno_rtti : Error<
- "cannot use dynamic_cast with -fno-rtti">;
+ "use of dynamic_cast requires enabling RTTI">;
wristow wrote:
> Sunil_S
aprantl added inline comments.
Comment at: test/CodeGen/debug-info-inline-for.c:13
+
+// CHECK: ![[DbgLoc]] = !DILocation(
Shouldn't you also check *which* location is attached to it?
Repository:
rC Clang
https://reviews.llvm.org/D47720
__
alekseyshl abandoned this revision.
alekseyshl added a comment.
Experimental.
Repository:
rC Clang
https://reviews.llvm.org/D47600
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yunlian marked an inline comment as done.
yunlian added a comment.
Herald added a subscriber: steven_wu.
ping?
https://reviews.llvm.org/D44788
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
Meinersbur added a comment.
In https://reviews.llvm.org/D47267#1122425, @dmgreen wrote:
> I noticed in the paper that you used the name "unrollandjam", minus
> underscores. Should I change this use that spelling here? I have no strong
> opinion of one over the other (was just using what I had f
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: clangd/Quality.cpp:33
+static SymbolQualitySignals::SymbolCategory categorize(const NamedDecl &ND) {
+ class Switch
Have you considered `
On Tue, Jun 5, 2018 at 2:33 AM Martin Storsjö wrote:
> > // Many of MSVC builtins are on both x64 and ARM; to avoid repeating
> code, we
> > // handle them here.
>
> This doesn't seem thought through wrt non-x86 architectures. I'm not sure
> if there's any similar suitable instruction to use on A
Author: sammccall
Date: Tue Jun 5 10:58:12 2018
New Revision: 334032
URL: http://llvm.org/viewvc/llvm-project?rev=334032&view=rev
Log:
[clangd] Quality fixes (uninit var, missing debug output, pattern decl CCRs).
Modified:
clang-tools-extra/trunk/clangd/Quality.cpp
Modified: clang-tools-ext
Author: sammccall
Date: Tue Jun 5 11:00:48 2018
New Revision: 334033
URL: http://llvm.org/viewvc/llvm-project?rev=334033&view=rev
Log:
[clangd] Fix inverted test again, sigh
Modified:
clang-tools-extra/trunk/clangd/Quality.cpp
Modified: clang-tools-extra/trunk/clangd/Quality.cpp
URL:
http:
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
I'm happy to refactor this after landing it as is, or you can do it if you like.
Comment at: lib/CodeGen/CGBuiltin.cpp:2808
case Builtin::BI_setjmpex: {
if (getTarget
wristow added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:6729
def err_no_dynamic_cast_with_fno_rtti : Error<
- "cannot use dynamic_cast with -fno-rtti">;
+ "use of dynamic_cast requires enabling RTTI">;
probinson wrote:
> wristow
pcc added inline comments.
Comment at: lib/Driver/ToolChains/CommonArgs.cpp:435
+ CmdArgs.push_back(
+ Args.MakeArgString(Twine("-plugin-opt=objcopy=") + Objcopy));
+ CmdArgs.push_back(
You no longer need to pass `objcopy=`, see D47091.
https
GBuella updated this revision to Diff 150018.
https://reviews.llvm.org/D46541
Files:
lib/CodeGen/CodeGenFunction.cpp
lib/CodeGen/CodeGenModule.cpp
lib/CodeGen/CodeGenModule.h
test/CodeGen/target-features-error-2.c
test/CodeGen/target-features-error.c
Index: test/CodeGen/target-features
GBuella marked an inline comment as done.
GBuella added inline comments.
Comment at: test/CodeGen/target-features-error-2.c:39
__m128d need_avx(__m128d a, __m128d b) {
return _mm_cmp_sd(a, b, 0); // expected-error {{'__builtin_ia32_cmpsd' needs
target feature avx}}
}
--
juliehockett added inline comments.
Comment at: clang-doc/YAMLGenerator.cpp:265
+// and thus register the generator.
+volatile int YAMLGeneratorAnchorSource = 0;
+
ioeric wrote:
> nit: add `static`?
`static` declares it as file-local, and so the `extern` referenc
shuaiwang updated this revision to Diff 150026.
shuaiwang marked an inline comment as done.
shuaiwang added a comment.
Remove stale comment
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45679
Files:
clang-tidy/utils/CMakeLists.txt
clang-tidy/utils/ExprMutationAnalyzer.cpp
shuaiwang added a comment.
Thanks a lot for the review!
Could you also help commit this diff as well? Thanks!
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45679
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists
mcgrathr accepted this revision.
mcgrathr added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rC Clang
https://reviews.llvm.org/D47758
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
craig.topper updated this revision to Diff 150027.
craig.topper added a comment.
Add subtract builtins to SemaChecking.cpp
Repository:
rC Clang
https://reviews.llvm.org/D47724
Files:
include/clang/Basic/BuiltinsX86.def
lib/CodeGen/CGBuiltin.cpp
lib/Headers/avx512fintrin.h
lib/Sema/Se
yunlian updated this revision to Diff 150028.
https://reviews.llvm.org/D44788
Files:
include/clang/Driver/Options.td
lib/Driver/ToolChains/CommonArgs.cpp
test/Driver/lto-dwo.c
Index: test/Driver/lto-dwo.c
===
--- /dev/null
++
gramanas updated this revision to Diff 150036.
gramanas marked an inline comment as done.
gramanas added a comment.
Add artificial debug location to the phi instruction
Repository:
rC Clang
https://reviews.llvm.org/D47720
Files:
lib/CodeGen/CGExprScalar.cpp
test/CodeGen/debug-info-inline
gramanas added inline comments.
Comment at: test/CodeGen/debug-info-inline-for.c:13
+
+// CHECK: ![[DbgLoc]] = !DILocation(
aprantl wrote:
> Shouldn't you also check *which* location is attached to it?
I wasn't sure if this should be an artificial location or not
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D46541
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.
As is the case with https://reviews.llvm.org/D47097, this helps preserve more
scope information after SROA. LGTM. Thanks!
Repository:
rC Clang
https://reviews.llvm.org/D47720
Sunil_Srivastava added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:6729
def err_no_dynamic_cast_with_fno_rtti : Error<
- "cannot use dynamic_cast with -fno-rtti">;
+ "use of dynamic_cast requires enabling RTTI">;
wristow wrote:
>
Sunil_Srivastava updated this revision to Diff 150038.
Sunil_Srivastava added a comment.
Changed as per Paul's suggestion.
https://reviews.llvm.org/D47291
Files:
include/clang/Basic/DiagnosticSemaKinds.td
test/SemaCXX/no-rtti.cpp
Index: test/SemaCXX/no-rtti.cpp
===
tra added a comment.
Looks OK overall, but I'm not very familiar with CGCall, so you may want to dig
through the history and find someone with more expertise.
Comment at: test/CodeGenCUDA/kernel-args-amdgcn.cu:1
+// RUN: %clang_cc1 -triple amdgcn-amd-amdhsa -fcuda-is-device -e
george.karpenkov added a comment.
> So having an analyzer-config option would be useful for those codebases that
> are expected to be compiled with less advanced compilers that do not elide
> copies or not doing it aggressively enough.
I'm not sure it makes sense. From my understanding, that's
Author: ctopper
Date: Tue Jun 5 14:54:35 2018
New Revision: 334051
URL: http://llvm.org/viewvc/llvm-project?rev=334051&view=rev
Log:
[X86] Make __builtin_ia32_vec_ext_v2si require ICE for its index argument. Add
warnings for out of range indices for __builtin_ia32_vec_ext_v2si,
__builtin_ia32_v
xazax.hun added a comment.
In https://reviews.llvm.org/D47671#1122994, @george.karpenkov wrote:
> > So having an analyzer-config option would be useful for those codebases
> > that are expected to be compiled with less advanced compilers that do not
> > elide copies or not doing it aggressively
dmgreen added a comment.
I quite like the UnrollAndFuse naming. I'd not heard that the xlc compiler
called it that. The UnrollAndJam pass was origin named that before I renamed
for similar reasons (UnrollAndJam being more well known).
I see your point about the mix of underscores. "nounroll_and
joerg updated this revision to Diff 150049.
joerg added a comment.
After a careful review of newer GCC / libgcc and the assembler annotations from
LLVM, I have come to the following conclusions:
(1) The semantics have been somewhat changed by GCC in recent years. There is
no actual specificatio
fidget324 created this revision.
fidget324 added reviewers: hiraditya, EricWF.
Herald added a subscriber: cfe-commits.
Fix an issue that was preventing std::vector from invoking the move
constructor on its allocator when appropriate.
Added a constructor to __vector_base which accepts an rvalue re
Meinersbur added a comment.
In https://reviews.llvm.org/D47267#1123013, @dmgreen wrote:
> I see your point about the mix of underscores. "nounroll_and_jam" also comes
> from the Intel docs, and theres already "nounroll" vs "unroll". The "no"
> becomes a qualifier on "unroll_and_jam". "no_unroll
Author: ericwf
Date: Tue Jun 5 15:32:52 2018
New Revision: 334053
URL: http://llvm.org/viewvc/llvm-project?rev=334053&view=rev
Log:
Fix PR37694 - std::vector doesn't correctly move construct allocators.
C++2a[container.requirements.general]p8 states that when move constructing
a container, the a
Author: ctopper
Date: Tue Jun 5 15:40:03 2018
New Revision: 334054
URL: http://llvm.org/viewvc/llvm-project?rev=334054&view=rev
Log:
[X86] Implement __builtin_ia32_vec_ext_v2si correctly even though we only use
it with an index of 0.
This builtin takes an index as its second operand, but the co
tra added a comment.
With the updated patch description + the discussion I'm OK with the approach
from the general "how do we compile/use CUDA" point of view. I'll leave the
question of whether the approach works for OpenMP to someone more familiar with
it.
While I'm not completely convinced t
tra added a comment.
I've experimented a bit and I think that we may not need this patch at all.
As far as I can tell, nv_weak is only applicable to __device__ functions. It's
ignored for __global__ kernels and is apparently forbidden for data.
For __device__ functions nvcc produces .weak attribu
leonardchan added a comment.
@ebevhan Does everything look good in this patch? I'm almost done with the next
one. Writing tests for it still.
Repository:
rC Clang
https://reviews.llvm.org/D46911
___
cfe-commits mailing list
cfe-commits@lists.llv
tra created this revision.
tra added reviewers: Hahnfeld, aaron.ballman, jlebar.
Herald added subscribers: bixia, sanjoy.
An alternative to implementing nv_weak attribute
(https://reviews.llvm.org/D47201).
The patch should make runtime sub functions to have .weak attribute in PTX and
that shoul
jlebar accepted this revision.
jlebar added a comment.
This revision is now accepted and ready to land.
What could possibly go wrong.
https://reviews.llvm.org/D47804
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
tra added a comment.
I'll wait to see if that fixes @Hahnfeld's problem.
AFAICT, nv_weak is not used for anything interesting other than the device-side
runtime stubs that return errors (apparently, until they are linked with the
proper device runtime which would have strong version of the symb
Author: ericwf
Date: Tue Jun 5 17:13:49 2018
New Revision: 334056
URL: http://llvm.org/viewvc/llvm-project?rev=334056&view=rev
Log:
Fix test failures after r334053.
Modified:
libcxx/trunk/test/std/containers/associative/map/map.cons/move.pass.cpp
libcxx/trunk/test/std/containers/associa
1 - 100 of 131 matches
Mail list logo
