Higuoxing added a comment.
In https://reviews.llvm.org/D47687#1125926, @rnk wrote:
> @dexonsmith is there someone from Apple who can comment on rdar://8678458 and
> the merits of disabling this warning in macros? I strongly suspect the
> original report was dealing with code like `assert(x ||
Author: ctopper
Date: Thu Jun 7 21:09:14 2018
New Revision: 334264
URL: http://llvm.org/viewvc/llvm-project?rev=334264=rev
Log:
[X86] Fix some typecasts in intrinsic headers that I messed up in r334261.
This was caught by the Header tests, but not the CodeGen tests.
Modified:
Author: ctopper
Date: Thu Jun 7 20:24:47 2018
New Revision: 334261
URL: http://llvm.org/viewvc/llvm-project?rev=334261=rev
Log:
[X86] Add subvector insert and extract builtins to enable target feature
checking and immediate range checking.
Test changes are due to differences in how we generate
dexonsmith added a comment.
In https://reviews.llvm.org/D47687#1125926, @rnk wrote:
> @dexonsmith is there someone from Apple who can comment on rdar://8678458 and
> the merits of disabling this warning in macros? I strongly suspect the
> original report was dealing with code like `assert(x ||
srhines added a comment.
In https://reviews.llvm.org/D47894#1125728, @jyknight wrote:
> In https://reviews.llvm.org/D47894#1125653, @efriedma wrote:
>
> > The problem would come from propagating nonnull-ness from something which
> > isn't inherently nonnull. For example, strlen has a nonnull
Author: ctopper
Date: Thu Jun 7 17:59:27 2018
New Revision: 334256
URL: http://llvm.org/viewvc/llvm-project?rev=334256=rev
Log:
[X86] Add builtins for vpermilps/pd instructions to enable target feature
checking.
Modified:
cfe/trunk/include/clang/Basic/BuiltinsX86.def
This revision was automatically updated to reflect the committed changes.
Closed by commit rC334253: [CodeGen] Always use MSVC personality for
windows-msvc targets (authored by smeenai, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D47862?vs=150243=150437#toc
Repository:
Author: smeenai
Date: Thu Jun 7 17:41:01 2018
New Revision: 334253
URL: http://llvm.org/viewvc/llvm-project?rev=334253=rev
Log:
[CodeGen] Always use MSVC personality for windows-msvc targets
The windows-msvc target is meant to be ABI compatible with MSVC,
including the exception handling.
This revision was automatically updated to reflect the committed changes.
Closed by commit rC334252: [clang-fuzzer] Made loop_proto more
vectorizable. (authored by morehouse, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D47920?vs=150435=150436#toc
Repository:
rC Clang
Author: morehouse
Date: Thu Jun 7 17:33:35 2018
New Revision: 334252
URL: http://llvm.org/viewvc/llvm-project?rev=334252=rev
Log:
[clang-fuzzer] Made loop_proto more "vectorizable".
Edited loop_proto and its converter to make more "vectorizable" code
according to kcc's comment in D47666
-
Author: smeenai
Date: Thu Jun 7 17:30:00 2018
New Revision: 334251
URL: http://llvm.org/viewvc/llvm-project?rev=334251=rev
Log:
Reapply "[Parse] Use CapturedStmt for @finally on MSVC"
This reapplies r334224 and adds explicit triples to some tests to fix
them on Windows (where otherwise they
morehouse accepted this revision.
morehouse added a comment.
This revision is now accepted and ready to land.
Looks like a good start.
Repository:
rC Clang
https://reviews.llvm.org/D47920
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
rnk accepted this revision.
rnk added inline comments.
This revision is now accepted and ready to land.
Comment at: lib/CodeGen/CGException.cpp:134-135
const llvm::Triple = Target.getTriple();
+ if (T.isWindowsMSVCEnvironment())
+return
rnk added subscribers: dexonsmith, chandlerc.
rnk added a comment.
@dexonsmith is there someone from Apple who can comment on rdar://8678458 and
the merits of disabling this warning in macros? I strongly suspect the original
report was dealing with code like `assert(x || y && "str");`, if so we
emmettneyman created this revision.
emmettneyman added reviewers: kcc, vitalybuka, morehouse.
Herald added a subscriber: cfe-commits.
Edited loop_proto and its converter to make more "vectorizable" code
- Removed all while loops
- Can only index into array with induction variable
Repository:
smeenai added inline comments.
Comment at: lib/CodeGen/CGException.cpp:134-135
const llvm::Triple = Target.getTriple();
+ if (T.isWindowsMSVCEnvironment())
+return EHPersonality::MSVC_CxxFrameHandler3;
+
rnk wrote:
> I guess previously we carefully
Author: ctopper
Date: Thu Jun 7 17:00:21 2018
New Revision: 334249
URL: http://llvm.org/viewvc/llvm-project?rev=334249=rev
Log:
[X86] Add builtins for blend with immediate control to enforce target feature
requirements and check immediate range.
Modified:
Author: ctopper
Date: Thu Jun 7 16:03:08 2018
New Revision: 334244
URL: http://llvm.org/viewvc/llvm-project?rev=334244=rev
Log:
[X86] Add builtins for shuff32x4/shuff64x2/shufi32x4/shuff64x2 to enable target
feature checking and immediate range checking.
Modified:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334243: [Frontend] Disallow non-MSVC exception models for
windows-msvc targets (authored by smeenai, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
Author: smeenai
Date: Thu Jun 7 15:54:54 2018
New Revision: 334243
URL: http://llvm.org/viewvc/llvm-project?rev=334243=rev
Log:
[Frontend] Disallow non-MSVC exception models for windows-msvc targets
The windows-msvc target is used for MSVC ABI compatibility, including
the exceptions model. It
rnk added inline comments.
Comment at: lib/CodeGen/CGException.cpp:134-135
const llvm::Triple = Target.getTriple();
+ if (T.isWindowsMSVCEnvironment())
+return EHPersonality::MSVC_CxxFrameHandler3;
+
I guess previously we carefully arranged to go to
rnk accepted this revision.
rnk added a comment.
lgtm
Repository:
rC Clang
https://reviews.llvm.org/D47853
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
GBuella added a comment.
In https://reviews.llvm.org/D47912#1125803, @smeenai wrote:
> I believe LLVM_APPEND_VC_REV controls whether the revision is appended to
> LLVM version string (e.g. the output of `llvm-config --version`), whereas the
> SVNRevision.inc file (which is what's causing the
yunlian updated this revision to Diff 150419.
yunlian added a comment.
Makes the default value to /path/to/binary_dwo, when DWO_DIR is provided, make
the path to DWO_DIR/path/to/binary_dwo
https://reviews.llvm.org/D44788
Files:
include/clang/Driver/Options.td
smeenai added a comment.
I believe LLVM_APPEND_VC_REV controls whether the revision is appended to LLVM
version string (e.g. the output of `llvm-config --version`), whereas the
SVNRevision.inc file (which is what's causing the relink after amending) is
used for e.g. the `clang --version`
Author: smeenai
Date: Thu Jun 7 15:24:20 2018
New Revision: 334240
URL: http://llvm.org/viewvc/llvm-project?rev=334240=rev
Log:
Revert "[Parse] Use CapturedStmt for @finally on MSVC"
This reverts commit r334224.
This is causing buildbot failures on Windows, presumably because some
tests don't
GBuella created this revision.
GBuella added reviewers: beanz, bogner, hintonda.
Herald added subscribers: cfe-commits, mgorny.
This is merely a quickfix, due to being fustrated with waiting
for ~70 objects to be linked each time following `git commit --amend`.
When toggling LLVM_APPEND_VC_REV
efriedma added a comment.
For potential transforms based on nonnull, see https://reviews.llvm.org/D36656,
I think?
Repository:
rC Clang
https://reviews.llvm.org/D47894
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
xbolva00 added a comment.
In https://reviews.llvm.org/D47894#1125653, @efriedma wrote:
> The problem would come from propagating nonnull-ness from something which
> isn't inherently nonnull. For example, strlen has a nonnull argument, so
> `strlen(NULL)` is UB, therefore given `int z =
kcc added a comment.
Some feedback on the generated code:
while (1){
let's not have the while loops inside the for loops for now.
If the initial goal is to stress the loop optimizations (e.g. vectorizer),
loops likes this are just a distraction
for (int loop_ctr = 0
too verbose. Use
jyknight added a comment.
In https://reviews.llvm.org/D47894#1125653, @efriedma wrote:
> The problem would come from propagating nonnull-ness from something which
> isn't inherently nonnull. For example, strlen has a nonnull argument, so
> `strlen(NULL)` is UB, therefore given `int z =
stephanemoore added a comment.
In https://reviews.llvm.org/D46922#1125689, @benhamilton wrote:
> > Is it possible to get someone to land this for me? I don't believe I have
> > access to land it myself.
>
> Done.
Thank you, kind sir
Repository:
rL LLVM
https://reviews.llvm.org/D46922
This should be fixed now with r334239. In for a penny, in for a pound.
On Wed, Jun 6, 2018 at 6:09 PM Grang, Mandeep Singh
wrote:
> @rnk I tried building spec2000/eon for Windows ARM64 and ran into these
> errors:
>
> use of undeclared identifier '_interlockedbittestandset_acq'
> use of
efriedma added a comment.
For the kernel, specifically, strlen() isn't an issue because it builds with
-fno-builtin, but the kernel uses explicit nonnull attributes in a few places.
But I guess we can assume they know what they're doing if nonnull is explicitly
specified.
We probably want
Author: rnk
Date: Thu Jun 7 14:39:04 2018
New Revision: 334239
URL: http://llvm.org/viewvc/llvm-project?rev=334239=rev
Log:
[MS] Re-add support for the ARM interlocked bittest intrinscs
Adds support for these intrinsics, which are ARM and ARM64 only:
_interlockedbittestandreset_acq
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334238: [checks/property-decls] Fix comment in
clang-tidy/objc/PropertyDeclarationCheck. (authored by benhamilton, committed
by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
benhamilton added a comment.
> Is it possible to get someone to land this for me? I don't believe I have
> access to land it myself.
Done.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D46922
___
cfe-commits mailing list
Author: ctopper
Date: Thu Jun 7 14:27:41 2018
New Revision: 334237
URL: http://llvm.org/viewvc/llvm-project?rev=334237=rev
Log:
[X86] Add builtins for VALIGNQ/VALIGND to enable proper target feature checking.
We still emit shufflevector instructions we just do it from CGBuiltin.cpp now.
This
efriedma added a comment.
The problem would come from propagating nonnull-ness from something which isn't
inherently nonnull. For example, strlen has a nonnull argument, so
`strlen(NULL)` is UB, therefore given `int z = strlen(x); if (x) {...}`, we can
remove the null check. (Not sure we
manojgupta added a comment.
In https://reviews.llvm.org/D47894#1125406, @efriedma wrote:
> Does IR generation need any special handling for this? We add nonnull
> attributes in various places.
My interpretation is adding nonnull attributes is fine as long is it is not
derived from a pointer
stephanemoore added a comment.
Is it possible to get someone to land this for me? I don't believe I have
access to land it myself.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D46922
___
cfe-commits mailing list
tejohnson created this revision.
tejohnson added reviewers: pcc, dexonsmith, mehdi_amini.
Herald added subscribers: steven_wu, eraman, inglorion.
Changes to some clang side tests to go with the summary parsing patch.
Depends on https://reviews.llvm.org/D47905.
Repository:
rC Clang
Author: jvesely
Date: Thu Jun 7 13:27:56 2018
New Revision: 334227
URL: http://llvm.org/viewvc/llvm-project?rev=334227=rev
Log:
r600/fmax: Flush denormals before calling builtin.
Same reason as amdgcn.
Fixes fmax, maxmag CTS on turks.
Reviewer: Tom Stellard
Signed-off-by: Jan Vesely
Added:
Author: jvesely
Date: Thu Jun 7 13:27:58 2018
New Revision: 334228
URL: http://llvm.org/viewvc/llvm-project?rev=334228=rev
Log:
r600/fmin: Flush denormals before calling builtin.
Same reason as amdgcn.
Fixes fmin, minmag CTS on turks.
Reviewer: Tom Stellard
Signed-off-by: Jan Vesely
Added:
Author: jvesely
Date: Thu Jun 7 13:27:43 2018
New Revision: 334226
URL: http://llvm.org/viewvc/llvm-project?rev=334226=rev
Log:
math/fma: Add fp32 software implementation
Passes CTS on carrizo (when forced to use sw fma) and turks.
Reviewer: Tom Stellard
Signed-off-by: Jan Vesely
Added:
smeenai added a comment.
Ping @rjmccall
Repository:
rC Clang
https://reviews.llvm.org/D47233
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
smeenai updated this revision to Diff 150399.
smeenai added a comment.
Address objc_exception attribute case
Repository:
rC Clang
https://reviews.llvm.org/D47233
Files:
lib/CodeGen/CGCXXABI.h
lib/CodeGen/CGObjCMac.cpp
lib/CodeGen/MicrosoftCXXABI.cpp
test/CodeGenObjC/dllstorage.m
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334224: [Parse] Use CapturedStmt for @finally on MSVC
(authored by smeenai, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D47564
Files:
Author: smeenai
Date: Thu Jun 7 13:07:52 2018
New Revision: 334224
URL: http://llvm.org/viewvc/llvm-project?rev=334224=rev
Log:
[Parse] Use CapturedStmt for @finally on MSVC
The body of a `@finally` needs to be executed on both exceptional and
non-exceptional paths. On landingpad platforms,
mstorsjo accepted this revision.
mstorsjo added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
Comment at: test/CodeGenCXX/personality.cpp:9
-// RUN: %clang_cc1 -triple i686-unknown-windows-msvc -fexceptions
-fseh-exceptions -fcxx-exceptions -S
Author: zturner
Date: Thu Jun 7 12:58:58 2018
New Revision: 334221
URL: http://llvm.org/viewvc/llvm-project?rev=334221=rev
Log:
[FileSystem] Split up the OpenFlags enumeration.
This breaks the OpenFlags enumeration into two separate
enumerations: OpenFlags and CreationDisposition. The first
Author: zturner
Date: Thu Jun 7 12:58:58 2018
New Revision: 334221
URL: http://llvm.org/viewvc/llvm-project?rev=334221=rev
Log:
[FileSystem] Split up the OpenFlags enumeration.
This breaks the OpenFlags enumeration into two separate
enumerations: OpenFlags and CreationDisposition. The first
smeenai updated this revision to Diff 150394.
smeenai marked 2 inline comments as done.
smeenai added a comment.
Add back missing MinGW coverage
Repository:
rC Clang
https://reviews.llvm.org/D47853
Files:
include/clang/Basic/DiagnosticFrontendKinds.td
lib/Frontend/CompilerInvocation.cpp
smeenai marked 2 inline comments as done.
smeenai added inline comments.
Comment at: test/CodeGen/personality.c:10
-// RUN: %clang_cc1 -triple x86_64-unknown-windows-msvc -D __SEH_EXCEPTIONS__
-fms-extensions -fexceptions -fblocks -fseh-exceptions -S -emit-llvm %s -o - |
ruiu added inline comments.
Comment at: llvm/lib/Support/Windows/Process.inc:240
+ Filename.assign(Base.begin(), Base.end());
+ return ec;
}
The intention of the code is to return a success, so it is less confusing if
you directly return a success (i.e.
Hahnfeld created this revision.
Hahnfeld added a reviewer: tra.
Herald added a subscriber: cfe-commits.
CGM.GetAddrOfConstantCString() sets the adress of the created GlobalValue
to unnamed. When emitting the object file LLVM will mark the surrounding
section as SHF_MERGE iff the string is
vlad.tsyrklevich added a comment.
Herald added a subscriber: steven_wu.
Hi Tobias, I tracked down the failure self-hosting LLVM with LTO with this
revision to https://bugs.llvm.org/show_bug.cgi?id=37684#c2 and have a fix under
review in https://reviews.llvm.org/D47898. This revision needs to be
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334216: Introducing single for loop into clang_proto_fuzzer
(authored by vitalybuka, committed by ).
Repository:
rL LLVM
https://reviews.llvm.org/D47843
Files:
Author: vitalybuka
Date: Thu Jun 7 12:17:46 2018
New Revision: 334216
URL: http://llvm.org/viewvc/llvm-project?rev=334216=rev
Log:
Introducing single for loop into clang_proto_fuzzer
Summary:
Created a new protobuf and protobuf-to-C++ "converter" that wraps the entire
C++ code in a single for
ethanhs added a comment.
In https://reviews.llvm.org/D47864#1124948, @bkramer wrote:
> I don't know much about the python bindings, but this is probably fine.
Yeah I wasn't really sure who to add so I looked at the commit history. Thank
you for adding the right people.
Repository:
rC
vitalybuka updated this revision to Diff 150380.
vitalybuka added a comment.
git clang-format -f --style=file HEAD^
Repository:
rC Clang
https://reviews.llvm.org/D47843
Files:
tools/clang-fuzzer/CMakeLists.txt
tools/clang-fuzzer/ExampleClangLoopProtoFuzzer.cpp
ormris updated this revision to Diff 150377.
ormris added a comment.
Use AST matchers to select references for preservation
Repository:
rC Clang
https://reviews.llvm.org/D47044
Files:
include/clang/StaticAnalyzer/Core/PathSensitive/LoopWidening.h
lib/StaticAnalyzer/Core/ExprEngine.cpp
efriedma added a comment.
Does IR generation need any special handling for this? We add nonnull
attributes in various places.
Repository:
rC Clang
https://reviews.llvm.org/D47894
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
sammccall created this revision.
sammccall added a reviewer: ilya-biryukov.
Herald added a subscriber: cfe-commits.
In particular, stderr etc where the equivalent symbols exist in the global
namespace. Having the symbol instead of the macro helps with ranking, and avoids
the current duplicate
manojgupta created this revision.
manojgupta added reviewers: t.p.northover, efriedma, jyknight, chandlerc, rnk,
srhines, void.
Support for this option is needed for building Linux kernel.
This is a very frequently requested feature by kernel developers.
More details :
emmettneyman updated this revision to Diff 150365.
emmettneyman added a comment.
- refactored cmake and deleted header file
Repository:
rC Clang
https://reviews.llvm.org/D47843
Files:
tools/clang-fuzzer/CMakeLists.txt
tools/clang-fuzzer/ExampleClangLoopProtoFuzzer.cpp
sammccall added a comment.
@ilya-biryukov Ping, anything left for me to do here?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47707
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: ctopper
Date: Thu Jun 7 10:28:03 2018
New Revision: 334208
URL: http://llvm.org/viewvc/llvm-project?rev=334208=rev
Log:
[X86] Add back builtins for _mm_slli_si128/_mm_srli_si128 and similar
intrinsics.
We still lower them to native shuffle IR, but we do it in CGBuiltin.cpp now.
This
tra added a comment.
In https://reviews.llvm.org/D47849#1124638, @Hahnfeld wrote:
> IMO this goes into the right direction, we should use the fast implementation
> in libdevice. If LLVM doesn't lower these calls in the NVPTX backend, I think
> it's ok to use header wrappers as CUDA already
gramanas updated this revision to Diff 150357.
gramanas added a comment.
Make more elaborate comment.
Repository:
rC Clang
https://reviews.llvm.org/D47097
Files:
lib/CodeGen/CGDecl.cpp
test/CodeGen/debug-info-preserve-scope.c
Index: test/CodeGen/debug-info-preserve-scope.c
bader added inline comments.
Comment at: test/Sema/address_spaces.c:17
int *_AS1 _AS2 *Z; // expected-error {{multiple address spaces specified
for type}}
+ int *_AS1 _AS1 *M;
ebevhan wrote:
> Anastasia wrote:
> > ebevhan wrote:
> > > bader wrote:
> > >
labath added a comment.
Yea, one day I'll have to try that out. I'm just putting it off cause it would
nuke all my branches and build folders :/
FWIW, the llvm part can actually be committed without breaking clang or anyone.
Repository:
rL LLVM
https://reviews.llvm.org/D47887
zturner added a comment.
It would be better if you're using a monorepo, that way both parts can just be
one single patch.
Repository:
rL LLVM
https://reviews.llvm.org/D47887
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
labath created this revision.
labath added reviewers: zturner, erik.pilkington.
Herald added a subscriber: mgorny.
This kind of functionality is useful to other project apart from clang.
LLDB works with version numbers a lot, but it does not have a convenient
abstraction for this. Moving this
labath created this revision.
labath added reviewers: erik.pilkington, zturner.
Herald added a subscriber: mgorny.
This kind of functionality is useful to other project apart from clang.
LLDB works with version numbers a lot, but it does not have a convenient
abstraction for this. Moving this
ebevhan added inline comments.
Comment at: include/clang/Sema/DeclSpec.h:670
const PrintingPolicy );
+ bool SetTypeSpecSat(SourceLocation Loc, const char *,
+ unsigned );
leonardchan wrote:
> ebevhan wrote:
> > This
xbolva00 added a comment.
Ping
https://reviews.llvm.org/D47135
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
probinson added a comment.
@rsmith anything else needed here?
https://reviews.llvm.org/D46190
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hans added a comment.
Thanks!
Comment at: lib/AST/MicrosoftMangle.cpp:888-891
auto EnumeratorI = ED->enumerator_begin();
-assert(EnumeratorI != ED->enumerator_end());
-Name += "getName();
+if (EnumeratorI == ED->enumerator_end()) {
+
leonardchan added inline comments.
Comment at: include/clang/Sema/DeclSpec.h:670
const PrintingPolicy );
+ bool SetTypeSpecSat(SourceLocation Loc, const char *,
+ unsigned );
ebevhan wrote:
> This should take a
On Thu, Jun 7, 2018 at 4:05 PM, Richard Smith via cfe-commits
wrote:
>
> struct S { enum {} e; };
>
> ... then do something with decltype(S::e). What happens if there are two
> such types in the class?
The bug doesn't reproduce if the enumeration has a name, which is why
it's hard to reference
majnemer added inline comments.
Comment at: lib/AST/MicrosoftMangle.cpp:888-891
auto EnumeratorI = ED->enumerator_begin();
-assert(EnumeratorI != ED->enumerator_end());
-Name += "getName();
+if (EnumeratorI == ED->enumerator_end()) {
+
Hahnfeld added a comment.
In https://reviews.llvm.org/D47849#1125019, @gtbercea wrote:
> It's precisely the issue which you report here. Since you don't use device
> specific math functions, you can run into the problem where you may end up
> calling assembly instructions for a different
aaron.ballman added a comment.
In https://reviews.llvm.org/D47290#1124991, @hans wrote:
> In https://reviews.llvm.org/D47290#1124964, @aaron.ballman wrote:
>
> > In https://reviews.llvm.org/D47290#1124956, @hans wrote:
> >
> > > In https://reviews.llvm.org/D47290#1124933, @aaron.ballman wrote:
>
alexfh added a reviewer: djasper.
alexfh added inline comments.
Comment at: lib/Format/BreakableToken.cpp:327
+ TokenText.substr(2, TokenText.size() - 4)
+ .split(Lines, TokenText.count('\r') > 0 ? "\r\n" : "\n");
FYI, there's a global UseCRLF flag in
gtbercea added a comment.
In https://reviews.llvm.org/D47849#1124638, @Hahnfeld wrote:
> IMO this goes into the right direction, we should use the fast implementation
> in libdevice. If LLVM doesn't lower these calls in the NVPTX backend, I think
> it's ok to use header wrappers as CUDA
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47704
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
gtbercea added inline comments.
Comment at: lib/Headers/__clang_cuda_device_functions.h:65
}
+#if defined(__cplusplus)
__DEVICE__ void __brkpt() { asm volatile("brkpt;"); }
Hahnfeld wrote:
> Why is that only valid for C++?
C does not support overloading of
hans added a comment.
In https://reviews.llvm.org/D47290#1124964, @aaron.ballman wrote:
> In https://reviews.llvm.org/D47290#1124956, @hans wrote:
>
> > In https://reviews.llvm.org/D47290#1124933, @aaron.ballman wrote:
> >
> > > In https://reviews.llvm.org/D47290#1124866, @hans wrote:
> > >
> >
On Thu, 7 Jun 2018, 13:54 Hans Wennborg via Phabricator via cfe-commits, <
cfe-commits@lists.llvm.org> wrote:
> hans added a comment.
>
> Please take a look.
>
> I couldn't figure out a way to get a mangled name for this without using
> debug info. Do you have any ideas?
>
struct S { enum {} e;
aaron.ballman added a comment.
In https://reviews.llvm.org/D47290#1124956, @hans wrote:
> In https://reviews.llvm.org/D47290#1124933, @aaron.ballman wrote:
>
> > In https://reviews.llvm.org/D47290#1124866, @hans wrote:
> >
> > > If we really want to special-case NSInteger, and given that you're
hans added a comment.
In https://reviews.llvm.org/D47290#1124933, @aaron.ballman wrote:
> In https://reviews.llvm.org/D47290#1124866, @hans wrote:
>
> > If we really want to special-case NSInteger, and given that you're
> > targeting a specific wide-spread pattern maybe that's the right thing
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
I don't know much about the python bindings, but this is probably fine.
Repository:
rC Clang
https://reviews.llvm.org/D47864
___
aaron.ballman added a comment.
In https://reviews.llvm.org/D47290#1124866, @hans wrote:
> If we really want to special-case NSInteger, and given that you're targeting
> a specific wide-spread pattern maybe that's the right thing to do, I think we
> should make -Wformat accept (move the warning
krasimir updated this revision to Diff 150320.
krasimir added a comment.
- Add comments tests
Repository:
rC Clang
https://reviews.llvm.org/D46757
Files:
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTestProto.cpp
unittests/Format/FormatTestRawStrings.cpp
krasimir updated this revision to Diff 150317.
krasimir added a comment.
- Update comments
Repository:
rC Clang
https://reviews.llvm.org/D46757
Files:
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTestProto.cpp
unittests/Format/FormatTestRawStrings.cpp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334192: [clangd] Code completion: drop explicit injected
names/operators, ignore Sema… (authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
Author: sammccall
Date: Thu Jun 7 05:49:17 2018
New Revision: 334192
URL: http://llvm.org/viewvc/llvm-project?rev=334192=rev
Log:
[clangd] Code completion: drop explicit injected names/operators, ignore Sema
priority
Summary:
Now we have most of Sema's code completion signals incorporated in
sammccall marked an inline comment as done.
sammccall added a comment.
Added explicit tests for this feature.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47871
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
sammccall updated this revision to Diff 150307.
sammccall added a comment.
Added tests and comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47871
Files:
clangd/CodeComplete.cpp
clangd/Quality.cpp
clangd/Quality.h
test/clangd/completion.test
1 - 100 of 133 matches
Mail list logo
