christophe-calmejane added a comment.
Hi,
consider the following code
myFunc([](int x) {
if (x)
call();
});
When activating your BeforeLambdaBody option, it changes the code to this
(breaking the start of the lambda to a new line)
myFunc(
[](int x)
SjoerdMeijer added a comment.
Thanks!
https://reviews.llvm.org/D50179
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: sjoerdmeijer
Date: Thu Oct 4 00:38:53 2018
New Revision: 343758
URL: http://llvm.org/viewvc/llvm-project?rev=343758&view=rev
Log:
[AArch64][ARM] Context sensitive meaning of crypto
For AArch64, crypto means:
- sm4 + sha3 + sha2 + aes for Armv8.4-A and up, and
- sha2 + aes for Armv8.3-A a
This revision was automatically updated to reflect the committed changes.
Closed by commit rL343758: [AArch64][ARM] Context sensitive meaning of crypto
(authored by SjoerdMeijer, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D50179?vs
On 04/10/2018 01:14, Richard Smith wrote:
On Tue, 2 Oct 2018 at 01:18, Stephan Bergmann via cfe-commits
mailto:cfe-commits@lists.llvm.org>> wrote:
On 28/09/2018 03:16, Richard Smith via cfe-commits wrote:
> Author: rsmith
> Date: Thu Sep 27 18:16:43 2018
> New Revision: 34328
hokein added inline comments.
Comment at: clangd/index/dex/Dex.h:61
}
// Symbols are owned by BackingData, Index takes ownership.
+ template
nit: this comment is stale too.
Comment at: unittests/clangd/DexTests.cpp:618
+Files.push_b
Author: sammccall
Date: Thu Oct 4 01:30:03 2018
New Revision: 343759
URL: http://llvm.org/viewvc/llvm-project?rev=343759&view=rev
Log:
[clangd] clangd-indexer: Drop support for MR-via-YAML
Summary:
It's slow, and the open-source reduce implementation doesn't scale properly.
While here, tidy up s
This revision was automatically updated to reflect the committed changes.
Closed by commit rL343759: [clangd] clangd-indexer: Drop support for
MR-via-YAML (authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D52517
Files
mboehme updated this revision to Diff 168239.
mboehme added a comment.
- Responses to reviewer comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52782
Files:
clang-tidy/bugprone/UseAfterMoveCheck.cpp
clang-tidy/utils/ExprSequence.cpp
clang-tidy/utils/ExprSequence.h
mboehme marked 3 inline comments as done.
mboehme added inline comments.
Comment at: clang-tidy/utils/ExprSequence.cpp:103
for (const Stmt *Parent : getParentStmts(S, Context)) {
+// For statements that have multiple parents, make sure we're using the
+// parent that l
christophe-calmejane added a comment.
Actually, without your change to HasMultipleNestedBlocks, I'm almost getting
the expected result: Lambda body is correctly indented (and not by function
name's length).
The only thing not working (and it's not either way, with or without your
change to HasM
sammccall marked 2 inline comments as done.
sammccall added inline comments.
Comment at: unittests/clangd/DexTests.cpp:618
+Files.push_back(R.Location.FileURI);
+ });
+}
hokein wrote:
> The test seems doesn't verify any thing?
Oops, thanks!
Repository:
r
lebedev.ri updated this revision to Diff 168240.
lebedev.ri marked an inline comment as done.
lebedev.ri added a comment.
Thank you for taking a look!
- Reworded the diag as suggested a little
- Do consume consequtive semis as one
- Do still record each one of them in AST. I'm not sure if we wa
steveire created this revision.
steveire added a reviewer: aaron.ballman.
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.org/D52870
Files:
include/clang/AST/NestedNameSpecifier.h
lib/AST/NestedNameSpecifier.cpp
Index: lib/AST/NestedNameSpecifier.cpp
===
sammccall updated this revision to Diff 168242.
sammccall marked an inline comment as done.
sammccall added a comment.
Fix test and comment, and sync
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52726
Files:
clangd/index/Serialization.cpp
clangd/index/dex/Dex.cpp
clangd
hokein added a comment.
Looks great! I played around this patch a bit on LLVM. The output size is 50MB
(binary)/1.2G (YAML).
The ref output is not complete (missing all refs in headers, since we only
collect refs from main file), I think we will add an option to
`SymbolCollector` to allow coll
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52726
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
Author: sammccall
Date: Thu Oct 4 02:16:12 2018
New Revision: 343760
URL: http://llvm.org/viewvc/llvm-project?rev=343760&view=rev
Log:
[clangd] Support refs() in dex. Largely cloned from MemIndex.
Reviewers: hokein
Subscribers: ilya-biryukov, ioeric, MaskRay, jkorous, arphaman, kadircet,
cfe-c
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE343760: [clangd] Support refs() in dex. Largely cloned
from MemIndex. (authored by sammccall, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D52726?vs=168242&id=168243#toc
Reposito
petpav01 added a comment.
No worries, thanks.
https://reviews.llvm.org/D51855
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL343761: [constexpr] Fix ICE when memcpy() is given a pointer
to an incomplete array (authored by petr.pavlu, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://rev
Author: petr.pavlu
Date: Thu Oct 4 02:25:44 2018
New Revision: 343761
URL: http://llvm.org/viewvc/llvm-project?rev=343761&view=rev
Log:
[constexpr] Fix ICE when memcpy() is given a pointer to an incomplete array
Fix code for constant evaluation of __builtin_memcpy() and
__builtin_memmove() that
sammccall marked 2 inline comments as done.
sammccall added a comment.
In https://reviews.llvm.org/D52531#1254828, @hokein wrote:
> The ref output is not complete (missing all refs in headers, since we only
> collect refs from main file), I think we will add an option to
> `SymbolCollector` to
sammccall updated this revision to Diff 168245.
sammccall added a comment.
Address review comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52531
Files:
clangd/index/IndexAction.cpp
clangd/index/IndexAction.h
clangd/index/Serialization.cpp
clangd/index/Serializat
klimek added a comment.
In https://reviews.llvm.org/D37813#1253813, @Typz wrote:
> In https://reviews.llvm.org/D37813#1184051, @klimek wrote:
>
> > The problem here is that we have different opinions on how the formatting
> > on namespace macros should behave in the first place- I think they sho
hokein created this revision.
hokein added a reviewer: sammccall.
Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric,
ilya-biryukov.
handleDeclOccurrencce reports a canonical declartion, so stick to use
canonical declarations to determine whether a declaration is in the
target
christophe-calmejane added a comment.
Ok I found the issue with noexcept, it's not related to your patch.
There is a missing
case tok::kw_noexcept:
in
UnwrappedLineParser::tryToParseLambda
Repository:
rC Clang
https://reviews.llvm.org/D44609
_
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
The implementation looks fine, but I believe we concluded that seeing huge
lists here was basically a bug.
So you may not want to land it, if you prefer to keep things simple. Up to you.
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
looks good.
Comment at: clangd/index/Serialization.cpp:301
+// A refs section has data grouped by Symbol. Each symbol has:
+// - SymbolID: 20 bytes
+// - NumRefs: varint
--
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Nice catch!
Comment at: unittests/clangd/XRefsTests.cpp:1185
std::vector> ExpectedLocations;
for (const auto &R : T.ranges("foo"))
ExpectedLocations.pu
Author: hokein
Date: Thu Oct 4 02:56:08 2018
New Revision: 343763
URL: http://llvm.org/viewvc/llvm-project?rev=343763&view=rev
Log:
[clangd] Use canonical declarations in ReferenceFinder.
Summary:
handleDeclOccurrencce reports a canonical declartion, so stick to use
canonical declarations to det
Typz added a comment.
In https://reviews.llvm.org/D37813#1254865, @klimek wrote:
> In https://reviews.llvm.org/D37813#1253813, @Typz wrote:
>
> > In https://reviews.llvm.org/D37813#1184051, @klimek wrote:
> >
> > > The problem here is that we have different opinions on how the formatting
> > > o
hokein updated this revision to Diff 168248.
hokein marked an inline comment as done.
hokein added a comment.
Remove unnecessary labels.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52871
Files:
clangd/XRefs.cpp
unittests/clangd/XRefsTests.cpp
Index: unittests/clangd/XRe
stryku added a comment.
@Rakete Any more comments?
https://reviews.llvm.org/D50766
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE343763: [clangd] Use canonical declarations in
ReferenceFinder. (authored by hokein, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D52871?vs=168248&id=168250#toc
Repository:
rL
This revision was automatically updated to reflect the committed changes.
Closed by commit rL343763: [clangd] Use canonical declarations in
ReferenceFinder. (authored by hokein, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D52871
Files:
takuto.ikuta added a comment.
Ping?
https://reviews.llvm.org/D51340
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ioeric added a comment.
> Generate more short-query trigrams, e.g. "AbcDefGhi" now yields "d" and "ag".
I am concerned about the impact on the size of posting lists (we can measure)
and retrieval quality by adding more incomplete trigrams.
> This is effectively required by LSP, having "ag" not
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM and a few NITs.
Comment at: clangd/index/dex/Iterator.cpp:376
+}
+default:
+ RealChildren.push_back(std::move(Child));
Maybe
philip.pfaffe added a comment.
Is this the right place in the pipeline to put the passes? The legacy PM
inserts the asan passes at EP_OptimizerLast, why not do the same thing?
Repository:
rC Clang
https://reviews.llvm.org/D52814
___
cfe-commits
ioeric added a comment.
> This is useful in the case where the calling tool always wants to use a
> particular non-default implementation (e.g. the tool should always be run
> with the all-TUs executor)
Any reason not to use the constructor of `AllTUsToolExecutor` directly? There
is one that t
Meinersbur updated this revision to Diff 168251.
Meinersbur marked 2 inline comments as done.
Meinersbur added a comment.
- Address @pekka.jaaskelainen's review.
Repository:
rC Clang
https://reviews.llvm.org/D52117
Files:
lib/CodeGen/CGLoopInfo.cpp
lib/CodeGen/CGLoopInfo.h
test/CodeGen
Author: sammccall
Date: Thu Oct 4 03:10:35 2018
New Revision: 343764
URL: http://llvm.org/viewvc/llvm-project?rev=343764&view=rev
Log:
[clangd] Revert accidental flag change
Modified:
clang-tools-extra/trunk/clangd/indexer/IndexerMain.cpp
Modified: clang-tools-extra/trunk/clangd/indexer/Ind
fedor.sergeev added inline comments.
Comment at: lib/CodeGen/BackendUtil.cpp:1031-1038
+ MPM.addPass(AddressSanitizerModulePass());
+
+ // Add Function Pass
+ CGSCCPassManager MainCGPipeline(CodeGenOpts.DebugPassManager);
+ MainCGPipeline.addPass(createCGSCCTo
sammccall created this revision.
sammccall added a reviewer: hokein.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ioeric, ilya-biryukov.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52872
Files:
clangd/indexer/IndexerMain.cpp
Index: clangd/i
JonasToth added a comment.
Thanks for clarification :)
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52782
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mantognini created this revision.
mantognini added a reviewer: Anastasia.
Herald added a subscriber: cfe-commits.
This is just a minor update of the tests.
Repository:
rC Clang
https://reviews.llvm.org/D52873
Files:
test/SemaOpenCL/cl20-device-side-enqueue.cl
Index: test/SemaOpenCL/cl20-
mboehme marked 2 inline comments as done.
mboehme added a comment.
In https://reviews.llvm.org/D52782#1254933, @JonasToth wrote:
> Thanks for clarification :)
Thanks! Do you agree this is ready to land now?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52782
_
ilya-biryukov added inline comments.
Comment at: clangd/indexer/IndexerMain.cpp:84
- $ clangd-indexer --executor=all-TUs compile_commands.json > index.yaml
+ $ clangd-indexer --executor=all-TUs compile_commands.json > clangd-index
Maybe we should suggest a
mantognini created this revision.
mantognini added reviewers: Anastasia, erichkeane.
Herald added subscribers: cfe-commits, kristina.
Ensure __builtin_(add|sub|mul)_overflow return bool instead of void as per
specification (LanguageExtensions).
Repository:
rC Clang
https://reviews.llvm.org/D
hokein created this revision.
hokein added a reviewer: sammccall.
Herald added subscribers: kadircet, arphaman, ioeric, ilya-biryukov.
Previously, clangd index ignored symbols defined in the function body even
IndexFunctionLocals is true.
Repository:
rC Clang
https://reviews.llvm.org/D52877
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
(can you update the title/summary to reflect that only local *types* are
affected?)
Repository:
rC Clang
https://reviews.llvm.org/D52877
__
sammccall added inline comments.
Comment at: clangd/indexer/IndexerMain.cpp:84
- $ clangd-indexer --executor=all-TUs compile_commands.json > index.yaml
+ $ clangd-indexer --executor=all-TUs compile_commands.json > clangd-index
hokein wrote:
> ilya-biryukov
JonasToth created this revision.
JonasToth added reviewers: alexfh, aaron.ballman, baloghadamsoftware.
Herald added subscribers: cfe-commits, rnkovacs, xazax.hun.
The check bugprone-exception-escape should not register
if -fno-exceptions is set for the compile options. Bailing out on non-cplusplu
hokein added inline comments.
Comment at: clangd/indexer/IndexerMain.cpp:58
SymbolCollector::Options Opts;
-Opts.FallbackDir = AssumedHeaderDir;
return createStaticIndexingAction(
If we remove the `assume-header-dir`, we probably remove `FallbackDir
mantognini created this revision.
mantognini added reviewers: Anastasia, spatel.
Herald added subscribers: cfe-commits, kristina.
mantognini added dependencies: D52873: Remove unwanted signedness conversion
from tests, D52875: Fix definitions of __builtin_(add|sub|mul)_overflow.
Prior to this pat
JonasToth added a comment.
In https://reviews.llvm.org/D52782#1254945, @mboehme wrote:
> In https://reviews.llvm.org/D52782#1254933, @JonasToth wrote:
>
> > Thanks for clarification :)
>
>
> Thanks! Do you agree this is ready to land now?
Sure!
Repository:
rCTE Clang Tools Extra
https://re
JonasToth added a comment.
This should definitly be backported, as exception-escape is in 7.0 and it hangs
up on no-except builds
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52880
___
cfe-commits mailing list
cfe-commits@lists.l
lebedev.ri added a comment.
Needs a test.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52880
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: hokein
Date: Thu Oct 4 04:03:55 2018
New Revision: 343767
URL: http://llvm.org/viewvc/llvm-project?rev=343767&view=rev
Log:
[Index] Respect "IndexFunctionLocals" option for type loc.
Summary:
Previously, clang index ignored local symbols defined in the function body even
IndexFunctionLoc
This revision was automatically updated to reflect the committed changes.
Closed by commit rC343767: [Index] Respect "IndexFunctionLocals"
option for type loc. (authored by hokein, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D52877?vs=168261&id=168263#toc
Repository:
rC
JonasToth added a comment.
In https://reviews.llvm.org/D52880#1255031, @lebedev.ri wrote:
> Needs a test.
How shall i test it? It feels that this condition should have been there from
the beginning on, as the check only makes sense in c++ and with exceptions.
Repository:
rCTE Clang Tools E
lebedev.ri added a comment.
In https://reviews.llvm.org/D52880#1255035, @JonasToth wrote:
> In https://reviews.llvm.org/D52880#1255031, @lebedev.ri wrote:
>
> > Needs a test.
>
>
> How shall i test it? It feels that this condition should have been there from
> the beginning on, as the check only
sammccall marked an inline comment as done.
sammccall added a comment.
**TL;DR**: i'm no longer convinced of my conclusions for short-query, look at
the proposal below.
In https://reviews.llvm.org/D52808#1254899, @ioeric wrote:
> > Generate more short-query trigrams, e.g. "AbcDefGhi" now yields
Author: mboehme
Date: Thu Oct 4 04:36:39 2018
New Revision: 343768
URL: http://llvm.org/viewvc/llvm-project?rev=343768&view=rev
Log:
[clang-tidy] Sequence statements with multiple parents correctly (PR39149)
Summary:
Before this fix, the bugprone-use-after-move check could incorrectly
conclude t
This revision was automatically updated to reflect the committed changes.
Closed by commit rL343768: [clang-tidy] Sequence statements with multiple
parents correctly (PR39149) (authored by mboehme, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llv
hans added a comment.
In https://reviews.llvm.org/D52773#1252584, @zturner wrote:
> Canyou add a test that demonstrates that multiple input files on the command
> line will print all of them?
Will do.
> Also does this really need to be a cc1 arg? Why not just print it in the
> driver?
Yeah
ffigueras created this revision.
ffigueras added reviewers: alexfh, kbobyrev.
Herald added subscribers: cfe-commits, xazax.hun.
Option to check for different naming conventions on the following types:
- GlobalConstantPointer
- GlobalPointer
- LocalConstantPointer
- LocalPointer
- PointerParameter
baloghadamsoftware updated this revision to Diff 168274.
baloghadamsoftware added a comment.
Herald added a subscriber: mgorny.
Updated according to the comments.
https://reviews.llvm.org/D52727
Files:
clang-tidy/performance/ForRangeCopyCheck.cpp
clang-tidy/performance/ForRangeCopyCheck.h
I agree magic environment variables are bad, but without it we don’t
address the only current actual use we have for this, which is making the
vs integration print filenames. Detecting compiler version from inside the
integration is hard, but with an environment variable it’s very easy to
solve.
I
zturner added a subscriber: rnk.
zturner added a comment.
I agree magic environment variables are bad, but without it we don’t
address the only current actual use we have for this, which is making the
vs integration print filenames. Detecting compiler version from inside the
integration is hard, b
lebedev.ri added a comment.
Thanks looks even better, getting there.
There are some spurious whiteline changes.
Comment at: clang-tidy/performance/ForRangeCopyCheck.cpp:53
const auto *Var = Result.Nodes.getNodeAs("loopVar");
+
// Ignore code in macros since we can't place
baloghadamsoftware added inline comments.
Comment at: clang-tidy/utils/Matchers.cpp:20
+matchesAnyListedName(const std::vector &NameList) {
+ SmallString<256> NameRegEx;
+ llvm::raw_svector_ostream NameOut(NameRegEx);
lebedev.ri wrote:
> ```
> if(NameList.empty
lebedev.ri added inline comments.
Comment at: clang-tidy/utils/Matchers.cpp:20
+matchesAnyListedName(const std::vector &NameList) {
+ SmallString<256> NameRegEx;
+ llvm::raw_svector_ostream NameOut(NameRegEx);
baloghadamsoftware wrote:
> lebedev.ri wrote:
> > `
lebedev.ri added inline comments.
Comment at: clang-tidy/utils/Matchers.cpp:18-19
+
+Matcher
+matchesAnyListedName(const std::vector &NameList) {
+ SmallString<256> NameRegEx;
Actually wait, what is this?
It should be something like
```
AST_MATCHER_P(NamedDecl,
sammccall updated this revision to Diff 168280.
sammccall added a comment.
Use similar but better-defined rules for short trigram matches.
Modify Dex to account for the matches not being exhaustive.
Unfortunately the test needs https://reviews.llvm.org/D52796, which depends on
this patch.
Repo
lebedev.ri added inline comments.
Comment at: clang-tidy/utils/Matchers.cpp:1
+//===--- Matchers.cpp -
clang-tidy-===//
+//
Also, why is this not in a header?
I suspect that heavily pessimizes inlining.
https://reviews.l
sammccall marked 5 inline comments as done.
sammccall added inline comments.
Comment at: clangd/index/dex/Iterator.cpp:376
+}
+default:
+ RealChildren.push_back(std::move(Child));
ilya-biryukov wrote:
> Maybe replace with `case Kind::Other` to make s
baloghadamsoftware added inline comments.
Comment at: clang-tidy/utils/Matchers.cpp:18-19
+
+Matcher
+matchesAnyListedName(const std::vector &NameList) {
+ SmallString<256> NameRegEx;
lebedev.ri wrote:
> Actually wait, what is this?
> It should be something like
Author: sammccall
Date: Thu Oct 4 06:12:23 2018
New Revision: 343774
URL: http://llvm.org/viewvc/llvm-project?rev=343774&view=rev
Log:
[clangd] Dex: FALSE iterator, peephole optimizations, fix AND bug
Summary:
The FALSE iterator will be used in a followup patch to fix a logic bug in Dex
(current
This revision was automatically updated to reflect the committed changes.
sammccall marked an inline comment as done.
Closed by commit rCTE343774: [clangd] Dex: FALSE iterator, peephole
optimizations, fix AND bug (authored by sammccall, committed by ).
Changed prior to commit:
https://reviews.l
erichkeane added a comment.
Can you write tests for this please? Particularly validate the results in a
constexpr context.
Additionally, these all have the 't' flag, which means that these signatures
are meaningless, right? What are you seeing where this works incorrectly?
Repository:
rC
lebedev.ri added inline comments.
Comment at: clang-tidy/utils/Matchers.cpp:18-19
+
+Matcher
+matchesAnyListedName(const std::vector &NameList) {
+ SmallString<256> NameRegEx;
baloghadamsoftware wrote:
> lebedev.ri wrote:
> > Actually wait, what is this?
> > It
hokein added a comment.
Hi, @aaronpuchert, the patch has caused many new warnings in our internal
codebase, below is a reduced one. Do you mind reverting the patch?
// if the condition is not true, CHECK will terminate the program.
#define CHECK(condition) (__builtin_expect((condition), true
JonasToth added inline comments.
Comment at: clang-tidy/utils/Matchers.cpp:18-19
+
+Matcher
+matchesAnyListedName(const std::vector &NameList) {
+ SmallString<256> NameRegEx;
lebedev.ri wrote:
> baloghadamsoftware wrote:
> > lebedev.ri wrote:
> > > Actually wait
sammccall created this revision.
sammccall added reviewers: ilya-biryukov, ioeric.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay.
Currently queries like "ab" can match identifiers like a_yellow_bee.
The value of allowing this for exactly one segment but no more seems
mantognini added a comment.
In https://reviews.llvm.org/D52875#1255146, @erichkeane wrote:
> Can you write tests for this please? Particularly validate the results in a
> constexpr context.
There are already some tests for those builtins (not sure about constexpr
context). They already tests
mantognini added a comment.
Note: the `get_kernel_*` functions used here all return unsigned integers,
hence the warning/present patch.
Repository:
rC Clang
https://reviews.llvm.org/D52873
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
> The problem is LSP clients are free to assume that the result list is
> complete (unless marked as incomplete) and therefore will never retrieve the
> better symbols.
Good point. Thanks for
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: clangd/index/dex/Trigram.cpp:44
// * Next Head - front character of the next segment
// * Skip-1-Next Head - front character of the skip-1-next segment
Author: sammccall
Date: Thu Oct 4 07:01:55 2018
New Revision: 343775
URL: http://llvm.org/viewvc/llvm-project?rev=343775&view=rev
Log:
[cland] Dex: fix/simplify short-trigram generation
Summary:
1) Instead of x$$ for a short-query trigram, just use x
2) Make rules more coherent: prefixes of leng
This revision was automatically updated to reflect the committed changes.
sammccall marked 2 inline comments as done.
Closed by commit rCTE343775: [cland] Dex: fix/simplify short-trigram generation
(authored by sammccall, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D52808?
balazske added inline comments.
Comment at: lib/AST/ASTImporter.cpp:194
+ // FIXME: This should be the final code.
+ //auto ToOrErr = Importer.Import(From);
+ //if (ToOrErr) {
a_sidorin wrote:
> Do I understand correctly that we have to use the upp
Author: sammccall
Date: Thu Oct 4 07:08:11 2018
New Revision: 343777
URL: http://llvm.org/viewvc/llvm-project?rev=343777&view=rev
Log:
[clangd] Remove one-segment-skipping from Dex trigrams.
Summary:
Currently queries like "ab" can match identifiers like a_yellow_bee.
The value of allowing this
This revision was automatically updated to reflect the committed changes.
sammccall marked an inline comment as done.
Closed by commit rCTE343777: [clangd] Remove one-segment-skipping from Dex
trigrams. (authored by sammccall, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D5
On Wed, Oct 3, 2018 at 3:38 AM Christof Douma
wrote:
> Hi.
>
>
>
> Yes, including would try to include the “version” file inside
> the users project. The problem is not the existence of the header file, but
> the #include directive that is not guarded. To give examples on when this
> goes wrong:
Author: sammccall
Date: Thu Oct 4 07:09:55 2018
New Revision: 343778
URL: http://llvm.org/viewvc/llvm-project?rev=343778&view=rev
Log:
[clangd] clangd-indexer gathers refs and stores them in index files.
Reviewers: ioeric
Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, cfe-com
This revision was automatically updated to reflect the committed changes.
Closed by commit rL343778: [clangd] clangd-indexer gathers refs and stores them
in index files. (authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.or
sammccall updated this revision to Diff 168287.
sammccall added a comment.
example filename "clangd.dex"
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52872
Files:
clangd/indexer/IndexerMain.cpp
Index: clangd/indexer/IndexerMain.cpp
sammccall marked an inline comment as done.
sammccall added inline comments.
Comment at: clangd/indexer/IndexerMain.cpp:58
SymbolCollector::Options Opts;
-Opts.FallbackDir = AssumedHeaderDir;
return createStaticIndexingAction(
hokein wrote:
> If we
1 - 100 of 271 matches
Mail list logo
