bmwiedemann created this revision.
bmwiedemann added a reviewer: RKSimon.
Herald added a subscriber: cfe-commits.
Without this patch, tests would fail after 2030.
Note: requires timestamps with more than 31 bits
Repository:
rC Clang
https://reviews.llvm.org/D52967
Files:
AntonBikineev marked an inline comment as done.
AntonBikineev added a comment.
I've submitted an issue to the Core about the case. Presumably, it will be
included in the next revision (mailing deadline of which is tomorrow).
Comment at: lib/CodeGen/CGCall.cpp:1893
+
+
shuaiwang updated this revision to Diff 168578.
shuaiwang marked 5 inline comments as done.
shuaiwang added a comment.
Resolved review comments.
Repository:
rC Clang
https://reviews.llvm.org/D52219
Files:
include/clang/Analysis/Analyses/ExprMutationAnalyzer.h
jlebar accepted this revision.
jlebar added inline comments.
This revision is now accepted and ready to land.
Comment at: lib/Sema/SemaDeclCXX.cpp:7231
+if (ICI)
+ CSM = getSpecialMember(MD);
+
LGTM, but perhaps we should use a new variable instead of
JonasToth added a comment.
In https://reviews.llvm.org/D52527#1257277, @owenpan wrote:
> I'd greatly appreciate it if someone could review this before I commit it
> next week.
Please do not commit without review. It is ok, to write `ping` every 5-7 days
if there is no comment from the
On Sat, Oct 6, 2018 at 10:06 PM Owen Pan via Phabricator via
cfe-commits wrote:
>
> owenpan added a comment.
>
> I'd greatly appreciate it if someone could review this before I commit it
> next week.
That is not how LLVM reviews work.
Commit-without-review mostly is only for NFC changes in the
owenpan added a comment.
I'd greatly appreciate it if someone could review this before I commit it next
week.
Repository:
rC Clang
https://reviews.llvm.org/D52527
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
jprice added a comment.
This change has caused Clang to start emitting erroneous warnings when using
OpenCL's vector specifier, e.g. "%v4f", which doesn't seem to be covered by the
format string analysis.
https://reviews.llvm.org/D52412
___
xbolva00 added inline comments.
Comment at: lib/Sema/SemaType.cpp:2232
+
+ if (isa(ArraySize))
+ArraySize->EvaluateForOverflow(Context);
xbolva00 wrote:
> Rakete wrote:
> > What's up with this statement? Why is it needed? This won't handle
> >
xbolva00 updated this revision to Diff 168575.
xbolva00 added a comment.
- Use Sema::CheckForIntOverflow
https://reviews.llvm.org/D52750
Files:
lib/Sema/SemaType.cpp
test/Sema/integer-overflow.c
Index: test/Sema/integer-overflow.c
xbolva00 added inline comments.
Comment at: lib/Sema/SemaType.cpp:2232
+
+ if (isa(ArraySize))
+ArraySize->EvaluateForOverflow(Context);
Rakete wrote:
> What's up with this statement? Why is it needed? This won't handle overflows
> for unary
Rakete added inline comments.
Comment at: lib/Sema/SemaType.cpp:2232
+
+ if (isa(ArraySize))
+ArraySize->EvaluateForOverflow(Context);
What's up with this statement? Why is it needed? This won't handle overflows
for unary expression for
xbolva00 abandoned this revision.
xbolva00 added a comment.
This shouldn't be implemented here, better choice is clang-tidy. Closing this
revision.
https://reviews.llvm.org/D52791
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
mewmew added a comment.
Any update on this? There are quite a few people who got excited about this
change and would like to start using it with clang-format.
Repository:
rL LLVM
https://reviews.llvm.org/D28462
___
cfe-commits mailing list
Author: rksimon
Date: Sat Oct 6 04:59:31 2018
New Revision: 343917
URL: http://llvm.org/viewvc/llvm-project?rev=343917=rev
Log:
Revert rL343916: Fix -Wmissing-braces warning. NFCI.
Modified:
clang-tools-extra/trunk/clang-tidy/modernize/DeprecatedIosBaseAliasesCheck.cpp
Modified:
Szelethus added inline comments.
Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h:929
+ // number of arguments is always the same as the number of parameters.
+ unsigned getNumImplicitArgs() const {
+return getOriginExpr()->passAlignment() ? 2 : 1;
Author: rksimon
Date: Sat Oct 6 04:46:27 2018
New Revision: 343916
URL: http://llvm.org/viewvc/llvm-project?rev=343916=rev
Log:
Fix -Wmissing-braces warning. NFCI.
Modified:
clang-tools-extra/trunk/clang-tidy/modernize/DeprecatedIosBaseAliasesCheck.cpp
Modified:
Author: rksimon
Date: Sat Oct 6 04:12:59 2018
New Revision: 343915
URL: http://llvm.org/viewvc/llvm-project?rev=343915=rev
Log:
Wdocumentation fix
Modified:
cfe/trunk/include/clang/Lex/CodeCompletionHandler.h
Modified: cfe/trunk/include/clang/Lex/CodeCompletionHandler.h
URL:
xbolva00 updated this revision to Diff 168569.
xbolva00 added a comment.
- added DefaultIgnore
https://reviews.llvm.org/D52949
Files:
include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaExpr.cpp
test/Sema/div-sizeof-ptr.c
Index:
xbolva00 added a comment.
Ping :)
https://reviews.llvm.org/D52750
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xbolva00 updated this revision to Diff 168564.
https://reviews.llvm.org/D52949
Files:
include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaExpr.cpp
test/Sema/div-sizeof-ptr.c
Index: test/Sema/div-sizeof-ptr.c
xbolva00 updated this revision to Diff 168562.
xbolva00 added a comment.
- fixed formatting noise
https://reviews.llvm.org/D52949
Files:
include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaExpr.cpp
test/Sema/div-sizeof-ptr.c
Index:
ztamas added a reviewer: dcoughlin.
ztamas added a comment.
Based on CODE_OWNERS.txt.
Repository:
rC Clang
https://reviews.llvm.org/D52936
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: maskray
Date: Sat Oct 6 00:00:50 2018
New Revision: 343912
URL: http://llvm.org/viewvc/llvm-project?rev=343912=rev
Log:
[clangd] Remove unused headers from CodeComplete.cpp
queue is not used after index-provided completions' merge with those from Sema
USRGeneration.h is not used after
24 matches
Mail list logo
