[PATCH] D59744: Fix i386 ABI "__m64" type bug

wxiao3 added a comment. Can anyone provide me some small reproducers code for the issue tripped over by Chromium / Skia? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59744/new/ https://reviews.llvm.org/D59744 ___

[PATCH] D57055: [RISCV] Mark TLS as supported

asb accepted this revision. asb added a comment. Herald added subscribers: Jim, benna, psnobl. LGTM, thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57055/new/ https://reviews.llvm.org/D57055 ___ cfe-commits

[PATCH] D62738: [HIP] Support device_shadow variable

yaxunl updated this revision to Diff 205503. yaxunl added a comment. Fix visibility and dso_local. Allow undefined symbol in code object. This is to allow merging the host and device symbols at run time. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62738/new/

[PATCH] D63497: Add support for openSUSE RISC-V triple

asb added a comment. Thanks for the contribution! I'd recommend adding a skeleton toolchain dir structure to clang/test/Driver/Inputs and adding a test to clang/test/Driver/riscv64-toolchain.c. You should be able to see examples in test/Driver/Inputs. Repository: rC Clang CHANGES SINCE

[PATCH] D63498: [RISC-V] Add -msave-restore and -mno-save-restore to clang driver

asb added a comment. Can you add a CHECK line that shows the expected warning is emitted? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63498/new/ https://reviews.llvm.org/D63498 ___ cfe-commits

[PATCH] D57086: Ignore trailing NullStmts in StmtExprs for GCC compatibility

domdom updated this revision to Diff 205501. domdom added a comment. clang-format the patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57086/new/ https://reviews.llvm.org/D57086 Files: clang/include/clang/AST/Stmt.h clang/lib/CodeGen/CGStmt.cpp clang/lib/Parse/ParseStmt.cpp

[PATCH] D63451: P0840R2: support for [[no_unique_address]] attribute

rjmccall added inline comments. Comment at: lib/AST/Decl.cpp:3937 + // -- [has] virtual member functions or virtual base classes, or + // -- has subobjects of nonzero size or bit-fields of nonzero length + if (const auto *CXXRD = dyn_cast(RD)) {

[PATCH] D63535: [clang][AST] MangleUtil: A refactoring of CodegenNameGeneratorImpl (NFC).

plotfi created this revision. plotfi added reviewers: compnerd, ahatanak, akyrtzi, aaron.ballman. Herald added subscribers: cfe-commits, arphaman, dexonsmith. Herald added a project: clang. CodegenNameGeneratorImpl is the most complete implementation of name mangling but it is in clang::Index.

[clang-tools-extra] r363761 - [TEST] Fix test on Windows by looking for substrings rather than a regex

Author: dyung Date: Tue Jun 18 20:02:33 2019 New Revision: 363761 URL: http://llvm.org/viewvc/llvm-project?rev=363761=rev Log: [TEST] Fix test on Windows by looking for substrings rather than a regex since the escaping of special characters appears to break on Windows. Modified:

[PATCH] D62888: [NewPM] Port Sancov

chandlerc added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1231-1232 + MPM.addPass(ModuleSanitizerCoveragePass(SancovOpts)); + MPM.addPass( + createModuleToFunctionPassAdaptor(SanitizerCoveragePass(SancovOpts))); +}

[PATCH] D63451: P0840R2: support for [[no_unique_address]] attribute

rsmith marked 2 inline comments as done. rsmith added inline comments. Comment at: lib/AST/Decl.cpp:3937 + // -- [has] virtual member functions or virtual base classes, or + // -- has subobjects of nonzero size or bit-fields of nonzero length + if (const auto *CXXRD =

[PATCH] D62225: [clang][NewPM] Fixing remaining -O0 tests that are broken under new PM

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. FWIW, this LGTM. We may want to tweak the behavior around flattening, but that can happen as a follow-up, and this seems to get us to a better state. Repository: rG LLVM Github

[PATCH] D63174: [clang][NewPM] Add RUNS for tests that produce slightly different IR under new PM

chandlerc added a comment. OMG, I'm so sorry, I had no idea that the tests would explode like that... Yeah, I don't think that's useful Maybe a better approach is to just explicitly run the code through `opt -passes=instsimplify` before handing it to FileCheck? That should produce almost

[PATCH] D62688: [Analyzer] Iterator Checkers - Model `empty()` method of containers

Szelethus added inline comments. Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:1741-1763 +bool isContainer(const CXXRecordDecl *CRD) { + if (!CRD) +return false; + + for (const auto *Decl : CRD->decls()) { +const auto *TD = dyn_cast(Decl); +if (!TD)

[PATCH] D63156: [clang][NewPM] Add -fno-experimental-new-pass-manager to tests

chandlerc added a comment. In D63156#1543937 , @leonardchan wrote: > I did some more digging and found the following differences between PMs for > each test, and they seem to all differ and can be fixed for different reasons. Awesome, and sorry this is

[PATCH] D63174: [clang][NewPM] Add RUNS for tests that produce slightly different IR under new PM

leonardchan added a comment. OK so I instead wrote a script that generated the tests for me since changing each individual case by hand was painful. All the `-cc1` tests now match, although I don't know any ways of simplifying the IR further to help reduce test size. I would definitely love to

[PATCH] D63174: [clang][NewPM] Add RUNS for tests that produce slightly different IR under new PM

leonardchan updated this revision to Diff 205496. leonardchan marked an inline comment as done. leonardchan added a reviewer: craig.topper. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63174/new/ https://reviews.llvm.org/D63174 Files:

[PATCH] D62571: Implement codegen for MSVC unions with reference members

domdom updated this revision to Diff 205495. domdom added a comment. clang-formatted the test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62571/new/ https://reviews.llvm.org/D62571 Files: clang/lib/CodeGen/CGExpr.cpp clang/test/CodeGenCXX/ms-union-member-ref.cpp Index:

[PATCH] D62688: [Analyzer] Iterator Checkers - Model `empty()` method of containers

Szelethus added a comment. Hmm, an idea just popped into my head. I'm not sure whether we have a single checker that does so much complicated (and totally awesome) modeling as `IteratorChecker`. What do you think about a debug checker similar to `debug.ExprInspection`, like

[PATCH] D62915: git-clang-format: Remove trailing whitespace in docstring. NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rL363759: git-clang-format: Remove trailing whitespace in docstring. NFC. (authored by sbc, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[clang-tools-extra] r363760 - Fix more tests after r363749

Author: aaronpuchert Date: Tue Jun 18 18:54:05 2019 New Revision: 363760 URL: http://llvm.org/viewvc/llvm-project?rev=363760=rev Log: Fix more tests after r363749 Apparently -Wmissing-prototypes is used for quite a few integration tests. Modified:

r363759 - git-clang-format: Remove trailing whitespace in docstring. NFC.

Author: sbc Date: Tue Jun 18 18:52:41 2019 New Revision: 363759 URL: http://llvm.org/viewvc/llvm-project?rev=363759=rev Log: git-clang-format: Remove trailing whitespace in docstring. NFC. Differential Revision: https://reviews.llvm.org/D62915 Modified:

[PATCH] D63451: P0840R2: support for [[no_unique_address]] attribute

rjmccall added a comment. Can this attribute not be applied to a base class, or to a type? I think every time I've seen someone get bitten by the unique-address rule, it was because they had a base class that deleted some constructors (or something like that) and which was a base of a million

[PATCH] D62738: [HIP] Support device_shadow variable

yaxunl updated this revision to Diff 205490. yaxunl retitled this revision from "[HIP] Support texture type" to "[HIP] Support device_shadow variable". yaxunl edited the summary of this revision. yaxunl added a comment. Revised by Artem's comments. CHANGES SINCE LAST ACTION

[PATCH] D63508: make -frewrite-includes handle __has_include wrapped in a macro

vsapsai added a comment. Luboš, can you please clarify what is wrong with the current Clang behavior? I'm just thinking about what should we do with nested macros. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63508/new/ https://reviews.llvm.org/D63508

[PATCH] D63451: P0840R2: support for [[no_unique_address]] attribute

rsmith updated this revision to Diff 205488. rsmith added a comment. - Remove accidentally-added file Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63451/new/ https://reviews.llvm.org/D63451 Files: include/clang/AST/Decl.h include/clang/AST/DeclCXX.h

[PATCH] D63451: P0840R2: support for [[no_unique_address]] attribute

rsmith added inline comments. Comment at: include/clang/AST/DeclCXX.h:337-341 /// true when this class is empty for traits purposes, -/// i.e. has no data members other than 0-width bit-fields, has no +/// i.e. has no data members other than 0-width bit-fields and

[PATCH] D63451: P0840R2: support for [[no_unique_address]] attribute

rsmith updated this revision to Diff 205487. rsmith marked 5 inline comments as done. rsmith added a comment. Herald added a reviewer: jfb. Herald added subscribers: jfb, arphaman. - Address review comments from @AaronBallman. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D62915: git-clang-format: Remove trailing whitespace in docstring. NFC.

aheejin accepted this revision. aheejin added a comment. This revision is now accepted and ready to land. I can't find the option of showing whitespace changes in Phabricator so I can't see it, but I'm always in favor of removing trailing whitespaces :D Repository: rG LLVM Github Monorepo

[PATCH] D63533: [analyzer] Fix clang-tidy crash on GCCAsmStmt

NoQ added a comment. Hey, thanks! That's a nice catch. The code looks fine, but i don't think your test actually tests it - see inline comments. Also i think we should put the test into the clang repo (i.e., `test/Analysis`), because that's where the change is. I'd like to know it if i break

LLVM buildmaster will be restarted tonight

Hello everyone, LLVM buildmaster will be restarted after 7PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D63533: [analyzer] Fix clang-tidy crash on GCCAsmStmt

Nathan-Huckleberry created this revision. Herald added subscribers: cfe-commits, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. Added entry in switch statement to recognize GCCAsmStmt as a possible block

[PATCH] D63369: [AST] Fixed extraneous warnings for binary conditional operator

Nathan-Huckleberry updated this revision to Diff 205473. Nathan-Huckleberry added a comment. Mistakenly updated revision. Attempting to revert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63369/new/ https://reviews.llvm.org/D63369 Files:

[PATCH] D63369: [AST] Fixed extraneous warnings for binary conditional operator

Nathan-Huckleberry updated this revision to Diff 205470. Nathan-Huckleberry added a comment. - [analyzer] Fix clang-tidy crash on GCCAsmStmt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63369/new/ https://reviews.llvm.org/D63369 Files:

[PATCH] D59744: Fix i386 ABI "__m64" type bug

efriedma added a comment. > I'm just laying out the basic requirements for getting this patch back in, > because the current patch is invalid given LLVM's current requirements. Yes, I'm on the same page. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59744/new/

r363754 - Fix tests after r363749

Author: aaronpuchert Date: Tue Jun 18 16:40:17 2019 New Revision: 363754 URL: http://llvm.org/viewvc/llvm-project?rev=363754=rev Log: Fix tests after r363749 We changed -Wmissing-prototypes there, which was used in these tests via -Weverything. Modified:

[PATCH] D59744: Fix i386 ABI "__m64" type bug

rjmccall added a comment. In D59744#1549229 , @efriedma wrote: > If we're going to insert emms instructions automatically, it doesn't really > make sense to do it in the frontend; the backend could figure out the most > efficient placement itself. (See

[PATCH] D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks

anton-afanasyev marked an inline comment as done. anton-afanasyev added inline comments. Comment at: clang/lib/Parse/ParseAST.cpp:167 if (ADecl && !Consumer->HandleTopLevelDecl(ADecl.get())) return; } @lebedev.ri This `return` should follow

[PATCH] D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks

anton-afanasyev added a comment. In D63325#1549316 , @lebedev.ri wrote: > Hmm, i'm only now noticing how fraglie this looks. > How do we know that `clang::ParseAST` will only ever be called with > `BackendConsumer` `ASTConsumer`? > How do we know that

[PATCH] D59402: Suggestions to fix -Wmissing-{prototypes,variable-declarations}

This revision was automatically updated to reflect the committed changes. aaronpuchert marked an inline comment as done. Closed by commit rL363749: Suggestions to fix -Wmissing-{prototypes,variable-declarations} (authored by aaronpuchert, committed by ). Herald added a project: LLVM. Herald

r363749 - Suggestions to fix -Wmissing-{prototypes, variable-declarations}

Author: aaronpuchert Date: Tue Jun 18 15:57:08 2019 New Revision: 363749 URL: http://llvm.org/viewvc/llvm-project?rev=363749=rev Log: Suggestions to fix -Wmissing-{prototypes,variable-declarations} Summary: I've found that most often the proper way to fix this warning is to add `static`, because

[PATCH] D62750: Show note for -Wmissing-prototypes for functions with parameters

This revision was automatically updated to reflect the committed changes. Closed by commit rL363748: Show note for -Wmissing-prototypes for functions with parameters (authored by aaronpuchert, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL

r363748 - Show note for -Wmissing-prototypes for functions with parameters

Author: aaronpuchert Date: Tue Jun 18 15:52:39 2019 New Revision: 363748 URL: http://llvm.org/viewvc/llvm-project?rev=363748=rev Log: Show note for -Wmissing-prototypes for functions with parameters Summary: There was a search for non-prototype declarations for the function, but we only showed

[PATCH] D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks

lebedev.ri added a comment. Hmm, i'm only now noticing how fraglie this looks. How do we know that `clang::ParseAST` will only ever be called with `BackendConsumer` `ASTConsumer`? How do we know that `BackendConsumer` will only ever be `ASTConsumer` from `clang::ParseAST`? Repository: rG

[PATCH] D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks

anton-afanasyev marked 2 inline comments as done. anton-afanasyev added inline comments. Comment at: clang/lib/CodeGen/CodeGenAction.cpp:250-252 + // Finish "Frontend" section starting inside clang::ParseAST() + if (llvm::timeTraceProfilerEnabled()) +

[PATCH] D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks

anton-afanasyev updated this revision to Diff 205451. anton-afanasyev marked an inline comment as done. anton-afanasyev added a comment. Updated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63325/new/ https://reviews.llvm.org/D63325 Files:

[PATCH] D63519: [analyzer] exploded-graph-rewriter: Fix escaping and unescaping of StringRegions.

NoQ updated this revision to Diff 205449. NoQ added a comment. Oh, right, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63519/new/ https://reviews.llvm.org/D63519 Files: clang/lib/StaticAnalyzer/Core/RegionStore.cpp clang/test/Analysis/exploded-graph-rewriter/escapes.c

[PATCH] D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks

lebedev.ri marked an inline comment as done. lebedev.ri added inline comments. Comment at: clang/lib/CodeGen/CodeGenAction.cpp:250-252 + // Finish "Frontend" section starting inside clang::ParseAST() + if (llvm::timeTraceProfilerEnabled()) +

[PATCH] D60455: [SYCL] Implement SYCL device code outlining

aaron.ballman added inline comments. Comment at: clang/test/SemaSYCL/device-attributes.cpp:3 + +[[clang::sycl_kernel]] int gv2 = 0; // expected-warning {{'sycl_kernel' attribute only applies to functions}} +__attribute((sycl_kernel)) int gv3 = 0; // expected-warning

[PATCH] D63519: [analyzer] exploded-graph-rewriter: Fix escaping and unescaping of StringRegions.

Charusso accepted this revision. Charusso marked an inline comment as done. Charusso added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:222 +Indent(Out, Space, IsDot) << "{ " <<

[PATCH] D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks

anton-afanasyev updated this revision to Diff 205446. anton-afanasyev marked 4 inline comments as done. anton-afanasyev added a comment. Updated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63325/new/ https://reviews.llvm.org/D63325 Files:

[PATCH] D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks

anton-afanasyev marked 10 inline comments as done. anton-afanasyev added inline comments. Comment at: clang/lib/CodeGen/CodeGenAction.cpp:250-252 + // Finish "Frontend" section starting inside clang::ParseAST() + if (llvm::timeTraceProfilerEnabled()) +

[PATCH] D63462: [analyzer] JsonSupport: Escape escapes

NoQ added a comment. My problem is demonstrated (and solved) by D63519 . If i revert my changes but apply this patch instead, my test keeps failing. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63462/new/

[PATCH] D63519: [analyzer] exploded-graph-rewriter: Fix escaping and unescaping of StringRegions.

NoQ created this revision. NoQ added a reviewer: Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. Additionally, add a forgotten escape for Store values. Repository:

[PATCH] D59744: Fix i386 ABI "__m64" type bug

efriedma added a comment. If we're going to insert emms instructions automatically, it doesn't really make sense to do it in the frontend; the backend could figure out the most efficient placement itself. (See lib/Target/X86/X86VZeroUpper.cpp, which implements similar logic for AVX.) The

[PATCH] D62761: [analyzer] exploded-graph-rewriter: Implement a --diff mode.

NoQ updated this revision to Diff 205443. NoQ added a comment. Don't try to sneak in an unrelated change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62761/new/ https://reviews.llvm.org/D62761 Files: clang/test/Analysis/exploded-graph-rewriter/environment_diff.dot

[PATCH] D63462: [analyzer] JsonSupport: Escape escapes

Charusso added a comment. In D63462#1549225 , @NoQ wrote: > I mean, i'm removing backslashes but you're adding more backslashes. > Therefore i think we're talking about different issues. You *have to* remove backslashes, because sometimes we have

[PATCH] D63462: [analyzer] JsonSupport: Escape escapes

NoQ added a comment. I mean, i'm removing backslashes but you're adding more backslashes. Therefore i think we're talking about different issues. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63462/new/ https://reviews.llvm.org/D63462

[PATCH] D63518: WIP BitStream reader: propagate errors

jfb added a comment. This is still a work in progress. I still have to debug clang tests that fail, and compile / fix more than clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63518/new/ https://reviews.llvm.org/D63518

[PATCH] D63290: Unify DependencyFileGenerator class and DependencyCollector interface

arphaman updated this revision to Diff 205438. arphaman marked 3 inline comments as done. arphaman added a comment. Address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63290/new/ https://reviews.llvm.org/D63290 Files:

[PATCH] D59744: Fix i386 ABI "__m64" type bug

rjmccall added a comment. Thank you. So it sounds like this patch needs to be reverted, and the correct version of it will have to insert these intrinsic calls in four places: - before translating vector arguments to MMX type before calls that pass `__m64` arguments, - after translating MMX

Re: r363204 - [clang-scan-deps] initial outline of the tool that runs preprocessor to find

I committed r363742 with the fix to the test. Cheers, Alex On Tue, 18 Jun 2019 at 10:23, Alex L wrote: > Hi Douglas, > > Thanks for the heads up! That's definitely a bug. > I don't think "-c" is needed here. I will adjust this test this morning to > remove the "-c", and will address the bug

r363742 - [test] NFC, udpate clang-scan-deps tests to not use -c to avoid driver issues when no integrated assembler is present

Author: arphaman Date: Tue Jun 18 14:36:30 2019 New Revision: 363742 URL: http://llvm.org/viewvc/llvm-project?rev=363742=rev Log: [test] NFC, udpate clang-scan-deps tests to not use -c to avoid driver issues when no integrated assembler is present Caught by Douglas Yung. Modified:

[PATCH] D59253: [AIX][libcxx] AIX system headers need stdint.h and inttypes.h to be re-enterable when macro _STD_TYPES_T is defined

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59253/new/ https://reviews.llvm.org/D59253 ___ cfe-commits

[PATCH] D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks

lebedev.ri added inline comments. Comment at: clang/lib/CodeGen/CodeGenAction.cpp:250-252 + // Finish "Frontend" section starting inside clang::ParseAST() + if (llvm::timeTraceProfilerEnabled()) +llvm::timeTraceProfilerEnd(); I think i'm

[PATCH] D59744: Fix i386 ABI "__m64" type bug

mtklein added a comment. Ah, thank you for that explanation. That's got to be exactly what we're tripping over in Chromium / Skia. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59744/new/ https://reviews.llvm.org/D59744

[PATCH] D63462: [analyzer] JsonSupport: Escape escapes

Charusso added a comment. In D63462#1549144 , @NoQ wrote: > Hmm, this doesn't seem to solve my problem in D62761 > . Let me write some actual test case so that > you knew it's fixed when it's fixed. Well, I have did

[PATCH] D59744: Fix i386 ABI "__m64" type bug

efriedma added a comment. > Are you saying that using MMX in LLVM requires source-level workarounds in > some way, and so we can't lower portable code to use MMX because that code > will (reasonably) lack those workarounds? Yes. The x86 architecture requires that a program executes an "emms"

[PATCH] D63462: [analyzer] JsonSupport: Escape escapes

NoQ added a comment. Hmm, this doesn't seem to solve my problem in D62761 . Let me write some actual test case so that you knew it's fixed when it's fixed. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63462/new/

r363734 - [OPENMP]Use host's mangling for 128 bit float types on the device.

Author: abataev Date: Tue Jun 18 13:29:06 2019 New Revision: 363734 URL: http://llvm.org/viewvc/llvm-project?rev=363734=rev Log: [OPENMP]Use host's mangling for 128 bit float types on the device. Device have to use the same mangling as the host for 128bit float types. Otherwise, the codegen for

[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

kpn added a comment. Andy, can I get you to chime in? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53157/new/ https://reviews.llvm.org/D53157 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

rjmccall added inline comments. Comment at: include/llvm/IR/IntrinsicInst.h:235 + ebStrict ///< This corresponds to "fpexcept.strict". }; kpn wrote: > rjmccall wrote: > > Is it okay that `ebUnspecified` and `ebInvalid` overlap here? > I can

[PATCH] D59744: Fix i386 ABI "__m64" type bug

rjmccall added a comment. In D59744#1548919 , @efriedma wrote: > > Now, we could theoretically use a different ABI rule for vectors defined > > with Clang-specific extensions, but that seems like it would cause quite a > > few problems of its own. > > I

r363720 - [OPENMP][NVPTX]Correct codegen for 128 bit long double.

Author: abataev Date: Tue Jun 18 12:04:27 2019 New Revision: 363720 URL: http://llvm.org/viewvc/llvm-project?rev=363720=rev Log: [OPENMP][NVPTX]Correct codegen for 128 bit long double. If the host uses 128 bit long doubles, the compiler should generate correct code for NVPTX devices. If the

[PATCH] D63508: make -frewrite-includes handle __has_include wrapped in a macro

llunak created this revision. llunak added reviewers: vsapsai, bkramer. llunak added a project: clang. Herald added subscribers: cfe-commits, dexonsmith. Qt5 has a wrapper macro that makes __has_include simpler to use: #ifdef __has_include 1. define QT_HAS_INCLUDE(x)

[PATCH] D63490: Script for generating AST JSON dump test cases

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thanks! I think we can maybe make this a little more convenient to use. For the non-JSON `-ast-dump` format, I added `utils/make-ast-dump-check.sh` which can be used as (for example): $

[PATCH] D59744: Fix i386 ABI "__m64" type bug

efriedma added a comment. > Now, we could theoretically use a different ABI rule for vectors defined with > Clang-specific extensions, but that seems like it would cause quite a few > problems of its own. I think we can't reasonably impose this ABI rule on vectors defined with

r363717 - [OPENMP]Use host's long double when compiling the code for device.

Author: abataev Date: Tue Jun 18 11:39:26 2019 New Revision: 363717 URL: http://llvm.org/viewvc/llvm-project?rev=363717=rev Log: [OPENMP]Use host's long double when compiling the code for device. The device code must use the same long double type as the host. Otherwise the code cannot be linked

[PATCH] D63381: Allow copy/move assignment operator to be coroutine as per N4775

GorNishanov accepted this revision. GorNishanov added a comment. This revision is now accepted and ready to land. LGTM! Thank you for the fix. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63381/new/ https://reviews.llvm.org/D63381 ___

[PATCH] D62437: [clang-tidy] Splits fuchsia-default-arguments

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL363712: [clang-tidy] Split fuchsia-default-arguments (authored by juliehockett, committed by ). Herald added a project:

[PATCH] D63361: Pretend NRVO variables are references so they can be found by debug info

aprantl added a comment. Thanks, this addresses my concern! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63361/new/ https://reviews.llvm.org/D63361 ___ cfe-commits mailing list

[clang-tools-extra] r363712 - [clang-tidy] Split fuchsia-default-arguments

Author: juliehockett Date: Tue Jun 18 11:07:33 2019 New Revision: 363712 URL: http://llvm.org/viewvc/llvm-project?rev=363712=rev Log: [clang-tidy] Split fuchsia-default-arguments Splits fuchsia-default-arguments check into two checks. fuchsia-default-arguments-calls warns if a function or

[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

kpn marked an inline comment as done. kpn added inline comments. Comment at: include/llvm/IR/IntrinsicInst.h:235 + ebStrict ///< This corresponds to "fpexcept.strict". }; rjmccall wrote: > Is it okay that `ebUnspecified` and `ebInvalid`

r363709 - Add test cases for dumping AST function decl nodes to JSON; NFC.

Author: aaronballman Date: Tue Jun 18 10:56:50 2019 New Revision: 363709 URL: http://llvm.org/viewvc/llvm-project?rev=363709=rev Log: Add test cases for dumping AST function decl nodes to JSON; NFC. Added: cfe/trunk/test/AST/ast-dump-funcs-json.cpp Added:

[PATCH] D63503: cmake: Add CLANG_LINK_CLANG_DYLIB option

tstellar created this revision. tstellar added reviewers: mgorny, beanz, smeenai, phosek, sylvestre.ledru. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. Setting CLANG_LINK_CLANG_DYLIB=ON causes clang tools to link against libclang_shared.so instead of the

[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

rjmccall added inline comments. Comment at: include/llvm/IR/IntrinsicInst.h:235 + ebStrict ///< This corresponds to "fpexcept.strict". }; Is it okay that `ebUnspecified` and `ebInvalid` overlap here? Comment at:

[PATCH] D59744: Fix i386 ABI "__m64" type bug

rjmccall added a comment. In D59744#1548540 , @mtklein wrote: > Hey folks, I'm the Skia point of contact on this, and "luckily" the person > who wrote all the code that got us into this mess. Let me cross post a > couple questions I've had from the

Re: r363204 - [clang-scan-deps] initial outline of the tool that runs preprocessor to find

Hi Douglas, Thanks for the heads up! That's definitely a bug. I don't think "-c" is needed here. I will adjust this test this morning to remove the "-c", and will address the bug later. Thanks, Alex On Mon, 17 Jun 2019 at 18:02, wrote: > Hi Alex, > > In the test you added here, the json file

[PATCH] D62956: [clangd] Collect tokens of main files when building the AST

ilya-biryukov added a comment. In D62956#1547826 , @sammccall wrote: > Can we add a test using TestTU that does a very basic verification of > expanded/spelled tokens (first after preamble, last token in file)? Done. Will land this tomorrow, want to

[PATCH] D62956: [clangd] Collect tokens of main files when building the AST

ilya-biryukov updated this revision to Diff 205387. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. - Rename tokens() to getTokens() for consistency with the rest of ParsedAST. - Update comments. - Add a test. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D63361: Pretend NRVO variables are references so they can be found by debug info

rnk added a comment. This needs two unit tests: - A clang test at `clang/test/CodeGenCXX/debug-info-nrvo.cpp` similar to other debug-info-* tests there. This test should have a second RUN line and extra checks for -fno-elide-constructors. - An LLVM test at `llvm/test/DebugInfo/COFF/nrvo.ll` to

[PATCH] D62635: Add enums as global variables in the IR metadata.

dblaikie added a comment. In D62635#1548721 , @rnk wrote: > In D62635#1548648 , @dblaikie wrote: > > > In D62635#1548157 , @rnk wrote: > > > > > We did things this way to

[PATCH] D62635: Add enums as global variables in the IR metadata.

rnk added a comment. In D62635#1548648 , @dblaikie wrote: > In D62635#1548157 , @rnk wrote: > > > We did things this way to track which **enumerators** were used, not which > > enums were used. Size data showed it

[PATCH] D63361: Pretend NRVO variables are references so they can be found by debug info

akhuang updated this revision to Diff 205385. akhuang added a comment. - add semicolon Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63361/new/ https://reviews.llvm.org/D63361 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D63361: Pretend NRVO variables are references so they can be found by debug info

akhuang added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:1145-1149 +bool Deref = false; +if (VI.Expr) { + if (!VI.Expr->extractIfOffset(ExprOffset, Deref)) continue; +} rnk wrote: > I see. I thought this

[PATCH] D63161: Devirtualize destructor of final class.

yamauchi updated this revision to Diff 205381. yamauchi added a comment. Updated. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63161/new/ https://reviews.llvm.org/D63161 Files: lib/CodeGen/CGExprCXX.cpp test/CodeGenCXX/devirtualize-dtor-final.cpp Index:

[PATCH] D63361: Pretend NRVO variables are references so they can be found by debug info

akhuang updated this revision to Diff 205382. akhuang marked 2 inline comments as done. akhuang added a comment. Now creates a pointer to the return location in the function prolog, whenever sret is being used. Also addressed some other comments. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D63498: [RISC-V] Add -msave-restore and -mno-save-restore to clang driver

lenary created this revision. lenary added reviewers: asb, luismarques. Herald added subscribers: cfe-commits, jocewei, PkmX, rkruppe, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sabuasal, apazos, simoncook, johnrusso, rbar. Herald

[PATCH] D62953: [Syntax] Do not glue multiple empty PP expansions to a single mapping

ilya-biryukov added a comment. In D62953#1547799 , @sammccall wrote: > Can you explain why this is important? > (in the code) I've added a few comments into the code that builds token buffers, but I couldn't figure out a good place to mention this in

[PATCH] D62953: [Syntax] Do not glue multiple empty PP expansions to a single mapping

ilya-biryukov updated this revision to Diff 205377. ilya-biryukov added a comment. - Added comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62953/new/ https://reviews.llvm.org/D62953 Files: clang/include/clang/Tooling/Syntax/Tokens.h

  1   2   3   >