[PATCH] D67613: [DWARF-5] Support for DWARF-5 C++ language tags

SouraVX added a comment. In D67613#1674597 , @aprantl wrote: > Please be sure the watch the lldb (and other debugger) bots after committing > this.. Thanks a lot! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67613/new/

r372299 - [Builtins] Delete setjmp_syscall and qsetjmp

Author: maskray Date: Wed Sep 18 21:41:38 2019 New Revision: 372299 URL: http://llvm.org/viewvc/llvm-project?rev=372299=rev Log: [Builtins] Delete setjmp_syscall and qsetjmp Similar to the resolution of gcc PR71876. Nobody uses them or needs the [-Wincomplete-setjmp-declaration] diagnostic.

[PATCH] D60748: Fix i386 struct and union parameter alignment

LiuChen3 updated this revision to Diff 220793. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60748/new/ https://reviews.llvm.org/D60748 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/x86_32-align-linux.c clang/test/CodeGen/x86_32-align-linux.cpp

[PATCH] D67734: [CLANG-BPF] change __builtin_preserve_access_index() signature

This revision was automatically updated to reflect the committed changes. Closed by commit rL372294: [CLANG][BPF] change __builtin_preserve_access_index() signature (authored by yhs, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r372294 - [CLANG][BPF] change __builtin_preserve_access_index() signature

Author: yhs Date: Wed Sep 18 19:59:43 2019 New Revision: 372294 URL: http://llvm.org/viewvc/llvm-project?rev=372294=rev Log: [CLANG][BPF] change __builtin_preserve_access_index() signature The clang intrinsic __builtin_preserve_access_index() currently has signature: const void *

[PATCH] D67744: [clang-tidy] Fix bugprone-argument-comment-check to correctly ignore implicit constructors.

ymandel created this revision. ymandel added a reviewer: gribozavr. Herald added a subscriber: xazax.hun. Herald added a project: clang. After revision 370919, this check incorrectly flags certain cases of implicit constructors. Specifically, if an argument is annotated with an argument-comment

[PATCH] D67647: [Consumed] Refactor handleCall to take function argument list. NFC.

dblaikie added a comment. In D67647#1674781 , @comex wrote: > In D67647#1674773 , @dblaikie wrote: > > > I wasn't expecting it to involve all this work - but instead to change > > "arguments()" to return ArrayRef.

[PATCH] D67740: [Consumed] Refactor and improve diagnostics

comex updated this revision to Diff 220784. comex added a comment. Fixed a mistake where the diagnostic would print the wrong parameter type. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67740/new/ https://reviews.llvm.org/D67740 Files:

[PATCH] D67647: [Consumed] Refactor handleCall to take function argument list. NFC.

comex added a comment. In D67647#1674773 , @dblaikie wrote: > I wasn't expecting it to involve all this work - but instead to change > "arguments()" to return ArrayRef. Though perhaps you didn't go that route to > allow future fixes to the strict

r372281 - Initialize all fields in ABIArgInfo.

Author: serge_sans_paille Date: Wed Sep 18 17:54:40 2019 New Revision: 372281 URL: http://llvm.org/viewvc/llvm-project?rev=372281=rev Log: Initialize all fields in ABIArgInfo. Due to usage of an uninitialized fields, we end up with a Conditional jump or move depends on uninitialised value Fixes

[PATCH] D67647: [Consumed] Refactor handleCall to take function argument list. NFC.

dblaikie added a comment. In D67647#1674745 , @comex wrote: > Here's a new version of the patch that uses iterator ranges instead of > `ArrayRef`, to avoid adding new uses of `CallExpr::getArgs()` in case it has > to be removed in the future due to the

[PATCH] D67743: [Consumed] Treat by-value class arguments as consuming by default, like rvalue refs.

comex created this revision. comex added a reviewer: dblaikie. Herald added a project: clang. Herald added a subscriber: cfe-commits. Also, fix the order of `if` statements so that an explicit `return_typestate` annotation takes precedence over the default behavior for rvalue refs. Note that

[PATCH] D67737: [clang-tidy] Add check for classes missing -hash ⚠️

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:105 +- New :doc:`objc-missing-hash + ` check. Wrong place. Please move to new checks list (in alphabetical order). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D67737: [clang-tidy] Add check for classes missing -hash ⚠️

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/objc/MissingHashCheck.cpp:40 +void MissingHashCheck::registerMatchers(MatchFinder *Finder) { + Finder->addMatcher( + objcMethodDecl( Should check if language is Objective-C. See

[PATCH] D67647: [Consumed] Refactor handleCall to take function argument list. NFC.

comex updated this revision to Diff 220771. comex added a comment. Herald added subscribers: llvm-commits, dexonsmith. Herald added a project: LLVM. Here's a new version of the patch that uses iterator ranges instead of `ArrayRef`, to avoid adding new uses of `CallExpr::getArgs()` in case it has

[PATCH] D67635: Fix for stringized function-macro args continued across lines

kousikk added a comment. Ping on the review for this :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67635/new/ https://reviews.llvm.org/D67635 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D67734: [CLANG-BPF] change __builtin_preserve_access_index() signature

ast accepted this revision. ast added a comment. This revision is now accepted and ready to land. that's indeed much better. Thanks for adding all the tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67734/new/ https://reviews.llvm.org/D67734

[PATCH] D67734: [CLANG-BPF] change __builtin_preserve_access_index() signature

yonghong-song updated this revision to Diff 220772. yonghong-song edited the summary of this revision. yonghong-song added a comment. does not change arg type and make result type the same as arg type Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D67740: [Consumed] Refactor and improve diagnostics

comex created this revision. comex added a reviewer: dblaikie. Herald added a project: clang. Herald added a subscriber: cfe-commits. As suggested by FIXME comments, fix commented-out diagnostic in Sema and remove the equivalent check within the consumed analysis. The diagnostic in question is

[PATCH] D67739: [WebAssembly] Let users know that wasm64 does not exist

sunfish added a comment. Would it be better to do this check in LLVM, in the backend, with a `report_fatal_error`? Clang for its part already supports what we expect wasm64 will need already, and we have a bunch of tests for it, so it'd be nice to keep that code around and tested. And, doing

[PATCH] D67739: [WebAssembly] Let users know that wasm64 does not exist

tlively created this revision. tlively added reviewers: dschuff, aheejin. Herald added subscribers: cfe-commits, jfb, sunfish, jgravelle-google, sbc100. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D67739 Files:

[PATCH] D67737: [clang-tidy] Add check for classes missing -hash ⚠️

stephanemoore created this revision. Herald added subscribers: cfe-commits, xazax.hun, mgorny. Herald added a project: clang. Apple documentation states that: "If two objects are equal, they must have the same hash value. This last point is particularly important if you define isEqual: in a

[PATCH] D67730: [CUDA][HIP] Fix typo in `BestViableFunction`

tra added a comment. LGTM. You may want to wait a bit for Justin's feedback, in case he has some concerns. Comment at: clang/test/SemaCUDA/function-overload.cu:406 + +// Two irrelevant classes with `operator-` defined. One of them is device only. +struct C1 { int m; };

[PATCH] D67545: [clang-tidy] Added DefaultOperatorNewCheck.

lebedev.ri added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/CERTTidyModule.cpp:69 +// MEM +CheckFactories.registerCheck("cert-mem57-cpp"); I find `DefaultOperatorNewCheck` to be insufficiently explanative. Maybe

[PATCH] D66716: [analyzer] PR43102: Fix an assertion and an out-of-bounds error for diagnostic location construction

Szelethus added a comment. We have no solid evidence to conclude that such an event should not occur at a `BlockEntrance`, so fixing this error mustn't be that bad. I certainly should've used `llvm::isa_or_nonnull`, so the patch overall makes sense, so I'm commiting it as is. With that said,

[PATCH] D66716: [analyzer] PR43102: Fix an assertion and an out-of-bounds error for diagnostic location construction

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL372269: [analyzer] PR43102: Fix an assertion and an out-of-bounds error for diagnostic… (authored by Szelethus, committed

r372269 - [analyzer] PR43102: Fix an assertion and an out-of-bounds error for diagnostic location construction

Author: szelethus Date: Wed Sep 18 15:24:26 2019 New Revision: 372269 URL: http://llvm.org/viewvc/llvm-project?rev=372269=rev Log: [analyzer] PR43102: Fix an assertion and an out-of-bounds error for diagnostic location construction Summary: https://bugs.llvm.org/show_bug.cgi?id=43102 In

[PATCH] D67723: [CodeView] Add option to disable inline line tables.

akhuang updated this revision to Diff 220756. akhuang marked 3 inline comments as done. akhuang added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67723/new/ https://reviews.llvm.org/D67723 Files:

[PATCH] D67480: [analyzer] Add 'freopen' support to SimpleStreamChecker.

NoQ added a comment. Btw, `evalCall` is not deprecated. In fact, there are no alternatives for it in many cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67480/new/ https://reviews.llvm.org/D67480

[PATCH] D67706: [clang][analyzer] Using CallDescription in StreamChecker.

NoQ added a comment. Thanks! Woohoo, tests! You can go one step further to have a `CallDescriptionMap`, like in D62557 . This would replace the whole chain of `if`s with a map lookup (which is currently still a chain of `if`s under the hood, but a lot less

r372263 - fix build, adjust test also for Windows path separator

Author: llunak Date: Wed Sep 18 14:41:45 2019 New Revision: 372263 URL: http://llvm.org/viewvc/llvm-project?rev=372263=rev Log: fix build, adjust test also for Windows path separator Introduced in 1e9c1d2b7bfc. Modified: cfe/trunk/test/Frontend/rewrite-includes-conditions.c

[PATCH] D67613: [DWARF-5] Support for DWARF-5 C++ language tags

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Please be sure the watch the lldb (and other debugger) bots after committing this.. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67613/new/ https://reviews.llvm.org/D67613

[PATCH] D67567: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage

mwyman updated this revision to Diff 220751. mwyman added a comment. Addressed review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67567/new/ https://reviews.llvm.org/D67567 Files: clang-tools-extra/clang-tidy/CMakeLists.txt

[PATCH] D49091: Warn about usage of __has_include/__has_include_next in macro expansions

arichardson added a comment. Herald added a project: clang. Ping? I'm not sure if this is still required now that D63508 has been committed? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49091/new/

[PATCH] D67734: [CLANG-BPF] change __builtin_preserve_access_index() signature

yonghong-song created this revision. yonghong-song added a reviewer: ast. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. The clang intrinsic __builtin_preserve_access_index() currently has signature: const void * __builtin_preserve_access_index(const void *

[PATCH] D67119: On PowerPC, Secure-PLT by default for FreeBSD 13 and higher

This revision was automatically updated to reflect the committed changes. Closed by commit rL372261: On PowerPC, Secure-PLT by default for FreeBSD 13 and higher (authored by dim, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES

r372261 - On PowerPC, Secure-PLT by default for FreeBSD 13 and higher

Author: dim Date: Wed Sep 18 13:58:03 2019 New Revision: 372261 URL: http://llvm.org/viewvc/llvm-project?rev=372261=rev Log: On PowerPC, Secure-PLT by default for FreeBSD 13 and higher Summary: In https://svnweb.freebsd.org/changeset/base/349351, FreeBSD 13 and higher transitioned to Secure-PLT

[PATCH] D52281: [clang-tidy] Add modernize check to use std::invoke in generic code

boga95 marked an inline comment as done. boga95 added a comment. Resolving the problems properly seemed quite difficult. I just finished university and started to work, therefore I don't have enough free time to finish the checker. Sorry about that. CHANGES SINCE LAST ACTION

[PATCH] D67730: [CUDA][HIP] Fix typo in `BestViableFunction`

hliao created this revision. hliao added a reviewer: tra. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Should consider viable ones only when checking SameSide candidates. - Replace erasing with clearing viable flag to reduce data moving/copying. - Add one and revise

r372252 - [OPENMP]Fix for PR43349: Crash for privatized loop bound.

Author: abataev Date: Wed Sep 18 12:24:07 2019 New Revision: 372252 URL: http://llvm.org/viewvc/llvm-project?rev=372252=rev Log: [OPENMP]Fix for PR43349: Crash for privatized loop bound. If the variable, used in the loop boundaries, is not captured in the construct, this variable must be

[PATCH] D63979: actually also compile output in tests for -frewrite-includes

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL372250: actually also compile output in tests for -frewrite-includes (authored by llunak, committed by ). Herald added a

[PATCH] D67718: [clang-format][PR41899] PointerAlignment: Left leads to useless space in lambda intializer expression

This revision was automatically updated to reflect the committed changes. Closed by commit rL372249: [clang-format][PR41899] PointerAlignment: Left leads to useless space in lambda… (authored by paulhoad, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

[PATCH] D67647: [Consumed] Refactor handleCall to take function argument list. NFC.

dblaikie added a comment. In D67647#1673363 , @comex wrote: > Ugh, it looks like `getArgs()` is a massive strict aliasing violation. And > it's used in enough different places in Clang that fixing the violation may > require extensive refactoring...

[PATCH] D67723: [CodeView] Add option to disable inline line tables.

dblaikie added subscribers: JDevlieghere, aprantl. dblaikie added a comment. As per the bug - I'm not super inclined towards a function attribute here (& even if it's going to be an inliner rather than debug info generation/backend thing (which I'm more on the fence about - think I'm happy with

r372250 - actually also compile output in tests for -frewrite-includes

Author: llunak Date: Wed Sep 18 12:12:14 2019 New Revision: 372250 URL: http://llvm.org/viewvc/llvm-project?rev=372250=rev Log: actually also compile output in tests for -frewrite-includes Checking that the created output matches something is nice, but this should also check whether the output

r372249 - [clang-format][PR41899] PointerAlignment: Left leads to useless space in lambda intializer expression

Author: paulhoad Date: Wed Sep 18 12:11:40 2019 New Revision: 372249 URL: http://llvm.org/viewvc/llvm-project?rev=372249=rev Log: [clang-format][PR41899] PointerAlignment: Left leads to useless space in lambda intializer expression Summary: https://bugs.llvm.org/show_bug.cgi?id=41899 ```auto

r372248 - make -frewrite-includes also rewrite conditions in #if/#elif

Author: llunak Date: Wed Sep 18 12:09:41 2019 New Revision: 372248 URL: http://llvm.org/viewvc/llvm-project?rev=372248=rev Log: make -frewrite-includes also rewrite conditions in #if/#elif Those conditions may use __has_include, which needs to be rewritten. The existing code has already tried to

[PATCH] D66856: [Sema] Suppress -Wformat diagnostics for bool types when printed using %hhd

This revision was automatically updated to reflect the committed changes. Closed by commit rL372247: [Sema] Suppress -Wformat diagnostics for bool types when printed using %hhd (authored by epilk, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D63508: make -frewrite-includes also rewrite conditions in #if/#elif

This revision was automatically updated to reflect the committed changes. Closed by commit rL372248: make -frewrite-includes also rewrite conditions in #if/#elif (authored by llunak, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r372247 - [Sema] Suppress -Wformat diagnostics for bool types when printed using %hhd

Author: epilk Date: Wed Sep 18 12:05:14 2019 New Revision: 372247 URL: http://llvm.org/viewvc/llvm-project?rev=372247=rev Log: [Sema] Suppress -Wformat diagnostics for bool types when printed using %hhd Also, add a diagnostic under -Wformat for printing a boolean value as a character.

[PATCH] D67670: [clang-format][PR41964] Fix crash with SIGFPE when TabWidth is set to 0 and line starts with tab

This revision was automatically updated to reflect the committed changes. Closed by commit rL372246: [clang-format][PR41964] Fix crash with SIGFPE when TabWidth is set to 0 and… (authored by paulhoad, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

r372246 - [clang-format][PR41964] Fix crash with SIGFPE when TabWidth is set to 0 and line starts with tab

Author: paulhoad Date: Wed Sep 18 11:57:09 2019 New Revision: 372246 URL: http://llvm.org/viewvc/llvm-project?rev=372246=rev Log: [clang-format][PR41964] Fix crash with SIGFPE when TabWidth is set to 0 and line starts with tab Summary: clang-format 8.0 crashes with SIGFPE (floating point

[PATCH] D66856: [Sema] Suppress -Wformat diagnostics for bool types when printed using %hhd

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for this! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66856/new/ https://reviews.llvm.org/D66856 ___

[PATCH] D67723: [CodeView] Add option to disable inline line tables.

rnk added a comment. + other debug info people Comment at: llvm/docs/LangRef.rst:1436 function. This can have very system-specific consequences. +``no-inline-line-tables`` +When this attribute is set to true, inline line tables are not generated This

[PATCH] D67720: [clangd] Add semantic selection to ClangdLSPServer.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1135 + Params.positions.size()); +Reply(llvm::make_error("failed to decode request", + ErrorCode::InvalidRequest));

[PATCH] D66856: [Sema] Suppress -Wformat diagnostics for bool types when printed using %hhd

erik.pilkington added a comment. Ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66856/new/ https://reviews.llvm.org/D66856 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D67720: [clangd] Add semantic selection to ClangdLSPServer.

usaxena95 updated this revision to Diff 220710. usaxena95 marked 2 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67720/new/ https://reviews.llvm.org/D67720 Files:

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

sdmitriev added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67031/new/ https://reviews.llvm.org/D67031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D63607: [clang][driver] Add basic --driver-mode=flang support for fortran

hfinkel added a comment. > One thought that occurs to me when reviewing this. I think we will assume > that F18 /flang when it lands in the LLVM > project will be an optional thing to build and will be an opt-in project at > the start that is off by default. What

[PATCH] D66795: [Mips] Use appropriate private label prefix based on Mips ABI

arichardson accepted this revision. arichardson added a comment. This revision is now accepted and ready to land. Looks good to me but I guess someone else should give the final approval. Comment at: llvm/lib/Target/Mips/MCTargetDesc/MipsMCAsmInfo.cpp:25 if

[PATCH] D67723: [CodeView] Add option to disable inline line tables.

akhuang created this revision. akhuang added a reviewer: rnk. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. This adds a clang option to disable inline line tables. When it is used, the inliner uses the call site as the location of the inlined

[PATCH] D67720: [clangd] Add semantic selection to ClangdLSPServer.

usaxena95 updated this revision to Diff 220703. usaxena95 added a comment. Fixed error message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67720/new/ https://reviews.llvm.org/D67720 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp

[PATCH] D67720: [clangd] Add semantic selection to ClangdLSPServer.

ilya-biryukov added a comment. A drive-by comment... Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1135 + Params.positions.size()); +Reply(llvm::make_error("failed to decode request", + ErrorCode::InvalidRequest));

[PATCH] D67567: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage

gribozavr accepted this revision. gribozavr added a comment. This revision is now accepted and ready to land. FWIW, I like this approach better than the one in Static Analyzer because it warns on the variable declaration -- that's where the root of the issue is, not at the call to

r372237 - [c++20] P1331R2: Allow transient use of uninitialized objects in

Author: rsmith Date: Wed Sep 18 10:37:44 2019 New Revision: 372237 URL: http://llvm.org/viewvc/llvm-project?rev=372237=rev Log: [c++20] P1331R2: Allow transient use of uninitialized objects in constant evaluation. Modified: cfe/trunk/include/clang/AST/DeclCXX.h

[PATCH] D67720: [clangd] Add semantic selection to ClangdLSPServer.

usaxena95 created this revision. usaxena95 added a reviewer: hokein. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This adds semantic selection to the LSP Server. Adds support for serialization of input request and the

[PATCH] D63607: [clang][driver] Add basic --driver-mode=flang support for fortran

richard.barton.arm added a comment. Thanks for the updates. I think this is now looking good and matches the RFC already posted. One thought that occurs to me when reviewing this. I think we will assume that F18 /flang when it lands in the LLVM project will be an

[PATCH] D67718: [clang-format][PR41899] PointerAlignment: Left leads to useless space in lambda intializer expression

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. LG Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67718/new/ https://reviews.llvm.org/D67718 ___ cfe-commits

[PATCH] D67719: [clang] [Basic] Enable __has_feature(leak_sanitizer)

mgorny created this revision. mgorny added reviewers: krytarowski, eugenis, leonardchan, vitalybuka, phosek. Add a 'leak_sanitizer' feature akin to existing '*_sanitizer' features to let programmers switch code paths accounting for leak sanitizers being enabled. https://reviews.llvm.org/D67719

[PATCH] D67718: [clang-format][PR41899] PointerAlignment: Left leads to useless space in lambda intializer expression

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: klimek, owenpan, krasimir, timwoj. MyDeveloperDay added a project: clang-tools-extra. Herald added a project: clang. https://bugs.llvm.org/show_bug.cgi?id=41899 auto lambda = [ = a]() { a = 2; }; is formatted as auto

r372235 - [OPENMP5.0]Allow multiple context selectors in the context selector

Author: abataev Date: Wed Sep 18 09:24:31 2019 New Revision: 372235 URL: http://llvm.org/viewvc/llvm-project?rev=372235=rev Log: [OPENMP5.0]Allow multiple context selectors in the context selector sets. According to OpenMP 5.0, context selector set might include several context selectors,

[libunwind] r372233 - unwind: remove a could of extraneous `else` (NFC)

Author: compnerd Date: Wed Sep 18 09:15:56 2019 New Revision: 372233 URL: http://llvm.org/viewvc/llvm-project?rev=372233=rev Log: unwind: remove a could of extraneous `else` (NFC) Simplify `if return else return` by removing the unnecessary `else`. Modified:

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

khchen marked 3 inline comments as done. khchen added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:1548 +{M.gccSuffix(), + "/../../../../riscv64-unknown-elf/lib" + M.gccSuffix()}); + }); kito-cheng

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

khchen updated this revision to Diff 220687. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67508/new/ https://reviews.llvm.org/D67508 Files: clang/lib/Driver/ToolChains/Gnu.cpp clang/lib/Driver/ToolChains/RISCVToolchain.cpp

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

khchen updated this revision to Diff 220686. khchen marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67508/new/ https://reviews.llvm.org/D67508 Files: clang/lib/Driver/ToolChains/Gnu.cpp clang/lib/Driver/ToolChains/RISCVToolchain.cpp

[PATCH] D62394: [ARM][CMSE] Add CMSE header & builtins

pbarrio added a comment. Hi, CMSE upstreaming is indeed one of our priorities. So yes, we are very interested in your feedback. And no, CMSE upstreaming is not abandoned, just going a bit slow ATM :( but any help reviewing is much appreciated! :) @chill would it make sense to start upstream

[PATCH] D67654: [clang-tidy] Fix a potential infinite loop in readability-isolate-declaration check.

ilya-biryukov marked an inline comment as done. ilya-biryukov added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/LexerUtils.h:38 template SourceLocation findPreviousAnyTokenKind(SourceLocation Start, const

[PATCH] D67714: [OpenCL] Add -Wconversion to fdeclare-opencl-builtins test

svenvh created this revision. svenvh added a reviewer: Anastasia. Herald added subscribers: cfe-commits, kristina, yaxunl. Herald added a reviewer: rengolin. Herald added a project: clang. Add the -Wconversion -Werror options to check no unexpected conversion is done. Patch by Pierre Gondois and

[PATCH] D67713: [OpenCL] Add image query builtin functions

svenvh created this revision. svenvh added a reviewer: Anastasia. Herald added subscribers: cfe-commits, kristina, yaxunl. Herald added a reviewer: rengolin. Herald added a project: clang. Add the image query builtin functions from the OpenCL C specification. Patch by Pierre Gondois and Sven van

[PATCH] D63607: [clang][driver] Add basic --driver-mode=flang support for fortran

peterwaller-arm updated this revision to Diff 220681. peterwaller-arm marked 6 inline comments as done. peterwaller-arm added a comment. - Fixed spurious comma - Fixed incorrect comment and changed comment wrapping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63607/new/

[PATCH] D66795: [Mips] Use appropriate private label prefix based on Mips ABI

mbrkusanin added a comment. In D66795#1650305 , @atanasyan wrote: > But take a look at `LLVMCreateDisasmCPUFeatures` function from > `Disassembler.cpp`. If we cannot retrieve `MCTargetOptions` right in this > function, we will have to change "LLVM-C"

[PATCH] D66795: [Mips] Use appropriate private label prefix based on Mips ABI

mbrkusanin updated this revision to Diff 220675. mbrkusanin added a comment. Herald added subscribers: lldb-commits, cfe-commits, seiya, lenary, rupprecht, jrtc27, hiraditya. Herald added projects: clang, LLDB. - MCTargetOptions is now always passed to MCAsmInfo (or rather createMCAsmInfo). In

[PATCH] D67545: [clang-tidy] Added DefaultOperatorNewCheck.

lebedev.ri marked an inline comment as done. lebedev.ri added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/DefaultOperatorNewCheck.cpp:51 + // The alignment used by default 'operator new' (in bits). + const unsigned DefaultAlignment =

[PATCH] D67661: [RISCV] Headers: Add Bitmanip extension Clang header files and rvintrin.h

lebedev.ri added a comment. In D67661#1673918 , @s.egerton wrote: > Sorry I misread your original comment. (which one?) > These functions exist so that we can guarantee that these particular > instructions will be emitted; Sure, that makes sense. >

[PATCH] D67545: [clang-tidy] Added DefaultOperatorNewCheck.

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/DefaultOperatorNewCheck.cpp:51 + // The alignment used by default 'operator new' (in bits). + const unsigned DefaultAlignment = Context.getTargetInfo().getNewAlign(); + balazske

[PATCH] D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls

lewis-revill updated this revision to Diff 220677. lewis-revill added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Replace internal -mllvm option with target feature enabled through the clang frontend using -msave-restore. Repository: rG LLVM Github

[PATCH] D67661: [RISCV] Headers: Add Bitmanip extension Clang header files and rvintrin.h

lebedev.ri added a comment. In D67661#1673993 , @lebedev.ri wrote: > In D67661#1673918 , @s.egerton wrote: > > > Sorry I misread your original comment. > > > (which one?) > > > These functions exist so that we can

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

serge-sans-paille added a comment. @Meinersbur any feedback on this update? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61446/new/ https://reviews.llvm.org/D61446 ___ cfe-commits mailing list

r372229 - Recommit -r372180

Author: erichkeane Date: Wed Sep 18 08:09:49 2019 New Revision: 372229 URL: http://llvm.org/viewvc/llvm-project?rev=372229=rev Log: Recommit -r372180 Commit message below, original caused the sphinx build bot to fail, this one should fix it. Create UsersManual section entitled 'Controlling

[PATCH] D67409: [RISCV] enable LTO support, pass some options to linker.

khchen updated this revision to Diff 220668. khchen added a comment. Thanks @lenary, I fixed it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67409/new/ https://reviews.llvm.org/D67409 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/lib/Driver/ToolChains/CommonArgs.cpp

[PATCH] D67545: [clang-tidy] Added DefaultOperatorNewCheck.

balazske marked an inline comment as done. balazske added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/DefaultOperatorNewCheck.cpp:51 + // The alignment used by default 'operator new' (in bits). + const unsigned DefaultAlignment =

[PATCH] D67661: [RISCV] Headers: Add Bitmanip extension Clang header files and rvintrin.h

s.egerton added a comment. Sorry I misread your original comment. These functions exist so that we can guarantee that these particular instructions will be emitted; the other option was LLVM IR intrinsics and Clang builtins, this was the other patch (https://reviews.llvm.org/D66479). We are

Re: r372082 - [Clang] Pragma vectorize_width() implies vectorize(enable)

Oopsy daisy! Sorry, and thanks for the revert. I will look into this. From: Hans Wennborg Sent: 18 September 2019 14:41 To: Sjoerd Meijer Cc: cfe-commits Subject: Re: r372082 - [Clang] Pragma vectorize_width() implies vectorize(enable) I've reverted this in

[PATCH] D67706: [clang][checkers] Using CallDescription in StreamChecker.

balazske created this revision. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp. Herald added a project: clang. Recognization of function names is done now with the CallDescription class instead of using IdentifierInfo. This means function name and argument count is compared

Re: r372082 - [Clang] Pragma vectorize_width() implies vectorize(enable)

I've reverted this in r372225 as it broke the Chromium build. It seems it doesn't actually manage to enable vectorization of a simple loop at -Oz, and at -Os it asserts. See details in my commit message. On Tue, Sep 17, 2019 at 10:41 AM Sjoerd Meijer via cfe-commits wrote: > > Author:

r372225 - Revert r372082 "[Clang] Pragma vectorize_width() implies vectorize(enable)"

Author: hans Date: Wed Sep 18 06:41:51 2019 New Revision: 372225 URL: http://llvm.org/viewvc/llvm-project?rev=372225=rev Log: Revert r372082 "[Clang] Pragma vectorize_width() implies vectorize(enable)" This broke the Chromium build. Consider the following code: float ScaleSumSamples_C(const

RE: r372185 - Revert "Create UsersManual section entitled 'Controlling Floating Point"

Ah, sorry- It broke the sphinx build bot, and the author was home for the evening and is going to get to it during the day today. From: Richard Smith Sent: Tuesday, September 17, 2019 8:10 PM To: Keane, Erich Cc: cfe-commits Subject: Re: r372185 - Revert "Create UsersManual section entitled

[PATCH] D67545: [clang-tidy] Added DefaultOperatorNewCheck.

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/DefaultOperatorNewCheck.cpp:51 + // The alignment used by default 'operator new' (in bits). + const unsigned DefaultAlignment = Context.getTargetInfo().getNewAlign(); +

[PATCH] D63607: [clang][driver] Add basic --driver-mode=flang support for fortran

kiranchandramohan added a comment. Some minor comments about Filetypes and file extensions. Can be ignored or considered for a separate commit. Comment at: clang/include/clang/Driver/Driver.h:69 +CLMode, +FlangMode, } Mode; Is the comma by choice?

[PATCH] D67545: [clang-tidy] Added DefaultOperatorNewCheck.

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/DefaultOperatorNewCheck.cpp:51 + // The alignment used by default 'operator new' (in bits). + const unsigned DefaultAlignment = Context.getTargetInfo().getNewAlign(); + martong

  1   2   >