[PATCH] D69122: Add support to find out resource dir and add it as compilation args

2019-11-02 Thread Kousik Kumar via Phabricator via cfe-commits
kousikk updated this revision to Diff 227601. kousikk added a comment. Forgot to run clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69122/new/ https://reviews.llvm.org/D69122 Files: clang/tools/clang-scan-deps/ClangScanDeps.cpp

[PATCH] D69122: Add support to find out resource dir and add it as compilation args

2019-11-02 Thread Kousik Kumar via Phabricator via cfe-commits
kousikk updated this revision to Diff 227600. kousikk marked an inline comment as done. kousikk added a comment. @BigCheese - thanks, all the three points make sense! > An alternative would be to only do FindResourceDir when given an absolute > path to a compiler, instead of trying to guess. I

[PATCH] D69759: [RFC][BPF] Add preserve_access_index attribute to record definition

2019-11-02 Thread Yonghong Song via Phabricator via cfe-commits
yonghong-song added a comment. Discussed with Martin last Friday that it would be easier for CO-RE programming if we can annotate the structure itself. This is the RFC patch. Please let me whether this sounds a reasonable approach. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D69759: [RFC][BPF] Add preserve_access_index attribute to record definition

2019-11-02 Thread Yonghong Song via Phabricator via cfe-commits
yonghong-song created this revision. yonghong-song added reviewers: ast, anakryiko. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. This patch introduced a new bpf specific attribute which can be added to struct or union definition. For example, struct s { ... }

[PATCH] D69756: [opaque pointer types] Add element type argument to IRBuilder CreatePreserveStructAccessIndex and CreatePreserveArrayAccessIndex

2019-11-02 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm accepted this revision. arsenm added a comment. This revision is now accepted and ready to land. Herald added a subscriber: wdng. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69756/new/ https://reviews.llvm.org/D69756

[PATCH] D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default

2019-11-02 Thread Samuel Thibault via Phabricator via cfe-commits
sthibaul created this revision. sthibaul added a reviewer: kristina. Herald added a project: clang. Herald added a subscriber: cfe-commits. Linux' current addLibCxxIncludePaths and addLibStdCxxIncludePaths are actually almost non-Linux-specific at all, and can be reused almost as such for all gcc

[PATCH] D69757: [CodeGenCXX] Don't use new PM with union-tbaa2 test

2019-11-02 Thread Petr Hosek via Phabricator via cfe-commits
phosek abandoned this revision. phosek added a subscriber: MaskRay. phosek added a comment. @MaskRay already landed rGe0b3a8c991569f8c05a4edb551b8cc2942e37ea1 so no longer needed. Repository: rC Clang CHANGES SINCE LAST

[PATCH] D69755: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld)

2019-11-02 Thread Kamil Rytarowski via Phabricator via cfe-commits
krytarowski added a comment. In D69755#1731394 , @MaskRay wrote: > I still have the feeling that such configurations should be added to > clangDriver/gcc specs or a shell script wrapper of lld. OK, as you allow now a shell wrapper of lld, this is a

[PATCH] D69756: [opaque pointer types] Add element type argument to IRBuilder CreatePreserveStructAccessIndex and CreatePreserveArrayAccessIndex

2019-11-02 Thread Craig Topper via Phabricator via cfe-commits
craig.topper created this revision. craig.topper added reviewers: jyknight, t.p.northover. Herald added subscribers: cfe-commits, arphaman. Herald added projects: clang, LLVM. These were the only remaining users of the GetElementPtrInst::getGEPReturnType method that gets the element type from the

[PATCH] D69757: [CodeGenCXX] Don't use new PM with union-tbaa2 test

2019-11-02 Thread Petr Hosek via Phabricator via cfe-commits
phosek created this revision. phosek added reviewers: xbolva00, Carrot, leonardchan. Herald added subscribers: cfe-commits, kosarev. Herald added a project: clang. This test started failing after D68593 landed. Repository: rC Clang

[PATCH] D69755: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld)

2019-11-02 Thread Kamil Rytarowski via Phabricator via cfe-commits
krytarowski marked an inline comment as done. krytarowski added inline comments. Comment at: lld/tools/nb.lld/nb.lld.cpp:94 + + // disable superfluous RUNPATH on NetBSD + args.push_back("--disable-new-dtags"); MaskRay wrote: > You can't use DT_RUNPATH probably

[clang] e0b3a8c - [CodeGenCXX][test] Use -fno-experimental-new-pass-manager for CodeGenCXX/union-tbaa2.cpp after D68593/llvmorg-10-init-8907-gcecc0d27ad5

2019-11-02 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2019-11-02T15:58:54-07:00 New Revision: e0b3a8c991569f8c05a4edb551b8cc2942e37ea1 URL: https://github.com/llvm/llvm-project/commit/e0b3a8c991569f8c05a4edb551b8cc2942e37ea1 DIFF: https://github.com/llvm/llvm-project/commit/e0b3a8c991569f8c05a4edb551b8cc2942e37ea1.diff

[PATCH] D69755: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld)

2019-11-02 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. I still have the feeling that such configurations should be added to clangDriver/gcc specs or a shell script wrapper of lld. How do you decide to handle "Handling of indirect shared library dependencies"? It does not seem to be favored by lld contributors.

[PATCH] D69755: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld)

2019-11-02 Thread Kamil Rytarowski via Phabricator via cfe-commits
krytarowski updated this revision to Diff 227593. krytarowski added a comment. - upload diff with wider context Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69755/new/ https://reviews.llvm.org/D69755 Files: clang/lib/Driver/ToolChain.cpp

[PATCH] D68074: [clang-tidy] Add readability-make-member-function-const

2019-11-02 Thread Matthias Gehre via Phabricator via cfe-commits
mgehre marked 8 inline comments as done. mgehre added a comment. Thanks, fixed! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68074/new/ https://reviews.llvm.org/D68074 ___ cfe-commits mailing list

[PATCH] D69755: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld)

2019-11-02 Thread Kamil Rytarowski via Phabricator via cfe-commits
krytarowski created this revision. krytarowski added reviewers: ruiu, joerg, mgorny, MaskRay. krytarowski added a project: lld. Herald added subscribers: llvm-commits, cfe-commits, fedor.sergeev, aheejin, emaste, dschuff. Herald added projects: clang, LLVM. The NetBSD target wraps the default

[PATCH] D69204: [OpenMP 5.0] - Extend defaultmap

2019-11-02 Thread Chi Chun Chen via Phabricator via cfe-commits
cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7368-7370 + bool IsImplicit, OpenMPDefaultmapClauseModifier ImplicitBehavior = + OMPC_DEFAULTMAP_MODIFIER_default, +

[PATCH] D69754: [hurd] Add --build-id option when enabled

2019-11-02 Thread Samuel Thibault via Phabricator via cfe-commits
sthibaul created this revision. sthibaul added a reviewer: kristina. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D69754 Files: clang/lib/Driver/ToolChains/Hurd.cpp Index: clang/lib/Driver/ToolChains/Hurd.cpp

Re: [PATCH] D55802: Change CGObjC to use objc intrinsics instead of runtime methods

2019-11-02 Thread Alina Sbirlea via cfe-commits
Following up on this, AFAICT this is working as intended on the LLVM side. The different decision is made in GlobalsAA + MemoryDependencyAnalysis. IIUC, the logic there is along the lines of: if I have a global G that's "internal" ("static" in C), and an intrinsic method M, then M cannot read

[clang] d0f3c82 - Fix uninitialized variable warnings. NFCI.

2019-11-02 Thread Simon Pilgrim via cfe-commits
Author: Simon Pilgrim Date: 2019-11-02T18:03:21Z New Revision: d0f3c822160e36e10588bc86dabde6ab8d63cf10 URL: https://github.com/llvm/llvm-project/commit/d0f3c822160e36e10588bc86dabde6ab8d63cf10 DIFF: https://github.com/llvm/llvm-project/commit/d0f3c822160e36e10588bc86dabde6ab8d63cf10.diff

[PATCH] D69752: clang-format: Add a fallback style to Emacs mode

2019-11-02 Thread Mikhail Gusarov via Phabricator via cfe-commits
dottedmag created this revision. dottedmag added a reviewer: djasper. Herald added a project: clang. Herald added a subscriber: cfe-commits. This allows one to enable `clang-format-buffer` on file save and avoid reformatting files that are outside of any project with .clang-format style.

[PATCH] D69498: IR: Invert convergent attribute handling

2019-11-02 Thread Mehdi AMINI via Phabricator via cfe-commits
mehdi_amini added a comment. In D69498#1727650 , @dexonsmith wrote: > In D69498#1723606 , @rjmccall wrote: > > > Perhaps there should be a global metadata, or something in the > > increasingly-misnamed "data

[PATCH] D69750: make -ftime-trace also trace time spent creating debug info

2019-11-02 Thread Luboš Luňák via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG4f2104c5adbc: make -ftime-trace also trace time spent creating debug info (authored by llunak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69750/new/

[PATCH] D69750: make -ftime-trace also trace time spent creating debug info

2019-11-02 Thread Anton Afanasyev via Phabricator via cfe-commits
anton-afanasyev accepted this revision. anton-afanasyev added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69750/new/ https://reviews.llvm.org/D69750

[PATCH] D69750: make -ftime-trace also trace time spent creating debug info

2019-11-02 Thread Luboš Luňák via Phabricator via cfe-commits
llunak created this revision. llunak added a reviewer: anton-afanasyev. llunak added a project: clang. Herald added subscribers: cfe-commits, aprantl. In debug builds a noticeable time can be spent generating debug info, so make -ftime-trace track that too. Repository: rC Clang

[PATCH] D69383: [RISCV] Match GCC `-march`/`-mabi` driver defaults

2019-11-02 Thread Kuan Hsu Chen (Zakk) via Phabricator via cfe-commits
khchen added a comment. LGTM, thanks for the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69383/new/ https://reviews.llvm.org/D69383 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D69585: PerformPendingInstatiations() already in the PCH

2019-11-02 Thread Luboš Luňák via Phabricator via cfe-commits
llunak updated this revision to Diff 227575. llunak added a comment. Let's go a different route. This patch fully passes all tests and so should be ready to be committed. It does so by opting out for OpenMP, which can be handled later whenever somebody who know about OpenMP looks at it.

[PATCH] D68854: [X86] add mayRaiseFPException flag and FPCW registers for X87 instructions

2019-11-02 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon added a comment. @LiuChen3 @craig.topper This has broken EXPENSIVE_CHECKS builds, please can you take a look? http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-ubuntu/builds/184/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

Zorg migration to GitHub/monorepo - Done

2019-11-02 Thread Galina Kistanova via cfe-commits
Hello everyone, Zorg migration to GitHub/monorepo is complete. I have removed the following builders from the production build bot: * clang-atom-d525-fedora-rel - fails to checkout from github * clang-x64-ninja-win7 - fails to checkout from github * polly-amd64-linux - missing git *