[PATCH] D71090: [clangd] Navigation from definition of template specialization to primary template

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:240 +// it's more useful to navigate to the template declaration. +if (Preferred->getLocation() == IdentStartLoc) { + if (auto *CTSD =

[PATCH] D71090: [clangd] Navigation from definition of template specialization to primary template

nridge added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:240 +// it's more useful to navigate to the template declaration. +if (Preferred->getLocation() == IdentStartLoc) { + if (auto *CTSD = dyn_cast(Preferred)) { sammccall

[PATCH] D71090: [clangd] Navigation from definition of template specialization to primary template

nridge updated this revision to Diff 232725. nridge marked 2 inline comments as done. nridge retitled this revision from "[clangd] Navigation from definition of template specialization to primary template Fixes https://github.com/clangd/clangd/issues/212.; to "[clangd] Navigation from

[PATCH] D71090: [clangd] Navigation from definition of template specialization to primary template

This revision was automatically updated to reflect the committed changes. Closed by commit rGe8716a6df7ab: [clangd] Navigation from definition of template specialization to primary… (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] e8716a6 - [clangd] Navigation from definition of template specialization to primary template

Author: Nathan Ridge Date: 2019-12-08T00:40:45-05:00 New Revision: e8716a6df7abad68b6cf81c437a2e0524e88f3ad URL: https://github.com/llvm/llvm-project/commit/e8716a6df7abad68b6cf81c437a2e0524e88f3ad DIFF: https://github.com/llvm/llvm-project/commit/e8716a6df7abad68b6cf81c437a2e0524e88f3ad.diff

[PATCH] D70094: [clang-tidy] new altera ID dependent backward branch check

ffrankies updated this revision to Diff 232724. ffrankies marked 2 inline comments as done. ffrankies added a comment. Addressed @Eugene.Zelenko's comments on use of `auto` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70094/new/ https://reviews.llvm.org/D70094 Files:

[PATCH] D70469: [attributes] [analyzer] Add handle related attributes

xazax.hun updated this revision to Diff 232723. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70469/new/ https://reviews.llvm.org/D70469 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D70469: [attributes] [analyzer] Add handle related attributes

xazax.hun marked 2 inline comments as done. xazax.hun added inline comments. Comment at: clang/test/Sema/attr-handles.cpp:20-21 +void ht(int __attribute__((acquire_handle(1))) *a); // expected-error {{'acquire_handle' attribute takes no arguments}} +int it()

[PATCH] D68362: [libunwind][RISCV] Add 64-bit RISC-V support

mhorne updated this revision to Diff 232721. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68362/new/ https://reviews.llvm.org/D68362 Files: libunwind/include/__libunwind_config.h libunwind/include/libunwind.h libunwind/src/Registers.hpp libunwind/src/UnwindCursor.hpp

[PATCH] D71166: Deprecate the hasDefaultArgument matcher

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a small doc request. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:6555 +/// \endcode +///

[PATCH] D71167: [Driver] Default to -momit-leaf-frame-pointer for AArch64

MaskRay created this revision. MaskRay added reviewers: c-rhodes, efriedma, rengolin, sdesmalen. Herald added subscribers: cfe-commits, kristof.beyls. Herald added a project: clang. This matches https://gcc.gnu.org/onlinedocs/gcc/AArch64-Options.html > -momit-leaf-frame-pointer >

[PATCH] D71166: Deprecate the hasDefaultArgument matcher

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. It doesn't provide a way to match on the contents of the default argumment. Rather than give it that capability, make it deprecated and recomment the

[PATCH] D71018: [ASTImporter] Improved import of TypeSourceInfo (TypeLoc)

a_sidorin added a comment. Finally, this FIXME is addressed. Thanks! Are you going to add any tests in the following patches? It looks almost good to me, but I have a question inline. Comment at: clang/lib/AST/ASTImporter.cpp:7914 + +#define IMPORT_TYPE_LOC(NAME)

[PATCH] D71159: [Attr] Move ParsedTargetAttr out of the TargetAttr class

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71159/new/ https://reviews.llvm.org/D71159 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] 6dcb100 - Optionally exclude bitfield definitions from magic numbers check

Author: Florin Iucha Date: 2019-12-07T12:33:10-05:00 New Revision: 6dcb1003f2022cba36e9f5a6d39648c3a3a213a0 URL: https://github.com/llvm/llvm-project/commit/6dcb1003f2022cba36e9f5a6d39648c3a3a213a0 DIFF: https://github.com/llvm/llvm-project/commit/6dcb1003f2022cba36e9f5a6d39648c3a3a213a0.diff

[PATCH] D71020: [ASTImporter] Friend class decl should not be visible in its context

a_sidorin added a comment. Hi Gabor, This patch looks mostly good to me. Thanks! Comment at: clang/lib/AST/ASTImporter.cpp:334 + FromDC->lookup(FromNamed->getDeclName()); + if (std::find(FromLookup.begin(), FromLookup.end(), FromNamed) != +

[PATCH] D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls

lewis-revill updated this revision to Diff 232702. lewis-revill added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62686/new/ https://reviews.llvm.org/D62686 Files: clang/lib/Driver/ToolChains/Arch/RISCV.cpp

[PATCH] D71159: [Attr] Move ParsedTargetAttr out of the TargetAttr class

rnk accepted this revision. rnk added a comment. Lg CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71159/new/ https://reviews.llvm.org/D71159 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D70469: [attributes] [analyzer] Add handle related attributes

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:7424 + ParsedAttr ) { + if (CurType->isFunctionType()) { +State.getSema().Diag(Attr.getLoc(), diag::warn_type_attribute_wrong_type) Is this correct, or

[PATCH] D71142: [Sema] Validate large bitfields

aaron.ballman added a comment. In D71142#1773933 , @Mordante wrote: > I'll have a look whether I can find a sane maximum width for a bit-field. The limits according to C are the size of the field's declared type (C17 6.7.2.1p4), but it seems that C++

[PATCH] D71141: [Wdocumentation] Use C2x/C++14 deprecated attribute

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/lib/AST/CommentSema.cpp:693 +StringRef AttributeSpelling = +CPlusPlus14 ? "[[deprecated]]" : "__attribute__((deprecated))";

[PATCH] D71154: Driver: Don't look for libc++ headers in the install directory on Android.

davezarzycki added a comment. Can we revert this? It doesn't seem to work on my Fedora 31 box: FAIL: Clang :: Driver/android-no-installed-libcxx.cpp (9249 of 59761) TEST 'Clang :: Driver/android-no-installed-libcxx.cpp' FAILED Script: -- :

[PATCH] D70819: [ASTImporter] Support functions with placeholder return types ...

martong added a reviewer: teemperor. martong marked an inline comment as done. martong added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:5625 + // parsed libcxx/src/filesystem/directory_iterator.cpp, but could not reduce + // that with creduce, because

[PATCH] D70819: [ASTImporter] Support functions with placeholder return types ...

a_sidorin accepted this revision. a_sidorin added a comment. This revision is now accepted and ready to land. LGTM, thanks! Let's wait for Shafik's comments before committing this. Comment at: clang/lib/AST/ASTImporter.cpp:48 #include "clang/Basic/Builtins.h" +#include

[PATCH] D71134: [OpenMP] Require trivially copyable type for mapping

This revision was automatically updated to reflect the committed changes. Hahnfeld marked an inline comment as done. Closed by commit rG071dca24cea9: [OpenMP] Require trivially copyable type for mapping (authored by Hahnfeld). Changed prior to commit:

[PATCH] D71141: [Wdocumentation] Use C2x/C++14 deprecated attribute

Mordante updated this revision to Diff 232695. Mordante retitled this revision from "[Wdocumentation] Use C++14 deprecated attribute" to "[Wdocumentation] Use C2x/C++14 deprecated attribute". Mordante edited the summary of this revision. Mordante added a comment. Added C2x support as requested.

[PATCH] D71141: [Wdocumentation] Use C++14 deprecated attribute

Mordante marked 3 inline comments as done. Mordante added inline comments. Comment at: clang/lib/AST/CommentSema.cpp:693 +StringRef AttributeSpelling = +CPlusPlus14 ? "[[deprecated]]" : "__attribute__((deprecated))"; if (PP) { Mordante wrote: >

[PATCH] D71142: [Sema] Validate large bitfields

Mordante marked 3 inline comments as done. Mordante added a comment. I'll have a look whether I can find a sane maximum width for a bit-field. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71142/new/ https://reviews.llvm.org/D71142

[PATCH] D70157: Align branches within 32-Byte boundary

annita.zhang added a comment. In D70157#1760278 , @jyknight wrote: > > Branch alignment > > --- > > The primary goal of this patch, restricting the placement of branch > instructions, is a performance optimization. Similar to loop alignment, the

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

serge-sans-paille updated this revision to Diff 232690. serge-sans-paille added a comment. @Meinersbur : with this version, validation passes using static build on three platforms, with the following config: -DLLVM_ENABLE_PROJECTS='polly;clang' -DPOLLY_ENABLE_GPGPU_CODEGEN=ON