[PATCH] D76525: Expose cache line size in __builtin_get_cpu_cache_line_size

craig.topper added a comment. In D76525#1942825 , @zoecarver wrote: > @craig.topper I'm not sure what should happen. It should probably just use > that CPU (although that's not a great solution). Is there a way to detect if > an attribute was used to cha

[PATCH] D76818: [clang-tidy] Add check llvmlibc-implementation-in-namespace.

sivachandra added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/llvmlibc-implementation-in-namespace.cpp:30 +// Wrapped in correct namespace. +namespace __llvm_libc { +class ClassB; For completeness, can you include a nested namespace a

[PATCH] D76818: [clang-tidy] Add check llvmlibc-implementation-in-namespace.

Eugene.Zelenko added a comment. Please also add isLanguageVersionSupported(), because namespaces make sense only in C++. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76818/new/ https://reviews.llvm.org/D76818 __

[PATCH] D73307: Unique Names for Functions with Internal Linkage

tmsriram added a comment. In D73307#1942805 , @MaskRay wrote: > In D73307#1932131 , @rnk wrote: > > > At a higher level, should this just be an IR pass that clang adds into the > > pipeline when the flag is set? It

[clang] d264f02 - Fix `-Wreturn-type` warning. NFC.

Author: Michael Liao Date: 2020-03-26T00:53:24-04:00 New Revision: d264f02c6f502960e2bcdd332f250efc702d09f2 URL: https://github.com/llvm/llvm-project/commit/d264f02c6f502960e2bcdd332f250efc702d09f2 DIFF: https://github.com/llvm/llvm-project/commit/d264f02c6f502960e2bcdd332f250efc702d09f2.diff

[PATCH] D76525: Expose cache line size in __builtin_get_cpu_cache_line_size

zoecarver updated this revision to Diff 252742. zoecarver added a comment. - Diff from master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76525/new/ https://reviews.llvm.org/D76525 Files: clang/include/clang/Basic/Builtins.def clang/lib/AST/

[PATCH] D76525: Expose cache line size in __builtin_get_cpu_cache_line_size

zoecarver updated this revision to Diff 252741. zoecarver added a comment. - Fix based on review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76525/new/ https://reviews.llvm.org/D76525 Files: clang/include/clang/Basic/Builtins.def cl

[PATCH] D76525: Expose cache line size in __builtin_get_cpu_cache_line_size

zoecarver added a comment. @craig.topper I'm not sure what should happen. It should probably just use that CPU (although that's not a great solution). Is there a way to detect if an attribute was used to change the target in which case we could error? What do you think should happen? Reposito

[PATCH] D73307: Unique Names for Functions with Internal Linkage

MaskRay added a comment. In D73307#1932131 , @rnk wrote: > At a higher level, should this just be an IR pass that clang adds into the > pipeline when the flag is set? It should be safe to rename internal functions > and give private functions internal li

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 252738. oontvoo added a comment. ... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/include/clang/Lex/HeaderSearch.h clang/include/clang/Lex/Preproces

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 252735. oontvoo added a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/include/clang/Lex/HeaderSearch.h clang/include/clang/Lex/Preprocessor

[PATCH] D74144: [OPENMP50]Add basic support for array-shaping operation.

rjmccall added a comment. Okay, if you think that suppress array decay is the right behavior here, that's fine with me. Please check the behavior of other OpenMP implementations, though. Comment at: clang/lib/Sema/SemaExpr.cpp:4848 + Expr::EvalResult EvResult; + if

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MarcusJohnson91 updated this revision to Diff 252730. MarcusJohnson91 added a comment. Implemented the suggestion to break the test strings down into smaller pieces CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75791/new/ https://reviews.llvm.org/D75791 Files: clang/docs/ReleaseNotes

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 252728. oontvoo added a comment. Typo - missing ! operator Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/include/clang/Lex/HeaderSearch.h clang/inclu

[PATCH] D76653: [clang] Allow -DDEFAULT_SYSROOT to be a relative path

sbc100 added a comment. Hmm.. `arc diff` was behaving strangely for me and failed to update this PR as I expected. Should fixed now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76653/new/ https://reviews.llvm.org/D76653 _

[PATCH] D76653: [clang] Allow -DDEFAULT_SYSROOT to be a relative path

sbc100 updated this revision to Diff 252725. sbc100 added a comment. squash Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76653/new/ https://reviews.llvm.org/D76653 Files: clang/CMakeLists.txt clang/lib/Driver/Driver.cpp Index: clang/lib/Dri

[PATCH] D76653: [clang] Allow -DDEFAULT_SYSROOT to be a relative path

sbc100 updated this revision to Diff 252724. sbc100 added a comment. feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76653/new/ https://reviews.llvm.org/D76653 Files: clang/lib/Driver/Driver.cpp Index: clang/lib/Driver/Driver.cpp ==

[PATCH] D76744: [clang-tidy] Add check to ensure llvm-libc implementations are defined in correct namespace.

PaulkaToast marked 3 inline comments as done. PaulkaToast added inline comments. Comment at: clang-tools-extra/clang-tidy/llvmlibc/EntrypointNamespaceCheck.cpp:67 + if (Result.SourceManager->getFilename(MatchedDecl->getLocation()) + .endswith(".h")) +return; --

[PATCH] D76717: feedback

sbc100 updated this revision to Diff 252723. sbc100 added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76717/new/ https://reviews.llvm.org/D76717 Files: clang/lib/Driver/Driver.cpp Index: clang/lib/Driver/Driver.cpp

[PATCH] D76744: [clang-tidy] Add check to ensure llvm-libc implementations are defined in correct namespace.

PaulkaToast abandoned this revision. PaulkaToast added a comment. Abandoning for a more generalized check. D76818 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76744/new/ https://reviews.llvm.org/D76744 ___

Buildbot numbers for the week of 03/15/2020 - 03/21/2020

Hello everyone, Below are some buildbot numbers for the last week of 03/15/2020 - 03/21/2020. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from gre

Buildbot numbers for the week of 03/8/2020 - 03/14/2020

Hello everyone, Below are some buildbot numbers for the week of 03/8/2020 - 03/14/2020. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed to

Buildbot numbers for the week of 03/1/2020 - 03/7/2020

Hello everyone, Below are some buildbot numbers for the week of 03/1/2020 - 03/7/2020. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed to r

[PATCH] D76818: [clang-tidy] Add check llvmlibc-implementation-in-namespace.

PaulkaToast created this revision. PaulkaToast added reviewers: alexfh, aaron.ballman, hokein, njames93. PaulkaToast added a project: clang-tools-extra. Herald added subscribers: cfe-commits, MaskRay, xazax.hun, mgorny. Herald added a project: clang. This check makes sure all llvm-libc implementat

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MarcusJohnson91 marked 2 inline comments as done. MarcusJohnson91 added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:2497 Style); } MyDeveloperDay wrote: > my assumption is this test is using `Style.IndentExternBlock =fals

[PATCH] D59321: WIP: AMDGPU: Teach toolchain to link rocm device libs

arsenm updated this revision to Diff 252715. arsenm added a comment. Herald added a subscriber: hiraditya. Handle wave64 library CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59321/new/ https://reviews.llvm.org/D59321 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/

[PATCH] D59321: WIP: AMDGPU: Teach toolchain to link rocm device libs

arsenm updated this revision to Diff 252708. arsenm added a comment. Cleanup a bit. This should eventually merge with the HIP library handling when it switches to using clang cc1 instead of llc CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59321/new/ https://reviews.llvm.org/D59321 Fi

[PATCH] D76812: [X86] Add Indirect Thunk Support to X86 to mitigate Load Value Injection (LVI) [3/3]

sconstab created this revision. sconstab added reviewers: craig.topper, andrew.w.kaylor, zbrid, chandlerc. Herald added subscribers: jfb, hiraditya. sconstab added a parent revision: D76811: [X86] Refactor X86IndirectThunks.cpp to Accomodate Mitigations other than Retpoline [2/3]. sconstab retitle

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

lanza updated this revision to Diff 252706. lanza added a comment. Rename and address some issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75574/new/ https://reviews.llvm.org/D75574 Files: clang/include/clang/AST/DeclObjC.h clang/include/

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

lanza updated this revision to Diff 252707. lanza added a comment. Reword commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75574/new/ https://reviews.llvm.org/D75574 Files: clang/include/clang/AST/DeclObjC.h clang/include/clang/Basic/Attr.

[clang-tools-extra] c2d7a1f - [clangd] Add test for FindTarget+RecoveryExpr (which already works). NFC

Author: Sam McCall Date: 2020-03-26T00:40:29+01:00 New Revision: c2d7a1f79cedfc9fcb518596aa839da4de0adb69 URL: https://github.com/llvm/llvm-project/commit/c2d7a1f79cedfc9fcb518596aa839da4de0adb69 DIFF: https://github.com/llvm/llvm-project/commit/c2d7a1f79cedfc9fcb518596aa839da4de0adb69.diff LO

[PATCH] D69585: PerformPendingInstatiations() already in the PCH

rsmith added a comment. This needs to be done behind a flag. It's an explicit design goal that compilation behavior using a PCH or precompiled preamble behaves identically to compilation not using a PCH / precompiled preamble. The behavior of this patch is also non-conforming: we're only allowe

[PATCH] D74144: [OPENMP50]Add basic support for array-shaping operation.

ABataev updated this revision to Diff 252700. ABataev added a comment. Rebase + fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74144/new/ https://reviews.llvm.org/D74144 Files: clang/include/clang-c/Index.h clang/include/clang/AST/ASTCon

[clang-tools-extra] 43c6334 - [clangd] Work around gcc bug after 8f237f9b0

Author: Sam McCall Date: 2020-03-26T00:06:54+01:00 New Revision: 43c63349f55d89e335108692aa0970a4602f4385 URL: https://github.com/llvm/llvm-project/commit/43c63349f55d89e335108692aa0970a4602f4385 DIFF: https://github.com/llvm/llvm-project/commit/43c63349f55d89e335108692aa0970a4602f4385.diff LO

[PATCH] D73369: [clangd] Simplify "preferred" vs "definition" logic a bit in XRefs AST code.

sammccall updated this revision to Diff 252690. sammccall added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73369/new/ https://reviews.llvm.org/D73369 Files: clang-tools-extra/clangd/XRefs.cpp clang-tools-extra/clangd

[PATCH] D59321: WIP: AMDGPU: Teach toolchain to link rocm device libs

arsenm updated this revision to Diff 252692. arsenm added a comment. Use -nogpulib instead of -nodefaultlibs CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59321/new/ https://reviews.llvm.org/D59321 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/include/clang/Driver

[PATCH] D73307: Unique Names for Functions with Internal Linkage

tmsriram updated this revision to Diff 252688. tmsriram marked 4 inline comments as done. tmsriram added a comment. Changes to description of flag, remove redundant check. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73307/new/ https://reviews.llvm.org/D73307 Files: clang/docs/Users

[PATCH] D73369: [clangd] Simplify "preferred" vs "definition" logic a bit in XRefs AST code.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:257 const NamedDecl *Def = getDefinition(D); -const NamedDecl *Preferred = Def ? Def : D; +if (const NamedDecl *C = llvm::dyn_cast(D->getCanonicalDecl())) + D = C; k

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

Meinersbur added a comment. In D76342#1941591 , @JonChesterfield wrote: > edit: actually you've already done the clang-format on trunk as I hoped, > phabricator mislead me. Apologies for the noise The previous diff was against a branch with only the wh

[PATCH] D73369: [clangd] Simplify "preferred" vs "definition" logic a bit in XRefs AST code.

sammccall updated this revision to Diff 252689. sammccall marked 3 inline comments as done. sammccall added a comment. address comments, rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73369/new/ https://reviews.llvm.org/D73369 Files: clang

[PATCH] D75153: [ThinLTO] Allow usage of all SMT threads in the system

aganea marked 3 inline comments as done. aganea added a subscriber: respindola. aganea added a comment. In D75153#1906580 , @MaskRay wrote: > Does `taskset -c 0-3 lld -flavor ...` restrict the number of cores? > > cpu_set_t cpu; > sched_getaffinity(0,

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 252685. oontvoo added a comment. Handle the case where the file is first seen Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/include/clang/Lex/HeaderSea

[PATCH] D73649: [CodeComplete] Member completion for concept-constrained types.

sammccall added a comment. @kadircet I realized this change was gathering dust, and you've touched SemaCodeComplete in recent memory... any interest? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73649/new/ https://reviews.llvm.org/D73649 _

[PATCH] D76663: [clangd] Support new semanticTokens request from LSP 3.16.

sammccall added a comment. For some context here, I was doing some digging as Heyward Fann is looking at hooking up our existing syntax highlighting to coc.nvim, and he and Jack Guo (of jackguo380/vim-lsp-cxx-highlight) were asking about the protocol. The new LSP protocol looks really solid, in

[PATCH] D76795: [HIP] Change default --gpu-max-threads-per-block value to 1024

b-sumner added a comment. Thanks. This looks fine to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76795/new/ https://reviews.llvm.org/D76795 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[PATCH] D76801: [AST] Print a> without extra spaces in C++11 or later.

sammccall updated this revision to Diff 252671. sammccall added a comment. update/move comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76801/new/ https://reviews.llvm.org/D76801 Files: clang-tools-extra/clangd/unittests/HoverTests.cpp cl

[PATCH] D76663: [clangd] Support new semanticTokens request from LSP 3.16.

sammccall updated this revision to Diff 252676. sammccall added a comment. Update SemanticHighlighting comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76663/new/ https://reviews.llvm.org/D76663 Files: clang-tools-extra/clangd/ClangdLSPServ

[PATCH] D76801: [AST] Print a> without extra spaces in C++11 or later.

sammccall added a comment. @kadircet sending this to you as I noticed it as a clangd hover bug :-) The highest impact is probably in diagnostic messages though. AFAICT the state before this patch is: - the type printer always printed the space - the stmt printer calls into the type printer to p

[PATCH] D75661: Remove SequentialType from the type heirarchy.

ctetreau added inline comments. Comment at: mlir/lib/Target/LLVMIR/ModuleTranslation.cpp:81 static llvm::Type *getInnermostElementType(llvm::Type *type) { - while (isa(type)) -type = type->getSequentialElementType(); - return type; + do { +if (auto *arrayTy = dyn_cast

[PATCH] D74144: [OPENMP50]Add basic support for array-shaping operation.

rjmccall added a comment. > We cannot build an array type since this expression does not represent a > supported array type. Sizes may be non-constant anywhere in the operation, > variable array type does not support it. I don't think that's true; the element type of a C99 VAT can still be anot

[PATCH] D76795: [HIP] Change default --gpu-max-threads-per-block value to 1024

yaxunl updated this revision to Diff 252661. yaxunl added a comment. change variable names CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76795/new/ https://reviews.llvm.org/D76795 Files: clang/include/clang/Basic/LangOptions.def clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen

[PATCH] D76801: [AST] Print a> without extra spaces in C++11 or later.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous. Herald added a project: clang. It's not 1998 anymore. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D76801 Files: clang-tools-extra/cla

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo added a comment. @jyknight Actually, please hold on on the review ... still working on it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 ___ cfe-commi

[PATCH] D76795: [HIP] Change default --gpu-max-threads-per-block value to 1024

yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:8123 +// --gpu-max-threads-per-block=n or its default value for HIP. +const unsigned OpenCLMaxWorkGroupSize = 256; +const unsigned MaxWorkGroupSize = --

[PATCH] D74144: [OPENMP50]Add basic support for array-shaping operation.

ABataev marked 4 inline comments as done. ABataev added a comment. In D74144#1941971 , @rjmccall wrote: > Okay, so these array-shaping expressions are only allowed as operands to > specific OpenMP directives? That's a plausible interpretation of "The >

[PATCH] D74144: [OPENMP50]Add basic support for array-shaping operation.

ABataev marked an inline comment as done. ABataev added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:4751 + LParenLoc, RParenLoc, Dims, Brackets); + if (!BaseTy->isAnyPointerType()) +return ExprError(Diag(Base->getExprLoc(),

[PATCH] D75661: Remove SequentialType from the type heirarchy.

efriedma updated this revision to Diff 252659. efriedma added a comment. Herald added subscribers: Joonsoo, liufengdb, lucyrfox, mgester, arpith-jacob, csigg, nicolasvasilache, antiagainst, shauheen, burmako, jpienaar, rriddle, mehdi_amini. Fix bug in GlobalOpt. Add fixes for MLIR. Repository

[PATCH] D71687: Fix full loop unrolling initialization in new pass manager

vitalybuka accepted this revision. vitalybuka added a comment. Can this be landed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71687/new/ https://reviews.llvm.org/D71687 ___ cfe-commits mailing list

[PATCH] D75638: [Hexagon] Support for Linux/Musl ABI.

kparzysz added a comment. I'm not sure if it's worth defining these macros especially if this is the only place where they are used. We'd need a more coordinated effort to replace all 32's with named constants where it refers to a register size, and I'm not even sure if we could classify wheth

[PATCH] D70411: [analyzer] CERT: STR31-C

Charusso marked 6 inline comments as done. Charusso added a comment. "To prevent such errors, either limit copies through truncation or, preferably, ensure that the destination is of sufficient size to hold the character data" - from the rule's page. Most of the projects are fine truncating by h

[PATCH] D76795: [HIP] Change default --gpu-max-threads-per-block value to 1024

b-sumner added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:8123 +// --gpu-max-threads-per-block=n or its default value for HIP. +const unsigned OpenCLMaxWorkGroupSize = 256; +const unsigned MaxWorkGroupSize = I'd like to see the word

[PATCH] D75685: Add MS Mangling for OpenCL Pipe types, add mangling test.

erichkeane marked 3 inline comments as done. erichkeane added a comment. Both done here: fe5c719eaf572e23b700e75832ec37a3761b337b . Thanks for the review @Anastasia Comment at: clang/test/CodeGenOpenCL/pip

[PATCH] D76761: [clang-tidy] Fix crash in readability-redundant-string-cstr

njames93 updated this revision to Diff 252646. njames93 added a comment. - Fixed by replacing cumbersome code with the arguably proper solution Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76761/new/ https://reviews.llvm.org/D76761 Files: clang

[PATCH] D75661: Remove SequentialType from the type heirarchy.

efriedma updated this revision to Diff 252645. efriedma added a comment. Address lint comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75661/new/ https://reviews.llvm.org/D75661 Files: clang/lib/CodeGen/CGExprConstant.cpp llvm/include/ll

[PATCH] D76761: [clang-tidy] Fix crash in readability-redundant-string-cstr

njames93 added a comment. In D76761#1941476 , @gribozavr2 wrote: > Right -- what I meant is a more detailed description of why, for example, > `tryGetCallExprAncestorForCxxConstructExpr` can't find the `CallExpr` in this > case -- is it not there, or doe

[PATCH] D75638: [Hexagon] Support for Linux/Musl ABI.

bcain added a comment. In D75638#1917565 , @bcain wrote: > @kparzysz do you have any thoughts about those review comments? @sidneym is this just pulling existing contents downstream to go upstream? If so let's expedite this please Repository: rG LL

[PATCH] D76572: Replace `T(x)` with `reinterpret_cast(x)` everywhere it means reinterpret_cast. No functional change

Quuxplusone marked 2 inline comments as done. Quuxplusone added a comment. Btw, @jhenderson and @rsmith, if you wanted to land your own files' pieces of this patch while waiting on whoever-it-is to approve the pieces in other files, that'd be cool. As I mentioned initially, I don't have the acce

[clang] fe5c719 - Implement post-commit comments for D75685/rG86e0a6c60627

Author: Erich Keane Date: 2020-03-25T12:24:56-07:00 New Revision: fe5c719eaf572e23b700e75832ec37a3761b337b URL: https://github.com/llvm/llvm-project/commit/fe5c719eaf572e23b700e75832ec37a3761b337b DIFF: https://github.com/llvm/llvm-project/commit/fe5c719eaf572e23b700e75832ec37a3761b337b.diff L

[clang] df48e39 - [Clang] Fix clang-tidy errors.

Author: Alexander Belyaev Date: 2020-03-25T20:13:43+01:00 New Revision: df48e3920a56b128ad691c258372c641b076f21c URL: https://github.com/llvm/llvm-project/commit/df48e3920a56b128ad691c258372c641b076f21c DIFF: https://github.com/llvm/llvm-project/commit/df48e3920a56b128ad691c258372c641b076f21c.d

[PATCH] D76795: [HIP] Change default --gpu-max-threads-per-block value to 1024

yaxunl created this revision. yaxunl added reviewers: b-sumner, tra. Herald added subscribers: kerbowa, nhaehnle, jvesely. This better matches CUDA behavior. https://reviews.llvm.org/D76795 Files: clang/include/clang/Basic/LangOptions.def clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGe

[PATCH] D75779: [OpenMP] `omp begin/end declare variant` - part 2, sema (+"CG")

hfinkel added inline comments. Comment at: clang/lib/AST/DeclarationName.cpp:147 +Name = Name.split(getOpenMPVariantManglingSeparatorStr()).first; + OS << Name; +} Would it make sense to print " (omp variant)" after the name to disambiguate? Re

[PATCH] D74144: [OPENMP50]Add basic support for array-shaping operation.

rjmccall added a comment. Okay, so these array-shaping expressions are only allowed as operands to specific OpenMP directives? That's a plausible interpretation of "The shape-operator can appear only in clauses where it is explicitly allowed" from the spec

[PATCH] D76724: Prevent immediate evaluations inside of decltype

Tyker added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:15389 if (!E.isUsable() || !Decl || !Decl->isConsteval() || isConstantEvaluated() || - RebuildingImmediateInvocation) + isInDeclType(*this) || RebuildingImmediateInvocation) return E;

[PATCH] D75779: [OpenMP] `omp begin/end declare variant` - part 2, sema (+"CG")

jdoerfert added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:5396 + IdentifierInfo &VariangtII = Context.Idents.get( + (D.getIdentifier()->getName() + "." + DVScope.NameSuffix).str()); + D.SetIdentifier(&VariangtII, D.getBeginLoc()); hfinkel

[PATCH] D76691: [AST][SVE] Treat built-in SVE types as trivially copyable

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76691/new/ https://reviews.llvm.org/D76691 ___

[PATCH] D76690: [AST][SVE] Treat built-in SVE types as POD

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. Okay, then LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76690/new/ https://reviews.llvm.org/D76690

[PATCH] D76692: [AST][SVE] Treat built-in SVE types as trivial

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76692/new/ https://reviews.llvm.org/D76692 __

[PATCH] D72773: [Matrix] Add __builtin_matrix_{add,sub} to Clang (WIP).

fhahn abandoned this revision. fhahn added a comment. superseded by D76793 using operators. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72773/new/ https://reviews.llvm.org/D72773 __

[PATCH] D72772: [Matrix] Add __builtin_matrix_extract to Clang (WIP).

fhahn abandoned this revision. fhahn added a comment. superseded by D76791 using operators. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72772/new/ https://reviews.llvm.org/D72772 __

[PATCH] D72774: [Matrix] Add __builtin_matrix_multiply to Clang (WIP).

fhahn added a comment. Superseded by D76794 using operators. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72774/new/ https://reviews.llvm.org/D72774 ___ cfe-commits m

[PATCH] D72785: [Matrix] Add __builtin_matrix_scalar_multiply to Clang (WIP).

fhahn abandoned this revision. fhahn added a comment. Superseded by D76794 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72785/new/ https://reviews.llvm.org/D72785 ___

[PATCH] D76794: [Matrix] Implement * binary operator for MatrixType.

fhahn created this revision. fhahn added reviewers: rjmccall, anemet, Bigcheese, rsmith, martong. Herald added subscribers: tschuett, dexonsmith, rnkovacs. Herald added a project: clang. This patch implements the * binary operator for values of MatrixType. It adds support for matrix * matrix, scal

[PATCH] D76793: [Matrix] Implement + and - operators for MatrixType.

fhahn created this revision. fhahn added reviewers: rjmccall, anemet, Bigcheese, rsmith, martong. Herald added subscribers: tschuett, dexonsmith, rnkovacs. Herald added a project: clang. This patch implements the + and - binary operators for values of MatrixType. It adds support for matrix +/- mat

[PATCH] D72283: [Matrix] Add __builtin_matrix_insert to Clang (WIP).

fhahn abandoned this revision. fhahn added a comment. superseded by D76791 using operators. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72283/new/ https://reviews.llvm.org/D72283 __

[PATCH] D76725: [clangd] Build ASTs only with fresh preambles or after building a new preamble

kadircet added a comment. In D76725#1940282 , @sammccall wrote: > So I think we need a careful description of the new model somewhere. Not so > much on specific changes/constraints parts of the code operate under, but > what it's trying to do. > > My bes

[PATCH] D72281: [Matrix] Add matrix type to Clang.

fhahn updated this revision to Diff 252634. fhahn edited the summary of this revision. fhahn added a comment. Include columns in structural equi check, fixed type printing todo & rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72281/new/ http

[PATCH] D76791: [Matrix] Implement matrix index expressions ([][]).

fhahn created this revision. fhahn added reviewers: rjmccall, anemet, Bigcheese, rsmith, martong. Herald added subscribers: tschuett, arphaman, dexonsmith, rnkovacs. Herald added a project: clang. This patch implements matrix index expressions (matrix[RowIdx][ColumnIdx]). It does so by utilizing

[PATCH] D76725: [clangd] Build ASTs only with fresh preambles or after building a new preamble

kadircet updated this revision to Diff 252633. kadircet added a comment. - Build golden asts in ASTWorker thread, rather than preamble thread. - Explain new model in file comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76725/new/ https://re

[PATCH] D72281: [Matrix] Add matrix type to Clang.

fhahn added a reviewer: rjmccall. fhahn marked 2 inline comments as done. fhahn added inline comments. Comment at: clang/lib/AST/ASTStructuralEquivalence.cpp:647 + return false; +if (Mat1->getNumRows() != Mat2->getNumRows()) + return false; martong

[clang] 044c51d - Fix vector type scalar checking when the scalar operand is dependent

Author: Erich Keane Date: 2020-03-25T11:38:58-07:00 New Revision: 044c51d8d433da885438fcb141b15c80d7b62eda URL: https://github.com/llvm/llvm-project/commit/044c51d8d433da885438fcb141b15c80d7b62eda DIFF: https://github.com/llvm/llvm-project/commit/044c51d8d433da885438fcb141b15c80d7b62eda.diff L

[PATCH] D73898: [analyzer] StdLibraryFunctionsChecker: Add argument constraints

martong added a comment. I just created a quick fix for the issue: https://reviews.llvm.org/D76790 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73898/new/ https://reviews.llvm.org/D73898 ___ cfe-commi

[PATCH] D73898: [analyzer] StdLibraryFunctionsChecker: Add argument constraints

martong marked an inline comment as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:409 - Optional FoundSummary = findFunctionSummary(FD, CE, C); + for (const ValueConstraintPtr& VC : Summary.ArgConstraints) {

[PATCH] D76790: [analyzer] StdLibraryFunctionsChecker: fix bug with arg constraints

martong created this revision. martong added reviewers: NoQ, Szelethus, baloghadamsoftware. Herald added subscribers: cfe-commits, ASDenysPetrov, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun, whisperity. Herald added a project: clang.

[PATCH] D76790: [analyzer] StdLibraryFunctionsChecker: fix bug with arg constraints

martong added a comment. I was thinking about the below test, but then I reverted back because I don't want to add "fake" summaries for testing purposes. Perhaps adding a new checker option could enable these "fake" summaries, @Szelethus what's your opinion? diff --git a/clang/lib/StaticAnaly

[PATCH] D59321: WIP: AMDGPU: Teach toolchain to link rocm device libs

arsenm updated this revision to Diff 252630. arsenm added a comment. Herald added a subscriber: kerbowa. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59321/new/ https://reviews.llvm.org/D59321 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/include/clang/Dri

[PATCH] D73307: Unique Names for Functions with Internal Linkage

davidxl added inline comments. Comment at: clang/docs/UsersManual.rst:1683 + Controls whether Clang emits a unique (best-effort) symbol name for internal + linkage symbols. The unique name is obtained by appending the MD5 hash of the + full module name to the original symb

[PATCH] D73720: [Analyzer] Use note tags to track container begin and and changes

NoQ accepted this revision. NoQ added a comment. Lovely, thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73720/new/ https://reviews.llvm.org/D73720 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[clang] c46a0c0 - [clang codegen] Address review comment on comment in constWithPadding.

Author: Eli Friedman Date: 2020-03-25T10:58:03-07:00 New Revision: c46a0c07a634d85d3fed2ef94747ea19fb4d2d69 URL: https://github.com/llvm/llvm-project/commit/c46a0c07a634d85d3fed2ef94747ea19fb4d2d69 DIFF: https://github.com/llvm/llvm-project/commit/c46a0c07a634d85d3fed2ef94747ea19fb4d2d69.diff

[clang] d788814 - Suppress a few -Wunreachable-code warnings.

Author: Nico Weber Date: 2020-03-25T13:55:42-04:00 New Revision: d7888149aa813fb543d562d0891739b1f85f5622 URL: https://github.com/llvm/llvm-project/commit/d7888149aa813fb543d562d0891739b1f85f5622 DIFF: https://github.com/llvm/llvm-project/commit/d7888149aa813fb543d562d0891739b1f85f5622.diff LO

[PATCH] D74183: [IRGen] Add an alignment attribute to underaligned sret parameters

efriedma added a comment. If it's just tramp3d-v4, I'm not that concerned... but that's a weird result. On x86 in particular, alignment markings have almost no effect on optimization, generally. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74183

  1   2   >