[PATCH] D78085: [AST] Fix recovery-expr crash on invalid aligned attr.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: clang. crash stack: lang: tools/clang/include/clang/AST/AttrImpl.inc:1490: unsigned int clang::AlignedAttr::getAlignment(clang::ASTContext &) const: Assertion `!isAlignmentDependent()' failed. PLEASE s

[clang] 37ac1c1 - [Analyzer][VLASize] Support multi-dimensional arrays.

Author: Balázs Kéri Date: 2020-04-14T10:26:51+02:00 New Revision: 37ac1c19bed7b7d22e9312dfa61e7a4506ed4e49 URL: https://github.com/llvm/llvm-project/commit/37ac1c19bed7b7d22e9312dfa61e7a4506ed4e49 DIFF: https://github.com/llvm/llvm-project/commit/37ac1c19bed7b7d22e9312dfa61e7a4506ed4e49.diff L

[PATCH] D78089: [dexp] NFC: Change positional argument format

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. kbobyrev updated this revision to Diff 257224. kbobyrev added a comment. kbobyrev edited the summary of this revision.

[PATCH] D77809: [Analyzer] Include typedef statements in CFG build.

balazske added a comment. I looked at the graphical CFG dump and observed that the added code makes the same parts appear that are there in a VLA declaration but missing if a VLA typedef is used. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77809

[PATCH] D78089: [dexp] NFC: Change positional argument format

kbobyrev updated this revision to Diff 257224. kbobyrev added a comment. %s/PATH TO INDEX/INDEX FILE/g for clarity Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78089/new/ https://reviews.llvm.org/D78089 Files: clang-tools-extra/clangd/index/dex

[PATCH] D77982: [Windows SEH] Fix the frame-ptr of a nested-filter within a _finally

tentzen updated this revision to Diff 257227. tentzen added a comment. Do not use name comparison to locate parent's alloca of frame-pointer-addr. search parent's LocalDeclMap instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77982/new/ https

[PATCH] D77982: [Windows SEH] Fix the frame-ptr of a nested-filter within a _finally

tentzen added a comment. In D77982#1978105 , @efriedma wrote: > Again, using the name isn't reliable. Among other things, in release builds, > IR values don't have names at all. ok, will fix it. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D78048: [clangd] Add tests that no-op changes are cheap

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks for doing this LGTM! Comment at: clang-tools-extra/clangd/unittests/ClangdTests.cpp:501 +MATCHER_P4(Stats, Name, UsesMemory, PreambleBuilds, ASTBuilds, "") { + re

[PATCH] D77305: [Analyzer][VLASize] Support multi-dimensional arrays.

This revision was automatically updated to reflect the committed changes. Closed by commit rG37ac1c19bed7: [Analyzer][VLASize] Support multi-dimensional arrays. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77305/new/ https:/

[PATCH] D77875: [ARM] Armv8.6-a Matrix Mul cmd line support

DavidSpickett added a reviewer: DavidSpickett. DavidSpickett added a comment. > Note: +f32mm and +f64mm are optional and so have to be enabled by default I think I know what you mean, but "and so are not enabled by default" would be clearer. Also to double check, does f64mm imply f32mm? (not su

[PATCH] D77395: [AST] Dont invalidate VarDecl even the default initializaiton is failed.

hokein updated this revision to Diff 257231. hokein marked 5 inline comments as done. hokein added a comment. rebase and address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77395/new/ https://reviews.llvm.org/D77395 Files: clan

[PATCH] D77395: [AST] Dont invalidate VarDecl even the default initializaiton is failed.

hokein added a comment. In D77395#1972666 , @sammccall wrote: > the `attempt to use a deleted function` diagnostic is a bit spammy, because > the default-constructor and destructor are often deleted for similar reasons. > But I guess this is probably OK,

[PATCH] D77794: [clangd] Pull installed gRPC and introduce shared-index-(server|client)

kbobyrev planned changes to this revision. kbobyrev added a comment. Also Comment at: clang-tools-extra/clangd/CMakeLists.txt:164 + + set(_GRPC_GRPCPP gRPC::grpc++) + set(_PROTOBUF_LIBPROTOBUF protobuf::libprotobuf) sammccall wrote: > Can we give these slight

[PATCH] D77732: [clangd] Shard preamble symbols in dynamic index

kadircet updated this revision to Diff 257242. kadircet marked 7 inline comments as done. kadircet added a comment. - Address comments - Merge slab generations into a single member that returns an `IndexFileIn`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D77794: [clangd] Pull installed gRPC and introduce shared-index-(server|client)

kbobyrev updated this revision to Diff 257240. kbobyrev marked 19 inline comments as done. kbobyrev added a comment. Address a bunch of comments (still a couple left though). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77794/new/ https://reviews.

[PATCH] D77732: [clangd] Shard preamble symbols in dynamic index

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/FileIndex.h:165 + /// Returns absolute paths for all files that has a shard. + std::vector getAllFiles() const; + sammccall wrote: > I do find it a little weird not to expose the map-str

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

fhahn added inline comments. Comment at: clang/docs/MatrixTypes.rst:79 + floating point type, convert the integer or floating point operand to the + underlying element type of the operand of matrix type. + rjmccall wrote: > You should standardize on one term an

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

fhahn updated this revision to Diff 257253. fhahn marked 8 inline comments as done. fhahn added a comment. Address latest comments, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76612/new/ https://reviews.llvm.org/D76612 Files: clang/doc

[PATCH] D76078: [AArch64][SVE] Add a pass for SVE intrinsic optimisations

This revision was automatically updated to reflect the committed changes. Closed by commit rG36c76de6789c: [AArch64][SVE] Add a pass for SVE intrinsic optimisations (authored by kmclaughlin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76078/new/

[clang] f2b5e60 - [Analyzer][StreamChecker] Added evaluation of fseek.

Author: Balázs Kéri Date: 2020-04-14T12:35:28+02:00 New Revision: f2b5e60dfd09f99d036197c078179c774f8b4582 URL: https://github.com/llvm/llvm-project/commit/f2b5e60dfd09f99d036197c078179c774f8b4582 DIFF: https://github.com/llvm/llvm-project/commit/f2b5e60dfd09f99d036197c078179c774f8b4582.diff L

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

fhahn updated this revision to Diff 257259. fhahn marked an inline comment as done. fhahn added a comment. Rename __builtin_matrix_columnwise_{load,store} => __builtin_matrix_column_major_{load,store} Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7

[PATCH] D75851: [Analyzer][StreamChecker] Added evaluation of fseek.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf2b5e60dfd09: [Analyzer][StreamChecker] Added evaluation of fseek. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75851/new/ https://

[clang] 9657385 - [AST] Dont invalide VarDecl even the default initializaiton is failed.

Author: Haojian Wu Date: 2020-04-14T12:58:48+02:00 New Revision: 9657385960350150b77ed652175b4c3801abd7fa URL: https://github.com/llvm/llvm-project/commit/9657385960350150b77ed652175b4c3801abd7fa DIFF: https://github.com/llvm/llvm-project/commit/9657385960350150b77ed652175b4c3801abd7fa.diff LO

[clang] 1647ff6 - [ADT/STLExtras.h] - Add llvm::is_sorted wrapper and update callers.

Author: Georgii Rymar Date: 2020-04-14T14:11:02+03:00 New Revision: 1647ff6e2753026f8a1e21c60d37b83602520b64 URL: https://github.com/llvm/llvm-project/commit/1647ff6e2753026f8a1e21c60d37b83602520b64 DIFF: https://github.com/llvm/llvm-project/commit/1647ff6e2753026f8a1e21c60d37b83602520b64.diff

[PATCH] D77794: [clangd] Pull installed gRPC and introduce clangd-remote-(server|client)

kbobyrev updated this revision to Diff 257270. kbobyrev marked 6 inline comments as done. kbobyrev added a comment. Improve CMake infrastructure. - Move client and server into separate directories and enable LLVM's error logic - Address a bunch of comments regarding flags enabling gRPC & remote i

[PATCH] D77794: [clangd] Pull installed gRPC and introduce clangd-remote-(server|client)

kbobyrev planned changes to this revision. kbobyrev added a comment. Still need to do: - Add documentation for enabling gRPC - Simplify `clangd-index-(server|client)` as proposed - Find out why lookup is working differently than in Dexp (debug a little bit, I'm pretty sure there is some minor bu

[PATCH] D77794: [clangd] Pull installed gRPC and introduce clangd-remote-(server|client)

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/CMakeLists.txt:156 + +option(GRPC_INSTALL_PATH "Path to gRPC library installation." OFF) +if (GRPC_INSTALL_PATH) sammccall wrote: > sammccall wrote: > > sammccall wrote: > > > We'll eventually w

[PATCH] D78016: [ADT/STLExtras.h] - Add llvm::is_sorted wrapper and update callers.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1647ff6e2753: [ADT/STLExtras.h] - Add llvm::is_sorted wrapper and update callers. (authored by grimar). Herald added subscribers: cfe-commits, jrtc27. Herald added a project: clang. Repository: rG LLVM

[PATCH] D77395: [AST] Dont invalidate VarDecl even the default initializaiton is failed.

This revision was automatically updated to reflect the committed changes. Closed by commit rG965738596035: [AST] Dont invalide VarDecl even the default initializaiton is failed. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D77395?vs=257231&id=257281#toc Repository:

[PATCH] D78098: [CGExprAgg] Fix infinite loop in `findPeephole`

ekatz created this revision. ekatz added reviewers: craig.topper, rjmccall, rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix PR45476 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D78098 Files: clang/lib/CodeGen/CGExprAgg.cpp Index: clang/l

[PATCH] D78097: [analyzer][RetainCount] Remove the CheckOSObject option

Szelethus created this revision. Szelethus added reviewers: NoQ, vsavchenko, martong, baloghadamsoftware, xazax.hun, balazske, dcoughlin. Szelethus added a project: clang. Herald added subscribers: cfe-commits, ASDenysPetrov, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.s

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

SjoerdMeijer added inline comments. Comment at: clang/docs/MatrixTypes.rst:12 +fixed-size matrices as language values and perform arithmetic on them. + +This feature is currently experimental, and both its design and its Would it be good to set expectations here

[PATCH] D78068: [www] Turn 'Clang 10' boxes green in C++ status pages to reflect release

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78068/new/ https://reviews.llvm.org/D78068

[PATCH] D74669: [clang-tidy] New check: bugprone-suspicious-include

sylvestre.ledru added a comment. Firefox uses a unified build model. For better performances in the binary, the C++ files are compiled as the same time from a single file (ex: Unified_cpp_netwerk_base3.cpp) which will include the .cpp files. This isn't a common use case, so, don't hesitate to i

[PATCH] D77461: [WIP][clang-tidy] Remove false positive in AvoidNonConstGlobalVariables

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidNonConstGlobalVariablesCheck.cpp:50 +// variables in a function. +if (!Variable->isLocalVarDecl()) { + diag(Variable->getLocation(), "variable %0 is non-const and gl

[PATCH] D57226: [Fixed Point] [AST] Add an AST serialization code for fixed-point literals.

vabridgers added a comment. Thank you for the comments. Please do let me know when this patch is ready to land. Best! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57226/new/ https://reviews.llvm.org/D57226 _

[PATCH] D57226: [Fixed Point] [AST] Add an AST serialization code for fixed-point literals.

vabridgers updated this revision to Diff 257287. vabridgers added a comment. update based on comments from rjmccall Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57226/new/ https://reviews.llvm.org/D57226 Files: clang/include/clang/AST/Expr.h

[PATCH] D78100: [AST] Suppress the spammy "attempt to use a deleted fucntion" diagnostic.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: clang. This patch fixes the regression diagnostic, which was introduced in https://reviews.llvm.org/D77395. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D78100 Files: clang/lib/Sema/Se

[PATCH] D78098: [CGExprAgg] Fix infinite loop in `findPeephole`

lebedev.ri added a comment. Can test be added here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78098/new/ https://reviews.llvm.org/D78098 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D76594: [clang][AST] Support AST files larger than 512M

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. We're starting to see quite a lot of production crashes with this and would very much like a fix. At this point it seems like we're best moving ahead and if someone comes up with a bette

[PATCH] D76083: [clang-tidy] Expand the list of functions in bugprone-unused-return-value

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UnusedReturnValueCheck.cpp:98 + "::access;" + "::bind;" + "::connect;" sam

[PATCH] D78101: [analyzer][StackAddressEscape] Tie warnings to the diagnostic checkers rather then core.StackAddrEscapeBase

Szelethus created this revision. Szelethus added reviewers: NoQ, xazax.hun, dcoughlin, baloghadamsoftware, balazske, martong. Szelethus added a project: clang. Herald added subscribers: cfe-commits, ASDenysPetrov, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnko

Re: [PATCH] D63194: [clangd] Link and initialize target infos

Hi Kadir, Thank you for looking into this. Unfortunately, I can't repro this anymore. I wonder if I had a weird stale clangd or something. Current test (now changed to armv7) does set the target properly. When I tried last time, it wasn't setting it, and was defaulting to my system's (darwin). Th

[clang] 440b445 - [clang-objc-fuzzer] Add LLVMFuzzerInitialize to fix msvc builds (PR44414)

Author: Simon Pilgrim Date: 2020-04-14T13:37:27+01:00 New Revision: 440b445fff848aded09fe5f7d69ff690113e44e2 URL: https://github.com/llvm/llvm-project/commit/440b445fff848aded09fe5f7d69ff690113e44e2 DIFF: https://github.com/llvm/llvm-project/commit/440b445fff848aded09fe5f7d69ff690113e44e2.diff

[PATCH] D78098: [CGExprAgg] Fix infinite loop in `findPeephole`

ekatz updated this revision to Diff 257299. ekatz added a comment. Herald added a subscriber: jfb. Added test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78098/new/ https://reviews.llvm.org/D78098 Files: clang/lib/CodeGen/CGExprAgg.cpp clang/test/CodeGen/atomic-struct-bug.cpp

[PATCH] D77809: [Analyzer] Include typedef statements in CFG build.

Szelethus added a comment. In D77809#1979911 , @balazske wrote: > I looked at the graphical CFG dump and observed that the added code makes the > same parts appear that are there in a VLA declaration but missing if a VLA > typedef is used. Could add a

[PATCH] D77875: [ARM] Armv8.6-a Matrix Mul cmd line support

DavidSpickett added a comment. Or in other words, does amrv8.6-a+sve imply +f32mm *and* +f64mm? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77875/new/ https://reviews.llvm.org/D77875 ___ cfe-commits

[PATCH] D77233: [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec.

erik.pilkington added inline comments. Comment at: clang/include/clang-c/Index.h:4503 CXObjCPropertyAttr_unsafe_unretained = 0x800, - CXObjCPropertyAttr_class = 0x1000 + CXObjCPropertyAttr_classattr = 0x1000 } CXObjCPropertyAttrKind; plotfi wrote: > erik.pi

[PATCH] D78100: [AST] Suppress the spammy "attempt to use a deleted fucntion" diagnostic.

hokein updated this revision to Diff 257302. hokein added a comment. fix the broken tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78100/new/ https://reviews.llvm.org/D78100 Files: clang/lib/Sema/SemaDecl.cpp clang/lib/Sema/SemaDeclCXX.c

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

fhahn updated this revision to Diff 257304. fhahn added a comment. Fix typo, remove a 2 places where `underlying` element type was used, move C portion of the example to LanguageExtensions.rst, drop the rest of the example. : Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware added a comment. OK, I made some experiments. In function `vector_insert_begin()` of test file `iterator-modeling.cpp`, line `960` we pass `i0` to `std::vector::insert()`. This function has no body at all so regardless of inlining of STL functions is enabled, this function is

[PATCH] D77732: [clangd] Shard preamble symbols in dynamic index

sammccall accepted this revision. sammccall added a comment. Still LG Comment at: clang-tools-extra/clangd/index/FileIndex.h:165 + /// Returns absolute paths for all files that has a shard. + std::vector getAllFiles() const; + kadircet wrote: > sammccall wrot

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

fhahn updated this revision to Diff 257309. fhahn added a comment. Drop another instance of underlying element type. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76612/new/ https://reviews.llvm.org/D76612 Files: clang/docs/LanguageExtensions.rs

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

fhahn marked 3 inline comments as done. fhahn added inline comments. Comment at: clang/docs/MatrixTypes.rst:12 +fixed-size matrices as language values and perform arithmetic on them. + +This feature is currently experimental, and both its design and its SjoerdMei

[PATCH] D77802: [analyzer] Improved RangeSet::Negate support of unsigned ranges

baloghadamsoftware added a comment. Thank you for fixing this issue! Please add a bit more tests where we can see that the negated of unsigned range of `[n..m]` is `UINT_MAX-m+1..UINT_MAX-n+1]`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77802/

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

SjoerdMeijer added inline comments. Comment at: clang/docs/MatrixTypes.rst:27 +internal layout, overall size and alignment are implementation-defined. +A *matrix element type* must be a real type (as in C99 6.2.5p17) excluding +enumeration types or an implementation-defined half-

[PATCH] D77794: [clangd] Pull installed gRPC and introduce clangd-remote-(server|client)

sammccall added inline comments. Comment at: clang-tools-extra/clangd/index/remote/CMakeLists.txt:19 +add_library(gRPCProtos ${Index_proto_source} ${Index_grpc_header} ${Index_grpc_source} ${Index_grpc_header}) +target_link_libraries(gRPCProtos gRPC::grpc++ protobuf::libprotobuf

[PATCH] D78101: [analyzer][StackAddressEscape] Tie warnings to the diagnostic checkers rather then core.StackAddrEscapeBase

baloghadamsoftware accepted this revision. baloghadamsoftware added a comment. This revision is now accepted and ready to land. This seems to be an obvious fix. Thank you for working on this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78101/new/

[libclc] cccdd05 - libclc: Don't pass linker flags to CLC/LLAsm

Author: Daniel Stone Date: 2020-04-14T10:03:27-04:00 New Revision: cccdd0579b5027d0a21fd2dbc0a6a50330134976 URL: https://github.com/llvm/llvm-project/commit/cccdd0579b5027d0a21fd2dbc0a6a50330134976 DIFF: https://github.com/llvm/llvm-project/commit/cccdd0579b5027d0a21fd2dbc0a6a50330134976.diff

[libclc] 24fad72 - libclc: Use temporary files rather than a pipe

Author: Daniel Stone Date: 2020-04-14T10:03:27-04:00 New Revision: 24fad7278a391c6f8af664f4ac691c1719008a09 URL: https://github.com/llvm/llvm-project/commit/24fad7278a391c6f8af664f4ac691c1719008a09 DIFF: https://github.com/llvm/llvm-project/commit/24fad7278a391c6f8af664f4ac691c1719008a09.diff

[libclc] acf0790 - libclc: Use echo rather than true for try_compile

Author: Daniel Stone Date: 2020-04-14T10:03:27-04:00 New Revision: acf079006e6dbdd23300e9289cc8d8197aab5fb5 URL: https://github.com/llvm/llvm-project/commit/acf079006e6dbdd23300e9289cc8d8197aab5fb5 DIFF: https://github.com/llvm/llvm-project/commit/acf079006e6dbdd23300e9289cc8d8197aab5fb5.diff

[libclc] e6bb1d6 - libclc: Fix LLVM library linking on Windows

Author: Daniel Stone Date: 2020-04-14T10:03:27-04:00 New Revision: e6bb1d69eccc612e54fd1a0b63ca3dcc84c3a6fa URL: https://github.com/llvm/llvm-project/commit/e6bb1d69eccc612e54fd1a0b63ca3dcc84c3a6fa DIFF: https://github.com/llvm/llvm-project/commit/e6bb1d69eccc612e54fd1a0b63ca3dcc84c3a6fa.diff

[clang-tools-extra] 808c285 - [clangd] Add tests that no-op changes are cheap

Author: Sam McCall Date: 2020-04-14T16:15:23+02:00 New Revision: 808c2855e11615a384df9667338aa52854a92fd5 URL: https://github.com/llvm/llvm-project/commit/808c2855e11615a384df9667338aa52854a92fd5 DIFF: https://github.com/llvm/llvm-project/commit/808c2855e11615a384df9667338aa52854a92fd5.diff LO

[PATCH] D78048: [clangd] Add tests that no-op changes are cheap

sammccall marked 3 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/unittests/ClangdTests.cpp:501 +MATCHER_P4(Stats, Name, UsesMemory, PreambleBuilds, ASTBuilds, "") { + return arg.first() == Name && (arg.second.UsedBytes != 0) == Us

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

NoQ added a comment. Aha, ok, sounds like i thought that it's not worth it to inline the constructor for an argument when the call itself is not inlined, therefore i didn't model the construction context for this call. See also D49443#1193290 . Your exam

[PATCH] D78027: [TimeProfiler] Emit real process ID and thread names

russell.gallop accepted this revision. russell.gallop added a comment. This revision is now accepted and ready to land. Would be nice if the test could check that the pid was being set to something but not sure how you could do that (beyond checking that it's a number). Apart from that, LGTM.

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

sfertile added inline comments. Comment at: clang/test/CodeGen/ppc32-struct-return.c:53 + +// AIX-SVR4: fatal error: error in backend: -msvr4-struct-return not supported on AIX + jasonliu wrote: > If certain front end option is not supported on certain target,

[PATCH] D77806: [analyzer] Do not report CFError null dereference for nonnull params

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Looks great. I'll commit this one as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77806/new/ https://reviews.llvm.org/D77806 ___

[PATCH] D77066: [analyzer] ApiModeling: Add buffer size arg constraint

martong updated this revision to Diff 257317. martong marked an inline comment as done. martong added a comment. - Rebase to master - Use BinaryOperator::negateComparisonOp - getBufferDynamicSize -> getDynamicSizeWithOffset Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D77066: [analyzer] ApiModeling: Add buffer size arg constraint

martong added a comment. In D77066#1953280 , @Charusso wrote: > Please avoid to stuff in `CheckerContext` because this facility should be > used by ExprEngine/Store as well. > Let us reword your API: `getDynamicSizeWithOffset(ProgramStateRef, SVal, > SV

[PATCH] D78020: clang/AMDGPU: Assume denormals are enabled for the default target.

arsenm added a comment. In D78020#1978034 , @yaxunl wrote: > I think https://reviews.llvm.org/D78019 should fix the issue about HIP not > using correct default denormal value if no arch is specified. > > In that case, driver actually sets offloading arch

[PATCH] D78020: clang/AMDGPU: Assume denormals are enabled for the default target.

arsenm updated this revision to Diff 257318. arsenm added a comment. Fix test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78020/new/ https://reviews.llvm.org/D78020 Files: clang/lib/Driver/ToolChains/AMDGPU.cpp clang/test/Driver/cl-denorms-are-zero.cl clang/test/Driver/cuda-flu

[PATCH] D77989: Allow disabling of vectorization using internal options

tejohnson added a comment. In D77989#1979772 , @wmi wrote: > In D77989#1979725 , @wmi wrote: > > > The patch makes the reasoning about when the internal flags will take > > effect much easier. > > > > One question

[PATCH] D76932: [AIX] emit .extern and .weak directive linkage

DiggerLin updated this revision to Diff 257319. DiggerLin marked 2 inline comments as done. DiggerLin added a comment. address comment and add a new test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76932/new/ https://reviews.llvm.org/D76932

[PATCH] D78048: [clangd] Add tests that no-op changes are cheap

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG808c2855e116: [clangd] Add tests that no-op changes are cheap (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D78048?vs=257083&id=2

[clang] f6ea026 - [SveEmitter] Fix encoding/decoding of SVETypeFlags

Author: Sander de Smalen Date: 2020-04-14T15:48:28+01:00 New Revision: f6ea026f179a02cd335d71e4800b4d67c25c006b URL: https://github.com/llvm/llvm-project/commit/f6ea026f179a02cd335d71e4800b4d67c25c006b DIFF: https://github.com/llvm/llvm-project/commit/f6ea026f179a02cd335d71e4800b4d67c25c006b.di

[PATCH] D78020: clang/AMDGPU: Assume denormals are enabled for the default target.

yaxunl added inline comments. Comment at: clang/test/Driver/cuda-flush-denormals-to-zero.cu:26 +// Test no subtarget +// FIXME: This defaults to gfx803, but gets a different denormal mode than explicitly specifying it. +// RUN: %clang -x hip -no-canonical-prefixes -### -target x

[PATCH] D76238: [SveEmitter] Implement builtins for contiguous loads/stores

sdesmalen added inline comments. Comment at: clang/include/clang/Basic/arm_sve.td:186 +def SVLDFF1 : MInst<"svldff1[_{2}]", "dPc", "csilUcUsUiUlhfd", [IsLoad], MemEltTyDefault, "aarch64_sve_ldff1">; +def SVLDFF1SB : MInst<"svldff1sb_{d}", "dPS", "silUsUiUl",

[PATCH] D77809: [Analyzer] Include typedef statements in CFG build.

balazske updated this revision to Diff 257330. balazske added a comment. - Added tests. - Updated a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77809/new/ https://reviews.llvm.org/D77809 Files: clang/lib/Analysis/CFG.cpp clang/test/

[PATCH] D77809: [Analyzer] Include typedef statements in CFG build.

balazske marked an inline comment as done. balazske added a comment. Without the new code the CFG dump for `vla_typedef` contains: [B1] 1: VLA vla; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77809/new/ https://reviews.llvm.org/D77809

[PATCH] D76389: [NewPM] Run the Speculative Execution Pass only if the target has divergent branches

arsenm added inline comments. Comment at: llvm/include/llvm/Transforms/Scalar/SpeculativeExecution.h:97 + +class SpeculativeExecutionIfHasBranchDivergencePass +: public SpeculativeExecutionPassImpl, Still define a second pass Comment at: ll

[PATCH] D78075: [Clang][OpenMP] Added support for nowait target in CodeGen

jdoerfert added a comment. You need to update the tests too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78075/new/ https://reviews.llvm.org/D78075 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D77875: [ARM] Armv8.6-a Matrix Mul cmd line support

LukeGeeson added a comment. In D77875#1979980 , @DavidSpickett wrote: > > Note: +f32mm and +f64mm are optional and so have to be enabled by default > > I think I know what you mean, but "and so are not enabled by default" would > be clearer. > > Also to

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

jasonliu added inline comments. Comment at: clang/test/CodeGen/ppc32-struct-return.c:53 + +// AIX-SVR4: fatal error: error in backend: -msvr4-struct-return not supported on AIX + jasonliu wrote: > sfertile wrote: > > jasonliu wrote: > > > If certain front end o

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

jasonliu added inline comments. Comment at: clang/test/CodeGen/ppc32-struct-return.c:53 + +// AIX-SVR4: fatal error: error in backend: -msvr4-struct-return not supported on AIX + sfertile wrote: > jasonliu wrote: > > If certain front end option is not supported

[PATCH] D77461: [WIP][clang-tidy] Remove false positive in AvoidNonConstGlobalVariables

vingeldal added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-avoid-non-const-global-variables.cpp:234-236 +static int staticNonConstLoopVariable = 42; int nonConstLoopVariable = 42; +nonConstInt = nonConstLoopVariable + i

[PATCH] D77794: [clangd] Pull installed gRPC and introduce clangd-remote-(server|client)

kbobyrev updated this revision to Diff 257334. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Improve CMake machinery and cleanup code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77794/new/ https://reviews.llvm.org/D77794 F

[PATCH] D77461: [WIP][clang-tidy] Remove false positive in AvoidNonConstGlobalVariables

vingeldal updated this revision to Diff 257335. vingeldal marked 3 inline comments as done. vingeldal added a comment. Moved previously added condition into the actual matcher. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77461/new/ https://review

[PATCH] D75184: [clang-tidy] Optional inheritance of file configs from parent directories 

DmitryPolukhin added a comment. @alexfh thank you for review! Comment at: clang-tools-extra/clang-tidy/ClangTidyOptions.h:101-104 +ClangTidyValue(const char *Value) : Value(Value), Priority(0) {} +ClangTidyValue(const std::string &Value) : Value(Value), Priority(0) {} +

[PATCH] D76617: [SveEmitter] Fix encoding/decoding of SVETypeFlags

This revision was automatically updated to reflect the committed changes. Closed by commit rGf6ea026f179a: [SveEmitter] Fix encoding/decoding of SVETypeFlags (authored by sdesmalen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76617/new/ https://r

[PATCH] D75184: [clang-tidy] Optional inheritance of file configs from parent directories 

DmitryPolukhin updated this revision to Diff 257336. DmitryPolukhin marked 6 inline comments as done. DmitryPolukhin added a comment. Comments resolved + rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75184/new/ https://reviews.llvm.org/D7518

[PATCH] D75184: [clang-tidy] Optional inheritance of file configs from parent directories 

DmitryPolukhin updated this revision to Diff 257338. DmitryPolukhin added a comment. Remove clang-format errors in diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75184/new/ https://reviews.llvm.org/D75184 Files: clang-tools-extra/clang-tidy/

[PATCH] D78030: [TimeProfiler] Emit clock synchronization point

broadwaylamb updated this revision to Diff 257340. broadwaylamb added a comment. Indent patterns in tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78030/new/ https://reviews.llvm.org/D78030 Files: clang/test/Driver/check-time-trace-sections

[PATCH] D78030: [TimeProfiler] Emit clock synchronization point

broadwaylamb marked an inline comment as done. broadwaylamb added a comment. It'd be good if I had one more LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78030/new/ https://reviews.llvm.org/D78030 __

[PATCH] D77794: [clangd] Pull installed gRPC and introduce clangd-remote-(server|client)

kbobyrev updated this revision to Diff 257341. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Give gRPC and Protobuf libraries better names in CMake. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77794/new/ https://reviews.llv

[PATCH] D77923: OpenCL: Fix some missing predefined macros

Anastasia added a comment. As for OpenCL C spec we should ideally add `__OPENCL_VERSION__` but I feel it should be taken from architecture or OS type... I think there were other cases where we needed something like an OpenCL runtime version in the triple too but I can't remember this now. I ca

[PATCH] D77794: [clangd] Pull installed gRPC and introduce clangd-remote-(server|client)

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/remote/CMakeLists.txt:19 +add_library(gRPCProtos ${Index_proto_source} ${Index_grpc_header} ${Index_grpc_source} ${Index_grpc_header}) +target_link_libraries(gRPCProtos gRPC::grpc++ protobuf::libprotobuf)

[PATCH] D75184: [clang-tidy] Optional inheritance of file configs from parent directories 

DmitryPolukhin updated this revision to Diff 257344. DmitryPolukhin added a comment. One more try to remove useless lint issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75184/new/ https://reviews.llvm.org/D75184 Files: clang-tools-extra/cla

[PATCH] D71227: [cuda][hip] Fix function overload resolution in the global initiailizer.

hliao updated this revision to Diff 257347. hliao added a comment. Rebase to trunk. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71227/new/ https://reviews.llvm.org/D71227 Files: clang/include/clang/Sema/Sema.h clang/lib/Parse/ParseDecl.cpp

[PATCH] D77461: [WIP][clang-tidy] Remove false positive in AvoidNonConstGlobalVariables

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidNonConstGlobalVariablesCheck.cpp:50 +// variables in a function. +if (!Variable->isLocalVarDecl()) { + diag(Variable->getLocation(), "variable %0 is non-const and gl

  1   2   3   >