[PATCH] D77982: [Windows SEH] Fix the frame-ptr of a nested-filter within a _finally

tentzen added a comment. It can be greater than 2 because this Map includes Decls of User locals from parent. see CodeGenFunction::EmitCapturedLocals() (the same place of this fix). .. auto I = ParentCGF.LocalDeclMap.find(VD); if (I == ParentCGF.LocalDeclMap.end()) continue; Add

[PATCH] D78252: [AArch64] FMLA/FMLS patterns improvement.

dmgreen added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:8055 multiclass SIMDFPIndexedTiedPatterns { + let Predicates = [HasNEON, HasFullFP16] in { + // 1 variant for the .8h version: DUPLANE from 128-bit Should we have equal p

[PATCH] D78273: [clang-tools-extra] reimplement PreprocessorTracker in terms of StringSet.

lattner added a comment. Hey @maskray, yes StringSet/StringMap's entries are separately allocated and the iterators/pointers are stable. The strings are held in each entry. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78273/new/ https://reviews.

[PATCH] D78273: [clang-tools-extra] reimplement PreprocessorTracker in terms of StringSet.

MaskRay added inline comments. Comment at: clang-tools-extra/modularize/PreprocessorTracker.cpp:912 // Lookup/add string. - StringHandle addString(llvm::StringRef Str) { return Strings.intern(Str); } + StringHandle addString(llvm::StringRef Str) { +return Strings.insert(

[PATCH] D78273: [clang-tools-extra] reimplement PreprocessorTracker in terms of StringSet.

lattner created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. MaskRay added inline comments. Comment at: clang-tools-extra/modularize/PreprocessorTracker.cpp:912 // Lookup/add string. - StringHandle addString(llvm::StringRef Str) { retu

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

rjmccall added inline comments. Comment at: clang/docs/MatrixTypes.rst:29 +A *matrix element type* must be a real type (as in C99 6.2.5p17) excluding +enumeration types or an implementation-defined half-precision floating point +type, otherwise the program is ill-formed.

[PATCH] D77592: [NFC][CodeGen] Add enum for selecting the layout of components in the vtable

rjmccall added a comment. I'm not sure if the AST-level v-table layout abstraction really cares about these differences. I don't think it vends byte offsets into the v-table, just slot indices (i.e. word offsets). Comment at: clang/include/clang/AST/VTableBuilder.h:380 +

[clang] 1765edb - Fix memory leak introduced by llvmorg-11-init-11960-gbab6df86aef.

Author: Richard Smith Date: 2020-04-15T19:39:39-07:00 New Revision: 1765edbb5660b028cee56f40e9a1988791762fd5 URL: https://github.com/llvm/llvm-project/commit/1765edbb5660b028cee56f40e9a1988791762fd5 DIFF: https://github.com/llvm/llvm-project/commit/1765edbb5660b028cee56f40e9a1988791762fd5.diff

[PATCH] D76038: PR45000: Use Sema::SetParamDefaultArgument in TransformLambdaExpr

aaronpuchert updated this revision to Diff 257938. aaronpuchert added a comment. Add test case, loosely based on that in the bug report. By choosing a conversion that should error out we can detect the issue in a pure frontend test. However, we would expect the error only once. Further investig

[PATCH] D76038: PR45000: Use Sema::SetParamDefaultArgument in TransformLambdaExpr

aaronpuchert added a comment. I tested a bit more and there is a problem: some errors now appear twice, and I think they shouldn't. template void f(int x = [](T x = nullptr) -> int { return x; }()); void g() { f(); } The error is expected, but it should only appear once: :2:23: err

[PATCH] D77982: [Windows SEH] Fix the frame-ptr of a nested-filter within a _finally

efriedma added a comment. If you can `assert(ParentCGF.LocalDeclMap.size() == 2);`, I guess the current code is good enough. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77982/new/ https://reviews.llvm.org/D77982 __

[PATCH] D77683: [Docs] Make code review policy clearer about requested pre-commit reviews

jdoerfert added a comment. The problem I want to address is with code owners. TBH, I would like our overall description of that role to be (more) like @hfinkel described it. In case there is no controversy, that is not really different from @dblaikie vision (I think). If there is controversy, a

[PATCH] D78134: [Sema] Don't apply an lvalue-to-rvalue conversion to a discarded-value expression if it has an array type

rsmith added a comment. In D78134#1985467 , @ahatanak wrote: > In D78134#1982291 , @rsmith wrote: > > > So far, the direction the wind is blowing is that attempting to perform an > > lvalue-to-rvalue conversion on

[PATCH] D78134: [Sema] Don't apply an lvalue-to-rvalue conversion to a discarded-value expression if it has an array type

ahatanak added a comment. In D78134#1982291 , @rsmith wrote: > In D78134#1981866 , @rsmith wrote: > > > I'm going to take this to CWG. > > > So far, the direction the wind is blowing is that attempting to perform an

[clang] 2ba12ff - Revert "Attempt to fix build with MSVC."

Author: Richard Smith Date: 2020-04-15T17:40:00-07:00 New Revision: 2ba12ff1e51aee7d33233f95734937d44c4a1282 URL: https://github.com/llvm/llvm-project/commit/2ba12ff1e51aee7d33233f95734937d44c4a1282 DIFF: https://github.com/llvm/llvm-project/commit/2ba12ff1e51aee7d33233f95734937d44c4a1282.diff

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

gamesh411 marked 5 inline comments as done. gamesh411 added inline comments. Comment at: clang/lib/CrossTU/CrossTranslationUnit.cpp:457 +return llvm::make_error( +index_error_code::ambiguous_compile_commands_database); + martong wrote: > Could we have

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

gamesh411 updated this revision to Diff 257896. gamesh411 marked an inline comment as done. gamesh411 added a comment. Implement review suggestions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/ https://reviews.llvm.org/D75665 Files: c

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

gamesh411 marked 7 inline comments as done. gamesh411 added inline comments. Comment at: clang/test/Analysis/ctu-on-demand-parsing.c:5 +// RUN: cp "%S/Inputs/ctu-other.c" "%t/ctu-other.c" +// RUN: echo '[{"directory":"%t","command":"gcc -c -std=c89 -Wno-visibility ctu-other.c","

[PATCH] D77880: get scan-view executable from environment

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thank you! While it probably will never matter in practice because `scan-view` is barely ever updated, wouldn't it be a bit safer from revision lock perspective to keep looking for `scan-view` rela

[PATCH] D77794: [clangd] Pull installed gRPC and introduce clangd-remote-(server|client)

kbobyrev updated this revision to Diff 257893. kbobyrev marked 18 inline comments as done. kbobyrev added a comment. Address a bunch of comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77794/new/ https://reviews.llvm.org/D77794 Files: cla

[PATCH] D77420: Also look for devtoolset-9 gcc toolchain

stephan.dollberg added a comment. Thanks, can you merge it? Don't have access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77420/new/ https://reviews.llvm.org/D77420 ___ cfe-commits mailing list cfe-

[PATCH] D77809: [Analyzer] Include typedef statements in CFG build.

NoQ added a comment. In D77809#1984689 , @efriedma wrote: > > Where is the size expression actually evaluated? Is it evaluated at the > > point of the typedef or at the point of the variable definition? > > At the point of the typedef. Whoa, indeed. Nic

[PATCH] D78252: [AArch64] FMLA/FMLS patterns improvement.

ilinpv created this revision. ilinpv added reviewers: samparker, dmgreen, SjoerdMeijer. Herald added subscribers: cfe-commits, danielkiss, hiraditya, kristof.beyls. Herald added a project: clang. FMLA/FMLS 8H duplane indexed patterns added. Fixes https://bugs.llvm.org/show_bug.cgi?id=45467 Repos

[PATCH] D77794: [clangd] Pull installed gRPC and introduce clangd-remote-(server|client)

sammccall added a comment. Thanks, this look really close now. A few things still in the wrong place, and naming/wording nits. Comment at: clang-tools-extra/clangd/CMakeLists.txt:156 + +# This setup requires gRPC to be built from sources using CMake and installed to +# ${GRPC

[PATCH] D77420: Also look for devtoolset-9 gcc toolchain

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. looks good Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77420/new/ https://reviews.llvm.org/D77420 ___

[PATCH] D78129: Add Marvell ThunderX3T110 support

wxz2020 updated this revision to Diff 257876. wxz2020 added a comment. The newly added two files were not accepted by the pre-merge check. Re worked on the diff file and uploaded it now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78129/new/ htt

[PATCH] D78131: [SVE] Fix unsigned is always >= 0

This revision was automatically updated to reflect the committed changes. Closed by commit rG464a0697e36a: [SVE] Fix unsigned is always >= 0 (authored by ctetreau). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78131/new/ https://reviews.llvm.org/D7

[PATCH] D77233: [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec.

plotfi added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77233/new/ https://reviews.llvm.org/D77233 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D77597: [SveEmitter] Add ExpandOp1SVALL and builtin for svptrue

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:7683 +if (TypeFlags.isExpandOp1SVALL()) { + if (Ops.size() <= 1) +Ops.push_back(Builder.getInt32(31)); The `Ops.size() <= 1` seems to return the same result for all the i

[clang] 464a069 - [SVE] Fix unsigned is always >= 0

Author: Christopher Tetreault Date: 2020-04-15T15:23:49-07:00 New Revision: 464a0697e36ae84c4292402c7774c6ec6e93a438 URL: https://github.com/llvm/llvm-project/commit/464a0697e36ae84c4292402c7774c6ec6e93a438 DIFF: https://github.com/llvm/llvm-project/commit/464a0697e36ae84c4292402c7774c6ec6e93a4

[PATCH] D61716: [libclang] Expose AtomicType

slowhog added a comment. Yes, please help to commit the patch. Thank you for looking after this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61716/new/ https://reviews.llvm.org/D61716 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D78239: [SveEmitter] Add builtins for FP conversions

efriedma added a comment. > as the LLVM IR intrinsics use the as the predicate. Why are the fp conversion intrinsics special here? Should we fix the LLVM intrinsic definitions? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78239/new/ https://re

[PATCH] D77621: ADT: SmallVector size & capacity use word-size integers when elements are small.

browneee updated this revision to Diff 257861. browneee added a comment. Rebase to latest HEAD. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77621/new/ https://reviews.llvm.org/D77621 Files: llvm/include/llvm/ADT/SmallVector.h llvm/lib/Suppor

[PATCH] D78125: [AVR] Use the correct address space for non-prototyped function calls

This revision was automatically updated to reflect the committed changes. Closed by commit rG215dc2e20334: [AVR] Use the correct address space for non-prototyped function calls (authored by aykevl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78125

[PATCH] D77593: [SveEmitter] Implement zeroing of false lanes

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77593/new/ https://reviews.llvm.org/D77593 ___ cfe-commits mailing list cfe-commi

[PATCH] D78235: [clangd] Store ppdirective in Inclusion

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Headers.h:55 + Range R; // Inclusion range. + std::string Directive; // Directive used for inclusion, e.g. impo

[PATCH] D78238: [SveEmitter] Add builtins for svwhilerw/svwhilewr

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78238/new/ https://reviews.llvm.org/D78238 ___

[PATCH] D77596: [SveEmitter] Add IsOverloadNone flag and builtins for svpfalse and svcnt[bhwd]_pat

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77596/new/ https://reviews.llvm.org/D77596 ___ cfe-commits mailing list cfe-commi

[PATCH] D78100: [AST] Suppress the spammy "attempt to use a deleted fucntion" diagnostic.

rsmith added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:12268 /// of sanity. void Sema::ActOnInitializerError(Decl *D) { // Our main concern here is re-establishing invariants like "a hokein wrote: > sammccall wrote: > > rsmith wrote: > > > Sho

[PATCH] D77595: [SveEmitter] Add builtins for svwhile

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77595/new/ https://reviews.llvm.org/D77595 ___ cfe-commits mailing list cfe-commi

[PATCH] D73307: Unique Names for Functions with Internal Linkage

tmsriram updated this revision to Diff 257853. tmsriram added a comment. Updated this patch, using a pass to convert symbol names in D78243 Also, removed the test for -fmacro-prefix-map. For -ffile-prefix-map, looks like getSourceFileName() should be modified

[PATCH] D77936: [Windows SEH] Fix abnormal-exits in _try

tentzen updated this revision to Diff 257849. tentzen added a comment. Replace F_HasSehAbnormalExits with F_HasExitSwitch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77936/new/ https://reviews.llvm.org/D77936 Files: clang/lib/CodeGen/CGCleanup

[clang] 215dc2e - [AVR] Use the correct address space for non-prototyped function calls

Author: Ayke van Laethem Date: 2020-04-15T23:44:51+02:00 New Revision: 215dc2e203341f7d1edc4c4a191b048af4ace43d URL: https://github.com/llvm/llvm-project/commit/215dc2e203341f7d1edc4c4a191b048af4ace43d DIFF: https://github.com/llvm/llvm-project/commit/215dc2e203341f7d1edc4c4a191b048af4ace43d.di

[PATCH] D72959: Relative VTables ABI on Fuchsia

phosek added inline comments. Comment at: clang/include/clang/Basic/LangOptions.def:353 COMPATIBLE_VALUE_LANGOPT(MaxTokens, 32, 0, "Max number of tokens per TU or 0") +LANGOPT(FuchsiaRelativeCXXABIVTables, 1, 0, +"Whether to use clang's relative C++ ABI " ---

[PATCH] D77772: [Clang] Expose RequiresNullTerminator in FileManager.

This revision was automatically updated to reflect the committed changes. Closed by commit rG92e8af0ecbe7: [Clang] Expose RequiresNullTerminator in FileManager. (authored by Bigcheese). Changed prior to commit: https://reviews.llvm.org/D2?vs=256722&id=257852#toc Repository: rG LLVM Githu

[clang] 50472c4 - Remove extra ‘;’. NFC.

Author: Michael Liao Date: 2020-04-15T17:22:03-04:00 New Revision: 50472c422cc6d27a4532a4025c4339fb6920 URL: https://github.com/llvm/llvm-project/commit/50472c422cc6d27a4532a4025c4339fb6920 DIFF: https://github.com/llvm/llvm-project/commit/50472c422cc6d27a4532a4025c4339fb6920.diff

[PATCH] D75184: [clang-tidy] Optional inheritance of file configs from parent directories 

njames93 added a comment. In D75184#1984565 , @DmitryPolukhin wrote: > I didn't notice the issue because of massive breakage with diff landed just > be bore mine Sorry about that :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

rjmccall added a comment. In D76384#1984683 , @mibintc wrote: > In D76384#1984584 , @rjmccall wrote: > > > I *would* like an NFC patch first that renames `FPFeatures` to something > > like `CurFPFeatures` in order

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

gamesh411 marked 23 inline comments as done. gamesh411 added a comment. Answered most review comments. Thanks for the reviewers @balazske, @martong so far. The question of absolute path policy is still up for debate. Comment at: clang/lib/CrossTU/CrossTranslationUnit.cpp:365

[clang] 92e8af0 - [Clang] Expose RequiresNullTerminator in FileManager.

Author: Michael Spencer Date: 2020-04-15T14:17:51-07:00 New Revision: 92e8af0ecbe7eb36bc03a211afa9151c81b7b531 URL: https://github.com/llvm/llvm-project/commit/92e8af0ecbe7eb36bc03a211afa9151c81b7b531 DIFF: https://github.com/llvm/llvm-project/commit/92e8af0ecbe7eb36bc03a211afa9151c81b7b531.dif

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

ZarkoCA marked an inline comment as done. ZarkoCA added inline comments. Comment at: clang/test/CodeGen/ppc32-struct-return.c:53 + +// AIX-SVR4: fatal error: error in backend: -msvr4-struct-return not supported on AIX + jasonliu wrote: > jasonliu wrote: > > sfe

[PATCH] D78233: [NFC] Correcting minor typo.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0b21f15e1417: [NFC] Correcting minor typo. (authored by ncv). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78233/new/ https://reviews.llvm.org/D78233 Files

[PATCH] D77597: [SveEmitter] Add ExpandOp1SVALL and builtin for svptrue

sdesmalen updated this revision to Diff 257834. sdesmalen added a comment. rebased patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77597/new/ https://reviews.llvm.org/D77597 Files: clang/include/clang/Basic/TargetBuiltins.h clang/include/clang/Basic/arm_sve.td clang/lib/Code

[PATCH] D76932: [AIX] emit .extern and .weak directive linkage

DiggerLin updated this revision to Diff 257827. DiggerLin marked 2 inline comments as done. DiggerLin added a comment. address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76932/new/ https://reviews.llvm.org/D76932 Files: clang/lib/Driv

[PATCH] D77596: [SveEmitter] Add IsOverloadNone flag and builtins for svpfalse and svcnt[bhwd]_pat

sdesmalen updated this revision to Diff 257824. sdesmalen retitled this revision from "[SveEmitter] Add NoOverload flag and builtin for svpfalse" to "[SveEmitter] Add IsOverloadNone flag and builtins for svpfalse and svcnt[bhwd]_pat". sdesmalen edited the summary of this revision. sdesmalen added

[PATCH] D78238: [SveEmitter] Add builtins for svwhilerw/svwhilewr

sdesmalen created this revision. sdesmalen added reviewers: SjoerdMeijer, efriedma. Herald added a subscriber: tschuett. Herald added a project: clang. sdesmalen added a parent revision: D77595: [SveEmitter] Add builtins for svwhile. sdesmalen added a child revision: D78239: [SveEmitter] Add built

[PATCH] D78239: [SveEmitter] Add builtins for FP conversions

sdesmalen created this revision. sdesmalen added reviewers: SjoerdMeijer, efriedma. Herald added a subscriber: tschuett. Herald added a project: clang. sdesmalen added a parent revision: D78238: [SveEmitter] Add builtins for svwhilerw/svwhilewr. sdesmalen added a child revision: D77597: [SveEmitte

[PATCH] D77595: [SveEmitter] Add builtins for svwhile

sdesmalen updated this revision to Diff 257829. sdesmalen retitled this revision from "[SveEmitter] Add NoAuto flag and builtins for svwhile." to "[SveEmitter] Add builtins for svwhile". sdesmalen edited the summary of this revision. sdesmalen added a comment. - The function that returns a list o

[PATCH] D77982: [Windows SEH] Fix the frame-ptr of a nested-filter within a _finally

tentzen added a comment. The fix there deals with SEH filter with SEH _finally parent where its prototype is FIXED (2 implicit parameters). It will never change. For #2, "...I was thinking you would save the ImplicitParmDecl*, not the actual alloca". If we just savw ImplicitParmDecl, we wil

[PATCH] D76932: [AIX] emit .extern and .weak directive linkage

DiggerLin marked 8 inline comments as done. DiggerLin added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:441 + case GlobalValue::ExternalWeakLinkage: +if (TM.getTargetTriple().isOSBinFormatXCOFF()) { + OutStreamer->emitSymbolAttribute(GVSym, M

[clang] 0b21f15 - [NFC] Correcting minor typo.

Author: Nate Voorhies Date: 2020-04-15T13:36:22-07:00 New Revision: 0b21f15e141737e421845b4a1993c7521af86ae6 URL: https://github.com/llvm/llvm-project/commit/0b21f15e141737e421845b4a1993c7521af86ae6 DIFF: https://github.com/llvm/llvm-project/commit/0b21f15e141737e421845b4a1993c7521af86ae6.diff

[clang] 30853cd - Attempt to fix build with MSVC.

Author: Richard Smith Date: 2020-04-15T13:28:24-07:00 New Revision: 30853cd689efd73a005163436673c13a29eca805 URL: https://github.com/llvm/llvm-project/commit/30853cd689efd73a005163436673c13a29eca805 DIFF: https://github.com/llvm/llvm-project/commit/30853cd689efd73a005163436673c13a29eca805.diff

[clang] 57acbae - Improve diagnostic when constant-evaluating a std::initializer_list with

Author: Richard Smith Date: 2020-04-15T13:28:24-07:00 New Revision: 57acbaece1ace979e6a9382d9d517d48895b9ef7 URL: https://github.com/llvm/llvm-project/commit/57acbaece1ace979e6a9382d9d517d48895b9ef7 DIFF: https://github.com/llvm/llvm-project/commit/57acbaece1ace979e6a9382d9d517d48895b9ef7.diff

[PATCH] D77982: [Windows SEH] Fix the frame-ptr of a nested-filter within a _finally

efriedma added a comment. For (1), I can see your point that it's sort of a balancing act. But generally, I'm concerned about making fragile assumptions: here, that LocalDeclMap contains precisely the two ImplicitParmDecls for the arguments, and nothing else. If we are going to assume that, I

[PATCH] D78181: [clangd] Fix a crash for accessing a null field decl returned by findExplicitReferences.

This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rG6a78c55e3af0: [clangd] Fix a crash for accessing a null field decl returned by… (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D78235: [clangd] Store ppdirective in Inclusion

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This will enable PreamblePatching proposed in D77392 craft a more in

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

This revision was automatically updated to reflect the committed changes. Closed by commit rG2ba4e3a4598b: Move BinaryOperators.FPOptions to trailing storage (authored by mibintc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76384/new/ https://rev

[PATCH] D77612: [ASTMatchers] Fix isDerivedFrom for recursive templates

This revision was automatically updated to reflect the committed changes. Closed by commit rG14d89bfbe0b4: [ASTMatchers] Fix isDerivedFrom for recursive templates (authored by jkorous). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://revie

[PATCH] D77809: [Analyzer] Include typedef statements in CFG build.

efriedma added a comment. > Where is the size expression actually evaluated? Is it evaluated at the point > of the typedef or at the point of the variable definition? At the point of the typedef. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77809

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc added a comment. In D76384#1984584 , @rjmccall wrote: > I *would* like an NFC patch first that renames `FPFeatures` to something like > `CurFPFeatures` in order to more clearly distinguish it from `FPOptions` in > Sema code, though. That should

[PATCH] D77962: PR38490: Support reading values out of __uuidof(X) expressions during constant evaluation.

rsmith abandoned this revision. rsmith added a comment. Superseded by https://reviews.llvm.org/D78171. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77962/new/ https://reviews.llvm.org/D77962 ___ cfe-c

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc added a comment. In D76384#1984584 , @rjmccall wrote: > In D76384#1984498 , @mibintc wrote: > > > Responding to @rjmccall 's review. John, after this is approved I want to > > proceed with pragma float_con

[PATCH] D78233: [NFC] Correcting minor typo.

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78233/new/ https://reviews.llvm.org/D78233

[clang] 2ba4e3a - Move BinaryOperators.FPOptions to trailing storage

Author: Melanie Blower Date: 2020-04-15T12:57:31-07:00 New Revision: 2ba4e3a4598b165245c581c506a813cd4a7dce33 URL: https://github.com/llvm/llvm-project/commit/2ba4e3a4598b165245c581c506a813cd4a7dce33 DIFF: https://github.com/llvm/llvm-project/commit/2ba4e3a4598b165245c581c506a813cd4a7dce33.diff

[clang] 14d89bf - [ASTMatchers] Fix isDerivedFrom for recursive templates

Author: Jan Korous Date: 2020-04-15T12:49:01-07:00 New Revision: 14d89bfbe0b4f633689d829145fc9f0bfdb07b6e URL: https://github.com/llvm/llvm-project/commit/14d89bfbe0b4f633689d829145fc9f0bfdb07b6e DIFF: https://github.com/llvm/llvm-project/commit/14d89bfbe0b4f633689d829145fc9f0bfdb07b6e.diff LO

[clang-tools-extra] 6a78c55 - [clangd] Fix a crash for accessing a null field decl returned by findExplicitReferences.

Author: Haojian Wu Date: 2020-04-15T21:42:27+02:00 New Revision: 6a78c55e3af0fc98513bf7e0b76b3b88719ca2c3 URL: https://github.com/llvm/llvm-project/commit/6a78c55e3af0fc98513bf7e0b76b3b88719ca2c3 DIFF: https://github.com/llvm/llvm-project/commit/6a78c55e3af0fc98513bf7e0b76b3b88719ca2c3.diff LO

[PATCH] D78171: Rework how UuidAttr, CXXUuidofExpr, and GUID template arguments and constants are represented.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbab6df86aefc: Rework how UuidAttr, CXXUuidofExpr, and GUID template arguments and constants… (authored by rsmith). Changed prior to commit: https://reviews.llvm.org/D78171?vs=257565&id=257808#toc Repos

[PATCH] D78171: Rework how UuidAttr, CXXUuidofExpr, and GUID template arguments and constants are represented.

rsmith marked an inline comment as done. rsmith added inline comments. Comment at: clang/lib/AST/Decl.cpp:897-898 +// Fall through. +// FIXME: Should GUIDs receive hidden visibility? We give them DSO-local +// linkage in CodeGen. + rnk wrote: > I supp

[PATCH] D78204: [AArch64][SVE] Remove LD1/ST1 dependency on llvm.masked.load/store

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. Practically, I'm not sure you're really getting much benefit out of this; there's very little common code that touches MLOAD/MSTORE nodes anyway. But, sure, LGTM. Repository: rG LLVM

[PATCH] D78232: [OPENMP50]Codegen for scan directive in simd loops.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: arphaman, guansong, yaxunl, jholewinski. Herald added a project: clang. Added codegen for scandirectives in simd loop. The codegen transforms original code: int x = 0; #pragma omp simd reduction(ins

[PATCH] D78233: [NFC] Correcting minor typo.

ncv created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. ncv added a reviewer: xazax.hun. Herald added a subscriber: rnkovacs. Hande -> Handle Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D78233 Files: clang/lib/Sema/SemaDeclAttr.cpp

[PATCH] D75184: [clang-tidy] Optional inheritance of file configs from parent directories 

DmitryPolukhin added a comment. @thakis, I don't see this bot on LLVM http://lab.llvm.org:8011/console Windows bots there still fail due to cmake issues. The issue is very real and thank you for pointing out but how should I find the bot? Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D76389: [NewPM] Run the Speculative Execution Pass only if the target has divergent branches

leonardchan updated this revision to Diff 257800. leonardchan marked an inline comment as done. leonardchan edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76389/new/ https://reviews.llvm.org/D76389 Files: llvm/l

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Oh, and this patch LGTM, thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76384/new/ https://reviews.llvm.org/D76384

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

rjmccall added a comment. In D76384#1984498 , @mibintc wrote: > Responding to @rjmccall 's review. John, after this is approved I want to > proceed with pragma float_control as proposed in D72841 > . Can you recommend an

[PATCH] D75184: [clang-tidy] Optional inheritance of file configs from parent directories 

DmitryPolukhin added a comment. @thakis sorry, I didn't notice the issue because of massive breakage with diff landed just be bore mine and also cmake issues on Windows bots. Thank you for trying to fix it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D78125: [AVR] Use the correct address space for non-prototyped function calls

rjmccall accepted this revision. rjmccall added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78125/new/ https://reviews.llvm.org/D78125 ___ cfe-commits mailing list cfe-commits@lists.

[clang] bab6df8 - Rework how UuidAttr, CXXUuidofExpr, and GUID template arguments and constants are represented.

Author: Richard Smith Date: 2020-04-15T12:20:42-07:00 New Revision: bab6df86aefc5ea4aa3895da7cf46be37add676d URL: https://github.com/llvm/llvm-project/commit/bab6df86aefc5ea4aa3895da7cf46be37add676d DIFF: https://github.com/llvm/llvm-project/commit/bab6df86aefc5ea4aa3895da7cf46be37add676d.diff

[PATCH] D61716: [libclang] Expose AtomicType

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Do you need me to commit on your behalf? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61716/new/ https://reviews.llvm.org/D61716 __

[PATCH] D78098: [CGExprAgg] Fix infinite loop in `findPeephole`

ekatz updated this revision to Diff 257794. ekatz added a comment. Changed the name of the test file to pr45476.cpp. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78098/new/ https://reviews.llvm.org/D78098 Files: clang/lib/CodeGen/CGExprAgg.cpp clang/test/CodeGen/pr45476.cpp Inde

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc updated this revision to Diff 257789. mibintc added a comment. Responding to @rjmccall 's review. John, after this is approved I want to proceed with pragma float_control as proposed in D72841 . Can you recommend an approach, do you think I will need to

[PATCH] D77592: [NFC][CodeGen] Add enum for selecting the layout of components in the vtable

leonardchan updated this revision to Diff 257786. leonardchan retitled this revision from "[NFC}[CodeGen] Make VTable initialization a method of CGCXXABI" to "[NFC][CodeGen] Add enum for selecting the layout of components in the vtable". leonardchan edited the summary of this revision. leonardcha

[PATCH] D77461: [WIP][clang-tidy] Remove false positive in AvoidNonConstGlobalVariables

aaron.ballman closed this revision. aaron.ballman added a comment. I've commit on your behalf in b2d8c89ea48beb83e0392b1f00c9eafa33c09ca8 , thank you for the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[clang-tools-extra] b2d8c89 - Remove false positive in AvoidNonConstGlobalVariables.

Author: Kim Viggedal Date: 2020-04-15T14:48:06-04:00 New Revision: b2d8c89ea48beb83e0392b1f00c9eafa33c09ca8 URL: https://github.com/llvm/llvm-project/commit/b2d8c89ea48beb83e0392b1f00c9eafa33c09ca8 DIFF: https://github.com/llvm/llvm-project/commit/b2d8c89ea48beb83e0392b1f00c9eafa33c09ca8.diff

[clang] 25db295 - [NFC] Silence compiler warning [-Wmissing-braces].

Author: Huihui Zhang Date: 2020-04-15T11:46:05-07:00 New Revision: 25db295756beffdeeb7e2efc134790c2d3f1ada9 URL: https://github.com/llvm/llvm-project/commit/25db295756beffdeeb7e2efc134790c2d3f1ada9 DIFF: https://github.com/llvm/llvm-project/commit/25db295756beffdeeb7e2efc134790c2d3f1ada9.diff

[PATCH] D78162: [CodeGen] Mark inline definitions of builtins as nobuiltin only if we plan to emit them.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2dd17ff08165: [CodeGen] only add nobuiltin to inline builtins if we'll emit them (authored by george.burgess.iv). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D78198: [Format] Work around current vim bugs in clang-format.py

This revision was automatically updated to reflect the committed changes. Closed by commit rG591be7ec500c: [Format] Work around current vim bugs in clang-format.py (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78198/new/ htt

[PATCH] D78223: [clang-tidy] performance-range-for-copy only for copy.

EricWF created this revision. EricWF added reviewers: fowles, shuaiwang. EricWF added a project: clang-tools-extra. Herald added subscribers: mgehre, xazax.hun. Currently the range-for-copy incorrectly suggests changing a by-value loop var to a reference to avoid copies even when: (1) A co

[PATCH] D70416: [Driver] Make -static-libgcc imply static libunwind

MaskRay closed this revision. MaskRay added a comment. Closed by 6551ac7489fe070a2edcfac88f68c93321cba9a9 The commit does not have `Differential Revision: ...` so the differential is not closed automatically. Repository:

[PATCH] D78139: [clang-tidy] modernize-use-using: Fix broken fixit with 'template' keyword

mgehre updated this revision to Diff 257774. mgehre marked an inline comment as done. mgehre added a comment. Implement review comments (Thanks!) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78139/new/ https://reviews.llvm.org/D78139 Files: cla

  1   2   3   >