[PATCH] D78491: Avoid relying on address space zero default parameter in llvm/IR

lebedev.ri added subscribers: llvm-commits, lebedev.ri. lebedev.ri added a comment. This should really be reviewed on llvm-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78491/new/ https://reviews.llvm.org/D78491

[PATCH] D78374: [Analyzer][StreamChecker] Added evaluation of fread and fwrite.

balazske added a comment. Finally I had to make the decision to remove the `ErrorKindTy` enum and use boolean flags instead for every possible error (including no error). This is needed because we do not know always what error is possible if it is "unknown". It could be determined from the last

[clang] e90fb82 - [AST] Suppress the spammy "attempt to use a deleted fucntion" diagnostic.

Author: Haojian Wu Date: 2020-04-21T09:43:46+02:00 New Revision: e90fb82f0f760703c14eafbad96c08b6019a2f0f URL: https://github.com/llvm/llvm-project/commit/e90fb82f0f760703c14eafbad96c08b6019a2f0f DIFF: https://github.com/llvm/llvm-project/commit/e90fb82f0f760703c14eafbad96c08b6019a2f0f.diff LO

[PATCH] D77392: [WIP][clangd] Make signatureHelp work with stale preambles

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/Preamble.cpp:281 + // We are only interested in newly added includes. + llvm::StringSet<> ExistingIncludes; + for (const auto &Inc : Preamble.LexedIncludes)

[PATCH] D77392: [WIP][clangd] Make signatureHelp work with stale preambles

kadircet updated this revision to Diff 258915. kadircet marked 2 inline comments as done. kadircet added a comment. - Make scanPreambleIncludes return an Expected> - Bail out in case of errors, document the rational. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D78100: [AST] Suppress the spammy "attempt to use a deleted fucntion" diagnostic.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe90fb82f0f76: [AST] Suppress the spammy "attempt to use a deleted fucntion" diagnostic. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D78100?vs=257689&id=258918#toc Repository

[clang-tools-extra] 6e01718 - [clangd] Store ppdirective in Inclusion

Author: Kadir Cetinkaya Date: 2020-04-21T10:27:26+02:00 New Revision: 6e017188b7607eb0f0b248881319bfd803cb8f78 URL: https://github.com/llvm/llvm-project/commit/6e017188b7607eb0f0b248881319bfd803cb8f78 DIFF: https://github.com/llvm/llvm-project/commit/6e017188b7607eb0f0b248881319bfd803cb8f78.dif

[clang] 2214b90 - [clangd] Make signatureHelp work with stale preambles

Author: Kadir Cetinkaya Date: 2020-04-21T10:27:26+02:00 New Revision: 2214b9076f1d3a4784820c4479e2417685e5c980 URL: https://github.com/llvm/llvm-project/commit/2214b9076f1d3a4784820c4479e2417685e5c980 DIFF: https://github.com/llvm/llvm-project/commit/2214b9076f1d3a4784820c4479e2417685e5c980.dif

[PATCH] D78235: [clangd] Store ppdirective in Inclusion

This revision was automatically updated to reflect the committed changes. Closed by commit rG6e017188b760: [clangd] Store ppdirective in Inclusion (authored by kadircet). Changed prior to commit: https://reviews.llvm.org/D78235?vs=257812&id=258926#toc Repository: rG LLVM Github Monorepo CHA

[PATCH] D77392: [clangd] Make signatureHelp work with stale preambles

This revision was automatically updated to reflect the committed changes. Closed by commit rG2214b9076f1d: [clangd] Make signatureHelp work with stale preambles (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77392/new/ https:/

[clang] 89d9912 - [AST] dont invaliate VarDecl when the initializer contains errors.

Author: Haojian Wu Date: 2020-04-21T10:53:35+02:00 New Revision: 89d9912cbf45068770ac8c1e2ef97b74c3b662ab URL: https://github.com/llvm/llvm-project/commit/89d9912cbf45068770ac8c1e2ef97b74c3b662ab DIFF: https://github.com/llvm/llvm-project/commit/89d9912cbf45068770ac8c1e2ef97b74c3b662ab.diff LO

[clang-tools-extra] 6b3168f - [clangd] Fix windows buildbots for #import statements

Author: Kadir Cetinkaya Date: 2020-04-21T10:56:34+02:00 New Revision: 6b3168f8cdb46656330929877b0b4daab35d30de URL: https://github.com/llvm/llvm-project/commit/6b3168f8cdb46656330929877b0b4daab35d30de DIFF: https://github.com/llvm/llvm-project/commit/6b3168f8cdb46656330929877b0b4daab35d30de.dif

[PATCH] D78511: [Driver][doc] Document option -mtune as a no-op. NFC.

psmith accepted this revision. psmith added a comment. This revision is now accepted and ready to land. That wording looks good to me. I've accepted the change, but worth waiting a day or so to see if there are any objections or suggestions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D76801: [AST] Print a> without extra spaces in C++11 or later.

labath added a comment. In D76801#1993337 , @dblaikie wrote: > In D76801#1991904 , @labath wrote: > > > David's example does work with gdb without -Wl,--gdb-index (the member > > variable is shown), presumably due

[PATCH] D78546: Enable bugprone-argument-comments check in llvm.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: llvm-commits, aheejin. Herald added a project: LLVM. LLVM code style encourages this [1], this check can detect the missing cases and provide an automatic fixit. [1] https://llvm.org/docs/CodingStandards.h

[PATCH] D78116: [AST] dont invaliate VarDecl when the initializer contains errors.

This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rG89d9912cbf45: [AST] dont invaliate VarDecl when the initializer contains errors. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D78116?v

[PATCH] D78511: [Driver][doc] Document option -mtune as a no-op. NFC.

SjoerdMeijer added a comment. Thank you both for reviewing! And I will wait a day. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78511/new/ https://reviews.llvm.org/D78511 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D78521: [clangd] Extend dexp to support remote index

kbobyrev updated this revision to Diff 258936. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Implement refs(), address some comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78521/new/ https://reviews.llvm.org/D78521 F

[PATCH] D69987: [RISCV] Assemble/Disassemble v-ext instructions.

simoncook added a reviewer: simoncook. simoncook added a comment. This is looking good, overall the patch is nicely laid out which has made it easy to compare against the spec. I've made a few comments, mostly about ordering of instructions so that they are identical to the spec. One question,

[clang-tools-extra] 4ccafab - [clangd] Change field name to prevent shadowing

Author: Kadir Cetinkaya Date: 2020-04-21T11:57:59+02:00 New Revision: 4ccafab0769ffaf1aee1c727ee5b733ce7907594 URL: https://github.com/llvm/llvm-project/commit/4ccafab0769ffaf1aee1c727ee5b733ce7907594 DIFF: https://github.com/llvm/llvm-project/commit/4ccafab0769ffaf1aee1c727ee5b733ce7907594.dif

[PATCH] D78521: [clangd] Extend dexp to support remote index

kbobyrev updated this revision to Diff 258942. kbobyrev added a comment. Add correct definition and fix build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78521/new/ https://reviews.llvm.org/D78521 Files: clang-tools-extra/clangd/CMakeLists.tx

[PATCH] D78365: [AST] Preserve the invalid initializer for auto VarDecl.

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:11852 + // There are unresolved typos in Init. Usually it indicates the + // initializer is very ill-formed, just drop it. RealDecl->setInvalidDecl(); -

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

martong added inline comments. Comment at: clang/include/clang/CrossTU/CrossTranslationUnit.h:56 + load_threshold_reached, + ambiguous_compile_commands_database }; xazax.hun wrote: > The two enum values refer to compilation database and compile command > data

[PATCH] D78533: [i386] Fix bug that get __m128/__m256/__m512 with wrong alignment for variadic functions.

RKSimon added a subscriber: cfe-commits. RKSimon added a comment. CCing cfe-commits CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78533/new/ https://reviews.llvm.org/D78533 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D78509: [AArch64][SVE] Add addressing mode for contiguous loads & stores

kmclaughlin updated this revision to Diff 258954. kmclaughlin marked 5 inline comments as done. kmclaughlin added a comment. - Renamed ld1nf multiclass to ldnf1 - Split out existing reg+imm tests into their own files - Renamed 'offset' to 'index' in reg+reg tests CHANGES SINCE LAST ACTION http

[PATCH] D78521: [clangd] Extend dexp to support remote index

kbobyrev updated this revision to Diff 258958. kbobyrev added a comment. Move type conversions to Marshalling.(h|cpp) and hide IndexClient behind a factory function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78521/new/ https://reviews.llvm.org

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

xazax.hun accepted this revision. xazax.hun added a comment. Ok, looks good to me. The minor nit regarding the naming is easy to fix before commit. The design question I had is not a blocker, my suggested alternative can be implemented later (if desired) in a backward-compatible way from the us

[PATCH] D77735: [SveEmitter] Implement builtins for gathers/scatters

andwar added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:7458 +llvm_unreachable("Invalid SVETypeFlag!"); + + case SVETypeFlags::EltTyInt8: SjoerdMeijer wrote: > nit: no need for the newlines here and also below? IMHO this improves readabilit

[PATCH] D78509: [AArch64][SVE] Add addressing mode for contiguous loads & stores

kmclaughlin added a comment. Thanks for taking a look at this, @fpetrogalli! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78509/new/ https://reviews.llvm.org/D78509 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D78491: Avoid relying on address space zero default parameter in llvm/IR

dylanmckay added a comment. > should help targets such as AVR than use a non-zero program address space. It definitely will - we have the exact same problems in terms of every call to `getUnqual` on a function pointer becomes a ISel error. > I think making such bugs a compilation failure should

[clang-tools-extra] 5a68138 - [clangd] Add icon to VSCode extension, and fix URLs

Author: Sam McCall Date: 2020-04-21T13:40:47+02:00 New Revision: 5a68138403c85c66c367b650a456b915e2636ae0 URL: https://github.com/llvm/llvm-project/commit/5a68138403c85c66c367b650a456b915e2636ae0 DIFF: https://github.com/llvm/llvm-project/commit/5a68138403c85c66c367b650a456b915e2636ae0.diff LO

[PATCH] D78509: [AArch64][SVE] Add addressing mode for contiguous loads & stores

This revision was automatically updated to reflect the committed changes. Closed by commit rG0df40d6ef8b8: [AArch64][SVE] Add addressing mode for contiguous loads & stores (authored by kmclaughlin). Changed prior to commit: https://reviews.llvm.org/D78509?vs=258954&id=258965#toc Repository:

[PATCH] D75430: [analyzer][NFC] Introduce CXXDeallocatorCall, deploy it in MallocChecker

Szelethus added a comment. Ping^2 :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75430/new/ https://reviews.llvm.org/D75430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[PATCH] D77735: [SveEmitter] Implement builtins for gathers/scatters

sdesmalen accepted this revision. sdesmalen added a comment. LGTM! Cheers @andwar Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77735/new/ https://reviews.llvm.org/D77735 ___ cfe-commits mailing list c

[clang-tools-extra] f5b0591 - [clangd] Bump VSCode version number to allow republish (icon-only change).

Author: Sam McCall Date: 2020-04-21T16:09:26+02:00 New Revision: f5b05915523a6faef16963a5b0f40037ed90dadc URL: https://github.com/llvm/llvm-project/commit/f5b05915523a6faef16963a5b0f40037ed90dadc DIFF: https://github.com/llvm/llvm-project/commit/f5b05915523a6faef16963a5b0f40037ed90dadc.diff LO

[PATCH] D76932: [AIX] emit .extern and .weak directive linkage

hubert.reinterpretcast added inline comments. Comment at: llvm/test/CodeGen/PowerPC/aix-extern-weak.ll:9 +; RUN: -mattr=-altivec -filetype=obj -o %t.o < %s +; RUN: llvm-readobj --symbols %t.o | FileCheck --check-prefix=CHECKSYM %s + No need for two consecutive s

[PATCH] D78563: [AIX] Port power alignment rules to clang

Xiangling_L created this revision. Xiangling_L added reviewers: jasonliu, hubert.reinterpretcast, sfertile. Xiangling_L added a project: LLVM. Herald added a project: clang. Herald added a subscriber: cfe-commits. Address the following aspects of power alignment rules: - Implemented double/long d

[PATCH] D78533: [i386] Fix bug that get __m128/__m256/__m512 with wrong alignment for variadic functions.

LiuChen3 added a comment. I uploaded a new patch D78564 as another solution, but it modified the current clang calling convention. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78533/new/ https://reviews.llvm.org/D78533 _

[PATCH] D78565: [clang][doc] Clang ARM CPU command line argument reference

SjoerdMeijer created this revision. SjoerdMeijer added reviewers: psmith, ostannard, kristof.beyls, chill. Herald added subscribers: danielkiss, arphaman. Following the discussion about -mtune on the cfe dev list, I thought it would be good to make a start with documenting common command line arg

[PATCH] D78567: C++2a -> C++20 in some identifiers; NFC

aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, dblaikie, echristo. Herald added subscribers: martong, kbarton, nemanjai. This does not hit all of the C++2a -> C++20 changes, but gets all of the ones related to the language options and keywords. https://reviews.llvm.

[PATCH] D78565: [clang][doc] Clang ARM CPU command line argument reference

psmith added a comment. One question I can't answer and I think would need wider review, is whether this is type of material (common options for specific CPUs) is suited for the Clang Documentation or whether it would be better hosted by Arm itself, for example on developer.arm.com? I think tha

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

whisperity added inline comments. Comment at: clang/docs/analyzer/user-docs/CrossTranslationUnit.rst:21 + +PCH based analysis +__ I think it's PCH-based with a -. Comment at: clang/docs/analyzer/user-docs/CrossTranslationUnit.rs

[PATCH] D77062: [analyzer] Added check for unacceptable equality operation between Loc and NonLoc types

ASDenysPetrov added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77062/new/ https://reviews.llvm.org/D77062 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D78252: [AArch64] FMLA/FMLS patterns improvement.

ilinpv updated this revision to Diff 259008. ilinpv edited the summary of this revision. ilinpv added a comment. v2f32 pattern removed, test added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78252/new/ https://reviews.llvm.org/D78252 Files: c

[PATCH] D78565: [clang][doc] Clang ARM CPU command line argument reference

SjoerdMeijer added a comment. Hi Peter, Thanks for reviewing again! I thought these examples to be relevant here, because it shows usage and examples of this tool (i.e. open-source clang/llvm). Additional benefits is that source and documentation is in one place, and it allows others, non-Arm p

[PATCH] D78252: [AArch64] FMLA/FMLS patterns improvement.

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. LGTM. Thanks Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:8094 V128:$Rm, VectorIndexS:$idx)>; - def : Pat<(f32 (OpNode (f32 FPR32:$Rd), (f32

[PATCH] D78569: [SVE][CodeGen] Lower SDIV & UDIV to SVE intrinsics

kmclaughlin created this revision. kmclaughlin added reviewers: sdesmalen, c-rhodes, efriedma, cameron.mcinally. Herald added subscribers: psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a project: LLVM. This patch maps IR operations for sdiv &

[PATCH] D78572: [Clang][Sema] Capturing section type conflicts on #pragma clang section

pratlucas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Section names used in clang section pragmas were not validated against previously defined sections, causing section type conflicts to be ignored by Sema. This patch enables Clang to capture the

[PATCH] D78573: [Clang][Sema] Capturing section type conflicts between #pragma clang section and section attributes

pratlucas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Conflicting types for the same section name defined in clang section pragmas and GNU-style section attributes were not properly captured by Clang's Sema. The lack of diagnostics was caused by th

[PATCH] D78572: [Clang][Sema] Capturing section type conflicts on #pragma clang section

pratlucas updated this revision to Diff 259039. pratlucas added a comment. Fixing missing clang-format messages. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78572/new/ https://reviews.llvm.org/D78572 Files: clang/include/clang/AST/ASTContext.h

[PATCH] D78573: [Clang][Sema] Capturing section type conflicts between #pragma clang section and section attributes

pratlucas updated this revision to Diff 259040. pratlucas added a comment. Fixing "mising clang-format" messages. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78573/new/ https://reviews.llvm.org/D78573 Files: clang/include/clang/AST/ASTContext.

[PATCH] D78478: [UpdateTestChecks] Add UTC_ARGS support for update_{llc,cc}_test_checks.py

jdoerfert added a comment. I feel there is a lot of good stuff here but it seems to mix two things. A rewrite of the script infrastructure and the UTC_ARGS stuff. If so, do you think we could split them? I feel there are also minor NFC changes that could go in on their own without review, I mar

[PATCH] D76932: [AIX] emit .extern and .weak directive linkage

hubert.reinterpretcast added inline comments. Comment at: llvm/test/CodeGen/PowerPC/aix-extern-weak.ll:174 +; CHECKSYM-NEXT: Index: [[#Index+11]] +; CHECKSYM-NEXT: ContainingCsectSymbolIndex: 8 +; CHECKSYM-NEXT: ParameterHashIndex: 0x0 This shou

[PATCH] D76929: [AArch64][SVE] Add SVE intrinsic for LD1RQ

kmclaughlin added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:11622 + if (VT.isFloatingPoint()) +Load = DAG.getNode(ISD::BITCAST, DL, VT, Load); + sdesmalen wrote: > kmclaughlin wrote: > > sdesmalen wrote: > > > I'd expect th

[PATCH] D76929: [AArch64][SVE] Add SVE intrinsic for LD1RQ

kmclaughlin updated this revision to Diff 259035. kmclaughlin marked an inline comment as done. kmclaughlin added a comment. - Use Load.getValue(0) when creating a bitcast in performLD1RQCombine CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76929/new/ https://reviews.llvm.org/D76929 Fi

[PATCH] D78534: [libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON

zhuhan0 updated this revision to Diff 259043. zhuhan0 added a comment. Spacing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78534/new/ https://reviews.llvm.org/D78534 Files: clang/cmake/modules/AddClang.cmake Index: clang/cmake/modules/AddCla

[clang] be881e2 - [AArch64] FMLA/FMLS patterns improvement.

Author: Pavel Iliin Date: 2020-04-21T18:23:21+01:00 New Revision: be881e2831735d6879ee43710f5a4d1c8d50c615 URL: https://github.com/llvm/llvm-project/commit/be881e2831735d6879ee43710f5a4d1c8d50c615 DIFF: https://github.com/llvm/llvm-project/commit/be881e2831735d6879ee43710f5a4d1c8d50c615.diff L

[PATCH] D78569: [SVE][CodeGen] Lower SDIV & UDIV to SVE intrinsics

efriedma added a comment. I'd prefer to handle legalization in a separate patch from handling legal sdiv/udiv operations, so we actually have some context to discuss the legalization strategy. Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:7670 +

[PATCH] D78573: [Clang][Sema] Capturing section type conflicts between #pragma clang section and section attributes

pratlucas updated this revision to Diff 259048. pratlucas added a comment. Removing unnecessary function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78573/new/ https://reviews.llvm.org/D78573 Files: clang/include/clang/AST/ASTContext.h clan

[PATCH] D73307: Unique Names for Functions with Internal Linkage

tmsriram marked 3 inline comments as done. tmsriram added a comment. @rnk Good now? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73307/new/ https://reviews.llvm.org/D73307 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D68049: Propeller: Clang options for basic block sections

tmsriram marked an inline comment as done. tmsriram added inline comments. Comment at: clang/include/clang/Driver/Options.td:1975 +def fbasicblock_sections_EQ : Joined<["-"], "fbasicblock-sections=">, Group, Flags<[CC1Option, CC1AsOption]>, + HelpText<"Place each function's bas

[PATCH] D76932: [AIX] emit .extern and .weak directive linkage

DiggerLin marked 2 inline comments as done. DiggerLin added inline comments. Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:2146 } } hubert.reinterpretcast wrote: > Replicate the > ``` > llvm_unreachable("Unknown linkage type!"); > ``` > here

[PATCH] D76801: [AST] Print a> without extra spaces in C++11 or later.

dblaikie added a comment. In D76801#1994003 , @labath wrote: > In D76801#1993337 , @dblaikie wrote: > > > In D76801#1991904 , @labath wrote: > > > > > David's example does wo

[PATCH] D76932: [AIX] emit .extern and .weak directive linkage

DiggerLin updated this revision to Diff 259057. DiggerLin marked an inline comment as done. DiggerLin added a comment. address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76932/new/ https://reviews.llvm.org/D76932 Files: clang/lib/Driv

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware updated this revision to Diff 259060. baloghadamsoftware added a comment. My first attempt for a new special kind of region for parameters of functions without definitions. Currently it causes more failed tests and assertions than ignoring the problem of different `Decl`s. I w

[PATCH] D78513: [hip] Claim builtin type `__float128` supported if the host target supports it.

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78513/new/ https://reviews.llvm.org/D78513 __

[PATCH] D78030: [TimeProfiler] Emit clock synchronization point

broadwaylamb added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78030/new/ https://reviews.llvm.org/D78030 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D78567: C++2a -> C++20 in some identifiers; NFC

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Herald added a subscriber: wuzish. Sounds good! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78567/new/ https://reviews.llvm.org/D78567 ___

[PATCH] D78252: [AArch64] FMLA/FMLS patterns improvement.

ilinpv closed this revision. ilinpv added a comment. Committed be881e2831735d6879ee43710f5a4d1c8d50c615 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78252/new/ https://reviews.

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

atmnpatel marked an inline comment as done and an inline comment as not done. atmnpatel added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:3211-3213 + VD->getStorageClass() == SC_Static && + (CanonicalVD->getDeclContext()->isNamespace() || +

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

atmnpatel updated this revision to Diff 259073. atmnpatel marked 3 inline comments as done. atmnpatel added a comment. Addresses inline comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75591/new/ https://reviews.llvm.org/D75591 Files: cla

[clang] 6a30894 - C++2a -> C++20 in some identifiers; NFC.

Author: Aaron Ballman Date: 2020-04-21T15:37:19-04:00 New Revision: 6a30894391ca671bab16c505eff30c7819bd8e8e URL: https://github.com/llvm/llvm-project/commit/6a30894391ca671bab16c505eff30c7819bd8e8e DIFF: https://github.com/llvm/llvm-project/commit/6a30894391ca671bab16c505eff30c7819bd8e8e.diff

[clang] 86e3b73 - [hip] Claim builtin type `__float128` supported if the host target supports it.

Author: Michael Liao Date: 2020-04-21T15:56:40-04:00 New Revision: 86e3b735cd803cc22c9eae15d99ce9df5956aae6 URL: https://github.com/llvm/llvm-project/commit/86e3b735cd803cc22c9eae15d99ce9df5956aae6 DIFF: https://github.com/llvm/llvm-project/commit/86e3b735cd803cc22c9eae15d99ce9df5956aae6.diff

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:3211-3213 + VD->getStorageClass() == SC_Static && + (CanonicalVD->getDeclContext()->isNamespace() || + !VD->isLocalVarDeclOrParm())) { atmnpatel wrote: > ABataev

[PATCH] D78134: [Sema] Don't apply an lvalue-to-rvalue conversion to a discarded-value expression if it has an array type

ahatanak updated this revision to Diff 259081. ahatanak added a comment. Make Sema::DefaultLvalueConversion ignore gl-values of array type Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78134/new/ https://reviews.llvm.org/D78134 Files: clang/incl

[PATCH] D78567: C++2a -> C++20 in some identifiers; NFC

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks! I've committed in 6a30894391ca671bab16c505eff30c7819bd8e8e . If I get a spare moment, I may do this dance again with diagnostic identifers as well. CH

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

atmnpatel marked 2 inline comments as done. atmnpatel added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:3211-3213 + VD->getStorageClass() == SC_Static && + (CanonicalVD->getDeclContext()->isNamespace() || + !VD->isLocalVarDeclOrParm()))

[PATCH] D78569: [SVE][CodeGen] Lower SDIV & UDIV to SVE intrinsics

sdesmalen added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:7670 + Mask, Op.getOperand(0), Op.getOperand(1)); +} + efriedma wrote: > If we're going to support these operations, we might as well just add isel >

[PATCH] D76929: [AArch64][SVE] Add SVE intrinsic for LD1RQ

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76929/new/ https://reviews.llvm.org/D76929 ___ cfe-commits mailing list cfe-co

[PATCH] D78513: [hip] Claim builtin type `__float128` supported if the host target supports it.

This revision was automatically updated to reflect the committed changes. Closed by commit rG86e3b735cd80: [hip] Claim builtin type `__float128` supported if the host target supports it. (authored by hliao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:3211-3213 + VD->getStorageClass() == SC_Static && + (CanonicalVD->getDeclContext()->isNamespace() || + !VD->isLocalVarDeclOrParm())) { atmnpatel wrote: > ABataev

[PATCH] D78569: [SVE][CodeGen] Lower SDIV & UDIV to SVE intrinsics

efriedma added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:7670 + Mask, Op.getOperand(0), Op.getOperand(1)); +} + sdesmalen wrote: > efriedma wrote: > > If we're going to support these operations, we might as w

[PATCH] D77233: [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec.

plotfi added a comment. @erik.pilkington @arphaman ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77233/new/ https://reviews.llvm.org/D77233 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D78563: [AIX] Port power alignment rules to clang

jasonliu added inline comments. Comment at: clang/test/Layout/aix-double-struct-member.cpp:136 +// CHECK-NEXT:| nvsize=12, nvalign=4] +}; // namespace test4 1. I think we also want to test empty base class with a derived class contains double as fir

[PATCH] D78563: [AIX] Port power alignment rules to clang

jasonliu added inline comments. Comment at: clang/include/clang/AST/RecordLayout.h:177 + /// getAIXOffsetAlignment - Get the record of aixOffset alignment in + /// characters. Not sure if aixOffset is a thing? Might be better to just say "aix offset alignmen

[PATCH] D77168: Add a flag to debug automatic variable initialization

jcai19 added a comment. > I'd also like to see the pragma attribute approach, as well as byte-pattern > variability as I described. I don't think auto-narrowing is the only approach > we should push people towards. Thank you for all the feedback. I agree, the pragma attribute and the byte-pat

[PATCH] D78563: [AIX] Port power alignment rules to clang

jasonliu added inline comments. Comment at: clang/include/clang/AST/RecordLayout.h:81 + /// AIXOffsetAlignment - The special AIX Alignment for the object that + /// contains floating-point member or sub-member. This is for AIX-abi only. AIX Alignment -> AIX a

[PATCH] D73846: [PCH] make sure to not warn about unused macros from -D

llunak added a comment. In D73846#1991330 , @rsmith wrote: > Looks OK as a workaround. Do you know why we consider these to be in the main > file? If we could fix that in the source manager, that'd seem preferable. According to my testing, SourceManager

[PATCH] D78000: [ASTImporter] Fix handling of not defined FromRecord in ImportContext(...)

shafik updated this revision to Diff 259110. shafik marked 2 inline comments as done. shafik added a comment. - Simplifying the changes in `ASTImporter::ImportContext` - Removing `DC->setHasExternalLexicalStorage(true);` from unit test since we are checking `getExternalSource()` CHANGES SINCE L

[clang] d892eec - Reapply: Make header inclusion order from umbrella dirs deterministic

Author: Bruno Cardoso Lopes Date: 2020-04-21T15:45:54-07:00 New Revision: d892eec710caae84099f38fdb89d32ca15a23c1a URL: https://github.com/llvm/llvm-project/commit/d892eec710caae84099f38fdb89d32ca15a23c1a DIFF: https://github.com/llvm/llvm-project/commit/d892eec710caae84099f38fdb89d32ca15a23c1a

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

atmnpatel added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:3211-3213 + VD->getStorageClass() == SC_Static && + (CanonicalVD->getDeclContext()->isNamespace() || + !VD->isLocalVarDeclOrParm())) { ABataev wrote: > atmnpate

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

atmnpatel updated this revision to Diff 259122. atmnpatel added a comment. Add capture by value for scalars. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75591/new/ https://reviews.llvm.org/D75591 Files: clang-tools-extra/docs/clang-tidy/checks

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

atmnpatel added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:2016-2023 + if (DSAStack->getDefaultDSA() == DSA_firstprivate && + VarsWithInheritedDSAType().count(D) == 0 && + !DSAStack->hasExplicitDSA( + D, [](OpenMPClauseKind K) -> bool { return

[PATCH] D77621: ADT: SmallVector size & capacity use word-size integers when elements are small.

browneee added a comment. Thanks for the revert explanation and notes, nikic. @dexonsmith what is your current thinking on going back to the original std::vector approach? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77621/new/ https://reviews.l

[PATCH] D78598: [clangd] Remove vscode plugin: now https://github.com/clangd/vscode-clangd

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Moving this out of the monorepo for consistency with other editor plugins. There's no version

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

NoQ added a comment. In D77229#1995079 , @baloghadamsoftware wrote: > My first attempt for a new special kind of region for parameters of functions > without definitions. Currently it causes more failed tests and assertions > than ignoring the problem o

[clang] 4ca2cad - [PowerPC] Add clang -msvr4-struct-return for 32-bit ELF

Author: Justin Hibbits Date: 2020-04-21T20:17:25-05:00 New Revision: 4ca2cad947d09ba0402f5b85d165aa7fcfbd9e3e URL: https://github.com/llvm/llvm-project/commit/4ca2cad947d09ba0402f5b85d165aa7fcfbd9e3e DIFF: https://github.com/llvm/llvm-project/commit/4ca2cad947d09ba0402f5b85d165aa7fcfbd9e3e.diff

[PATCH] D72893: [NewPassManager] Add assertions when getting statefull cached analysis.

chandlerc added a comment. Really like the approach now. Pretty minor code nits below only. =D Comment at: llvm/include/llvm/Analysis/CGSCCPassManager.h:856-858 +auto *ResultFAMCP = +&CGAM.getResult(*C, CG); +ResultFAMCP->updateFAM(FAM);

[PATCH] D73290: [PowerPC] Add clang -msvr4-struct-return for 32-bit ELF

This revision was automatically updated to reflect the committed changes. Closed by commit rG4ca2cad947d0: [PowerPC] Add clang -msvr4-struct-return for 32-bit ELF (authored by jhibbits). Changed prior to commit: https://reviews.llvm.org/D73290?vs=239982&id=259143#toc Repository: rG LLVM Gith

[PATCH] D78232: [OPENMP50]Codegen for scan directive in simd loops.

jdoerfert added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.h:1351 +Exclusive, +Unknown, + }; I think it is not `Unknown` but `None` (or similar) as we know that it is not a scan reduction. Comment at: clang/lib/Cod

  1   2   >