[clang] 6288292 - SymbolManager::SymbolDependencies: Use unique_ptr to simplify memory management

Author: David Blaikie Date: 2020-04-28T22:31:17-07:00 New Revision: 628829254d35bd3dfd1bff29f8afeaf464aafde9 URL: https://github.com/llvm/llvm-project/commit/628829254d35bd3dfd1bff29f8afeaf464aafde9 DIFF: https://github.com/llvm/llvm-project/commit/628829254d35bd3dfd1bff29f8afeaf464aafde9.diff

[clang] e265f92 - AnalysisDeclContext::ManagedAnalyses: Use unique_ptr to simplify memory management

Author: David Blaikie Date: 2020-04-28T22:31:16-07:00 New Revision: e265f92b6e5e56b21fefdb83aec90f6e39c94857 URL: https://github.com/llvm/llvm-project/commit/e265f92b6e5e56b21fefdb83aec90f6e39c94857 DIFF: https://github.com/llvm/llvm-project/commit/e265f92b6e5e56b21fefdb83aec90f6e39c94857.diff

[clang] fcee807 - ASTContext::OMPTraitInfoVector: Use unique_ptr to simplify memory management

Author: David Blaikie Date: 2020-04-28T22:31:16-07:00 New Revision: fcee80737c3272dc9de2dfd9635a1e90db215c7a URL: https://github.com/llvm/llvm-project/commit/fcee80737c3272dc9de2dfd9635a1e90db215c7a DIFF: https://github.com/llvm/llvm-project/commit/fcee80737c3272dc9de2dfd9635a1e90db215c7a.diff

[clang] 9b77242 - CodeGenTypes::CGRecordLayouts: Use unique_ptr to simplify memory management

Author: David Blaikie Date: 2020-04-28T22:31:16-07:00 New Revision: 9b77242c9a0089dca1ac4f80420b29492c5ed555 URL: https://github.com/llvm/llvm-project/commit/9b77242c9a0089dca1ac4f80420b29492c5ed555 DIFF: https://github.com/llvm/llvm-project/commit/9b77242c9a0089dca1ac4f80420b29492c5ed555.diff

[PATCH] D78827: Add support for #pragma clang fp allow_reassociation(on|off) -- floating point control of associative math transformations

sepavloff added inline comments. Comment at: clang/docs/LanguageExtensions.rst:3159 +controlled with this pragma. +``#pragma clang fp allow_reassociation`` allows control over the reassociation +of floating point expressions. When enabled, this pragma allows the expression

[clang] cbae0d8 - BugReporter::StrBugTypes: Use unique_ptr to simplify memory management

Author: David Blaikie Date: 2020-04-28T22:31:16-07:00 New Revision: cbae0d8221c7a5de229913754d4a6bf562a7db67 URL: https://github.com/llvm/llvm-project/commit/cbae0d8221c7a5de229913754d4a6bf562a7db67 DIFF: https://github.com/llvm/llvm-project/commit/cbae0d8221c7a5de229913754d4a6bf562a7db67.diff

[clang] 4bd5fbe - PragmaNamespace::Handlers: Use unique_ptr to simplify memory management

Author: David Blaikie Date: 2020-04-28T22:31:15-07:00 New Revision: 4bd5fbec4bef71d79cbcd916237c8c7b467fb782 URL: https://github.com/llvm/llvm-project/commit/4bd5fbec4bef71d79cbcd916237c8c7b467fb782 DIFF: https://github.com/llvm/llvm-project/commit/4bd5fbec4bef71d79cbcd916237c8c7b467fb782.diff

[PATCH] D78350: [AST] Build recovery expressions by default for C++.

hubert.reinterpretcast added a comment. In D78350#2007065 , @hokein wrote: > In D78350#2006469 , > @hubert.reinterpretcast wrote: > > > Got it. I'll put together a build. > > > Thank you! Look forward to the

[PATCH] D78970: [CUDA][HIP] Fix ambiguity of new operator

yaxunl closed this revision. yaxunl added a comment. committed by 55bcb96f3154808bcb5afc3fb46d8e00bf1db847 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78970/new/ https://reviews.llvm.org/D78970

[PATCH] D78534: [libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON

zhuhan0 added a comment. Thanks @hans My bad. Didn't test this when LLVM_ENABLE_PIC=OFF. Submitted D79059 to better solve this problem. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78534/new/

[PATCH] D79059: Fix and re-submit D78534 - [libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON

zhuhan0 updated this revision to Diff 260818. zhuhan0 edited the summary of this revision. zhuhan0 added a comment. Spacing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79059/new/ https://reviews.llvm.org/D79059 Files:

[PATCH] D79052: [clang codegen] Fix alignment of "Address" for incomplete array pointer.

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:176 CharUnits Alignment; - if (T->isIncompleteType()) { + if (T->getBaseElementTypeUnsafe()->isIncompleteType()) { Alignment = CharUnits::One(); // Shouldn't be used, but pessimistic is

[PATCH] D78756: [SveEmitter] Add builtins for svreinterpret

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:7880 +return Builder.CreateBitCast(Val, Ty); + } + I'm vaguely suspicious this might be wrong for big-endian targets. I mean, this isn't unreasonable, but users might be surprised

[PATCH] D78677: [SveEmitter] Add builtins for gather prefetches

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM with one minor comment Comment at: clang/lib/CodeGen/CGBuiltin.cpp:7739 + +// Index needs to be passed as scaled offset. +llvm::Type *MemEltTy =

[PATCH] D79059: Fix and re-submit D78534 - [libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON

zhuhan0 created this revision. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. zhuhan0 edited the summary of this revision. D78354 enabled installing PIC version of both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC is ON.

[clang] 0a088ea - Improve diagnostics for missing import / #include of module.

Author: Richard Smith Date: 2020-04-28T18:41:14-07:00 New Revision: 0a088ead85fae11bb41d8a93ebe213db5554f087 URL: https://github.com/llvm/llvm-project/commit/0a088ead85fae11bb41d8a93ebe213db5554f087 DIFF: https://github.com/llvm/llvm-project/commit/0a088ead85fae11bb41d8a93ebe213db5554f087.diff

[clang-tools-extra] 216833b - Revert "Temporarily revert "build: use `find_package(Python3)` if available""

Author: Saleem Abdulrasool Date: 2020-04-29T01:38:08Z New Revision: 216833b32befd14079130a3b857906f4e301179c URL: https://github.com/llvm/llvm-project/commit/216833b32befd14079130a3b857906f4e301179c DIFF: https://github.com/llvm/llvm-project/commit/216833b32befd14079130a3b857906f4e301179c.diff

[PATCH] D78982: [clang-format] Fix Microsoft style for C++ enums

asmith updated this revision to Diff 260814. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78982/new/ https://reviews.llvm.org/D78982 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h clang/lib/Format/Format.cpp

[PATCH] D78982: [clang-format] Fix Microsoft style for C++ enums

asmith updated this revision to Diff 260812. asmith retitled this revision from "[clang-format] Fix Microsoft style for enums" to "[clang-format] Fix Microsoft style for C++ enums". asmith edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78982/new/

[clang] 409df39 - ASTWriter::FileDeclIDs: Use unique_ptr to simplify memory management

Author: David Blaikie Date: 2020-04-28T18:05:28-07:00 New Revision: 409df3987cb8d6c4a9005b2e633d0116c315375d URL: https://github.com/llvm/llvm-project/commit/409df3987cb8d6c4a9005b2e633d0116c315375d DIFF: https://github.com/llvm/llvm-project/commit/409df3987cb8d6c4a9005b2e633d0116c315375d.diff

[clang] d9485df - ASTUnit::FileDecls: Use unique_ptr to simplify memory management

Author: David Blaikie Date: 2020-04-28T17:59:45-07:00 New Revision: d9485dfbc12b277e4ba222f4c0e371c5914fe51e URL: https://github.com/llvm/llvm-project/commit/d9485dfbc12b277e4ba222f4c0e371c5914fe51e DIFF: https://github.com/llvm/llvm-project/commit/d9485dfbc12b277e4ba222f4c0e371c5914fe51e.diff

[PATCH] D78890: [clang-tidy] Add check callee-namespace.

PaulkaToast updated this revision to Diff 260805. PaulkaToast marked 3 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78890/new/ https://reviews.llvm.org/D78890 Files: clang-tools-extra/clang-tidy/llvmlibc/CMakeLists.txt

[PATCH] D78890: [clang-tidy] Add check callee-namespace.

PaulkaToast added inline comments. Comment at: clang-tools-extra/clang-tidy/llvmlibc/CalleeNamespaceCheck.cpp:52-53 + + diag(FuncDecl->getLocation(), + "currently resolves to: ", clang::DiagnosticIDs::Note); +} aaron.ballman wrote: > PaulkaToast wrote: >

[PATCH] D78890: [clang-tidy] Add check callee-namespace.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8683f5de5352: [clang-tidy] Add check callee-namespace. (authored by PaulkaToast). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78890/new/

[PATCH] D79052: [clang codegen] Fix alignment of "Address" for incomplete array pointer.

efriedma marked an inline comment as done. efriedma added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:176 CharUnits Alignment; - if (T->isIncompleteType()) { + if (T->getBaseElementTypeUnsafe()->isIncompleteType()) { Alignment = CharUnits::One();

[clang] c98a7e9 - AllocatedCXCodeCompleteResults::DiagnosticWrappers: use unique_ptr to simplify memory management

Author: David Blaikie Date: 2020-04-28T17:45:07-07:00 New Revision: c98a7e9bcc26a13d5e0b3fd199a7d0298777d85e URL: https://github.com/llvm/llvm-project/commit/c98a7e9bcc26a13d5e0b3fd199a7d0298777d85e DIFF: https://github.com/llvm/llvm-project/commit/c98a7e9bcc26a13d5e0b3fd199a7d0298777d85e.diff

[clang-tools-extra] 8683f5d - [clang-tidy] Add check callee-namespace.

Author: Paula Toth Date: 2020-04-28T17:22:23-07:00 New Revision: 8683f5de535274398a82ed0a2c9f05648dc43f41 URL: https://github.com/llvm/llvm-project/commit/8683f5de535274398a82ed0a2c9f05648dc43f41 DIFF: https://github.com/llvm/llvm-project/commit/8683f5de535274398a82ed0a2c9f05648dc43f41.diff

[PATCH] D77168: Add a flag to debug automatic variable initialization

jcai19 updated this revision to Diff 260796. jcai19 added a comment. Update tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77168/new/ https://reviews.llvm.org/D77168 Files: clang/include/clang/Basic/LangOptions.def

[PATCH] D78750: [SveEmitter] Add builtins for svdupq and svdupq_lane

efriedma added a comment. Is there some reason you decided to implement these particular functions as inline functions directly in the header? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78750/new/ https://reviews.llvm.org/D78750

[PATCH] D77982: [Windows SEH] Fix the frame-ptr of a nested-filter within a _finally

tentzen added a comment. any more concern or comment? thanks, Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77982/new/ https://reviews.llvm.org/D77982 ___ cfe-commits mailing list

[PATCH] D79054: [NFC] Improve documentation for -i and update example git one liner

ctetreau added a comment. I considered trying to find a way to work around the issue. Something like "if the file is not found, and the current directory is `/foo/bar/`, and the computed filename is `bar/baz.c`, then use `/foo/bar/baz.c`". But I don't think there's any way we can reliably know

[PATCH] D79052: [clang codegen] Fix alignment of "Address" for incomplete array pointer.

efriedma created this revision. efriedma added a reviewer: rjmccall. Herald added a project: clang. rsmith added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:176 CharUnits Alignment; - if (T->isIncompleteType()) { + if

[PATCH] D79052: [clang codegen] Fix alignment of "Address" for incomplete array pointer.

rsmith added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:176 CharUnits Alignment; - if (T->isIncompleteType()) { + if (T->getBaseElementTypeUnsafe()->isIncompleteType()) { Alignment = CharUnits::One(); // Shouldn't be used, but pessimistic is

[PATCH] D79054: [NFC] Improve documentation for -i and update example git one liner

ctetreau created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. ctetreau added reviewers: djasper, alexfh. ctetreau added a comment. I considered trying to find a way to work around the issue. Something like "if the file is not found, and the current

[clang-tools-extra] 35edd70 - Temporarily revert "build: use `find_package(Python3)` if available"

Author: Eric Christopher Date: 2020-04-28T16:41:22-07:00 New Revision: 35edd704e0fda09e8e634515c0b451d4a8b6b914 URL: https://github.com/llvm/llvm-project/commit/35edd704e0fda09e8e634515c0b451d4a8b6b914 DIFF:

[clang] 35edd70 - Temporarily revert "build: use `find_package(Python3)` if available"

Author: Eric Christopher Date: 2020-04-28T16:41:22-07:00 New Revision: 35edd704e0fda09e8e634515c0b451d4a8b6b914 URL: https://github.com/llvm/llvm-project/commit/35edd704e0fda09e8e634515c0b451d4a8b6b914 DIFF:

[PATCH] D77168: Add a flag to debug automatic variable initialization

jcai19 marked an inline comment as done. jcai19 added a comment. > - Allows bracketing as John suggested (lower / upper bounds where to stop / > start). I have made some updates to this patch based on the comments here. One question I have though is whether we should have another option for

[PATCH] D78777: [AST] Use PrintingPolicy for format string diagnosis

This revision was automatically updated to reflect the committed changes. Closed by commit rG5fee6936b8b2: [AST] Use PrintingPolicy for format string diagnosis (authored by jrtc27). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78777/new/

[PATCH] D77168: Add a flag to debug automatic variable initialization

jcai19 updated this revision to Diff 260788. jcai19 added a comment. Update baesd on comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77168/new/ https://reviews.llvm.org/D77168 Files: clang/include/clang/Basic/LangOptions.def

Re: [PATCH] D78501: Add a facility to get system cache directory and use it in clangd

On Wed, Apr 29, 2020 at 12:52 AM Eric Christopher wrote: > I've had to temporarily revert this as it was breaking some tests: > > .../sources/llvm-project/llvm/unittests/Support/Path.cpp:334:5: error: > use of undeclared identifier 'set' > set(Value); > ^ > 1 error

[clang-tools-extra] 4e769e9 - Reland "Add a facility to get system cache directory and use it in clangd"

Author: Sam McCall Date: 2020-04-29T00:56:36+02:00 New Revision: 4e769e93b90b4d83ee795cda51bea9f76ca5ad5b URL: https://github.com/llvm/llvm-project/commit/4e769e93b90b4d83ee795cda51bea9f76ca5ad5b DIFF: https://github.com/llvm/llvm-project/commit/4e769e93b90b4d83ee795cda51bea9f76ca5ad5b.diff

Re: [PATCH] D78501: Add a facility to get system cache directory and use it in clangd

I've had to temporarily revert this as it was breaking some tests: .../sources/llvm-project/llvm/unittests/Support/Path.cpp:334:5: error: use of undeclared identifier 'set' set(Value); ^ 1 error generated. Happy to help diagnose this with you if you need some assistance.

[clang-tools-extra] faf2dce - Temporarily revert "Add a facility to get system cache directory and use it in clangd"

Author: Eric Christopher Date: 2020-04-28T15:49:46-07:00 New Revision: faf2dce1dd6ae25aa75d2685ac7bb27ec31e2ced URL: https://github.com/llvm/llvm-project/commit/faf2dce1dd6ae25aa75d2685ac7bb27ec31e2ced DIFF:

[clang] 5fee693 - [AST] Use PrintingPolicy for format string diagnosis

Author: Jessica Clarke Date: 2020-04-28T23:43:48+01:00 New Revision: 5fee6936b8b241b36fadaf0dcd962e9c9adc8a69 URL: https://github.com/llvm/llvm-project/commit/5fee6936b8b241b36fadaf0dcd962e9c9adc8a69 DIFF:

[PATCH] D75936: Add a Pass to X86 that builds a Condensed CFG for Load Value Injection (LVI) Gadgets [4/6]

craig.topper added inline comments. Comment at: llvm/lib/Target/X86/X86LoadValueInjectionLoadHardening.cpp:322 + DenseSet> GadgetEdgeSet; + auto AnalyzeUse = [&](NodeAddr Use, MachineInstr *MI) { +assert(!(Use.Addr->getFlags() & NodeAttrs::PhiRef)); mattdr

[PATCH] D78501: Add a facility to get system cache directory and use it in clangd

VojtechStep added a comment. Great, thanks for the fixes! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78501/new/ https://reviews.llvm.org/D78501 ___ cfe-commits mailing list

[PATCH] D78659: Add nomerge function attribute to supress tail merge optimization in simplifyCFG

zequanwu updated this revision to Diff 260780. zequanwu added a comment. Add test case for preventing hoisting. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78659/new/ https://reviews.llvm.org/D78659 Files: llvm/docs/LangRef.rst llvm/include/llvm/Bitcode/LLVMBitCodes.h

[clang] 68b30bc - [NFC] Correct spelling of "ambiguous"

Author: Casey Carter Date: 2020-04-28T14:51:37-07:00 New Revision: 68b30bc02b3a7e84d03f43a82cc08e5df76a28dd URL: https://github.com/llvm/llvm-project/commit/68b30bc02b3a7e84d03f43a82cc08e5df76a28dd DIFF: https://github.com/llvm/llvm-project/commit/68b30bc02b3a7e84d03f43a82cc08e5df76a28dd.diff

[PATCH] D78501: Add a facility to get system cache directory and use it in clangd

This revision was automatically updated to reflect the committed changes. Closed by commit rGad38f4b371bd: Add a facility to get system cache directory and use it in clangd (authored by VojtechStep, committed by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79033: [NFC][clang] Replace raw new/delete with unique_ptr to store ABIInfo in TargetCodeGenInfo

hubert.reinterpretcast added a comment. Funny that it's the front-end code that this patch makes more C++11 after so many years. LGTM; thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79033/new/ https://reviews.llvm.org/D79033 ___

[PATCH] D78501: Add a facility to get system cache directory and use it in clangd

sammccall added a comment. Sorry about the delay, ran into some problems with the tests and decided to simplify them a little by extracting the helper. Also I think the subdirectory inside $XDG_CACHE_HOME isn't supposed to be hidden, so .clangd->clangd which meant a little refactoring. Thanks

[PATCH] D78862: [IR] Convert null-pointer-is-valid into an enum attribute

manojgupta added a comment. @nikic Thanks for the work. In D78862#2003684 , @arsenm wrote: > FWIW I think this attribute should be replaced with a data layout property, > so this would eventually be removed @arsenm Is there any work planned on moving

[PATCH] D78501: Add a facility to get system cache directory and use it in clangd

sammccall updated this revision to Diff 260768. sammccall added a comment. Use $cache/clangd/index, not $cache/.clangd/index Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78501/new/ https://reviews.llvm.org/D78501 Files:

[PATCH] D79044: [AIX] Avoid structor alias; die before bad alias codegen

hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: cebowleratibm, jasonliu, sfertile, daltenty, DiggerLin. Herald added subscribers: kbarton, hiraditya, nemanjai. Herald added projects: clang, LLVM. hubert.reinterpretcast edited the summary of this revision.

[PATCH] D79033: [NFC][clang] Replace raw new/delete with unique_ptr to store ABIInfo in TargetCodeGenInfo

jasonliu updated this revision to Diff 260766. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79033/new/ https://reviews.llvm.org/D79033 Files: clang/lib/CodeGen/TargetInfo.cpp clang/lib/CodeGen/TargetInfo.h Index: clang/lib/CodeGen/TargetInfo.h

[clang-tools-extra] ad38f4b - Add a facility to get system cache directory and use it in clangd

Author: Vojtěch Štěpančík Date: 2020-04-28T23:18:31+02:00 New Revision: ad38f4b371bdca214e3a3cda9a76ec2213215c68 URL: https://github.com/llvm/llvm-project/commit/ad38f4b371bdca214e3a3cda9a76ec2213215c68 DIFF:

[PATCH] D79039: [SveEmitter] Add builtins for svmov_b and svnot_b.

sdesmalen created this revision. sdesmalen added reviewers: SjoerdMeijer, efriedma, ctetreau. Herald added a subscriber: tschuett. Herald added a reviewer: rengolin. These are custom expanded in CGBuiltin: svmov_b_z(pg, op) <=> svand_b_z(pg, op, op) svnot_b_z(pg, op) <=> sveor_b_z(pg, op,

[PATCH] D79039: [SveEmitter] Add builtins for svmov_b and svnot_b.

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79039/new/ https://reviews.llvm.org/D79039 ___ cfe-commits mailing list

[PATCH] D78501: Add a facility to get system cache directory and use it in clangd

sammccall updated this revision to Diff 260757. sammccall added a comment. Fix(?) test compile for windows, split out windows/unix tests for simplicity. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78501/new/ https://reviews.llvm.org/D78501

[PATCH] D78659: Add nomerge function attribute to supress tail merge optimization in simplifyCFG

zequanwu added a comment. > Does sinking and hoisting remove the debug source location? I assumed that it > wouldn't, but now after all the smooth stepping work, maybe it does. Yes, both sinking and hoisting in simplifycfg remove the debug source location by `Instruction::applyMergedLocation`

[PATCH] D78129: Add Marvell ThunderX3T110 support

wxz2020 marked an inline comment as done. wxz2020 added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.td:849-857 +// These pointer authentication instructions require armv8.3a +let Predicates = [HasV8_3a, HasPA] in { let Uses = [LR], Defs = [LR] in {

[PATCH] D78760: Check a class has a definition before iterating over its base classes

rsmith added a comment. In D78760#2005874 , @ahatanak wrote: > `TagDecl::isDependentType()` is returning true. Oh, sorry, we do already do the thing I was suggesting. But in your testcase the issue is that the base class `B0` is dependent but is also

[PATCH] D79033: [NFC][clang] Replace raw new/delete with unique_ptr to store ABIInfo in TargetCodeGenInfo

jasonliu updated this revision to Diff 260746. jasonliu added a comment. Provide default virtual destructor. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79033/new/ https://reviews.llvm.org/D79033 Files: clang/lib/CodeGen/TargetInfo.cpp clang/lib/CodeGen/TargetInfo.h Index:

[PATCH] D79009: [AST] Preserve the incomplete-type member expr.

hokein abandoned this revision. hokein marked an inline comment as done. hokein added inline comments. Comment at: clang/test/AST/ast-dump-recovery.cpp:107 +struct Incomplete; +Incomplete make_incomplete(); sammccall wrote: > This test doesn't seem to relate

[PATCH] D79035: [clang][AIX] Implement ABIInfo and TargetCodeGenInfo for AIX

jasonliu created this revision. jasonliu added reviewers: Xiangling_L, sfertile, hubert.reinterpretcast, cebowleratibm, ZarkoCA. Herald added subscribers: kbarton, nemanjai. Herald added a project: clang. Created AIXABIInfo and AIXTargetCodeGenInfo for AIX ABI. Some investigation and FAQ on why

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

asmith added a comment. In D78982#2007172 , @MyDeveloperDay wrote: > - This needs unit tests in clang/unittests/Format to demonstrate the problem > and test this fixing it Is there an easy way to check the test is working? 'ninja check-clang-format'

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

asmith marked 5 inline comments as done. asmith added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1767 if (FormatTok->Tok.getKind() == ClosingBraceKind) { + if (!Style.AllowEnumsOnASingleLine) +addUnwrappedLine(); This

[PATCH] D78501: Add a facility to get system cache directory and use it in clangd

VojtechStep added a comment. Herald added a project: LLVM. Ping @sammccall, could you commit the changes? Thanks  CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78501/new/ https://reviews.llvm.org/D78501 ___ cfe-commits mailing list

[PATCH] D79033: [NFC][clang] Replace raw new/delete with unique_ptr to store ABIInfo in TargetCodeGenInfo

hubert.reinterpretcast added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.h:51 - TargetCodeGenInfo(ABIInfo *info = nullptr) : Info(info) {} - virtual ~TargetCodeGenInfo(); I'm not sure removing a virtual destructor is a good idea. The use of

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

asmith updated this revision to Diff 260732. asmith added a comment. Rename option Add test case Only apply to Microsoft CPP style CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78982/new/ https://reviews.llvm.org/D78982 Files: clang/include/clang/Format/Format.h

[PATCH] D79033: [NFC][clang] Replace raw new/delete with unique_ptr to store ABIInfo in TargetCodeGenInfo

jasonliu created this revision. jasonliu added reviewers: hubert.reinterpretcast, sfertile, nemanjai, Xiangling_L. Herald added subscribers: s.egerton, simoncook, fedor.sergeev, aheejin, dschuff. Herald added a project: clang. Use unique_ptr to manage the lifetime of ABIInfo member inside

[PATCH] D65543: [Windows] Autolink with basenames and add libdir to libpath

This revision was automatically updated to reflect the committed changes. Closed by commit rGb8000c0ce845: [Windows] Autolink with basenames and add libdir to libpath (authored by rnk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65543/new/

[PATCH] D78958: [SVE] Update EmitSVEPredicateCast to take a ScalableVectorType

This revision was automatically updated to reflect the committed changes. Closed by commit rGef3678cfeea6: [SVE] Update EmitSVEPredicateCast to take a ScalableVectorType (authored by ctetreau). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] b8000c0 - [Windows] Autolink with basenames and add libdir to libpath

Author: Reid Kleckner Date: 2020-04-28T11:36:21-07:00 New Revision: b8000c0ce84541c5b5535419234fb65ce77d6756 URL: https://github.com/llvm/llvm-project/commit/b8000c0ce84541c5b5535419234fb65ce77d6756 DIFF: https://github.com/llvm/llvm-project/commit/b8000c0ce84541c5b5535419234fb65ce77d6756.diff

[clang] ef3678c - [SVE] Update EmitSVEPredicateCast to take a ScalableVectorType

Author: Christopher Tetreault Date: 2020-04-28T11:22:20-07:00 New Revision: ef3678cfeea69a882bd58df42b6d21a0860703fd URL: https://github.com/llvm/llvm-project/commit/ef3678cfeea69a882bd58df42b6d21a0860703fd DIFF:

[PATCH] D78904: [clang-tidy] extend bugprone-signed-char-misuse check with array subscript case.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some minor nits. Comment at: clang-tools-extra/clang-tidy/bugprone/SignedCharMisuseCheck.cpp:106 + + // Catch array subscripts with singed

[PATCH] D79009: [AST] Preserve the incomplete-type member expr.

sammccall added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:7223 + RequireCompleteType(OpLoc, BaseType, diag::err_incomplete_member_access)) { +if (Base->containsErrors()) + return Base; Sorry, I don't get what's going on here at

[PATCH] D78890: [clang-tidy] Add check callee-namespace.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some minor nits. Comment at: clang-tools-extra/clang-tidy/llvmlibc/CalleeNamespaceCheck.cpp:52-53 + + diag(FuncDecl->getLocation(), +

[PATCH] D79020: [clang-format] Correct the AfterControlStatement configuration option output style

duncan-llvm added a comment. Based on the New Contributors section I understand I should be asking someone to commit this (and D79022 ) on my behalf. @MyDeveloperDay would you be able to do that for

[PATCH] D78853: [Analysis] Fix null pointer dereference warnings [1/n]

aaronpuchert added a comment. Could you explain why we are doing this? Clang has its own static analyzer , which can find null dereferences as well but also tracks constraints

[PATCH] D78885: [clangd] Fix remote index build without shared libs mode

This revision was automatically updated to reflect the committed changes. Closed by commit rG9ff3f339e881: [clangd] Fix remote index build without shared libs mode (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78885/new/

[PATCH] D78812: [SVE][CodeGen] Fix legalisation for scalable types

kmclaughlin marked an inline comment as done. kmclaughlin added inline comments. Comment at: llvm/lib/CodeGen/TargetLoweringBase.cpp:1429 + !isTypeLegal(EVT::getVectorVT(Context, EltTy, EltCnt))) { +EltCnt.Min >>= 1; NumVectorRegs <<= 1; I will

[PATCH] D79022: [clang-format] Fix a bug causing BeforeLambdaBody to affect brace initialiser formatting

Wawha accepted this revision. Wawha added a comment. Thanks for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79022/new/ https://reviews.llvm.org/D79022 ___ cfe-commits mailing list

[PATCH] D79022: [clang-format] Fix a bug causing BeforeLambdaBody to affect brace initialiser formatting

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79022/new/ https://reviews.llvm.org/D79022

[PATCH] D79020: [clang-format] Correct the AfterControlStatement configuration option output style

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. This LGTM, yeah not sure about how this can be tested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79020/new/

[PATCH] D78118: [analyzer] StdLibraryFunctionsChecker: Add option to display loaded summaries

martong added a comment. > This is a great idea, but the tests just seem to, well, test the new > functionality? I updated the patch so now we have a new RUN line that checks with FileCheck. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78118: [analyzer] StdLibraryFunctionsChecker: Add option to display loaded summaries

martong added a comment. In D78118#2007943 , @martong wrote: > In D78118#1988464 , @balazske wrote: > > > The new option will simply list the (found) functions that have a summary > > based check enabled. (The

[PATCH] D78118: [analyzer] StdLibraryFunctionsChecker: Add option to display loaded summaries

martong updated this revision to Diff 260687. martong added a comment. - Handle and test the display of signatures Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78118/new/ https://reviews.llvm.org/D78118 Files:

[PATCH] D78979: OpenCL: Include builtin header by default

arsenm added a comment. In D78979#2007356 , @Anastasia wrote: > > I'm somewhat confused by the way this is supposed to work, or why a > > separate option exists for OpenCL. The other language flags seem to be > > implemented in the driver, not cc1 like

[clang-tools-extra] 9ff3f33 - [clangd] Fix remote index build without shared libs mode

Author: Kirill Bobyrev Date: 2020-04-28T19:16:37+02:00 New Revision: 9ff3f339e881b65217272cb11714493d0e5f1c70 URL: https://github.com/llvm/llvm-project/commit/9ff3f339e881b65217272cb11714493d0e5f1c70 DIFF:

[PATCH] D79012: [AST] Fix a crash on a dependent vector_size attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rG2bb686b4b629: [AST] Fix a crash on a dependent vector_size attribute (authored by erik.pilkington). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78129: Add Marvell ThunderX3T110 support

wxz2020 updated this revision to Diff 260680. wxz2020 added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Remove non-official target options. We now only support -mcpu=thunderx3t110 Typo fix. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78129/new/

[PATCH] D79022: [clang-format] Fix a bug causing BeforeLambdaBody to affect brace initialiser formatting

duncan-llvm created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. duncan-llvm added reviewers: MyDeveloperDay, Wawha. duncan-llvm added a project: clang-format. The condition added with the new setting checked whether the character was an l-brace, not

[PATCH] D79012: [AST] Fix a crash on a dependent vector_size attribute

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79012/new/ https://reviews.llvm.org/D79012 ___ cfe-commits mailing list

[PATCH] D79020: [clang-format] Correct the AfterControlStatement configuration option output style

duncan-llvm created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. duncan-llvm edited the summary of this revision. duncan-llvm added a reviewer: MyDeveloperDay. duncan-llvm added a project: clang-format. Due to the order in which the enum cases were defined

[PATCH] D79000: [clang-format] C# property formatting can be controlled by config options

jbcoe added a comment. Reverted this commit. Will pick this up tomorrow. Apologies for the noise! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79000/new/ https://reviews.llvm.org/D79000 ___

[clang] 2bb686b - [AST] Fix a crash on a dependent vector_size attribute

Author: Erik Pilkington Date: 2020-04-28T12:54:49-04:00 New Revision: 2bb686b4b629e3565dab239fd53b49f3a882d856 URL: https://github.com/llvm/llvm-project/commit/2bb686b4b629e3565dab239fd53b49f3a882d856 DIFF:

[clang] 095ccf4 - [SystemZ] Avoid __INTPTR_TYPE__ conversions in vecintrin.h

Author: Ulrich Weigand Date: 2020-04-28T18:49:49+02:00 New Revision: 095ccf4455654750cd4c0296ff91565c2b613319 URL: https://github.com/llvm/llvm-project/commit/095ccf4455654750cd4c0296ff91565c2b613319 DIFF:

[clang] 85ee97f - Revert "[clang-format] C# property formatting can be controlled by config options"

Author: Jonathan Coe Date: 2020-04-28T17:41:17+01:00 New Revision: 85ee97fd894b2d0432dfaf20347e73f3e154ae97 URL: https://github.com/llvm/llvm-project/commit/85ee97fd894b2d0432dfaf20347e73f3e154ae97 DIFF: https://github.com/llvm/llvm-project/commit/85ee97fd894b2d0432dfaf20347e73f3e154ae97.diff

[PATCH] D79000: [clang-format] C# property formatting can be controlled by config options

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG015bca3e67cb: [clang-format] C# property formatting can be controlled by config options (authored by Jonathan Coe

  1   2   3   >