[PATCH] D80079: [clang-format] [NFC] isCpp() is inconsistently used to mean both C++ and Objective C, add language specific isXXX() functions

sammccall added inline comments. Comment at: clang/include/clang/Format/Format.h:1632 + bool isCppOnly() const { return Language == LK_Cpp; } + bool isObjectiveC() const { return Language == LK_ObjC; } + bool isCpp() const { return isCppOnly() || isObjectiveC(); }

[PATCH] D79961: [PGO] Fix computation of fuction Hash

serge-sans-paille updated this revision to Diff 264552. serge-sans-paille edited the summary of this revision. serge-sans-paille added a comment. Updated summary + removed namespace. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79961/new/ https://

[PATCH] D79862: [clangd-remote] Replace YAML serialization with proper Protobuf messages

kbobyrev updated this revision to Diff 264553. kbobyrev added a comment. Don't complicate SymbolCollectorTest, use TestTU. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79862/new/ https://reviews.llvm.org/D79862 Files: clang-tools-extra/clangd/i

[PATCH] D79862: [clangd-remote] Replace YAML serialization with proper Protobuf messages

kbobyrev updated this revision to Diff 264554. kbobyrev added a comment. Inline HeaderCode and MainCode. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79862/new/ https://reviews.llvm.org/D79862 Files: clang-tools-extra/clangd/index/remote/Client

[PATCH] D80109: [AST][RecoveryExpr] Preserve type for broken member call expr.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D80109 Files: clang/lib/Sema/SemaOverload.cpp clang/test/AST/ast-dump-recovery.cpp Index: clang/test/AST/ast-dump-recovery.cpp

[PATCH] D79961: [PGO] Fix computation of fuction Hash

hans added a comment. Nice fix, and nice test :-) May I ask how you found this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79961/new/ https://reviews.llvm.org/D79961 ___ cfe-commits mailing list cf

[PATCH] D79704: [Analyzer] [NFC] Parameter Regions

baloghadamsoftware marked an inline comment as done. baloghadamsoftware added a comment. In D79704#2040798 , @NoQ wrote: > > It turns out that parameter regions are never created for functions without > > `Decl` because of the first lines in > > `CallEve

[PATCH] D79325: [clang-format] [PR42164] Add Option to Break before While

krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79325/new/ https://reviews.llvm.org/D79325 ___ cfe-commits mailing list cfe

[PATCH] D80079: [clang-format] [NFC] isCpp() is inconsistently used to mean both C++ and Objective C, add language specific isXXX() functions

MyDeveloperDay added a comment. - I personally find the current form (Style.Language == LK_XXX) very verbose and difficult to read, especially when its in the middle of a large clause. - Its clear to me that isCpp() is not understood, its name doesn't quite suggest what it does and as such there

[PATCH] D80109: [AST][RecoveryExpr] Preserve type for broken member call expr.

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:14105 case OR_No_Viable_Function: CandidateSet.NoteCandidates( It is a bit sad that the broken function call cases (too many/few aggum

[PATCH] D79950: [clangd] Avoid wasteful data structures in RefSlab::Builder

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. LGTM with a couple of nits. Thank you for the patch, this is a good idea! Comment at: clang-tools-extra/clangd/index/Ref.cpp:11 +#include "llvm/ADT/STLExtras.h" +#includ

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

stuij updated this revision to Diff 264560. stuij added a comment. addressing review comments and adding Simon Tatham to contributers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76077/new/ https://reviews.llvm.org/D76077 Files: clang/include/c

[PATCH] D80079: [clang-format] [NFC] isCpp() is inconsistently used to mean both C++ and Objective C, add language specific isXXX() functions

MyDeveloperDay marked 2 inline comments as done. MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3443 - Style.Language == FormatStyle::LK_TextProto) { + } else if (Style.isCpp() || Style.isProtoBuf() || Style.isTableGen() || +

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

stuij updated this revision to Diff 264562. stuij added a comment. redo: addressing review comments and adding Simon Tatham to contributers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76077/new/ https://reviews.llvm.org/D76077 Files: clang/doc

[clang-tools-extra] 4f0cc10 - [NFC][clang-tidy] use hasOperands in place of hasEitherOperand

Author: Nathan James Date: 2020-05-18T10:11:22+01:00 New Revision: 4f0cc10bf5d0009a9d00565fedb34933c2adf8f6 URL: https://github.com/llvm/llvm-project/commit/4f0cc10bf5d0009a9d00565fedb34933c2adf8f6 DIFF: https://github.com/llvm/llvm-project/commit/4f0cc10bf5d0009a9d00565fedb34933c2adf8f6.diff

[PATCH] D80025: [ASTMatcher] Correct memoization bug ignoring direction (descendants or ancestors)

njames93 added a comment. This needs rebasing against trunk Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80025/new/ https://reviews.llvm.org/D80025 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D79992: [WIP][clangd] Patch PP directives to use stale preambles while building ASTs

kadircet updated this revision to Diff 264567. kadircet added a comment. - Only store defines - Make use of source text directly instead of printing tokens Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79992/new/ https://reviews.llvm.org/D79992 Fi

[PATCH] D80025: [ASTMatcher] Correct memoization bug ignoring direction (descendants or ancestors)

klimek added inline comments. Comment at: clang/lib/ASTMatchers/ASTMatchFinder.cpp:46-49 +enum class MatchDirection { + Ancestors, + Descendants +}; Nice find! Why don't we need more states though? 1. wouldn't hasParent() followed by a hasAncestor() also trigge

[clang-tools-extra] 968d293 - [clang-tidy] NFC: Cleanup Python scripts

Author: Kirill Bobyrev Date: 2020-05-18T12:21:27+02:00 New Revision: 968d293063bc008ff93ff8fcf363039ce61574a2 URL: https://github.com/llvm/llvm-project/commit/968d293063bc008ff93ff8fcf363039ce61574a2 DIFF: https://github.com/llvm/llvm-project/commit/968d293063bc008ff93ff8fcf363039ce61574a2.diff

[PATCH] D76793: [Matrix] Implement + and - operators for MatrixType.

fhahn added a comment. ping :) this patch should be ready to be reviewed independently (it's marked as dependent on D76791 in Phab, but it can be applied independently and changing the relationship in Phab will trigger a bunch of unnecessary emails) Reposito

[PATCH] D80115: [clang-format] [PR45816] Add AlignConsecutiveBitFields

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: krasimir, mitchell-stellar, JakeMerdichAMD, curdeius, owenpan. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay updated this revision to Diff 264575. MyDeveloperDay added a comment. MyDeveloperDay edited the su

[PATCH] D79330: [Analyzer][VLASizeChecker] Check for VLA size overflow.

balazske updated this revision to Diff 264572. balazske added a comment. Rebase, added checker name to overflow test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79330/new/ https://reviews.llvm.org/D79330 Files: clang/lib/StaticAnalyzer/Checke

[PATCH] D78985: [clang-tidy] NFC: Cleanup Python scripts

This revision was automatically updated to reflect the committed changes. Closed by commit rG968d293063bc: [clang-tidy] NFC: Cleanup Python scripts (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78985/new/ https://reviews.llvm

[PATCH] D80115: [clang-format] [PR45816] Add AlignConsecutiveBitFields

MyDeveloperDay updated this revision to Diff 264575. MyDeveloperDay added a comment. clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80115/new/ https://reviews.llvm.org/D80115 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/ReleaseNotes.rst clang/include/clang

[clang] a6a237f - [OpenCL] Added addrspace_cast operator in C++ mode.

Author: Anastasia Stulova Date: 2020-05-18T12:07:54+01:00 New Revision: a6a237f2046ad8993db30481c8b61aeb2f73a5ad URL: https://github.com/llvm/llvm-project/commit/a6a237f2046ad8993db30481c8b61aeb2f73a5ad DIFF: https://github.com/llvm/llvm-project/commit/a6a237f2046ad8993db30481c8b61aeb2f73a5ad.d

[PATCH] D60193: [OpenCL] Added addrspace_cast operator

This revision was automatically updated to reflect the committed changes. Closed by commit rGa6a237f2046a: [OpenCL] Added addrspace_cast operator in C++ mode. (authored by Anastasia). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D60193?vs=263085&id=264581#toc

[PATCH] D80016: [analyzer] StdLibraryFunctionsChecker: Add support to lookup types

balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:747 + : *FilePtrTy) +: None; + The `Optional` can be left out from the right side expressions (in the `?` operat

[clang] 87b235d - Turn -Wmax-tokens off by default

Author: Hans Wennborg Date: 2020-05-18T13:21:46+02:00 New Revision: 87b235db63a3d8d5b82d60ef6202b92b94a7d9d2 URL: https://github.com/llvm/llvm-project/commit/87b235db63a3d8d5b82d60ef6202b92b94a7d9d2 DIFF: https://github.com/llvm/llvm-project/commit/87b235db63a3d8d5b82d60ef6202b92b94a7d9d2.diff

[PATCH] D80117: [analyzer] Introduce reasoning about symbolic remainder operator

vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin, xazax.hun, ASDenysPetrov. Herald added subscribers: cfe-commits, martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. Herald added a project: clang. New log

[PATCH] D78442: Create a warning flag for 'warn_conv_*_not_used'

rdwampler added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78442/new/ https://reviews.llvm.org/D78442 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D79711: [ARM][BFloat] Add poly64_t on AArch32.

stuij updated this revision to Diff 264586. stuij added a comment. adhere to attribution conventions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79711/new/ https://reviews.llvm.org/D79711 Files: clang/include/clang/Basic/TargetBuiltins.h cla

[PATCH] D79708: [clang][BFloat] add NEON emitter for bfloat

stuij updated this revision to Diff 264587. stuij added a comment. adhere to patch attribution conventions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79708/new/ https://reviews.llvm.org/D79708 Files: clang/include/clang/Basic/arm_bf16.td cl

[PATCH] D79710: [clang][BFloat] add create/set/get/dup intrinsics

stuij updated this revision to Diff 264588. stuij added a comment. adhere to patch attribution conventions: change author to Ties, add all the contributors Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79710/new/ https://reviews.llvm.org/D79710 F

[PATCH] D80014: Turn -Wmax-tokens off by default

This revision was automatically updated to reflect the committed changes. Closed by commit rG87b235db63a3: Turn -Wmax-tokens off by default (authored by hans). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80014/new/ https://reviews.llvm.org/D80014

[PATCH] D79869: [clang][BFloat] Add reinterpret cast intrinsics

stuij updated this revision to Diff 264590. stuij added a comment. adhere to attribution conventions: change author to Ties, add all the contributors Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79869/new/ https://reviews.llvm.org/D79869 Files:

[PATCH] D78508: [Clang] Allow long as size_t printf argument on 32-bit Windows platforms.

hans added a comment. Doing special handling for SIZE_T, as opposed to long in general, on Windows as Richard suggests seems reasonable to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78508/new/ https://reviews.llvm.org/D78508

[PATCH] D79710: [clang][BFloat] add create/set/get/dup intrinsics

LukeGeeson added a comment. Can you update the commit message in this differential as well please? Same for the other commits :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79710/new/ https://reviews.llvm.org/D79710 __

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MarcusJohnson91 added a comment. In D75791#2040665 , @MyDeveloperDay wrote: > > Something is not quite right here, this text isn't ending up in the > ClangFormatStyleOptions.rst You're right, I didn't catch that before, turns out having a comment be

[PATCH] D79961: [PGO] Fix computation of fuction Hash

serge-sans-paille added a comment. > May I ask how you found this? This was a long (and painful) quest when tracking https://bugzilla.redhat.com/show_bug.cgi?id=1827282 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79961/new/ https://reviews.ll

[PATCH] D78508: [Clang] Allow long as size_t printf argument on 32-bit Windows platforms.

aaron.ballman added a comment. In D78508#2041432 , @hans wrote: > Doing special handling for SIZE_T, as opposed to long in general, on Windows > as Richard suggests seems reasonable to me. I would be fine with this so long as it doesn't allow `%zu` to m

[PATCH] D80009: [Analyzer][StreamChecker] Changed representation of stream error state - NFC.

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. LGTM! Amazing job! Sorry for this dragging out for so long, but I'm very happy with how this patch and the overall direction turned out. I've left an annoying nit, and as always, feel fr

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MarcusJohnson91 updated this revision to Diff 264597. MarcusJohnson91 added a comment. Fixed the generation of ReleaseNotes.rst CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75791/new/ https://reviews.llvm.org/D75791 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/ReleaseN

[PATCH] D72705: [analyzer] Added new checker 'alpha.unix.ErrorReturn'.

martong added a comment. In D72705#2036066 , @balazske wrote: > It is a way of find some of the cases with the mentioned way of tracking what > operations are allowed after what operations with or without error check, on > a specific stream. Instead of a

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

SjoerdMeijer added inline comments. Comment at: clang/docs/LanguageExtensions.rst:518 +Clang supports three half-precision (16-bit) floating point types: ``__fp16``, +``_Float16`` and ``__bf16``. These types are supported in all language modes. stuij wrote: >

[PATCH] D80117: [analyzer] Introduce reasoning about symbolic remainder operator

vsavchenko added a comment. Here is a proof in Z3: https://gist.github.com/SavchenkoValeriy/559ca923b050f2c01e340c1be543b7e0 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80117/new/ https://reviews.llvm.org/D80117 ___

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:3434-3435 + if (Stack->getDefaultDSA() == DSA_firstprivate && + VD->getStorageDuration() == SD_Static && + CanonicalVD->getDeclContext()->isFileContext() && !Stack->isLoopCo

[PATCH] D79704: [Analyzer] [NFC] Parameter Regions

baloghadamsoftware updated this revision to Diff 264598. baloghadamsoftware added a comment. Unit test updated to cover all cases. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79704/new/ https://reviews.llvm.org/D79704 Files: clang/include/clang/StaticAnalyzer/Checkers/SValExplainer

[PATCH] D79704: [Analyzer] [NFC] Parameter Regions

baloghadamsoftware added a comment. In D79704#2040798 , @NoQ wrote: > > It turns out that parameter regions are never created for functions without > > `Decl` because of the first lines in > > `CallEvent::getCalleeAnalysisDeclContext()`. > > Removing the

[PATCH] D79434: [analyzer] Generalize bitwise AND rules for ranges

vsavchenko updated this revision to Diff 264603. vsavchenko added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79434/new/ https://reviews.llvm.org/D79434 Files: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp clang/

[PATCH] D79336: [analyzer] Generalize bitwise OR rules for ranges

vsavchenko updated this revision to Diff 264602. vsavchenko added a comment. Fix a bug with double expressions withing integer expressions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79336/new/ https://reviews.llvm.org/D79336 Files: clang/incl

[PATCH] D79434: [analyzer] Generalize bitwise AND rules for ranges

vsavchenko updated this revision to Diff 264606. vsavchenko added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79434/new/ https://reviews.llvm.org/D79434 Files: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp clang/

[PATCH] D80015: [Analyzer][StreamChecker] Added support for 'fread' and 'fwrite'.

Szelethus added a comment. I think the warning about EOF could be a separate patch, and it could be implemented for most stream operations. The patch in large looks great, but I'm just not sure why we handle fwrite so differently. Could you please explain? Comment at: clang/l

[PATCH] D80117: [analyzer] Introduce reasoning about symbolic remainder operator

vsavchenko updated this revision to Diff 264605. vsavchenko added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80117/new/ https://reviews.llvm.org/D80117 Files: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp clang/

[clang] 22d40cc - [Analyzer][StreamChecker] Changed representation of stream error state - NFC.

Author: Balázs Kéri Date: 2020-05-18T16:18:59+02:00 New Revision: 22d40cc3a724fa3df259c52009571a21a3a3a632 URL: https://github.com/llvm/llvm-project/commit/22d40cc3a724fa3df259c52009571a21a3a3a632 DIFF: https://github.com/llvm/llvm-project/commit/22d40cc3a724fa3df259c52009571a21a3a3a632.diff L

[PATCH] D79232: [analyzer] Refactor range inference for symbolic expressions

vsavchenko updated this revision to Diff 264614. vsavchenko added a comment. Fix a problem with doubles sneaking into integer symbolic expressions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79232/new/ https://reviews.llvm.org/D79232 Files: c

[PATCH] D79336: [analyzer] Generalize bitwise OR rules for ranges

vsavchenko updated this revision to Diff 264615. vsavchenko added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79336/new/ https://reviews.llvm.org/D79336 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/BasicValueF

[PATCH] D80115: [clang-format] [PR45816] Add AlignConsecutiveBitFields

JakeMerdichAMD added a comment. Ironically, I independently made a near-identical change because my codebase needs this, and was going to upload it today. I won't post it now, but I stuck a copy on github if you're interested: https://github.com/JakeMerdichAMD/llvm-project/commit/6eec9ce0bb7732

[PATCH] D79967: Fix debug info for NoDebug attr

yaxunl marked 4 inline comments as done. yaxunl added a comment. In D79967#2039153 , @dblaikie wrote: > Could you check the commit history for this feature and rope in some folks > who added the function declaration work (it's for debug call sites) - mayb

[PATCH] D80009: [Analyzer][StreamChecker] Changed representation of stream error state - NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rG22d40cc3a724: [Analyzer][StreamChecker] Changed representation of stream error state - NFC. (authored by balazske). Changed prior to commit: https://reviews.llvm.org/D80009?vs=264230&id=264618#toc Repo

[PATCH] D79905: [clang-format] [PR44476] Add space between template and attribute

JakeMerdichAMD accepted this revision. JakeMerdichAMD added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79905/new/ https://reviews.llvm.org/D79905 ___ cfe-commits mailing li

[PATCH] D80115: [clang-format] [PR45816] Add AlignConsecutiveBitFields

MyDeveloperDay planned changes to this revision. MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: clang/lib/Format/WhitespaceManager.cpp:588-590 +return C.Tok->Previous->startsSequence(tok::identifier, tok::colon, +

[PATCH] D79967: Fix debug info for NoDebug attr

yaxunl updated this revision to Diff 264622. yaxunl marked 2 inline comments as done. yaxunl added a comment. Fix the tests and move the logic to CGDebugInfo::EmitFuncDeclForCallSite to make it clearer. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79967/new/ https://reviews.llvm.org/D

[PATCH] D80015: [Analyzer][StreamChecker] Added support for 'fread' and 'fwrite'.

balazske marked 4 inline comments as done. balazske added a comment. The difference of fread and fwrite comes from the fact that `fwrite` can always succeed, `fread` does not succeed in EOF state. The plan is to add the file functions sequentially. From the currently implemented functions only `

[PATCH] D79322: [FEnv] Small fixes to implementation of flt.rounds

sepavloff updated this revision to Diff 264623. sepavloff added a comment. Updated patch Default lowering of FLT_ROUNDS_ again is made by replacing the node with constant 1, which denotes rounding to nearest, ties to even. It is incorrect, but is compatible with with current behavior. Using more

[PATCH] D80115: [clang-format] [PR45816] Add AlignConsecutiveBitFields

MyDeveloperDay added a comment. How about we combine the two revisions CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80115/new/ https://reviews.llvm.org/D80115 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D79322: [FEnv] Small fixes to implementation of flt.rounds

sepavloff marked an inline comment as done. sepavloff added inline comments. Comment at: llvm/test/CodeGen/RISCV/flt-rounds.ll:23 +; RV64I-NEXT:sd ra, 8(sp) +; RV64I-NEXT:call __flt_rounds +; RV64I-NEXT:ld ra, 8(sp) craig.topper wrote: > sepavloff wro

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MyDeveloperDay added a comment. I've added you to https://reviews.llvm.org/project/view/78/ Comment at: clang/include/clang/Format/Format.h:1555 + IndentExternBlockStyle IndentExternBlock; + /// A vector of prefixes ordered by the desired groups for Java imports. --

[clang] 1907f28 - [Analyzer][StreamChecker] Fixed compile error - NFC.

Author: Balázs Kéri Date: 2020-05-18T17:14:39+02:00 New Revision: 1907f28b47cfe9c951df43309d121679895b0edf URL: https://github.com/llvm/llvm-project/commit/1907f28b47cfe9c951df43309d121679895b0edf DIFF: https://github.com/llvm/llvm-project/commit/1907f28b47cfe9c951df43309d121679895b0edf.diff L

[PATCH] D80115: [clang-format] [PR45816] Add AlignConsecutiveBitFields

JakeMerdichAMD added a comment. Good idea, feel free to incorporate anything about the change (eg, tests and TT_BitFieldColon) or delegate to me if you like. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80115/new/ https://reviews.llvm.org/D80115

[PATCH] D80126: Add educational note records to the .dia format and expose them via libclang

owenv created this revision. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. An educational note is attached to a diagnostic and is essentially just a path to associated documentation somewhere in a compiler toolchain. The documentation can then be displayed alongsi

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MyDeveloperDay added a comment. Sorry forgot to submit the comment issue, seems like you worked that bit out already CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75791/new/ https://reviews.llvm.org/D75791 ___ cfe-commits mailing list cfe-

[PATCH] D80009: [Analyzer][StreamChecker] Changed representation of stream error state - NFC.

balazske added a comment. There was a problem showing up in the buildbots, it should be fixed now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80009/new/ https://reviews.llvm.org/D80009 ___ cfe-commi

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

stuij marked an inline comment as done. stuij added inline comments. Comment at: clang/docs/LanguageExtensions.rst:518 +Clang supports three half-precision (16-bit) floating point types: ``__fp16``, +``_Float16`` and ``__bf16``. These types are supported in all language modes.

[PATCH] D80117: [analyzer] Introduce reasoning about symbolic remainder operator

vsavchenko added a comment. Here is a short summary of the performance testing I conducted across a bunch of open-source projects: | | vim | git | tmux| redis

[PATCH] D79862: [clangd-remote] Replace YAML serialization with proper Protobuf messages

kbobyrev updated this revision to Diff 264633. kbobyrev added a comment. Rebase on top of master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79862/new/ https://reviews.llvm.org/D79862 Files: clang-tools-extra/clangd/index/remote/Client.cpp

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MyDeveloperDay added a comment. > if thats true how didn't the automated tests catch it? If you are not in the premerge testing group the unit tests won't be run. (which is why I added you) When I run the gtest it fails, I cannot see why.. but one suggestion I have is to drop the whole true/fa

[PATCH] D79754: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 1

sameerds added inline comments. Comment at: clang/lib/AST/Decl.cpp:3226 + // the only special cases that are supported by device-side runtime. + if (Context.getTargetInfo().getTriple().isAMDGCN() && + Context.getLangOpts().OpenMPIsDevice && Why is the chec

[PATCH] D72705: [analyzer] Added new checker 'alpha.unix.ErrorReturn'.

balazske marked an inline comment as done. balazske added a comment. I can make comparisons if more functions are added to the checker, `fputs` only is not sufficient. Comment at: clang/lib/StaticAnalyzer/Checkers/ErrorReturnChecker.cpp:221 +/// and the visitor is called on a

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MyDeveloperDay added a comment. ok it crashes because you are not initializing IndentExternBlock in the getLLVMStyle() function LLVMStyle.IndentExternBlock = FormatStyle::IEBS_NoIndent; You cannot leave it uninitialized, now what the correct value is in my view may be an issue CHANGES SINCE

[PATCH] D80117: [analyzer] Introduce reasoning about symbolic remainder operator

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:459 +bool CoversTheWholeType = +(Origin.From().isMinSignedValue() || Origin.To().isMaxValue()); + `(Origin.From() + 1).isMinSignedValue()` is another suffi

[PATCH] D78938: Fixing all comparisons for C++20 compilation.

jfb accepted this revision. jfb added a comment. This revision is now accepted and ready to land. This seems fine, assuming you've run usual tests? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78938/new/ https://reviews.llvm.org/D78938

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MyDeveloperDay added a comment. I think it needs to be: `LLVMStyle.IndentExternBlock = FormatStyle::IEBS_NoIndent;` I'm wondering if the GNU style also needs `Expanded.IndentExternBlock = FormatStyle::IEBS_Indent;` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75791/new/ https://revi

[PATCH] D79895: Add a new warning to warn when passing uninitialized variables as const reference parameters to a function

aeubanks added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2110 +def warn_uninit_const_reference : Warning< + "variable %0 is uninitialized when passes as a const reference parameter " + "here">, InGroup, DefaultIgnore; s/passe

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

SjoerdMeijer added inline comments. Comment at: clang/docs/LanguageExtensions.rst:518 +Clang supports three half-precision (16-bit) floating point types: ``__fp16``, +``_Float16`` and ``__bf16``. These types are supported in all language modes. stuij wrote: >

[PATCH] D80117: [analyzer] Introduce reasoning about symbolic remainder operator

vsavchenko marked 2 inline comments as done. vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:459 +bool CoversTheWholeType = +(Origin.From().isMinSignedValue() || Origin.To().isMaxValue()); + NoQ w

[PATCH] D80115: [clang-format] [PR45816] Add AlignConsecutiveBitFields

MyDeveloperDay added a comment. How about I abandon and we use yours (but would you please consider changing the name to be AlignConsecutiveBitFields ) (capital F) as that was in the orignal request CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80115/new/ https://reviews.llvm.org/D80

[PATCH] D80117: [analyzer] Introduce reasoning about symbolic remainder operator

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:462 +if (CoversTheWholeType) { + return {ValueFactory.getMinValue(RangeType), + ValueFactory.getMaxValue(RangeType)}; vsavchenko wrote: > NoQ wro

[PATCH] D80015: [Analyzer][StreamChecker] Added support for 'fread' and 'fwrite'.

Szelethus added a comment. In D80015#2041653 , @balazske wrote: > The difference of fread and fwrite comes from the fact that `fwrite` can > always succeed, `fread` does not succeed in EOF state. > The plan is to add the file functions sequentially. From

[PATCH] D80015: [Analyzer][StreamChecker] Added support for 'fread' and 'fwrite'.

Szelethus added a comment. But just to assure you, this patch is practically perfect. I don't think we're going to have any hiccups moving forward with this. Again, thank you for all the patience! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8001

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

SjoerdMeijer added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8111 "pointer cannot be cast to type %0">; +def err_cast_to_bfloat : Error<"cannot type-cast to __bf16">; +def err_cast_from_bfloat : Error<"cannot type-cast from __bf16">; ---

[PATCH] D80117: [analyzer] Introduce reasoning about symbolic remainder operator

vsavchenko marked an inline comment as done. vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:462 +if (CoversTheWholeType) { + return {ValueFactory.getMinValue(RangeType), + ValueFactory.getMaxValue(Range

[PATCH] D80117: [analyzer] Introduce reasoning about symbolic remainder operator

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:459 +bool CoversTheWholeType = +(Origin.From().isMinSignedValue() || Origin.To().isMaxValue()); + vsavchenko wrote: > NoQ wrote: > > `(Origin.From() + 1).i

[PATCH] D79992: [WIP][clangd] Patch PP directives to use stale preambles while building ASTs

kadircet updated this revision to Diff 264666. kadircet added a comment. - MacroInfo's definition range is a token range, convert it to a char range. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79992/new/ https://reviews.llvm.org/D79992 Files:

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

SjoerdMeijer added a comment. There are Sema and CodeGen tests, but was wondering if there would be some value in having an AST test too? There are some other types that do have AST tests. Comment at: clang/lib/AST/ASTContext.cpp:2052 + Width = Target->getBFloat16Width()

[PATCH] D80109: [AST][RecoveryExpr] Preserve type for broken member call expr.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaOverload.cpp:14083 OverloadCandidateSet::iterator Best; +bool Succeeded = true; switch (CandidateSet.BestViableFunction

[PATCH] D68049: Propeller: Clang options for basic block sections

tmsriram added a comment. Ping. Comment at: clang/include/clang/Basic/CodeGenOptions.h:114-127 + // -fbasic-block-sections=. The allowed values with this option are: + // {"labels", "all", "", "none"}. + // + // "labels": Only generate basic block symbols (labels) for

[PATCH] D80041: [clang-format] [PR45198] deletes whitespace inside of a noexcept specifier

JakeMerdichAMD added a comment. I mainly have concerns with the search for noexcept being too brittle and not looking far enough back. Implementing that may have performance implications though, so I have no issue ignoring that problem if it's proven sufficiently rare. Also: should this do the

[PATCH] D79704: [Analyzer] [NFC] Parameter Regions

martong added a comment. Wow, this is some nice work and huge effort from all the participants, it was pretty informative to read through. Thanks @baloghadamsoftware and @NoQ for working on this! > This means that we always found a Decl. However, this Decl is not stored but > retrieved always

[PATCH] D80144: [clang-format] @lefticus just taught the world how to use [[unlikely]] but we forgot to teach clang-format

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: krasimir, mitchell-stellar, JakeMerdichAMD, curdeius, lefticus. MyDeveloperDay added projects: clang, clang-format. https://twitter.com/lefticus/status/1262392152950288384?s=20 Jason Turner's (@lefticus) most recent C++ weekly

[PATCH] D68049: Propeller: Clang options for basic block sections

rsmith added a comment. Clang side LG with some minor changes. Comment at: clang/docs/ClangCommandLineReference.rst:1336 + +Generate labels for each basic block or place each basic block or a subset of basic blocks in its own section + This file is automatical

  1   2   >